Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

2017-02-03 Thread Andrew Lunn
> This is especially nice because we may change the base-board and use > there another PHY and as long we have drivers for all possible PHY built > in the kernel (or available via modules) proper driver will be instantiated > based on PHY ID read from MDIO. I.e. having no PHY node in DT adds >

[PATCH net-next 3/8] pci: add Annapurna Labs PCI id

2017-02-03 Thread Antoine Tenart
Adds the Annapurna Labs vendor id. Signed-off-by: Antoine Tenart --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 73dda0edcb97..8a11e2d8f35f 100644 ---

[PATCH net-next 7/8] net: ethernet: annapurna: add eee helpers to the Alpine driver

2017-02-03 Thread Antoine Tenart
Add the get_eee() and set_eee() helpers to support the Energy-Efficient (EEE) feature in the Annapurna Labs Alpine driver. --- drivers/net/ethernet/annapurna/al_eth.c| 44 +++ drivers/net/ethernet/annapurna/al_hw_eth.h | 28 +++

[PATCH net-next 2/8] soc: alpine: add udma helpers

2017-02-03 Thread Antoine Tenart
One or more DMA controllers (called Universal DMA) are exposed as PCI endpoints for some units connected to the I/O fabric. The DMA controller registers are mapped in BARs. These helpers help drivers supporting units connected to the Alpine I/O fabric, to configure and use the exposed UDMA. The

[PATCH net-next 8/8] net: ethernet: annapurna: add the coalesce helpers to the Alpine driver

2017-02-03 Thread Antoine Tenart
Add the get_coalesce() and set_coalesce() helpers to the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 81 + 1 file changed, 81 insertions(+) diff --git a/drivers/net/ethernet/annapurna/al_eth.c

[PATCH net-next 1/8] alpine: add I/O fabric interrupt controller (iofic) helpers

2017-02-03 Thread Antoine Tenart
All units connected to the I/O fabric share a common interrupt controller interface, with the same architecture. This means there are multiple interrupt controllers exposed, one per unit connected to the I/O fabric, with the exact same interface. One particularity of the Alpine platform is that

[PATCH net-next 6/8] net: ethernet: annapurna: add wol helpers to the Alpine driver

2017-02-03 Thread Antoine Tenart
Implement the get_wol() and set_wol() helpers in the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/net/ethernet/annapurna/al_eth.c

[PATCH net-next 5/8] net: ethernet: annapurna: add statistics helper

2017-02-03 Thread Antoine Tenart
Add the ndo_get_stats64() helper in the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 36 drivers/net/ethernet/annapurna/al_hw_eth.h | 9 + drivers/net/ethernet/annapurna/al_hw_eth_main.c | 225 3 files changed,

[PATCH V3 0/2] Add QLogic FastLinQ FCoE (qedf) driver

2017-02-03 Thread Dupuis, Chad
From: "Dupuis, Chad" Dave, please apply the qed patch to net-next at your earliest convenience. Martin, the qed patch needs to be applied first as the qedf patch is dependent on the FCoE bits in the first qed driver patch. This series introduces the hardware offload FCoE

[PATCH V3 net-next 1/2] qed: Add support for hardware offloaded FCoE.

2017-02-03 Thread Dupuis, Chad
From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

Re: [patch net-next] MAINTAINERS: add Ivan as a switchdev maintainer

2017-02-03 Thread David Miller
From: Jiri Pirko Date: Thu, 2 Feb 2017 17:05:04 +0100 > From: Jiri Pirko > > Ivan will be taking care of switchdev code from now on. > > Signed-off-by: Jiri Pirko Applied.

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-02-03 Thread Andy Lutomirski
On Mon, Jan 23, 2017 at 12:20 PM, Andy Lutomirski wrote: > On Sun, Jan 22, 2017 at 8:31 PM, Alexei Starovoitov > wrote: >> On Thu, Jan 19, 2017 at 08:04:59PM -0800, Andy Lutomirski wrote: >>> restricting the types of sockets that can be created,

[PATCH v2 0/2] net: ethernet: bgmac: bug fixes

2017-02-03 Thread Jon Mason
Changes in v2: * Reworked the first match to make it more obvious what portions of the register were being preserved (Per Rafal Mileki) * Style change to reorder the function variables in patch 2 (per Sergei Shtylyov) Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac

Re: [PATCH net-next] be2net: get rid of custom busy poll code

2017-02-03 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Feb 2017 10:16:00 -0800 > From: Eric Dumazet > > Compared to custom busy_poll, the generic NAPI one is better, since > it allows to use GRO, and it removes a lot of code and extra locked > operations in fast path. >

Re: [PATCH net-next] bpf: test for AND edge cases

2017-02-03 Thread Josef Bacik
On Fri, 2017-02-03 at 16:03 -0500, David Miller wrote: > From: Josef Bacik > Date: Thu, 2 Feb 2017 12:00:38 -0500 > > > > > These two tests are based on the work done for f23cc643f9ba.  The > > first test is > > just a basic one to make sure we don't allow AND'ing negative > >

Re: [PATCH net-next] ixgbe: get rid of custom busy polling code

2017-02-03 Thread David Miller
Intel folks please review these two patches, as I need to apply them in order to add Eric's final patch which removes the busy polling NDO op altogether. http://patchwork.ozlabs.org/patch/723356/ Thank you.

Re: [PATCH net-next] tcp: clear pfmemalloc on outgoing skb

2017-02-03 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Feb 2017 20:40:08 -0800 > From: Eric Dumazet > > Josef Bacik diagnosed following problem : > >I was seeing random disconnects while testing NBD over loopback. >This turned out to be because NBD sets

Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152

2017-02-03 Thread Guenter Roeck
On Tue, Jan 31, 2017 at 02:53:47PM -0500, Alan Stern wrote: > On Tue, 31 Jan 2017, Guenter Roeck wrote: > > > When unloading the r8152 driver using the 'unbind' sysfs attribute > > in a system with KASAN enabled, the following error message is seen > > on a regular basis. > > ... > > > The

Re: [PATCH net-next] ixgbevf: get rid of custom busy polling code

2017-02-03 Thread Alexander Duyck
On Thu, Feb 2, 2017 at 4:59 PM, Eric Dumazet wrote: > From: Eric Dumazet > > In linux-4.5, busy polling was implemented in core > NAPI stack, meaning that all custom implementation can > be removed from drivers. > > Not only we remove lot's of code,

Re: [PATCH net-next] myri10ge: get rid of custom busy poll code

2017-02-03 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Feb 2017 10:50:48 -0800 > From: Eric Dumazet > > Compared to custom busy_poll, the generic NAPI one is simpler and > removes a lot of code. It removes one atomic in the fast path (when > busy poll is not in action)

Re: [PATCH net] net: use a work queue to defer net_disable_timestamp() work

2017-02-03 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Feb 2017 10:31:35 -0800 > From: Eric Dumazet > > Dmitry reported a warning [1] showing that we were calling > net_disable_timestamp() -> static_key_slow_dec() from a non > process context. > > Grabbing a mutex

[PATCH net-next][v2] bpf: test for AND edge cases

2017-02-03 Thread Josef Bacik
These two tests are based on the work done for f23cc643f9ba. The first test is just a basic one to make sure we don't allow AND'ing negative values, even if it would result in a valid index for the array. The second is a cleaned up version of the original testcase provided by Jann Horn that

Re: [PATCH 1/1] bonding: Remove unnecessary returned value check

2017-02-03 Thread David Miller
From: Zhu Yanjun Date: Thu, 2 Feb 2017 23:46:21 -0500 > The function bond_info_query alwarys returns 0. As such, in the function > bond_do_ioctl, it is not necessary to check the returned value. So the > interface type of the function bond_info_query is changed to void.

[PULL] vhost: cleanups and fixes

2017-02-03 Thread Michael S. Tsirkin
The following changes since commit 566cf877a1fcb6d6dc0126b076aad062054c2637: Linux 4.10-rc6 (2017-01-29 14:25:17 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH net-next] ixgbe: get rid of custom busy polling code

2017-02-03 Thread Alexander Duyck
On Thu, Feb 2, 2017 at 4:26 PM, Eric Dumazet wrote: > From: Eric Dumazet > > In linux-4.5, busy polling was implemented in core > NAPI stack, meaning that all custom implementation can > be removed from drivers. > > Not only we remove lot's of code,

Re: [PATCH net-next] trace: rename trace_print_hex_seq arg and add kdoc

2017-02-03 Thread David Miller
From: Daniel Borkmann Date: Thu, 2 Feb 2017 17:09:54 +0100 > Steven suggested to improve trace_print_hex_seq() a bit after commit > 2acae0d5b0f7 ("trace: add variant without spacing in trace_print_hex_seq") > in two ways: i) by adding a kdoc comment for the helper function

Re: [PATCH net-next] bpf: test for AND edge cases

2017-02-03 Thread David Miller
From: Josef Bacik Date: Thu, 2 Feb 2017 12:00:38 -0500 > These two tests are based on the work done for f23cc643f9ba. The first test > is > just a basic one to make sure we don't allow AND'ing negative values, even if > it > would result in a valid index for the array. The

Re: [PATCH net-next 5/8] net: ethernet: annapurna: add statistics helper

2017-02-03 Thread kbuild test robot
Hi Antoine, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Antoine-Tenart/ARM-Alpine-Ethernet-support/20170204-022156 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:

Re: [next-net 00/19][pull request] Intel Wired LAN Driver Updates 2017-02-02

2017-02-03 Thread David Miller
Pretty sloppy submission Jeff. First of all, things are getting backlogged way too much. 19 patches is too large, you need to keep it closer down to 10 and the very very low teens. You need to send me pull requests more often so that this does not happen. Second of all, all of your Subjects

Re: [RFC PATCH 0/2] mac80211: use crypto shash for AES cmac

2017-02-03 Thread Malinen, Jouni
On Fri, Feb 03, 2017 at 07:25:53PM +, Ard Biesheuvel wrote: > The mac80211 aes_cmac code reimplements the CMAC algorithm based on the > core AES cipher, which is rather restrictive in how platforms can satisfy > the dependency on this algorithm. For instance, SIMD implementations may > have a

Re: [PATCH net-next 5/8] net: ethernet: annapurna: add statistics helper

2017-02-03 Thread Florian Fainelli
On 02/03/2017 10:12 AM, Antoine Tenart wrote: > Add the ndo_get_stats64() helper in the Annapurna Labs Alpine Ethernet > driver. > --- > drivers/net/ethernet/annapurna/al_eth.c | 36 > drivers/net/ethernet/annapurna/al_hw_eth.h | 9 + >

Re: [PATCH v2] PCI: lock each enable/disable num_vfs operation in sysfs

2017-02-03 Thread Bjorn Helgaas
On Fri, Jan 06, 2017 at 01:59:08PM -0800, Emil Tantilov wrote: > Enabling/disabling SRIOV via sysfs by echo-ing multiple values > simultaneously: > > echo 63 > /sys/class/net/ethX/device/sriov_numvfs& > echo 63 > /sys/class/net/ethX/device/sriov_numvfs > > sleep 5 > > echo 0 >

Re: [PATCH] net: stmmac: don't set tx delay in RGMII_ID and RGMII_TXID mode

2017-02-03 Thread Martin Blumenstingl
On Wed, Feb 1, 2017 at 8:19 PM, Heiner Kallweit wrote: > As documented in Documentation/devicetree/bindings/net/ethernet.txt, > in RGMII_ID and RGMII_TXID mode the MAC should not add a tx delay. > > Signed-off-by: Heiner Kallweit Acked-by: Martin

Re: [PATCH net-next] net: ipv6: Set protocol to kernel for local routes

2017-02-03 Thread David Miller
From: David Ahern Date: Thu, 2 Feb 2017 08:52:21 -0800 > IPv6 stack does not set the protocol for local routes, so those routes show > up with proto "none": > $ ip -6 ro ls table local > local ::1 dev lo proto none metric 0 pref medium > local 2100:3:: dev

Re: [PATCH net-next] cxgb4: get rid of custom busy poll code

2017-02-03 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Feb 2017 11:44:27 -0800 > From: Eric Dumazet > > In linux-4.5, busy polling was implemented in core > NAPI stack, meaning that all custom implementation can > be removed from drivers. > > Not only we remove lot of

[PATCH net-next 0/3] net: ethernet: bgmac: PM support and clean-ups

2017-02-03 Thread Jon Mason
Add code to support Power Management (only tested on NS2), and add some code clean-ups Joey Zhong (1): net: ethernet: bgmac: driver power manangement Jon Mason (2): net: ethernet: bgmac: use #defines for MAX size net: ethernet: bgmac: unify code of the same family

Re: Understanding mutual exclusion between rtnl_lock and rcu_read_lock

2017-02-03 Thread Cong Wang
On Thu, Feb 2, 2017 at 6:05 PM, Joel Cunningham wrote: > > In the case of SIOCSIFHWADDR, we get a pointer to the net_device through > __dev_get_by_name() and then pass it to dev_set_mac_address() to modify > through ndo_set_mac_address(). I didn’t see any uses of RCU

[PATCH 1/3] net: ethernet: bgmac: use #defines for MAX size

2017-02-03 Thread Jon Mason
The maximum frame size is really just the standard ethernet frame size and FCS. So use those existing defines to make the code a little more beautiful. Signed-off-by: Jon Mason --- drivers/net/ethernet/broadcom/bgmac.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/3] net: ethernet: bgmac: driver power manangement

2017-02-03 Thread Jon Mason
From: Joey Zhong Implements suspend/resume, external phy 54810 is assumed to remain powered up during deep-sleep for wake-on-lane. Signed-off-by: Joey Zhong Signed-off-by: Jon Mason ---

[PATCH 2/3] net: ethernet: bgmac: unify code of the same family

2017-02-03 Thread Jon Mason
BCM471X and BCM535X are of the same family (from what I can derive from internal documents). Group them into the case statement together, which results in more code reuse. Also, use existing helper variables to make the code a little more readable too. Signed-off-by: Jon Mason

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-03 Thread David Miller
From: Roopa Prabhu Date: Tue, 31 Jan 2017 22:59:50 -0800 > lwt and dst_metadata have enabled vxlan l3 deployments > to use a single vxlan netdev for multiple vnis eliminating the scalability > problem with using a single vxlan netdev per vni. This series tries to > do

Re: [PATCH net-next] virtio: Fix affinity for >32 VCPUs

2017-02-03 Thread Willem de Bruijn
On Fri, Feb 3, 2017 at 1:34 PM, Rick Jones wrote: > On 02/03/2017 10:31 AM, Willem de Bruijn wrote: >> >> Configuring interrupts and xps from userspace at boot is more robust, >> as device driver defaults can change. But especially for customers who >> are unaware of these

Re: [PATCH net] bpf: expose netns inode to bpf programs

2017-02-03 Thread Andy Lutomirski
On Thu, Feb 2, 2017 at 8:33 PM, Eric W. Biederman wrote: > Alexei Starovoitov writes: > >> On 1/26/17 11:07 AM, Andy Lutomirski wrote: >>> On Thu, Jan 26, 2017 at 10:32 AM, Alexei Starovoitov wrote: On 1/26/17 10:12 AM, Andy Lutomirski

[PATCH v2 1/2] net: ethernet: bgmac: init sequence bug

2017-02-03 Thread Jon Mason
From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason

[PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

2017-02-03 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason

Re: [RFC PATCH net-next 1/2] bpf: Save original ebpf instructions

2017-02-03 Thread Daniel Borkmann
On 02/03/2017 09:38 PM, David Ahern wrote: Similar to classic bpf, support saving original ebpf instructions Signed-off-by: David Ahern Not convinced that this is in the right direction, this not only *significantly* increases mem footprint for each and every

Re: [PATCH net-next v2 00/12] bnxt_en: Add XDP support.

2017-02-03 Thread Michael Chan
On Fri, Feb 3, 2017 at 12:49 PM, David Miller wrote: > > Please _DO NOT_ guard XDP support with an ifdef the user > can modify. > > Treat it like any other common netdev feature a driver might > support such as checksum offloading or GRO. > David, I want to make sure I

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Shannon Nelson
On 2/3/2017 9:56 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx

Re: [PATCH v2 net-next] bpf: enable verifier to add 0 to packet ptr

2017-02-03 Thread Daniel Borkmann
[ please keep us Cc'ed ;) ] On 02/03/2017 06:22 PM, William Tu wrote: The patch fixes the case when adding a zero value to the packet pointer. The verifer reports the following error: [...] R0=imm0,min_value=0,max_value=0 R1=pkt(id=0,off=0,r=4) R2=pkt_end R3=fp-12

[RFC PATCH net-next 2/2] bpf: Add support to retrieve program attached to a cgroup

2017-02-03 Thread David Ahern
Add support to ebpf to retrieve a program attached to a cgroup. This is done using a new bpf_cmd, BPF_PROG_GET_ATTACH, and associated struct in bpf_attr. This allows a program to verify a bpf filter attached to a cgroup as well as verify the lack of a filter - which can be just as relevant when

[RFC PATCH net-next 0/2] bpf: Allow retrieval of ebpf filters

2017-02-03 Thread David Ahern
As mentioned at netconf in October, insight into bpf filters is an essential part of debugging and verifying a particular networking configuration. For example, classic bpf filters can be returned for packet sockets as part of the sock_diag infrastructure and the PACKET_DIAG_FILTER attribute. This

[RFC PATCH net-next 1/2] bpf: Save original ebpf instructions

2017-02-03 Thread David Ahern
Similar to classic bpf, support saving original ebpf instructions Signed-off-by: David Ahern --- include/linux/filter.h | 5 - kernel/bpf/syscall.c | 36 2 files changed, 40 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next v2 00/12] bnxt_en: Add XDP support.

2017-02-03 Thread David Miller
Please _DO NOT_ guard XDP support with an ifdef the user can modify. Treat it like any other common netdev feature a driver might support such as checksum offloading or GRO. Thanks.

Re: [PATCH v2 net-next] bpf: enable verifier to add 0 to packet ptr

2017-02-03 Thread Alexei Starovoitov
On Fri, Feb 03, 2017 at 09:22:45AM -0800, William Tu wrote: > The patch fixes the case when adding a zero value to the packet > pointer. The verifer reports the following error: > [...] > R0=imm0,min_value=0,max_value=0 > R1=pkt(id=0,off=0,r=4) > R2=pkt_end R3=fp-12 >

Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-03 Thread Shannon Nelson
On 2/3/2017 9:59 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: The ldmvsw driver is specifically for supporting the ldom virtual networking by running in the primary ldom and using the LDC to connect the remaining ldoms to the outside world via a bridge. With

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-02-03 Thread Andrew Lunn
> +/* MDIO */ > +#define AL_ETH_MDIO_C45_DEV_MASK 0x1f > +#define AL_ETH_MDIO_C45_DEV_SHIFT16 > +#define AL_ETH_MDIO_C45_REG_MASK 0x > + > +static int al_mdio_read(struct mii_bus *bp, int mii_id, int reg) > +{ > + struct al_eth_adapter *adapter = bp->priv; > + u16 value

Re: [PATCH] dt-bindings: net: remove reference to fixed link support

2017-02-03 Thread David Miller
From: Thomas Petazzoni Date: Thu, 2 Feb 2017 17:47:44 +0100 > Contrary to what the Device Tree binding indicates, the binding for the > PPv2 network device currently doesn't provide any fixed link > functionality. This commit adjusts the Device Tree binding

Re: [PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-02-03 Thread Florian Fainelli
On 02/03/2017 01:54 AM, Russell King - ARM Linux wrote: > On Thu, Feb 02, 2017 at 09:54:07PM -0500, David Miller wrote: >> Hot plugging PHYs and notifications and all of that business is >> net-next material. > > I was talking more about unbinding of the driver, which is something > that can be

Re: [PATCH net] bpf: expose netns inode to bpf programs

2017-02-03 Thread Eric W. Biederman
Andy Lutomirski writes: > On Thu, Feb 2, 2017 at 8:33 PM, Eric W. Biederman > wrote: >> Alexei Starovoitov writes: >> >>> On 1/26/17 11:07 AM, Andy Lutomirski wrote: On Thu, Jan 26, 2017 at 10:32 AM, Alexei Starovoitov

Re: [PATCH v2 net-next] bpf: enable verifier to add 0 to packet ptr

2017-02-03 Thread William Tu
Hi Alexei, why it is bogus? on my system, it fails without the patch applied. --William On Fri, Feb 3, 2017 at 12:55 PM, Alexei Starovoitov wrote: > On Fri, Feb 03, 2017 at 09:22:45AM -0800, William Tu wrote: >> The patch fixes the case when adding a zero value to

[RFC] igmp: address pmc kmemleak from on igmpv3_del_delrec()

2017-02-03 Thread Luis R. Rodriguez
When we igmpv3_add_delrec() we kzalloc the pmc, but when users calligmpv3_del_delrec() we never free the pmc. This was caught by the following kmemleak splat: unreferenced object 0x99666ff43b40 (size 192): comm "systemd-resolve", pid 1258, jiffies 4309905600 (age 2138.352s) hex dump

[PATCH net-next 3/9] sunvnet: update version and version printing

2017-02-03 Thread Shannon Nelson
There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet.c |

[PATCH net-next 8/9] ldmvsw: update and simplify version string

2017-02-03 Thread Shannon Nelson
New version and simplify the print code. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c

[PATCH net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-03 Thread Shannon Nelson
Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c | 63 +

Re: [patch net-next 00/19] mlxsw: Introduce TC Flower offload using TCAM

2017-02-03 Thread Jiri Pirko
Fri, Feb 03, 2017 at 06:57:25PM CET, f.faine...@gmail.com wrote: >On 02/02/2017 10:58 PM, Jiri Pirko wrote: >> Thu, Feb 02, 2017 at 10:40:42PM CET, f.faine...@gmail.com wrote: >>> On 02/02/2017 07:12 AM, Jiri Pirko wrote: From: Jiri Pirko This patchset introduces

Re: [PATCH net-next] virtio: Fix affinity for >32 VCPUs

2017-02-03 Thread Benjamin Serebrin
Thanks, Michael, I'll put this text in the commit log: XPS settings aren't write-able from userspace, so the only way I know to fix XPS is in the driver. The interrupt affinity settings could be set by irqbalancer, yes, but it's not always enabled (by intention) in all guests. I just confirmed

[PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-03 Thread Vivien Didelot
A slave device will now notify the switch fabric once its port is bridged or unbridged, instead of calling directly its switch operations. This code allows propagating cross-chip bridging events in the fabric. Signed-off-by: Vivien Didelot ---

[PATCH net-next 1/6] net: dsa: move netdevice notifier registration

2017-02-03 Thread Vivien Didelot
Move the netdevice notifier block register code in slave.c and provide helpers for dsa.c to register and unregister it. At the same time, check for errors since (un)register_netdevice_notifier may fail. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c |

[PATCH net-next 3/6] net: dsa: rollback bridging on error

2017-02-03 Thread Vivien Didelot
When an error is returned during the bridging of a port in a NETDEV_CHANGEUPPER event, net/core/dev.c rolls back the operation. Be consistent and unassign dp->bridge_dev when this happens. In the meantime, add comments to document this behavior. Signed-off-by: Vivien Didelot

Re: [PATCH RFC net-next 4/4] bridge: add ability to turn off fdb used updates

2017-02-03 Thread Stephen Hemminger
On Fri, 3 Feb 2017 09:30:37 +0100 Nikolay Aleksandrov wrote: > On 03/02/17 03:47, David Miller wrote: > > From: Nikolay Aleksandrov > > Date: Tue, 31 Jan 2017 16:31:58 +0100 > > > >> @@ -197,7 +197,8 @@ int

Re: [PATCH net-next] virtio: Fix affinity for >32 VCPUs

2017-02-03 Thread Willem de Bruijn
> XPS settings aren't write-able from userspace, so the only way I know > to fix XPS is in the driver. It is writable by privileged users. >> I wonder why not just do it in userspace though. Configuring interrupts and xps from userspace at boot is more robust, as device driver defaults can

Re: Regarding DSA architecture in linux

2017-02-03 Thread Florian Fainelli
On 02/03/2017 02:11 AM, thathi reddy wrote: > Hi, > > Sorry for disturb, i got work related DSA in Linux, > I am new to this stuff, Can you please share Documents, if you have. There is documentation in the kernel sources here:

Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

2017-02-03 Thread Alexey Brodkin
Hi Andrew, On Fri, 2017-02-03 at 18:10 +0100, Andrew Lunn wrote: > On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote: > > > > Current implemntation returns ENODEV if device tree node for > > phy is absent. But in reality there're many boards with the one > > and only PHY on board

Re: [PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-03 Thread Eric Dumazet
On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: > The ldmvsw driver is specifically for supporting the ldom virtual > networking by running in the primary ldom and using the LDC to connect > the remaining ldoms to the outside world via a bridge. With TSO and GSO > supported while

[RFC PATCH 0/2] mac80211: use crypto shash for AES cmac

2017-02-03 Thread Ard Biesheuvel
This is something I spotted while working on AES in various modes for ARM and arm64. The mac80211 aes_cmac code reimplements the CMAC algorithm based on the core AES cipher, which is rather restrictive in how platforms can satisfy the dependency on this algorithm. For instance, SIMD

[RFC PATCH 2/2] mac80211: aes-cmac: switch to shash CMAC driver

2017-02-03 Thread Ard Biesheuvel
Instead of open coding the CMAC algorithm in the mac80211 driver using byte wide xors and calls into the crypto layer for each block of data, instantiate a cmac(aes) synchronous hash and pass all the data into it directly. This does not only simplify the code, it also allows the use of more

[PATCH v2 net-next] bpf: enable verifier to add 0 to packet ptr

2017-02-03 Thread William Tu
The patch fixes the case when adding a zero value to the packet pointer. The verifer reports the following error: [...] R0=imm0,min_value=0,max_value=0 R1=pkt(id=0,off=0,r=4) R2=pkt_end R3=fp-12 R4=imm4,min_value=4,max_value=4 R5=pkt(id=0,off=4,r=4) 269: (bf) r2 = r0

[PATCH net-next 0/8] ARM: Alpine: Ethernet support

2017-02-03 Thread Antoine Tenart
Hello all, This series intend to add Ethernet support for the Annapurna Labs Alpine v1 (ARM) and v2 (ARM64). The series first adds helpers for the I/O fabric interrupt controller that is found in many controllers on the Alpine, then helpers for the so called "Universal DMA" (UDMA) are also added

Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

2017-02-03 Thread Florian Fainelli
On 02/03/2017 09:30 AM, Alexey Brodkin wrote: > Hi Andrew, > > On Fri, 2017-02-03 at 18:10 +0100, Andrew Lunn wrote: >> On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote: >>> >>> Current implemntation returns ENODEV if device tree node for >>> phy is absent. But in reality there're

Re: [PATCH RFC net-next 4/4] bridge: add ability to turn off fdb used updates

2017-02-03 Thread Nikolay Aleksandrov
On 03/02/17 19:28, Stephen Hemminger wrote: > On Fri, 3 Feb 2017 09:30:37 +0100 > Nikolay Aleksandrov wrote: > >> On 03/02/17 03:47, David Miller wrote: >>> From: Nikolay Aleksandrov >>> Date: Tue, 31 Jan 2017 16:31:58 +0100 >>>

Re: [PATCH net-next] virtio: Fix affinity for >32 VCPUs

2017-02-03 Thread Rick Jones
On 02/03/2017 10:22 AM, Benjamin Serebrin wrote: Thanks, Michael, I'll put this text in the commit log: XPS settings aren't write-able from userspace, so the only way I know to fix XPS is in the driver. ?? root@np-cp1-c0-m1-mgmt:/home/stack# cat

Re: [PATCH net-next 7/8] net: ethernet: annapurna: add eee helpers to the Alpine driver

2017-02-03 Thread Florian Fainelli
On 02/03/2017 10:12 AM, Antoine Tenart wrote: > Add the get_eee() and set_eee() helpers to support the Energy-Efficient > (EEE) feature in the Annapurna Labs Alpine driver. Missing SoB. > --- > drivers/net/ethernet/annapurna/al_eth.c| 44 +++ >

[PATCH net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-03 Thread Shannon Nelson
When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables, since most of the real work is being done in the shared code. Also, this is simply dead code in

[PATCH net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-03 Thread Shannon Nelson
The ldmvsw driver is specifically for supporting the ldom virtual networking by running in the primary ldom and using the LDC to connect the remaining ldoms to the outside world via a bridge. With TSO and GSO supported while connected the bridge, things tend to misbehave as seen in our case by

[PATCH net-next 7/9] sunvnet: remove extra rcu_read_unlocks

2017-02-03 Thread Shannon Nelson
The RCU read lock is grabbed first thing in sunvnet_start_xmit_common() so it always needs to be released. This removes the conditional release in the dropped packet error path and removes a couple of superfluous calls in the middle of the code. Reported-by: Bijan Mottahedeh

[PATCH net-next 6/9] sunvnet: straighten up message event handling logic

2017-02-03 Thread Shannon Nelson
The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c | 94

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Eric Dumazet
On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: > In order to allow the underlying LDC and outstanding memory operations > to potentially catch up with the driver's Tx requests, add a memory > barrier before checking again for available tx descriptors. > > Signed-off-by: Shannon Nelson

Re: [patch net-next 00/19] mlxsw: Introduce TC Flower offload using TCAM

2017-02-03 Thread Florian Fainelli
On 02/02/2017 10:58 PM, Jiri Pirko wrote: > Thu, Feb 02, 2017 at 10:40:42PM CET, f.faine...@gmail.com wrote: >> On 02/02/2017 07:12 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> This patchset introduces support for offloading TC cls_flower and actions >>> to Spectrum

Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

2017-02-03 Thread Andrew Lunn
On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote: > Current implemntation returns ENODEV if device tree node for > phy is absent. But in reality there're many boards with the one > and only PHY on board and MACs that may find a PHY by querying > MDIO bus. One good example is STMMAC.

[PATCH net-next 0/9] sunvnet driver updates

2017-02-03 Thread Shannon Nelson
The sunvnet ldom virtual network driver was due for some updates and a bugfix or two. These patches address a few items left over from last year's make-over. Shannon Nelson (8): sunvnet: make sunvnet common code dynamically loadable sunvnet: update version and version printing sunvnet: add

[PATCH net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

2017-02-03 Thread Shannon Nelson
From: Sowmini Varadhan The vio_dring_state *dr variable is unused in maybe_tx_wakeup(). As the comments indicate, we call maybe_tx_wakeup() whenever we get a STOPPED LDC message on the port. If the queue is stopped, we want to wake it up so that we will send another

[PATCH net-next 5/6] net: dsa: add switch notifier

2017-02-03 Thread Vivien Didelot
Add a notifier block per DSA switch, registered against a notifier head in the switch fabric they belong to. This infrastructure will allow to propagate fabric-wide events such as port bridging, VLAN configuration, etc. If a DSA switch driver cares about cross-chip configuration, such events can

[PATCH net-next 2/6] net: dsa: simplify netdevice events handling

2017-02-03 Thread Vivien Didelot
Simplify the code handling the slave netdevice notifier call by providing a dsa_slave_changeupper helper for NETDEV_CHANGEUPPER, and so on (only this event is supported at the moment.) Return NOTIFY_DONE when we did not care about an event, and NOTIFY_OK when we were concerned but no error

[PATCH net-next 0/6] net: dsa: add fabric notifier

2017-02-03 Thread Vivien Didelot
When a switch fabric is composed of multiple switch chips, these chips must be programmed accordingly when an event occurred on one of them. Examples of such event include hardware bridging: when a Linux bridge spans interconnected chips, they must be programmed to allow external ports to ingress

[PATCH net-next 4/6] net: dsa: change state setter scope

2017-02-03 Thread Vivien Didelot
The scope of the functions inside net/dsa/slave.c must be the slave net_device pointer. Change to state setter helper accordingly to simplify callers. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 15 +-- 1 file changed, 9 insertions(+), 6

Re: [PATCH net-next 6/8] net: ethernet: annapurna: add wol helpers to the Alpine driver

2017-02-03 Thread Sergei Shtylyov
Hello! On 02/03/2017 09:12 PM, Antoine Tenart wrote: Implement the get_wol() and set_wol() helpers in the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 44 + 1 file changed, 44 insertions(+) diff --git

[RFC PATCH 1/2] mac80211: fils_aead: clone shared CMAC functions into private version

2017-02-03 Thread Ard Biesheuvel
Before reworking the AES CMAC mac80211 code, clone the routines that it shares with the FILS AEAD driver into its own source file, and remove the external declaration from aes_cmac.h. This will allow us to carry over one user at a time from the open coded CMAC code to the crypto API.

Re: [PATCH net-next] virtio: Fix affinity for >32 VCPUs

2017-02-03 Thread Rick Jones
On 02/03/2017 10:31 AM, Willem de Bruijn wrote: Configuring interrupts and xps from userspace at boot is more robust, as device driver defaults can change. But especially for customers who are unaware of these settings, choosing sane defaults won't hurt. The devil is in finding the sane

[PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson ---

Re: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat

2017-02-03 Thread Stephen Hemminger
On Thu, 26 Jan 2017 14:44:39 +0200 Nogah Frankel wrote: > Extended stats are part of the RTM_GETSTATS method. This patch adds them > to ifstat. > While extended stats can come in many forms, we support only the > rtnl_link_stats64 struct for them (which is the 64 bits

  1   2   3   >