Re: net: possible deadlock in skb_queue_tail

Andrey Konovalov wrote: [ CC Paolo ] > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit c470abd4fde40ea6a0846a2beab642a578c0b8cd (4.10). > > Unfortunately I can't reproduce it. This needs NETLINK_BROADCAST_ERROR enabled on a

Re: [PATCH] iproute2: hide devices starting with period by default

From: David Ahern Date: Thu, 23 Feb 2017 18:07:07 -0700 > On 2/23/17 5:30 PM, Stephen Hemminger wrote: >> On Thu, 23 Feb 2017 16:39:52 -0700 >> David Ahern wrote: >> >>> On 2/23/17 12:50 PM, Stephen Hemminger wrote: Some use cases create

[PATCH net] net: phy: Add missing driver check in phy_aneg_done()

Dan's static checker caught a potential code path in phy_state_machine() where we were not checking phydev->drv which is in phy_aneg_done(). Reported-by: Dan Carpenter Fixes: 25149ef9d25c ("net: phy: Check phydev->drv") Signed-off-by: Florian Fainelli

[PATCH net] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

From: Eric Dumazet The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in cyclecounter_cyc2ns(), and the final result is 804 ms, which is silly.

Re: netvsc NAPI

On Thu, 23 Feb 2017 18:24:06 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Wed, 22 Feb 2017 09:33:16 -0800 > > > NAPI for netvsc is ready but the merge coordination is a nuisance. > > > > Since netvsc NAPI support requires

Re: [PATCH] iproute2: hide devices starting with period by default

On Thu, 23 Feb 2017 18:07:07 -0700 David Ahern wrote: > On 2/23/17 5:30 PM, Stephen Hemminger wrote: > > On Thu, 23 Feb 2017 16:39:52 -0700 > > David Ahern wrote: > > > >> On 2/23/17 12:50 PM, Stephen Hemminger wrote: > >>> Some use cases

[PATCH net-next 0/1] net: Add support for rmnet_data driver

This patch adds support for the rmnet_data driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP mode.

[PATCH net-next 1/1] net: rmnet_data: Initial implementation

RmNet Data driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded and bridge modes. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a

[PATCH] uapi: fix rdma/mlx5-abi.h userspace compilation errors

Consistently use types from linux/types.h to fix the following rdma/mlx5-abi.h userspace compilation errors: /usr/include/rdma/mlx5-abi.h:69:25: error: 'u64' undeclared here (not in a function) MLX5_LIB_CAP_4K_UAR = (u64)1 << 0, /usr/include/rdma/mlx5-abi.h:69:29: error: expected ',' or '}'

Re: [PATCH] iproute2: hide devices starting with period by default

On 2/23/17 5:30 PM, Stephen Hemminger wrote: > On Thu, 23 Feb 2017 16:39:52 -0700 > David Ahern wrote: > >> On 2/23/17 12:50 PM, Stephen Hemminger wrote: >>> Some use cases create Linux networking devices which are not intended for >>> use >>> by normal networking.

[PATCH] iproute2: hide devices starting with period by default

Some use cases create Linux networking devices which are not intended for use by normal networking. This is an enhancement to ip command to hide network devices starting with period (like files in normal directory). Interfaces whose name start with "." are not shown by default, and the -a (or

Re: [PATCH v5 07/10] bpf: Add a Landlock sandbox example

On 22/02/2017 02:26, Mickaël Salaün wrote: > Add a basic sandbox tool to create a process isolated from some part of > the system. This sandbox create a read-only environment. It is only > allowed to write to a character device such as a TTY: > > # :> X > # echo $? > 0 > #

[PATCH] net: realtek: r8169: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/realtek/r8169.c | 41

Re: [patch net] lib: Remove string from parman config selection

Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko wrote: > From: Jiri Pirko > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > >

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

On Fri, Feb 24, 2017 at 12:04 AM, David Laight wrote: > From: Xin Long >> Sent: 23 February 2017 03:46 >> On Tue, Feb 21, 2017 at 10:27 PM, David Laight >> wrote: >> > From: Xin Long >> >> Sent: 18 February 2017 17:53 >> >> This patch is to add

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

Hi Rob, Thank you for code review comments. On Tue, Feb 21, 2017 at 10:42:38AM -0600, Rob Herring wrote: > EXTERNAL EMAIL > > > > Do i need to change from "vsc8531, led-0-mode" to "mscc, led-0-mode" > > Is this your suggestion? > > Well, there shouldn't be a space there, but yess, mscc is

[PATCH 3/3] mwifiex: wake system up when receives a wake irq

Currrently we are disabling this wake irq after receiving it. If this happens before we finish suspend and the pm event check is disabled, the system will continue suspending, and this irq would not work again. We may need to abort system suspend to avoid that. Signed-off-by: Jeffy Chen

[PATCH net] sctp: set sin_port for addr param when checking duplicate address

Commit b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's bind address list") tried to check for duplicate address before copying to asoc's bind_addr list from global addr list. But all the addrs' sin_ports in global addr list are 0 while the addrs' sin_ports are bp->port in asoc's

Re: [PATCH net] net: phy: Fix LED mode in DT single property.

Hi Raju, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Raju-Lakkaraju/net-phy-Fix-LED-mode-in-DT-single-property/20170224-140414 config: x86_64-randconfig-x007-201708 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

Hi Tom, On Thu, Feb 23, 2017 at 10:07:03AM -0800, Tom Herbert wrote: > I'm looking at the GTP encapsulation, it's not particularly complex. > Is there any real reason why we can't just implement a netdev > interface with static tunnels and configuration to do performance > testing and

[PATCH net] net: phy: Fix LED mode in DT single property.

From: Raju Lakkaraju Fix the LED mode DT parameters combine to a single property and change the vendor prefix i.e. mscc. Signed-off-by: Raju Lakkaraju --- .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 20 -

[PATCH v1 net] net: phy: Fix LED mode in DT single property.

From: Raju Lakkaraju Fix the LED mode DT parameters combine to a single property and change the vendor prefix i.e. mscc. Signed-off-by: Raju Lakkaraju --- Change set: v0: Fix the LED mode DT parameters combine to a single property v1:

Re: VXLAN RCU error

On Thu, Feb 23, 2017 at 12:20 AM, Jakub Kicinski wrote: > On Wed, 22 Feb 2017 20:30:31 -0800, Jakub Kicinski wrote: >> On Wed, 22 Feb 2017 14:27:45 -0800, Jakub Kicinski wrote: >> > [ 1571.067134] === >> > [ 1571.071842] [ ERR: suspicious RCU usage. ]

Re: [PATCH] iproute2: hide devices starting with period by default

On Thu, 23 Feb 2017 16:39:52 -0700 David Ahern wrote: > On 2/23/17 12:50 PM, Stephen Hemminger wrote: > > Some use cases create Linux networking devices which are not intended for > > use > > by normal networking. This is an enhancement to ip command to hide network >

Re: [PATCH] iproute2: hide devices starting with period by default

On 2/23/17 12:50 PM, Stephen Hemminger wrote: > Some use cases create Linux networking devices which are not intended for use > by normal networking. This is an enhancement to ip command to hide network > devices starting with period (like files in normal directory). Interfaces > whose > name

Re: netvsc NAPI

From: Stephen Hemminger Date: Wed, 22 Feb 2017 09:33:16 -0800 > NAPI for netvsc is ready but the merge coordination is a nuisance. > > Since netvsc NAPI support requires other changes that are proceeding through > GregKH's char-misc tree. I would like to send the two

[PATCH 0/8] Netfilter fixes for net

Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Revisit warning logic when not applying default helper assignment. Jiri Kosina considers we are breaking existing setups and not warning our users accordinly now that automatic helper assignment has

[PATCH 5/8] netfilter: ipset: Null pointer exception in ipset list:set

From: Vishwanath Pai If we use before/after to add an element to an empty list it will cause a kernel panic. $> cat crash.restore create a hash:ip create b hash:ip create test list:set timeout 5 size 4 add test b before a $> ipset -R < crash.restore Executing the above will

[PATCH 1/8] netfilter: nf_ct_helper: warn when not applying default helper assignment

From: Jiri Kosina Commit 3bb398d925 ("netfilter: nf_ct_helper: disable automatic helper assignment") is causing behavior regressions in firewalls, as traffic handled by conntrack helpers is now by default not passed through even though it was before due to missing CT targets

Re: Software loopback with phy 88E1116R and marvell MV78100 gbe

On Thu, Feb 23, 2017 at 12:28:10PM +0100, Paolo Minazzi wrote: > On Thu, Feb 23, 2017 at 11:59 AM, Andrew Lunn wrote: > >> I tried to do the same things on 88E1116R, setting the but 14 of reg 0. > >> But If I do it I lose the link, and the test program does not work. > >> I tried

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: > On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: > > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: > >> Hi Or, > >> - On Feb 16, 2017, at 3:59 PM, Or Gerlitz

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: > - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: [...] > > This shouldn't be taken as a HW requirement and it's unlikely we'd add > > explicit GTP support in flow_dissector. If we can't get entropy in the

ip route get oddly fails for ipv6

Hey, For some reason ip route get fails to retrieve ipv6 routes, although the subject destination is indeed reachable: [root@localhost tests]# ip -6 route 2001:1::/64 dev eth1 proto kernel metric 256 fe80::/64 dev eth0 proto kernel metric 256 fe80::/64 dev eth1 proto kernel metric 256

Re: ip route get oddly fails for ipv6

Forgot to mention: [root@localhost tests]# uname -r 3.10.0-514.2.2.el7.x86_64 [root@localhost tests]# cat /etc/redhat-release CentOS Linux release 7.2.1511 (Core) On Thu, Feb 23, 2017 at 4:43 PM, Leon Goldberg wrote: > Hey, > > For some reason ip route get fails to

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

On 2/23/2017 3:49 PM, Pablo Neira Ayuso wrote: "The UDP Source Port is a locally allocated port number at the sending GTP-U entity." and the proposed patch goes in that direction, agree?

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

- On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: >> On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >> > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz >> > wrote:

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

On 23/02/2017 4:18 AM, Alexander Duyck wrote: On Wed, Feb 22, 2017 at 6:06 PM, Eric Dumazet wrote: On Wed, 2017-02-22 at 17:08 -0800, Alexander Duyck wrote: Right but you were talking about using both halves one after the other. If that occurs you have nothing

RE: create drivers/net/mdio and move mdio drivers into it

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Andrew Lunn > Sent: Thursday, February 23, 2017 5:30 PM > To: YUAN Linyu > Cc: Florian Fainelli; David S . Miller; netdev@vger.kernel.org; cug...@163.com > Subject: Re: create

Re: create drivers/net/mdio and move mdio drivers into it

On Thu, Feb 23, 2017 at 09:51:17AM +, YUAN Linyu wrote: > > > > -Original Message- > > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > > On Behalf Of Andrew Lunn > > Sent: Thursday, February 23, 2017 5:30 PM > > To: YUAN Linyu > > Cc: Florian Fainelli;

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

Hi Tom, - On Feb 22, 2017, at 6:41 PM, Tom Herbert t...@herbertland.com wrote: > On Tue, Feb 21, 2017 at 2:18 AM, Andreas Schultz wrote: >> Add network device to gtp context in preparation for splitting >> the TEID from the network device. >> >> Use this to rework the

Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors

Hello! On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' u8 rx_traces; /usr/include/linux/rds.h:199:2: error: unknown type name

[PATCH v2] uapi: fix linux/rds.h userspace compilation errors

Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' u8 rx_traces; /usr/include/linux/rds.h:199:2: error: unknown type name 'u8' u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];

Re: [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: Include in uapi/linux/seg6.h to fix the following linux/seg6.h userspace compilation error: /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr' struct in6_addr segments[0]; Include in

[PATCH] net: stmmac: unify registers dumps methods

The stmmac driver have two methods for registers dumps: via ethtool and at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly. This patch convert all dump_regs() function from "printing regs" to "fill the reg_space used by ethtool".

[PATCH net] vxlan: correctly validate VXLAN ID against VXLAN_VID_MASK

The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: netfilter: nft_ct: add zone id set support

Hi Florian, On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List wrote: > Web: > https://git.kernel.org/torvalds/c/edee4f1e92458299505ff007733f676b00c516a1 > Commit: edee4f1e92458299505ff007733f676b00c516a1 > Parent:

SIPHASH (was: Re: [GIT] Networking)

Hi Jason, On Wed, Feb 22, 2017 at 5:31 AM, David Miller wrote: > 3) Introduce SIPHASH and it's usage for secure sequence numbers and >syncookies. From Jason A. Donenfeld. > Jason A. Donenfeld (4): > siphash: add cryptographically secure PRF > siphash:

Re: netfilter: nft_ct: add zone id set support

On Thu, Feb 23, 2017 at 12:34:35PM +0100, Florian Westphal wrote: > Geert Uytterhoeven wrote: > > On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List > > wrote: > > > Web: > > >

Re: [patch net] lib: Remove string from parman config selection

Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko wrote: > From: Jiri Pirko > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. Thanks!

[PATCH 6/8] netfilter: xt_hashlimit: Fix integer divide round to zero.

From: Alban Browaeys Diving the divider by the multiplier before applying to the input. When this would "divide by zero", divide the multiplier by the divider first then multiply the input by this value. Currently user2creds outputs zero when input value is bigger than

[PATCH 3/8] netfilter: ctnetlink: Fix regression in CTA_HELP processing

From: Kevin Cernekee Prior to Linux 4.4, it was usually harmless to send a CTA_HELP attribute containing the name of the current helper. That is no longer the case: as of Linux 4.4, if ctnetlink_change_helper() returns an error from the ct->master check, processing of the

[PATCH 8/8] netfilter: nfnetlink: remove static declaration from err_list

From: Liping Zhang Otherwise, different subsys will race to access the err_list, with holding the different nfnl_lock(subsys_id). But this will not happen now, since ->call_batch is only implemented by nftables, so the err_list is protected by

[PATCH 2/8] netfilter: ctnetlink: Fix regression in CTA_STATUS processing

From: Kevin Cernekee The libnetfilter_conntrack userland library always sets IPS_CONFIRMED when building a CTA_STATUS attribute. If this toggles the bit from 0->1, the parser will return an error. On Linux 4.4+ this will cause any NFQA_EXP attribute in the packet to be

[PATCH 7/8] netfilter: nfnetlink_queue: fix NFQA_VLAN_MAX definition

From: Ken-ichirou MATSUZAWA Should be - 1 as in other _MAX definitions. Signed-off-by: Ken-ichirou MATSUZAWA Acked-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 4/8] Fix bug: sometimes valid entries in hash:* types of sets were evicted

From: Jozsef Kadlecsik Wrong index was used and therefore when shrinking a hash bucket at deleting an entry, valid entries could be evicted as well. Thanks to Eric Ewanco for the thorough bugreport. Fixes netfilter bugzilla #1119 Signed-off-by: Jozsef Kadlecsik

Re: Software loopback with phy 88E1116R and marvell MV78100 gbe

On Thu, Feb 23, 2017 at 11:59 AM, Andrew Lunn wrote: >> I tried to do the same things on 88E1116R, setting the but 14 of reg 0. >> But If I do it I lose the link, and the test program does not work. >> I tried to force the link in software, but seems the controller send >> packets

Re: netfilter: nft_ct: add zone id set support

Geert Uytterhoeven wrote: > On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List > wrote: > > Web: > > https://git.kernel.org/torvalds/c/edee4f1e92458299505ff007733f676b00c516a1 > > Commit:

Re: [PATCH net 3/6] net/mlx5e: Do not reduce LRO WQE size when not using build_skb

On Wed, Feb 22, 2017 at 9:45 PM, Alexei Starovoitov wrote: > On Wed, Feb 22, 2017 at 7:20 AM, Saeed Mahameed wrote: >> From: Tariq Toukan >> >> When rq_type is Striding RQ, no room of SKB_RESERVE is needed >> as SKB

[PATCH] RDS: IB: fix ifnullfree.cocci warnings

net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on

Re: lib: Introduce priority array area manager

Thu, Feb 23, 2017 at 10:22:22AM CET, ge...@linux-m68k.org wrote: >Hi Jiri, > >On Thu, Feb 23, 2017 at 9:32 AM, Jiri Pirko wrote: >> Thu, Feb 23, 2017 at 08:56:26AM CET, ge...@linux-m68k.org wrote: >>>On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List

[patch net] lib: Remove string from parman config selection

From: Jiri Pirko As reported by Geert, remove the string so the user does not see this config option. The option is explicitly selected only as a dependency of in-kernel users. Reported-by: Geert Uytterhoeven Fixes: 44091d29f207 ("lib: Introduce

[PATCH net V3 3/5] net/mlx4_core: Fix VF overwrite of module param which disables DMFS on new probed PFs

From: Majd Dibbiny In the VF driver, module parameter mlx4_log_num_mgm_entry_size was mistakenly overwritten -- and in a manner which overrode the device-managed flow steering option encoded in the parameter. log_num_mgm_entry_size is a global module parameter which affects

[PATCH net V3 4/5] net/mlx4_core: Use cq quota in SRIOV when creating completion EQs

From: Jack Morgenstein When creating EQs to handle CQ completion events for the PF or for VFs, we create enough EQE entries to handle completions for the max number of CQs that can use that EQ. When SRIOV is activated, the max number of CQs a VF (or the PF) can obtain

[PATCH net V3 0/5] mlx4 misc fixes

Hi Dave, This patchset contains misc bug fixes from Eric Dumazet and our team to the mlx4 Core and Eth drivers. Series generated against net commit: eee2faabc63d tcp: account for ts offset only if tsecr not zero Thanks, Tariq. v3: * Rebased, conflict solved. v2: * Added Eric's fix (patch

[PATCH net V3 5/5] net/mlx4_en: Use __skb_fill_page_desc()

From: Eric Dumazet Or we might miss the fact that a page was allocated from memory reserves. Fixes: dceeab0e5258 ("mlx4: support __GFP_MEMALLOC for rx") Signed-off-by: Eric Dumazet Signed-off-by: Tariq Toukan ---

[PATCH net V3 2/5] net/mlx4: Spoofcheck and zero MAC can't coexist

From: Eugenia Emantayev Spoofcheck can't be enabled if VF MAC is zero. Vice versa, can't zero MAC if spoofcheck is on. Fixes: 8f7ba3ca12f6 ('net/mlx4: Add set VF mac address support') Signed-off-by: Eugenia Emantayev Signed-off-by: Tariq Toukan

[PATCH net V3 1/5] net/mlx4: Change ENOTSUPP to EOPNOTSUPP

From: Or Gerlitz As ENOTSUPP is specific to NFS, change the return error value to EOPNOTSUPP in various places in the mlx4 driver. Signed-off-by: Or Gerlitz Suggested-by: Yotam Gigi Reviewed-by: Matan Barak

Re: [PATCH net V3 0/5] mlx4 misc fixes

From: Tariq Toukan Date: Thu, 23 Feb 2017 12:02:40 +0200 > This patchset contains misc bug fixes from Eric Dumazet and our team > to the mlx4 Core and Eth drivers. > > Series generated against net commit: > eee2faabc63d tcp: account for ts offset only if tsecr not zero ...

Re: [PATCH] bpf: fix spelling mistake: "proccessed" -> "processed"

From: Colin King Date: Thu, 23 Feb 2017 00:20:53 + > From: Colin Ian King > > trivial fix to spelling mistake in verbose log message > > Signed-off-by: Colin Ian King Applied.

[PATCH net 1/1] tipc: move premature initilalization of stack variables

In the function tipc_rcv() we initialize a couple of stack variables from the message header before that same header has been validated. In rare cases when the arriving header is non-linar, the validation function itself may linearize the buffer by calling skb_may_pull(), while the wrongly

[PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID

The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer --- v2: check against VXLAN_N_VID instead of changing operator drivers/net/vxlan.c | 2

Re: [PATCH net] vxlan: don't allow overwrite of config src addr

On Mon, 20 Feb 2017 17:25:28 +, Brian Russell wrote: > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2019,7 +2019,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct > net_device *dev, > > dst_port = rdst->remote_port ? rdst->remote_port : >

[PATCH] wireless/atmel: remove time_t usage

last_qual never really holds a time. It only holds jiffies. Make it the same type as jiffies. Signed-off-by: Alexandre Belloni --- drivers/net/wireless/atmel/atmel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

On 2/23/2017 4:47 AM, kbuild test robot wrote: net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some

Re: [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID

On Thu, 23 Feb 2017 17:19:41 +0100, Matthias Schiffer wrote: > The incorrect check caused an off-by-one error: the maximum VID 0xff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer > --- > v2: check

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

On Thu, Feb 23, 2017 at 03:21:13PM +0100, Andreas Schultz wrote: > - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: [...] > > According to specs, section 4.4.2.3 Encapsulated T-PDU, TS 29.281. > > > > "The UDP Source Port is a locally allocated port number at the sending > >

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

On Thu, Feb 23, 2017 at 6:21 AM, Andreas Schultz wrote: > - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > >> On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: >>> On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >>> > On

Re: [PATCH 0/8] Netfilter fixes for net

From: Pablo Neira Ayuso Date: Thu, 23 Feb 2017 12:14:01 +0100 > The following patchset contains Netfilter fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks a lot!

RE: [PATCH net-next 2/2] sctp: add support for MSG_MORE

From: Xin Long > Sent: 23 February 2017 03:46 > On Tue, Feb 21, 2017 at 10:27 PM, David Laight > wrote: > > From: Xin Long > >> Sent: 18 February 2017 17:53 > >> This patch is to add support for MSG_MORE on sctp. > >> > >> It adds force_delay in sctp_datamsg to save

Re: create drivers/net/mdio and move mdio drivers into it

> Big picture is we can remove struct mii_bus, So if you remove this, how do you represent MII as a bus? It is a bus, clause 22 allows up to 32 devices on it, and i have boards with more than 8 devices on the bus. Clause 44 allows many more devices on the bus. Andrew

Re: lib: Introduce priority array area manager

Hi Jiri, On Thu, Feb 23, 2017 at 9:32 AM, Jiri Pirko wrote: > Thu, Feb 23, 2017 at 08:56:26AM CET, ge...@linux-m68k.org wrote: >>On Wed, Feb 22, 2017 at 8:02 PM, Linux Kernel Mailing List >> wrote: >>> Web: >>>

Re: netfilter: nft_ct: add zone id set support

Pablo Neira Ayuso wrote: > On Thu, Feb 23, 2017 at 12:34:35PM +0100, Florian Westphal wrote: > > Yes, Dan reported this and a patch is queued at > > http://patchwork.ozlabs.org/patch/727573/ > > > > Pablo, any reason why this is still waiting? > > I just flushing out my

Re: [PATCH net] vxlan: don't allow overwrite of config src addr

On Mon, 20 Feb 2017 17:25:28 +, Brian Russell wrote: > When using IPv6 transport and a default dst, a pointer to the configured > source address is passed into the route lookup. If no source address is > configured, then the value is overwritten. > > IPv6 route lookup ignores egress ifindex

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

On Thu, Feb 23, 2017 at 1:19 AM, Andreas Schultz wrote: > Hi Tom, > > - On Feb 22, 2017, at 6:41 PM, Tom Herbert t...@herbertland.com wrote: > >> On Tue, Feb 21, 2017 at 2:18 AM, Andreas Schultz wrote: >>> Add network device to gtp context in preparation

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

On Thu, Feb 23, 2017 at 6:00 AM, Pablo Neira Ayuso wrote: > On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: >> - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > [...] >> > This shouldn't be taken as a HW requirement and it's

Re: [PATCH v2] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 14:30:34 +0300 > Include in uapi/linux/seg6.h to fix the following > linux/seg6.h userspace compilation error: > > /usr/include/linux/seg6.h:31:18: error: array type has incomplete element > type 'struct in6_addr' > struct

Re: [PATCH v2] uapi: fix linux/rds.h userspace compilation errors

From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 14:35:23 +0300 > Consistently use types from linux/types.h to fix the following > linux/rds.h userspace compilation errors: > > /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' > u8 rx_traces; >

Re: [PATCH RFC v2 00/12] socket sendmsg MSG_ZEROCOPY

From: Willem de Bruijn Date: Wed, 22 Feb 2017 11:38:49 -0500 > From: Willem de Bruijn > > RFCv2: > > I have received a few requests for status and rebased code of this > feature. We have been running this code internally, discovering and >

Re: [PATCH] uapi: fix linux/ip6_tunnel.h userspace compilation errors

From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 01:38:03 +0300 > Include and to fix the following > linux/ip6_tunnel.h userspace compilation errors: > > /usr/include/linux/ip6_tunnel.h:23:12: error: 'IFNAMSIZ' undeclared here (not > in a function) > char name[IFNAMSIZ];

Re: [PATCH] uapi: fix linux/llc.h userspace compilation error

From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 01:38:26 +0300 > Include to fix the following linux/llc.h userspace > compilation error: > > /usr/include/linux/llc.h:26:27: error: 'IFHWADDRLEN' undeclared here (not in > a function) > unsigned char sllc_mac[IFHWADDRLEN];

Re: [patch net] lib: Remove string from parman config selection

From: Jiri Pirko Date: Thu, 23 Feb 2017 10:57:45 +0100 > From: Jiri Pirko > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > >

Re: [PATCH 1/1] forcedeth: Remove return from a void function

From: Zhu Yanjun Date: Thu, 23 Feb 2017 03:22:49 -0500 > In a void function, it is not necessary to append a return statement in it. > > Signed-off-by: Zhu Yanjun Applied.

Re: [PATCH net v5] bpf: add helper to compare network namespaces

David Ahern writes: > On 2/19/17 9:17 PM, Eric W. Biederman wrote: @@ -2597,6 +2598,39 @@ static const struct bpf_func_proto bpf_xdp_event_output_proto = { .arg5_type = ARG_CONST_STACK_SIZE, }; +BPF_CALL_3(bpf_sk_netns_cmp,

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate >

Re: [PATCH net] vxlan: correctly validate VXLAN ID against VXLAN_VID_MASK

On Thu, 23 Feb 2017 13:59:02 +0100, Matthias Schiffer wrote: > The incorrect check caused an off-by-one error: the maximum VID 0xff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer > --- >

Re: [PATCH net 0/6] Mellanox mlx5e fixes for 4.11-rc1

From: Saeed Mahameed Date: Wed, 22 Feb 2017 17:20:10 +0200 > This series includes some important bug fixes for mlx5e driver. > > Three misc fixes: > From Mohamad, compilation fix on s390 system > From Me, A fix for driver unload when switchdev mode is on. > From Tariq, HW

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

Hi Tom, - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >> On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: >>> Hi Or, >>> - On Feb 16, 2017, at 3:59 PM, Or

Re: Software loopback with phy 88E1116R and marvell MV78100 gbe

> I tried to do the same things on 88E1116R, setting the but 14 of reg 0. > But If I do it I lose the link, and the test program does not work. > I tried to force the link in software, but seems the controller send > packets but it is not able to receive them. > Is possibile to do such a software

[PATCH v2] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

Include in uapi/linux/seg6.h to fix the following linux/seg6.h userspace compilation error: /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr' struct in6_addr segments[0]; Include in uapi/linux/seg6_iptunnel.h to fix the following

[PATCH iproute2 master] {f,m}_bpf: dump tag over insns

We already export TCA_BPF_TAG resp. TCA_ACT_BPF_TAG from kernel commit f1f7714ea51c ("bpf: rework prog_digest into prog_tag"), thus also dump it when filter/actions are shown. Signed-off-by: Daniel Borkmann --- tc/f_bpf.c | 9 + tc/m_bpf.c | 9 + 2 files

  1   2   >