Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jiri Pirko
Sun, Apr 16, 2017 at 02:34:30PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >When you dump hundreds of thousands of actions, getting only 32 per >dump batch even when the socket buffer and memory allocations allow >is inefficient. > >With this change, the user will

[PATCH net] be2net: VxLAN offload should be re-enabled when only 1 UDP port is left

2017-04-17 Thread Sriharsha Basavapatna
We disable VxLAN offload when more than 1 UDP port is added to the driver, since Skyhawk doesn't support offload with multiple ports. The existing driver design expects the user to delete all port configurations and create a configuration with a single UDP port for VxLAN offload to be re-enabled.

КЛИЕНТСКИЕ БАЗЫ http://xurl.es/PR0DAWEZ УЗНАЙТЕ ПОДРОБНЕЕ!

2017-04-17 Thread .

Re: [PATCH] sh_eth: unmap DMA buffers when freeing rings

2017-04-17 Thread Sergei Shtylyov
Hello! On 4/16/2017 11:01 PM, Sergei Shtylyov wrote: The DMA API debugging (when enabled) causes: WARNING: CPU: 0 PID: 1445 at lib/dma-debug.c:519 add_dma_entry+0xe0/0x12c DMA-API: exceeded 7 overlapping mappings of cacheline 0x01b2974d to be printed after repeated initialization of the

Re: [PATCH RFC] ptr_ring: add ptr_ring_unconsume

2017-04-17 Thread Sergei Shtylyov
Hello! On 4/17/2017 2:19 AM, Michael S. Tsirkin wrote: Applications that consume a batch of entries in one go can benefit from ability to return some of them back into the ring. Add an API for that - assuming there's space. If there's no space naturally we can't do this and have to drop

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jamal Hadi Salim
On 17-04-17 09:10 AM, Eric Dumazet wrote: [..] We can not assume user programs properly cleared the paddings anyway. Using them for 'new features' is risky, since it might break programs. So the safe way is using new attributes really. Since we agreed to have longer discussions on uapis

[PATCH net-next] Replace constant with sysctl netdev_budget_jiffies to enable tuning

2017-04-17 Thread Matthew Whitehead
Constants used for tuning are generally a bad idea, especially as hardware changes over time. Replace the constant '2' with netdev_budget_jiffies to enable sysadmins to tune the behavior. Also document the variable. For example, a very fast machine might tune this to 1, while my regression

Re: [PATCH net] sfc: limit the number of receive queues

2017-04-17 Thread David Miller
From: Bert Kenward Date: Wed, 12 Apr 2017 17:06:52 +0100 > The number of rx queues is determined by the rss_cpus parameter > or the cpu topology. If that is higher than EFX_MAX_RX_QUEUES the > driver can corrupt state. > > Fixes: 8ceee660aacb ("New driver "sfc" for

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

2017-04-17 Thread David Miller
From: Wolfgang Bumiller Date: Wed, 12 Apr 2017 16:21:38 +0200 > Commit 1045ba77a ("net sched actions: Add support for user cookies") > added code to net/sched/act_api.c's tcf_action_init_1 using the `tb` > nlattr array unconditionally, while it was otherwise used as well

Re: [PATCH net-next v2] net: dsa: isolate legacy code

2017-04-17 Thread David Miller
From: Vivien Didelot Date: Wed, 12 Apr 2017 12:45:03 -0400 > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Signed-off-by: Vivien Didelot >

[PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 16:44:32 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (25): Use devm_kmalloc_array() in mvneta_init() Improve two size determinations in mvneta_init()

[PATCH 02/25] net: mvneta: Improve two size determinations in mvneta_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 21:45:38 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

Re: [PATCH net-next] Replace constant with sysctl netdev_budget_jiffies to enable tuning

2017-04-17 Thread Eric Dumazet
On Mon, 2017-04-17 at 10:29 -0400, Matthew Whitehead wrote: > Constants used for tuning are generally a bad idea, especially as hardware > changes over time. Replace the constant '2' with netdev_budget_jiffies to > enable sysadmins to tune the behavior. Also document the variable. > > For

Re: [PATCH v2 0/9] ftgmac100: Rework batch 5 - Features

2017-04-17 Thread David Miller
From: Benjamin Herrenschmidt Date: Thu, 13 Apr 2017 14:39:07 +1000 > This is the second spin of the fifth and last batch of > updates to the ftgmac100 driver. This series doesn't apply cleanly to net-next, please respin. Thanks.

[PATCH 03/25] net: mvneta: Use kmalloc_array() in mvneta_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 22:11:22 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected

[PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:09:07 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH 06/25] net: mvpp2: Improve two size determinations in mvpp2_probe()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:38:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH 07/25] net: mvpp2: Improve another size determination in mvpp2_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:48:23 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 08/25] net: mvpp2: Improve another size determination in mvpp2_port_probe()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:55:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 09/25] net: mvpp2: Improve another size determination in mvpp2_bm_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 09:06:33 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 10/25] net: mvpp2: Improve another size determination in mvpp2_prs_default_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 09:12:34 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 13/25] net: mvpp2: Fix a jump label position in mvpp2_rx()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:52:02 +0200 The script "checkpatch.pl" pointed out that labels should not be indented. Thus delete two horizontal tabs before the jump label "err_drop_frame" in the function "mvpp2_rx". Signed-off-by: Markus Elfring

[PATCH 12/25] net: mvpp2: Improve a size determination in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:40:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Eric Dumazet
On Mon, 2017-04-17 at 10:02 -0400, Jamal Hadi Salim wrote: > On 17-04-17 09:10 AM, Eric Dumazet wrote: > > [..] > > > > We can not assume user programs properly cleared the paddings anyway. > > > > Using them for 'new features' is risky, since it might break programs. > > > > So the safe way is

Re: [PATCH v2] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-04-17 Thread Linus Lüssing
On Tue, Mar 21, 2017 at 04:32:45PM -0700, Stephen Hemminger wrote: > On Tue, 21 Mar 2017 23:28:45 +0100 > Linus Lüssing wrote: > > > However, the IP code drops it in the beginning of ip_input.c/ip_rcv() > > as the dnat target did not update the skb->pkt_type. If after >

[PATCH 11/25] net: mvpp2: Improve 27 size determinations

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:30:29 +0200 Replace the specification of data structures by references to a local variable as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus

[PATCH 14/25] net: mvpp2: Rename a jump label in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:10:47 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 16 +++- 1 file

Use of skb_unclone in drivers

2017-04-17 Thread James Hughes
Netdevs, We have recently got to the bottom of an issue which we have been encountering on a Raspberry Pi being used as an access point, and we need a bit of advice on the correct way of fixing the issue. The set up is a Raspberry Pi 3 running hostapd on its inbuilt wireless adaptor (Brcm43438

Re: [PATCH net-next,2/2] hv_netvsc: Exclude non-TCP port numbers from vRSS hashing

2017-04-17 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Apr 2017 11:35:06 -0700 > From: Haiyang Zhang > > Azure hosts are not supporting non-TCP port numbers in vRSS hashing for > now. For example, UDP packet loss rate will be high if port numbers are > also

Re: [PATCH net-next,1/2] hv_netvsc: Fix the queue index computation in forwarding case

2017-04-17 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Apr 2017 11:35:05 -0700 > From: Haiyang Zhang > > If the outgoing skb has a RX queue mapping available, we use the queue > number directly, other than put it through Send Indirection Table. > >

[PATCH 01/25] net: mvneta: Use devm_kmalloc_array() in mvneta_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 21:23:19 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue

Re: [PATCH net-next 00/16] Mellanox, mlx5 RDMA net device support

2017-04-17 Thread David Miller
From: Saeed Mahameed Date: Thu, 13 Apr 2017 06:36:50 +0300 > This series provides the lower level mlx5 support of RDMA netdevice > creation API [1] suggested and introduced by Intel's HFI OPA VNIC > netdevice driver [2], to enable IPoIB mlx5 RDMA netdevice creation. Series

[PATCH 04/25] net: mvneta: Adjust six checks for null pointers

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 22:45:33 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

Re: [PATCH net-next] net: bridge: notify on hw fdb takeover

2017-04-17 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 14 Apr 2017 13:49:34 +0300 > Recently we added support for SW fdbs to take over HW ones, but that > results in changing a user-visible fdb flag thus we need to send a > notification, also it's consistent with how HW takes over SW

Re: [PATCH net-next] net: mvneta: fix failed to suspend if WOL is enabled

2017-04-17 Thread David Miller
From: Jisheng Zhang Date: Fri, 14 Apr 2017 19:07:32 +0800 > Recently, suspend/resume and WOL support are added into mvneta driver. > If we enable WOL, then we get some error as below on Marvell BG4CT > platforms during suspend: > > [ 184.149723] dpm_run_callback():

Re: [PATCH net-next] ibmvnic: Report errors when failing to release sub-crqs

2017-04-17 Thread David Miller
Please do not submit a set of changes to the same driver like this. Instead, submit a proper patch series which is numbered (so that the dependencies betweeen changes, if any, are explciit) and also with a proper "[PATCH 0/N] ..." header posting which describes what the patch series is doing,

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Roman Mashak
Eric Dumazet writes: > On Mon, 2017-04-17 at 12:46 -0400, Jamal Hadi Salim wrote: > >> Of course it is trivial to add this as attributes and 32 bits >> for this case is not a big deal because it is done once. I want to talk >> about the pads instead ;-> What do you

Re: [PATCH net-next 0/6] bpf: LRU performance and test-program improvements

2017-04-17 Thread David Miller
From: Martin KaFai Lau Date: Fri, 14 Apr 2017 10:30:24 -0700 > The first 4 patches make a few improvements to the LRU tests. > > Patch 5/6 is to improve the performance of BPF_F_NO_COMMON_LRU map. > > Patch 6/6 adds an example in using LRU map with map-in-map. Series applied,

bluetooth 6lowpan interfaces are not virtual anymore

2017-04-17 Thread Alexander Aring
Hi, bluetooth-next contains patches which introduces a queue for bluetooth 6LoWPAN interfaces. [0] At first, the current behaviour is now that 802.15.4 6LoWPAN interfaces are virtual and bluetooth 6LoWPAN interfaces are not virtual anymore. To have a different handling in both subsystems is

[PATCH] net: cx89x0: move attribute declaration before struct keyword

2017-04-17 Thread Stefan Agner
The attribute declaration is typically before the definition. Move the __maybe_unused attribute declaration before the struct keyword. Signed-off-by: Stefan Agner --- drivers/net/ethernet/cirrus/cs89x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-17 Thread Jiri Pirko
Sun, Apr 16, 2017 at 03:56:13PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >This adds support for filtering based on time since last used. >When we are dumping a large number of actions it is useful to >have the option of filtering based on when the action was

Re: [PATCH] net: thunderx: Fix set_max_bgx_per_node for 81xx rgx

2017-04-17 Thread Sunil Kovvuri
On Thu, Apr 13, 2017 at 12:55 PM, George Cherian wrote: > Add the PCI_SUBSYS_DEVID_81XX_RGX and use the same to set > the max bgx per node count. > > This fixes the issue intoduced by following commit > 78aacb6f6 net: thunderx: Fix invalid mac addresses for node1

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Eric Dumazet
On Mon, 2017-04-17 at 07:01 -0400, Jamal Hadi Salim wrote: > The name "pad" is ugly - but _we need to put these reserved spaces > to good use_. We cant keep declaring pads and say they should never > be used in the future. > We dont need more than 2-3 bits for the flags for example and i dont >

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jamal Hadi Salim
On 17-04-17 04:19 AM, Jiri Pirko wrote: Sun, Apr 16, 2017 at 02:34:30PM CEST, j...@mojatatu.com wrote: From: Jamal Hadi Salim When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations allow is

Re: skb_over_panic using UDP and 6lowpan / fakelb

2017-04-17 Thread Alexander Aring
Hi, sorry for the late reply. On 04/03/2017 07:29 PM, Cong Wang wrote: > (Cc'ing netdev and maintainers) > > On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: >> >> Hi, >> >> Sending a simple UDP packet (39 bytes long), over a 6lowpan interface >> (using fakelb),

Re: [PATCH] sh_eth: unmap DMA buffers when freeing rings

2017-04-17 Thread Sergei Shtylyov
Hello! On 04/17/2017 11:57 AM, Sergei Shtylyov wrote: WARNING: CPU: 0 PID: 1445 at lib/dma-debug.c:519 add_dma_entry+0xe0/0x12c DMA-API: exceeded 7 overlapping mappings of cacheline 0x01b2974d to be printed after repeated initialization of the Ether device, e.g. suspend/resume or 'ifconfig'

[PATCH v2] sh_eth: unmap DMA buffers when freeing rings

2017-04-17 Thread Sergei Shtylyov
The DMA API debugging (when enabled) causes: WARNING: CPU: 0 PID: 1445 at lib/dma-debug.c:519 add_dma_entry+0xe0/0x12c DMA-API: exceeded 7 overlapping mappings of cacheline 0x01b2974d to be printed after repeated initialization of the Ether device, e.g. suspend/resume or 'ifconfig' up/down.

[PATCH 16/25] net: mvpp2: Rename a jump label in mvpp2_tx_frag_process()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:36:34 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2

[PATCH 20/25] net: mvpp2: Adjust a null pointer check in mvpp2_egress_enable()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 14:07:52 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "txq->descs". Thus fix the affected source code place. Signed-off-by: Markus Elfring

[PATCH 24/25] skge: Adjust a null pointer check in skge_down()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 16:08:39 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!skge->mem". Thus fix the affected source code place. Signed-off-by: Markus Elfring

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

2017-04-17 Thread Jamal Hadi Salim
On 17-04-17 10:59 AM, David Miller wrote: Jamal please review this. Waiting for Wolfgang to submit a new patch. cheers, jamal

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jamal Hadi Salim
On 17-04-17 10:58 AM, Eric Dumazet wrote: [..] Very often, pads are there because of ABI constraints. We 'name' them to make clear to developers that they are there, and avoid security issues, because of say few bytes from kernel stack are copied to user space. struct foo { __u32 a; __u16

[PATCH 15/25] net: mvpp2: Adjust three error messages

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:20:41 +0200 Use the word "failed" in the string for three function calls. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 6 +++--- 1 file changed, 3

[PATCH 17/25] net: mvpp2: Rename a jump label in mvpp2_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 12:58:33 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2

[PATCH 19/25] net: mvpp2: Rename a jump label in mvpp2_prs_vlan_add()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 13:50:35 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jiri Pirko
Mon, Apr 17, 2017 at 03:10:59PM CEST, eric.duma...@gmail.com wrote: >On Mon, 2017-04-17 at 07:01 -0400, Jamal Hadi Salim wrote: > >> The name "pad" is ugly - but _we need to put these reserved spaces >> to good use_. We cant keep declaring pads and say they should never >> be used in the future.

[PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 14:32:14 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using

Re: Use of skb_unclone in drivers

2017-04-17 Thread Eric Dumazet
On Mon, 2017-04-17 at 16:02 +0100, James Hughes wrote: > Netdevs, > > We have recently got to the bottom of an issue which we have been > encountering on a Raspberry Pi being used as an access point, and we > need a bit of advice on the correct way of fixing the issue. > > The set up is a

[PATCH 18/25] net: mvpp2: Rename a jump label in mvpp2_prs_double_vlan_add()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 13:03:49 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 7 +++ 1 file changed, 3

[PATCH 23/25] skge: Use seq_puts() in skge_debug_show()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 15:43:08 +0200 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software.

[PATCH 22/25] net: pxa168_eth: Adjust four checks for null pointers

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 15:23:45 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 25/25] sky2: Use seq_puts() in sky2_debug_show()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 16:15:12 +0200 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software.

linux-next: build failure after merge of the block tree

2017-04-17 Thread Stephen Rothwell
Hi all, After merging the block tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/block/nbd.c: In function 'nbd_genl_connect': drivers/block/nbd.c:1662:10: error: too few arguments to function 'nla_parse_nested' ret = nla_parse_nested(socks, NBD_SOCK_MAX,

Re: [PATCH RFC (resend) net-next 3/6] virtio_net: Add basic skeleton for handling vnet header extensions.

2017-04-17 Thread Jason Wang
On 2017年04月16日 00:38, Vladislav Yasevich wrote: This is the basic sceleton which will be fleshed out by individiual extensions. Signed-off-by: Vladislav Yasevich --- drivers/net/virtio_net.c| 21 + include/linux/virtio_net.h | 12

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-17 Thread Alexei Starovoitov
On Mon, Apr 17, 2017 at 06:12:45PM -0700, David Miller wrote: > > > >> + if (insn->src_reg == BPF_REG_FP || insn->dst_reg == BPF_REG_FP) { > >> + ctx->saw_frame_pointer = true; > >> + if (BPF_CLASS(code) == BPF_ALU || > >> + BPF_CLASS(code) == BPF_ALU64) { > >> +

Re: [PATCH RFC] ptr_ring: add ptr_ring_unconsume

2017-04-17 Thread Jason Wang
On 2017年04月17日 07:19, Michael S. Tsirkin wrote: Applications that consume a batch of entries in one go can benefit from ability to return some of them back into the ring. Add an API for that - assuming there's space. If there's no space naturally we can't do this and have to drop entries, but

Re: [PATCH net] ipv6: drop non loopback packets claiming to originate from ::1

2017-04-17 Thread David Miller
From: Florian Westphal Date: Fri, 14 Apr 2017 20:22:43 +0200 > We lack a saddr check for ::1. This causes security issues e.g. with acls > permitting connections from ::1 because of assumption that these originate > from local machine. > > Assuming a source address of ::1 is

Re: [PATCH -next] net: phy: test the right variable in phy_write_mmd()

2017-04-17 Thread David Miller
From: Dan Carpenter Date: Fri, 14 Apr 2017 22:10:41 +0300 > This is a copy and paste buglet. We meant to test for ->write_mmd but > we test for ->read_mmd. > > Fixes: 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD > accessors") > Signed-off-by: Dan

Re: [PATCH net-next 1/2] netvsc: fix RCU warning in get_stats

2017-04-17 Thread David Miller
Both patches applied but you may want to use more consistent Subject line subsystem prefixes in the future.

Re: [PATCH] net: natsemi: ns83820: add checks for dma mapping error

2017-04-17 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 15 Apr 2017 01:50:50 +0300 > @@ -1136,6 +1141,10 @@ static netdev_tx_t ns83820_hard_start_xmit(struct > sk_buff *skb, > if (nr_frags) > len -= skb->data_len; > buf = pci_map_single(dev->pci_dev, skb->data, len,

[PATCH net-next v3] bonding: deliver link-local packets with skb->dev set to link that packets arrived on

2017-04-17 Thread Chonggang Li
Bonding driver changes the skb->dev to the bonding-master before passing the packet to stack for further processing. This, however does not make sense for the link-local packets and it loses "the link info" once its skb->dev is changed to bonding-master. This patch changes this behavior for

Re: [PATCH net-next] drivers: net: xgene-v2: Extend ethtool statistics

2017-04-17 Thread David Miller
From: Iyappan Subramanian Date: Fri, 14 Apr 2017 16:48:18 -0700 > + XGE_EXTD_STAT(rx_byte_cntr, RBYT), > + XGE_EXTD_STAT(rx_pkt_cntr, RPKT), > + XGE_EXTD_STAT(rx_fcs_error_cntr, RFCS), > + XGE_EXTD_STAT(rx_multicast_pkt_cntr, RMCA), > +

Re: [PATCH net-next v2] Add uid and cookie bpf helper to cg_skb_func_proto

2017-04-17 Thread David Miller
From: Chenbo Feng Date: Fri, 14 Apr 2017 18:25:26 -0700 > From: Chenbo Feng > > BPF helper functions get_socket_cookie and get_socket_uid can be > used for network traffic classifications, among others. Expose > them also to programs of type

Re: [PATCH] gso: Validate assumption of frag_list segementation

2017-04-17 Thread David Miller
From: Date: Sun, 16 Apr 2017 11:00:07 +0300 > From: Ilan Tayari > > Commit 07b26c9454a2 ("gso: Support partial splitting at the frag_list > pointer") assumes that all SKBs in a frag_list (except maybe the last > one) contain the same amount of GSO

Re: [PATCH net-next 1/1] ipv6: sr: fix BUG due to headroom too small after SRH push

2017-04-17 Thread David Miller
From: David Lebrun Date: Sun, 16 Apr 2017 12:27:14 +0200 > When a locally generated packet receives an SRH with two or more segments, > the remaining headroom is too small to push an ethernet header. This patch > ensures that the headroom is large enough after SRH

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-17 Thread Cong Wang
On Sat, Apr 15, 2017 at 11:48 AM, Wolfgang Bumiller wrote: > >> On April 15, 2017 at 8:20 PM Cong Wang wrote: >> >> >> On Fri, Apr 14, 2017 at 2:08 AM, Wolfgang Bumiller >> wrote: >> > Before I do that - trying to wrap my

Re: [PATCH net-next v2] bonding: deliver link-local packets with skb->dev set to link that packets arrived on

2017-04-17 Thread Jay Vosburgh
Chonggang Li wrote: >Bonding driver changes the skb->dev to the bonding-master before >passing the packet to stack for further processing. This, however >does not make sense for the link-local packets and it looses "the >link info" once its skb->dev is changed to

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-17 Thread David Miller
From: Daniel Borkmann Date: Mon, 17 Apr 2017 20:44:35 +0200 > On 04/17/2017 05:38 AM, David Miller wrote: >> +/* Map BPF registers to SPARC registers */ >> +static const int bpf2sparc[] = { >> + /* return value from in-kernel function, and exit value from eBPF */ >> +

[Patch net-next v3] net_sched: move the empty tp check from ->destroy() to ->delete()

2017-04-17 Thread Cong Wang
Roi reported we could have a race condition where in ->classify() path we dereference tp->root and meanwhile a parallel ->destroy() makes it a NULL. This is possible because ->destroy() could be called when deleting a filter to check if we are the last one in tp, this tp is still linked and

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-17 Thread Daniel Borkmann
On 04/17/2017 05:38 AM, David Miller wrote: There are a bunch of things I want to do still, and I know that I have to attend to sparc32 more cleanly, but I wanted to post this now that I have it passing the BPF testsuite completely: [24174.315421] test_bpf: Summary: 305 PASSED, 0 FAILED,

Re: pull request: bluetooth-next 2017-04-14

2017-04-17 Thread David Miller
From: Johan Hedberg Date: Fri, 14 Apr 2017 21:12:12 +0300 > Here's the main batch of Bluetooth & 802.15.4 patches for the 4.12 > kernel. > > - Many fixes to 6LoWPAN, in particular for BLE > - New CA8210 IEEE 802.15.4 device driver (accounting for most of the >

Re: [Patch net] ipv4: fix a deadlock in ip_ra_control

2017-04-17 Thread David Miller
From: Cong Wang Date: Wed, 12 Apr 2017 12:32:13 -0700 > Similar to commit 87e9f0315952 > ("ipv4: fix a potential deadlock in mcast getsockopt() path"), > there is a deadlock scenario for IP_ROUTER_ALERT too: > >CPU0CPU1 >

Re: [PATCH resend 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-04-17 Thread David Miller
From: Hauke Mehrtens Date: Wed, 12 Apr 2017 22:31:02 +0200 > __USE_MISC is glibc specific and not available in musl libc. Only do > this check when glibc is used. This fixes a problem with musl libc. > > Acked-by: Mikko Rapeli > Signed-off-by: Hauke

Re: [PATCH net] net-timestamp: avoid use-after-free in ip_recv_error

2017-04-17 Thread David Miller
From: Willem de Bruijn Date: Wed, 12 Apr 2017 19:24:35 -0400 > From: Willem de Bruijn > > Syzkaller reported a use-after-free in ip_recv_error at line > > info->ipi_ifindex = skb->dev->ifindex; > > This function is called on dequeue

Re: [PATCH net-next] l2tp: device MTU setup, tunnel socket needs a lock

2017-04-17 Thread David Miller
From: "R. Parameswaran" Date: Wed, 12 Apr 2017 18:31:04 -0700 (PDT) > > The MTU overhead calculation in L2TP device set-up > merged via commit b784e7ebfce8cfb16c6f95e14e8532d0768ab7ff > needs to be adjusted to lock the tunnel socket while > referencing the sub-data

Re: [PATCH net-next 0/2] qed/qede: aRFS support

2017-04-17 Thread David Miller
From: Manish Chopra Date: Thu, 13 Apr 2017 04:54:43 -0700 > This series adds support for Accelerated Flow Steering > in qede driver for TCP/UDP over IPv4/IPv6 protocols. > > Please consider applying this series to "net-next" Series applied, thanks.

Re: [PATCH net-next v2] Subject: net: allow configuring default qdisc

2017-04-17 Thread David Miller
From: Stephen Hemminger Date: Thu, 13 Apr 2017 08:40:53 -0700 > Since 3.12 it has been possible to configure the default queuing > discipline via sysctl. This patch adds ability to configure the > default queue discipline in kernel configuration. This is useful for >

Re: [PATCH 2/2] net: phy: simplify phy_supported_speeds()

2017-04-17 Thread David Miller
From: Russell King Date: Thu, 13 Apr 2017 16:49:20 +0100 > Simplify the loop in phy_supported_speeds(). > > Signed-off-by: Russell King Also applied to net-next, thanks.

Re: [PATCH 1/2] net: phy: improve phylib correctness for non-autoneg settings

2017-04-17 Thread David Miller
From: Russell King Date: Thu, 13 Apr 2017 16:49:15 +0100 > phylib has some undesirable behaviour when forcing a link mode through > ethtool. phylib uses this code: > > idx = phy_find_valid(phy_find_setting(phydev->speed, phydev->duplex), >

Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

2017-04-17 Thread David Miller
From: Grygorii Strashko Date: Thu, 13 Apr 2017 14:11:27 -0500 > Now the command: > ethtool --phy-statistics eth0 > will cause system crash with meassage "Unable to handle kernel NULL pointer > dereference at virtual address 0010" from: > > (kszphy_get_stats)

Re: [PATCH] net/ncsi: fix checksum validation in response packet

2017-04-17 Thread David Miller
From: Cédric Le Goater Date: Fri, 14 Apr 2017 10:56:37 +0200 > htonl was used instead of ntohl. Surely a typo. > > Signed-off-by: Cédric Le Goater I don't think so, "checksum" is of type "u32" thus is in host byte order. Therefore "htonl()" is correct.

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jamal Hadi Salim
On 17-04-17 11:31 AM, Jiri Pirko wrote: Mon, Apr 17, 2017 at 03:10:59PM CEST, eric.duma...@gmail.com wrote: On Mon, 2017-04-17 at 07:01 -0400, Jamal Hadi Salim wrote: Agreed. Plus the argument that attributes are "a big waste" sounds to me really silly. What is couple of bytes?Please do

Re: [PATCH net-next] net: ipv6: send unsolicited NA on admin up

2017-04-17 Thread David Miller
From: David Ahern Date: Wed, 12 Apr 2017 11:49:04 -0700 > ndisc_notify is the ipv6 equivalent to arp_notify. When arp_notify is > set to 1, gratuitous arp requests are sent when the device is brought up. > The same is expected when ndisc_notify is set to 1 (per

Re: [patch net-next] MAINTAINERS: rename TC entry and add couple of header files

2017-04-17 Thread Jamal Hadi Salim
On 17-04-13 12:13 PM, Jiri Pirko wrote: From: Jiri Pirko The section is not specific only to "TC classifiers", but applies to the whole TC subsystem. Also, add couple of forgotten headers. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim

Re: [PATCH v4] smsc95xx: Add comments to the registers definition

2017-04-17 Thread David Miller
From: Martin Wetterwald Date: Thu, 13 Apr 2017 10:08:44 +0200 > This chip is used by a lot of embedded devices and also by the Raspberry > Pi 1, 2 & 3 which were created to promote the study of computer > sciences. Students wanting to learn kernel / network device driver >

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Jiri Pirko
Mon, Apr 17, 2017 at 06:46:17PM CEST, j...@mojatatu.com wrote: >On 17-04-17 11:31 AM, Jiri Pirko wrote: >> Mon, Apr 17, 2017 at 03:10:59PM CEST, eric.duma...@gmail.com wrote: >> > On Mon, 2017-04-17 at 07:01 -0400, Jamal Hadi Salim wrote: > >> Agreed. >> >> Plus the argument that attributes are

Re: [PATCH] net: thunderx: Fix set_max_bgx_per_node for 81xx rgx

2017-04-17 Thread David Miller
From: George Cherian Date: Thu, 13 Apr 2017 07:25:01 + > Add the PCI_SUBSYS_DEVID_81XX_RGX and use the same to set > the max bgx per node count. > > This fixes the issue intoduced by following commit > 78aacb6f6 net: thunderx: Fix invalid mac addresses for node1

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-17 Thread Eric Dumazet
On Mon, 2017-04-17 at 12:46 -0400, Jamal Hadi Salim wrote: > Of course it is trivial to add this as attributes and 32 bits > for this case is not a big deal because it is done once. I want to talk > about the pads instead ;-> What do you suggest we do with pads? We do nothing with pads. Just

Re: [patch net-next] MAINTAINERS: rename TC entry and add couple of header files

2017-04-17 Thread David Miller
From: Jiri Pirko Date: Thu, 13 Apr 2017 18:13:51 +0200 > From: Jiri Pirko > > The section is not specific only to "TC classifiers", but applies to the > whole TC subsystem. Also, add couple of forgotten headers. > > Signed-off-by: Jiri Pirko

Re: [PATCH net] net: vrf: Fix setting NLM_F_EXCL flag when adding l3mdev rule

2017-04-17 Thread David Miller
From: David Ahern Date: Thu, 13 Apr 2017 10:57:15 -0600 > Only need 1 l3mdev FIB rule. Fix setting NLM_F_EXCL in the nlmsghdr. > > Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create") > Signed-off-by: David Ahern

  1   2   >