[PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i is a heavy hacked version of stmmac hardware by allwinner. In fact the only common part is the descriptor management and the first register function. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 11 +

[PATCH v6 06/21] arm: sun8i: sunxi-h3-h5: Add dt node for the syscon control module

2017-05-31 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner H3/H5 Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock.. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 ++

[PATCH v6 07/21] arm: sun8i: sunxi-h3-h5: add dwmac-sun8i ethernet driver

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the dwmac-sun8i on Allwinner H3/H5 SoC Device-tree. SoC H3/H5 have an internal PHY, so optionals syscon and ephy are set. Signed-off-by: Corentin Labbe ---

[PATCH v6 09/21] arm: sun8i: orangepi-zero: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI Zero. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH net] mpls: fix clearing of dead nh_flags on link up

2017-05-31 Thread Roopa Prabhu
From: Roopa Prabhu recent fixes to use WRITE_ONCE for nh_flags on link up, accidently ended up leaving the deadflags on a nh. This patch fixes the WRITE_ONCE to use freshly evaluated nh_flags. Fixes: 39eb8cd17588 ("net: mpls: rt_nhn_alive and nh_flags should be

[PATCH] mISDN: Fix a sleep-in-atomic bug

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a read spin lock, and the function call path is: send_socklist (acquire the lock by read_lock) skb_copy(GFP_KERNEL) --> may sleep To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC". Signed-off-by: Jia-Ju Bai ---

[PATCH v6 18/21] arm64: allwinner: bananapi-m64: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the BananaPi M64. It uses an external PHY rtl8211e via RGMII. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH v6 13/21] arm: sun8i: nanopi-neo: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the NanoPi Neo. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v6 10/21] arm: sun8i: orangepi-one: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI One. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 21/21] arm64: defconfig: Enable dwmac-sun8i driver on defconfig

2017-05-31 Thread Corentin Labbe
Enable the dwmac-sun8i ethernet driver as a module in the ARM64 defconfig. Signed-off-by: Corentin Labbe --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH v6 20/21] arm: multi_v7: Enable dwmac-sun8i driver on multi_v7_defconfig

2017-05-31 Thread Corentin Labbe
Enable the dwmac-sun8i driver in the multi_v7 default configuration Signed-off-by: Corentin Labbe --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig

[PATCH v6 17/21] arm64: allwinner: pine64-plus: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the pine64 plus. It uses an external PHY rtl8211e via RGMII. Signed-off-by: Corentin Labbe --- .../arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff

[PATCH v6 19/21] arm: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig

2017-05-31 Thread Corentin Labbe
Enable the dwmac-sun8i driver in the sunxi default configuration Signed-off-by: Corentin Labbe --- arch/arm/configs/sunxi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig index

[PATCH v6 00/21] net-next: stmmac: add dwmac-sun8i ethernet driver

2017-05-31 Thread Corentin Labbe
Hello This patch series add the driver for dwmac-sun8i which handle the Ethernet MAC present on Allwinner H3/H5/A83T/A64 SoCs. This driver is the continuation of the sun8i-emac driver. During the development, it appeared that in fact the hardware was a modified version of some dwmac. So the

[PATCH v6 03/21] dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-05-31 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Allwinner dwmac-sun8i driver. Signed-off-by: Corentin Labbe Acked-by: Rob Herring --- .../devicetree/bindings/net/dwmac-sun8i.txt| 78 ++ 1 file changed, 78

[PATCH v6 01/21] net-next: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

2017-05-31 Thread Corentin Labbe
Thoses symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, they need to be exported. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH v6 02/21] net-next: stmmac: add optional setup function

2017-05-31 Thread Corentin Labbe
Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- include/linux/stmmac.h

[PATCH v6 08/21] arm: sun8i: orangepi-pc: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI PC. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 04/21] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon

2017-05-31 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the syscon present in allwinner devices. Signed-off-by: Corentin Labbe Acked-by: Rob Herring --- .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++ 1 file

Re: [PULL] topic/e1000e-fix

2017-05-31 Thread Daniel Vetter
On Wed, May 31, 2017 at 7:54 AM, Daniel Vetter wrote: > On Wed, May 31, 2017 at 1:06 AM, Dave Airlie wrote: >> On 31 May 2017 at 08:10, David Miller wrote: >>> From: Daniel Vetter >>> Date: Tue, 30 May 2017

[PATCH v6 11/21] arm: sun8i: orangepi-2: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI 2. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 16/21] arm64: allwinner: pine64: Enable dwmac-sun8i

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the pine64 It uses an external PHY via RMII. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v6 15/21] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver

2017-05-31 Thread Corentin Labbe
The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit connections. It is very similar to the device found in the Allwinner H3, but lacks the internal 100 Mbit PHY and its associated control bits. This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps it disabled at this

[PATCH v6 14/21] arm64: allwinner: sun50i-a64: Add dt node for the syscon control module

2017-05-31 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner A64. Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock. Signed-off-by: Corentin Labbe --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi |

[PATCH v6 12/21] arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high

2017-05-31 Thread Corentin Labbe
On the Orange Pi PC Plus, the polarity of the LEDs on the RJ45 Ethernet port were changed from active low to active high. Signed-off-by: Chen-Yu Tsai Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 5 + 1 file

Re: 'iw events' stops receiving events after a while on 4.9 + hacks

2017-05-31 Thread Bastian Bittorf
* Johannes Berg [31.05.2017 10:09]: > > Is there any way to dump out the socket information if we reproduce > > the problem? > > I have no idea, sorry. > > If you or Bastian can tell me how to reproduce the problem, I can try > to investigate it. there was an

[PATCH net-next 2/2] sctp: merge sctp_stream_new and sctp_stream_init

2017-05-31 Thread Xin Long
Since last patch, sctp doesn't need to alloc memory for asoc->stream any more. sctp_stream_new and sctp_stream_init both are used to alloc memory for stream.in or stream.out, and their names are also confusing. This patch is to merge them into sctp_stream_init, and only pass stream and streamcnt

[PATCH net-next 1/2] sctp: define the member stream as an object instead of pointer in asoc

2017-05-31 Thread Xin Long
As Marcelo's suggestion, stream is a fixed size member of asoc and would not grow with more streams. To avoid an allocation for it, this patch is to define it as an object instead of pointer and update the places using it, also create sctp_stream_update() called in sctp_assoc_update() to migrate

[PATCH net-next 0/2] sctp: improve asoc streams management

2017-05-31 Thread Xin Long
This patchset changes to define asoc->stream as an object, and also improve some codes to make it more clearly. Xin Long (2): sctp: define the member stream as an object instead of pointer in asoc sctp: merge sctp_stream_new and sctp_stream_init include/net/sctp/structs.h | 7 ++--

Re: [PATCH net-next] powerpc: use asm-generic/socket.h as much as possible

2017-05-31 Thread Arnd Bergmann
On Wed, May 31, 2017 at 7:43 AM, Stephen Rothwell wrote: > asm-generic/socket.h already has an exception for the differences that > powerpc needs, so just include it after defining the differences. > > Signed-off-by: Stephen Rothwell Acked-by: Arnd

[PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) ioremap --> may sleep To fix it, the lock is released before "ioremap", and the lock is acquired again after this function. Signed-off-by: Jia-Ju Bai

net/ipv6: use-after-free in ip6_dst_ifdown

2017-05-31 Thread Andrey Konovalov
Hi, I've got the following error report while fuzzing the kernel with syzkaller. On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3). Unfortunately it's not reproducible. == BUG: KASAN: use-after-free in

[PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) b43legacy_synchronize_irq synchronize_irq --> may sleep To fix it, the lock is released before b43legacy_synchronize_irq, and the lock is acquired

Re: [PATCH net-next] netlink: include netnsid only when netns differs.

2017-05-31 Thread Nicolas Dichtel
Le 30/05/2017 à 23:33, Flavio Leitner a écrit : > Don't include netns id for notifications broadcasts when the > socket and the skb are in the same netns because it will be > an error which can't be distinguished from a peer netns failing > to allocate an id. I don't understand the problem.

net/ipv4: use-after-free in add_grec

2017-05-31 Thread Andrey Konovalov
Hi, I've got the following error report while fuzzing the kernel with syzkaller. On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3). Unfortunately it's not reproducible. == BUG: KASAN: use-after-free in

Re: [PATCH net-next] powerpc: use asm-generic/socket.h as much as possible

2017-05-31 Thread Michael Ellerman
Stephen Rothwell writes: > asm-generic/socket.h already has an exception for the differences that > powerpc needs, so just include it after defining the differences. > > Signed-off-by: Stephen Rothwell > --- > arch/powerpc/include/uapi/asm/socket.h

[PATCH net-next] nfp: add MAY_USE_DEVLINK dependency

2017-05-31 Thread Arnd Bergmann
When devlink is configured as a loadable module, a built-in nfp driver causes a link error: drivers/net/built-in.o: In function `nfp_devlink_port_register': (.text+0xb8b05): undefined reference to `devlink_port_type_eth_set' drivers/net/built-in.o: In function `nfp_devlink_port_register':

Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error

2017-05-31 Thread Alexander Potapenko
Hi David, I've noticed that the upstream patch: https://github.com/torvalds/linux/commit/0ff50e83b5122e836ca492fefb11656b225ac29c contains the KMSAN report and the repro, despite I've put them under the triple dash (IIRC Eric told me I shouldn't bloat the patch descriptions with that

Re: [PATCH net-next] nfp: add MAY_USE_DEVLINK dependency

2017-05-31 Thread Jakub Kicinski
On Wed, 31 May 2017 10:16:50 +0200, Arnd Bergmann wrote: > When devlink is configured as a loadable module, a built-in nfp driver > causes a link error: > > drivers/net/built-in.o: In function `nfp_devlink_port_register': > (.text+0xb8b05): undefined reference to `devlink_port_type_eth_set' >

[PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_hw_read_wx_2M and netxen_nic_hw_write_wx_2M

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a write spin lock, and function call path is: netxen_nic_hw_read_wx_2M (acquire the lock by write_lock_irqsave) crb_win_lock netxen_pcie_sem_lock msleep --> may sleep netxen_nic_hw_write_wx_2M (acquire the lock by write_lock_irqsave) crb_win_lock

Dear Friend,

2017-05-31 Thread Ja Ikh
Dear Friend, How are you? I want to inquire from you if you can handle a transaction for mutual benefits/life opportunity for you and me. I am Dr.Jaslin Ikhsan. The Chief International Relation Foreign RemittanceUnit of my bank here in Burkina Faso Ouagadougou Branch. I Have an Opportunity to

[PATCH] net: don't call strlen on non-terminated string in dev_set_alias()

2017-05-31 Thread Alexander Potapenko
KMSAN reported a use of uninitialized memory in dev_set_alias(), which was caused by calling strlcpy() (which in turn called strlen()) on the user-supplied non-terminated string. Signed-off-by: Alexander Potapenko --- For the record, here is the KMSAN report:

[PATCH v2] net: don't call strlen on non-terminated string in dev_set_alias()

2017-05-31 Thread Alexander Potapenko
KMSAN reported a use of uninitialized memory in dev_set_alias(), which was caused by calling strlcpy() (which in turn called strlen()) on the user-supplied non-terminated string. Signed-off-by: Alexander Potapenko --- v2: fixed an off-by-one error spotted by Dmitry Vyukov For

[PATCH v2 1/2] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties

2017-05-31 Thread Leonard Crestez
Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same register values can be set through the micrel phy driver by using dts properties. This seems preferable and allows cleanly fixing suspend/resume. Signed-off-by: Leonard Crestez Reviewed-by: Fabio

[PATCH v2 0/2] ARM: imx6ul-14x14-evk: Fix suspend over nfs by phy

2017-05-31 Thread Leonard Crestez
Right now attempting doing suspend/resume while root is mounted over NFS hangs on imx6ul-14x14-evk. This is happening because ksz8081 phy fixups are lost on resume. Fix this by using equivalent devicetree properties instead of a phy fixup and handling those properties on resume in the micrel

[net-next 8/9] i40e: check for Tx timestamp timeouts during watchdog

2017-05-31 Thread Jeff Kirsher
From: Jacob Keller The i40e driver has logic to handle only one Tx timestamp at a time, using a state bit lock to avoid multiple requests at once. It may be possible, if incredibly unlikely, that a Tx timestamp event is requested but never completes. Since we use an

[net-next 7/9] i40e: use pf data structure directly in i40e_ptp_rx_hang

2017-05-31 Thread Jeff Kirsher
From: Jacob Keller There's no reason to pass a *vsi pointer if we already have the *pf pointer in the only location where we call this function. Lets update the signature and directly pass the *pf data structure pointer. Signed-off-by: Jacob Keller

[net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2017-05-31

2017-05-31 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Jesse provides a couple of fixes, starting with cleaning up duplicate lines of code. Fixed a missing line which enables RSS as a negotiated feature. Since the VF does not have any way of reporting FCoE enabled, so just force the code to

[net-next 4/9] i40e: fix race condition with PTP_TX_IN_PROGRESS bits

2017-05-31 Thread Jeff Kirsher
From: Jacob Keller Hardware related to the i40e driver has a limitation on Tx PTP packets. This requires us to limit the driver to timestamping a single packet at once. This is done using a state bitlock which enforces that only one timestamp request is honored at a

[net-next 6/9] i40e: add statistic indicating number of skipped Tx timestamps

2017-05-31 Thread Jeff Kirsher
From: Jacob Keller The i40e driver can only handle one Tx timestamp request at a time. This means it is possible for an application timestamp request to be ignored. There is no easy way for an administrator to determine if this occurred. Add a new statistic which

[net-next 3/9] i40evf: disable unused flags

2017-05-31 Thread Jeff Kirsher
From: Jesse Brandeburg The i40evf hardware doesn't have any way to ever report FCoE enabled so just force the code to always report FCoE is disabled, remove the unused defines, and mark the OP as reserved. Signed-off-by: Jesse Brandeburg

[net-next 5/9] i40e: avoid permanent lock of *_PTP_TX_IN_PROGRESS

2017-05-31 Thread Jeff Kirsher
From: Jacob Keller The i40e driver uses a bit lock to indicate when a Tx timestamp is in progress to avoid attempting to timestamp multiple packets at once. This is required because hardware only has registers to handle one request at a time. There is a corner case

[net-next 1/9] i40evf: fix duplicate lines

2017-05-31 Thread Jeff Kirsher
From: Jesse Brandeburg This removes two duplicate lines that snuck into the code somehow. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

Re: [PATCH net-next] powerpc: use asm-generic/socket.h as much as possible

2017-05-31 Thread Stephen Rothwell
Hi Michael, On Wed, 31 May 2017 20:15:55 +1000 Michael Ellerman wrote: > > Stephen Rothwell writes: > > > asm-generic/socket.h already has an exception for the differences that > > powerpc needs, so just include it after defining the differences. > >

[PATCH net] cxgb4: avoid enabling napi twice to the same queue

2017-05-31 Thread Ganesh Goudar
Take uld mutex to avoid race between cxgb_up() and cxgb4_register_uld() to enable napi for the same uld queue. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH net] samples/bpf: bpf_load.c order of prog_fd[] should correspond with ELF order

2017-05-31 Thread David Miller
From: Jesper Dangaard Brouer Date: Tue, 30 May 2017 14:37:51 +0200 > An eBPF ELF file generated with LLVM can contain several program > section, which can be used for bpf tail calls. The bpf prog file > descriptors are accessible via array prog_fd[]. > > At-least XDP samples

Re: [PATCH net-next] rtnetlink: use the new rtnl_get_event() interface

2017-05-31 Thread David Miller
From: Vladislav Yasevich Date: Tue, 30 May 2017 10:07:02 -0400 > Small clean-up to rtmsg_ifinfo() to use the rtnl_get_event() > interface instead of using 'internal' values directly. > > Signed-off-by: Vladislav Yasevich Applied, thanks Vlad.

[PATCH net-next, 1/2] tools: hv: set allow-hotplug for VF on Ubuntu

2017-05-31 Thread Simon Xiao
On HyperV, the VF interface can be offered by a host at any time. Mark the VF interface as hotplug, to make sure it will be brought up automatically when it is registered. Signed-off-by: Simon Xiao Reviewed-by: Haiyang Zhang --- tools/hv/bondvf.sh

[PATCH net-next, 2/2] tools: hv: set hotplug for VF on Suse

2017-05-31 Thread Simon Xiao
On HyperV, the VF interface can be offered by a host at any time. Mark the VF interface as hotplug, to make sure it will be brought up automatically when it is registered. Signed-off-by: Simon Xiao Reviewed-by: Haiyang Zhang --- tools/hv/bondvf.sh

Re: net/ipv4: use-after-free in add_grec

2017-05-31 Thread Eric Dumazet
On Wed, 2017-05-31 at 11:46 +0200, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3). > > Unfortunately it's not reproducible. > >

Re: net/ipv6: use-after-free in ip6_dst_ifdown

2017-05-31 Thread Eric Dumazet
On Wed, May 31, 2017 at 9:45 AM, Cong Wang wrote: > On Wed, May 31, 2017 at 2:42 AM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-05-31 Thread David Miller
From: Florian Westphal Date: Tue, 30 May 2017 11:38:12 +0200 > Quoting Joe Stringer: > If a user loads nf_conntrack_ftp, sends FTP traffic through a network > namespace, destroys that namespace then unloads the FTP helper module, > then the kernel will crash. > > Events

Re: [PULL] topic/e1000e-fix

2017-05-31 Thread David Miller
From: Daniel Vetter Date: Wed, 31 May 2017 08:10:45 +0200 > On Wed, May 31, 2017 at 7:54 AM, Daniel Vetter wrote: >> On Wed, May 31, 2017 at 1:06 AM, Dave Airlie wrote: >>> On 31 May 2017 at 08:10, David Miller

Re: [PATCH v2] net: don't call strlen on non-terminated string in dev_set_alias()

2017-05-31 Thread Stephen Hemminger
On Wed, 31 May 2017 14:51:50 +0200 Alexander Potapenko wrote: > + /* alias comes from the userspace and may not be zero-terminated. > + */ > + memcpy(dev->ifalias, alias, len); You don't need a multi-line comment here.

Re: [PULL] topic/e1000e-fix

2017-05-31 Thread Jani Nikula
On Wed, 31 May 2017, David Miller wrote: > And we can't understand why respinning with the requested change is > less work than making several postings such as this one. When our CI hits tons of non-drm issues every merge window, I imagine our developers can start to get a

[PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-05-31 Thread Jani Nikula
From: Chris Wilson An error during suspend (e100e_pm_suspend), [ 429.994338] ACPI : EC: event blocked [ 429.994633] e1000e: EEE TX LPI TIMER: 0011 [ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2 [ 430.955454] dpm_run_callback():

Re: [PATCH net-next 0/3] net: dsa: mv88e6xxx: PHY nitpicks

2017-05-31 Thread David Miller
From: Vivien Didelot Date: Fri, 26 May 2017 18:03:04 -0400 > This patchset isolates more PPU code into phy.c and makes distinction > between PHY Registers read and write implementations vs. generic PHY > routines. Series applied, thanks.

Re: [PATCH net-next] net: dsa: remove dev arg of dsa_register_switch

2017-05-31 Thread David Miller
From: Vivien Didelot Date: Fri, 26 May 2017 18:12:51 -0400 > The current dsa_register_switch function takes a useless struct device > pointer argument, which always equals ds->dev. > > Drivers either call it with ds->dev, or with the same device pointer >

[PATCH net-next] liquidio: VF interrupt initialization cleanup

2017-05-31 Thread Felix Manlunas
From: Rick Farrington Set initialization state variable to (reflect interrupt initialization) at correct time (immediately after having configured interrupts). This fixes problem of inconsistent IRQ allocation in case of [obscure] failure when negotiating with PF

Re: [PATCH net-next 2/3] udp: avoid a cache miss on dequeue

2017-05-31 Thread Eric Dumazet
On Mon, 2017-05-29 at 17:27 +0200, Paolo Abeni wrote: > Since UDP no more uses sk->destructor, we can clear completely > the skb head state before enqueuing. ... > @@ -1739,6 +1740,9 @@ static int __udp_queue_rcv_skb(struct sock *sk, struct > sk_buff *skb) >

Re: [PATCH net-next] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread kbuild test robot
Hi Sowmini, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Sowmini-Varadhan/neigh-Really-delete-an-arp-neigh-entry-on-ip-neigh-delete-or-arp-d/20170531-235737 config: x86_64-allyesdebian (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Larry Finger
On 05/31/2017 05:29 AM, Jia-Ju Bai wrote: The driver may sleep under a spin lock, and the function call path is: b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) b43legacy_radio_set_interference_mitigation b43legacy_radio_interference_mitigation_disable

[PATCH net-next 7/9] nfp: move bpf offload code to the BPF app

2017-05-31 Thread Jakub Kicinski
Move bulk of the eBPF offload code out of common vNIC code into app-specific callbacks. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/main.c | 84 ++ drivers/net/ethernet/netronome/nfp/bpf/main.h | 5 ++

[PATCH net-next 6/9] nfp: move eBPF offload files to BPF app directory

2017-05-31 Thread Jakub Kicinski
Pure move of eBPF offload files to BPF app directory, only change the names and relative header location. nfp_asm.h stays in the main dir and it doesn't really have to include nfp_bpf.h. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile

[PATCH net-next 8/9] nfp: move basic eBPF stats to app-specific code

2017-05-31 Thread Jakub Kicinski
Allow apps to associate private data with vNICs and move BPF-specific fields of nfp_net to such structure. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/main.c | 19 - drivers/net/ethernet/netronome/nfp/bpf/main.h | 18

[PATCH net-next 9/9] nfp: fix memory leak on FW load error

2017-05-31 Thread Jakub Kicinski
Free management FW info when app FW load failed. Fixes: eefbde7e1002 ("nfp: add hwmon support") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net-next 2/9] nfp: add missing fall through statements

2017-05-31 Thread Jakub Kicinski
GCC 7 checks for fall through comments, add the two missing ones. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c

[PATCH net-next 4/9] nfp: move port init to apps

2017-05-31 Thread Jakub Kicinski
Start fleshing out the apps by turning the vNIC init code to a per-app callback. The two initial apps we have are NIC and eBPF. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile | 5 +-

[PATCH net-next 5/9] nfp: report app name in ethtool -i

2017-05-31 Thread Jakub Kicinski
Let the app print its name in ethtool -i output. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/main.c| 1 + drivers/net/ethernet/netronome/nfp/nfp_app.c | 2 +- drivers/net/ethernet/netronome/nfp/nfp_app.h | 9

[PATCH net-next 3/9] nfp: turn reading PCIe RTsym parameters into a helper

2017-05-31 Thread Jakub Kicinski
Turn the function to read number of ports into a generic helper. While at it make sure we propagate all errors other than -ENOENT. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 24 --- 1 file changed, 17

[PATCH net-next 1/9] sched: add helper for updating statistics on all actions

2017-05-31 Thread Jakub Kicinski
Forgetting to disable preemption around tcf_action_stats_update() seems to be a common mistake. Add a helper function for updating stats on all actions of a filter. Signed-off-by: Jakub Kicinski --- CC: Jiri Pirko CC: Jamal Hadi Salim

Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error

2017-05-31 Thread Alexander Potapenko
On Wed, May 31, 2017 at 5:10 PM, David Miller wrote: > From: Alexander Potapenko > Date: Wed, 31 May 2017 10:56:47 +0200 > >> Hi David, >> >> I've noticed that the upstream patch: >>

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 18:29:07 +0800 Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) > b43legacy_radio_set_interference_mitigation >

Re: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Rob Herring
On Tue, May 23, 2017 at 11:48:08AM +0200, Quentin Schulz wrote: > Some PHY require to wait for a bit after the reset GPIO has been > toggled. This adds support for the DT property `phy-reset-post-delay` > which gives the delay in milliseconds to wait after reset. > > If the DT property is not

[PATCH net-next 0/9] nfp: move BPF offload code into app

2017-05-31 Thread Jakub Kicinski
Hi! This series moves the eBPF offload code out of netdev/vNIC handling and starts building the nfp_app. Port init is moved into the apps as well because various apps associate vNICs, representors with ports differently. First patch adds a helper for updating tc stats which has been waiting in

[PATCH] net: davicom: dm9000: Avoid spinlock recursion during dm9000_timeout routine

2017-05-31 Thread Liu Xiang
On the DM9000B, dm9000_phy_write() is called after the main spinlock is held, during the dm9000_timeout() routine. Spinlock recursion occurs because the main spinlock is requested again in dm9000_phy_write(). So spinlock should be avoided in dm9000_phy_write() during the dm9000_timeout() routine.

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: > Jia-Ju Bai writes: > > > The driver may sleep under a spin lock, and the function call path is: > > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > >

Re: [PULL] topic/e1000e-fix

2017-05-31 Thread Daniel Vetter
On Wed, May 31, 2017 at 5:08 PM, David Miller wrote: > From: Daniel Vetter > Date: Wed, 31 May 2017 08:10:45 +0200 > >> On Wed, May 31, 2017 at 7:54 AM, Daniel Vetter >> wrote: >>> On Wed, May 31, 2017 at 1:06 AM, Dave Airlie

Re: [PATCH net-next 0/3] udp: reduce cache pressure

2017-05-31 Thread Eric Dumazet
On Wed, May 31, 2017 at 9:47 AM, David Miller wrote: > > Eric can you give this a quick review when you get a chance? Sure, will do in a few minutes. Thanks.

Re: [PATCH net-next 3/3] udp: try to avoid 2 cache miss on dequeue

2017-05-31 Thread Eric Dumazet
On Mon, 2017-05-29 at 17:27 +0200, Paolo Abeni wrote: > when udp_recvmsg() is executed, on x86_64 and other archs, most skb > fields are on cold cachelines. > If the skb are linear and the kernel don't need to compute the udp > csum, only a handful of skb fields are required by udp_recvmsg(). >

Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error

2017-05-31 Thread David Miller
From: Alexander Potapenko Date: Wed, 31 May 2017 10:56:47 +0200 > Hi David, > > I've noticed that the upstream patch: > https://github.com/torvalds/linux/commit/0ff50e83b5122e836ca492fefb11656b225ac29c > contains the KMSAN report and the repro, despite I've put them under >

Re: [PATCH RFC net-next] arp: Really delete an arp entry on "arp -d"

2017-05-31 Thread Sowmini Varadhan
On (05/30/17 18:42), David Ahern wrote: > It has been noticed. I have not sent a patch since adjusting gc > parameters will reclaim FAILED entries at whatever rate the user wants. Overly aggressive garbage collection will delete other (non-FAILED) entries as well, and can trigger needless re-ARP

Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-31 Thread Sebastian Ott
Hi, A system running v4.12-rc3-11-gf511c0b on s390 hangs after boot with no messages on the console. The message buffer obtained via a system dump looked like this: [...] [ 17.870712] virbr0: port 1(virbr0-nic) entered disabled state [ 19.618523] Unable to handle kernel pointer dereference

Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing

2017-05-31 Thread David Miller
From: Andy Shevchenko Date: Tue, 30 May 2017 21:48:05 +0300 > On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka wrote: >> Some cleanups of the way we probe DMI platforms in the driver. Reduces >> a bit of open-coding and makes the logic easier

Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC

2017-05-31 Thread David Miller
From: Arnd Bergmann Date: Tue, 30 May 2017 11:26:14 +0200 > The new mlxfw code fails to build without the xz library: > > drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.o: In function > `mlxfw_mfa2_xz_dec_run': > :(.text.mlxfw_mfa2_xz_dec_run+0x8): undefined reference to

Re: [PATCH net-next 0/9] bpf: stack depth tracking

2017-05-31 Thread David Miller
From: Alexei Starovoitov Date: Tue, 30 May 2017 13:31:26 -0700 > Introduce tracking of bpf program stack depth in the verifier and use that > info to reduce bpf program stack consumption in the interpreter and x64 JIT. > Other JITs can take advantage of it as well in the future. >

[PATCH V4] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Sowmini Varadhan
The command # arp -s 62.2.0.1 a:b:c:d:e:f dev eth2 adds an entry like the following (listed by "arp -an") ? (62.2.0.1) at 0a:0b:0c:0d:0e:0f [ether] PERM on eth2 but the symmetric deletion command # arp -i eth2 -d 62.2.0.1 does not remove the PERM entry from the table, and instead leaves

Re: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Florian Fainelli
Le 05/31/17 à 18:39, Andy Duan a écrit : > From: Rob Herring Sent: Thursday, June 01, 2017 12:44 AM >> On Tue, May 23, 2017 at 11:48:08AM +0200, Quentin Schulz wrote: >>> Some PHY require to wait for a bit after the reset GPIO has been >>> toggled. This adds support for the DT

[PATCH] cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cw1200_tx_confirm_cb (acquire the lock by spin_lock) __cw1200_cqm_bssloss_sm cancel_work_sync --> may sleep cw1200_cqm_bssloss_sm __cw1200_cqm_bssloss_sm cancel_work_sync --> may sleep To fix it, the lock is

[PATCH net-next] bpf: Take advantage of stack_depth tracking in sparc64 JIT

2017-05-31 Thread David Miller
Signed-off-by: David S. Miller --- Committed to net-next. arch/sparc/net/bpf_jit_comp_64.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c index 4a52d34..098874a 100644 ---

  1   2   3   >