Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

2017-07-06 Thread Cong Wang
On Thu, Jul 6, 2017 at 5:08 AM, Nicolas Dichtel wrote: > Le 06/07/2017 à 00:43, Cong Wang a écrit : >> On Wed, Jul 5, 2017 at 8:57 AM, Nicolas Dichtel >> wrote: >>> When a device changes from one netns to another, it's first unregistered, >>>

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Alan Stern
On Thu, 6 Jul 2017, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 12:49:12PM -0400, Alan Stern wrote: > > On Thu, 6 Jul 2017, Paul E. McKenney wrote: > > > > > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney

Re: ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Erik Stromdahl
With gcc 4.1.2: drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_mbox_rxmsg_pending_handler’: drivers/net/wireless/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function + + *done = true; + + /* Copy the lookahead obtained from the HTC

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Peter Zijlstra
On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 02:12:24PM +, David Laight wrote: > > > From: Paul E. McKenney > > [ . . . ] > > > Now on the one hand I feel like Oleg that it

Re: [PATCH v2] mwifiex: uninit wakeup info in the error handling

2017-07-06 Thread Brian Norris
On Thu, Jul 06, 2017 at 03:55:28PM +0800, Jeffy Chen wrote: > We inited wakeup info at the beginning of mwifiex_add_card, so we need > to uninit it in the error handling. > > It's much the same as what we did in: > 36908c4 mwifiex: uninit wakeup info when removing device > > Signed-off-by: Jeffy

Re: [PATCH 0/2] bring UP loopback device at initialziation

2017-07-06 Thread महेश बंडेवार
On Thu, Jul 6, 2017 at 5:18 AM, Eric W. Biederman wrote: > "Mahesh Bandewar (महेश बंडेवार)" writes: > >>> I wonder if it is too late to change this since this behavior is probably >>> from the beginning of network namespace. A networkless netns is also

Re: [PATCH net-next RFC 03/12] net: dsa: Remove switchdev dependency from DSA switch notifier chain

2017-07-06 Thread Vivien Didelot
Arkadi Sharshevsky writes: > Currently, the switchdev objects are embedded inside the DSA notifier > info. This patch removes this dependency. This is done as a preparation > stage before adding support for learning FDB through the switchdev > notification chain. > >

Re: [PATCH v2 1/9] net/netfilter/nf_conntrack_core: Fix net_conntrack_lock()

2017-07-06 Thread Manfred Spraul
Hi Paul, On 07/06/2017 01:31 AM, Paul E. McKenney wrote: From: Manfred Spraul As we want to remove spin_unlock_wait() and replace it with explicit spin_lock()/spin_unlock() calls, we can use this to simplify the locking. In addition: - Reading nf_conntrack_locks_all

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-07-06 Thread Casey Leedom
| From: Jakub Kicinski | Sent: Wednesday, June 28, 2017 6:00 PM |   | On Wed, 28 Jun 2017 14:47:51 -0700, Dustin Byford wrote: | > | > You're not the first, or the second to ask that question.  I agree it | > could use clarification. | > | > I always read auto in this context

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Peter Zijlstra
On Thu, Jul 06, 2017 at 09:24:12AM -0700, Paul E. McKenney wrote: > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > And yes, there are architecture-specific optimizations for an > > > empty

Re: [PATCH v2 1/9] net/netfilter/nf_conntrack_core: Fix net_conntrack_lock()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 08:45:59PM +0200, Manfred Spraul wrote: > Hi Paul, > > On 07/06/2017 01:31 AM, Paul E. McKenney wrote: > >From: Manfred Spraul > > > >As we want to remove spin_unlock_wait() and replace it with explicit > >spin_lock()/spin_unlock() calls, we can

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:08:50PM +0100, Will Deacon wrote: > On Thu, Jul 06, 2017 at 06:50:36PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > > > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > > > On Thu, Jul 06, 2017 at

[PATCH v1 1/1] dt-binding: ptp: Add SoC compatibility strings for dte ptp clock

2017-07-06 Thread Arun Parameswaran
Add SoC specific compatibility strings to the Broadcom DTE based PTP clock binding document. Fixed the document heading and node name. Fixes: 80d6076140b2 ("dt-binding: ptp: add bindings document for dte based ptp clock") Signed-off-by: Arun Parameswaran ---

Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

2017-07-06 Thread Willem de Bruijn
On Thu, Jul 6, 2017 at 10:43 AM, David Miller wrote: > From: Willem de Bruijn > Date: Wed, 5 Jul 2017 12:27:11 -0400 > --- a/net/ipv4/udp_offload.c +++ b/net/ipv4/udp_offload.c @@ -21,7 +21,7 @@ static struct sk_buff

Re: [PATCH net-next RFC 02/12] net: dsa: Remove prepare phase for FDB

2017-07-06 Thread Vivien Didelot
Arkadi Sharshevsky writes: > The prepare phase for FDB add is unneeded because most of DSA devices > can have failures during bus transactions (SPI, I2C, etc.), thus, the > prepare phase cannot guarantee success of the commit stage. > > The support for learning FDB through

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-07-06 Thread Jakub Kicinski
On Thu, 6 Jul 2017 18:53:42 +, Casey Leedom wrote: > However, the first question which pops up is: what happens if a user > explicitly selects a particular FEC for from the set offered by the > current Transceiver Module, and then swap out Transceiver Modules to > one which doesn't support

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Alan Stern
On Thu, 6 Jul 2017, Paul E. McKenney wrote: > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > And yes, there are architecture-specific optimizations for an > > > empty spin_lock()/spin_unlock() critical

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-06 Thread Bjorn Helgaas
On Thu, Jul 06, 2017 at 08:58:51PM +0800, Ding Tianhong wrote: > Hi Bjorn: > > Could you please give some feedback about this patchset, it looks like no > more comments for more than a week, > thanks. :) I was on vacation when you posted it, but don't worry, it's still in the queue:

Re: [PATCHv2 1/3] ethtool: stmmac: Fix Designware ethtool register dump

2017-07-06 Thread Thor Thayer
On 06/28/2017 10:13 AM, thor.tha...@linux.intel.com wrote: From: Thor Thayer The commit fbf68229ffe7 ("net: stmmac: unify registers dumps methods") in the Linux kernel modified the register dump to store the DMA registers at the DMA register offset (0x1000) but

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:41:34PM +0200, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 09:24:12AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > > And yes, there are

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:50:36PM +0200, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 02:12:24PM +, David Laight wrote: > > > > From: Paul E. McKenney

Re: [Patch net] tap: convert a mutex to a spinlock

2017-07-06 Thread Cong Wang
On Thu, Jul 6, 2017 at 1:24 AM, Eric Dumazet wrote: > On Wed, 2017-07-05 at 13:50 -0700, Cong Wang wrote: >> We are not allowed to block on the RCU reader side, so can't >> just hold the mutex as before. As a quick fix, convert it to >> a spinlock. >> >> Fixes:

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-06 Thread Edward Cree
On 04/07/17 23:28, Daniel Borkmann wrote: > Have you tried with cilium's BPF code? The kernel selftests are quite small, > so not really pushing processed insns too far. I can send you a BPF obj file > if that's easier for testing. Results from the next (in-progress) version of the patch series,

Re: [PATCH 0/2] bring UP loopback device at initialziation

2017-07-06 Thread Cong Wang
On Wed, Jul 5, 2017 at 4:01 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > > Now that you have made me aware of some use cases that do want the > loopback device to be DOWN, could we use a global sysctl to dictate > the loopback behavior during init? e.g. Yeah, it is never about

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-06 Thread Manfred Spraul
Hi Alan, On 07/03/2017 09:57 PM, Alan Stern wrote: (Alternatively, you could make nf_conntrack_all_unlock() do a lock+unlock on all the locks in the array, just like nf_conntrack_all_lock(). But of course, that would be a lot less efficient.) H. Someone with a weakly ordered system who

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-07-06 Thread Casey Leedom
| From: Jakub Kicinski | Sent: Thursday, July 6, 2017 12:02 PM | | IMHO if something gets replugged all the settings should be reset. | I feel that it's not entirely unlike replugging a USB adapter. Perhaps | we should introduce some (devlink) notifications for SFP module events

RE: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-07-06 Thread Wyborny, Carolyn
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jakub Kicinski > Sent: Thursday, July 06, 2017 12:02 PM > To: Casey Leedom > Cc: Dustin Byford ; Andrew Lunn > ;

RE: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-07-06 Thread Wyborny, Carolyn
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Casey Leedom > Sent: Thursday, July 06, 2017 2:54 PM > To: Jakub Kicinski > Cc: Dustin Byford ; Andrew Lunn > ; Roopa

Re: [iovisor-dev] [PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-07-06 Thread Nadav Amit
Edward Cree via iovisor-dev wrote: > Tracks value alignment by means of tracking known & unknown bits. > Tightens some min/max value checks and fixes a couple of bugs therein. > If pointer leaks are allowed, and adjust_ptr_min_max_vals returns -EACCES, > treat the

Re: [PATCH net-next RFC 08/12] net: dsa: Remove support for bypass bridge port attributes/vlan set

2017-07-06 Thread Florian Fainelli
On 07/06/2017 04:00 AM, Arkadi Sharshevsky wrote: > > > On 07/05/2017 10:45 PM, Florian Fainelli wrote: >> On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: >>> The bridge port attributes/vlan for DSA devices should be set only >>> from bridge code. Furthermore, The vlans are synced totally with

[Patch net] wl1251: add a missing spin_lock_init()

2017-07-06 Thread Cong Wang
This fixes the following kernel warning: [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 [ 5668.771850] lock: 0xce63ef20, .magic: , .owner: /-1, .owner_cpu: 0 [ 5668.772277] CPU: 0 PID: 9745 Comm: kworker/u2:3 Tainted: GW 4.12.0-03002-gec979a4-dirty

[Patch net] bonding: avoid NETDEV_CHANGEMTU event when unregistering slave

2017-07-06 Thread Cong Wang
As Hongjun/Nicolas summarized in their original patch: " When a device changes from one netns to another, it's first unregistered, then the netns reference is updated and the dev is registered in the new netns. Thus, when a slave moves to another netns, it is first unregistered. This triggers a

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-07-06 Thread Andrew Lunn
On Thu, Jul 06, 2017 at 09:53:46PM +, Casey Leedom wrote: > | From: Jakub Kicinski > | Sent: Thursday, July 6, 2017 12:02 PM > | > | IMHO if something gets replugged all the settings should be reset. > | I feel that it's not entirely unlike replugging a USB adapter. Perhaps >

[PATCH] mwifiex: fix compile warning of unused variable

2017-07-06 Thread Shawn Lin
We got a compile warning shows below: drivers/net/wireless/marvell/mwifiex/sdio.c: In function 'mwifiex_sdio_remove': drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] Per the code, it didn't check if

Re: [PATCH] mwifiex: fix compile warning of unused variable

2017-07-06 Thread Kalle Valo
Shawn Lin writes: > We got a compile warning shows below: > > drivers/net/wireless/marvell/mwifiex/sdio.c: In function > 'mwifiex_sdio_remove': > drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable > 'ret' set but not used [-Wunused-but-set-variable] >

[PATCH v10 05/15] mlx4: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v10 07/15] wireless: ipw2200: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/net/wireless/intel/ipw2x00/ipw2200.c |

[PATCH v10 12/15] scsi: mpt3sas: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 73

[PATCH v10 13/15] scsi: mvsas: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- drivers/scsi/mvsas/mv_init.c | 6 +++---

[PATCH v10 14/15] scsi: pmcraid: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v10 01/15] block: DAC960: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

Re: [PATCH v2 net-next] liquidio: fix bug in soft reset failure detection

2017-07-06 Thread Leon Romanovsky
On Wed, Jul 05, 2017 at 11:59:27AM -0700, Felix Manlunas wrote: > From: Derek Chickles > > The code that detects a failed soft reset of Octeon is comparing the wrong > value against the reset value of the Octeon SLI_SCRATCH_1 register, > resulting in an inability to

RE: [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB

2017-07-06 Thread Chris Paterson
Hello Sergei, Thank you for your comments. > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: 05 July 2017 17:14 > > Hello! > > On 07/05/2017 06:56 PM, Biju Das wrote: > > > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel > KSZ9031MNX). > > Gigabit

[PATCH v10 15/15] PCI: Remove PCI pool macro functions

2017-07-06 Thread Romain Perier
Now that all the drivers use dma pool API, we can remove the macro functions for PCI pool. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin --- include/linux/pci.h | 9 - 1 file changed, 9 deletions(-) diff --git

[PATCH] ptp: dte: Use LL suffix for 64-bit constants

2017-07-06 Thread Geert Uytterhoeven
With gcc 4.1.2: drivers/ptp/ptp_dte.c: In function ‘dte_write_nco_delta’: drivers/ptp/ptp_dte.c:105: warning: integer constant is too large for ‘long’ type drivers/ptp/ptp_dte.c:112: warning: integer constant is too large for ‘long’ type drivers/ptp/ptp_dte.c:114: warning:

Re: [PATCH] mwifiex: fix compile warning of unused variable

2017-07-06 Thread Shawn Lin
Hi Kalle, On 2017/7/6 15:57, Kalle Valo wrote: Shawn Lin writes: We got a compile warning shows below: drivers/net/wireless/marvell/mwifiex/sdio.c: In function 'mwifiex_sdio_remove': drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable 'ret' set but

[PATCH v10 00/15] Replace PCI pool by DMA pool API

2017-07-06 Thread Romain Perier
by the dma pool API and remove the defines. Changes in v10: - Rebased series onto next-20170706 - I have fixed and improved patch "scsi: megaraid: Replace PCI pool old API" Changes in v9: - Rebased series onto next-20170522 - I have fixed and improved the patch for lpfc driver Cha

Re: [Patch net] tap: convert a mutex to a spinlock

2017-07-06 Thread Christian Borntraeger
On 07/05/2017 10:50 PM, Cong Wang wrote: > We are not allowed to block on the RCU reader side, so can't > just hold the mutex as before. As a quick fix, convert it to > a spinlock. > > Fixes: d9f1f61c0801 ("tap: Extending tap device create/destroy APIs") > Reported-by: Christian Borntraeger

Re: [PATCH 06/14] bpf: Implement show_options

2017-07-06 Thread Daniel Borkmann
On 07/05/2017 05:24 PM, David Howells wrote: Implement the show_options superblock op for bpf as part of a bid to get rid of s_options and generic_show_options() to make it easier to implement a context-based mount where the mount options can be passed individually over a file descriptor.

[PATCH v10 03/15] IB/mthca: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v10 04/15] net: e100: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Acked-by: Jeff Kirsher

[PATCH v10 10/15] scsi: lpfc: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. It also updates some comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin ---

[PATCH v10 11/15] scsi: megaraid: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Sumit Saxena

[PATCH v10 08/15] scsi: be2iscsi: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

Re: [Patch net] tap: convert a mutex to a spinlock

2017-07-06 Thread Eric Dumazet
On Wed, 2017-07-05 at 13:50 -0700, Cong Wang wrote: > We are not allowed to block on the RCU reader side, so can't > just hold the mutex as before. As a quick fix, convert it to > a spinlock. > > Fixes: d9f1f61c0801 ("tap: Extending tap device create/destroy APIs") > Reported-by: Christian

[PATCH v10 09/15] scsi: csiostor: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. It also updates the name of some variables and the content of comments, accordingly. Signed-off-by: Romain Perier Reviewed-by: Peter Senna

Regarding xfrm state search with destination address as wildcard mask

2017-07-06 Thread Balaji Foss
Hi All, Im trying to implement IPSec for ospfv3 as per RFC4552 on Linux kernel version 3.16.39. Requirement is to support IPsec encryption/authentication for ospfv3 traffic. As of now, this can be achieved by following set of SA and SP rules. ip xfrm state add src :: dst ff02::5 proto ah spi

[PATCH] sctp: set the value of flowi6_oif to sk_bound_dev_if to make sctp_v6_get_dst to find the correct route entry.

2017-07-06 Thread Zheng Li
From: Zheng Li if there are several same route entries with different outgoing net device, application's socket specifies the oif through setsockopt with SO_BINDTODEVICE, sctpv6 should choose the route entry whose outgoing net device is the oif which was specified by

[PATCH v2] mwifiex: uninit wakeup info in the error handling

2017-07-06 Thread Jeffy Chen
We inited wakeup info at the beginning of mwifiex_add_card, so we need to uninit it in the error handling. It's much the same as what we did in: 36908c4 mwifiex: uninit wakeup info when removing device Signed-off-by: Jeffy Chen --- Changes in v2: Uninit wakeup when

[PATCH v10 02/15] dmaengine: pch_dma: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter Senna Tschudin

[PATCH v10 06/15] mlx5: Replace PCI pool old API

2017-07-06 Thread Romain Perier
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Doug Ledford

ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Geert Uytterhoeven
On Wed, Jul 5, 2017 at 9:52 PM, Linux Kernel Mailing List wrote: > Web: > https://git.kernel.org/torvalds/c/d96db25d20256208ce47d71b9f673a1de4c6fd7e > Commit: d96db25d20256208ce47d71b9f673a1de4c6fd7e > Parent: f008d1537bf88396cf41a7c7a831e3acd1ee92a1

Re: [PATCH] mwifiex: uninit wakeup info when failed to add card

2017-07-06 Thread jeffy
Hi brian, On 07/06/2017 02:08 AM, Brian Norris wrote: On Mon, Jul 03, 2017 at 03:54:30PM +0800, Jeffy Chen wrote: We inited wakeup info at the beginning of mwifiex_add_card, so we need to uninit it in the error handling. It's much the same as what we did in: 36908c4 mwifiex: uninit wakeup

RE: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

2017-07-06 Thread David Laight
From: McCabe, Robert J > Sent: 04 July 2017 01:14 > + if (nla_put(skb, TCA_STAB_DATA, sizeof(stab->szopts)*sizeof(u16), > >data)) > + goto nla_put_failure; Multiplying sizeof(a) by sizeof(b) really doesn't look right at all. David

MPLS Pseudowire (RFC3985) linux kernel support and development

2017-07-06 Thread Алексей Болдырев
Is there any plan for developing mpls pseudowire dliver for linux. And also, is it possible to write a driver for MPLS pseudowire on the basis of tun / tap?

Re: [PATCH 6/6] net: stmmac: revert "support future possible different internal phy mode"

2017-07-06 Thread David Miller
From: Corentin Labbe Date: Thu, 6 Jul 2017 10:51:47 +0200 > On Sun, Jul 02, 2017 at 02:31:59PM +0200, Corentin Labbe wrote: >> Since internal phy-mode is reserved for non-xMII protocol we cannot use >> it with dwmac-sun8i >> This reverts commit 1c2fa5f84683 ("net:

Re: [PATCH 6/6] net: stmmac: revert "support future possible different internal phy mode"

2017-07-06 Thread Corentin Labbe
On Sun, Jul 02, 2017 at 02:31:59PM +0200, Corentin Labbe wrote: > Since internal phy-mode is reserved for non-xMII protocol we cannot use > it with dwmac-sun8i > This reverts commit 1c2fa5f84683 ("net: stmmac: support future possible > different internal phy mode") > > Signed-off-by: Corentin

Re: [PATCH net-next] TLS: Fix length check in do_tls_getsockopt_tx()

2017-07-06 Thread David Miller
From: Matthias Rosenfelder Date: Thu, 6 Jul 2017 00:56:36 -0400 > copy_to_user() copies the struct the pointer is pointing to, but the > length check compares against sizeof(pointer) and not sizeof(struct). > On 32-bit the size is probably the same, so it might have

Re: [linux-sunxi] Re: [PATCH 6/6] net: stmmac: revert "support future possible different internal phy mode"

2017-07-06 Thread Chen-Yu Tsai
Hi Corentin, On Thu, Jul 6, 2017 at 5:45 PM, David Miller wrote: > From: Corentin Labbe > Date: Thu, 6 Jul 2017 10:51:47 +0200 > >> On Sun, Jul 02, 2017 at 02:31:59PM +0200, Corentin Labbe wrote: >>> Since internal phy-mode is reserved for

Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static

2017-07-06 Thread Fengguang Wu
Hi Stephen, On Thu, Jul 06, 2017 at 10:27:12AM +1000, Stephen Rothwell wrote: Hi, Not sure why you sent this to me ... it fixes a commit in the net-next tree (now in Linus' tree) ... Yeah sorry -- it's a bug in the robot. On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot

Re: [PATCH] sctp: set the value of flowi6_oif to sk_bound_dev_if to make sctp_v6_get_dst to find the correct route entry.

2017-07-06 Thread Ethan Zhao
Zheng, On Thu, Jul 6, 2017 at 3:00 PM, Zheng Li wrote: > From: Zheng Li > > if there are several same route entries with different outgoing net device, > application's socket specifies the oif through setsockopt with > SO_BINDTODEVICE, sctpv6

Re: [PATCH] sctp: set the value of flowi6_oif to sk_bound_dev_if to make sctp_v6_get_dst to find the correct route entry.

2017-07-06 Thread David Miller
From: Zheng Li Date: Thu, 6 Jul 2017 15:00:09 +0800 > From: Zheng Li > > if there are several same route entries with different outgoing net device, > application's socket specifies the oif through setsockopt with > SO_BINDTODEVICE, sctpv6 should

Re: [PATCH net-next RFC 08/12] net: dsa: Remove support for bypass bridge port attributes/vlan set

2017-07-06 Thread Arkadi Sharshevsky
On 07/05/2017 10:45 PM, Florian Fainelli wrote: > On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: >> The bridge port attributes/vlan for DSA devices should be set only >> from bridge code. Furthermore, The vlans are synced totally with the >> bridge so there is no need for special dump

[PATCH] net: axienet: add support for standard phy-mode binding

2017-07-06 Thread Alvaro Gamez Machado
Keep supporting proprietary "xlnx,phy-type" attribute and add support for MII connectivity to the PHY. Signed-off-by: Alvaro Gamez Machado --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 48 +-- 1 file changed, 36 insertions(+), 12

Re: [PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail()

2017-07-06 Thread Eric Dumazet
On Thu, 2017-07-06 at 02:16 -0700, Eric Dumazet wrote: > On Thu, 2017-07-06 at 17:01 +0800, Lin Zhang wrote: > > In the pull_pages code block, if the first frags size > eat, > > we can end the loop in advance to avoid extra copy. > > > > Signed-off-by: Lin Zhang > > --- >

Re: [Patch net] tap: convert a mutex to a spinlock

2017-07-06 Thread David Miller
From: Cong Wang Date: Wed, 5 Jul 2017 13:50:00 -0700 > We are not allowed to block on the RCU reader side, so can't > just hold the mutex as before. As a quick fix, convert it to > a spinlock. > > Fixes: d9f1f61c0801 ("tap: Extending tap device create/destroy APIs") >

[PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail()

2017-07-06 Thread Lin Zhang
In the pull_pages code block, if the first frags size > eat, we can end the loop in advance to avoid extra copy. Signed-off-by: Lin Zhang --- net/core/skbuff.c | 4 1 file changed, 4 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index

Re: [PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail()

2017-07-06 Thread Eric Dumazet
On Thu, 2017-07-06 at 17:01 +0800, Lin Zhang wrote: > In the pull_pages code block, if the first frags size > eat, > we can end the loop in advance to avoid extra copy. > > Signed-off-by: Lin Zhang > --- > net/core/skbuff.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail()

2017-07-06 Thread lin zhang
2017-07-06 17:23 GMT+08:00 Eric Dumazet : > On Thu, 2017-07-06 at 02:16 -0700, Eric Dumazet wrote: >> On Thu, 2017-07-06 at 17:01 +0800, Lin Zhang wrote: >> > In the pull_pages code block, if the first frags size > eat, >> > we can end the loop in advance to avoid extra

Re: [PATCH net-next] skbuff: optimize the pull_pages code in __pskb_pull_tail()

2017-07-06 Thread Eric Dumazet
On Thu, 2017-07-06 at 17:35 +0800, lin zhang wrote: > thanks, i am a newer, "net-next is closed" it means i need repost it > after net-next reopened? Yes, please read Documentation/networking/netdev-FAQ.txt for details.

Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

2017-07-06 Thread David Miller
From: David Ahern Date: Wed, 5 Jul 2017 14:41:46 -0600 > Lennert reported a failure to add different mpls encaps in a multipath > route: > > $ ip -6 route add 1234::/16 \ > nexthop encap mpls 10 via fe80::1 dev ens3 \ > nexthop encap mpls 20 via fe80::1 dev

Re: [PATCH] ptp: dte: Use LL suffix for 64-bit constants

2017-07-06 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 6 Jul 2017 10:34:54 +0200 > With gcc 4.1.2: > > drivers/ptp/ptp_dte.c: In function ‘dte_write_nco_delta’: > drivers/ptp/ptp_dte.c:105: warning: integer constant is too large for > ‘long’ type > drivers/ptp/ptp_dte.c:112:

Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static

2017-07-06 Thread David Miller
From: Stephen Rothwell Date: Thu, 6 Jul 2017 10:27:12 +1000 > Hi, > > Not sure why you sent this to me ... it fixes a commit in the net-next > tree (now in Linus' tree) ... > > On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot > wrote: >> >>

[PATCH 0/2] Netfilter fixes for net

2017-07-06 Thread Pablo Neira Ayuso
Hi David, The following patchset contains two Netfilter fixes for your net tree, they are: 1) Fix memleak from netns release path of conntrack protocol trackers, patch from Liping Zhang. 2) Uninitialized flags field in ebt_log, that results in unpredictable logging format in ebtables,

[PATCH 1/2] netfilter: nf_ct_dccp/sctp: fix memory leak after netns cleanup

2017-07-06 Thread Pablo Neira Ayuso
From: Liping Zhang After running the following commands for a while, kmemleak reported that "1879 new suspected memory leaks" happened: # while : ; do ip netns add test ip netns delete test done unreferenced object 0x88006342fa38 (size 1024): comm "ip", pid

Re: MPLS Pseudowire (RFC3985) linux kernel support and development

2017-07-06 Thread Vincent JARDIN
Le 06/07/2017 à 11:13, Алексей Болдырев a écrit : Is there any plan for developing mpls pseudowire dliver for linux. And also, is it possible to write a driver for MPLS pseudowire on the basis of tun / tap? We are working on a RFC patch that should be available soon. They'll be tested with

Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

2017-07-06 Thread Nicolas Dichtel
Le 06/07/2017 à 00:43, Cong Wang a écrit : > On Wed, Jul 5, 2017 at 8:57 AM, Nicolas Dichtel > wrote: >> When a device changes from one netns to another, it's first unregistered, >> then the netns reference is updated and the dev is registered in the new >> netns. Thus,

Re: [PATCH net-next RFC 05/12] net: dsa: Add support for learning FDB through notification

2017-07-06 Thread Arkadi Sharshevsky
On 07/05/2017 10:35 PM, Florian Fainelli wrote: > On 07/05/2017 08:36 AM, Arkadi Sharshevsky wrote: >> Add support for learning FDB through notification. The driver defers >> the hardware update via ordered work queue. In case of a successful >> FDB add a notification is sent back to bridge. >>

Re: [PATCH 0/2] Netfilter fixes for net

2017-07-06 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 6 Jul 2017 14:54:23 +0200 > The following patchset contains two Netfilter fixes for your net tree, > they are: > > 1) Fix memleak from netns release path of conntrack protocol trackers, >patch from Liping Zhang. > > 2) Uninitialized

[PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Richard Leitner
Some PHYs (for example the LAN8710) doesn't allow turning the clocks off and on again without reset (according to their datasheet). Exactly this behaviour was introduced for power saving reasons by commit e8fcfcd5684a ("net: fec: optimize the clock management to save power") Therefore add a

[PATCH 1/2] net: ethernet: freescale: simplify fec_reset_phy

2017-07-06 Thread Richard Leitner
The fec_reset_phy function allowed only one execution during probeing. As a preparation for future patches move the dt parsing and gpio allocation to the probe function. The parameters of the phy reset are added to the fec_enet_private struct. As a result the fec_reset_phy function may be called

[PATCH net] vrf: fix bug_on triggered by rx when destroying a vrf

2017-07-06 Thread Nikolay Aleksandrov
When destroying a VRF device we cleanup the slaves in its ndo_uninit() function, but that causes packets to be switched (skb->dev == vrf being destroyed) even though we're pass the point where the VRF should be receiving any packets while it is being dismantled. This causes a BUG_ON to trigger if

[PATCH 2/2] netfilter: ebt_nflog: fix unexpected truncated packet

2017-07-06 Thread Pablo Neira Ayuso
From: Liping Zhang "struct nf_loginfo li;" is a local variable, so we should set the flags to 0 explicitly, else, packets maybe truncated unexpectedly when copied to the userspace. Fixes: 7643507fe8b5 ("netfilter: xt_NFLOG: nflog-range does not truncate packets") Cc:

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-06 Thread Ding Tianhong
Hi Bjorn: Could you please give some feedback about this patchset, it looks like no more comments for more than a week, thanks. :) Ding On 2017/6/29 13:47, Ding Tianhong wrote: > ping > > On 2017/6/22 20:15, Ding Tianhong wrote: >> Some devices have problems with Transaction Layer Packets

Re: [CRIU] BUG: Dentry ffff9f795a08fe60{i=af565f, n=lo} still in use (1) [unmount of proc proc]

2017-07-06 Thread Eric W. Biederman
Andrei Vagin writes: > I did a few experiments and found that the bug is reproduced for 6-12 > hours on the our test server. Then I reverted two patches and the server > is working normally for more than 24 hours already, so the bug is > probably in one of these patches. > >

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Andrew Lunn
Hi Richard > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt > b/Documentation/devicetree/bindings/net/fsl-fec.txt > index 6f55bdd..1766579 100644 > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > @@ -23,6 +23,9

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-06 Thread Edward Cree
On 04/07/17 20:22, Edward Cree wrote: > I don't know why test_l4lb has to process _fewer_ insns with my patches; > if anything I'm worrying that I may be incorrectly pruning branches. > (I've spotted a possible bug in that I'm not looking at 'id' which, > although it doesn't have to match, if

RE: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread David Laight
From: Paul E. McKenney > Sent: 06 July 2017 00:30 > There is no agreed-upon definition of spin_unlock_wait()'s semantics, > and it appears that all callers could do just as well with a lock/unlock > pair. This series therefore removes spin_unlock_wait() and changes > its users to instead use a

Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

2017-07-06 Thread David Miller
From: Willem de Bruijn Date: Wed, 5 Jul 2017 13:21:02 -0400 > On Wed, Jul 5, 2017 at 12:06 PM, Willem de Bruijn > wrote: >>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h >>> index 5209b5e..32fb046 100644

Re: [Intel-wired-lan] [PATCH 1/2] i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct virtchnl_vf_resource

2017-07-06 Thread Greg Rose
On Wed, Jul 5, 2017 at 10:15 PM, Wyborny, Carolyn wrote: > > > -Original Message- > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > > Of Stefan Assmann > > Sent: Thursday, June 29, 2017 6:12 AM > > To:

  1   2   >