RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread maowenan
> -Original Message- > From: maowenan > Sent: Tuesday, August 01, 2017 8:20 PM > To: 'Neal Cardwell'; David Miller > Cc: netdev@vger.kernel.org; Yuchung Cheng; Nandita Dukkipati > Subject: RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data > ACKed/SACKed > > > > >

RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread maowenan
> -Original Message- > From: maowenan > Sent: Tuesday, August 01, 2017 8:20 PM > To: 'Neal Cardwell'; David Miller > Cc: netdev@vger.kernel.org; Yuchung Cheng; Nandita Dukkipati > Subject: RE: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data > ACKed/SACKed > > > > >

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Boris Brezillon
On Wed, 14 Jun 2017 23:15:40 +0200 Arnd Bergmann wrote: > When CONFIG_KASAN is used, we consume a lot of extra stack space: > > drivers/mtd/chips/cfi_cmdset_0020.c: In function 'do_write_buffer': > drivers/mtd/chips/cfi_cmdset_0020.c:603:1: error: the frame size of 2184 > bytes

[PATCH] iproute2/misc: do not mix CFLAGS with LDFLAGS

2017-08-04 Thread Marcus Meissner
during linking, do not use CFLAGS. This avoid clashes when doing PIE builds. --- misc/Makefile | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/misc/Makefile b/misc/Makefile index 72807678..1d86c44d 100644 --- a/misc/Makefile +++ b/misc/Makefile @@ -23,17

Re: [PATCH net] xgene: Always get clk source, but ignore if it's missing for SGMII ports

2017-08-04 Thread Will Deacon
On Thu, Aug 03, 2017 at 03:43:14PM +0200, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > Even the driver doesn't do anything with the clk source for SGMII > ports it needs to be enabled by doing a devm_clk_get(), if there is > a clk source in DT. > > Fixes:

Re: [PATCH v3] ARM: dts: tango4: Request RGMII RX and TX clock delays

2017-08-04 Thread Arnd Bergmann
On Fri, Jul 28, 2017 at 3:27 PM, Marc Gonzalez wrote: > RX and TX clock delays are required. Request them explicitly. > > Fixes: cad008b8a77e6 ("ARM: dts: tango4: Initial device trees") > Signed-off-by: Marc Gonzalez > --- > Arnd,

WARN_ON in commit 0ffdaf5 "net/sock: add WARN_ON(parent->sk) in sock_graft()"

2017-08-04 Thread Guoqing Jiang
HI, With commit 0ffdaf5b41cf4435ece14d1d3e977ce69012a20d "net/sock: add WARN_ON(parent->sk) in sock_graft()", I can see the WARN_ON is triggered easily by dlm subsystem. tcp_accept_from_sock() in fs/dlm/lowcomms.c has the following snippet: 1.result = sock_create_kern(_net,

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Boris Brezillon
On Fri, 4 Aug 2017 11:09:53 +0200 Arnd Bergmann wrote: > On Fri, Aug 4, 2017 at 9:42 AM, Boris Brezillon > wrote: > > On Wed, 14 Jun 2017 23:15:40 +0200 > > Arnd Bergmann wrote: > > > >> When CONFIG_KASAN is used, we consume a

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Boris Brezillon
On Wed, 14 Jun 2017 23:15:40 +0200 Arnd Bergmann wrote: > When CONFIG_KASAN is used, we consume a lot of extra stack space: > > drivers/mtd/chips/cfi_cmdset_0020.c: In function 'do_write_buffer': > drivers/mtd/chips/cfi_cmdset_0020.c:603:1: error: the frame size of 2184 > bytes

Re: WARN_ON in commit 0ffdaf5 "net/sock: add WARN_ON(parent->sk) in sock_graft()"

2017-08-04 Thread Sowmini Varadhan
On (08/04/17 19:13), Guoqing Jiang wrote: > > HI, > > With commit 0ffdaf5b41cf4435ece14d1d3e977ce69012a20d "net/sock: add > WARN_ON(parent->sk) in sock_graft()", > I can see the WARN_ON is triggered easily by dlm subsystem. > > tcp_accept_from_sock() in fs/dlm/lowcomms.c has the following

Re: [patch net-next 00/21] mlxsw: Support for IPv6 UC router

2017-08-04 Thread Ido Schimmel
On Thu, Aug 03, 2017 at 04:54:35PM -0600, David Ahern wrote: > On 8/3/17 4:41 PM, David Miller wrote: > > But unlike the percpu flag, don't we want to somehow propagate offload > > state to the user? > > It's a per nexthop flag. For IPv4 it is tracked in fib_nh.nh_flags. > Perhaps it is time for

Re: [PATCH v2 05/11] mtd: cfi: reduce stack size with KASAN

2017-08-04 Thread Arnd Bergmann
On Fri, Aug 4, 2017 at 9:42 AM, Boris Brezillon wrote: > On Wed, 14 Jun 2017 23:15:40 +0200 > Arnd Bergmann wrote: > >> When CONFIG_KASAN is used, we consume a lot of extra stack space: >> >> drivers/mtd/chips/cfi_cmdset_0020.c: In function

[PATCH] net: phy: marvell: logical vs bitwise OR typo

2017-08-04 Thread Dan Carpenter
This was supposed to be a bitwise OR but there is a || vs | typo. Fixes: 864dc729d528 ("net: phy: marvell: Refactor m88e1121 RGMII delay configuration") Signed-off-by: Dan Carpenter diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index

[PATCH net-next] net: hns: Fix for __udivdi3 compiler error

2017-08-04 Thread Yunsheng Lin
This patch fixes the __udivdi3 undefined error reported by test robot. Fixes: b8c17f708831 ("net: hns: Add self-adaptive interrupt coalesce support in hns driver") Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 3 ++- 1 file changed, 2

Re: [PATCH net-next V2] net ipv6: convert fib6_table rwlock to a percpu lock

2017-08-04 Thread David Ahern
On 8/4/17 11:07 AM, Eric Dumazet wrote: > On Fri, 2017-08-04 at 09:38 -0700, Shaohua Li wrote: >> From: Shaohua Li >> >> In a syn flooding test, the fib6_table rwlock is a significant >> bottleneck. While converting the rwlock to rcu sounds straighforward, >> but is very challenging

Re: [PATCH] net: phy: marvell: logical vs bitwise OR typo

2017-08-04 Thread Andrew Lunn
On Fri, Aug 04, 2017 at 11:17:21AM +0300, Dan Carpenter wrote: > This was supposed to be a bitwise OR but there is a || vs | typo. > > Fixes: 864dc729d528 ("net: phy: marvell: Refactor m88e1121 RGMII delay > configuration") > Signed-off-by: Dan Carpenter Hi Dan

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Neal Cardwell
On Fri, Aug 4, 2017 at 1:10 PM, Willy Tarreau wrote: > Hi Neal, > > On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote: >> I have attached patches for this fix rebased on to v3.10.107, the >> latest stable release for 3.10. That's pretty far back in history, so >> there

Re: [patch net-next v2 00/20] net: sched: summer cleanup part 1, mainly in exts area

2017-08-04 Thread David Miller
From: Jiri Pirko Date: Fri, 4 Aug 2017 14:28:55 +0200 > From: Jiri Pirko > > This patchset is one of the couple cleanup patchsets I have in queue. > The motivation aside the obvious need to "make things nicer" is also > to prepare for shared filter blocks

Re: [PATCH net-next v3 1/2] bpf: add support for sys_enter_* and sys_exit_* tracepoints

2017-08-04 Thread Yonghong Song
On 8/4/17 11:40 AM, Alexei Starovoitov wrote: On 8/3/17 5:09 PM, Y Song wrote: On Thu, Aug 3, 2017 at 7:08 PM, Alexei Starovoitov wrote: On 8/3/17 6:29 AM, Yonghong Song wrote: @@ -578,8 +596,9 @@ static void perf_syscall_enter(void *ignore, struct pt_regs *regs, long id)

Re: [PATCH net-next] net: dsa: User per-cpu 64-bit statistics

2017-08-04 Thread Eric Dumazet
On Fri, 2017-08-04 at 08:51 -0700, Florian Fainelli wrote: > On 08/03/2017 10:36 PM, Eric Dumazet wrote: > > On Thu, 2017-08-03 at 21:33 -0700, Florian Fainelli wrote: > >> During testing with a background iperf pushing 1Gbit/sec worth of > >> traffic and having both ifconfig and ethtool collect

Re: [PATCH] net: phy: marvell: logical vs bitwise OR typo

2017-08-04 Thread Andrew Lunn
On Fri, Aug 04, 2017 at 02:54:45PM +, David Laight wrote: > From: Dan Carpenter > > Sent: 04 August 2017 09:17 > > This was supposed to be a bitwise OR but there is a || vs | typo. > > > > Fixes: 864dc729d528 ("net: phy: marvell: Refactor m88e1121 RGMII delay > > configuration") > >

Re: [PATCH] MIPS: Add missing file for eBPF JIT.

2017-08-04 Thread David Miller
From: Daniel Borkmann Date: Fri, 04 Aug 2017 15:05:19 +0200 > On 08/04/2017 02:10 AM, David Daney wrote: >> Inexplicably, commit f381bf6d82f0 ("MIPS: Add support for eBPF JIT.") >> lost a file somewhere on its path to Linus' tree. Add back the >> missing ebpf_jit.c so that

Re: [PATCH] samples/bpf: Fix cross compiler error with bpf sample

2017-08-04 Thread Joel Fernandes
On Fri, Aug 4, 2017 at 6:58 AM, Daniel Borkmann wrote: > On 08/04/2017 07:46 AM, Joel Fernandes wrote: >> >> When cross-compiling the bpf sample map_perf_test for aarch64, I find that >> __NR_getpgrp is undefined. This causes build errors. Fix it by allowing >> the >>

Re: [PATCH v5] ss: Enclose IPv6 address in brackets

2017-08-04 Thread Stephen Hemminger
On Fri, 4 Aug 2017 20:02:52 +0200 Florian Lehner wrote: > diff --git a/misc/ss.c b/misc/ss.c > index 12763c9..83683b5 100644 > --- a/misc/ss.c > +++ b/misc/ss.c > @@ -1046,8 +1046,9 @@ do_numeric: > > static void inet_addr_print(const inet_prefix *a, int port, unsigned > int

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-08-04 Thread Casey Leedom
| From: Raj, Ashok | Sent: Thursday, August 3, 2017 1:31 AM | | I don't understand this completely.. So your driver would know not to send | RO TLP's to root complex. But you want to send RO to the NVMe device? This | is the peer-2-peer case correct? Yes, this is the "heavy

[PATCH] wan: dscc4: add checks for dma mapping errors

2017-08-04 Thread Alexey Khoroshilov
The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/wan/dscc4.c | 52

[PATCH net] bpf: fix byte order test in test_verifier

2017-08-04 Thread Daniel Borkmann
We really must check with #if __BYTE_ORDER == XYZ instead of just presence of #ifdef __LITTLE_ENDIAN. I noticed that when actually running this on big endian machine, the latter test resolves to true for user space, same for #ifdef __BIG_ENDIAN. E.g., looking at endian.h from libc, both are also

[PATCH v2 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device

2017-08-04 Thread David Ahern
A missing piece to the VRF puzzle is the ability to bind sockets to devices enslaved to a VRF. This patch set adds the enslaved device index, sdif, to IPv4 and IPv6 socket lookups. The end result for users is the following scope options for services: 1. "global" services - sockets not bound to

[PATCH v2 net-next 4/7] net: ipv4: add second dif to multicast source filter

2017-08-04 Thread David Ahern
Signed-off-by: David Ahern --- include/linux/igmp.h | 3 ++- net/ipv4/igmp.c | 6 -- net/ipv4/raw.c | 2 +- net/ipv4/udp.c | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/linux/igmp.h b/include/linux/igmp.h index

[PATCH v2 net-next 3/7] net: ipv4: add second dif to raw socket lookups

2017-08-04 Thread David Ahern
Add a second device index, sdif, to raw socket lookups. sdif is the index for ingress devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 domain when searching for a socket. Signed-off-by: David Ahern --- include/net/raw.h

[PATCH v2 net-next 5/7] net: ipv6: add second dif to udp socket lookups

2017-08-04 Thread David Ahern
Add a second device index, sdif, to udp socket lookups. sdif is the index for ingress devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 domain when searching for a socket. Early demux lookups are handled in the next patch as part of INET_MATCH

[PATCH v2 net-next 1/7] net: ipv4: add second dif to udp socket lookups

2017-08-04 Thread David Ahern
Add a second device index, sdif, to udp socket lookups. sdif is the index for ingress devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 domain when searching for a socket. Early demux lookups are handled in the next patch as part of INET_MATCH

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-08-04 Thread Raj, Ashok
On Fri, Aug 04, 2017 at 08:20:37PM +, Casey Leedom wrote: > | From: Raj, Ashok > | Sent: Thursday, August 3, 2017 1:31 AM > | > | I don't understand this completely.. So your driver would know not to send > | RO TLP's to root complex. But you want to send RO to the NVMe

[PATCH] of_mdio: use of_property_read_u32_array()

2017-08-04 Thread Sergei Shtylyov
The "fixed-link" prop support predated of_property_read_u32_array(), so basically had to open-code it. Using the modern API saves 24 bytes of the object code (ARM gcc 4.8.5); the only behavior change would be that the prop length check is now less strict (however the strict pre-check done in

Re: [PATCH iproute2 1/2] tc actions: Improved batching and time filtered dumping

2017-08-04 Thread Stephen Hemminger
On Wed, 2 Aug 2017 07:46:26 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > dump more than TCA_ACT_MAX_PRIO actions per batch when the kernel > supports it. > > Introduced keyword "since" for time based filtering of actions. > Some example (we

[PATCH v2 net-next 7/7] net: ipv6: add second dif to raw socket lookups

2017-08-04 Thread David Ahern
Add a second device index, sdif, to raw socket lookups. sdif is the index for ingress devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 domain when searching for a socket. Signed-off-by: David Ahern --- include/net/rawv6.h

[PATCH v2 net-next 6/7] net: ipv6: add second dif to inet6 socket lookups

2017-08-04 Thread David Ahern
Add a second device index, sdif, to inet6 socket lookups. sdif is the index for ingress devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 domain when searching for a socket. TCP moves the data in the cb. Prior to tcp_v4_rcv (e.g., early demux)

[PATCH v2 net-next 2/7] net: ipv4: add second dif to inet socket lookups

2017-08-04 Thread David Ahern
Add a second device index, sdif, to inet socket lookups. sdif is the index for ingress devices enslaved to an l3mdev. It allows the lookups to consider the enslaved device as well as the L3 domain when searching for a socket. TCP moves the data in the cb. Prior to tcp_v4_rcv (e.g., early demux)

Re: [PATCH net-next 00/10] net: l3mdev: Support for sockets bound to enslaved device

2017-08-04 Thread David Ahern
On 8/1/17 6:41 PM, David Miller wrote: > From: David Ahern > Date: Mon, 31 Jul 2017 20:13:16 -0700 > >> Existing code for socket lookups already pass in 6+ arguments. Rather >> than add another for the enslaved device index, the existing lookups >> are converted to use a new

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-08-04 Thread Casey Leedom
| From: Raj, Ashok | Sent: Friday, August 4, 2017 1:21 PM | | On Fri, Aug 04, 2017 at 08:20:37PM +, Casey Leedom wrote: | > ... | > As I've noted a number of times, it would be great if the Intel Hardware | > Engineers who attempted to implement the Relaxed Ordering

uapi: MAX_ADDR_LEN vs. numeric 32

2017-08-04 Thread Mikko Rapeli
Hi, First, thanks Dmitry for fixing several uapi compilation problems in user space. I got a bit demotivated about the slow review progress, e.g. no feedback what so ever, on some of the patches, but lets try again... I rebased my tree now and saw commit 745cb7f8a5de0805cade3de3991b7a95317c7c73

Re: [net-next PATCH] net: devmap fix mutex in rcu critical section

2017-08-04 Thread John Fastabend
On 08/04/2017 02:21 PM, John Fastabend wrote: > Originally we used a mutex to protect concurrent devmap update > and delete operations from racing with netdev unregister notifier > callbacks. > [...] > } > @@ -396,22 +385,20 @@ static int dev_map_notification(struct notifier_block >

Re: [PATCH v5] ss: Enclose IPv6 address in brackets

2017-08-04 Thread Eric Dumazet
On Fri, 2017-08-04 at 12:05 -0700, Stephen Hemminger wrote: > On Fri, 4 Aug 2017 20:02:52 +0200 > Florian Lehner wrote: > > > diff --git a/misc/ss.c b/misc/ss.c > > index 12763c9..83683b5 100644 > > --- a/misc/ss.c > > +++ b/misc/ss.c > > @@ -1046,8 +1046,9 @@ do_numeric: > >

Re: [PATCH v8 1/4] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-08-04 Thread Casey Leedom
| From: Ding Tianhong | Sent: Thursday, August 3, 2017 6:44 AM | | diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c | index 6967c6b..1e1cdbe 100644 | --- a/drivers/pci/quirks.c | +++ b/drivers/pci/quirks.c | @@ -4016,6 +4016,44 @@ static void

[net-next PATCH] net: devmap fix mutex in rcu critical section

2017-08-04 Thread John Fastabend
Originally we used a mutex to protect concurrent devmap update and delete operations from racing with netdev unregister notifier callbacks. The notifier hook is needed because we increment the netdev ref count when a dev is added to the devmap. This ensures the netdev reference is valid in the

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Willy Tarreau
On Fri, Aug 04, 2017 at 02:01:34PM -0400, Neal Cardwell wrote: > On Fri, Aug 4, 2017 at 1:10 PM, Willy Tarreau wrote: > > Hi Neal, > > > > On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote: > >> I have attached patches for this fix rebased on to v3.10.107, the > >> latest

Re: [PATCH net 0/2] Two BPF fixes for s390

2017-08-04 Thread David Miller
From: Daniel Borkmann Date: Fri, 4 Aug 2017 14:20:53 +0200 > Found while testing some other work touching JITs. Series applied and patch #1 queued up for -stable, thanks!

Re: [PATCH net-next 2/5] ipv6: sr: export SRH insertion functions

2017-08-04 Thread David Miller
From: David Lebrun Date: Fri, 4 Aug 2017 15:24:12 +0200 > +EXPORT_SYMBOL(seg6_do_srh_encap); ... > +EXPORT_SYMBOL(seg6_do_srh_inline); EXPORT_SYMBOL_GPL() please.

Re: [PATCH net 1/2] bpf, s390: fix jit branch offset related to ldimm64

2017-08-04 Thread David Miller
From: Michael Holzheu Date: Fri, 4 Aug 2017 19:10:33 +0200 > At least I would vote for "Cc: stable". No, please do not ever do this for networking patches.

Re: [PATCH net-next V2] net ipv6: convert fib6_table rwlock to a percpu lock

2017-08-04 Thread Wei Wang
On Fri, Aug 4, 2017 at 10:11 AM, David Ahern wrote: > On 8/4/17 11:07 AM, Eric Dumazet wrote: >> On Fri, 2017-08-04 at 09:38 -0700, Shaohua Li wrote: >>> From: Shaohua Li >>> >>> In a syn flooding test, the fib6_table rwlock is a significant >>> bottleneck. While

Re: [PATCH] net: phy: marvell: logical vs bitwise OR typo

2017-08-04 Thread David Miller
From: Dan Carpenter Date: Fri, 4 Aug 2017 11:17:21 +0300 > This was supposed to be a bitwise OR but there is a || vs | typo. > > Fixes: 864dc729d528 ("net: phy: marvell: Refactor m88e1121 RGMII delay > configuration") > Signed-off-by: Dan Carpenter

[PATCH v5] ss: Enclose IPv6 address in brackets

2017-08-04 Thread Florian Lehner
This updated patch adds support for RFC2732 IPv6 address format with brackets for the tool ss. Now checking the complete IPv6 address if it is IN6ADDR_ANY. Signed-off-by: Lehner Florian --- misc/ss.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-)

Re: [PATCH net-next v3 1/2] bpf: add support for sys_enter_* and sys_exit_* tracepoints

2017-08-04 Thread Alexei Starovoitov
On 8/3/17 5:09 PM, Y Song wrote: On Thu, Aug 3, 2017 at 7:08 PM, Alexei Starovoitov wrote: On 8/3/17 6:29 AM, Yonghong Song wrote: @@ -578,8 +596,9 @@ static void perf_syscall_enter(void *ignore, struct pt_regs *regs, long id) if (!sys_data) return; +

Re: [PATCH] samples/bpf: Fix cross compiler error with bpf sample

2017-08-04 Thread Daniel Borkmann
On 08/04/2017 08:33 PM, Joel Fernandes wrote: On Fri, Aug 4, 2017 at 6:58 AM, Daniel Borkmann wrote: On 08/04/2017 07:46 AM, Joel Fernandes wrote: When cross-compiling the bpf sample map_perf_test for aarch64, I find that __NR_getpgrp is undefined. This causes build

Re: [PATCH net 1/2] bpf, s390: fix jit branch offset related to ldimm64

2017-08-04 Thread Michael Holzheu
Am Fri, 04 Aug 2017 15:52:47 +0200 schrieb Daniel Borkmann : > On 08/04/2017 03:44 PM, Michael Holzheu wrote: > > Am Fri, 4 Aug 2017 14:20:54 +0200 > > schrieb Daniel Borkmann : > [...] > > > > What about "Cc: sta...@vger.kernel.org"? > > Handled by

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

2017-08-04 Thread Willy Tarreau
Hi Neal, On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote: > I have attached patches for this fix rebased on to v3.10.107, the > latest stable release for 3.10. That's pretty far back in history, so > there were substantial conflict resolutions and adjustments required. > :-) Hope

Re: [PATCH net-next V2] net ipv6: convert fib6_table rwlock to a percpu lock

2017-08-04 Thread David Miller
From: David Ahern Date: Fri, 4 Aug 2017 11:11:40 -0600 > On 8/4/17 11:07 AM, Eric Dumazet wrote: >> On Fri, 2017-08-04 at 09:38 -0700, Shaohua Li wrote: >>> From: Shaohua Li >>> >>> In a syn flooding test, the fib6_table rwlock is a significant >>> bottleneck.

Re: [PATCH net] xgene: Always get clk source, but ignore if it's missing for SGMII ports

2017-08-04 Thread David Miller
From: Thomas Bogendoerfer Date: Thu, 3 Aug 2017 15:43:14 +0200 > From: Thomas Bogendoerfer > > Even the driver doesn't do anything with the clk source for SGMII > ports it needs to be enabled by doing a devm_clk_get(), if there is > a clk

Re: STABLE: net: reduce skb_warn_bad_offload() noise

2017-08-04 Thread Greg KH
On Fri, Jul 28, 2017 at 10:22:52PM -0700, Eric Dumazet wrote: > On Fri, 2017-07-28 at 12:30 -0700, David Miller wrote: > > From: Mark Salyzyn > > Date: Fri, 28 Jul 2017 10:29:57 -0700 > > > > > Please backport the upstream patch to the stable trees (including > > > 3.10.y,

Re: [PATCH net-next V2] net ipv6: convert fib6_table rwlock to a percpu lock

2017-08-04 Thread Eric Dumazet
On Fri, 2017-08-04 at 09:38 -0700, Shaohua Li wrote: > From: Shaohua Li > > In a syn flooding test, the fib6_table rwlock is a significant > bottleneck. While converting the rwlock to rcu sounds straighforward, > but is very challenging if it's possible. A percpu spinlock (lglock

Re: [PATCH net-next] net: dsa: User per-cpu 64-bit statistics

2017-08-04 Thread Eric Dumazet
On Fri, 2017-08-04 at 10:11 -0700, Eric Dumazet wrote: > You could add a debug version of u64_stats_update_begin() > > doing > > int ret = atomic_inc((atomic_t *)syncp); I meant atomic_inc_return() of course. > > BUG_ON(ret & 1); > > > And u64_stats_update_end() > > int ret =

Re: [patch net 0/2] mlxsw: Couple of fixes

2017-08-04 Thread David Miller
From: Jiri Pirko Date: Fri, 4 Aug 2017 14:12:28 +0200 > From: Jiri Pirko > > Ido says: > > The first patch prevents us from warning about valid situations that can > happen due to the fact that some operations in switchdev are deferred. > > Second patch

Re: [PATCH 0/3] ARM: dts: keystone-k2g: Add DCAN instances to 66AK2G

2017-08-04 Thread Santosh Shilimkar
Hi Franklin, On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote: Add D CAN nodes to 66AK2G based SoC dtsi. Franklin S Cooper Jr (2): dt-bindings: net: c_can: Update binding for clock and power-domains property ARM: configs: keystone: Enable D_CAN driver Lokesh Vutla (1): ARM: dts:

Re: [PATCH net-next] net: hns: Fix for __udivdi3 compiler error

2017-08-04 Thread David Miller
From: Yunsheng Lin Date: Fri, 4 Aug 2017 17:24:59 +0800 > This patch fixes the __udivdi3 undefined error reported by > test robot. > > Fixes: b8c17f708831 ("net: hns: Add self-adaptive interrupt coalesce support > in hns driver") > Signed-off-by: Yunsheng Lin

Re: [net-next PATCH v2] net: comment fixes against BPF devmap helper calls

2017-08-04 Thread David Miller
From: John Fastabend Date: Fri, 04 Aug 2017 08:24:05 -0700 > Update BPF comments to accurately reflect XDP usage. > > Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine") > Reported-by: Alexei Starovoitov > Signed-off-by: John Fastabend

[PATCH net-next 1/1] netvsc: fix rtnl deadlock on unregister of vf

2017-08-04 Thread Stephen Hemminger
With new transparent VF support, it is possible to get a deadlock when some of the deferred work is running and the unregister_vf is trying to cancel the work element. The solution is to use trylock and reschedule (similar to bonding and team device). Reported-by: Vitaly Kuznetsov

[PATCH net-next 0/1] netvsc: fix deadlock in VF unregister

2017-08-04 Thread Stephen Hemminger
There was a race in VF unregister (in net-next only) which can be triggered if SR-IOV is disabled on host side, which causes PCI hotplug removal. Stephen Hemminger (1): netvsc: fix rtnl deadlock on unregister of vf drivers/net/hyperv/netvsc_drv.c | 12 ++-- 1 file changed, 10

[PATCH v2 2/2] dt-bindings: net: Document bindings for anarion-gmac

2017-08-04 Thread Alexandru Gagniuc
Signed-off-by: Alexandru Gagniuc --- .../devicetree/bindings/net/anarion-gmac.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/anarion-gmac.txt diff --git

[PATCH v2 1/2] net: stmmac: Add Adaptrum Anarion GMAC glue layer

2017-08-04 Thread Alexandru Gagniuc
Before the GMAC on the Anarion chip can be used, the PHY interface selection must be configured with the DWMAC block in reset. This layer covers a block containing only two registers. Although it is possible to model this as a reset controller and use the "resets" property of stmmac, it's much

Re: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

2017-08-04 Thread Roland Dreier
> I think the conclusion is that a hard-wired ACS capability is a > positive indication of isolation for a multifunction device, the code > is intended to support this and appears to do so, and Roland was going > to investigate the sightings that inspired this patch in more detail. > Dropping for

Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code

2017-08-04 Thread Andrew Lunn
> @@ -251,8 +251,9 @@ dsa_switch_setup(struct dsa_switch_tree *dst, struct > net_device *master, > ds->cd = cd; > ds->ops = ops; > ds->priv = priv; > + ds->dev = parent; Hi Vivien Is this even needed? dsa_switch_alloc() does ds->dev = dev. Andrew

Re: [PATCH v5] ss: Enclose IPv6 address in brackets

2017-08-04 Thread Stephen Hemminger
On Fri, 04 Aug 2017 13:46:27 -0700 Eric Dumazet wrote: > On Fri, 2017-08-04 at 12:05 -0700, Stephen Hemminger wrote: > > On Fri, 4 Aug 2017 20:02:52 +0200 > > Florian Lehner wrote: > > > > > diff --git a/misc/ss.c b/misc/ss.c > > > index

Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Andrew Lunn
On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote: > From: Roopa Prabhu > > Signed-off-by: Roopa Prabhu > --- > net/core/lwtunnel.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff

Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Roopa Prabhu
On Fri, Aug 4, 2017 at 3:25 PM, Andrew Lunn wrote: > On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Signed-off-by: Roopa Prabhu >> --- >> net/core/lwtunnel.c | 26

Re: [PATCH] of_mdio: use of_property_read_u32_array()

2017-08-04 Thread Andrew Lunn
On Sat, Aug 05, 2017 at 12:43:43AM +0300, Sergei Shtylyov wrote: > The "fixed-link" prop support predated of_property_read_u32_array(), so > basically had to open-code it. Using the modern API saves 24 bytes of the > object code (ARM gcc 4.8.5); the only behavior change would be that the > prop

[PATCH net-next v2] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- v2 - fixed a incorrect replace net/core/lwtunnel.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/lwtunnel.c

[PATCH net-next 0/3] net: dsa: remove unnecessary arguments

2017-08-04 Thread Vivien Didelot
Several DSA core functions take many arguments, mostly because the legacy code does not assign ds->dev. This patch series assigns ds->dev in legacy and removes the unnecessary arguments of these functions, where either the dsa_switch or dsa_port argument is enough. Vivien Didelot (3): net: dsa:

[PATCH net-next 1/3] net: dsa: assign switch device in legacy code

2017-08-04 Thread Vivien Didelot
Assign the parent device to the dev member of the newly allocated dsa_switch structure in the legacy dsa_switch_setup function, so that the underlying dsa_switch_setup_one and dsa_cpu_dsa_setups functions can access it instead of requiring an additional struct device argument. Signed-off-by:

[PATCH net-next 3/3] net: dsa: remove useless args of dsa_slave_create

2017-08-04 Thread Vivien Didelot
dsa_slave_create currently takes 4 arguments while it only needs the related dsa_port and its name. Remove all other arguments. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 2 +- net/dsa/dsa_priv.h | 3 +-- net/dsa/legacy.c | 2 +-

Re: [PATCH net] bpf: fix byte order test in test_verifier

2017-08-04 Thread Yonghong Song
On 8/4/17 1:24 PM, Daniel Borkmann wrote: We really must check with #if __BYTE_ORDER == XYZ instead of just presence of #ifdef __LITTLE_ENDIAN. I noticed that when actually running this on big endian machine, the latter test resolves to true for user space, same for #ifdef __BIG_ENDIAN. E.g.,

[PATCH net-next v4 1/2] bpf: add support for sys_enter_* and sys_exit_* tracepoints

2017-08-04 Thread Yonghong Song
Currently, bpf programs cannot be attached to sys_enter_* and sys_exit_* style tracepoints. The iovisor/bcc issue #748 (https://github.com/iovisor/bcc/issues/748) documents this issue. For example, if you try to attach a bpf program to tracepoints syscalls/sys_enter_newfstat, you will get the

[PATCH net-next v4 2/2] bpf: add a test case for syscalls/sys_{enter|exit}_* tracepoints

2017-08-04 Thread Yonghong Song
Signed-off-by: Yonghong Song --- samples/bpf/Makefile | 4 +++ samples/bpf/syscall_tp_kern.c | 62 + samples/bpf/syscall_tp_user.c | 71 +++ 3 files changed, 137 insertions(+) create mode 100644

[PATCH net-next v4 0/2] bpf: add support for sys_{enter|exit}_* tracepoints

2017-08-04 Thread Yonghong Song
Currently, bpf programs cannot be attached to sys_enter_* and sys_exit_* style tracepoints. The main reason is that syscalls/sys_enter_* and syscalls/sys_exit_* tracepoints are treated differently from other tracepoints and there is no bpf hook to it. This patch set adds bpf support for these

[PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- net/core/lwtunnel.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c index d9cb353..8693ff8 100644

[PATCH net-next 2/3] net: dsa: remove useless args of dsa_cpu_dsa_setup

2017-08-04 Thread Vivien Didelot
dsa_cpu_dsa_setup currently takes 4 arguments but they are all available from the dsa_port argument. Remove all others. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c | 10 +- net/dsa/dsa2.c | 4 ++-- net/dsa/dsa_priv.h | 3 +--

Re: uapi: MAX_ADDR_LEN vs. numeric 32

2017-08-04 Thread Dmitry V. Levin
Hi, On Sat, Aug 05, 2017 at 12:33:25AM +0300, Mikko Rapeli wrote: > First, thanks Dmitry for fixing several uapi compilation problems in > user space. I got a bit demotivated That's quite understandable. > about the slow review progress, e.g. > no feedback what so ever, on some of the patches,

Re: [PATCH net] bpf: fix byte order test in test_verifier

2017-08-04 Thread David Miller
From: Daniel Borkmann Date: Fri, 4 Aug 2017 22:24:41 +0200 > We really must check with #if __BYTE_ORDER == XYZ instead of > just presence of #ifdef __LITTLE_ENDIAN. I noticed that when > actually running this on big endian machine, the latter test > resolves to true for

Re: uapi: MAX_ADDR_LEN vs. numeric 32

2017-08-04 Thread Mikko Rapeli
On Sat, Aug 05, 2017 at 01:25:19AM +0300, Dmitry V. Levin wrote: > > On Sat, Aug 05, 2017 at 12:33:25AM +0300, Mikko Rapeli wrote: > > > > I find using MAX_ADDR_LEN better than numeric 32, though I doubt this will > > change any time soon. Would you mind if I change packet_diag.h and > >

Re: [PATCH net-next] aquantia: Switch to use napi_gro_receive

2017-08-04 Thread David Miller
From: Pavel Belous Date: Thu, 3 Aug 2017 18:15:32 +0300 > From: Pavel Belous > > Add support for GRO (generic receive offload) for aQuantia Atlantic driver. > This results in a perfomance improvement when GRO is enabled. > >

[Patch net-next 2/2] net_sched: use void pointer for filter handle

2017-08-04 Thread Cong Wang
Now we use 'unsigned long fh' as a pointer in every place, it is safe to convert it to a void pointer now. This gets rid of many casts to pointer. Cc: Jamal Hadi Salim Cc: Jiri Pirko Signed-off-by: Cong Wang ---

[Patch net-next 1/2] net_sched: refactor notification code for RTM_DELTFILTER

2017-08-04 Thread Cong Wang
It is confusing to use 'unsigned long fh' as both a handle and a pointer, especially commit 9ee7837449b3 ("net sched filters: fix notification of filter delete with proper handle"). This patch introduces tfilter_del_notify() so that we can pass it as a pointer as before, and we don't need to

[Patch net-next 0/2] net_sched: clean up filter handle

2017-08-04 Thread Cong Wang
This patchset sits in my local branch for a long time, it is time to send it out. It cleans up the ambiguous use of 'unsigned long fh', please see each of them for details. Cong Wang (2): net_sched: refactor notification code for RTM_DELTFILTER net_sched: use void pointer for filter handle

[net-next PATCH v2] bpf: devmap fix mutex in rcu critical section

2017-08-04 Thread John Fastabend
Originally we used a mutex to protect concurrent devmap update and delete operations from racing with netdev unregister notifier callbacks. The notifier hook is needed because we increment the netdev ref count when a dev is added to the devmap. This ensures the netdev reference is valid in the

[PATCH net 0/2] Two BPF fixes for s390

2017-08-04 Thread Daniel Borkmann
Found while testing some other work touching JITs. Thanks! Daniel Borkmann (2): bpf, s390: fix jit branch offset related to ldimm64 bpf, s390: fix build for libbpf and selftest suite arch/s390/net/bpf_jit_comp.c | 3 ++- tools/build/feature/test-bpf.c | 2 ++ tools/lib/bpf/bpf.c

[PATCH net 1/2] bpf, s390: fix jit branch offset related to ldimm64

2017-08-04 Thread Daniel Borkmann
While testing some other work that required JIT modifications, I run into test_bpf causing a hang when JIT enabled on s390. The problematic test case was the one from ddc665a4bb4b (bpf, arm64: fix jit branch offset related to ldimm64), and turns out that we do have a similar issue on s390 as well.

[PATCH net 2/2] bpf, s390: fix build for libbpf and selftest suite

2017-08-04 Thread Daniel Borkmann
The BPF feature test as well as libbpf is missing the __NR_bpf define for s390 and currently refuses to compile (selftest suite depends on libbpf as well). Similar issue was fixed some time ago via b0c47807d31d ("bpf: Add sparc support to tools and samples."), just do the same and add definitions.

[patch net-next v2 00/20] net: sched: summer cleanup part 1, mainly in exts area

2017-08-04 Thread Jiri Pirko
From: Jiri Pirko This patchset is one of the couple cleanup patchsets I have in queue. The motivation aside the obvious need to "make things nicer" is also to prepare for shared filter blocks introduction. That requires tp->q removal, and therefore removal of all tp->q users.

[patch net-next v2 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-08-04 Thread Jiri Pirko
From: Jiri Pirko Use the tcf_exts_has_actions helper instead or directly testing exts->nr_actions in tcf_exts_exec. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 46 +++--- 1 file changed, 23 insertions(+),

[patch net-next v2 01/20] net: sched: sch_atm: use Qdisc_class_common structure

2017-08-04 Thread Jiri Pirko
From: Jiri Pirko Even if it is only for classid now, use this common struct a be aligned with the rest of the classful qdiscs. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim --- net/sched/sch_atm.c | 12 ++-- 1 file

[patch net-next v2 05/20] net: sched: remove redundant helpers tcf_exts_is_predicative and tcf_exts_is_available

2017-08-04 Thread Jiri Pirko
From: Jiri Pirko These two helpers are doing the same as tcf_exts_has_actions, so remove them and use tcf_exts_has_actions instead. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 30 -- net/sched/cls_fw.c | 2 +-

  1   2   >