Performance comparision / qdisc / no qdisc / queueing linux kernel 4.12

2017-08-05 Thread Paweł Staszewski
Hi Want to send some comparisions about poor performance of kernel when simple queueing is enabled So first - kernel performance for forwarded udp packets generated from pktgen: UDP stream ~10Mpps - random destination from network 172.16.0.0/12 + random udp port Forwarding

Re: [PATCH] samples/bpf: Fix cross compiler error with bpf sample

2017-08-05 Thread Joel Fernandes
Hi Daniel, >>> >>> So the only arch that sets __ARCH_WANT_SYSCALL_DEPRECATED >>> is score: >>> >>>$ git grep -n __ARCH_WANT_SYSCALL_DEPRECATED >>>arch/score/include/uapi/asm/unistd.h:7:#define >>> __ARCH_WANT_SYSCALL_DEPRECATED >>>include/uapi/asm-generic/unistd.h:837:#ifdef >>>

Re: [PATCH net] sctp: use __GFP_NOWARN for sctpw.fifo allocation

2017-08-05 Thread Marcelo Ricardo Leitner
On Sat, Aug 05, 2017 at 08:31:09PM +0800, Xin Long wrote: > Chen Wei found a kernel call trace when modprobe sctp_probe with > bufsize set with a huge value. > > It's because in sctpprobe_init when alloc memory for sctpw.fifo, > the size is got from userspace. If it is too large, kernel will >

Re: [PATCH net-next 1/3] net: dsa: assign switch device in legacy code

2017-08-05 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> @@ -251,8 +251,9 @@ dsa_switch_setup(struct dsa_switch_tree *dst, struct >> net_device *master, >> ds->cd = cd; >> ds->ops = ops; >> ds->priv = priv; >> +ds->dev = parent; > > Is this even needed? dsa_switch_alloc() does

Re: Performance comparision / qdisc / no qdisc / queueing linux kernel 4.12

2017-08-05 Thread Paweł Staszewski
With 4.13-rc3 have kernel panic when deleting qdisc - will try to get panic trace W dniu 2017-08-05 o 18:38, Paweł Staszewski pisze: Hi Want to send some comparisions about poor performance of kernel when simple queueing is enabled So first - kernel performance for forwarded udp packets

[PATCH net-next v2 1/3] net: dsa: remove useless argument in legacy setup

2017-08-05 Thread Vivien Didelot
dsa_switch_alloc() already assigns ds-dev, which can be used in dsa_switch_setup_one and dsa_cpu_dsa_setups instead of requiring an additional struct device argument. Signed-off-by: Vivien Didelot --- net/dsa/legacy.c | 16 1 file changed, 8

[PATCH net-next v2 3/3] net: dsa: remove useless args of dsa_slave_create

2017-08-05 Thread Vivien Didelot
dsa_slave_create currently takes 4 arguments while it only needs the related dsa_port and its name. Remove all other arguments. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 2 +- net/dsa/dsa_priv.h | 3 +-- net/dsa/legacy.c | 2 +-

[PATCH net-next v2 2/3] net: dsa: remove useless args of dsa_cpu_dsa_setup

2017-08-05 Thread Vivien Didelot
dsa_cpu_dsa_setup currently takes 4 arguments but they are all available from the dsa_port argument. Remove all others. Signed-off-by: Vivien Didelot --- net/dsa/dsa.c | 10 +- net/dsa/dsa2.c | 4 ++-- net/dsa/dsa_priv.h | 3 +--

[PATCH net-next v2 0/3] net: dsa: remove useless arguments

2017-08-05 Thread Vivien Didelot
Several DSA core setup functions take many arguments, mostly because of the legacy code. This patch series removes the useless args of these functions, where either the dsa_switch or dsa_port argument is enough. Changes in v2: - ds->dev is already assigned by dsa_switch_alloc Vivien Didelot

Fw: [Bug 196595] New: Regression IGMP sysctl init values if not IP_MULTICAST

2017-08-05 Thread Stephen Hemminger
Begin forwarded message: Date: Sat, 05 Aug 2017 23:57:48 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 196595] New: Regression IGMP sysctl init values if not IP_MULTICAST https://bugzilla.kernel.org/show_bug.cgi?id=196595 Bug ID:

Re: [PATCH v8 1/4] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-08-05 Thread Ding Tianhong
On 2017/8/5 5:06, Casey Leedom wrote: > | From: Ding Tianhong > | Sent: Thursday, August 3, 2017 6:44 AM > | > | diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > | index 6967c6b..1e1cdbe 100644 > | --- a/drivers/pci/quirks.c > | +++ b/drivers/pci/quirks.c > |

[PATCH net] net: sched: set xt_tgchk_param par.net properly in ipt_init_target

2017-08-05 Thread Xin Long
Now xt_tgchk_param par in ipt_init_target is a local varibale, par.net is not initialized there. Later when xt_check_target calls target's checkentry in which it may access par.net, it would cause kernel panic. Jaroslav found this panic when running: # ip link add TestIface type dummy # tc

[PATCH v9 4/4] net/cxgb4vf: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-08-05 Thread Ding Tianhong
From: Casey Leedom cxgb4vf Ethernet driver now queries PCIe configuration space to determine if it can send TLPs to it with the Relaxed Ordering Attribute set, just like the pf did. Signed-off-by: Casey Leedom Signed-off-by: Ding Tianhong

[PATCH v9 1/4] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-08-05 Thread Ding Tianhong
From: Casey Leedom The patch adds a new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING to indicate that Relaxed Ordering (RO) attribute should not be used for Transaction Layer Packets (TLP) targetted towards these affected root complexes. Current list of affected parts include some

[PATCH v9 2/4] PCI: Disable PCIe Relaxed Ordering if unsupported

2017-08-05 Thread Ding Tianhong
When bit4 is set in the PCIe Device Control register, it indicates whether the device is permitted to use relaxed ordering. On some platforms using relaxed ordering can have performance issues or due to erratum can cause data-corruption. In such cases devices must avoid using relaxed ordering.

[PATCH v9 3/4] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-08-05 Thread Ding Tianhong
From: Casey Leedom cxgb4 Ethernet driver now queries PCIe configuration space to determine if it can send TLPs to it with the Relaxed Ordering Attribute set. Remove the enable_pcie_relaxed_ordering() to avoid enable PCIe Capability Device Control[Relaxed Ordering Enable] at

[PATCH v9 0/4] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-08-05 Thread Ding Tianhong
Some devices have problems with Transaction Layer Packets with the Relaxed Ordering Attribute set. This patch set adds a new PCIe Device Flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch some known devices with Relaxed Ordering issues, and a use of this new flag by the cxgb4

[PATCH v4 net-next 1/5] net: dsa: lan9303: Change lan9303_xxx_packet_processing() port param.

2017-08-05 Thread Egil Hjelmeland
lan9303_enable_packet_processing, lan9303_disable_packet_processing() Pass port number (0,1,2) as parameter instead of port offset. Because other functions in the module pass port numbers. And to enable simplifications in following patch. Introduce lan9303_write_switch_port(). Signed-off-by:

[PATCH v4 net-next 2/5] net: dsa: lan9303: define LAN9303_NUM_PORTS 3

2017-08-05 Thread Egil Hjelmeland
Will be used instead of '3' in upcomming patches. Signed-off-by: Egil Hjelmeland Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/lan9303-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v4 net-next 3/5] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

2017-08-05 Thread Egil Hjelmeland
Simplify usage of lan9303_enable_packet_processing, lan9303_disable_packet_processing() Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/lan9303-core.c | 24

[PATCH v4 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats

2017-08-05 Thread Egil Hjelmeland
In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic by using new lan9303_read_switch_reg() inside loop. Reduced scope of two variables. Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli

[PATCH v4 net-next 0/5] Refactor lan9303_xxx_packet_processing

2017-08-05 Thread Egil Hjelmeland
This series is purely non functional. It changes the lan9303_enable_packet_processing, lan9303_disable_packet_processing() to pass port number (0,1,2) as parameter instead of port offset. This aligns them with other functions in the module, and makes it possible to simplify the code. The

[PATCH v4 net-next 4/5] net: dsa: lan9303: Rename lan9303_xxx_packet_processing()

2017-08-05 Thread Egil Hjelmeland
The lan9303_enable_packet_processing, lan9303_disable_packet_processing functions operate on port, so the names should reflect that. And to align with lan9303_disable_processing(), rename: lan9303_enable_packet_processing -> lan9303_enable_processing_port lan9303_disable_packet_processing ->

[PATCH net] net: sched: set xt_tgchk_param par.nft_compat with false in ipt_init_target

2017-08-05 Thread Xin Long
Commit 55917a21d0cc ("netfilter: x_tables: add context to know if extension runs from nft_compat") introduced a member nft_compat to xt_tgchk_param structure. But it didn't set it's value for ipt_init_target. With unexpected value in par.nft_compat, it may return unexpected result in some

[PATCH net-next 04/14] sctp: remove the typedef sctp_scope_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_scope_t, and replace with enum sctp_scope in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 4 ++-- include/net/sctp/sctp.h | 4 ++-- include/net/sctp/structs.h | 17

[PATCH net-next 00/14] sctp: remove typedefs from structures part 5

2017-08-05 Thread Xin Long
As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures. All this kind of typedef's using should be removed. This patchset is the part 5 to remove all typedefs in include/net/sctp/constants.h. Just as the

[PATCH net-next 01/14] sctp: remove the typedef sctp_lower_cwnd_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_lower_cwnd_t, and replace with enum sctp_lower_cwnd in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 4 ++-- include/net/sctp/structs.h | 3 ++- net/sctp/transport.c |

[PATCH net-next 06/14] sctp: remove the typedef sctp_sock_state_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_sock_state_t, and replace with enum sctp_sock_state in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 6 +++--- include/net/sctp/sctp.h | 3 ++- 2 files changed, 5

[PATCH net-next 03/14] sctp: remove the typedef sctp_scope_policy_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_scope_policy_t and keep it's members as an anonymous enum. It is also to define SCTP_SCOPE_POLICY_MAX to replace the num 3 in sysctl.c to make codes clear. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 6 --

[PATCH net-next 08/14] sctp: remove the typedef sctp_ierror_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_ierror_t, and replace with enum sctp_ierror in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 5 ++--- net/sctp/sm_make_chunk.c | 23 ---

[PATCH net-next 07/14] sctp: remove the typedef sctp_xmit_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_xmit_t, and replace with enum sctp_xmit in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 4 +-- include/net/sctp/structs.h | 9 --- net/sctp/output.c| 60

[PATCH net-next 09/14] sctp: remove the typedef sctp_state_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_state_t, and replace with enum sctp_state in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/command.h | 4 ++-- include/net/sctp/constants.h | 4 ++-- include/net/sctp/sctp.h | 2 +-

[PATCH net-next 10/14] sctp: remove the typedef sctp_event_primitive_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_event_primitive_t, and replace with enum sctp_event_primitive in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH net-next 05/14] sctp: remove the typedef sctp_transport_cmd_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_transport_cmd_t, and replace with enum sctp_transport_cmd in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 4 ++-- include/net/sctp/structs.h | 7 --- net/sctp/associola.c

[PATCH net-next 13/14] sctp: remove the typedef sctp_event_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_event_t, and replace with enum sctp_event in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 6 ++ include/net/sctp/sm.h| 12 +--- net/sctp/primitive.c

[PATCH net-next 12/14] sctp: remove the typedef sctp_event_timeout_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_event_timeout_t, and replace with enum sctp_event_timeout in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/command.h | 4 ++-- include/net/sctp/constants.h | 8

[PATCH net-next 11/14] sctp: remove the typedef sctp_event_other_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_event_other_t, and replace with enum sctp_event_other in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] atm: idt77252: Adjustments for some function implementations

2017-08-05 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 5 Aug 2017 14:22:33 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (4): Adjust four function calls together with a variable assignment Delete an error message for a failed

[PATCH 2/4] atm: idt77252: Delete an error message for a failed memory allocation in seven functions

2017-08-05 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 5 Aug 2017 12:45:34 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link:

[PATCH net] sctp: use __GFP_NOWARN for sctpw.fifo allocation

2017-08-05 Thread Xin Long
Chen Wei found a kernel call trace when modprobe sctp_probe with bufsize set with a huge value. It's because in sctpprobe_init when alloc memory for sctpw.fifo, the size is got from userspace. If it is too large, kernel will fail and give a warning. As there will be a fallback allocation later,

[PATCH 3/4] atm: idt77252: Improve seven size determinations

2017-08-05 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 5 Aug 2017 13:51:04 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-05 Thread kbuild test robot
Hi Roopa, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/lwtunnel-replace-EXPORT_SYMBOL-with-EXPORT_SYMBOL_GPL/20170805-212202 config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce

[PATCH][net-next] net: hns3: fix spelling mistake: "capabilty" -> "capability"

2017-08-05 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_err error message and also split overly long line to avoid a checkpatch warning. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 ++- 1

[PATCH net-next v2 3/5] ipv6: sr: define core operations for seg6local lightweight tunnel

2017-08-05 Thread David Lebrun
This patch implements a new type of lightweight tunnel named seg6local. A seg6local lwt is defined by a type of action and a set of parameters. The action represents the operation to perform on the packets matching the lwt's route, and is not necessarily an encapsulation. The set of parameters are

[PATCH net-next v2 4/5] ipv6: sr: add rtnetlink functions for seg6local action parameters

2017-08-05 Thread David Lebrun
This patch adds the necessary functions to parse, fill, and compare seg6local rtnetlink attributes, for all defined action parameters. - The SRH parameter defines an SRH to be inserted or encapsulated. - The TABLE parameter defines the table to use for the route lookup of the next segment or

[PATCH net-next v2 0/5] ipv6: sr: add support for advanced local segment processing

2017-08-05 Thread David Lebrun
v2: use EXPORT_SYMBOL_GPL The current implementation of IPv6 SR supports SRH insertion/encapsulation and basic segment endpoint behavior (i.e., processing of an SRH contained in a packet whose active segment (IPv6 DA) is routed to the local node). This behavior simply consists of updating the DA

[PATCH net-next v2 1/5] ipv6: sr: allow SRH insertion with arbitrary segments_left value

2017-08-05 Thread David Lebrun
The seg6_validate_srh() function only allows SRHs whose active segment is the first segment of the path. However, an application may insert an SRH whose active segment is not the first one. Such an application might be for example an SR-aware Virtual Network Function. This patch enables to insert

[PATCH net-next v2 2/5] ipv6: sr: export SRH insertion functions

2017-08-05 Thread David Lebrun
This patch exports the seg6_do_srh_encap() and seg6_do_srh_inline() functions. It also removes the CONFIG_IPV6_SEG6_INLINE knob that enabled the compilation of seg6_do_srh_inline(). This function is now built-in. Signed-off-by: David Lebrun --- include/net/seg6.h

[PATCH net-next v2 5/5] ipv6: sr: implement several seg6local actions

2017-08-05 Thread David Lebrun
This patch implements the following seg6local actions. - SEG6_LOCAL_ACTION_END: regular SRH processing. The DA of the packet is updated to the next segment and forwarded accordingly. - SEG6_LOCAL_ACTION_END_X: same as above, except that the packet is forwarded to the specified IPv6 next-hop.

[PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-05 Thread Xin Long
As we know in some target's checkentry it may dereference par.entryinfo to check entry stuff inside. But when sched action calls xt_check_target, par.entryinfo is set with NULL. It would cause kernel panic when calling some targets. It can be reproduce with: # tc qd add dev eth1 ingress handle

[PATCH net-next 02/14] sctp: remove the typedef sctp_retransmit_reason_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_retransmit_reason_t, and replace with enum sctp_retransmit_reason in the places where it's using this typedef. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 4 ++-- include/net/sctp/structs.h | 4 ++--

[PATCH net-next 14/14] sctp: remove the typedef sctp_subtype_t

2017-08-05 Thread Xin Long
This patch is to remove the typedef sctp_subtype_t, and replace with union sctp_subtype in the places where it's using this typedef. Note that it doesn't fix many indents although it should, as sctp_disposition_t's removal would mess them up again. So better to fix them when removing

[PATCH 1/4] atm: idt77252: Adjust four function calls together with a variable assignment

2017-08-05 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 4 Aug 2017 22:20:08 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 4/4] atm: idt77252: Adjust ten checks for null pointers

2017-08-05 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 5 Aug 2017 14:04:42 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[patch net-next 11/15] nfp: change flows in apps that offload ndo_setup_tc

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Change the flows a bit in preparation of follow-up changes in ndo_setup_tc args. Also, change the error code to align with the rest of the drivers. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/netronome/nfp/bpf/main.c | 16

[patch net-next 08/15] mlxsw: spectrum: push cls_flower and cls_matchall setup_tc processing into separate functions

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Let mlxsw_sp_setup_tc be a splitter for specific setup_tc types and push out cls_flower and cls_matchall specific codes into separate functions. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 81

[patch net-next 15/15] net: sched: get rid of struct tc_to_netdev

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Get rid of struct tc_to_netdev which is now just unnecessary container and rather pass per-type structures down to drivers directly. Along with that, consolidate the naming of per-type structure variables in cls_*. Signed-off-by: Jiri Pirko

[patch net-next 12/15] net: sched: push cls related args into cls_common structure

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko As ndo_setup_tc is generic offload op for whole tc subsystem, does not really make sense to have cls-specific args. So move them under cls_common structurure which is embedded in all cls structs. Signed-off-by: Jiri Pirko ---

[patch net-next 03/15] net: sched: make egress_dev flag part of flower offload struct

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Since this is specific to flower now, make it part of the flower offload struct. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- include/linux/netdevice.h| 1 -

[patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko This patchset focuses on ndo_setup_tc and its args. Currently there are couple of things that do not make much sense. The type is passed in struct tc_to_netdev, but as it is always required, should be arg of the ndo. Other things are passed as args but they

[patch net-next 02/15] net: sched: rename TC_SETUP_MATCHALL to TC_SETUP_CLSMATCHALL

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko In order to be aligned with the rest of the types, rename TC_SETUP_MATCHALL to TC_SETUP_CLSMATCHALL. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- include/linux/netdevice.h | 2

[patch net-next 04/15] cxgb4: push cls_u32 setup_tc processing into a separate function

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Let cxgb_setup_tc be a splitter for specific setup_tc types and push out cls_u32 specific code into a separate function. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 42 +++-- 1 file

[patch net-next 01/15] net: sched: make type an argument for ndo_setup_tc

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Since the type is always present, push it to be a separate argument to ndo_setup_tc. On the way, name the type enum and use it for arg type. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c| 6 +++---

[patch net-next 13/15] net: sched: move prio into cls_common

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko prio is not cls_flower specific, but it is meaningful for all classifiers. Seems that only mlxsw cares about the value. Obviously, cls offload in other drivers is broken. Signed-off-by: Jiri Pirko ---

[patch net-next 14/15] net: sched: change return value of ndo_setup_tc for driver supporting mqprio only

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Change the return value from -EINVAL to -EOPNOTSUPP. The rest of the drivers have it like that, so be aligned. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c| 2 +-

[patch net-next 09/15] mlxsw: spectrum: rename cls arg in matchall processing

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko To sync-up with the naming in the rest of the driver, rename the cls arg. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[patch net-next 10/15] dsa: push cls_matchall setup_tc processing into a separate function

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Let dsa_slave_setup_tc be a splitter for specific setup_tc types and push out cls_matchall specific code into a separate function. Signed-off-by: Jiri Pirko --- net/dsa/slave.c | 33 + 1 file changed, 21

[patch net-next 06/15] mlx5e: push cls_flower and mqprio setup_tc processing into separate functions

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Let mlx5e_setup_tc (former mlx5e_ndo_setup_tc) be a splitter for specific setup_tc types and push out cls_flower and mqprio specific codes into separate functions. Also change the return values so they are the same as in the rest of the drivers.

[patch net-next 05/15] ixgbe: push cls_u32 and mqprio setup_tc processing into separate functions

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Let __ixgbe_setup_tc be a splitter for specific setup_tc types and push out cls_u32 and mqprio specific codes into separate functions. Also change the return values so they are the same as in the rest of the drivers. Signed-off-by: Jiri Pirko

[patch net-next 07/15] mlx5e_rep: push cls_flower setup_tc processing into a separate function

2017-08-05 Thread Jiri Pirko
From: Jiri Pirko Let mlx5e_rep_setup_tc (former mlx5e_rep_ndo_setup_tc) be a splitter for specific setup_tc types and push out cls_flower specific code into a separate function. Signed-off-by: Jiri Pirko ---