Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Xin Long
On Thu, Aug 17, 2017 at 5:57 PM, Cong Wang wrote: > On Wed, Aug 16, 2017 at 1:39 AM, Xin Long wrote: >> On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: >>> On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: > This looks like a completely

[PATCH v2 6/6] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated

2017-08-17 Thread Corentin Labbe
The current way to find if the phy is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the internal one. This patch adds a new way to find if the PHY is internal, via the phy-is-integrated pr

[PATCH v2 5/6] ARM: sun8i: orangepi-one: Set phy-is-integrated to the internal phy node

2017-08-17 Thread Corentin Labbe
This patch add the new phy-is-integrated property to the internal PHY node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one

[PATCH v2 4/6] ARM: sun8i: orangepi-2: Set phy-is-integrated to the internal phy node

2017-08-17 Thread Corentin Labbe
This patch add the new phy-is-integrated property to the internal PHY node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts i

[PATCH v2 1/6] ARM: sun8i: orangepipc: Set phy-is-integrated to the internal phy node

2017-08-17 Thread Corentin Labbe
This patch add the new phy-is-integrated property to the internal PHY node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dt

[PATCH v2 3/6] ARM: sun8i: nanopi-neo: Set phy-is-integrated to the internal phy node

2017-08-17 Thread Corentin Labbe
This patch add the new phy-is-integrated property to the internal PHY node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts i

[PATCH v2 0/6] net: stmmac: Detect PHY location with phy-is-integrated

2017-08-17 Thread Corentin Labbe
Hello The current way to find if the phy is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the integrated one. This patchs series adds a new way to find if the PHY is integrated, via the p

[PATCH v2 2/6] ARM: sun8i: beelink-x2: Set phy-is-integrated to the internal phy node

2017-08-17 Thread Corentin Labbe
This patch add the new phy-is-integrated property to the internal PHY node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts i

[PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-17 Thread Dexuan Cui
Without the patch, vmw_vsock_vmci_transport.ko can automatically load when an application creates an AF_VSOCK socket. This is the expected good behavior on VMware hypervisor, but as we are going to add hv_sock.ko (i.e. Hyper-V transport for AF_VSOCK), we should make sure vmw_vsock_vmci_transport.

RE: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-17 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Wednesday, August 16, 2017 15:34 > > From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > > Without the patch, vmw_vsock_vmci_transport.ko and vmw_vmci.ko can > > > automatically load when an application creates an AF_VSOCK socket. > > > > > > This is the expected good

[PATCH] liquidio: fix spelling mistake: "interuupt" -> "interrupt"

2017-08-17 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_info message Signed-off-by: Colin Ian King --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/et

[PATCH][net-next] net: hns3: ensure media_type is unitialized

2017-08-17 Thread Colin King
From: Colin Ian King Media type is only set if h->ae_algo->ops->get_media_type is called so there is a possibility that media_type is uninitialized when it is used a switch statement. Fix this by initializing media_type to HNAE3_MEDIA_TYPE_UNKNOWN. Detected by CoverityScan, CID#1452624("Uniniti

Re: [PATCH net-next] phylink: Fix an uninitialized variable bug

2017-08-17 Thread Russell King - ARM Linux
On Thu, Aug 10, 2017 at 05:21:12PM +0200, Andrew Lunn wrote: > On Thu, Aug 10, 2017 at 12:35:50AM +0300, Dan Carpenter wrote: > > "ret" isn't necessarily initialized here. > > > > Fixes: 9525ae83959b ("phylink: add phylink infrastructure") > > Signed-off-by: Dan Carpenter > > Reviewed-by: Andrew

Re: Something hitting my total number of connections to the server

2017-08-17 Thread Akshat Kakkar
On Wed, Aug 16, 2017 at 4:04 PM, Eric Dumazet wrote: > On Wed, 2017-08-16 at 10:18 +0530, Akshat Kakkar wrote: >> On Mon, Aug 14, 2017 at 2:37 PM, Akshat Kakkar wrote: >> > I have centos 7.3 (Kernel 3.10) running on a server with 128GB RAM and >> > 2 x 10 Core Xeon Processor. >> > I have hosted a

RE: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

2017-08-17 Thread David Laight
From: Willem de Bruijn > Sent: 17 August 2017 00:27 > Actually, it is safe even without the check. Overflow of the signed integer > is benign here. IIRC the C language states that 'signed integer overflow' is undefined. So 'MAXINT + 1' doesn't have to equal '-MAXINT - 1' (as one would expect on a

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile (fwd)

2017-08-17 Thread Julia Lawall
-TCP-module-and-modifying-Kconfig-and-makefile/20170817-055643 :: branch date: 3 hours ago :: commit date: 3 hours ago >> net/ipv4/tcp_agilesd.c:121:1-3: WARNING: possible condition with no effect >> (if == else) # https://github.com/0day-ci/

Re: [PATCH] i40e{,vf}: Fix out-of-bound cpumask read in IRQ affinity handler

2017-08-17 Thread Stefano Brivio
Jeff, Dave, This is a pretty bad issue as one can crash a kernel quite easily by forcing interrupt affinity changes. We now have three versions of this patch, with exactly the same code changes. I posted mine as I independently found this issue last week and didn't notice Juergen patch which was

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Pablo Neira Ayuso
On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: > > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: > >> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: > >>> This looks like a completely API burden? > >> netfilter xt targets are not

[RFC PATCH v2 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

2017-08-17 Thread Amritha Nambiar
The Mirred/redirect action is extended to forward to a traffic class on the device. The traffic class index needs to be provided in addition to the device's ifindex. Example: # tc filter add dev eth0 protocol ip parent : prio 1 flower\ dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\ skip_s

[RFC PATCH v2 2/6] [net-next]net: i40e: Maintain a mapping of TCs with the VSI seids

2017-08-17 Thread Amritha Nambiar
Add mapping of TCs with the seids of the channel VSIs. TC0 will be mapped to the main VSI seid and all other TCs are mapped to the seid of the channel VSI. Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h |1 + drivers/net/ethernet/intel/i40e/i40e_main.c |2

[RFC PATCH v2 0/6] Configure cloud filters in i40e via tc-flower classifier

2017-08-17 Thread Amritha Nambiar
This patch series enables configuring cloud filters in i40e using the tc-flower classifier. The only tc-filter action supported is to redirect packets to a traffic class on the same device. The tc/mirred:redirect action is extended to accept a traffic class to achieve this. The cloud filters are a

[RFC PATCH v2 5/6] [net-next]net: i40e: Clean up of cloud filters

2017-08-17 Thread Amritha Nambiar
Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. v2: Moved field comments in struct i40e_cloud_filter to the right. Removed hlist_empty check from i40e_cloud_filter_exit() Signed-off-by: Amritha Nambiar --- drivers/net/ethernet/intel/i40e/i40e.h

[RFC PATCH v2 3/6] [net-next]net: i40e: Extend set switch config command to accept cloud filter mode

2017-08-17 Thread Amritha Nambiar
Add definitions for L4 filters and switch modes based on cloud filters modes and extend the set switch config command to include the additional cloud filter mode. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 31 +

[RFC PATCH v2 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters

2017-08-17 Thread Amritha Nambiar
Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. v2: Added I40E_CHECK_STRUCT_LEN check to AQ command structs and added AQ definitions to i40evf for consistency based on Shannon's feedbac

[RFC PATCH v2 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc flower classifier

2017-08-17 Thread Amritha Nambiar
This patch enables tc-flower based hardware offloads. tc flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and adds cloud filters to configure these tc-flower filt

[PATCH v2] bpf: Update sysctl documentation to list all supported architectures

2017-08-17 Thread Michael Ellerman
The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list, and break it out to indicate which architectures support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT (HAVE_EBPF_JIT). Signed-off-by: Michael Ellerman --- Documentation/sys

Re: [PATCH] bpf: Update sysctl documentation to list all supported architectures

2017-08-17 Thread Michael Ellerman
Daniel Borkmann writes: > On 08/16/2017 01:10 PM, Michael Ellerman wrote: >> Daniel Borkmann writes: >>> On 08/16/2017 07:15 AM, Michael Ellerman wrote: diff --git a/Documentation/sysctl/net.txt b/Documentation/sysctl/net.txt index 14db18c970b1..f68356024d09 100644 --- a/Documentat

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Pablo Neira Ayuso
On Thu, Aug 17, 2017 at 12:02:20PM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: > > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: > > > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: > > >> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang > > >> wrote

[RFC, iproute2 PATCH v2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-17 Thread Amritha Nambiar
The Mirred/redirect action is extended to accept a traffic class on the device in addition to the device's ifindex. Usage: mirred Example: # tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent : prio 1 flower\ dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\ skip

Re: [PATCH net] PCI: fix the return value for the pci_find_pcie_root_port()

2017-08-17 Thread Thierry Reding
On Thu, Aug 17, 2017 at 10:25:30AM +0800, Ding Tianhong wrote: > The pci_find_pcie_root_port() would return NULL if the given > dev is already a Root Port, it looks like unfriendly to the > PCIe Root Port device, Thierry and Bjorn suggest to let this > function return the given dev under this circu

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread David Lamparter
Hi Nikolay, On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: > On 16/08/17 20:01, David Lamparter wrote: > > This implements holding dst metadata information in the bridge layer, > > but only for unicast entries in the MAC table. Multicast is still left > > to design and impl

[PATCH] PCI: Allow PCI express root ports to find themselves

2017-08-17 Thread Thierry Reding
uld now be redundant. Fixes: a99b646afa8a ("PCI: Disable PCIe Relaxed Ordering if unsupported") Fixes: c56d4450eb68 ("PCI: Turn off Request Attributes to avoid Chelsio T5 Completion erratum") Signed-off-by: Thierry Reding --- This applies on top of and was tested on next-20170817.

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Xin Long
On Thu, Aug 17, 2017 at 10:33 PM, Pablo Neira Ayuso wrote: > On Thu, Aug 17, 2017 at 12:02:20PM +0200, Pablo Neira Ayuso wrote: >> On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: >> > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: >> > > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote

Re: Something hitting my total number of connections to the server

2017-08-17 Thread Eric Dumazet
On Thu, 2017-08-17 at 14:35 +0530, Akshat Kakkar wrote: > I upgraded to 4.4 but still experiencing same issue. > Please help. Still too old kernel, shoot again ;)

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread Nikolay Aleksandrov
On 17/08/17 14:03, David Lamparter wrote: > Hi Nikolay, > > > On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: >> On 16/08/17 20:01, David Lamparter wrote: >>> This implements holding dst metadata information in the bridge layer, >>> but only for unicast entries in the MAC tab

[PATCH V5 net-next 00/21] Huawei HiNIC Ethernet Driver

2017-08-17 Thread Aviad Krawczyk
The patch-set contains the support of the HiNIC Ethernet driver for hinic family of PCIE Network Interface Cards. The Huawei's PCIE HiNIC card is a new Ethernet card and hence there was a need of a new driver. The current driver is meant to be used for the Physical Function and there would soon b

Re: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

2017-08-17 Thread Daniel Borkmann
On 08/17/2017 12:30 PM, Michael Ellerman wrote: The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list, and break it out to indicate which architectures support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT (HAVE_EBPF_JIT). Signe

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread Nikolay Aleksandrov
On 17/08/17 14:39, Nikolay Aleksandrov wrote: > On 17/08/17 14:03, David Lamparter wrote: >> Hi Nikolay, >> >> >> On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: >>> On 16/08/17 20:01, David Lamparter wrote: This implements holding dst metadata information in the bridge la

[PATCH V5 net-next 00/21] Huawei HiNIC Ethernet Driver

2017-08-17 Thread Aviad Krawczyk
The patch-set contains the support of the HiNIC Ethernet driver for hinic family of PCIE Network Interface Cards. The Huawei's PCIE HiNIC card is a new Ethernet card and hence there was a need of a new driver. The current driver is meant to be used for the Physical Function and there would soon b

[PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface

2017-08-17 Thread Aviad Krawczyk
Initialize hw interface as part of the nic initialization for accessing hw. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- Documentation/networking/hinic.txt | 125 ++ drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/Makefile

[PATCH V5 net-next 09/21] net-next/hinic: Add Rx mode and link event handler

2017-08-17 Thread Aviad Krawczyk
Add port management message for setting Rx mode in the card, used for rx_mode netdev operation. The link event handler is used for getting a notification about the link state. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 17 ++

[PATCH V5 net-next 21/21] net-next/hinic: Add netpoll

2017-08-17 Thread Aviad Krawczyk
Add more netdev operation - netpoll. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 +++ drivers/net/ethernet/huawei/hinic/hinic_main.c | 20 2 files changed, 27 insertions(+) diff --git a/MAINTAINERS b/MA

[PATCH V5 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-08-17 Thread Aviad Krawczyk
Add ethtool operations and statistics operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 3 + drivers/net/ethernet/huawei/hinic/hinic_main.c | 218 - drivers/net/ethernet/huawei/hinic/hinic_port.c |

[PATCH V5 net-next 18/21] net-next/hinic: Add Rx handler

2017-08-17 Thread Aviad Krawczyk
Set the io resources in the nic and handle rx events by qp operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_csr.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.

[PATCH V5 net-next 17/21] net-next/hinic: Add cmdq completion handler

2017-08-17 Thread Aviad Krawczyk
Add cmdq completion handler for getting a notification about the completion of cmdq commands. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 297 +- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.h | 12 + 2 f

[PATCH V5 net-next 15/21] net-next/hinic: Add ceqs

2017-08-17 Thread Aviad Krawczyk
Initialize the completion event queues and handle ceq events by calling the registered handlers. Used for cmdq command completion. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 16 ++ drivers/net/ethernet/huawei/hinic/hinic_hw_cs

[PATCH V5 net-next 19/21] net-next/hinic: Add Tx operation

2017-08-17 Thread Aviad Krawczyk
Add transmit operation for sending data by qp operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h| 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 47 +++ drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h | 22 ++ d

[PATCH V5 net-next 16/21] net-next/hinic: Add cmdq commands

2017-08-17 Thread Aviad Krawczyk
Add cmdq commands for setting queue pair contexts in the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_common.c | 25 ++ drivers/net/ethernet/huawei/hinic/hinic_common.h | 9 + drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 282

[PATCH V5 net-next 13/21] net-next/hinic: Set qp context

2017-08-17 Thread Aviad Krawczyk
Update the nic about the resources of the queue pairs. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 5 +- drivers/net/ethernet/huawei/hinic/hinic_common.c | 55 ++ drivers/net/ethernet/huawei/hinic/hinic_common.h |

[PATCH V5 net-next 12/21] net-next/hinic: Add qp resources

2017-08-17 Thread Aviad Krawczyk
Create the resources for queue pair operations: doorbell area, consumer index address and producer index address. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_hw_if.h | 1 + drivers

[PATCH V5 net-next 14/21] net-next/hinic: Initialize cmdq

2017-08-17 Thread Aviad Krawczyk
Create the work queues for cmdq and update the nic about the work queue contexts. cmdq commands are used for updating the nic about the qp contexts. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 282 +- drivers

[PATCH V5 net-next 11/21] net-next/hinic: Add wq

2017-08-17 Thread Aviad Krawczyk
Create work queues for being used by the queue pairs. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_common.h | 25 ++ drivers/net/ethernet/huawei/hinic/hinic_hw_io.c | 69 ++- driv

[PATCH V5 net-next 10/21] net-next/hinic: Add logical Txq and Rxq

2017-08-17 Thread Aviad Krawczyk
Create the logical queues of the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 5 +- drivers/net/ethernet/huawei/hinic/hinic_dev.h| 5 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 131 + drivers

[PATCH V5 net-next 08/21] net-next/hinic: Add port management commands

2017-08-17 Thread Aviad Krawczyk
Add the port management commands that are sent as management messages. The port management commands are used for netdev operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_dev.h

[PATCH V5 net-next 07/21] net-next/hinic: Add aeqs

2017-08-17 Thread Aviad Krawczyk
Handle aeq elements that are accumulated on the aeq by calling the registered handler for the specific event. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_csr.h | 49 +++ drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 464 +++

[PATCH V5 net-next 04/21] net-next/hinic: Initialize api cmd hw

2017-08-17 Thread Aviad Krawczyk
Update the hardware about api cmd resources and initialize it. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 173 - .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.h | 38 + drivers/net/ethernet/huawei/h

[PATCH V5 net-next 06/21] net-next/hinic: Add api cmd commands

2017-08-17 Thread Aviad Krawczyk
Add the api cmd commands for sending management messages to the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 329 - .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.h | 65 drivers/net/ethernet/hua

[PATCH V5 net-next 05/21] net-next/hinic: Add management messages

2017-08-17 Thread Aviad Krawczyk
Add the management messages for sending to api cmd and add the asynchronous event handler for the completion of the messages. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 35 ++ .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.h

[PATCH V5 net-next 03/21] net-next/hinic: Initialize api cmd resources

2017-08-17 Thread Aviad Krawczyk
Initialize api cmd resources as part of management initialization. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 446 + .../net/ethernet/huawei/hini

[PATCH V5 net-next 02/21] net-next/hinic: Initialize hw device components

2017-08-17 Thread Aviad Krawczyk
Initialize hw device by calling the initialization functions of aeqs and management channel. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile| 3 +- drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 172 -- dri

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread David Lamparter
On Thu, Aug 17, 2017 at 02:51:12PM +0300, Nikolay Aleksandrov wrote: > On 17/08/17 14:39, Nikolay Aleksandrov wrote: > > On 17/08/17 14:03, David Lamparter wrote: > >> On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: [cut] > >>> and hitting the fast path for everyone in a few di

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread David Lamparter
On Thu, Aug 17, 2017 at 02:10:20PM +0200, David Lamparter wrote: > On Thu, Aug 17, 2017 at 02:51:12PM +0300, Nikolay Aleksandrov wrote: > > On 17/08/17 14:39, Nikolay Aleksandrov wrote: > > > On 17/08/17 14:03, David Lamparter wrote: > > >> On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksand

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread Nikolay Aleksandrov
On 17/08/17 15:10, David Lamparter wrote: > On Thu, Aug 17, 2017 at 02:51:12PM +0300, Nikolay Aleksandrov wrote: >> On 17/08/17 14:39, Nikolay Aleksandrov wrote: >>> On 17/08/17 14:03, David Lamparter wrote: On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: > [cut] > and

[PATCH V6 02/21] net-next/hinic: Initialize hw device components

2017-08-17 Thread Aviad Krawczyk
Initialize hw device by calling the initialization functions of aeqs and management channel. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile| 3 +- drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 172 -- dri

[PATCH V6 20/21] net-next/hinic: Add ethtool and stats

2017-08-17 Thread Aviad Krawczyk
Add ethtool operations and statistics operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 3 + drivers/net/ethernet/huawei/hinic/hinic_main.c | 218 - drivers/net/ethernet/huawei/hinic/hinic_port.c |

[PATCH V6 21/21] net-next/hinic: Add netpoll

2017-08-17 Thread Aviad Krawczyk
Add more netdev operation - netpoll. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 +++ drivers/net/ethernet/huawei/hinic/hinic_main.c | 20 2 files changed, 27 insertions(+) diff --git a/MAINTAINERS b/MA

[PATCH V6 18/21] net-next/hinic: Add Rx handler

2017-08-17 Thread Aviad Krawczyk
Set the io resources in the nic and handle rx events by qp operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_csr.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.

[PATCH V6 19/21] net-next/hinic: Add Tx operation

2017-08-17 Thread Aviad Krawczyk
Add transmit operation for sending data by qp operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h| 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 47 +++ drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h | 22 ++ d

[PATCH V6 16/21] net-next/hinic: Add cmdq commands

2017-08-17 Thread Aviad Krawczyk
Add cmdq commands for setting queue pair contexts in the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_common.c | 25 ++ drivers/net/ethernet/huawei/hinic/hinic_common.h | 9 + drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 282

[PATCH V6 17/21] net-next/hinic: Add cmdq completion handler

2017-08-17 Thread Aviad Krawczyk
Add cmdq completion handler for getting a notification about the completion of cmdq commands. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 297 +- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.h | 12 + 2 f

[PATCH V6 15/21] net-next/hinic: Add ceqs

2017-08-17 Thread Aviad Krawczyk
Initialize the completion event queues and handle ceq events by calling the registered handlers. Used for cmdq command completion. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 16 ++ drivers/net/ethernet/huawei/hinic/hinic_hw_cs

[PATCH V6 14/21] net-next/hinic: Initialize cmdq

2017-08-17 Thread Aviad Krawczyk
Create the work queues for cmdq and update the nic about the work queue contexts. cmdq commands are used for updating the nic about the qp contexts. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 282 +- drivers

[PATCH V6 13/21] net-next/hinic: Set qp context

2017-08-17 Thread Aviad Krawczyk
Update the nic about the resources of the queue pairs. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 5 +- drivers/net/ethernet/huawei/hinic/hinic_common.c | 55 ++ drivers/net/ethernet/huawei/hinic/hinic_common.h |

[PATCH V6 11/21] net-next/hinic: Add wq

2017-08-17 Thread Aviad Krawczyk
Create work queues for being used by the queue pairs. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_common.h | 25 ++ drivers/net/ethernet/huawei/hinic/hinic_hw_io.c | 69 ++- driv

[PATCH V6 10/21] net-next/hinic: Add logical Txq and Rxq

2017-08-17 Thread Aviad Krawczyk
Create the logical queues of the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 5 +- drivers/net/ethernet/huawei/hinic/hinic_dev.h| 5 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 131 + drivers

[PATCH V6 12/21] net-next/hinic: Add qp resources

2017-08-17 Thread Aviad Krawczyk
Create the resources for queue pair operations: doorbell area, consumer index address and producer index address. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_hw_if.h | 1 + drivers

[PATCH V6 09/21] net-next/hinic: Add Rx mode and link event handler

2017-08-17 Thread Aviad Krawczyk
Add port management message for setting Rx mode in the card, used for rx_mode netdev operation. The link event handler is used for getting a notification about the link state. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 17 ++

[PATCH V6 08/21] net-next/hinic: Add port management commands

2017-08-17 Thread Aviad Krawczyk
Add the port management commands that are sent as management messages. The port management commands are used for netdev operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- drivers/net/ethernet/huawei/hinic/hinic_dev.h

[PATCH V6 07/21] net-next/hinic: Add aeqs

2017-08-17 Thread Aviad Krawczyk
Handle aeq elements that are accumulated on the aeq by calling the registered handler for the specific event. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_csr.h | 49 +++ drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 464 +++

[PATCH V6 06/21] net-next/hinic: Add api cmd commands

2017-08-17 Thread Aviad Krawczyk
Add the api cmd commands for sending management messages to the nic. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 329 - .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.h | 65 drivers/net/ethernet/hua

[PATCH V6 03/21] net-next/hinic: Initialize api cmd resources

2017-08-17 Thread Aviad Krawczyk
Initialize api cmd resources as part of management initialization. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/Makefile | 4 +- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 446 + .../net/ethernet/huawei/hini

[PATCH V6 05/21] net-next/hinic: Add management messages

2017-08-17 Thread Aviad Krawczyk
Add the management messages for sending to api cmd and add the asynchronous event handler for the completion of the messages. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 35 ++ .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.h

[PATCH V6 00/21] Huawei HiNIC Ethernet Driver

2017-08-17 Thread Aviad Krawczyk
The patch-set contains the support of the HiNIC Ethernet driver for hinic family of PCIE Network Interface Cards. The Huawei's PCIE HiNIC card is a new Ethernet card and hence there was a need of a new driver. The current driver is meant to be used for the Physical Function and there would soon b

[PATCH V6 04/21] net-next/hinic: Initialize api cmd hw

2017-08-17 Thread Aviad Krawczyk
Update the hardware about api cmd resources and initialize it. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 173 - .../net/ethernet/huawei/hinic/hinic_hw_api_cmd.h | 38 + drivers/net/ethernet/huawei/h

[PATCH V6 01/21] net-next/hinic: Initialize hw interface

2017-08-17 Thread Aviad Krawczyk
Initialize hw interface as part of the nic initialization for accessing hw. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- Documentation/networking/hinic.txt | 125 ++ drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/Makefile

Re: [net-next PATCH 07/10] bpf: add access to sock fields and pkt data from sk_skb programs

2017-08-17 Thread Daniel Borkmann
On 08/17/2017 07:42 AM, Alexei Starovoitov wrote: On 8/15/17 10:33 PM, John Fastabend wrote: +static int sk_skb_prologue(struct bpf_insn *insn_buf, bool direct_write, + const struct bpf_prog *prog) +{ +struct bpf_insn *insn = insn_buf; + +if (!direct_write) +return

Re: [PATCH net] PCI: fix the return value for the pci_find_pcie_root_port()

2017-08-17 Thread Ding Tianhong
On 2017/8/17 18:51, Thierry Reding wrote: > On Thu, Aug 17, 2017 at 10:25:30AM +0800, Ding Tianhong wrote: >> The pci_find_pcie_root_port() would return NULL if the given >> dev is already a Root Port, it looks like unfriendly to the >> PCIe Root Port device, Thierry and Bjorn suggest to let this

Re: [PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

2017-08-17 Thread Jorgen S. Hansen
> On Aug 16, 2017, at 12:15 AM, Dexuan Cui wrote: > > > With the current code, when vsock_dequeue_accept() is removing a sock > from the list, nothing prevents vsock_enqueue_accept() from adding a new > sock into the list concurrently. We should add a lock to protect the list. > For the VMCI

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Pablo Neira Ayuso
On Thu, Aug 17, 2017 at 11:24:00PM +1200, Xin Long wrote: > On Thu, Aug 17, 2017 at 10:33 PM, Pablo Neira Ayuso > wrote: > > On Thu, Aug 17, 2017 at 12:02:20PM +0200, Pablo Neira Ayuso wrote: > >> On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: > >> > On Wed, Aug 9, 2017 at 7:33 AM, Con

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread David Lamparter
On Thu, Aug 17, 2017 at 02:39:43PM +0300, Nikolay Aleksandrov wrote: > On 17/08/17 14:03, David Lamparter wrote: > > On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: > >> On 16/08/17 20:01, David Lamparter wrote: > >> and hitting the fast path for everyone in a few different pla

Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and netpoll

2017-08-17 Thread Aviad Krawczyk
Hi David, Fixed in V6. In V5 patch-set there was a problem in cover-letter msg-id. Thanks, Aviad On 8/16/2017 9:47 PM, David Miller wrote: > From: Aviad Krawczyk > Date: Wed, 16 Aug 2017 20:03:06 +0800 > >> +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff >> *skb, >> +

Re: 100% CPU load when generating traffic to destination network that nexthop is not reachable

2017-08-17 Thread Paweł Staszewski
Hi Wondering if someone have idea how to optimise this ? From reali life perspective it is really important for optimising this behavior cause imagine situation - just normal situation with linux acting as a router: Lets say we have Linux router with connected 3 customers and one upstream

Re: [PATCH V6 21/21] net-next/hinic: Add netpoll

2017-08-17 Thread Sergei Shtylyov
Hello. On 08/17/2017 03:25 PM, Aviad Krawczyk wrote: Add more netdev operation - netpoll. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 +++ drivers/net/ethernet/huawei/hinic/hinic_main.c | 20 2 fi

[PATCH net-next] bpf: fix liveness propagation to parent in spilled stack slots

2017-08-17 Thread Daniel Borkmann
Using parent->regs[] when propagating REG_LIVE_READ for spilled regs doesn't work since parent->regs[] denote the set of normal registers but not spilled ones. Propagate to the correct regs. Fixes: dc503a8ad984 ("bpf/verifier: track liveness for pruning") Reported-by: Dan Carpenter Signed-off-by:

Re: [PATCH V6 21/21] net-next/hinic: Add netpoll

2017-08-17 Thread Aviad Krawczyk
Will be fixed in V7 Thanks On 8/17/2017 3:57 PM, Sergei Shtylyov wrote: > Hello. > > On 08/17/2017 03:25 PM, Aviad Krawczyk wrote: > >> Add more netdev operation - netpoll. >> >> Signed-off-by: Aviad Krawczyk >> Signed-off-by: Zhao Chen >> --- >> MAINTAINERS

Re: [PATCH 1/6] bridge: learn dst metadata in FDB

2017-08-17 Thread Nikolay Aleksandrov
On 17/08/17 15:45, David Lamparter wrote: > On Thu, Aug 17, 2017 at 02:39:43PM +0300, Nikolay Aleksandrov wrote: >> On 17/08/17 14:03, David Lamparter wrote: >>> On Wed, Aug 16, 2017 at 11:38:06PM +0300, Nikolay Aleksandrov wrote: On 16/08/17 20:01, David Lamparter wrote: and hitting the

[PATCH net-next] bpf: no need to nullify ri->map in xdp_do_redirect

2017-08-17 Thread Daniel Borkmann
We are guaranteed to have a NULL ri->map in this branch since we test for it earlier, so we don't need to reset it here. Signed-off-by: Daniel Borkmann --- net/core/filter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index e9f8dce..ea3ca34 100644 ---

LL,

2017-08-17 Thread adeola chambers
Dear friend, I am Barrister Wilson, I want you to work with me as a foreign partner also as family members or close relatives to my late client who deposited USD$14.3Million dollars in a bank here my country before his death, and a nationality of your country, The bank has given me notice as his La

Re: TCP fast retransmit issues

2017-08-17 Thread Jeremy Harris
On 28/07/17 08:27, Willy Tarreau wrote: > I didn't want to suggest names but since you did it first ;-) Indeed it's > mostly on the same device that I've been bothered a lot by their annoying > randomization. I used to know by memory the exact command to type to disable > it, but I don't anymore (s

[PATCH] net: ibm: ibmvnic: constify vio_device_id

2017-08-17 Thread Arvind Yadav
vio_device_id are not supposed to change at runtime. All functions working with vio_device_id provided by work with const vio_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

  1   2   3   4   >