[PATCH stable-3.16 3/3] VSOCK: Detach QP check should filter out non matching QPs.

2017-09-13 Thread Michal Hocko
From: Jorgen Hansen commit 8ab18d71de8b07d2c4d6f984b718418c09ea45c5 upstream. The check in vmci_transport_peer_detach_cb should only allow a detach when the qp handle of the transport matches the one in the detach message. Testing: Before this change, a detach from a peer

[PATCH stable-3.16 1/3] VSOCK: sock_put wasn't safe to call in interrupt context

2017-09-13 Thread Michal Hocko
From: Jorgen Hansen commit 4ef7ea9195ea73262cd9730fb54e1eb726da157b upstream. In the vsock vmci_transport driver, sock_put wasn't safe to call in interrupt context, since that may call the vsock destructor which in turn calls several functions that should only be called from

[PATCH stable-3.16 2/3] VSOCK: Fix lockdep issue.

2017-09-13 Thread Michal Hocko
From: Jorgen Hansen commit 8566b86ab9f0f45bc6f7dd422b21de9d0cf5415a upstream. The recent fix for the vsock sock_put issue used the wrong initializer for the transport spin_lock causing an issue when running with lockdep checking. Testing: Verified fix on kernel with lockdep

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Denys Fedoryshchenko
On 2017-09-13 18:51, Eric Dumazet wrote: On Wed, 2017-09-13 at 18:20 +0300, Denys Fedoryshchenko wrote: Hi, I noticed after increasing bandwidth over some amount HTB started to throttle classes it should not throttle. Also estimated rate in htb totally wrong, while byte counters is correct.

RFC: Audit Kernel Container IDs

2017-09-13 Thread Richard Guy Briggs
Containers are a userspace concept. The kernel knows nothing of them. The Linux audit system needs a way to be able to track the container provenance of events and actions. Audit needs the kernel's help to do this. Since the concept of a container is entirely a userspace concept, a trigger

Re: scheduling while atomic from vmci_transport_recv_stream_cb in 3.16 kernels

2017-09-13 Thread Jorgen S. Hansen
> On Sep 12, 2017, at 11:08 AM, Michal Hocko wrote: > > Hi, > we are seeing the following splat with Debian 3.16 stable kernel > > BUG: scheduling while atomic: MATLAB/26771/0x0100 > Modules linked in: veeamsnap(O) hmac cbc cts nfsv4 dns_resolver > rpcsec_gss_krb5 nfsd

Re: [PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-13 Thread Sergei Shtylyov
Hello! On 09/13/2017 03:17 PM, Yoshihiro Shimoda wrote: Add a new compatible string for the R8A77995 (R-Car D3) RAVB. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread David Miller
From: Allen Pais Date: Wed, 13 Sep 2017 13:02:15 +0530 > Signed-off-by: Allen Pais This is quite pointless as the caller doesn't do anything with the value, it just tests whether a negative value is returned or not.

[PATCH net v2 3/3] nfp: wait for the NSP resource to appear on boot

2017-09-13 Thread Jakub Kicinski
The control process (NSP) may take some time to complete its initialization. This is not a problem on most servers, but on very fast-booting machines it may not be ready for operation when driver probes the device. There is also a version of the flash in the wild where NSP tries to train the

[PATCH net v2 0/3] nfp: wait more carefully for card init

2017-09-13 Thread Jakub Kicinski
Hi! The first patch is a small fix for flower offload, we need a whitelist of supported matches, otherwise the unsupported ones will be ignored. The second and the third patch are adding wait/polling to the probe path. We had reports of driver failing probe because it couldn't find the control

[PATCH net v2 1/3] nfp: add whitelist of supported flow dissector

2017-09-13 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Previously we did not check the flow dissector against a list of allowed and supported flow key dissectors. This patch introduces such a list and correctly rejects unsupported flow keys. Fixes: 43f84b72c50d ("nfp: add metadata

Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation

2017-09-13 Thread Joe Perches
On Wed, 2017-09-13 at 13:02 +0530, Allen Pais wrote: > Signed-off-by: Allen Pais I think the changelog for this series of conversions should show that you've validated the change by inspecting the return call chain at each modified line. Also, it seems you've cc'd the same

Re: netfilter: xt_bpf: ABI issue in xt_bpf_info_v1?

2017-09-13 Thread Willem de Bruijn
On Wed, Sep 13, 2017 at 11:05 AM, Willem de Bruijn wrote: > On Wed, Sep 13, 2017 at 10:22 AM, Jan Engelhardt wrote: >> >> On Wednesday 2017-09-13 15:24, Shmulik Ladkani wrote: >>> >>>One way to fix is to have iptables open the object (using the

Re: Memory leaks in conntrack

2017-09-13 Thread Florian Westphal
Florian Westphal wrote: > Cong Wang wrote: > > While testing my TC filter patches (so not related to conntrack), the > > following memory leaks are shown up: > > > > unreferenced object 0x9b19ba551228 (size 128): > > comm "chronyd", pid 338,

Re: [PATCH net] sctp: potential read out of bounds in sctp_ulpevent_type_enabled()

2017-09-13 Thread David Miller
From: Dan Carpenter Date: Wed, 13 Sep 2017 12:20:28 +0300 > @@ -154,7 +154,11 @@ static inline int sctp_ulpevent_type_enabled(__u16 > sn_type, >struct sctp_event_subscribe *mask) > { > char *amask = (char *) mask; > -

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Denys Fedoryshchenko
On 2017-09-13 19:16, Eric Dumazet wrote: On Wed, 2017-09-13 at 18:34 +0300, Denys Fedoryshchenko wrote: Well, probably i am answering my own question, removing estimator from classes seems drastically improve situation. It seems estimator has some issues that cause shaper to behave incorrectly

Re: [patch net] net: sched: fix use-after-free in tcf_action_destroy and tcf_del_walker

2017-09-13 Thread David Miller
From: Jiri Pirko Date: Wed, 13 Sep 2017 17:32:37 +0200 > From: Jiri Pirko > > Recent commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu") removed > freeing in call_rcu, which changed already existing hard-to-hit > race condition into 100% hit: > > [

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 19:27 +0300, Denys Fedoryshchenko wrote: > On 2017-09-13 19:16, Eric Dumazet wrote: > > On Wed, 2017-09-13 at 18:34 +0300, Denys Fedoryshchenko wrote: > >> Well, probably i am answering my own question, removing estimator from > >> classes seems drastically improve situation.

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-13 Thread Matthew Rosato
On 09/13/2017 04:13 AM, Jason Wang wrote: > > > On 2017年09月13日 09:16, Jason Wang wrote: >> >> >> On 2017年09月13日 01:56, Matthew Rosato wrote: >>> We are seeing a regression for a subset of workloads across KVM guests >>> over a virtual bridge between host kernel 4.12 and 4.13. Bisecting >>>

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 20:12 +0300, Denys Fedoryshchenko wrote: > For my case, as load increased now, i am hitting same issue (i tried to > play with quantum / bursts as well, didnt helped): > > tc -s -d class show dev eth3.777 classid 1:111;sleep 5;tc -s -d class > show dev eth3.777 classid

[PATCH net 3/3] nfp: wait for the NSP resource to appear on boot

2017-09-13 Thread Jakub Kicinski
The control process (NSP) may take some time to complete its initialization. This is not a problem on most servers, but on very fast-booting machines it may not be ready for operation when driver probes the device. There is also a version of the flash in the wild where NSP tries to train the

[PATCH net 1/3] nfp: add whitelist of supported flow dissector

2017-09-13 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Previously we did not check the flow dissector against a list of allowed and supported flow key dissectors. This patch introduces such a list and correctly rejects unsupported flow keys. Fixes: 43f84b72c50d ("nfp: add metadata

Re: [PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-13 Thread Sergei Shtylyov
On 09/13/2017 07:02 PM, Sergei Shtylyov wrote: Add a new compatible string for the R8A77995 (R-Car D3) RAVB. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 18:34 +0300, Denys Fedoryshchenko wrote: > Well, probably i am answering my own question, removing estimator from > classes seems drastically improve situation. > It seems estimator has some issues that cause shaper to behave > incorrectly (throttling traffic while it

[patch net] net: sched: fix use-after-free in tcf_action_destroy and tcf_del_walker

2017-09-13 Thread Jiri Pirko
From: Jiri Pirko Recent commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu") removed freeing in call_rcu, which changed already existing hard-to-hit race condition into 100% hit: [ 598.599825] BUG: unable to handle kernel NULL pointer dereference at 0030 [

Re: Memory leaks in conntrack

2017-09-13 Thread Cong Wang
On Wed, Sep 13, 2017 at 1:05 AM, Florian Westphal wrote: > Cong Wang wrote: >> While testing my TC filter patches (so not related to conntrack), the >> following memory leaks are shown up: >> >> unreferenced object 0x9b19ba551228 (size 128): >>

Re: [PATCH net 0/3] nfp: wait more carefully for card init

2017-09-13 Thread Jakub Kicinski
On Wed, 13 Sep 2017 09:39:02 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Wed, 13 Sep 2017 08:51:28 -0700 > > > The first patch is a small fix for flower offload, we need a whitelist > > of supported matches, otherwise the unsupported ones will be

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Denys Fedoryshchenko
On 2017-09-13 19:55, Eric Dumazet wrote: On Wed, 2017-09-13 at 09:42 -0700, Eric Dumazet wrote: On Wed, 2017-09-13 at 19:27 +0300, Denys Fedoryshchenko wrote: > On 2017-09-13 19:16, Eric Dumazet wrote: > > On Wed, 2017-09-13 at 18:34 +0300, Denys Fedoryshchenko wrote: > >> Well, probably i am

Re: [PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure.

2017-09-13 Thread David Sterba
On Wed, Sep 13, 2017 at 01:02:19PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais > --- > fs/btrfs/check-integrity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c > index

[PATCH net 0/3] nfp: wait more carefully for card init

2017-09-13 Thread Jakub Kicinski
Hi! The first patch is a small fix for flower offload, we need a whitelist of supported matches, otherwise the unsupported ones will be ignored. The second and the third patch are adding wait/polling to the probe path. We had reports of driver failing probe because it couldn't find the control

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 18:20 +0300, Denys Fedoryshchenko wrote: > Hi, > > I noticed after increasing bandwidth over some amount HTB started to > throttle classes it should not throttle. > Also estimated rate in htb totally wrong, while byte counters is > correct. > > Is there any overflow or

[PATCH net 2/3] nfp: wait for board state before talking to the NSP

2017-09-13 Thread Jakub Kicinski
Board state informs us which low-level initialization stages the card has completed. We should wait for the card to be fully initialized before trying to communicate with it, not only before we configure passing traffic. Signed-off-by: Jakub Kicinski Reviewed-by:

Re: [PATCH net 0/3] nfp: wait more carefully for card init

2017-09-13 Thread David Miller
From: Jakub Kicinski Date: Wed, 13 Sep 2017 08:51:28 -0700 > The first patch is a small fix for flower offload, we need a whitelist > of supported matches, otherwise the unsupported ones will be ignored. > > The second and the third patch are adding wait/polling to

[PATCH net] be2net: fix TSO6/GSO issue causing TX-stall on Lancer/BEx

2017-09-13 Thread Suresh Reddy
IPv6 TSO requests with extension hdrs are a problem to the Lancer and BEx chips. Workaround is to disable TSO6 feature for such packets. Also in Lancer chips, MSS less than 256 was resulting in TX stall. Fix this by disabling GSO when MSS less than 256. Signed-off-by: Suresh Reddy

HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Denys Fedoryshchenko
Hi, I noticed after increasing bandwidth over some amount HTB started to throttle classes it should not throttle. Also estimated rate in htb totally wrong, while byte counters is correct. Is there any overflow or something? X520 card (but XL710 same) br1 8000.90e2ba86c38c

Re: scheduling while atomic from vmci_transport_recv_stream_cb in 3.16 kernels

2017-09-13 Thread Michal Hocko
On Wed 13-09-17 15:07:26, Jorgen S. Hansen wrote: > > > On Sep 12, 2017, at 11:08 AM, Michal Hocko wrote: > > > > Hi, > > we are seeing the following splat with Debian 3.16 stable kernel > > > > BUG: scheduling while atomic: MATLAB/26771/0x0100 > > Modules linked in:

Re: [PATCH net] be2net: fix TSO6/GSO issue causing TX-stall on Lancer/BEx

2017-09-13 Thread David Miller
From: Suresh Reddy Date: Wed, 13 Sep 2017 11:12:42 -0400 > IPv6 TSO requests with extension hdrs are a problem to the > Lancer and BEx chips. Workaround is to disable TSO6 feature > for such packets. > > Also in Lancer chips, MSS less than 256 was resulting in TX

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 09:42 -0700, Eric Dumazet wrote: > On Wed, 2017-09-13 at 19:27 +0300, Denys Fedoryshchenko wrote: > > On 2017-09-13 19:16, Eric Dumazet wrote: > > > On Wed, 2017-09-13 at 18:34 +0300, Denys Fedoryshchenko wrote: > > >> Well, probably i am answering my own question, removing

Re: Memory leaks in conntrack

2017-09-13 Thread Cong Wang
On Wed, Sep 13, 2017 at 9:45 AM, Cong Wang wrote: > On Wed, Sep 13, 2017 at 1:05 AM, Florian Westphal wrote: >> Cong Wang wrote: >>> While testing my TC filter patches (so not related to conntrack), the >>> following memory

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 20:35 +0300, Denys Fedoryshchenko wrote: > Overlimits never appear in HTB as i know, here is simulation on this > class that have constant "at least" 1G traffic, i throttled it to 1Kbit > to simulate forced drops: > > shapernew ~ # sh /etc/shaper.cfg;sleep 1;tc -s -d

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Cole Robinson
On 09/13/2017 01:40 PM, Cole Robinson wrote: > On 09/13/2017 01:28 PM, Josef Bacik wrote: >> Sorry I thought I had made this other fix, can you apply this on top of the >> other one and try that? I have more things to try if this doesn’t work, >> sorry you are playing go between, but I want to

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

2017-09-13 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 7, 2017 at 3:09 PM, Florian Fainelli wrote: > On 08/23/2017 10:13 AM, Florian Fainelli wrote: >> On 08/23/2017 04:45 AM, Geert Uytterhoeven wrote: >>> On Tue, Aug 22, 2017 at 8:49 PM, Florian Fainelli >>> wrote: On

[PATCH v2] net: smsc911x: Quieten netif during suspend

2017-09-13 Thread Geert Uytterhoeven
If the network interface is kept running during suspend, the net core may call net_device_ops.ndo_start_xmit() while the Ethernet device is still suspended, which may lead to a system crash. E.g. on sh73a0/kzm9g and r8a73a4/ape6evm, the external Ethernet chip is driven by a PM controlled clock.

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Chuck Ebbert
On Wed, 13 Sep 2017 17:28:25 + Josef Bacik wrote: > Sorry I thought I had made this other fix, can you apply this on top > of the other one and try that? I have more things to try if this > doesn’t work, sorry you are playing go between, but I want to make > sure I know

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Josef Bacik
Alright thanks, this should fix it. Josef On 9/13/17, 12:14 PM, "Cole Robinson" wrote: On 09/13/2017 01:40 PM, Cole Robinson wrote: > On 09/13/2017 01:28 PM, Josef Bacik wrote: >> Sorry I thought I had made this other fix, can you apply this on top of the >> other one and

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Cole Robinson
On 09/13/2017 01:28 PM, Josef Bacik wrote: > Sorry I thought I had made this other fix, can you apply this on top of the > other one and try that? I have more things to try if this doesn’t work, > sorry you are playing go between, but I want to make sure I know _which_ fix > actually fixes the

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-13 Thread Rob Herring
On Fri, Sep 08, 2017 at 09:43:25AM +0200, Corentin Labbe wrote: > On Fri, Sep 08, 2017 at 09:25:38AM +0200, Maxime Ripard wrote: > > On Fri, Sep 08, 2017 at 09:11:51AM +0200, Corentin Labbe wrote: > > > This patch add documentation about the MDIO switch used on sun8i-h3-emac > > > for integrated

[PATCH] ath10k: make ath10k_hw_ce_regs const

2017-09-13 Thread Bhumika Goyal
Make them const as they are not modified in the file referencing them. They are only stored in the const field 'hw_ce_reg' of an ath10k structure. Also, make the declarations in the header const. Signed-off-by: Bhumika Goyal --- drivers/net/wireless/ath/ath10k/hw.c | 4 ++--

Re: [PATCH net] perf/bpf: fix a clang compilation issue

2017-09-13 Thread Nick Desaulniers
great, thanks! On Mon, Sep 11, 2017 at 2:28 PM, David Miller wrote: > From: Yonghong Song > Date: Thu, 7 Sep 2017 18:36:15 -0700 > >> clang does not support variable length array for structure member. >> It has the following error during compilation: >> >>

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Josef Bacik
Sorry I thought I had made this other fix, can you apply this on top of the other one and try that? I have more things to try if this doesn’t work, sorry you are playing go between, but I want to make sure I know _which_ fix actually fixes the problem, and then clean up in followup patches.

Re: [PATCH v5 02/10] dt-bindings: net: Restore sun8i dwmac binding

2017-09-13 Thread Rob Herring
On Fri, Sep 08, 2017 at 09:11:48AM +0200, Corentin Labbe wrote: > This patch restore dt-bindings documentation about dwmac-sun8i > This reverts commit 8aa33ec2f481 ("dt-bindings: net: Revert sun8i dwmac > binding") Why? > > Signed-off-by: Corentin Labbe > --- >

Re: scheduling while atomic from vmci_transport_recv_stream_cb in 3.16 kernels

2017-09-13 Thread Jorgen S. Hansen
> On Sep 13, 2017, at 5:19 PM, Michal Hocko wrote: > > On Wed 13-09-17 15:07:26, Jorgen S. Hansen wrote: >> >>> On Sep 12, 2017, at 11:08 AM, Michal Hocko wrote: >>> >>> Hi, >>> we are seeing the following splat with Debian 3.16 stable kernel >>> >>>

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Denys Fedoryshchenko
On 2017-09-13 20:20, Eric Dumazet wrote: On Wed, 2017-09-13 at 20:12 +0300, Denys Fedoryshchenko wrote: For my case, as load increased now, i am hitting same issue (i tried to play with quantum / bursts as well, didnt helped): tc -s -d class show dev eth3.777 classid 1:111;sleep 5;tc -s -d

[PATCH] MAINTAINERS: review Renesas DT bindings as well

2017-09-13 Thread Sergei Shtylyov
When adding myself as a reviewer for the Renesas Ethernet drivers I somehow forgot about the bindings -- I want to review them as well. Fixes: 8e6569af3a1b ("MAINTAINERS: add myself as Renesas Ethernet drivers reviewer") Signed-off-by: Sergei Shtylyov ---

Re: RFC: Audit Kernel Container IDs

2017-09-13 Thread Carlos O'Donell
On 09/13/2017 12:13 PM, Richard Guy Briggs wrote: > Containers are a userspace concept. The kernel knows nothing of them. I am looking at this RFC from a userspace perspective, particularly from the loader's point of view and the unshare syscall and the semantics that arise from the use of it.

Re: [PATCH/RFC net-next] ravb: RX checksum offload

2017-09-13 Thread Sergei Shtylyov
Hello! On 09/12/2017 04:04 PM, Simon Horman wrote: Add support for RX checksum offload. This is enabled by default and may be disabled and re-enabled using ethtool: # ethtool -K eth0 rx off # ethtool -K eth0 rx on The RAVB provides a simple checksumming scheme which appears to be

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Eric Dumazet
On Wed, 2017-09-13 at 10:58 -0700, Eric Dumazet wrote: > On Wed, 2017-09-13 at 20:35 +0300, Denys Fedoryshchenko wrote: > > > Overlimits never appear in HTB as i know, here is simulation on this > > class that have constant "at least" 1G traffic, i throttled it to 1Kbit > > to simulate forced

[PATCH net] net_sched: gen_estimator: fix scaling error in bytes/packets samples

2017-09-13 Thread Eric Dumazet
From: Eric Dumazet Denys reported wrong rate estimations with HTB classes. It appears the bug was added in linux-4.10, since my tests where using intervals of one second only. HTB using 4 sec default rate estimators, reported rates were 4x higher. We need to properly

Re: [PATCH] MAINTAINERS: review Renesas DT bindings as well

2017-09-13 Thread David Miller
From: Sergei Shtylyov Date: Wed, 13 Sep 2017 22:28:53 +0300 > When adding myself as a reviewer for the Renesas Ethernet drivers > I somehow forgot about the bindings -- I want to review them as well. > > Fixes: 8e6569af3a1b ("MAINTAINERS: add myself as

Re: [patch net] net: sched: fix use-after-free in tcf_action_destroy and tcf_del_walker

2017-09-13 Thread David Miller
From: Jiri Pirko Date: Wed, 13 Sep 2017 22:50:06 +0200 > Wed, Sep 13, 2017 at 06:34:28PM CEST, da...@davemloft.net wrote: >>From: Jiri Pirko >>Date: Wed, 13 Sep 2017 17:32:37 +0200 >> >>> From: Jiri Pirko >>> >>> Recent commit

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Josef Bacik
> On Sep 13, 2017, at 12:46 PM, Chuck Ebbert wrote: > > On Wed, 13 Sep 2017 17:28:25 + > Josef Bacik wrote: > >> Sorry I thought I had made this other fix, can you apply this on top >> of the other one and try that? I have more things to try if this

Re: [PATCH net] net_sched: gen_estimator: fix scaling error in bytes/packets samples

2017-09-13 Thread David Miller
From: Eric Dumazet Date: Wed, 13 Sep 2017 11:16:45 -0700 > From: Eric Dumazet > > Denys reported wrong rate estimations with HTB classes. > > It appears the bug was added in linux-4.10, since my tests > where using intervals of one second only. >

Re: [patch net] net: sched: fix use-after-free in tcf_action_destroy and tcf_del_walker

2017-09-13 Thread Jiri Pirko
Wed, Sep 13, 2017 at 06:34:28PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 13 Sep 2017 17:32:37 +0200 > >> From: Jiri Pirko >> >> Recent commit d7fb60b9cafb ("net_sched: get rid of tcfa_rcu") removed >> freeing in call_rcu, which changed

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Cole Robinson
On 09/13/2017 03:44 PM, Josef Bacik wrote: > Alright thanks, this should fix it. > Still no luck with all three patches applied to fedora 4.12.8-300 RPM. Pretty sure I didn't mess up the testing but since I rarely do kernel builds it's not impossible... Thanks, Cole

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-13 Thread Franklin S Cooper Jr
On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: > During test transmitting using CAN-FD at high bitrates (4 Mbps) only > resulted in errors. Scoping the signals I noticed that only a single bit > was being transmitted and with a bit more investigation realized the actual > MCAN IP would go

Re: [PATCH] net: Convert int functions to bool

2017-09-13 Thread Alexey Dobriyan
> Global function ipv6_rcv_saddr_equal and static functions > ipv6_rcv_saddr_equal and ipv4_rcv_saddr_equal currently return int. > > bool is slightly more descriptive for these functions so change > their return type from int to bool. >From code generation POV "int" is better for non-inlined

[PATCH v2 net] sctp: potential read out of bounds in sctp_ulpevent_type_enabled()

2017-09-13 Thread Dan Carpenter
This code causes a static checker warning because Smatch doesn't trust anything that comes from skb->data. I've reviewed this code and I do think skb->data can be controlled by the user here. The sctp_event_subscribe struct has 13 __u8 fields and we want to see if ours is non-zero. sn_type can

Job Offer In USA

2017-09-13 Thread Valero Energy Recruitment
Valero Energy Oil & Gas Company USA Employment Opportunity in Texas, USA. Oil & Gas Sector ( NEW PLANT RIG ) Salary Range $7,000 USD - $11,700 Per Month Kindly send your CV/RESUME for more details regarding our Job Program, Employment offers for all Offices. CC: Forward All

Re: netfilter: xt_bpf: ABI issue in xt_bpf_info_v1?

2017-09-13 Thread Willem de Bruijn
On Wed, Sep 13, 2017 at 10:22 AM, Jan Engelhardt wrote: > > On Wednesday 2017-09-13 15:24, Shmulik Ladkani wrote: >> >>One way to fix is to have iptables open the object (using the stored >>xt_bpf_info_v1->path), gaining a new process local fd for the object, >>just after getting

Re: HTB going crazy over ~5Gbit/s (4.12.9, but problem present in older kernels as well)

2017-09-13 Thread Denys Fedoryshchenko
Well, probably i am answering my own question, removing estimator from classes seems drastically improve situation. It seems estimator has some issues that cause shaper to behave incorrectly (throttling traffic while it should not). But i guess thats a bug? As i was not able to predict such

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Laura Abbott
On 09/12/2017 04:12 PM, Josef Bacik wrote: First I’m super sorry for the top post, I’m at plumbers and I forgot to upload my muttrc to my new cloud instance, so I’m screwed using outlook. I have a completely untested, uncompiled patch that I think will fix the problem, would you mind giving

[PATCH net v2 2/3] nfp: wait for board state before talking to the NSP

2017-09-13 Thread Jakub Kicinski
Board state informs us which low-level initialization stages the card has completed. We should wait for the card to be fully initialized before trying to communicate with it, not only before we configure passing traffic. Signed-off-by: Jakub Kicinski ---

Re: [PATCH v2] net: smsc911x: Quieten netif during suspend

2017-09-13 Thread Florian Fainelli
On 09/13/2017 10:42 AM, Geert Uytterhoeven wrote: > If the network interface is kept running during suspend, the net core > may call net_device_ops.ndo_start_xmit() while the Ethernet device is > still suspended, which may lead to a system crash. > > E.g. on sh73a0/kzm9g and r8a73a4/ape6evm,

Re: [PATCH RFC v1 0/3] Support for tap user-space access with veth interfaces

2017-09-13 Thread Jason Wang
On 2017年09月07日 08:34, sainath.gran...@intel.com wrote: From: Sainath Grandhi This patchset adds a tap device driver for veth virtual network interface. With this implementation, tap character interface can be added only to the peer veth interface. Adding tap

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-13 Thread Jason Wang
On 2017年09月14日 00:59, Matthew Rosato wrote: On 09/13/2017 04:13 AM, Jason Wang wrote: On 2017年09月13日 09:16, Jason Wang wrote: On 2017年09月13日 01:56, Matthew Rosato wrote: We are seeing a regression for a subset of workloads across KVM guests over a virtual bridge between host kernel 4.12

Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation

2017-09-13 Thread Allen
> I think the changelog for this series of conversions > should show that you've validated the change by > inspecting the return call chain at each modified line. > > Also, it seems you've cc'd the same mailing lists for > all of the patches modified by this series. > > It would be better to

[PATCH] staging: irda: Remove typedef struct

2017-09-13 Thread Haneen Mohammed
This patch remove typedef from a structure with all its ocurrences since using typedefs for structures is discouraged. Issue found using Coccinelle: @r1@ type T; @@ typedef struct { ... } T; @script:python c1@ T2; T << r1.T; @@ if T[-2:] =="_t" or T[-2:] == "_T": coccinelle.T2 = T[:-2];

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-13 Thread Sekhar Nori
On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: > > > On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: >> During test transmitting using CAN-FD at high bitrates (4 Mbps) only >> resulted in errors. Scoping the signals I noticed that only a single bit >> was being

Re: RFC: Audit Kernel Container IDs

2017-09-13 Thread Richard Guy Briggs
On 2017-09-13 14:33, Carlos O'Donell wrote: > On 09/13/2017 12:13 PM, Richard Guy Briggs wrote: > > Containers are a userspace concept. The kernel knows nothing of them. > > I am looking at this RFC from a userspace perspective, particularly from > the loader's point of view and the unshare

[PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

2017-09-13 Thread nixiaoming
If fanout_add is preempted after running po-> fanout = match and before running __fanout_link, it will cause BUG_ON when __unregister_prot_hook call __fanout_unlink so, we need add mutex_lock(_mutex) to __unregister_prot_hook or add spin_lock(>bind_lock) before po-> fanout = match test on linux

[PATCH net] tcp: update skb->skb_mstamp more carefully

2017-09-13 Thread Eric Dumazet
From: Eric Dumazet liujian reported a problem in TCP_USER_TIMEOUT processing with a patch in tcp_probe_timer() : https://www.spinics.net/lists/netdev/msg454496.html After investigations, the root cause of the problem is that we update skb->skb_mstamp of skbs in write

[PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-13 Thread Yoshihiro Shimoda
Add a new compatible string for the R8A77995 (R-Car D3) RAVB. Acked-by: Geert Uytterhoeven Signed-off-by: Yoshihiro Shimoda --- Changes from v1: - Based on r8a77970 patch. https://marc.info/?l=linux-renesas-soc=150524655515476 -

Re: [PATCH v2 net] sctp: potential read out of bounds in sctp_ulpevent_type_enabled()

2017-09-13 Thread David Miller
From: Dan Carpenter Date: Thu, 14 Sep 2017 02:00:54 +0300 > This code causes a static checker warning because Smatch doesn't trust > anything that comes from skb->data. I've reviewed this code and I do > think skb->data can be controlled by the user here. > > The

[PATCH] net: ipv4: fix l3slave check for index returned in IP_PKTINFO

2017-09-13 Thread David Ahern
rt_iif is only set to the actual egress device for the output path. The recent change to consider the l3slave flag when returning IP_PKTINFO works for local traffic (the correct device index is returned), but it broke the more typical use case of packets received from a remote host always

[PATCH net] udpv6: Fix the checksum computation when HW checksum does not apply

2017-09-13 Thread Subash Abhinov Kasiviswanathan
While trying an ESP transport mode encryption for UDPv6 packets of datagram size 1436 with MTU 1500, checksum error was observed in the secondary fragment. This error occurs due to the UDP payload checksum being missed out when computing the full checksum for these packets in

RE: [PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

2017-09-13 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov > Sent: Thursday, September 14, 2017 1:02 AM > > Hello! > > On 09/13/2017 03:17 PM, Yoshihiro Shimoda wrote: > > > Add a new compatible string for the R8A77995 (R-Car D3) RAVB. > > > > Signed-off-by: Yoshihiro Shimoda > > --- >

Re: [RFC net-next 2/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-13 Thread Vinicius Costa Gomes
Hi Henrik, Henrik Austad writes: > On Thu, Aug 31, 2017 at 06:26:22PM -0700, Vinicius Costa Gomes wrote: >> This queueing discipline implements the shaper algorithm defined by >> the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. >> >> It's primary usage is to apply some

RE: [Intel-wired-lan] [PATCH] igb: check memory allocation failure

2017-09-13 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Christophe JAILLET > Sent: Monday, August 28, 2017 10:13 AM > To: Waskiewicz Jr, Peter ; Kirsher, Jeffrey T > > Cc: netdev@vger.kernel.org;

[PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

2017-09-13 Thread nixiaoming
If fanout_add is preempted after running po-> fanout = match and before running __fanout_link, it will cause BUG_ON when __unregister_prot_hook call __fanout_unlink so, we need add mutex_lock(_mutex) to __unregister_prot_hook or add spin_lock(>bind_lock) before po-> fanout = match test on linux

Re: [PATCH v2] geneve: Fix setting ttl value in collect metadata mode

2017-09-13 Thread Pravin Shelar
On Wed, Sep 13, 2017 at 4:15 AM, 严海双 wrote: > > >> On 2017年9月13日, at 上午7:43, Pravin Shelar wrote: >> >> On Tue, Sep 12, 2017 at 12:05 AM, Haishuang Yan >> wrote: >>> Similar to vxlan/ipip tunnel, if key->tos

[PATCH] net: Convert int functions to bool

2017-09-13 Thread Joe Perches
Global function ipv6_rcv_saddr_equal and static functions ipv6_rcv_saddr_equal and ipv4_rcv_saddr_equal currently return int. bool is slightly more descriptive for these functions so change their return type from int to bool. Signed-off-by: Joe Perches ---

Re: [PATCH] net: Convert int functions to bool

2017-09-13 Thread Joe Perches
On Thu, 2017-09-14 at 01:31 +0300, Alexey Dobriyan wrote: > > Global function ipv6_rcv_saddr_equal and static functions > > ipv6_rcv_saddr_equal and ipv4_rcv_saddr_equal currently return int. > > > > bool is slightly more descriptive for these functions so change > > their return type from int to

Re: [PATCH] tcp: TCP_USER_TIMEOUT can not work in tcp_probe_timer()

2017-09-13 Thread liujian
在 2017/9/12 23:38, Eric Dumazet 写道: > On Tue, 2017-09-12 at 08:05 -0700, Eric Dumazet wrote: >> On Tue, 2017-09-12 at 14:08 +0800, liujian wrote: >>> Hi, >>> >>> In the scenario, tcp server side IP changed, and at that memont, >>> userspace application still send data continuously; >>>

[PATCH 03/10] driver:gpu: return -ENOMEM on allocation failure.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/gpu/drm/gma500/mid_bios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c index d75ecb3..1fa1633 100644 --- a/drivers/gpu/drm/gma500/mid_bios.c

Re: [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types

2017-09-13 Thread Jorgen S. Hansen
> On Sep 12, 2017, at 6:34 PM, Stefan Hajnoczi wrote: > > This patch fixes the following compiler errors when userspace > applications use the vm_sockets.h header: > > include/uapi/linux/vm_sockets.h:148:32: error: invalid application of > ‘sizeof’ to incomplete type

Re: [PATCH] ravb: document R8A77970 bindings

2017-09-13 Thread Geert Uytterhoeven
On Tue, Sep 12, 2017 at 10:02 PM, Sergei Shtylyov wrote: > R-Car V3M (R8A77970) SoC also has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov

Re: [PATCH] ipv4: Namespaceify tcp_fastopen knob

2017-09-13 Thread 严海双
> On 2017年9月13日, at 上午11:57, David Miller wrote: > > From: Haishuang Yan > Date: Tue, 12 Sep 2017 18:30:57 +0800 > >> Different namespace application might require enable TCP Fast Open >> feature independently of the host. >> >>

[no subject]

2017-09-13 Thread kindergartenchaos2
<>

RE: [PATCH] qed: remove unnecessary call to memset

2017-09-13 Thread Kalluru, Sudarsana
-Original Message- From: Himanshu Jha [mailto:himanshujha199...@gmail.com] Sent: 12 September 2017 16:49 To: Mintz, Yuval Cc: Elior, Ariel ; Dept-Eng Everest Linux L2 ; netdev@vger.kernel.org;

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-13 Thread Simon Horman
On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: > On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman > wrote: > > Allow matching on options in tunnel headers. > > This makes use of existing tunnel metadata support. > > Simon, > > This patch is about matching

  1   2   >