[net PATCH] bnxt_en: check for ingress qdisc in flower offload

2017-09-18 Thread Sathya Perla
Check for ingress-only qdisc for flower offload, as other qdiscs are not supported for flower offload. Suggested-by: Jiri Pirko Signed-off-by: Sathya Perla --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 4 1 file changed, 4 insertions(+)

[PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm

2017-09-18 Thread Colin King
From: Colin Ian King Pointer tcm is being initialized and is never read, it is only being used to determine the size of struct tcmsg. Clean this up by removing variable tcm and explicitly using the sizeof struct tcmsg rather than *tcm. Cleans up clang warning:

Re: [pktgen script v2 0/2] Add a pktgen sample script of NUMA awareness

2017-09-18 Thread Jesper Dangaard Brouer
On Sun, 17 Sep 2017 20:36:36 +0800 Robert Hoo wrote: > Change log > v2: > Rebased to https://github.com/netoptimizer/network-testing/tree/master/pktgen Hi Robert, Thank you for submitting this against my git tree[1]. I skimmed the patches and they looked okay. I'll

Re: [PATCH net-next] net: remove useless comments in dst.c

2017-09-18 Thread Sergei Shtylyov
Hello! On 9/18/2017 9:00 AM, Duan Jiong wrote: dst gc related code has been removed in commit 5b7c9a8ff828, so those comments are no longer Please also specify the commit's summary line enclosed in (""). useful. Signed-off-by: Duan Jiong [...] MBR, Sergei

Re: [PATCH net-next 09/11] bnxt_en: bnxt: add TC flower filter offload support

2017-09-18 Thread Jiri Pirko
Mon, Sep 18, 2017 at 11:43:22AM CEST, sathya.pe...@broadcom.com wrote: >On Mon, Sep 11, 2017 at 7:06 PM, Jiri Pirko wrote: >> Mon, Aug 28, 2017 at 07:40:33PM CEST, michael.c...@broadcom.com wrote: >>>From: Sathya Perla >>> >>>This patch adds support

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-18 Thread Henrik Austad
On Mon, Sep 18, 2017 at 10:02:14AM +0200, Richard Cochran wrote: > On Thu, Aug 31, 2017 at 06:26:20PM -0700, Vinicius Costa Gomes wrote: > > * Time-aware shaper (802.1Qbv): > > I just posted a working alternative showing how to handle 802.1Qbv and > many other Ethernet field buses. Yes, I saw

Re: [net PATCH] bnxt_en: check for ingress qdisc in flower offload

2017-09-18 Thread Jiri Pirko
Mon, Sep 18, 2017 at 01:35:37PM CEST, sathya.pe...@broadcom.com wrote: >Check for ingress-only qdisc for flower offload, as other qdiscs >are not supported for flower offload. > >Suggested-by: Jiri Pirko >Signed-off-by: Sathya Perla Reviewed-by: Jiri

[PATCH] sunrpc: remove redundant initialization of sock

2017-09-18 Thread Colin King
From: Colin Ian King sock is being initialized and then being almost immediately updated hence the initialized value is not being used and is redundant. Remove the initialization. Cleans up clang warning: warning: Value stored to 'sock' during its initialization is

Re: Page allocator bottleneck

2017-09-18 Thread Tariq Toukan
On 15/09/2017 1:23 PM, Mel Gorman wrote: On Thu, Sep 14, 2017 at 07:49:31PM +0300, Tariq Toukan wrote: Insights: Major degradation between #1 and #2, not getting any close to linerate! Degradation is fixed between #2 and #3. This is because page allocator cannot stand the higher allocation

[PATCH 03/16] thunderbolt: Move enum tb_cfg_pkg_type to thunderbolt.h

2017-09-18 Thread Mika Westerberg
These will be needed by Thunderbolt services when sending and receiving XDomain control messages. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat ---

[PATCH 14/16] thunderbolt: Add function to retrieve DMA device for the ring

2017-09-18 Thread Mika Westerberg
This is needed when Thunderbolt service drivers need to DMA map memory before it is passed down to the ring. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat ---

[PATCH 04/16] thunderbolt: Move thunderbolt domain structure to thunderbolt.h

2017-09-18 Thread Mika Westerberg
These are needed by Thunderbolt services so move them to thunderbolt.h to make sure they are available outside of drivers/thunderbolt. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel Bernat

[PATCH 02/16] thunderbolt: Add support for XDomain properties

2017-09-18 Thread Mika Westerberg
Thunderbolt XDomain discovery protocol uses directories which contain properties and other directories to exchange information about what capabilities the remote host supports. This also includes identification information like device ID and name. This adds support for parsing and formatting

[PATCH 1/3] net: set tb->fast_sk_family

2017-09-18 Thread josef
From: Josef Bacik We need to set the tb->fast_sk_family properly so we can use the proper comparison function for all subsequent reuseport bind requests. Cc: sta...@vger.kernel.org Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreuseport when adding a reuseport sk")

[PATCH 0/3] fix reuseaddr regression

2017-09-18 Thread josef
I introduced a regression when reworking the fastreuse port stuff that allows bind conflicts to occur once a reuseaddr socket successfully opens on an existing tb. The root cause is I reversed an if statement which caused us to set the tb as if there were no owners on the socket if there were,

[PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-18 Thread Nisar Sayed
Allow EEPROM write for less than MAX_EEPROM_SIZE Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [PATCH RFC V1 net-next 2/6] net: skbuff: Add a field to support time based transmission.

2017-09-18 Thread Eric Dumazet
On Mon, 2017-09-18 at 09:41 +0200, Richard Cochran wrote: > Signed-off-by: Richard Cochran > --- > include/linux/skbuff.h | 2 ++ > 1 file changed, 2 insertions(+) Why skb->tstamp can not be used ? AFAIK, fact that it might be overwritten by packet captures should not

Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a future transmit time.

2017-09-18 Thread Eric Dumazet
On Mon, 2017-09-18 at 09:41 +0200, Richard Cochran wrote: > + case SO_TXTIME: > + if (!sock_flag(sk, SOCK_TXTIME)) > + return -EINVAL; > + sockc->transmit_time = *(u64 *)CMSG_DATA(cmsg); 1) No guarantee the CMSG is properly aligned on arches that

[PATCH 06/16] thunderbolt: Add support for XDomain discovery protocol

2017-09-18 Thread Mika Westerberg
When two hosts are connected over a Thunderbolt cable, there is a protocol they can use to communicate capabilities supported by the host. The discovery protocol uses automatically configured control channel (ring 0) and is build on top of request/response transactions using special XDomain

[PATCH 12/16] thunderbolt: Use spinlock in NHI serialization

2017-09-18 Thread Mika Westerberg
This is needed because ring polling functionality can be called from atomic contexts when networking and other high-speed traffic is transferred over a Thunderbolt cable. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet

[PATCH 07/16] thunderbolt: Configure interrupt throttling for all interrupts

2017-09-18 Thread Mika Westerberg
This will keep the interrupt delivery rate reasonable. The value used here (128 us) is a recommendation from the hardware people. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg

[PATCH 00/16] Thunderbolt networking

2017-09-18 Thread Mika Westerberg
Hi all, In addition of tunneling PCIe, Display Port and USB traffic, Thunderbolt allows connecting two hosts (domains) over a Thunderbolt cable. It is possible to tunnel arbitrary data packets over such connection using high-speed DMA rings available in the Thunderbolt host controller. In order

[PATCH 13/16] thunderbolt: Add polling mode for rings

2017-09-18 Thread Mika Westerberg
In order to support things like networking over Thunderbolt cable, there needs to be a way to switch the ring to a mode where it can be polled with the interrupt masked. We implement such mode so that the caller can allocate a ring by passing pointer to a function that is then called when an

[PATCH 09/16] thunderbolt: Export ring handling functions to modules

2017-09-18 Thread Mika Westerberg
These are used by Thunderbolt services to send and receive frames over the high-speed DMA rings. We also put the functions to tb_ namespace to make sure we do not collide with others and add missing kernel-doc comments for the exported functions. Signed-off-by: Mika Westerberg

Re: Page allocator bottleneck

2017-09-18 Thread Tariq Toukan
On 18/09/2017 10:44 AM, Aaron Lu wrote: On Mon, Sep 18, 2017 at 03:34:47PM +0800, Aaron Lu wrote: On Sun, Sep 17, 2017 at 07:16:15PM +0300, Tariq Toukan wrote: It's nice to have the option to dynamically play with the parameter. But maybe we should also think of changing the default

[PATCH 01/16] byteorder: Move {cpu_to_be32,be32_to_cpu}_array() from Thunderbolt to core

2017-09-18 Thread Mika Westerberg
We will be using these when communicating XDomain discovery protocol over Thunderbolt link but they might be useful for other drivers as well. Make them available through byteorder/generic.h. Suggested-by: Andy Shevchenko Signed-off-by: Mika Westerberg

RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm

2017-09-18 Thread David Laight
From: Eric Dumazet > Sent: 18 September 2017 16:01 ... > > > - err = nlmsg_parse(nlh, sizeof(*tcm), tca, TCA_MAX, NULL, NULL); > > > + err = nlmsg_parse(nlh, sizeof(struct tcmsg), tca, TCA_MAX, NULL, NULL); > > > > Would sizeof(*nlmsg_data(nlh)) be cleaner?? > > Not really, since > > static

[PATCH 08/16] thunderbolt: Add support for frame mode

2017-09-18 Thread Mika Westerberg
When high-speed DMA paths are used to transfer arbitrary data over a Thunderbolt link, DMA rings should be in frame mode instead of raw mode. The latter is used by the control channel (ring 0). In frame mode each data frame can hold up to 4kB payload. This patch modifies the DMA ring code to

[PATCH 10/16] thunderbolt: Move ring descriptor flags to thunderbolt.h

2017-09-18 Thread Mika Westerberg
A Thunderbolt service driver might need to check if there was an error with the descriptor when in frame mode. We also add two Rx specific error flags RING_DESC_CRC_ERROR and RING_DESC_BUFFER_OVERRUN. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet

[PATCH 05/16] thunderbolt: Move tb_switch_phy_port_from_link() to thunderbolt.h

2017-09-18 Thread Mika Westerberg
A Thunderbolt service might need to find the physical port from a link the cable is connected to. For instance networking driver uses this information to generate MAC address according the Apple ThunderboltIP protocol. Move this function to thunderbolt.h and rename it to tb_phy_port_from_link()

Re: [PATCH 06/16] thunderbolt: Add support for XDomain discovery protocol

2017-09-18 Thread Dan Williams
On Mon, 2017-09-18 at 18:30 +0300, Mika Westerberg wrote: > When two hosts are connected over a Thunderbolt cable, there is a > protocol they can use to communicate capabilities supported by the > host. > The discovery protocol uses automatically configured control channel > (ring 0) and is build

RE: [Intel-wired-lan] [PATCH] fm10k: Use seq_putc() in fm10k_dbg_desc_break()

2017-09-18 Thread Singh, Krishneil K
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of SF Markus Elfring > Sent: Monday, May 8, 2017 9:18 AM > To: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; Kirsher, > Jeffrey T > > Cc:

[PATCH 16/16] thunderbolt: Add support for networking over Thunderbolt cable

2017-09-18 Thread Mika Westerberg
From: Amir Levy ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet traffic over a Thunderbolt cable. The protocol consists of configuration phase where each side sends ThunderboltIP login packets (the protocol is determined by UUID in the XDomain packet

Re: [PATCH 06/16] thunderbolt: Add support for XDomain discovery protocol

2017-09-18 Thread Dan Williams
On Mon, 2017-09-18 at 11:12 -0500, Dan Williams wrote: > On Mon, 2017-09-18 at 18:30 +0300, Mika Westerberg wrote: > > When two hosts are connected over a Thunderbolt cable, there is a > > protocol they can use to communicate capabilities supported by the > > host. > > The discovery protocol uses

[PATCH 2/3] net: use inet6_rcv_saddr to compare sockets

2017-09-18 Thread josef
From: Josef Bacik In ipv6_rcv_saddr_equal() we need to use inet6_rcv_saddr(sk) for the ipv6 compare with the fast socket information to make sure we're doing the proper comparisons. Cc: sta...@vger.kernel.org Fixes: 637bc8bbe6c0 ("inet: reset tb->fastreuseport when adding a

[PATCH 3/3] inet: fix improper empty comparison

2017-09-18 Thread josef
From: Josef Bacik When doing my reuseport rework I screwed up and changed a if (hlist_empty(>owners)) to if (!hlist_empty(>owners)) This is obviously bad as all of the reuseport/reuse logic was reversed, which caused weird problems like allowing an ipv4 bind conflict if we

[PATCH v4 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

2017-09-18 Thread Nisar Sayed
Fix for eeprom read/write when device auto suspend Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 24 1 file changed, 20

[PATCH v4 net 3/3] lan78xx: Use default values loaded from EEPROM/OTP after reset

2017-09-18 Thread Nisar Sayed
Use default value of auto duplex and auto speed values loaded from EEPROM/OTP after reset. The LAN78xx allows platform configurations to be loaded from EEPROM/OTP. Ex: When external phy is connected, the MAC can be configured to have correct auto speed, auto duplex, auto polarity configured from

[PATCH v4 net 0/3] lan78xx: This series of patches are for lan78xx driver.

2017-09-18 Thread Nisar Sayed
This series of patches are for lan78xx driver. These patches fixes potential issues associated with lan78xx driver. v4 - Updated changes to handle return values as per comments - Updated EEPROM write handling as per comments v3 - Updated chagnes as per comments v2 - Added patch version

[PATCH 11/16] thunderbolt: Use spinlock in ring serialization

2017-09-18 Thread Mika Westerberg
This makes it possible to enqueue frames also from atomic context which is needed for example, when networking packets are sent over a Thunderbolt cable. Signed-off-by: Mika Westerberg Reviewed-by: Michael Jamet Reviewed-by: Yehezkel

[PATCH 15/16] thunderbolt: Allocate ring HopID automatically if requested

2017-09-18 Thread Mika Westerberg
Thunderbolt services should not care which HopID (ring) they use for sending and receiving packets over the high-speed DMA path, so make tb_ring_alloc_rx() and tb_ring_alloc_tx() accept negative HopID. This means that the NHI will allocate next available HopID for the caller automatically. These

Re: [PATCH] netfilter: nat: Do not use ARRAY_SIZE() on spinlocks to fix zero div

2017-09-18 Thread Pablo Neira Ayuso
On Sun, Sep 10, 2017 at 01:41:41PM +0200, Geert Uytterhoeven wrote: > If no spinlock debugging options (CONFIG_GENERIC_LOCKBREAK, > CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_LOCK_ALLOC) are enabled on a UP > platform (e.g. m68k defconfig), arch_spinlock_t is an empty struct, > hence using

Re: [PATCH] bpf: devmap: pass on return value of bpf_map_precharge_memlock

2017-09-18 Thread Alexei Starovoitov
On Mon, Sep 18, 2017 at 03:03:46PM +0200, Tobias Klauser wrote: > If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned > regardless of the actual error produced by bpf_map_precharge_memlock. > Fix it by passing on the error returned by bpf_map_precharge_memlock. > > Also return

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

2017-09-18 Thread David Miller
From: Richard Cochran Date: Mon, 18 Sep 2017 09:41:15 +0200 > - The driver does not handle out of order packets. If user space > sends a packet with an earlier Tx time, then the code should stop > the queue, reshuffle the descriptors accordingly, and then >

[PATCH] vhost: remove unneeded linux/miscdevice.h include

2017-09-18 Thread Corentin Labbe
drivers/vhost/vhost.c does not use any miscdevice, so this patch remove this unnecessary inclusion. Signed-off-by: Corentin Labbe --- drivers/vhost/vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index

[PATCH net 2/3] net: mvpp2: fix parsing fragmentation detection

2017-09-18 Thread Antoine Tenart
From: Stefan Chulski Parsing fragmentation detection failed due to wrong configured parser TCAM entry's. Some traffic was marked as fragmented in RX descriptor, even it wasn't IP fragmented. The hardware also failed to calculate checksums which lead to use software checksum

[PATCH net 3/3] net: mvpp2: fix port list indexing

2017-09-18 Thread Antoine Tenart
From: Yan Markman The private port_list array has a list of pointers to mvpp2_port instances. This list is allocated given the number of ports enabled in the device tree, but the pointers are set using the port-id property. If on a single port is enabled, the port_list

Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup

2017-09-18 Thread Roman Yeryomin
On 18 September 2017 at 16:02, Roman Yeryomin wrote: > On 17 September 2017 at 23:09, Florian Fainelli wrote: >> >> >> On 09/17/2017 10:23 AM, Roman Yeryomin wrote: >>> Changes from v1: >>> - use GRO instead of increasing ring size >>> - use

[PATCH net 0/3] net: mvpp2: various fixes

2017-09-18 Thread Antoine Tenart
Hi all, This series contains various fixes for the Marvell PPv2 driver. Please have a thorough look at patch 1/3 ("net: mvpp2: fix the dma_mask and coherent_dma_mask settings for PPv2.2") as I'm not 100% sure about the fix implementation. Thanks! Antoine Antoine Tenart (1): net: mvpp2: fix

[PATCH net 1/3] net: mvpp2: fix the dma_mask and coherent_dma_mask settings for PPv2.2

2017-09-18 Thread Antoine Tenart
The dev->dma_mask usually points to dev->coherent_dma_mask. This is an issue as setting both of them will override the other. This is problematic here as the PPv2 driver uses a 32-bit-mask for coherent accesses (txq, rxq, bm) and a 40-bit mask for all other accesses due to an hardware limitation.

Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup

2017-09-18 Thread Roman Yeryomin
On 17 September 2017 at 23:09, Florian Fainelli wrote: > > > On 09/17/2017 10:23 AM, Roman Yeryomin wrote: >> Changes from v1: >> - use GRO instead of increasing ring size >> - use NAPI_POLL_WEIGHT instead of defining own NAPI_WEIGHT >> - optimize rx descriptor flags

[PATCH] bpf: devmap: pass on return value of bpf_map_precharge_memlock

2017-09-18 Thread Tobias Klauser
If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned regardless of the actual error produced by bpf_map_precharge_memlock. Fix it by passing on the error returned by bpf_map_precharge_memlock. Also return -EINVAL instead of -ENOMEM if the page count overflow check fails. This makes

Re: next build: 6 warnings 0 failures (next/next-20170918)

2017-09-18 Thread Arnd Bergmann
On Mon, Sep 18, 2017 at 7:55 AM, Olof's autobuilder wrote: > Warnings: > > 6 net/netfilter/nf_nat_core.c:432:56: warning: division by zero > [-Wdiv-by-zero] Geert posted the fix for this last week: https://patchwork.kernel.org/patch/9946253/ Arnd

Re: stable-rc build: 6 warnings 0 failures (stable-rc/v4.9.50-79-g8d96ea4)

2017-09-18 Thread gregkh
On Mon, Sep 18, 2017 at 04:12:35PM +0200, Arnd Bergmann wrote: > On Mon, Sep 18, 2017 at 12:57 PM, Olof's autobuilder wrote: > > Here are the build results from automated periodic testing. > > > > Warnings: > > > > 2 fs/xfs/xfs_buf_item.c:573:7: warning: unused variable

Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a future transmit time.

2017-09-18 Thread Richard Cochran
On Mon, Sep 18, 2017 at 09:41:16AM +0200, Richard Cochran wrote: > diff --git a/arch/powerpc/include/uapi/asm/socket.h > b/arch/powerpc/include/uapi/asm/socket.h > index 3c590c7c42c0..55718129ab06 100644 > --- a/arch/powerpc/include/uapi/asm/socket.h > +++ b/arch/powerpc/include/uapi/asm/socket.h

Re: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm

2017-09-18 Thread Eric Dumazet
On Mon, 2017-09-18 at 12:18 +, David Laight wrote: > From: Colin King > > Sent: 18 September 2017 12:41 > > Pointer tcm is being initialized and is never read, it is only being used > > to determine the size of struct tcmsg. Clean this up by removing > > variable tcm and explicitly using the

RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm

2017-09-18 Thread David Laight
From: Colin King > Sent: 18 September 2017 12:41 > Pointer tcm is being initialized and is never read, it is only being used > to determine the size of struct tcmsg. Clean this up by removing > variable tcm and explicitly using the sizeof struct tcmsg rather than *tcm. > Cleans up clang warning:

Re: [PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-09-18 Thread Mikko Rapeli
On Mon, Sep 04, 2017 at 07:15:11PM +0300, Dmitry V. Levin wrote: > On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote: > > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > > > It is not needed and not part of uapi headers, but causes > > > user space compilation error:

Re: [PATCH] bpf: devmap: pass on return value of bpf_map_precharge_memlock

2017-09-18 Thread Daniel Borkmann
On 09/18/2017 03:03 PM, Tobias Klauser wrote: If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned regardless of the actual error produced by bpf_map_precharge_memlock. Fix it by passing on the error returned by bpf_map_precharge_memlock. Also return -EINVAL instead of -ENOMEM if

Re: selftests/bpf doesn't compile

2017-09-18 Thread Daniel Borkmann
On 09/16/2017 12:41 AM, Shuah Khan wrote: On 09/15/2017 12:48 PM, Daniel Borkmann wrote: On 09/15/2017 08:23 PM, Daniel Borkmann wrote: On 09/15/2017 08:07 PM, Alexei Starovoitov wrote: On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: On 15/09/17 17:02, Alexei Starovoitov wrote:

Re: [PATCH] bnx2x: drop packets where gso_size is too big for hardware

2017-09-18 Thread Eric Dumazet
On Mon, 2017-09-18 at 14:41 +1000, Daniel Axtens wrote: > Hi Eric, ... > So I've been experimenting with this and reading through the core > networking code. If my understanding is correct, disabling GSO will > cause the packet to be segmented, but it will be segemented into > gso_size+header

[PATCH net] net: phy: Kconfig: Fix PHY infrastructure menu in menuconfig

2017-09-18 Thread Jerome Brunet
Since the integration of PHYLINK, the configuration option which used to be under the PHY infrastructure menu in menuconfig ended up one level up (the network device driver section) By placing PHYLINK option right after PHYLIB entry, it broke the way Kconfig used to build the menu. See

[PATCH net-next] net: mvpp2: remove useless goto

2017-09-18 Thread Antoine Tenart
Remove a goto in the PPv2 tx function which jumps to the next line anyway. This is a cosmetic commit. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c

Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

2017-09-18 Thread Mike Manning
Hi, In the absence of a reply from Mahesh, I would be most grateful for anyone familiar with the IPv6 code to review this 1-line fix. Or if not, then I request that the commit f784ad3d79e5 is backed out, as its intention is to remove the redundant but harmless RTM_DELADDR for addresses in

Re: stable-rc build: 6 warnings 0 failures (stable-rc/v4.9.50-79-g8d96ea4)

2017-09-18 Thread Arnd Bergmann
On Mon, Sep 18, 2017 at 12:57 PM, Olof's autobuilder wrote: > Here are the build results from automated periodic testing. > > Warnings: > > 2 fs/xfs/xfs_buf_item.c:573:7: warning: unused variable 'ordered' > [-Wunused-variable] This is evidently from the backport of

Re: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-18 Thread Hannes Frederic Sowa
Ilya Lesokhin writes: > +/* We assume that the socket is already connected */ > +static struct net_device *get_netdev_for_sock(struct sock *sk) > +{ > + struct inet_sock *inet = inet_sk(sk); > + struct net_device *netdev = NULL; > + > + netdev =

Re: [PATCH 3/3] selftests: silence test output by default

2017-09-18 Thread Josef Bacik
On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote: > On 09/18/2017 11:37 AM, jo...@toxicpanda.com wrote: > > From: Josef Bacik > > > > Some of the networking tests are very noisy and make it impossible to > > see if we actually passed the tests as they run. Default to

[PATCH net] tcp: remove two unused functions

2017-09-18 Thread Yuchung Cheng
remove tcp_may_send_now and tcp_snd_test that are no longer used Fixes: 840a3cbe8969 ("tcp: remove forward retransmit feature") Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Signed-off-by: Eric Dumazet ---

Re: [PATCH 3/3] selftests: silence test output by default

2017-09-18 Thread Josef Bacik
On Mon, Sep 18, 2017 at 12:13:40PM -0600, Shuah Khan wrote: > On 09/18/2017 11:52 AM, Josef Bacik wrote: > > On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote: > >> On 09/18/2017 11:37 AM, jo...@toxicpanda.com wrote: > >>> From: Josef Bacik > >>> > >>> Some of the

Re: [PATCH] ravb: document R8A77970 bindings

2017-09-18 Thread David Miller
From: Sergei Shtylyov Date: Tue, 12 Sep 2017 23:02:08 +0300 > R-Car V3M (R8A77970) SoC also has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-18 Thread Yuchung Cheng
On Sun, Sep 17, 2017 at 11:43 AM, Oleksandr Natalenko wrote: > Hi. > > Just to note that it looks like disabling RACK and re-enabling FACK prevents > warning from happening: > > net.ipv4.tcp_fack = 1 > net.ipv4.tcp_recovery = 0 > > Hope I get semantics of these tunables

RE: [Intel-wired-lan] [PATCH] fm10k: Fix misuse of net_ratelimit()

2017-09-18 Thread Singh, Krishneil K
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Joe Perches > Sent: Friday, August 11, 2017 9:17 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- >

[PATCH 3/3] selftests: silence test output by default

2017-09-18 Thread josef
From: Josef Bacik Some of the networking tests are very noisy and make it impossible to see if we actually passed the tests as they run. Default to suppressing the output from any tests run in order to make it easier to track what failed. Signed-off-by: Josef Bacik

Re: [PATCH 0/3] fix reuseaddr regression

2017-09-18 Thread Cole Robinson
On 09/18/2017 12:28 PM, jo...@toxicpanda.com wrote: > I introduced a regression when reworking the fastreuse port stuff that allows > bind conflicts to occur once a reuseaddr socket successfully opens on an > existing tb. The root cause is I reversed an if statement which caused us to > set the

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-18 Thread Yuchung Cheng
On Mon, Sep 18, 2017 at 10:18 AM, Yuchung Cheng wrote: > On Sun, Sep 17, 2017 at 11:43 AM, Oleksandr Natalenko > wrote: >> Hi. >> >> Just to note that it looks like disabling RACK and re-enabling FACK prevents >> warning from happening: >> >>

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-18 Thread Yuchung Cheng
On Mon, Sep 18, 2017 at 10:59 AM, Oleksandr Natalenko wrote: > OK. Should I keep FACK disabled? Yes since it is disabled in the upstream by default. Although you can experiment FACK enabled additionally. Do we know the crash you first experienced is tied to this issue?

Re: [PATCH] net: Convert int functions to bool

2017-09-18 Thread David Miller
From: Joe Perches Date: Wed, 13 Sep 2017 13:58:15 -0700 > Global function ipv6_rcv_saddr_equal and static functions > ipv6_rcv_saddr_equal and ipv4_rcv_saddr_equal currently return int. > > bool is slightly more descriptive for these functions so change > their return type

Re: [PATCH net] udpv6: Fix the checksum computation when HW checksum does not apply

2017-09-18 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 13 Sep 2017 19:30:51 -0600 > While trying an ESP transport mode encryption for UDPv6 packets of > datagram size 1436 with MTU 1500, checksum error was observed in > the secondary fragment. > > This error occurs due to the

[PATCH net-next 1/7] kobject: add kobject_uevent_net_broadcast()

2017-09-18 Thread Eric Dumazet
This removes some #ifdef pollution and will ease follow up patches. Signed-off-by: Eric Dumazet --- lib/kobject_uevent.c | 96 +--- 1 file changed, 53 insertions(+), 43 deletions(-) diff --git a/lib/kobject_uevent.c

[PATCH net-next 2/7] kobject: copy env blob in one go

2017-09-18 Thread Eric Dumazet
No need to iterate over strings, just copy in one efficient memcpy() call. Tested: time perf record "(for f in `seq 1 3000` ; do ip netns add tast$f; done)" [ perf record: Woken up 10 times to write data ] [ perf record: Captured and wrote 8.224 MB perf.data (~359301 samples) ] real0m52.554s

[PATCH net-next 7/9] s390/qeth: translate SETVLAN/DELVLAN errors

2017-09-18 Thread Julian Wiedmann
Properly return any error encountered during VLAN processing to the the caller. Resulting change in behaviour: if SETVLAN fails while registering a new VLAN ID, the stack no longer creates the corresponding vlan device. Signed-off-by: Julian Wiedmann Reviewed-by: Ursula

[PATCH net-next 5/9] s390/qeth: don't take queue lock in send_packet_fast()

2017-09-18 Thread Julian Wiedmann
Locking the output queue prior to TX is needed on OSA devices, to synchronize against a packing flush from the TX completion code (via qeth_check_outbound_queue()). But send_packet_fast() is only used for IQDs, which don't do packing. So remove the locking, and apply some easy cleanups.

[PATCH net-next 3/9] s390/qeth: add VNICC get/set timeout support

2017-09-18 Thread Julian Wiedmann
From: Hans Wippel HiperSockets allow configuring so called VNIC Characteristics (VNICC) that influence how the underlying hardware handles packets. For VNICCs, additional commands for getting and setting timeouts are available. Currently, the learning VNICC uses these

[PATCH net-next 8/9] s390/qeth: fold VLAN handling into l3_rebuild_skb()

2017-09-18 Thread Julian Wiedmann
Move the overly complicated VLAN processing from the L3 RX handler into its l3_rebuild_skb() helper. No change in functionality. Signed-off-by: Julian Wiedmann Reviewed-by: Ursula Braun --- drivers/s390/net/qeth_l3_main.c | 27

[PATCH net-next 1/9] s390/qeth: add basic VNICC support

2017-09-18 Thread Julian Wiedmann
From: Hans Wippel VNIC Characteristics (VNICC) are features of HiperSockets that define how packets are handled by the underlying network hardware. For example, if the VNICC flooding is configured on a qeth device, ethernet frames to unknown destination MAC addresses

[PATCH net-next 2/9] s390/qeth: add VNICC enable/disable support

2017-09-18 Thread Julian Wiedmann
From: Hans Wippel HiperSocket devices allow enabling and disabling so called VNIC Characteristics (VNICC) that influence how the underlying hardware handles packets. These VNICCs are: * Flooding VNICC: Flooding allows specifying if packets to unknown destination

[PATCH net-next 9/9] s390/qeth: tidy up parameter naming for qeth_do_send_packet()

2017-09-18 Thread Julian Wiedmann
From: Jens Remus Cppcheck reports the following for drivers/s390/net/qeth_core.h: warning - line 1560 - Function 'qeth_do_send_packet' argument order different: declaration 'card, queue, skb, hdr, hd_len, offset, elements' definition 'card, queue,

[PATCH net-next 4/9] s390/qeth: remove unused code in qdio_establish_cq()

2017-09-18 Thread Julian Wiedmann
Storing the number of input buffers into 'i' has no effect, it is immediately re-assigned in the next line. Signed-off-by: Julian Wiedmann Reviewed-by: Ursula Braun --- drivers/s390/net/qeth_core_main.c | 1 - 1 file changed, 1 deletion(-)

[PATCH net-next 6/9] s390/qeth: simplify L3 sysfs group management

2017-09-18 Thread Julian Wiedmann
Use the right helpers to create/remove all attribute groups in one go. Suggested-by: Hans Wippel Signed-off-by: Julian Wiedmann Reviewed-by: Ursula Braun --- drivers/s390/net/qeth_l3_sys.c | 45

[PATCH net-next 3/3] bpf: Test deletion in BPF_MAP_TYPE_LPM_TRIE

2017-09-18 Thread Craig Gallek
From: Craig Gallek Extend the 'random' operation tests to include a delete operation (delete half of the nodes from both lpm implementions and ensure that lookups are still equivalent). Also, add a simple IPv4 test which verifies lookup behavior as nodes are deleted from the

[PATCH v2] net: stmmac: dwmac-sun8i: Use reset exclusive

2017-09-18 Thread Corentin Labbe
The current dwmac_sun8i module cannot be rmmod/modprobe due to that the reset controller was not released when removed. This patch remove ambiguity, by using of_reset_control_get_exclusive and add the missing reset_control_put(). Note that we cannot use devm_reset_control_get, since the reset is

net-next is OPEN...

2017-09-18 Thread David Miller
http://vger.kernel.org/~davem/net-next.html

cross namespace interface notification for tun devices

2017-09-18 Thread Jason A. Donenfeld
Hey guys, It's possible to create a tun device in a process in namespace A and then move that interface to namespace B. The controlling process in A needs to receive notifications on when the interface is brought up or down. It can receive these notifications via netlink while the interface lives

[PATCH 1/3] selftest: add a reuseaddr test

2017-09-18 Thread josef
From: Josef Bacik This is to test for a regression introduced by b9470c27607b ("inet: kill smallest_size and smallest_port") which introduced a problem with reuseaddr and bind conflicts. Signed-off-by: Josef Bacik --- tools/testing/selftests/net/.gitignore

[PATCH 2/3] selftests: actually run the various net selftests

2017-09-18 Thread josef
From: Josef Bacik These self tests are just self contained binaries, they are not run by any of the scripts in the directory. This means they need to be marked with TEST_GEN_PROGS to actually be run, not TEST_GEN_FILES. Signed-off-by: Josef Bacik ---

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-18 Thread Oleksandr Natalenko
On pondělí 18. září 2017 20:01:42 CEST Yuchung Cheng wrote: > Yes since it is disabled in the upstream by default. Although you can > experiment FACK enabled additionally. OK. > Do we know the crash you first experienced is tied to this issue? No, unfortunately. I wasn't able to re-create it

Re: [net-next] dummy: declare dummy devices as enumerated devices

2017-09-18 Thread David Miller
From: Zhang Shengju Date: Tue, 12 Sep 2017 09:32:45 +0800 > Dummy device name is enumerated by the kernel, let user space be aware > of the naming scheme used by dummy devices: > (visible in /sys/class/net//name_assign_type). > > Signed-off-by: Zhang Shengju

Re: [PATCH] net: tcp_input: Neaten DBGUNDO

2017-09-18 Thread David Miller
From: Joe Perches Date: Sun, 10 Sep 2017 19:02:25 -0700 > Move the #ifdef into the static void function so that the use > of DBGUNDO is validated when FASTRETRANS_DEBUG <= 1. > > Remove the now unnecessary #else and #define DBGUNDO. > > Signed-off-by: Joe Perches

Re: [PATCH net-next v2 1/2] net: phy: realtek: rename RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT

2017-09-18 Thread David Miller
From: Kunihiko Hayashi Date: Tue, 12 Sep 2017 18:54:35 +0900 > This renames the definition of page select register from > RTL8211F_PAGE_SELECT to RTL821x_PAGE_SELECT to use it across models. > > Signed-off-by: Kunihiko Hayashi

Re: [PATCH net-next v2 2/2] net: phy: realtek: add RTL8201F phy-id and functions

2017-09-18 Thread David Miller
From: Kunihiko Hayashi Date: Tue, 12 Sep 2017 18:54:36 +0900 > From: Jassi Brar > > Add RTL8201F phy-id and the related functions to the driver. > > The original patch is as follows: > https://patchwork.kernel.org/patch/2538341/ > >

  1   2   3   >