Re: [PATCH,net-next,0/2] Improve code coverage of syzkaller

2017-09-20 Thread David Miller
From: Petar Penkov Date: Tue, 19 Sep 2017 21:26:14 -0700 > Furthermore, in a way testing already requires specific kernel > configuration. In this particular example, syzkaller prefers > synchronous operation and therefore needs 4KSTACKS disabled. Other > features that

[PATCH net-next v5 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

2017-09-20 Thread Yonghong Song
Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing happens, the number of samples or counter value

[PATCH net-next v5 0/4] bpf: add two helpers to read perf event enabled/running time

2017-09-20 Thread Yonghong Song
Hardware pmu counters are limited resources. When there are more pmu based perf events opened than available counters, kernel will multiplex these events so each event gets certain percentage (but not 100%) of the pmu time. In case that multiplexing happens, the number of samples or counter value

[PATCH net-next v5 3/4] bpf: add helper bpf_perf_prog_read_value

2017-09-20 Thread Yonghong Song
This patch adds helper bpf_perf_prog_read_cvalue for perf event based bpf programs, to read event counter and enabled/running time. The enabled/running time is accumulated since the perf event open. The typical use case for perf event based bpf program is to attach itself to a single event. In

[PATCH net-next v5 4/4] bpf: add a test case for helper bpf_perf_prog_read_value

2017-09-20 Thread Yonghong Song
The bpf sample program trace_event is enhanced to use the new helper to print out enabled/running time. Signed-off-by: Yonghong Song --- samples/bpf/trace_event_kern.c| 10 ++ samples/bpf/trace_event_user.c| 13 -

[PATCH net-next] cxgb4: add new T5 pci device id's

2017-09-20 Thread Ganesh Goudar
Add 0x50a5, 0x50a6, 0x50a7, 0x50a8 and 0x50a9 T5 device id's. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h

Re: [PATCH net-next 2/4] qed: Add iWARP out of order support

2017-09-20 Thread Kalderon, Michal
From: Leon Romanovsky Sent: Tuesday, September 19, 2017 8:45 PM On Tue, Sep 19, 2017 at 08:26:17PM +0300, Michal Kalderon wrote: >> iWARP requires OOO support which is already provided by the ll2 >> interface (until now was used only for iSCSI offload). >> The changes mostly

[PATCH net-next v5 2/4] bpf: add a test case for helper bpf_perf_event_read_value

2017-09-20 Thread Yonghong Song
The bpf sample program tracex6 is enhanced to use the new helper to read enabled/running time as well. Signed-off-by: Yonghong Song --- samples/bpf/tracex6_kern.c| 26 ++ samples/bpf/tracex6_user.c| 13 -

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Almost there Bisecting: 6 revisions left to test after this (roughly 3 steps) [ad65a2f05695aced349e308193c6e2a6b1d87112] ipv6: call dst_hold_safe() properly W dniu 2017-09-20 o 13:02, Paweł Staszewski pisze: Ok resumed and soo far: Panic: # bad: [9cc9a5cb176ccb4f2cda5ac34da5a659926f125f]

[net-next] macvlan: code refine to check data before using

2017-09-20 Thread Zhang Shengju
This patch checks data first at one place, return if it's null. Signed-off-by: Zhang Shengju --- drivers/net/macvlan.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index

Re: [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

2017-09-20 Thread Oliver Neukum
Am Dienstag, den 19.09.2017, 13:51 -0700 schrieb Guenter Roeck: > On Tue, Sep 19, 2017 at 1:37 PM, Oliver Neukum wrote: > > > > Am Dienstag, den 19.09.2017, 09:15 -0700 schrieb Douglas Anderson: > > > [..] > > > NOTES: > > > - No known bugs are fixed by this; it's just found

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-20 Thread Jason Wang
On 2017年09月19日 02:11, Matthew Rosato wrote: On 09/18/2017 03:36 AM, Jason Wang wrote: On 2017年09月18日 11:13, Jason Wang wrote: On 2017年09月16日 03:19, Matthew Rosato wrote: It looks like vhost is slowed down for some reason which leads to more idle time on 4.13+VHOST_RX_BATCH=1. Appreciated

[PATCH] netfilter: nf_tables: Release memory obtained by kasprintf

2017-09-20 Thread Arvind Yadav
Free memory region, if nf_tables_set_alloc_name is not successful. Signed-off-by: Arvind Yadav --- net/netfilter/nf_tables_api.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Hi Will try bisecting tonight W dniu 2017-09-20 o 05:24, Eric Dumazet pisze: On Wed, 2017-09-20 at 02:06 +0200, Paweł Staszewski wrote: Just checked kernel 4.13.2 and same problem Just after start all 6 bgp sessions - and kernel starts to learn routes it panic.

Re: [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

2017-09-20 Thread Oliver Neukum
Am Dienstag, den 19.09.2017, 13:53 -0700 schrieb Doug Anderson: > Hi, > > On Tue, Sep 19, 2017 at 1:37 PM, Oliver Neukum wrote: > > > > Am Dienstag, den 19.09.2017, 09:15 -0700 schrieb Douglas Anderson: > > > > > > In general when you've got a flag communicating that

[PATCH v2 1/2] mac80211: Add rcu read side critical sections

2017-09-20 Thread Ville Syrjala
From: Ville Syrjälä I got the following lockdep warning about the rcu_dereference()s in ieee80211_tx_h_select_key(). After tracing all callers of ieee80211_tx_h_select_key() I discovered that ieee80211_get_buffered_bc() and ieee80211_build_data_template() had the

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Trying to make video from ipmi :) with that results: https://bugzilla.kernel.org/attachment.cgi?id=258521 catched two more lines where it starts - panic from 4.13.2. Now will try tro do some bisection W dniu 2017-09-20 o 09:58, Paweł Staszewski pisze: Hi Will try bisecting tonight W

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Ok looks like ending bisection Latest bisected kernel when there is no kernel panic 4.12.0+ (from next)  - but only this warning: [  309.030019] NETDEV WATCHDOG: enp4s0f0 (ixgbe): transmit queue 0 timed out [  309.030034] [ cut here ] [  309.030040] WARNING: CPU: 35

Re: [lkp-robot] [test_rhashtable] c1bd3689a7: WARNING:at_lib/debugobjects.c:#__debug_object_init

2017-09-20 Thread Florian Westphal
kernel test robot wrote: > FYI, we noticed the following commit: > > commit: c1bd3689a70d1ba1a2f7c6781770920087166018 ("test_rhashtable: add test > case for rhl_table interface") > url: >

Re: [PATCH net-next 1/5] net: add support for noref skb->sk

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 18:54 +0200, Paolo Abeni wrote: > Noref sk do not carry a socket refcount, are valid > only inside the current RCU section and must be > explicitly cleared before exiting such section. > > They will be used in a later patch to allow early demux > without sock refcounting.

Re: Latest net-next from GIT panic

2017-09-20 Thread Wei Wang
>> This is why I suggested to replace the BUG() in another mail >> >> So : >> >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index >> f535779d9dc1dfe36934c2abba4e43d053ac5d6f..220cd12456754876edf2d3ef13195e82d70d5c74 >> 100644 >> --- a/include/linux/netdevice.h >> +++

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 10:50 -0700, Cong Wang wrote: > On Wed, Sep 20, 2017 at 6:11 AM, Eric Dumazet wrote: > > Sorry for top-posting, but this is to give context to Wei, since Pawel > > used a top posting way to report his bisection. > > > > Wei, can you take a look at

usb/net/p54: trying to register non-static key in p54_unregister_leds

2017-09-20 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 1 PID: 1404 Comm:

Re: Latest net-next from GIT panic

2017-09-20 Thread Cong Wang
On Wed, Sep 20, 2017 at 11:30 AM, Eric Dumazet wrote: > On Wed, 2017-09-20 at 11:22 -0700, Cong Wang wrote: >> but dmesg at this time shows nothing about interfaces or flaps. >> >> This is very odd. >> >> We only free netdevice in free_netdev() and it is only called when

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 16:03 +0200, Paweł Staszewski wrote: > Nit much more after adding this patch > > https://bugzilla.kernel.org/attachment.cgi?id=258529 > This is why I suggested to replace the BUG() in another mail So : diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h

RFC iproute2 doc files

2017-09-20 Thread Stephen Hemminger
I noticed that the iproute man pages are up to date but the LaTex documentation is very out of date. Rarely updated since the Linux 2.2 days. Either someone needs to do a massive editing job on them, or they should just be dropped. My preference would be to just drop everything in the doc/

Re: [PATCH net-next 00/10] net/smc: updates 2017-09-20

2017-09-20 Thread Bart Van Assche
On Wed, 2017-09-20 at 13:58 +0200, Ursula Braun wrote: > here is a collection of small smc-patches built for net-next improving > the smc code in different areas. Hello Ursula, Can you provide us an update for the timeline of the plan to transition from PF_SMC to PF_INET/PF_INET6 + SOCK_STREAM?

RE: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-20 Thread Nisar.Sayed
Thanks Sergei, I will update it and submit next version. - Nisar > Hello! > > On 09/19/2017 01:02 AM, Nisar Sayed wrote: > > > Allow EEPROM write for less than MAX_EEPROM_SIZE > > > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to > > 10/100/1000 Ethernet device driver") > >

Re: Latest net-next from GIT panic

2017-09-20 Thread Cong Wang
On Wed, Sep 20, 2017 at 6:11 AM, Eric Dumazet wrote: > Sorry for top-posting, but this is to give context to Wei, since Pawel > used a top posting way to report his bisection. > > Wei, can you take a look at Pawel report ? > > Crash happens in dst_destroy() at following :

Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum

2017-09-20 Thread Tom Herbert
On Mon, Sep 18, 2017 at 9:24 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 18 Sep 2017 17:39:02 -0700 > >> Add configuration to control use of zero checksums on transmit for both >> IPv4 and IPv6, and control over accepting zero IPv6 checksums

Re: [PATCH v5 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-20 Thread Corentin Labbe
On Tue, Sep 19, 2017 at 09:49:52PM -0500, Rob Herring wrote: > On Thu, Sep 14, 2017 at 2:19 PM, Andrew Lunn wrote: > >> > Is the MDIO controller "allwinner,sun8i-h3-emac" or "snps,dwmac-mdio"? > >> > If the latter, then I think the node is fine, but then the mux should be > >> > a

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 11:22 -0700, Cong Wang wrote: > but dmesg at this time shows nothing about interfaces or flaps. > > This is very odd. > > We only free netdevice in free_netdev() and it is only called when > we unregister a netdevice. Otherwise pcpu_refcnt is impossible > to be NULL. If

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

2017-09-20 Thread levipearson
> This series is an early RFC that introduces a new socket option > allowing time based transmission of packets. This option will be > useful in implementing various real time protocols over Ethernet, > including but not limited to P802.1Qbv, which is currently finding > its way into 802.1Q. > >

Re: Latest net-next from GIT panic

2017-09-20 Thread Cong Wang
On Wed, Sep 20, 2017 at 10:55 AM, Paweł Staszewski wrote: > > > W dniu 2017-09-20 o 19:50, Cong Wang pisze: > > On Wed, Sep 20, 2017 at 6:11 AM, Eric Dumazet > wrote: > > Sorry for top-posting, but this is to give context to Wei, since Pawel > used

Re: mac80211: avoid allocating TXQs that won't be used

2017-09-20 Thread Johannes Berg
On Wed, 2017-09-20 at 17:08 +0100, Colin Ian King wrote: > Johannes, > > Static analysis with CoverityScan on linux-next today detected a null > pointer dereference issue on commit: > > From 0fc4b3403d215ecd3c05505ec1f0028a227ed319 Mon Sep 17 00:00:00 > 2001 > From: Johannes Berg

[PATCH net-next 3/5] udp: do not touch socket refcount in early demux

2017-09-20 Thread Paolo Abeni
use noref sockets instead. This gives some small performance improvements and will allow efficient early demux for unconnected sockets in a later patch. Signed-off-by: Paolo Abeni --- net/ipv4/udp.c | 18 ++ net/ipv6/udp.c | 10 ++ 2 files changed, 16

[PATCH net-next 5/5] udp: perform full socket lookup in early demux

2017-09-20 Thread Paolo Abeni
Since UDP early demux lookup fetches noref socket references, we can safely be optimistic about it and set the sk reference even if the skb is not going to land on such socket, avoiding the rx dst cache usage for unconnected unicast sockets. This avoids a second lookup for unconnected sockets,

[PATCH net-next 2/5] net: allow early demux to fetch noref socket

2017-09-20 Thread Paolo Abeni
We must be careful to avoid leaking such sockets outside the RCU section containing the early demux call; we clear them on nonlocal delivery. For ipv4 we must take care of local mcast delivery, too, since udp early demux works also for mcast addresses. Also update all iptables/nftables extension

Re: [PATCH net-next v5 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

2017-09-20 Thread Peter Zijlstra
On Tue, Sep 19, 2017 at 11:09:32PM -0700, Yonghong Song wrote: > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 3e691b7..2d5bbe5 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -3684,10 +3684,12 @@ static inline u64 perf_event_count(struct perf_event >

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Tom Herbert
On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 18 Sep 2017 17:38:58 -0700 > >> Allow peers to be specified by IPv6 addresses. >> >> Signed-off-by: Tom Herbert > > Hmmm, can you just check the

Re: [PATCH net-next] bpf: Optimize lpm trie delete

2017-09-20 Thread Craig Gallek
On Wed, Sep 20, 2017 at 12:51 PM, Daniel Mack wrote: > Hi Craig, > > Thanks, this looks much cleaner already :) > > On 09/20/2017 06:22 PM, Craig Gallek wrote: >> diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c >> index 9d58a576b2ae..b5a7d70ec8b5 100644 >> ---

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 19:46, Wei Wang pisze: This is why I suggested to replace the BUG() in another mail So : diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index f535779d9dc1dfe36934c2abba4e43d053ac5d6f..220cd12456754876edf2d3ef13195e82d70d5c74 100644 ---

Re: cross namespace interface notification for tun devices

2017-09-20 Thread Cong Wang
On Tue, Sep 19, 2017 at 2:02 PM, Jason A. Donenfeld wrote: > On Tue, Sep 19, 2017 at 10:40 PM, Cong Wang wrote: >> By "notification" I assume you mean netlink notification. > > Yes, netlink notification. > >> The question is why does the process in A

[PATCH] hv_netvsc: fix send buffer failure on MTU change

2017-09-20 Thread Stephen Hemminger
From: Alex Ng If MTU is changed the host would reject the send buffer change. This problem is result of recent change to allow changing send buffer size. Every time we change the MTU, we store the previous net_device section count before destroying the buffer, but we don’t

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Andreas Schultz
On 19/09/17 02:38, Tom Herbert wrote: Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace control plane). This allows GTP interfaces to be configured and the data path tested without requiring a GTP-C daemon.

re: mac80211: avoid allocating TXQs that won't be used

2017-09-20 Thread Colin Ian King
Johannes, Static analysis with CoverityScan on linux-next today detected a null pointer dereference issue on commit: >From 0fc4b3403d215ecd3c05505ec1f0028a227ed319 Mon Sep 17 00:00:00 2001 From: Johannes Berg Date: Thu, 22 Jun 2017 12:20:29 +0200 Subject: [PATCH]

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Andreas Schultz
On 20/09/17 17:57, Tom Herbert wrote: On Wed, Sep 20, 2017 at 8:27 AM, Andreas Schultz wrote: On 19/09/17 02:38, Tom Herbert wrote: Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace

Re: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH hdrlen

2017-09-20 Thread Xiang Gao
Hi David, Thanks for your time and all your suggestions. I will resend a new patch soon. Xiang Gao Xiang Gao 2017-09-19 18:32 GMT-04:00 David Miller : > From: Xiang Gao > Date: Tue, 19 Sep 2017 08:59:50 -0400 > >> In ipv6_skip_exthdr, the lengh of

[PATCH net-next] bpf: Optimize lpm trie delete

2017-09-20 Thread Craig Gallek
From: Craig Gallek Before the delete operator was added, this datastructure maintained an invariant that intermediate nodes were only present when necessary to build the tree. This patch updates the delete operation to reinstate that invariant by removing unnecessary

[patch net-next 01/16] mlxsw: spectrum_switchdev: Change mc_router to mrouter

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Change the naming of mc_router to mrouter to keep consistency. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 18 +- 1 file

[patch net-next 07/16] mlxsw: spectrum_switchdev: Break mid deletion into two function

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Break mid deletion into two function, so it will be possible in the future to delete a mid entry for other reasons then switchdev command (like port deletion). Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko

[patch net-next 02/16] mlxsw: spectrum_switchdev: Add a ports bitmap to the mid db

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Add a bitmap of ports to the mid struct to hold the ports that are registered to this mid. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 1 +

[patch net-next 10/16] mlxsw: spectrum_switchdev: Use generic mc flood function

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Use the generic mc flood function to decide whether to flood mc to a port when mc is being enabled / disabled. Move this function in the file to avoid forward declaration. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko

[patch net-next 12/16] mlxsw: spectrum_switchdev: Flush the mdb when a port is being removed

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When a port is being removed from a bridge, flush the bridge mdb to remove the mids of that port. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c |

[patch net-next 08/16] mlxsw: spectrum_switchdev: Don't write mids to the HW when mc is disabled

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Don't write multicast related data to the HW when mc is disabled. Also, don't allocate mid id to new mids (so the remove function could know that they weren't wrote to the HW) Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko

[patch net-next 05/16] mlxsw: spectrum_switchdev: Break smid write function

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Break the smid write function into two, one that cleans the ports that might be still written there and one that changes an exiting mid entry. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko ---

[patch net-next 06/16] mlxsw: spectrum_switchdev: Attach mid id allocation to HW write

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Attach mid getting and releasing mid id to the HW write / remove, and add a flag to indicate whether the mid is in the HW. It is done because mid id is also HW index to this mid. This change allows adding in the following patches the ability to have a mid

[patch net-next 03/16] mlxsw: spectrum_switchdev: Remove reference count from mid

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Since there is a bitmap for the ports registered to each mid, there is no need for a ref count, since it will always be the number of set bits in this bitmap. Any check of the ref count was replaced with checking if the bitmap is empty. Signed-off-by:

[patch net-next 13/16] mlxsw: spectrum_switchdev: Flood all mc packets to mrouter ports

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When mc is enabled, whenever a mc packet doesn't hit any mdb entry it is being flood to the ports marked as mrouters. However, all mc packets should be flooded to them even if they match an entry in the mdb. This patch adds the mrouter ports to every mdb

[patch net-next 16/16] mlxsw: spectrum_switchdev: Consider mrouter status for mdb changes

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When a mrouter is registered or leaves a mid, don't update the HW. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 13 + 1 file

[patch net-next 11/16] mlxsw: spectrum_switchdev: Flood mc when mc is disabled by user flag

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When multicast is disabled, flood mc packets only to port that are marked BR_MCAST_FLOOD (instead to all). Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko ---

Re: [PATCH net-next] net: dsa: Utilize dsa_slave_dev_check()

2017-09-20 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Instead of open coding the check. > > Signed-off-by: Florian Fainelli If we do need to use it outside one day, we may think about renaming netdev_uses_dsa() to netdev_is_dsa_master() and renaming

[PATCH v5 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-20 Thread Nisar Sayed
Allow EEPROM write for less than MAX_EEPROM_SIZE Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

[PATCH v5 net 0/3] lan78xx: This series of patches are for lan78xx driver.

2017-09-20 Thread Nisar Sayed
This series of patches are for lan78xx driver. These patches fixes potential issues associated with lan78xx driver. v5 - Updated changes as per comments v4 - Updated changes to handle return values as per comments - Updated EEPROM write handling as per comments v3 - Updated chagnes as per

[PATCH v5 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

2017-09-20 Thread Nisar Sayed
Fix for eeprom read/write when device auto suspend Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 24 1 file changed, 20

[PATCH net-next] net: avoid a full fib lookup when rp_filter is disabled.

2017-09-20 Thread Paolo Abeni
Since commit 1dced6a85482 ("ipv4: Restore accept_local behaviour in fib_validate_source()") a full fib lookup is needed even if the rp_filter is disabled, if accept_local is false - which is the default. What we really need in the above scenario is just checking that the source IP address is not

Re: [Patch net] net_sched: remove cls_flower idr on failure

2017-09-20 Thread Jiri Pirko
Wed, Sep 20, 2017 at 06:18:45PM CEST, xiyou.wangc...@gmail.com wrote: >Fixes: c15ab236d69d ("net/sched: Change cls_flower to use IDR") >Cc: Chris Mi >Cc: Jiri Pirko >Signed-off-by: Cong Wang Looks fine. Acked-by: Jiri Pirko

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Nit much more after adding this patch https://bugzilla.kernel.org/attachment.cgi?id=258529 W dniu 2017-09-20 o 15:44, Eric Dumazet pisze: On Wed, 2017-09-20 at 15:39 +0200, Paweł Staszewski wrote: W dniu 2017-09-20 o 15:34, Eric Dumazet pisze: Could you try this debug patch ? diff --git

Re: [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types

2017-09-20 Thread Stefan Hajnoczi
On Tue, Sep 19, 2017 at 10:38:40AM -0700, David Miller wrote: > From: Stefan Hajnoczi > Date: Mon, 18 Sep 2017 16:21:00 +0100 > > > On Fri, Sep 15, 2017 at 02:14:32PM -0700, David Miller wrote: > >> > diff --git a/include/uapi/linux/vm_sockets.h > >> >

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-20 Thread Hannes Frederic Sowa
Sridhar Samudrala writes: > This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used > to enable symmetric tx and rx queues on a socket. > > This option is specifically useful for epoll based multi threaded workloads > where each thread handles

Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache

2017-09-20 Thread Andreas Schultz
On 19/09/17 14:09, Harald Welte wrote: Hi Dave, On Mon, Sep 18, 2017 at 09:17:51PM -0700, David Miller wrote: This and the new dst caching code ignores any source address selection done by ip_route_output_key() or the new tunnel route lookup helpers. Either source address selection should

Re: [PATCH net-next] bpf: Optimize lpm trie delete

2017-09-20 Thread Daniel Mack
Hi Craig, Thanks, this looks much cleaner already :) On 09/20/2017 06:22 PM, Craig Gallek wrote: > diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c > index 9d58a576b2ae..b5a7d70ec8b5 100644 > --- a/kernel/bpf/lpm_trie.c > +++ b/kernel/bpf/lpm_trie.c > @@ -397,7 +397,7 @@ static int

Re: [PATCHv3 iproute2 1/2] lib/libnetlink: re malloc buff if size is not enough

2017-09-20 Thread Stephen Hemminger
On Wed, 20 Sep 2017 09:43:39 +0800 Hangbin Liu wrote: Thanks for keeping up on this. > +realloc: > + bufp = realloc(buf, buf_len); > + > + if (bufp == NULL) { Minor personal style issue: To me, blank lines are like paragraphs in writing. Code reads better

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-20 Thread Tom Herbert
On Tue, Sep 19, 2017 at 10:13 PM, Eric Dumazet wrote: > On Tue, 2017-09-19 at 21:59 -0700, Samudrala, Sridhar wrote: >> On 9/19/2017 5:48 PM, Tom Herbert wrote: >> > On Tue, Sep 19, 2017 at 5:34 PM, Samudrala, Sridhar >> > wrote: >> > > On

IP Expo show Europe 2017 Attendees List

2017-09-20 Thread Aspen Ella
Hi, Would you be interested in the "IP Expo show Europe 2017 Attendees List ?" Please Let me know your interest to send you the number of attendees and cost. Just let me know if you have any questions. Awaiting your reply Regards, Aspen Marketing Executive To remove from this mailing: reply

Re: [PATCH,net-next,0/2] Improve code coverage of syzkaller

2017-09-20 Thread Willem de Bruijn
On Wed, Sep 20, 2017 at 2:08 AM, David Miller wrote: > From: Petar Penkov > Date: Tue, 19 Sep 2017 21:26:14 -0700 > >> Furthermore, in a way testing already requires specific kernel >> configuration. In this particular example, syzkaller prefers >>

[PATCH v4 0/4] Add cross-compilation support to eBPF samples

2017-09-20 Thread Joel Fernandes
These patches fix issues seen when cross-compiling eBPF samples on arm64. Compared to [1], I dropped the controversial inline-asm patch and exploring other options to fix it. However these patches are a step in the right direction and I look forward to getting them into -next and the merge window.

Re: [PATCH net-next 08/10] net/smc: introduce a delay

2017-09-20 Thread Ursula Braun
On 09/20/2017 04:03 PM, Leon Romanovsky wrote: > On Wed, Sep 20, 2017 at 01:58:11PM +0200, Ursula Braun wrote: >> The number of outstanding work requests is limited. If all work >> requests are in use, tx processing is postponed to another scheduling >> of the tx worker. Switch to a delayed

[PATCH v5 net 3/3] lan78xx: Use default values loaded from EEPROM/OTP after reset

2017-09-20 Thread Nisar Sayed
Use default value of auto duplex and auto speed values loaded from EEPROM/OTP after reset. The LAN78xx allows platform configurations to be loaded from EEPROM/OTP. Ex: When external phy is connected, the MAC can be configured to have correct auto speed, auto duplex, auto polarity configured from

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 8:27 AM, Andreas Schultz wrote: > On 19/09/17 02:38, Tom Herbert wrote: >> >> Add new configuration of GTP interfaces that allow specifying a port to >> listen on (as opposed to having to get sockets from a userspace control >> plane). This allows GTP

[PATCH v4 2/4] samples/bpf: Enable cross compiler support

2017-09-20 Thread Joel Fernandes
When cross compiling, bpf samples use HOSTCC for compiling the non-BPF part of the sample, however what we really want is to use the cross compiler to build for the cross target since that is what will load and run the BPF sample. Detect this and compile samples correctly. Acked-by: Alexei

[PATCH v4 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress

2017-09-20 Thread Joel Fernandes
When cross-compiling the bpf sample map_perf_test for aarch64, I find that __NR_getpgrp is undefined. This causes build errors. This syscall is deprecated and requires defining __ARCH_WANT_SYSCALL_DEPRECATED. To avoid having to define that, just use a different syscall (getppid) for the array map

[PATCH v4 3/4] samples/bpf: Fix pt_regs issues when cross-compiling

2017-09-20 Thread Joel Fernandes
BPF samples fail to build when cross-compiling for ARM64 because of incorrect pt_regs param selection. This is because clang defines __x86_64__ and bpf_headers thinks we're building for x86. Since clang is building for the BPF target, it shouldn't make assumptions about what target the BPF program

[PATCH v4 4/4] samples/bpf: Add documentation on cross compilation

2017-09-20 Thread Joel Fernandes
Acked-by: Alexei Starovoitov Signed-off-by: Joel Fernandes --- samples/bpf/README.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst index 79f9a58f1872..2b906127ef54 100644 ---

[PATCH net-next] net: dsa: use dedicated CPU port

2017-09-20 Thread Vivien Didelot
Each port in DSA has its own dedicated CPU port currently available in its parent switch's ds->ports[port].cpu_dp. Use it instead of getting the unique tree CPU port, which will be deprecated soon. Signed-off-by: Vivien Didelot ---

Re: [PATCH net-next 00/14] gtp: Additional feature support

2017-09-20 Thread Andreas Schultz
Hi Harald, On 20/09/17 01:19, Harald Welte wrote: Hi Tom, On Tue, Sep 19, 2017 at 08:59:28AM -0700, Tom Herbert wrote: On Tue, Sep 19, 2017 at 5:43 AM, Harald Welte wrote: On Mon, Sep 18, 2017 at 05:38:50PM -0700, Tom Herbert wrote: - IPv6 support see my detailed

Re: [PATCH net-next] net: avoid a full fib lookup when rp_filter is disabled.

2017-09-20 Thread Paolo Abeni
Dumb me and dumb my scripts. This is actually a v2, v1 was at: https://patchwork.ozlabs.org/project/netdev/list/?series=3835 David, please let me know if you prefer I'll repost with a more appropriate subject line. Sorry for the noise, Paolo

vhost_net: VM looses network when using vhost over time

2017-09-20 Thread Bernd Naumann
Hi @all, We have encountered/experience a bug which is more or less reproducible, but we do not know how to do it exactly or how to debug the issue in the first place. # Background In our setup we have a Ganti Cluser (kvm) with atm ~60 nodes running ~500 VMs, we are using tap interfaces on

[Patch net] net_sched: remove cls_flower idr on failure

2017-09-20 Thread Cong Wang
Fixes: c15ab236d69d ("net/sched: Change cls_flower to use IDR") Cc: Chris Mi Cc: Jiri Pirko Signed-off-by: Cong Wang --- net/sched/cls_flower.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH] ipv6: Use ipv6_authlen for len in ipv6_skip_exthdr

2017-09-20 Thread Xiang Gao
In ipv6_skip_exthdr, the lengh of AH header is computed manually as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro named ipv6_authlen is already defined for exactly the same job. This commit replaces the manual computation code with the macro. Signed-off-by: Xiang Gao

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 9:07 AM, Andreas Schultz wrote: > > > On 20/09/17 17:57, Tom Herbert wrote: >> >> On Wed, Sep 20, 2017 at 8:27 AM, Andreas Schultz >> wrote: >>> >>> On 19/09/17 02:38, Tom Herbert wrote: Add new configuration of GTP

Re: [PATCH v4 4/4] samples/bpf: Add documentation on cross compilation

2017-09-20 Thread Randy Dunlap
On 09/20/17 09:11, Joel Fernandes wrote: > Acked-by: Alexei Starovoitov > Signed-off-by: Joel Fernandes > --- > samples/bpf/README.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst >

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-20 Thread Samudrala, Sridhar
On 9/20/2017 7:18 AM, Tom Herbert wrote: On Tue, Sep 19, 2017 at 10:13 PM, Eric Dumazet wrote: On Tue, 2017-09-19 at 21:59 -0700, Samudrala, Sridhar wrote: On 9/19/2017 5:48 PM, Tom Herbert wrote: On Tue, Sep 19, 2017 at 5:34 PM, Samudrala, Sridhar

[PATCH net-next 1/5] net: add support for noref skb->sk

2017-09-20 Thread Paolo Abeni
Noref sk do not carry a socket refcount, are valid only inside the current RCU section and must be explicitly cleared before exiting such section. They will be used in a later patch to allow early demux without sock refcounting. Signed-off-by: Paolo Abeni ---

[PATCH net-next 0/5] net: introduce noref sk

2017-09-20 Thread Paolo Abeni
This series introduce the infrastructure to store inside the skb a socket pointer without carrying a refcount to the socket. Such infrastructure is then used in the network receive path - and specifically the early demux operation. This allows the UDP early demux to perform a full lookup for UDP

[PATCH net-next 4/5] net: add simple socket-like dst cache helpers

2017-09-20 Thread Paolo Abeni
It will be used by later patches to reduce code duplication. Signed-off-by: Paolo Abeni --- include/net/dst.h | 12 net/core/dst.c| 16 2 files changed, 28 insertions(+) diff --git a/include/net/dst.h b/include/net/dst.h index

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread David Miller
From: Tom Herbert Date: Wed, 20 Sep 2017 11:03:52 -0700 > On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote: >> From: Tom Herbert >> Date: Mon, 18 Sep 2017 17:38:58 -0700 >> >>> Allow peers to be specified by IPv6 addresses. >>>

[PATCH] [RESEND][for 4.14] net: qcom/emac: add software control for pause frame mode

2017-09-20 Thread Timur Tabi
The EMAC has the option of sending only a single pause frame when flow control is enabled and the RX queue is full. Although sending only one pause frame has little value, this would allow admins to enable automatic flow control without having to worry about the EMAC flooding nearby switches with

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote: > From: Tom Herbert > Date: Wed, 20 Sep 2017 11:03:52 -0700 > >> On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Mon,

[PATCH v3 22/31] sctp: Copy struct sctp_sock.autoclose to userspace using put_user()

2017-09-20 Thread Kees Cook
From: David Windsor The autoclose field can be copied with put_user(), so there is no need to use copy_to_user(). In both cases, hardened usercopy is being bypassed since the size is constant, and not open to runtime manipulation. This patch is verbatim from Brad Spengler/PaX

  1   2   3   4   >