Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses
variable len to keep trailing colon from interface name comparison. This
variable is local to loop body but we set it in one pass and use it in
following one(s) so that we are actually using (pseudo)random length for
comparison.
On Thu, Oct 19, 2017 at 10:21:08AM +0200, Michal Kubecek wrote:
> Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses
> variable len to keep trailing colon from interface name comparison. This
> variable is local to loop body but we set it in one pass and use it in
> following
> On Thu, Oct 19, 2017 at 10:21:08AM +0200, Michal Kubecek wrote:
> > Commit 530903dd9003 ("ip: fix igmp parsing when iface is long") uses
> > variable len to keep trailing colon from interface name comparison. This
> > variable is local to loop body but we set it in one pass and use it in
> >
On 10/19/2017 03:49 AM, James Morris wrote:
On Wed, 18 Oct 2017, David Miller wrote:
Series applied.
I hadn't gotten to reviewing this patchset yet.
Please wait for more acks/reviews from LSM folk for things touching
security/, next time.
It didn't get applied yet due to a build error, v7
On Wed, Oct 18, 2017 at 08:50:49PM +0200, Corentin Labbe wrote:
> On Wed, Oct 18, 2017 at 06:44:50PM +0200, Andrew Lunn wrote:
> > On Wed, Oct 18, 2017 at 01:44:50PM +0200, Corentin Labbe wrote:
> > > The original dwmac-sun8i DT bindings have some issue on how to handle
> > > integrated PHY and
On Mon, Oct 16, 2017 at 2:19 PM, Dmitry Vyukov wrote:
> On Mon, Oct 16, 2017 at 11:40 AM, Stanislaw Gruszka
> wrote:
>> Hi Dmitry
>>
>> On Sat, Oct 14, 2017 at 04:38:03PM +0200, Dmitry Vyukov wrote:
>>> On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka
From: Troy Kisky Sent: Thursday, October 19,
2017 2:30 AM
>On 10/18/2017 11:10 AM, Troy Kisky wrote:
>> On 10/17/2017 7:30 PM, Andy Duan wrote:
>>> From: Troy Kisky Sent: Wednesday,
>>> October 18, 2017 5:34 AM
>> This is
The perf traces for ipv6 routing code show a relevant cost around
trace_fib6_table_lookup(), even if no trace is enabled. This is
due to the fib6_table de-referencing currently performed by the
caller.
Let's the tracing code pay this overhead, passing to the trace
helper the table pointer. This
> >>> On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote:
> During test transmitting using CAN-FD at high bitrates (4 Mbps)
> only resulted in errors. Scoping the signals I noticed that
> only a single bit was being transmitted and with a bit more
>
Hello!
On 10/18/2017 11:23 PM, Paolo Abeni wrote:
After the commit Fixes: 2b760fcf5cfb ("ipv6: hook up exception
Fixes: belongs in the tag section. :-)
table to store dst cache"), the fib6 gc is not started after
the creation of a RTF_CACHE via a redirect or pmtu update, since
On 10/19/2017 07:07 AM, Sekhar Nori wrote:
Sounds reasonable. What's the status of this series?
>>>
>>> I have had some offline discussions with Franklin on this, and I am not
>>> fully convinced that DT is the way to go here (although I don't have the
>>> agreement with Franklin there).
>>
On 10/19/2017 10:04 AM, Ramesh Shanmugasundaram wrote:
>>> Sounds reasonable. What's the status of this series?
>>
>> I have had some offline discussions with Franklin on this, and I am not
>> fully convinced that DT is the way to go here (although I don't have the
>> agreement with Franklin
Hi Doug and Dave,
In the absence of linux-next, I want to warn you that there is a trivial
merge conflict between rdma-next and net-next in
drivers/net/ethernet/mellanox/mlx4/catas.c
The origin of the merge conflict is the following patch
https://patchwork.kernel.org/patch/9986131/
applied to
Thu, Oct 19, 2017 at 12:01:38AM CEST, dsah...@gmail.com wrote:
>Use container_of to convert the generic fib_notifier_info into
>the event specific data structure.
>
>Signed-off-by: David Ahern
>Reviewed-by: Ido Schimmel
Acked-by: Jiri Pirko
On Tue, Oct 17, 2017 at 05:42:53PM -0500, Gustavo A. R. Silva wrote:
> This code was tested by compilation only (GCC 7.2.0 was used).
>
No worry, this case really has to fall through.
> diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c
> index 7135f46..f517942 100644
> ---
On Thu, Oct 19, 2017 at 05:26:25PM +0800, Herbert Xu wrote:
>
> So it's an netlink API issue. It is possible for cb->done to be
> called without cb->dump ever being called. And xfrm_user doesn't
> deal with that. Let me survey the others to see whether we should
> fix this in netlink, xfrm, or
> +enum devlink_autoneg_protocol {
> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM,
> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM,
> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY,
> + DEVLINK_AUTONEG_PROTOCOL_BAM, /* Broadcom
> Autoneg Mode */
> +
Hi Dave,
Here's the first bluetooth-next pull request targeting the 4.15 kernel
release.
- Multiple fixes & improvements to the hci_bcm driver
- DT improvements, e.g. new local-bd-address property
- Fixes & improvements to ECDH usage. Private key is now generated by
the crypto subsystem.
This patch is to void the potential security issue that the family
or protocol modules are autoloaded when requesting _diag module by
not requesting _diag module if the family or protocol is not added
or registered in sock_diag and inet_diag.
As the repost of the patch '[PATCH net] sock_diag:
Now when using 'ss' in iproute, kernel would try to load all _diag
modules. It causes the corresponding family or proto modules to be
loaded as well.
Like after 'ss -a', sctp, dccp, af_packet(if it works as a moudle)
will be loaded.
As these family or proto modules are loaded unexpectly, this
The patch 'sock_diag: request _diag module only when the family has
been registered' fixed a security issue for sock_diag, the same fix
is needed for inet_diag module when requesting _diag module.
Fixes: 305e1e969114 ("[INET]: Let inet_diag and friends autoload")
Reported-by: Sabrina Dubroca
On Mon, Oct 16, 2017 at 04:37:44PM -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Stanislaw Gruszka
On Thu, 19 Oct 2017 09:29:03 +0900 wrote:
> 2017-10-18 19:23 GMT+09:00 Kunihiko Hayashi :
> > On Mon, 16 Oct 2017 00:08:21 +0900 wrote:
>
> >> priv->rst = devm_reset_control_get_optional_shared(dev,
On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote:
> On 10/19/2017 07:07 AM, Sekhar Nori wrote:
> Sounds reasonable. What's the status of this series?
I have had some offline discussions with Franklin on this, and I am not
fully convinced that DT is the way to go
From: Girish Moodalbail
Date: Wed, 18 Oct 2017 11:16:46 -0700
> This flag identifies that the address was obtained through DHCP.
>
> Today there is no easy way to find out whether an address on an
> interface is DHCP controlled or is static. Either you will need to
On 10/19/2017 01:14 PM, Oliver Hartkopp wrote:
> Since we have a netlink socket interface to configure sample point, I
> wonder if that should be extended to configure SSP too (or at least the
> offset part of SSP)?
>
> +1 too
The struct can_bittiming in defined in uapi, so we have
On big-endian machines, functions converting between tunnel ID
and VNI use the three LSBs of tunnel ID storage to map VNI.
The comparison function eq_tun_id_and_vni(), on the other hand,
attempted to map the VNI from the three MSBs. Fix it by using
the same check implemented on LE, which maps VNI
No need to re-invent memchr_inv() with !is_all_zero(). While at
it, replace conditional and return clauses with a single return
clause in is_tnl_info_zero().
Signed-off-by: Stefano Brivio
---
drivers/net/geneve.c | 19 +++
1 file changed, 3 insertions(+), 16
On 19 October 2017 at 01:40, Paweł Staszewski wrote:
>
>
> W dniu 2017-10-19 o 01:29, Alexander Duyck pisze:
>
>> On Mon, Oct 16, 2017 at 10:51 PM, Vitezslav Samel
>> wrote:
>>>
>>> On Tue, Oct 17, 2017 at 01:34:29AM +0200, Paweł Staszewski wrote:
From:
Date: Tue, 17 Oct 2017 07:33:55 +
> From: Netanel Belgazal
>
> Netanel Belgazal (6):
> net: ena: improve ENA driver boot time.
> net: ena: remove legacy suspend suspend/resume support
> net: ena: add power management ops to the ENA driver
From: Dan Carpenter
Date: Tue, 17 Oct 2017 15:33:01 +0300
> There is a problem when we do:
>
> sequence = pkg->hdr.length_sn & TBIP_HDR_SN_MASK;
> sequence >>= TBIP_HDR_SN_SHIFT;
>
> TBIP_HDR_SN_SHIFT is 27, and right shifting a u8 27 bits is always
>
From: Dan Carpenter
Date: Tue, 17 Oct 2017 15:32:17 +0300
> The problematic code looks like this:
>
> res_seq = res_hdr->xd_hdr.length_sn & TB_XDOMAIN_SN_MASK;
> res_seq >>= TB_XDOMAIN_SN_SHIFT;
>
> TB_XDOMAIN_SN_SHIFT is 27, and right shifting a u8 27
From: Thomas Falcon
Date: Tue, 17 Oct 2017 12:36:53 -0500
> This patch set is fairly straightforward. The first patch enables
> scatter-gather support in the ibmvnic driver. The following patch
> then enables the TCP Segmentation offload feature. The final patch
>
From: David Ahern
Date: Tue, 17 Oct 2017 13:09:33 -0700
> Running perf in one window to capture tcp_retransmit_skb tracepoint:
> $ perf record -e tcp:tcp_retransmit_skb -a
>
> And causing a retransmission on an active TCP session (e.g., dropping
> packets in the receiver,
On Thu, Oct 19, 2017 at 02:33:20PM +0300, Timo Teras wrote:
>
> > Fixes: 4c563f7669c1 ("[XFRM]: Speed up xfrm_policy and xfrm_state...")
>
> This is not correct. The original commit works just fine.
OK, I'll change it.
> At that time there was no .start which got added just few years ago. I
>
From: Yunsheng Lin
Date: Tue, 17 Oct 2017 14:51:30 +0800
> When using tc qdisc, dcb_ops->setup_tc is used to tell hclge_dcb
> module to do the tm related setup. Only TC_MQPRIO_MODE_CHANNEL
> offload mode is supported.
>
> Signed-off-by: Yunsheng Lin
From: Alexander Duyck
Date: Mon, 16 Oct 2017 22:44:44 -0400
> This patch reverts earlier commit b13ba1b83f52 ("macvlan: forbid L2
> fowarding offload for macvtap"). The reason for reverting this is because
> the original patch no longer fixes what it previously did
From:
Date: Tue, 17 Oct 2017 07:33:02 +
> From: Netanel Belgazal
>
> Some fixes for ENA ethernet driver
Series applied.
From: Daniel Borkmann
Date: Tue, 17 Oct 2017 16:55:51 +0200
> The set fixes a splat in devmap percpu allocation when we alloc
> the flush bitmap. Patch 1 is a prerequisite for the fix in patch 2,
> patch 1 is rather small, so if this could be routed via -net, for
> example,
From: Jiri Pirko
Date: Tue, 17 Oct 2017 22:05:56 +0200
> From: Jiri Pirko
>
> Introduce new type of ndo_setup_tc message to propage binding/unbinding
> of a block to driver. Call this ndo whenever qdisc gets/puts a block.
> Alongside with this, there's need
In the UDP code there are two leftover error messages with very few meaning.
Replace them with a more descriptive error message as some users
reported them as "strange network error".
Signed-off-by: Matteo Croce
---
v2: added proper signed off tag
net/ipv4/udp.c | 4 ++--
1
From: Stefan Mätje
The dlc member of the struct rx_msg contains also the ESD_RTR flag to
mark received RTR frames. Without the fix the can_dlc value for received
RTR frames would always be set to 8 by get_can_dlc() instead of the
received value.
Fixes: 96d8e90382dc ("can:
From: "ZHU Yi (ST-FIR/ENG1-Zhu)"
Enable FLEXCAN_QUIRK_BROKEN_PERR_STATE for i.MX28 to report correct
state transitions, especially to error passive.
Signed-off-by: Wolfgang Grandegger
Signed-off-by: Zhu Yi
Signed-off-by: Mark
From: Colin Ian King
The assignment of net via call sock_net will dereference sk. This
is performed before a sanity null check on sk, so there could be
a potential null dereference on the sock_net call if sk is null.
Fix this by assigning net after the sk null check.
On Thu, 19 Oct 2017 17:57:04 +0800
Herbert Xu wrote:
> On Thu, Oct 19, 2017 at 05:26:25PM +0800, Herbert Xu wrote:
> >
> > So it's an netlink API issue. It is possible for cb->done to be
> > called without cb->dump ever being called. And xfrm_user doesn't
> > deal
From: Xin Long
Date: Tue, 17 Oct 2017 18:28:45 +0800
> On Tue, Oct 17, 2017 at 5:59 PM, Jiri Pirko wrote:
>> Tue, Oct 17, 2017 at 11:39:38AM CEST, lucien@gmail.com wrote:
>>>It's better to send notifications to userspace by the events
>>>in
From: "Gustavo A. R. Silva"
Date: Tue, 17 Oct 2017 13:59:20 -0500
> NULL check before freeing functions like kfree is not needed.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Applied to
From: "Gustavo A. R. Silva"
Date: Tue, 17 Oct 2017 14:01:45 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Applied to net-next.
On Wed, 18 Oct 2017 17:12:09 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Oct 16, 2017 at 12:19:39PM +0200, Jesper Dangaard Brouer wrote:
> > @@ -191,15 +280,45 @@ static int cpu_map_kthread_run(void *data)
> > * kthread_stop signal until queue is empty.
> > */
> >
From: James Morris
Date: Thu, 19 Oct 2017 12:49:59 +1100 (AEDT)
> On Wed, 18 Oct 2017, David Miller wrote:
>
>> Series applied.
>
> I hadn't gotten to reviewing this patchset yet.
>
> Please wait for more acks/reviews from LSM folk for things touching
> security/,
+0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
tags/linux-can-fixes-for-4.14-20171019
for you to fetch changes up to 97819f943063b622eca44d3644067c190dc75039:
can: gs_usb: fix busy loop if no more TX context is available (2017
From: Wolfgang Grandegger
If sending messages with no cable connected, it quickly happens that
there is no more TX context available. Then "gs_can_start_xmit()"
returns with "NETDEV_TX_BUSY" and the upper layer does retry
immediately keeping the CPU busy. To fix that issue,
This patch adds the missing check and error handling for out-of-memory
situations, when kzalloc cannot allocate memory.
Fixes: cb5635a36776 ("can: complete initial namespace support")
Acked-by: Oliver Hartkopp
Cc: linux-stable
Signed-off-by: Marc
"proto_tab" is a RCU protected array, when directly accessing the array,
sparse throws these warnings:
CHECK /srv/work/frogger/socketcan/linux/net/can/af_can.c
net/can/af_can.c:115:14: error: incompatible types in comparison expression
(different address spaces)
net/can/af_can.c:795:17:
On 26/09/2017 6:30 PM, Eric Dumazet wrote:
On Tue, Sep 26, 2017 at 8:22 AM, Dmitry Torokhov
wrote:
It is in Greg's tree where all kobject patches should go through as far as I
know.
Yes, I will fix this, adding a second memmove()
Hi Eric,
I just wanted to
From:
Date: Tue, 17 Oct 2017 07:30:34 +
> From: Netanel Belgazal
>
> ENA driver was developed by developers from Annapurna Labs.
> Annapurna Labs was acquired by Amazon and the company's domain
> (@annapurnalabs.com) will become deprecated soon.
>
>
On Thu, Oct 19, 2017 at 05:19:55AM +0800, Jiri Benc wrote:
> On Mon, 16 Oct 2017 21:53:29 +0800, Yi Yang wrote:
> > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key,
> > + const struct nlattr *a)
> > +{
> > + struct nshhdr *nh;
> > + size_t length;
> > + int
From: Eric Dumazet
Date: Tue, 17 Oct 2017 10:07:44 -0700
> From: Eric Dumazet
>
> syzkaller hit the WARN() in tun_get_user(), providing skb
> with payload in fragments only, and nothing in skb->head
>
> GRO layer is fine with this, so relax the
Hi Alex,
On ons, 2017-10-18 at 16:37 -0700, Alexander Duyck wrote:
> When we last talked I had asked if you could do a git bisect to find
> the memory leak and you said you would look into it. The most useful
> way to solve this would be to do a git bisect between your current
> kernel and the
[ full-quoting due to Cc fixups, adding netdev ]
Steve Ibanez wrote:
> Hi Florian, Neal, and Daniel,
>
> I hope this email finds you well. My name is Stephen Ibanez and I'm a PhD
> Student at Stanford currently working on a project with Mohammad Alizadeh,
> Nick McKeown,
On Thu, 19 Oct 2017 19:40:53 +0800, Yang, Yi wrote:
> Actually mdtype can't be set, only push_nsh can set mdtype, so set_nsh
> won't have mdtype flow key, we can't get it from flow_key in set_nsh,
> only ttl, flags and path_hdr can be set in set_nsh as you can see in code.
> I understand your
> DEVLINK_ATTR_PERM_CFG_MBA_LINK_SPEED: Configured link speed
> while executing MBA host software (PXI/iSCSI); use enum
> devlink_mba_link_speed.
#4 introduces:
> DEVLINK_ATTR_PERM_CFG_PRE_OS_LINK_SPEED_D0: Configure default
> pre-OS link speed in full power (D0) state; use enum
>
> DEVLINK_ATTR_PERM_CFG_NPAR_BW_RESERVATION_VALID: 1 to use
> BW_RESERVATION setting, 0 to ignore.
>
...
> DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT_VALID: 1 to use BW_LIMIT
> setting, 0 to ignore.
While it probably ties to different fields in your NVM layout why would the user
require specific
From: Jeff Kirsher
Date: Tue, 17 Oct 2017 11:21:04 -0700
> This series contains updates to i40e and ethtool.
>
> Alan provides most of the changes in this series which are mainly fixes
> and cleanups. Renamed the ethtool "cmd" variable to "ks", since the new
>
From: "ZHU Yi (ST-FIR/ENG1-Zhu)"
Enable FLEXCAN_QUIRK_BROKEN_PERR_STATE for i.MX6 to report correct state
transitions.
Signed-off-by: Zhu Yi
Signed-off-by: Mark Jonas
Acked-by: Wolfgang Grandegger
Cc:
From: "ZHU Yi (ST-FIR/ENG1-Zhu)"
Add FLEXCAN_QUIRK_BROKEN_PERR_STATE for better description of the
missing error passive interrupt quirk.
Error interrupt flooding may happen if the broken error state quirk fix
is enabled. For example, in case there is singled out node on
From: "ZHU Yi (ST-FIR/ENG1-Zhu)"
Rename FLEXCAN_QUIRK_BROKEN_ERR_STATE to FLEXCAN_QUIRK_BROKEN_WERR_STATE
for better description of the missing [TR]WRN_INT quirk.
Signed-off-by: Zhu Yi
Signed-off-by: Mark Jonas
Acked-by:
From: "ZHU Yi (ST-FIR/ENG1-Zhu)"
Enable FLEXCAN_QUIRK_BROKEN_WERR_STATE and
FLEXCAN_QUIRK_BROKEN_PERR_STATE for p1010 to report correct state
transitions.
Signed-off-by: Zhu Yi
Signed-off-by: Mark Jonas
Acked-by: Wolfgang
From: "ZHU Yi (ST-FIR/ENG1-Zhu)"
Update state upon any interrupt to report correct state transitions in
case the flexcan core enabled the broken error state quirk fix.
Signed-off-by: Zhu Yi
Signed-off-by: Mark Jonas
From: Michal Kalderon
Date: Tue, 17 Oct 2017 10:23:25 +0300
> Out of order flow is not working for iWARP.
> This patch got cut out from initial series that added out
> of order support for iWARP.
>
> Make out of order code common for iWARP and iSCSI.
> Add new
From: "Gustavo A. R. Silva"
Date: Tue, 17 Oct 2017 17:42:53 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced the "NOBREAK" comment with
> a "fall
From: Stephen Hemminger
Date: Tue, 17 Oct 2017 17:16:52 -0700
> dql_init always returned 0, and the only place that uses it
> in network core code didn't care about the return value anyway.
>
> Signed-off-by: Stephen Hemminger
Applied to
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I placed a "fall through" comment on
its own line, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva
Implements get and set of configuration parameters using new devlink
config get/set API.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 245 +-
Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent config
parameter. Defines number of MSI-X vectors allocated per VF.
Value is permanent (stored in NVRAM), so becomes the new default
value for this device.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
Changes since v1, based on the excellent feedback received:
* Implemented nested parameters correctly this time, I think.
* Submitting config get/set infrastructure separately from the
parameters themselves, and then submitting just the first four
parameters as separate patches. Once this
Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config
parameter, which sets the number of VFs per PF in SR-IOV
mode. Value is permanent (stored in NVRAM), so becomes the
new default value for this device.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
parameter. If value is 1, SR-IOV is enabled. If value is 0,
SR-IOV is disabled on this device. Value is permanent (stored
in NVRAM), so becomes the new default value for this device.
Signed-off-by: Steve Lin
On 2017-10-12 15:45, Steve Grubb wrote:
> On Thursday, October 12, 2017 10:14:00 AM EDT Richard Guy Briggs wrote:
> > Containers are a userspace concept. The kernel knows nothing of them.
> >
> > The Linux audit system needs a way to be able to track the container
> > provenance of events and
Under LOCKDEP, the timer lock_class_key (set up in __setup_timer) needs
to be tied to the caller's context, so an inline for timer_setup()
won't work. We do, however, want to keep the inline version around for
argument type checking, though, so this provides macro wrappers in the
LOCKDEP case.
From: Ben Greear
This makes it easier to properly handle errors when calling this
from scripts, etc.
Old behaviour:
$ ethtool -L eth3 combined 1
combined unmodified, ignoring
no channel parameters changed, aborting
current values: tx 0 rx 0 other 1 combined 1
Thu, Oct 19, 2017 at 09:17:06PM CEST, steven.l...@broadcom.com wrote:
>Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
>parameter. If value is 1, SR-IOV is enabled. If value is 0,
>SR-IOV is disabled on this device. Value is permanent (stored
>in NVRAM), so becomes the new default
On Thu, Oct 19, 2017 at 12:07 PM, Jean-Philippe Brucker
wrote:
> When the driver cannot map a TX buffer, instead of rolling back
> gracefully and retrying later, we currently get a panic:
>
> [ 159.885994] igb :00:00.0: TX DMA map failed
> [ 159.886588] Unable
On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
Acked-by: Paul Bolle
For
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to
> On Thu, Oct 19, 2017 at 2:07 AM, Yuval Mintz
> wrote:
> >> +enum devlink_autoneg_protocol {
> >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM,
> >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM,
> >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY,
> >> +
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to
On 10/19/2017 09:54 PM, Mario Hüttel wrote:
On 10/19/2017 08:35 PM, Oliver Hartkopp wrote:
We already have this 'dsample-point' implemented in the ip tool:
$ ip link set vcan0 type can help
Usage: ip link set DEVICE type can
[ bitrate BITRATE [ sample-point SAMPLE-POINT] ] |
[ tq
> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent
> config
> parameter. Defines number of MSI-X vectors allocated per VF.
> Value is permanent (stored in NVRAM), so becomes the new default
> value for this device.
Sounds like you're having this enforce the same configuration for all
Gustavo A. R. Silva wrote:
> + /* fall through */
All new comments in rxrpc should begin with a capital letter; I'm switching to
this as I modify the lines with comments on. Fix checkpatch or gcc or
whatever takes -Wimplicit-fallthrough to stop being silly.
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
Please, verify if the actual intention of the code is to
Add support for permanent config parameter get/set commands. Used
for parameters held in NVRAM, persistent device configuration.
Signed-off-by: Steve Lin
Acked-by: Andy Gospodarek
---
include/net/devlink.h| 3 +
Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config
parameter. Sets the maximum number of PF MSI-X (Message
Signaled Interrupts) vectors. Value is permanent (stored in
NVRAM), so becomes the new default value for this device.
Signed-off-by: Steve Lin
Quoting David Howells :
Gustavo A. R. Silva wrote:
+ /* fall through */
All new comments in rxrpc should begin with a capital letter; I'm
switching to
this as I modify the lines with comments on. Fix checkpatch or gcc or
Code refactoring in order to make the code easier to read and maintain.
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only (GCC 7.2.0 was used).
net/netrom/nr_route.c | 63 ---
1 file changed,
From: Craig Gallek
Syzkaller stumbled upon a way to trigger
WARNING: CPU: 1 PID: 13881 at net/core/sock_reuseport.c:41
reuseport_alloc+0x306/0x3b0 net/core/sock_reuseport.c:39
There are two initialization paths for the sock_reuseport structure in a
socket: Through the udp/tcp
On Thu, Oct 19, 2017 at 7:07 AM, Paolo Abeni wrote:
> The commit 2b760fcf5cfb ("ipv6: hook up exception table to store
> dst cache") partially reverted the commit 1e2ea8ad37be ("ipv6: set
> dst.obsolete when a cached route has expired").
>
> As a result, RTF_CACHE dst
On 10/19/2017 12:51 PM, Tom Herbert wrote:
> On Thu, Oct 19, 2017 at 10:42 AM, Eric Dumazet
> wrote:
>
>> On Fri, 2017-07-28 at 16:22 -0700, Tom Herbert wrote:
>>> Generalize strparser from more than just being used in conjunction
>>> with read_sock. strparser will also
On Mon, 2017-10-16 at 17:29 -0700, Kees Cook wrote:
> This replaces a kmalloc followed by a bunch of per-field zeroing with a
> single kzalloc call, reducing the lines of code.
Acked-by: Paul Bolle
Thanks,
Paul Bolle
When the driver cannot map a TX buffer, instead of rolling back
gracefully and retrying later, we currently get a panic:
[ 159.885994] igb :00:00.0: TX DMA map failed
[ 159.886588] Unable to handle kernel paging request at virtual address
0a08c7a8
...
[ 159.897031]
1 - 100 of 279 matches
Mail list logo