Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

On Mon, 13 Nov 2017 08:55:56 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 08:17:34AM CET, jakub.kicin...@netronome.com wrote: > >On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: > >> Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicin...@netronome.com wrote: > >> >On Sun, 12 Nov 2017

Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

Mon, Nov 13, 2017 at 09:12:35AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 08:55:56 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 08:17:34AM CET, jakub.kicin...@netronome.com wrote: >> >On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: >> >> Mon, Nov 13, 2017 at

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

On Mon, 13 Nov 2017 09:35:55 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 09:17:23AM CET, jakub.kicin...@netronome.com wrote: > >On Mon, 13 Nov 2017 09:08:16 +0100, Jiri Pirko wrote: > >> Mon, Nov 13, 2017 at 09:03:34AM CET, jakub.kicin...@netronome.com wrote: > >> >On Mon, 13 Nov 2017

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

Peter Zijlstra wrote: > On Mon, Nov 13, 2017 at 08:21:59AM +0100, Florian Westphal wrote: > > Reason is that some places do this: > > > > rtnl_register(pf, RTM_FOO, doit, NULL, 0); > > rtnl_register(pf, RTM_FOO, NULL, dumpit, 0); > > Sure, however, > > > (from different

Re: [PATCH v2] netfilter: mark expected switch fall-throughs

On Tue, Nov 07, 2017 at 08:19:29AM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1128839 > Addresses-Coverity-ID: 1128840 > Addresses-Coverity-ID: 115120 >

Re: [PATCH] wcn36xx: fix iris child-node lookup

Johan Hovold writes: > Fix child-node lookup during probe, which ended up searching the whole > device tree depth-first starting at the parent rather than just matching > on its children. > > To make things worse, the parent mmio node was also prematurely freed. > > Fixes:

[PATCH 2/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional()

devm_gpiod_get_optional() can return an error in addition to a NULL ptr. Check for error and propagate that to the probe function. Check return value in probe. This will now handle EPROBE_DEFER for the reset gpio. Signed-off-by: Phil Reid ---

RE: [PATCH V2 net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

Hi David, > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 13, 2017 1:19 AM > To: Salil Mehta > Cc: h...@lst.de; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org;

Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks

Mon, Nov 13, 2017 at 09:05:26AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 08:56:58 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 08:54:52AM CET, jakub.kicin...@netronome.com wrote: >> >On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote: >> >> diff --git

[PATCH 0/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional()

Replaces Pan Bian patch "net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional" Errors need to be prograted back from probe. Note: I have only compile tested the code as I don't have the hardware. Phil Reid (2): net: dsa: lan9303: make

[PATCH 1/2] net: dsa: lan9303: make lan9303_handle_reset() a void function

lan9303_handle_reset never returns anything other than success. So there's not need for it to return an error code. Signed-off-by: Phil Reid --- drivers/net/dsa/lan9303-core.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

Mon, Nov 13, 2017 at 09:03:34AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 08:58:44 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicin...@netronome.com wrote: >> >On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

Hi, those four patches never made it into any 4.13 release. 0001-net-call-sk_reuseport_match-if-we-are-a-reusesock.patch 0001-net-don-t-fast-patch-mismatched-sockets-in-STRICT-mo.patch 0001-net-use-inet6_rcv_saddr-to-compare-sockets.patch 0001-net-set-tb-fast_sk_family.patch And I have just

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

Mon, Nov 13, 2017 at 09:45:12AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 09:35:55 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 09:17:23AM CET, jakub.kicin...@netronome.com wrote: >> >On Mon, 13 Nov 2017 09:08:16 +0100, Jiri Pirko wrote: >> >> Mon, Nov 13, 2017 at

Re: [ftrace-bpf 1/5] add BPF_PROG_TYPE_FTRACE to bpf

> 1. anything bpf related has to go via net-next tree. I found there is a net-next git repo: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git I will use this repo for the further bpf-ftrace patch set. > 2. > this obviously breaks ABI. New types can only be added to the end.

[PATCH] ARM64: dts: meson-axg: add ethernet mac controller

Add DT info for the stmmac ethernet MAC which found in the Amlogic's Meson-AXG SoC, also describe the ethernet pinctrl & clock information here. This is tested in the S400 dev board which use a RTL8211F PHY, and the pins connect to the 'eth_rgmii_y_pins' group. Signed-off-by: Yixun Lan

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

On Mon, 13 Nov 2017 09:08:16 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 09:03:34AM CET, jakub.kicin...@netronome.com wrote: > >On Mon, 13 Nov 2017 08:58:44 +0100, Jiri Pirko wrote: > >> Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicin...@netronome.com wrote: > >> >On Sun, 12 Nov 2017

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

Mon, Nov 13, 2017 at 09:17:23AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 09:08:16 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 09:03:34AM CET, jakub.kicin...@netronome.com wrote: >> >On Mon, 13 Nov 2017 08:58:44 +0100, Jiri Pirko wrote: >> >> Mon, Nov 13, 2017 at

Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks

On Mon, 13 Nov 2017 08:56:58 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 08:54:52AM CET, jakub.kicin...@netronome.com wrote: > >On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote: > >> diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c > >> index 5ecc38f..ee89efc 100644 > >>

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

On Mon, 13 Nov 2017 08:58:44 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicin...@netronome.com wrote: > >On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Couple of classifiers call netif_keep_dst directly on

Re: [RFC] hv_netvsc: safer orderly shutdown

Stephen Hemminger writes: > > The NAPI disable is already handled by rndis close. Sorry, but I'm probably missing something: I can only see netif_napi_del() call in netvsc_device_remove() but this happens much later. And I don see us doing napi_disable() anywhere on

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 13 November 2017 11:54 > To: Paul Durrant > Cc: netdev@vger.kernel.org; Wei Liu ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH net-next v1]

Re: [PATCH 12/14] nubus: Rename struct nubus_dev

Hi Finn, On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain wrote: > It is misleading to use "dev" to mean a functional resource. And > in adopting the Linux Driver Model, struct nubus_board will embed a > struct device. Drivers will then bind with boards, not with

Re: [PATCH 26/31] nds32: Build infrastructure

On Wed, Nov 8, 2017 at 11:16 AM, Arnd Bergmann wrote: > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> --- /dev/null >> +++ b/arch/nds32/Kconfig >> @@ -0,0 +1,107 @@ >> +# >> +# For a description of the syntax of this configuration file, >> +# see

RE: [Xen-devel] [PATCH net-next v1] xen-netback: make copy batch size configurable

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2017 10:50 > To: Paul Durrant > Cc: Wei Liu ; xen-de...@lists.xenproject.org; 'Joao > Martins' ; netdev@vger.kernel.org >

Re: [PATCH iproute2 2/2] devlink: add batch command support

On Sun, Nov 12, 2017 at 04:16:50PM -0800, Stephen Hemminger wrote: > On Fri, 10 Nov 2017 21:47:35 +0200 > Leon Romanovsky wrote: > > > On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote: > > > On 10.11.2017 07:57, Leon Romanovsky wrote: > > > > On Fri, Nov 10, 2017 at

[PATCH net 5/6] tls: Avoid copying crypto_info again after cipher_type check.

Avoid copying crypto_info again after cipher_type check to avoid a TOCTOU exploits. The temporary array on the stack is removed as we don't really need it Fixes: 3c4d7559159b ('tls: kernel TLS support') Signed-off-by: Ilya Lesokhin --- net/tls/tls_main.c | 29

[PATCH net 6/6] tls: don't override sk_write_space if tls_set_sw_offload fails.

If we fail to enable tls in the kernel we shouldn't override the sk_write_space callback Fixes: 3c4d7559159b ('tls: kernel TLS support') Signed-off-by: Ilya Lesokhin --- net/tls/tls_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH net 3/6] tls: Fix TLS ulp context leak, when TLS_TX setsockopt is not used.

Previously the TLS ulp context would leak if we attached a TLS ulp to a socket but did not use the TLS_TX setsockopt, or did use it but it failed. This patch solves the issue by overriding prot[TLS_BASE_TX].close and fixing tls_sk_proto_close to work properly when its called with ctx->tx_conf ==

[PATCH net 0/6] tls: Miscellaneous fixes

Here's a set of miscellaneous fix patches. Patch 1 makes sure aead_request is initailized properly. Patches 2-3 Fix a memory leak we've encountered. patch 4 moves tls_make_aad to allow sharing it in the future. Patch 5 fixes a TOCTOU issue reported here:

[PATCH net 1/6] tls: Use kzalloc for aead_request allocation

Use kzalloc for aead_request allocation as we don't set all the bits in the request. Fixes: 3c4d7559159b ('tls: kernel TLS support') Signed-off-by: Ilya Lesokhin --- net/tls/tls_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c

[PATCH net 4/6] tls: Move tls_make_aad to header to allow sharing

move tls_make_aad as it is going to be reused by the device offload code and rx path. Remove unused recv parameter. Signed-off-by: Ilya Lesokhin --- include/net/tls.h | 15 +++ net/tls/tls_sw.c | 18 +- 2 files changed, 16 insertions(+), 17

Re: [PATCH] wcn36xx: fix iris child-node lookup

On Mon, Nov 13, 2017 at 08:51:49AM +, Kalle Valo wrote: > Johan Hovold writes: > > > Fix child-node lookup during probe, which ended up searching the whole > > device tree depth-first starting at the parent rather than just matching > > on its children. > > > > To make

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 10 November 2017 19:35 > To: netdev@vger.kernel.org > Cc: Joao Martins ; Wei Liu > ; Paul Durrant ; xen- >

Re: FW: [PATCH 15/31] nds32: System calls handling

On Mon, Nov 13, 2017 at 3:51 AM, Vincent Chen wrote: >>>On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> From: Greentime Hu > >>> +#define __ARCH_WANT_SYS_CLONE >> >>This seems ok, though it would be nice to have the

Re: [Xen-devel] [PATCH net-next v1] xen-netback: make copy batch size configurable

>>> On 13.11.17 at 11:33, wrote: >> From: Joao Martins [mailto:joao.m.mart...@oracle.com] >> Sent: 10 November 2017 19:35 >> --- a/drivers/net/xen-netback/netback.c >> +++ b/drivers/net/xen-netback/netback.c >> @@ -96,6 +96,11 @@ unsigned int xenvif_hash_cache_size = >>

Hello Dear...

Hello Dear... I know that this message will come to you as a surprise. I hoped that you will not expose or betray this trust and confident that I am about to repose on you, my name is M, Shakour Rosarita. I am 19 years old Girl, female, from Tartu Syria, (never married) 61 kg, white in

Re: [net-next] tcp: allow drivers to tweak TSQ logic

On Sat, 2017-11-11 at 15:38 -0800, Eric Dumazet wrote: > > Hm. I wish we wouldn't have to do this on every skb, but perhaps it > > doesn't matter that much. > > Yes, it does not matter, even at 40Gbit ;) :) > Same cache line already ;) Hah. It seemed so far away, but actually looking at the

[PATCH iproute2] ip: Fix compilation break on old systems

From: Leon Romanovsky As was reported [1], the iproute2 fails to compile on old systems, in Cong's case, it was Fedora 19, in our case it was RedHat 7.2, which failed with the following errors during compilation: ipxfrm.c: In function ‘xfrm_selector_print’: ipxfrm.c:479:7:

Fwd: FW: [PATCH 04/31] nds32: Exception handling

>> From: Greentime Hu >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Greentime Hu >> arch/nds32/mm/alignment.c | 564 >> +++ > >> diff --git a/arch/nds32/mm/alignment.c

Re: [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP

On 10. nov. 2017 12:54, Egil Hjelmeland wrote: Now that IGMP packets no longer is flooded in HW, we want the SW bridge to forward packets based on bridge configuration. To make that happen, IGMP packets must have skb->offload_fwd_mark = 0. Signed-off-by: Egil Hjelmeland

[PATCH net] geneve: show remote address and checksum info even after link down

geneve->sock4/6 were added with geneve_open and released with geneve_stop. So when geneve link down, we will not able to show remote address and checksum info after commit 11387fe4a98 ("geneve: fix fill_info when using collect_metadata"). Fix this by reset back to the previous behavior: only show

[PATCH net 2/6] tls: Add function to update the TLS socket configuration

The tx configuration is now stored in ctx->tx_conf. And sk->sk_prot is updated trough a function This will simplify things when we add rx and support for different possible tx and rx cross configurations. Signed-off-by: Ilya Lesokhin --- include/net/tls.h | 2 ++

Re: [PATCH 0/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional()

On 13. nov. 2017 09:07, Phil Reid wrote: Replaces Pan Bian patch "net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional" Errors need to be prograted back from probe. Note: I have only compile tested the code as I don't have the hardware. Phil Reid

[PATCH V3 net-next] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

This patch migrates the HNS3 driver code from use of depricated PCI MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. Signed-off-by: Salil Mehta Suggested-by: Christoph Hellwig --- PATCH V3: respin against latest net-next PATCH V2: Yuval

Re: [PATCH net-next] net: thunderbolt: Clear finished Tx frame bus address in tbnet_tx_callback()

On Sat, Nov 11, 2017 at 07:21:24PM +0900, David Miller wrote: > From: Mika Westerberg > Date: Thu, 9 Nov 2017 13:46:28 +0300 > > > When Thunderbolt network interface is disabled or when the cable is > > unplugged the driver releases all allocated buffers by

Re: [PATCH net-next v1] xen-netback: make copy batch size configurable

On 11/13/2017 10:33 AM, Paul Durrant wrote: >> -Original Message- >> From: Joao Martins [mailto:joao.m.mart...@oracle.com] >> Sent: 10 November 2017 19:35 >> To: netdev@vger.kernel.org >> Cc: Joao Martins ; Wei Liu >> ; Paul Durrant

[PATCH] socket: Move the socket inuse to namespace.

From: Tonghao Zhang This patch add a member in struct netns_core. and this is a counter for socket_inuse in the _net_ namespace. The patch will add/sub counter in the sock_alloc or sock_release. In the sock_alloc, the private data of inode saves the special _net_. When

Re: Per-CPU Queueing for QoS

I have been thinking we'd try to submit sch_cake to mainline on this go-around. It's been out of tree for way too long. I look forward to understanding your patches soon in the tbf case. (I'm only responding because cake uses deficit, rather than a token bucket, scheduler, and is not reliant on

Re: [PATCH RFC,WIP 0/5] Flow offload infrastructure

On Fri, 3 Nov 2017 16:26:31 +0100, Pablo Neira Ayuso wrote: > I'm measuring here that the software flow table forwarding path is 2.5 > faster than the classic forwarding path in my testbed. > > TODO, still many things: > > * Only IPv4 at this time. > * Only IPv4 SNAT is supported. > * No netns

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

> I wonder if there is some way to use the split format for the > intermediate files, but then for the very final link bring them all in > and make the end result be a traditional single binary. I'm not > talking the separate "dwp" package that packs multiple dwo files into > one, but to actually

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On 11/13/17 9:07 PM, Björn Töpel wrote: 2017-10-31 13:41 GMT+01:00 Björn Töpel : From: Björn Töpel [...] We'll do a presentation on AF_PACKET V4 in NetDev 2.2 [1] Seoul, Korea, and our paper with complete benchmarks will be released shortly on

Re: Per-CPU Queueing for QoS

On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet wrote: > On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >> > 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >>

Re: Per-CPU Queueing for QoS

2017-11-13 15:08 GMT-08:00 Eric Dumazet : > On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >> > 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >> >> On Sun, 12

Re: [PATCH net] ipv6: set all.accept_dad to 0 by default

On Mon, 13 Nov 2017 14:21:52 + Erik Kline wrote: > Alternatively, if we really want to make all, default, and ifname > useful perhaps we need to investigate a tristate option (for currently > boolean values, at least). -1 could mean no preference, for example. I think this

Re: [PATCH 12/14] nubus: Rename struct nubus_dev

On Mon, 13 Nov 2017, Geert Uytterhoeven wrote: > Hi Finn, > > On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain > wrote: > > It is misleading to use "dev" to mean a functional resource. And in > > adopting the Linux Driver Model, struct nubus_board will embed a > >

Re: [PATCH net-next] net: dsa: Fix dependencies on bridge

From: Andrew Lunn Date: Sat, 11 Nov 2017 16:29:41 +0100 > DSA now uses one of the symbols exported by the bridge, > br_vlan_enabled(). This has a stub, if the bridge is not > enabled. However, if the bridge is enabled, we cannot have DSA built > in and the bridge as a module,

Re: [PATCH net] ipv6: set all.accept_dad to 0 by default

On Mon, 13 Nov 2017 14:45:36 +0100 Nicolas Dichtel wrote: > The commit a2d3f3e33853 modifies the way to disable dad on an interface. > Before the patch, setting .accept_dad to 0 was enough to disable it. > Because all.accept_dad is set to 1 by default, after the patch,

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

Yes, thanks for your advise. I will modify, test it and then submit v3 On Tue, Nov 14, 2017 at 10:09 AM, Cong Wang wrote: > On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang > wrote: >> From: Tonghao Zhang >> >> This

Re: KASAN: use-after-free Read in rds_tcp_dev_event

On 11/7/17 12:28 PM, syzbot wrote: Hello, syzkaller hit the following crash on 287683d027a3ff83feb6c7044430c79881664ecf git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

[PATCH] uapi: fix linux/tls.h userspace compilation error

Move inclusion of a private kernel header from uapi/linux/tls.h to its only user - net/tls.h, to fix the following linux/tls.h userspace compilation error: /usr/include/linux/tls.h:41:21: fatal error: net/tcp.h: No such file or directory As to this point uapi/linux/tls.h was totaly unusuable

Re: len = bpf_probe_read_str(); bpf_perf_event_output(... len) == FAIL

On 11/13/2017 04:08 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 13, 2017 at 03:56:14PM +0100, Daniel Borkmann escreveu: >> On 11/13/2017 03:30 PM, Arnaldo Carvalho de Melo wrote: >>> Hi, >>> >>> In a5e8c07059d0 ("bpf: add bpf_probe_read_str helper") you >>> state: >>> >>>"This is

Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

Hi Bryant, A few things: 1) The commit message could probably be trimmed, especially the stack traces. 2) What exactly are you changing and why does it fix the issue? I couldn't figure that out from the commit message. 3) Does this need a Fixes: tag? > } > > - netdev->min_mtu =

RE: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

> Subject: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip > KSZ8795 DSA driver > > Hi! > > Are there any news here? Is there new release planned? Is there a git > tree somewhere? I probably should get it working, soon.. so I guess I > can help with testing. > Reviewed patches

Re: Per-CPU Queueing for QoS

2017-11-13 14:47 GMT-08:00 Alexander Duyck : > On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >> 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >>> On Sun, 12 Nov 2017 13:43:13 -0800 >>> Michael Ma

Re: Per-CPU Queueing for QoS

2017-11-13 18:05 GMT-08:00 Michael Ma : > 2017-11-13 15:08 GMT-08:00 Eric Dumazet : >> On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >>> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >>> > 2017-11-12 16:14 GMT-08:00

[PATCH v2] net: use ARRAY_SIZE

Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p

[PATCH] usbnet: ipheth: prevent TX queue timeouts when device not ready

iOS devices require the host to be "trusted" before servicing network packets. Establishing trust requires the user to confirm a dialog on the iOS device.Until trust is established, the iOS device will silently discard network packets from the host. Currently, the ipheth driver does not detect

Re: Per-CPU Queueing for QoS

2017-11-13 16:13 GMT-08:00 Alexander Duyck : > On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet wrote: >> On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >>> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >>> >

Re: [PATCH net] geneve: show remote address and checksum info even after link down

Hi Eric, Thanks for the comments. On Mon, Nov 13, 2017 at 03:27:25PM -0500, Eric Garver wrote: > > Fixes: 11387fe4a98 ("geneve: fix fill_info when using collect_metadata") > > Signed-off-by: Hangbin Liu > > --- > > drivers/net/geneve.c | 28 +++- >

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

> On 14 Nov 2017, at 10:09, Cong Wang wrote: > > On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang > wrote: >> From: Tonghao Zhang >> >> This patch add a member in struct netns_core. and this is >> a counter for

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

On Mon, Nov 13, 2017 at 7:23 PM, 张军伟(基础平台部) wrote: > >> On 14 Nov 2017, at 10:09, Cong Wang wrote: >> >> On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang >> wrote: >>> From: Tonghao Zhang

Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

From: Atul Gupta Date: Thu, 9 Nov 2017 16:59:01 +0530 > register xfrmdev_ops callbacks, Send IPsec tunneled data > to HW for inline processing. > The driver use hardware crypto accelerator to encrypt and > generate ICV for the transmitted packet in Inline mode. > >

Re: [PATCH 0/7] net: core: devname allocation cleanups

From: Rasmus Villemoes Date: Mon, 13 Nov 2017 00:15:03 +0100 > It's somewhat confusing to have both dev_alloc_name and > dev_get_valid_name. I can't see why the former is less strict than the > latter, so make them (or rather dev_alloc_name_ns and > dev_get_valid_name)

Fwd: FW: [PATCH 18/31] nds32: Library functions

>>On Wed, Nov 08, 2017 at 01:55:06PM +0800, Greentime Hu wrote: > >> +#define __range_ok(addr, size) (size <= get_fs() && addr <= (get_fs() >> +-size)) >> + >> +#define access_ok(type, addr, size) \ >> + __range_ok((unsigned long)addr, (unsigned long)size) > >> +#define

[PATCH net-next] liquidio: Missing error code in liquidio_init_nic_module()

We accidentally return success if lio_vf_rep_modinit() fails instead of propogating the error code. Fixes: e20f469660ad ("liquidio: synchronize VF representor names with NIC firmware") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH net-next 0/3] rxrpc: Fixes

From: David Howells Date: Sat, 11 Nov 2017 17:57:52 + > > Here are some patches that fix some things in AF_RXRPC: > > (1) Prevent notifications from being passed to a kernel service for a call > that it has ended. > > (2) Fix a null pointer deference that

Re: [PATCH v2 net-next] tcp: allow drivers to tweak TSQ logic

From: Eric Dumazet Date: Sat, 11 Nov 2017 15:54:12 -0800 > From: Eric Dumazet > > I had many reports that TSQ logic breaks wifi aggregation. > > Current logic is to allow up to 1 ms of bytes to be queued into qdisc > and drivers queues. > > But

Re: Per-CPU Queueing for QoS

On Mon, Nov 13, 2017 at 7:45 PM, John Fastabend wrote: > On 11/13/2017 06:18 PM, Michael Ma wrote: >> 2017-11-13 16:13 GMT-08:00 Alexander Duyck : >>> On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet >>> wrote: On

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

On 11/11/2017 05:33 PM, Fengguang Wu wrote: CC gcc list. According to Alexei: This is a known issue with gcc 7 on mips that is "optimizing" normal 64-bit multiply into 128-bit variant. Nothing to fix on the kernel side. I filed a bug report. This is now

Re: [PATCH V2 net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

On Thu, Nov 09, 2017 at 04:38:13PM +, Salil Mehta wrote: > This patch migrates the HNS3 driver code from use of depricated PCI > MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. > > Signed-off-by: Salil Mehta > Suggested-by: Christoph Hellwig

[PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static

Fixes the following sparse warnings: net/openvswitch/flow_netlink.c:340:8: warning: symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/openvswitch/flow_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH net-next] openvswitch: Using kfree_rcu() to simplify the code

The callback function of call_rcu() just calls a kfree(), so we can use kfree_rcu() instead of call_rcu() + callback function. Signed-off-by: Wei Yongjun --- net/openvswitch/meter.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

Ramon Fried writes: > From: Eyal Ilsar > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active > WLAN

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On 11/13/2017 09:33 PM, Björn Töpel wrote: > 2017-11-14 0:50 GMT+01:00 Alexei Starovoitov : >> On 11/13/17 9:07 PM, Björn Töpel wrote: >>> >>> 2017-10-31 13:41 GMT+01:00 Björn Töpel : From: Björn Töpel >>> [...]

Re: [PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets

From: Xin Long Date: Sat, 11 Nov 2017 19:58:50 +0800 > Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport > header offset") removed icmp6_code and icmp6_type check before calling > neigh_reduce when doing neigh proxy. > > It means all icmpv6 packets

[PATCH v3] wcn36xx: Set default BTLE coexistence config

From: Eyal Ilsar If the value for the firmware configuration parameters BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty cycle between BT and WLAN is such that if BT (including BLE) is active WLAN gets 0 bandwidth. When tuning these parameters having a

Re: r8169 regression: UDP packets dropped intermittantly

As far as I am aware there were no follow up comments to my last post on this subject on 24 March 2017. The text of that post is included below for reference. To summarise: a short test program which reliably triggered the problem was written in the hope it would assist in the repair of this

Re: [PATCHv3 1/1] bnx2x: fix slowpath null crash

From: Zhu Yanjun Date: Sat, 11 Nov 2017 10:42:03 -0500 > When "NETDEV WATCHDOG: em4 (bnx2x): transmit queue 2 timed out" occurs, > BNX2X_SP_RTNL_TX_TIMEOUT is set. In the function bnx2x_sp_rtnl_task, > bnx2x_nic_unload and bnx2x_nic_load are executed to shutdown and open >

Re: [PATCH net-next] net-sysfs: trigger netlink notification on ifalias change via sysfs

Tue, Nov 14, 2017 at 08:21:36AM CET, ro...@cumulusnetworks.com wrote: >From: Roopa Prabhu > >This patch adds netlink notifications on iflias changes via sysfs. >makes it consistent with the netlink path which also calls >netdev_state_change. Also makes it consistent

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

2017-11-14 0:50 GMT+01:00 Alexei Starovoitov : > On 11/13/17 9:07 PM, Björn Töpel wrote: >> >> 2017-10-31 13:41 GMT+01:00 Björn Töpel : >>> >>> From: Björn Töpel >>> >> [...] >>> >>> >>> We'll do a presentation on AF_PACKET V4 in NetDev

[PATCH net-next] xdp: sample: Missing curly braces in read_route()

The assert statement is supposed to be part of the else branch but the curly braces were accidentally left off. Fixes: 3e29cd0e6563 ("xdp: Sample xdp program implementing ip forward") Signed-off-by: Dan Carpenter diff --git a/samples/bpf/xdp_router_ipv4_user.c

Re: [PATCH v5 00/13] exit_net checks for objects initialized in net_init hook

From: Vasily Averin Date: Sun, 12 Nov 2017 22:26:44 +0300 > OpenVz kernel team have a long history of fighting against namespace-related > bugs, > some of them could be prevented by using simple checks described below. > > One of typical errors is related to live cycle of

Re: KASAN: use-after-free Read in rds_tcp_dev_event

On (11/13/17 19:30), Girish Moodalbail wrote: > (L538-540). However, it leaves behind some of the rds_tcp connections that > shared the same underlying RDS connection (L534 and 535). These connections > with pointer to stale network namespace are left behind in the global list. It leaves behind

Re: [PATCH net-next 0/3] bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics

From: Yonghong Song Date: Sat, 11 Nov 2017 16:00:33 -0800 > This patch set intends to change verifier ARG_CONST_SIZE_OR_ZERO > semantics so that simpler bpf programs can be written with verifier > acceptance. Patch #1 comment provided the detailed examples and > the patch itself

Re: [PATCH net 0/6] tls: Miscellaneous fixes

From: Ilya Lesokhin Date: Mon, 13 Nov 2017 10:22:43 +0200 > Here's a set of miscellaneous fix patches. > > Patch 1 makes sure aead_request is initailized properly. > Patches 2-3 Fix a memory leak we've encountered. > patch 4 moves tls_make_aad to allow sharing it in the

Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns

Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangc...@gmail.com wrote: >On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently, user may choose to move device that is used by mirred action >> to another network namespace. That is

Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns

On Mon, Nov 13, 2017 at 9:17 PM, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangc...@gmail.com wrote: >>On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Currently, user may choose to move

[PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd_features()

In case of error, the function ovs_meter_cmd_reply_start() returns ERR_PTR() not NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") Signed-off-by: Wei Yongjun ---

Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns

Tue, Nov 14, 2017 at 06:51:42AM CET, xiyou.wangc...@gmail.com wrote: >On Mon, Nov 13, 2017 at 9:17 PM, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangc...@gmail.com wrote: >>>On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko wrote: From:

  1   2   3   >