Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8

On Fri, Dec 01, 2017 at 08:56:24PM +0100, Michal Kubecek wrote: > On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote: > > On Fri, 1 Dec 2017 13:04:51 +0200 > > Leon Romanovsky wrote: > > > > > From: Leon Romanovsky > > > > > > Add

[PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

The Gemini ethernet has been around for years as an out-of-tree patch used with the NAS boxen and routers built on StorLink SL3512 and SL3516, later Storm Semiconductor, later Cortina Systems. These ASICs are still being deployed and brand new off-the-shelf systems using it can easily be acquired.

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

Hi Russel The Grygorii has raised one Additional point (about netif_carrier_off) I just didn't want to start before finishing the previous one. On ifconfig-down the mac_config() called but with LINK=0. The config has no any knowledge what is intention -- up or down and should be done under

Re: [Patch net-next] net_sched: get rid of rcu_barrier() in tcf_block_put_ext()

Sat, Dec 02, 2017 at 01:18:04AM CET, xiyou.wangc...@gmail.com wrote: >Both Eric and Paolo noticed the rcu_barrier() we use in >tcf_block_put_ext() could be a performance bottleneck when >we have lots of filters. The problem is not a lots of filters, the problem is lots of classes and therefore

Re: [PATCH net] nfp: fix port stats for mac representors

On Fri, Dec 1, 2017 at 9:37 PM, Jakub Kicinski wrote: > From: Pieter Jansen van Vuuren > > Previously we swapped the tx_packets, tx_bytes and tx_dropped counters > with rx_packets, rx_bytes and rx_dropped counters, respectively.

Re: [BUG] mveta: mvneta_txq_bufs_free NULL pointer dereference

Hi >> I'm not sure at all, but could you try to apply >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d63785c6b94b5d2f095f90755825f90eea791f5 >> and see if the problem is resolved ?> > I will apply the patch right away, and report back. > The same issue

Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8

On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote: > On Fri, 1 Dec 2017 13:04:51 +0200 > Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > Add asm/posix_types.h header file to the list of needed includes, > > because the headers

Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

Thu, Nov 30, 2017 at 11:53:32PM CET, xiyou.wangc...@gmail.com wrote: >tcfm_dev always points to the correct netdev and we already >hold a refcnt, so no need to use ifindex to lookup again. > >If we would support moving target netdev across netns, using >pointer would be better than ifindex. > >Cc:

Re: [PATCH 01/10] trailing whitespace fixed

On Sun, Nov 26, 2017 at 01:45:56AM +0300, Mike wrote: > Signed-off-by: Mike > --- > drivers/staging/irda/drivers/ali-ircc.c | 1002 > +++ > 1 file changed, 501 insertions(+), 501 deletions(-) > Hi, This is the friendly patch-bot of Greg

[PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other transitions are not traced with tcp_set_state tracepoint. In order to trace the whole tcp lifespans, two helpers are introduced, void __tcp_set_state(struct sock *sk, int state) void __sk_state_store(struct sock *sk, int

[PATCH net-next 1/2 v6] net: ethernet: Add DT bindings for the Gemini ethernet

This adds the device tree bindings for the Gemini ethernet controller. It is pretty straight-forward, using standard bindings and modelling the two child ports as child devices under the parent ethernet controller device. Cc: devicet...@vger.kernel.org Cc: Tobias Waldvogel

Re: [PATCH 00/10] Code style patches for staging/irda

On Sun, Nov 26, 2017 at 01:45:55AM +0300, Mike wrote: > > This is my task from Little Penguin :) What does that mean? > > Mike (10): > trailing whitespace fixed > spaces before tabs are fixed > trailing */ on a separate line fixed > if-else code style fixed > space prohibited before

[PATCH net-next] net: phy: broadcom: re-add mistakenly removed config settings

Previous patch mistakenly removed three chip-specific config settings. Add them again. Fixes: 80274abafc60 "net: phy: remove generic settings for callbacks config_aneg and read_status from drivers" Signed-off-by: Heiner Kallweit --- drivers/net/phy/broadcom.c | 3 +++ 1

Re: [PATCH 1/3] iio: trigger: Fix platform_get_irq's error checking

On Thu, 30 Nov 2017 21:13:34 +0530 Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav

Re: netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On Fri, Dec 01, 2017 at 09:47:00PM +0100, Daniel Borkmann wrote: > > Might want to replace security_path_mknod() with something saner, while we > > are > > at it. > > > > Objections? > > No, thanks for looking into this, and sorry for this fugly hack! :( Not > that this doesn't make it any

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

On Thu, Nov 30, 2017 at 12:26 AM, Florian Fainelli wrote: > On 11/29/2017 03:19 PM, Linus Walleij wrote: >> Or are there in pracice things such that reg is different >> on the port and the PHY connected to it? Then it makes >> much sense to put an MDIO bus inside the switch

Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

Ok Bhadram thx for this check, I was afraid that the HW FIFO had some issues. Best Regards Peppe On 12/1/2017 4:39 PM, Bhadram Varka wrote: Hi Giuseppe, I don't see any issue with if we execute "ping -s 1400" case. I believe in this case TSO not triggered. Thanks, Bhadram. -Original

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

On Sat, Dec 02, 2017 at 11:08:45AM +, Yan Markman wrote: > Hi Russel > > The Grygorii has raised one Additional point (about netif_carrier_off) > I just didn't want to start before finishing the previous one. > > On ifconfig-down the mac_config() called but with LINK=0. > The config has no

Re: ath9k: dfs: use swap macro in ath9k_check_chirping

"Gustavo A. R. Silva" wrote: > Make use of the swap macro and remove unnecessary variable temp. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva >

Re: [v4] wcn36xx: Set default BTLE coexistence config

Ramon Fried wrote: > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active > WLAN gets 0 bandwidth. When tuning these parameters

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-28 3:07 GMT+08:00 Rob Herring : > On Mon, Nov 27, 2017 at 6:28 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds support for device tree. >> >> Signed-off-by: Vincent Chen >>

Re: [PATCH] net: phy: realtek: fix RTL8211F interrupt mode

Hi Heiner, On Sun, Nov 12, 2017 at 4:16 PM, Heiner Kallweit wrote: > After commit b94d22d94ad22 "ARM64: dts: meson-gx: add external PHY > interrupt on some platforms" ethernet stopped working on my Odroid-C2 > which has a RTL8211F phy. > > It turned out that no interrupts

Wireless regressions in v4.15-rc1

Hi, just a heads up to everyone that there are multiple regressions in v4.15-rc1. For starters hostapd (=AP mode) doesn't work because of: net: netlink: Update attr validation to require exact length for some types https://git.kernel.org/linus/28033ae4e0f5 Jouni fixed this already in hostapd

[PATCH 10/10] net: ethernet: cpmac: Handle return value of platform_get_irq_byname

platform_get_irq_byname() can fail here and we must check its return value Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ti/cpmac.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index

[PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource

platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/fjes/fjes_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c

[PATCH 09/10] net: ethernet: korina: Handle return value of platform_get_irq_byname

platform_get_irq_byname() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/korina.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH 07/10] net: ethernet: smsc: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/smsc/smc911x.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c

[PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

From: Johannes Berg This netlink type is used only for backwards compatibility with broken userspace that used the wrong size for a given u8 attribute, which is now rejected. It would've been wrong before already, since on big endian the wrong value (always zero) would

[PATCH net 2/2] nl80211: use NLA_U8_BUGGY for two attributes

From: Johannes Berg We discovered that these are set incorrectly by the corresponding userspace code, so keep compatible with their bugs even if they'd always set the value to 0. Reported-by: Jouni Malinen Fixes: 28033ae4e0f5 ("net: netlink: Update attr

[PATCH net-next 2/4] rtnetlink: get reference on module before invoking handlers

Add yet another rtnl_register function. It will be used by modules that can be removed. The passed module struct is used to prevent module unload while a netlink dump is in progress or when a DOIT_UNLOCKED doit callback is called. Cc: Peter Zijlstra Signed-off-by: Florian

Re: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource

Hi Sergei, On Sunday 03 December 2017 01:36 AM, Sergei Shtylyov wrote: Hello! On 12/02/2017 10:26 PM, Arvind Yadav wrote: platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav ---

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

On 12/2/2017 2:33 PM, Yossi Kuperman wrote: On 1 Dec 2017, at 9:09, Steffen Klassert wrote: On Tue, Nov 28, 2017 at 07:55:41PM +0200, av...@mellanox.com wrote: From: Aviv Heller Adding the state to the offload device prior to replay init

Re: [PATCH net-next] openvswitch: do not propagate headroom updates to internal port

From: Paolo Abeni Date: Thu, 30 Nov 2017 15:35:33 +0100 > After commit 3a927bc7cf9d ("ovs: propagate per dp max headroom to > all vports") the need_headroom for the internal vport is updated > accordingly to the max needed headroom in its datapath. > > That avoids the

Re: [PATCH net-next 0/4] net: dsa: simplify switchdev prepare phase

From: Vivien Didelot Date: Thu, 30 Nov 2017 11:23:56 -0500 > This patch series brings no functional changes. > > It removes the unused switchdev_trans arguments from the dsa_switch_ops > for both MDB and VLAN operations, and provides functions to prepare and

Re: [PATCH net 0/4] bnxt_en: Fixes.

From: Michael Chan Date: Fri, 1 Dec 2017 03:13:01 -0500 > A shutdown fix for SMARTNIC, 2 fixes related to TC Flower vxlan > filters, and the last one fixes an out-of-scope variable when sending > short firmware messages. Series applied, thanks Michael.

Re: [PATCH 07/10] net: ethernet: smsc: Handle return value of platform_get_irq

On 12/02/2017 10:26 PM, Arvind Yadav wrote: platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/smsc/smc911x.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi Sergei, On Sunday 03 December 2017 01:38 AM, Sergei Shtylyov wrote: Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

[PATCH net-next 5/5] net: phy: realtek: add utility functions to read/write page addresses

Realtek PHYs implement the concept of so-called "extension pages". The reason for this is probably because these PHYs expose more registers than available in the standard address range. After all read/write operations on such a page are done the driver should switch back to page 0 where the

[PATCH net-next 3/5] net: phy: realtek: group all register bit #defines for RTL821x_INER

This simply moves all register bit #defines which describe the (PHY specific) bits in the RTL821x_INER right below the RTL821x_INER register definition. This makes it easier to spot which registers and bits belong together. No functional changes. Signed-off-by: Martin Blumenstingl

[PATCH net-next 2/5] net: phy: realtek: rename RTL821x_INER_INIT to RTL8211B_INER_INIT

This macro is only used by the RTL8211B code. RTL8211E and RTL8211F both use other bits to initialize the RTL821x_INER register. No functional changes. Signed-off-by: Martin Blumenstingl --- drivers/net/phy/realtek.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

>> On 1 Dec 2017, at 9:09, Steffen Klassert >> wrote: >> >> On Tue, Nov 28, 2017 at 07:55:41PM +0200, av...@mellanox.com wrote: >> From: Aviv Heller >> >> Adding the state to the offload device prior to replay init in >>

Re: [PATCH net 1/2] netlink: add NLA_U8_BUGGY attribute type

On 12/2/17 1:23 PM, Johannes Berg wrote: > From: Johannes Berg > > This netlink type is used only for backwards compatibility > with broken userspace that used the wrong size for a given > u8 attribute, which is now rejected. It would've been wrong > before already,

Re: [PATCH net-next v3 0/8] xdp: make stack perform remove and add selftests

On 12/02/2017 12:08 AM, Jakub Kicinski wrote: > Hi! > > The purpose of this series is to add a software model of BPF offloads > to make it easier for everyone to test them and make some of the more > arcane rules and assumptions more clear. > > The series starts with 3 patches aiming to make XDP

Re: Fixing CVE-2017-16939 in v4.4.y and possibly v3.18.y

On 12/01/2017 11:48 AM, Michal Kubecek wrote: On Thu, Nov 30, 2017 at 10:37:40AM -0800, Guenter Roeck wrote: Hi, The fix for CVE-2017-16939 has been applied to v4.9.y, but not to v4.4.y and older kernels. However, I confirmed that running the published POC (see

[PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2

[PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1

[PATCH 04/10] can: xilinx: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/can/xilinx_can.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 89aec07..e36e2a2

[PATCH 06/10] net: ethernet: natsemi: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/natsemi/jazzsonic.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c

[PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. And remove unnecessary check for free_netdev(). Signed-off-by: Arvind Yadav ---

[PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error

The change is to call free_netdev(), If of_match_node() will fail. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c

[PATCH 00/10] Handle return value of platform_get_*

- The platform_get_*_*() function returns negative if an error occurs. zero or positive number on success. platform_get_irq_byname() error checking for zero is not correct. - The change is to call free_netdev(), If of_match_node() will fail. - Handle return value of

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. The why you consider returning 0 a sign of failure? Signed-off-by:

[PATCH net-next 1/5] net: phy: realtek: use the BIT and GENMASK macros

This makes it easier to compare the #defines with the datasheets. No functional changes. Signed-off-by: Martin Blumenstingl --- drivers/net/phy/realtek.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/phy/realtek.c

[PATCH net-next 0/5] Realtek Ethernet PHY driver improvements

This series provides some small improvements and cleanups for the Realtek Ethernet PHY driver. None of the patches in this series should change any functionality. The goal is to make the code a bit easier to read by: - re-using the BIT and GENMASK macros (which makes it easier to compare the

[PATCH net-next 4/5] net: phy: realtek: use the same indentation for all #defines

This simply makes the code easier to read. No functional changes. Signed-off-by: Martin Blumenstingl --- drivers/net/phy/realtek.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/net/phy/realtek.c

[RfC net-next 1/3] net: phy: realtek: add support for configuring the RX delay on RTL8211F

On RTL8211F the RX delay can also be enabled/disabled. The overall behavior of the RX delay is similar to the behavior of the TX delay, which was already supported by the driver. The RX delay (similar to the TX delay) may be enabled using hardware pin strapping. If the MAC already configures the

Re: netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On Sat, Dec 02, 2017 at 06:48:50PM +, Al Viro wrote: > On Fri, Dec 01, 2017 at 09:47:00PM +0100, Daniel Borkmann wrote: > > > > Might want to replace security_path_mknod() with something saner, while > > > we are > > > at it. > > > > > > Objections? > > > > No, thanks for looking into

[RfC net-next 3/3] net: phy: realtek: add more interrupt bits for RTL8211E and RTL8211F

This documents a few more bits in the RTL821x_INER register for RTL8211E and RTL8211F. These are added only to document them (as no public datasheets are available for these PHYs), they are currently not used. Signed-off-by: Martin Blumenstingl ---

Re: [PATCH] vsock.7: document VSOCK socket address family

On Fri, Dec 01, 2017 at 09:57:04AM -0500, G. Branden Robinson wrote: > At 2017-12-01T13:09:01+, Stefan Hajnoczi wrote: > > On Thu, Nov 30, 2017 at 01:21:26PM +, Jorgen S. Hansen wrote: > > > > On Nov 30, 2017, at 12:21 PM, Stefan Hajnoczi > > > > wrote: > > > >

RE: [PATCH net-next] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver

Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, December 01, 2017 1:44 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen) > ; lipeng (Y) ; >

Re: [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

On Sat, Dec 02, 2017 at 10:01:35AM +0530, Sagar Arun Kamble wrote: > There is no real need for the users of timecounters to define cyclecounter > and timecounter variables separately. Since timecounter will always be > based on cyclecounter, have cyclecounter struct as member of timecounter >

Re: [PATCH net-next 0/2] net: dsa: cross-chip FDB support

From: Vivien Didelot Date: Thu, 30 Nov 2017 12:56:41 -0500 > DSA can have interconnected switches. For instance, the ZII Dev Rev B > board described in arch/arm/boot/dts/vf610-zii-dev-rev-b.dts has a > switch fabric composed of 3 switch devices like this: >

Re: netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

>> OK... See vfs.git#untested.mkobj; it really needs testing, though - >> mq_open(2) >> passes LTP tests, but that's not saying much, and BPF side is completely >> untested. > > ... and FWIW, completely untested patch for net/netfilter/xt_bpf.c follows: Thanks a lot for this fix. The tree

Re: [PATCH net 0/3] s390/qeth: fixes 2017-12-01

From: Julian Wiedmann Date: Fri, 1 Dec 2017 10:14:48 +0100 > please apply the following three fixes for 4.15. These should also go > back to stable. Series applied and queued up for -stable, thanks.

Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks

From: w...@redhat.com Date: Fri, 1 Dec 2017 05:10:35 -0500 > Matthew found a roughly 40% tcp throughput regression with commit > c67df11f(vhost_net: try batch dequing from skb array) as discussed > in the following thread: > https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html

Re: [PATCH net-next 5/5] net: phy: realtek: add utility functions to read/write page addresses

On Sat, Dec 02, 2017 at 10:51:28PM +0100, Martin Blumenstingl wrote: > Realtek PHYs implement the concept of so-called "extension pages". The > reason for this is probably because these PHYs expose more registers > than available in the standard address range. > After all read/write operations on

Re: [PATCH net-next 1/5] net: phy: realtek: use the BIT and GENMASK macros

On Sat, Dec 02, 2017 at 10:51:24PM +0100, Martin Blumenstingl wrote: > This makes it easier to compare the #defines with the datasheets. > No functional changes. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 2/5] net: phy: realtek: rename RTL821x_INER_INIT to RTL8211B_INER_INIT

On Sat, Dec 02, 2017 at 10:51:25PM +0100, Martin Blumenstingl wrote: > This macro is only used by the RTL8211B code. RTL8211E and RTL8211F both > use other bits to initialize the RTL821x_INER register. > No functional changes. > > Signed-off-by: Martin Blumenstingl

Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

Sat, Dec 02, 2017 at 08:53:20PM CET, xiyou.wangc...@gmail.com wrote: >On Sat, Dec 2, 2017 at 11:47 AM, Cong Wang wrote: >> On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko wrote: >>> Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and >>>

Re: [stable] s390/qeth: stable candidates

From: Julian Wiedmann Date: Fri, 1 Dec 2017 10:22:37 +0100 > 83cf79a2fec3 s390/qeth: fix early exit from error path > Fixes: 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") > For 4.8+ Queued up. The rest are for truly ancient kernels. I

Re: [PATCH net-next 3/5] net: phy: realtek: group all register bit #defines for RTL821x_INER

On Sat, Dec 02, 2017 at 10:51:26PM +0100, Martin Blumenstingl wrote: > This simply moves all register bit #defines which describe the (PHY > specific) bits in the RTL821x_INER right below the RTL821x_INER register > definition. This makes it easier to spot which registers and bits belong >

Re: [PATCH net-next 4/5] net: phy: realtek: use the same indentation for all #defines

On Sat, Dec 02, 2017 at 10:51:27PM +0100, Martin Blumenstingl wrote: > This simply makes the code easier to read. No functional changes. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v4 2/2] net: ethernet: socionext: add AVE ethernet driver

Hi Kunihiko, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Kunihiko-Hayashi/dt-bindings-net-add-DT-bindings-for-Socionext-UniPhier-AVE/20171203-095248 config: alpha-allyesconfig (attached as

Re: [RFC] virtio-net: help live migrate SR-IOV devices

On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: > > > Re. problem #2: > > > Indeed the best way to address it seems to be to enslave the VF driver > > > netdev

Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko wrote: > Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and > tcf_mirred_ifindex. Then you can remove tcfm_ifindex completely. Sounds good. Will send v2.

Re: [Patch net-next] act_mirred: use tcfm_dev in tcf_mirred_get_dev()

On Sat, Dec 2, 2017 at 11:47 AM, Cong Wang wrote: > On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko wrote: >> Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and >> tcf_mirred_ifindex. Then you can remove tcfm_ifindex completely. > > Sounds

Re: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource

Hello! On 12/02/2017 10:26 PM, Arvind Yadav wrote: platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/fjes/fjes_main.c | 10 ++ 1 file changed, 10 insertions(+)

Re: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

On 12/1/2017 11:47 AM, Shannon Nelson wrote: On 11/28/2017 9:55 AM, av...@mellanox.com wrote: From: Aviv Heller Adding the state to the offload device prior to replay init in xfrm_state_construct() will result in NULL dereference if a matching ESP packet is received in

pull-request: bpf-next 2017-12-03

Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Addition of a software model for BPF offloads in order to ease testing code changes in that area and make semantics more clear. This is implemented in a new driver called

[PATCH net-next 4/4] rtnetlink: remove __rtnl_register

This removes __rtnl_register and switches callers to either rtnl_register or rtnl_register_module. Also, rtnl_register() will now print an error if memory allocation failed rather than panic the kernel. Signed-off-by: Florian Westphal --- include/net/rtnetlink.h | 2 --

[PATCH next-next 0/4] rtnetlink: rework handler (un)registering

Peter Zijlstra reported (referring to commit 019a316992ee0d983, "rtnetlink: add reference counting to prevent module unload while dump is in progress"): 1) it not in fact a refcount, so using refcount_t is silly 2) there is a distinct lack of memory barriers, so we can easily observe the

[PATCH net-next 3/4] net: use rtnl_register_module where needed

all of these can be compiled as a module, so use new _module version to make sure module can no longer be removed while callback/dump is in use. Signed-off-by: Florian Westphal --- net/bridge/br_mdb.c | 6 +++--- net/can/gw.c| 14 ++

[PATCH net-next 1/4] net: rtnetlink: use rcu to free rtnl message handlers

rtnetlink is littered with READ_ONCE() because we can have read accesses while another cpu can write to the structure we're reading by (un)registering doit or dumpit handlers. This patch changes this so that (un)registering cpu allocates a new structure and then publishes it via

[RfC net-next 2/3] net: phy: realtek: configure the INTB pin on RTL8211F

The interrupt pin on the RTL8211F PHY can be used in two different modes: INTB - the default mode of the PHY - interrupts can be configured through page 0xa42 register RTL821x_INER - interrupts can be ACK'ed through RTL8211F_INSR - it acts as a level-interrupt which is active low - Wake-on-LAN

[RfC net-next 0/3] RTL8211F Ethernet PHY "documentation"

A recent patch from Heiner made me curious if the RTL8211F part of the realtek.c PHY driver is correct: [0] I contacted Realtek and asked if we could get a datasheet for the RTL8211F PHY. it seems that the full datasheet can only be obtained with an NDA. however, the contact at Realtek kindly

Re: Fixing CVE-2017-16939 in v4.4.y and possibly v3.18.y

On Sat, Dec 02, 2017 at 04:20:40PM -0800, Guenter Roeck wrote: > On 12/01/2017 11:48 AM, Michal Kubecek wrote: > > On Thu, Nov 30, 2017 at 10:37:40AM -0800, Guenter Roeck wrote: > > > Hi, > > > > > > The fix for CVE-2017-16939 has been applied to v4.9.y, but not to v4.4.y > > > and older kernels.