[PATCH net-next v2 1/5] net: mvpp2: only free the TSO header buffers when it was allocated

2017-12-11 Thread Antoine Tenart
This patch adds a check to only free the TSO header buffer when its allocation previously succeeded. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[PATCH net-next v2 2/5] net: mvpp2: split the max ring size from the default one

2017-12-11 Thread Antoine Tenart
From: Yan Markman The Rx/Tx ring sizes can be adjusted thanks to ethtool given specific network needs. This commit splits the default ring size from its max value to allow ethtool to vary the parameters in both ways. Signed-off-by: Yan Markman

[PATCH net-next v2 0/5] net: mvpp2: various improvements

2017-12-11 Thread Antoine Tenart
Hi all, These patches are sent as a series to avoid any possible conflict, even though there're not entirely related. I can send them separately if needed. The series applies on today's net-next tree. Thanks! Antoine Since v1: - Removed the patch disabling TSO on allocation errors. Antoine

[PATCH net] tcp md5sig: Use skb's saddr when replying to an incoming segment

2017-12-11 Thread Christoph Paasch
The MD5-key that belongs to a connection is identified by the peer's IP-address. When we are in tcp_v4(6)_reqsk_send_ack(), we are replying to an incoming segment from tcp_check_req() that failed the seq-number checks. Thus, to find the correct key, we need to use the skb's saddr and not the

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-11 Thread Richard Weinberger
Randy, Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: > On 12/10/2017 06:08 PM, Linus Torvalds wrote: > > Another week, another rc. > > um (uml) won't build on i386 or x86_64: > > CC init/main.o > In file included from ../include/linux/perf_event.h:18:0, >

[PATCH net-next v2 3/5] net: mvpp2: align values in ethtool get_coalesce

2017-12-11 Thread Antoine Tenart
Cosmetic patch aligning values in the ethtool get_coalesce function. This patch do not modify in anyway the driver's behaviour. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH net-next v2 5/5] net: mvpp2: adjust the coalescing parameters

2017-12-11 Thread Antoine Tenart
This patch adjust the coalescing parameters to the vendor recommendations for the PPv2 network controller. Suggested-by: Yan Markman Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 4 ++-- 1 file changed, 2

[PATCH net-next v2 4/5] net: mvpp2: report the tx-usec coalescing information to ethtool

2017-12-11 Thread Antoine Tenart
This patch adds the tx-usec value to the informations reported to ethtool by the get_coalesce function. Suggested-by: Yan Markman Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 1 + 1 file changed, 1

[PATCH net-next 2/2] net: tap: fix POLLOUT condition in tap_poll()

2017-12-11 Thread yuan linyu
From: yuan linyu from logical view, if sock_writeable(>sk) return false, original second condition will false too, change it and make second condition can return true. Signed-off-by: yuan linyu --- drivers/net/tap.c | 3 +-- 1

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread Masami Hiramatsu
Hello, 2017-12-11 21:04 GMT+09:00 Kunihiko Hayashi : > On Mon, 11 Dec 2017 10:19:15 +0100 Phlippe Ombredanne > wrote: > >> Dear Kunihiko-san, >> >> On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi >> wrote:

[RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-11 Thread Michal Kubecek
Request the same information as ETHTOOL_GDRVINFO. This is read-only so that corresponding SET_DRVINFO exists but is only used in kernel replies. Rip the code to query the driver out of the legacy interface and move it to a new file ethtool_common.c so that both interfaces can use it.

[PATCH net-next v5 2/2] net: thunderx: add timestamping support

2017-12-11 Thread Aleksey Makarov
From: Sunil Goutham This adds timestamping support for both receive and transmit paths. On the receive side no filters are supported i.e either all pkts will get a timestamp appended infront of the packet or none. On the transmit side HW doesn't support timestamp insertion

[PATCH net-next v5 1/2] net: add support for Cavium PTP coprocessor

2017-12-11 Thread Aleksey Makarov
From: Radoslaw Biernacki This patch adds support for the Precision Time Protocol Clocks and Timestamping hardware found on Cavium ThunderX processors. Signed-off-by: Radoslaw Biernacki Signed-off-by: Aleksey Makarov ---

Re: pull-request: mac80211 2017-12-11

2017-12-11 Thread David Miller
From: Johannes Berg Date: Mon, 11 Dec 2017 10:52:35 +0100 > Three fixes, two related to build issues with the new regdb stuff, > and one for some patch overlap problem that caused locking to be > missing which in turn caused lots of warnings. > > Please pull and let

[RFC PATCH 2/9] ethtool: introduce ethtool netlink interface

2017-12-11 Thread Michal Kubecek
No function implemented yet, only genetlink and module infrastructure. Register/unregister genetlink family "ethtool" and allow the module to be autoloaded by genetlink code (if built as a module, distributions would probably prefer "y"). Signed-off-by: Michal Kubecek ---

[RFC PATCH 0/9] ethtool netlink interface (WiP)

2017-12-11 Thread Michal Kubecek
This is still work in progress and only a very small part of the ioctl interface is reimplemented but I would like to get some comments before the patchset becomes too big and changing things becomes too tedious. The interface used for communication between ethtool and kernel is based on ioctl()

Re: 76f43b4 fix for stable

2017-12-11 Thread Johannes Berg
On Mon, 2017-12-11 at 14:51 +0100, Richard Schütz wrote: > Hello, > > as per netdev-FAQ.txt I'm requesting the submission of commit > 57629915d568c522ac1422df7bba4bee5b5c7a7c ("mac80211: Fix addition of > mesh configuration element") to stable. Because of automatic selection > commit

Re: Waiting for the PHY to complete auto-negotiation

2017-12-11 Thread Mason
+ Mans On 09/12/2017 19:49, Florian Fainelli wrote: > Having any HW state machine requiring X number of clock cycles to > guarantee a full transition to a stopped state is not unusual, however, > the fact that you need to send 5 packets to guarantee an EOC descriptor > is hit is completely

Re: [PATCH net-next v5 0/2] net: thunderx: add support for PTP clock

2017-12-11 Thread Philippe Ombredanne
Aleksey, On Mon, Dec 11, 2017 at 3:14 PM, Aleksey Makarov wrote: > This series adds support for IEEE 1588 Precision Time Protocol > to Cavium ethernet driver. > > The first patch adds support for the Precision Time Protocol Clocks and > Timestamping coprocessor (PTP)

Re: [PATCH] rtnetlink: fix typo in GSO max segments

2017-12-11 Thread David Miller
From: Stephen Hemminger Date: Fri, 8 Dec 2017 15:34:13 -0800 > Fixes: 46e6b992c250 ("rtnetlink: allow GSO maximums to be set on device > creation") > Signed-off-by: Stephen Hemminger Applied, thanks you.

Re: [PATCH net-next v3 0/2] bpf/tracing: allow user space to query prog array on the same tp

2017-12-11 Thread Daniel Borkmann
Hey Yonghong, On 12/06/2017 11:07 PM, Yonghong Song wrote: > Commit e87c6bc3852b ("bpf: permit multiple bpf attachments > for a single perf event") added support to attach multiple > bpf programs to a single perf event. Given a perf event > (kprobe, uprobe, or kernel tracepoint), the perf ioctl

[PATCH net-next 0/2] net: tap: two minor issue

2017-12-11 Thread yuan linyu
From: yuan linyu patch1: replay while() loop with % operator in tap_get_queue() patch2: fix POLLOUT condition in tap_poll() --- yuan linyu (2): net: tap: replay while() loop with % operator in tap_get_queue() net: tap: fix POLLOUT condition in tap_poll()

76f43b4 fix for stable

2017-12-11 Thread Richard Schütz
Hello, as per netdev-FAQ.txt I'm requesting the submission of commit 57629915d568c522ac1422df7bba4bee5b5c7a7c ("mac80211: Fix addition of mesh configuration element") to stable. Because of automatic selection commit 76f43b4c0a9337af22827d78de4f2b8fd5328489 ("mac80211: Remove invalid flag

[RFC PATCH 1/9] netlink: introduce nla_put_bitfield32()

2017-12-11 Thread Michal Kubecek
Similar to other data types, this helper puts NLA_BITFIELD32 attribute into a netlink message. It takes separate value and selector arguments, if you already have struct nla_bitfield32, you can use nla_put(). Signed-off-by: Michal Kubecek --- include/net/netlink.h | 15

[RFC PATCH 3/9] ethtool: helper functions for netlink interface

2017-12-11 Thread Michal Kubecek
Misc helpers used by ethtool netlink code. Signed-off-by: Michal Kubecek --- net/core/ethtool_netlink.c | 177 + 1 file changed, 177 insertions(+) diff --git a/net/core/ethtool_netlink.c b/net/core/ethtool_netlink.c index

[PATCH net-next v5 0/2] net: thunderx: add support for PTP clock

2017-12-11 Thread Aleksey Makarov
This series adds support for IEEE 1588 Precision Time Protocol to Cavium ethernet driver. The first patch adds support for the Precision Time Protocol Clocks and Timestamping coprocessor (PTP) found on Cavium processors. It registers a new PTP clock in the PTP core and provides functions to use

Re: Waiting for the PHY to complete auto-negotiation

2017-12-11 Thread Måns Rullgård
Mason writes: > + Mans > > On 09/12/2017 19:49, Florian Fainelli wrote: > >> Having any HW state machine requiring X number of clock cycles to >> guarantee a full transition to a stopped state is not unusual, however, >> the fact that you need to send 5 packets to guarantee an

Re: Waiting for the PHY to complete auto-negotiation

2017-12-11 Thread Mason
On 11/12/2017 15:36, Måns Rullgård wrote: > Mason writes: > >> I suppose I should test forcefully setting the enable bit to 0 in >> the driver, and see if hell breaks loose. > > You can't. When the enable bit is 1, writes to that register are > ignored. It goes back to 0 automatically when

[RFC PATCH 7/9] ethtool: implement SET_SETTINGS message

2017-12-11 Thread Michal Kubecek
Sets the information provided by ETHTOOL_SLINKSETTINGS, ETHTOOL_SWOL and ETHTOOL_SMSGLVL. Unlike with ioctl(), userspace can send only some attributes so that we only need to call ethtool_ops callbacks which we really need (and the "set" callback is only called when we actually changed some

[RFC PATCH 8/9] ethtool: implement GET_PARAMS message

2017-12-11 Thread Michal Kubecek
Requests the information provide by ETHTOOL_GCOALESCE, ETHTOOL_GRINGPARAM, ETHTOOL_GPAUSEPARAM, ETHTOOL_GCHANNELS, ETHTOOL_GEEE and ETHTOOL_GFECPARAM. Flags in info_mask allow selecting only some (or on) of these categories. Signed-off-by: Michal Kubecek ---

Re: [PATCH] Revert "ravb: add workaround for clock when resuming with WoL enabled"

2017-12-11 Thread Niklas Söderlund
Hi Geert, Thanks for your patch. Feels good to get rid of this hack :-) On 2017-12-11 09:54:09 +0100, Geert Uytterhoeven wrote: > This reverts commit fbf3d034f2ff6264183cfa6845770e8cc2a986c8. > > As of commit 560869100b99a3da ("clk: renesas: cpg-mssr: Restore module > clocks during resume"),

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread David Miller
From: Kunihiko Hayashi Date: Mon, 11 Dec 2017 16:57:29 +0900 > +static inline u32 ave_desc_read(struct net_device *ndev, enum desc_id id, > + int entry, int offset) Do not use inline functions in foo.c files, let the compiler decide

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread Russell King - ARM Linux
On Mon, Dec 11, 2017 at 10:34:17PM +0900, Masami Hiramatsu wrote: > IMHO, even if we use SPDX license identifier, I recommend to use > C-style comments as many other files do, since it is C code. > If SPDX identifier requires C++ style, that is SPDX parser's issue > and should be fixed to get it

[RFC PATCH 6/9] ethtool: implement GET_SETTINGS message

2017-12-11 Thread Michal Kubecek
Requests the information provided by ETHTOOL_GLINKSETTINGS, ETHTOOL_GWOL and ETHTOOL_GMSGLVL. The info_mask header field can be used to request only part of the information. Flag ETH_SETTINGS_RF_COMPACT_BITSETS switches between flag-by-flag list and compact bitmaps for link modes in the reply.

[RFC PATCH 4/9] ethtool: netlink bitset handling

2017-12-11 Thread Michal Kubecek
Declare attribute type constants and add helper functions to handle arbitrary length bit sets. Signed-off-by: Michal Kubecek --- Documentation/networking/ethtool-netlink.txt | 56 + include/uapi/linux/ethtool_netlink.h | 31 +++ net/core/ethtool_netlink.c

[RFC PATCH 9/9] ethtool: implement SET_PARAMS message

2017-12-11 Thread Michal Kubecek
Sets the information provided by ETHTOOL_SCOALESCE, ETHTOOL_SRINGPARAM, ETHTOOL_SPAUSEPARAM, ETHTOOL_SCHANNELS, ETHTOOL_SEEE and ETHTOOL_SFECPARAM. Each of these has corresponding nesting attribute containing attributes for its settings. This way, userspace can request changes equivalent to one or

[PATCH net-next v5 3/4] net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag

2017-12-11 Thread Richard Leitner
From: Richard Leitner The Microchip/SMSC LAN8710/LAN8720 PHYs need (according to their datasheet [1]) a continuous REF_CLK when configured to "REF_CLK In Mode". Therefore set the PHY_RST_AFTER_CLK_EN flag for those PHYs to let the ETH driver reset them after the

[PATCH net-next v5 1/4] phylib: Add device reset delay support

2017-12-11 Thread Richard Leitner
From: Richard Leitner Some PHYs need a minimum time after the reset gpio was asserted and/or deasserted. To ensure we meet these timing requirements add two new optional devicetree parameters for the phy: reset-delay-us and reset-post-delay-us. Signed-off-by:

[PATCH net v2 2/9] net: aquantia: Fix hardware DMA stream overload on large MRRS

2017-12-11 Thread Igor Russkikh
Systems with large MRRS on device (2K, 4K) with high data rates and/or large MTU, atlantic observes DMA packet buffer overflow. On some systems that causes PCIe transaction errors, hardware NMIs or datapath freeze. This patch 1) Limits MRRS from device side to 2K (thats maximum our hardware

[PATCH net v2 4/9] net: aquantia: Fill ndev stat couters from hardware

2017-12-11 Thread Igor Russkikh
Originally they were filled from ring sw counters. These sometimes incorrectly calculate byte and packet amounts when using LRO/LSO and jumboframes. Filling ndev counters from hardware makes them precise. Signed-off-by: Igor Russkikh ---

[PATCH net v2 0/9] net: aquantia: Atlantic driver 12/2017 updates

2017-12-11 Thread Igor Russkikh
The patchset contains important hardware fix for machines with large MRRS and couple of improvement in stats and capabilities reporting patch v2: - split into more detailed commits Comment from David on wrong defines case will be submitted separately later Igor Russkikh (9): net: aquantia:

Re: [PATCH net] sctp: make sure stream nums can match optlen in sctp_setsockopt_reset_streams

2017-12-11 Thread Neil Horman
On Sun, Dec 10, 2017 at 03:40:51PM +0800, Xin Long wrote: > Now in sctp_setsockopt_reset_streams, it only does the check > optlen < sizeof(*params) for optlen. But it's not enough, as > params->srs_number_streams should also match optlen. > > If the streams in params->srs_stream_list are less

Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static

2017-12-11 Thread Florian Westphal
Colin King wrote: > From: Colin Ian King > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > not need to be in global scope, so make it static. This bug was added in commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread Philippe Ombredanne
Dear Kunihiko-san, On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi wrote: > The UniPhier platform from Socionext provides the AVE ethernet > controller that includes MAC and MDIO bus supporting RGMII/RMII > modes. The controller is named AVE. > > Signed-off-by:

Re: [PATCH v2 net-next 0/5] rhashtable: New features in walk and bucket

2017-12-11 Thread Herbert Xu
On Tue, Dec 05, 2017 at 02:47:58PM -0500, David Miller wrote: > > I'll allow Herbert time to think about this some more as he requested > in comments against the first version of this series. Sorry for the late response. Tom's changes look good to me. We should also fix up all existing

[PATCH net-next v5 2/4] phylib: add reset after clk enable support

2017-12-11 Thread Richard Leitner
From: Richard Leitner Some PHYs need the refclk to be a continuous clock. Therefore they don't allow turning it off and on again during operation. Nonetheless such a clock switching is performed by some ETH drivers (namely FEC [1]) for power saving reasons. An

[PATCH net v2 9/9] net: aquantia: Increment driver version

2017-12-11 Thread Igor Russkikh
Add a suffix to distinguish kernel mainline version and aquantia releases Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 3 ++- drivers/net/ethernet/aquantia/atlantic/ver.h| 6 -- 2 files changed, 6 insertions(+), 3

[PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20

2017-12-11 Thread Richard Leitner
From: Richard Leitner This patch series fixes the use of the SMSC LAN8710/20 with a Freescale ETH when the refclk is generated by the FSL. This patchset depends on the "phylib: Add device reset GPIO support" patch submitted by Geert Uytterhoeven/Sergei Shtylyov,

[PATCH] wlcore: fix unused function warning

2017-12-11 Thread Arnd Bergmann
The newly added wlcore_fw_sleep function is called conditionally, which causes a warning without CONFIG_PM: drivers/net/wireless/ti/wlcore/main.c:981:12: error: 'wlcore_fw_sleep' defined but not used [-Werror=unused-function] Instead of trying to keep track of what should be in the #ifdef and

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread Kunihiko Hayashi
On Mon, 11 Dec 2017 10:19:15 +0100 Phlippe Ombredanne wrote: > Dear Kunihiko-san, > > On Mon, Dec 11, 2017 at 8:57 AM, Kunihiko Hayashi > wrote: > > The UniPhier platform from Socionext provides the AVE ethernet > > controller that

Re: [PATCH net-next] net: thunderx: Add support for xdp redirect

2017-12-11 Thread Jesper Dangaard Brouer
On Fri, 24 Nov 2017 15:03:26 +0300 Aleksey Makarov wrote: > From: Sunil Goutham > > This patch adds support for XDP_REDIRECT. Flush is not > yet supported. > > Signed-off-by: Sunil Goutham > Signed-off-by: cjacob

Re: [PATCH net-next v3 1/2] bpf/tracing: allow user space to query prog array on the same tp

2017-12-11 Thread Peter Zijlstra
On Wed, Dec 06, 2017 at 02:07:45PM -0800, Yonghong Song wrote: > Commit e87c6bc3852b ("bpf: permit multiple bpf attachments > for a single perf event") added support to attach multiple > bpf programs to a single perf event. > Although this provides flexibility, users may want to know > what other

[PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-11 Thread Michael Chan
Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when NETIF_F_GRO_HW is set. Disable NETIF_F_GRO_HW in bnx2x_fix_features() if the MTU does not support TPA_MODE_GRO or GRO is not set. bnx2x_change_mtu() also needs to disable NETIF_F_GRO_HW if the MTU does not support it. Cc: Ariel Elior

[PATCH net-next v4 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-11 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware GRO. With this flag, we can now independently turn on or off hardware GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to control hardware GRO and so it cannot be independently turned on or off without affecting

[PATCH net-next v4 3/5] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-11 Thread Michael Chan
Advertise NETIF_F_GRO_HW in hw_features if hardware GRO is supported. In bnxt_fix_features(), disable GRO_HW and LRO if current hardware configuration does not allow it. GRO_HW depends on GRO. GRO_HW is also mutually exclusive with LRO. XDP setup will now rely on bnxt_fix_features() to turn off

[PATCH net-next v4 5/5] qede: Use NETIF_F_GRO_HW.

2017-12-11 Thread Michael Chan
Advertise NETIF_F_GRO_HW and set edev->gro_disable according to the feature flag. Add qede_fix_features() to drop NETIF_F_GRO_HW if XDP is running or MTU does not support GRO_HW or GRO is not set. qede_change_mtu() also checks and disables GRO_HW if MTU is not supported. Cc: Ariel Elior

[PATCH net-next v4 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

2017-12-11 Thread Michael Chan
Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan --- net/core/dev.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PATCH net-next v4 0/5] Introduce NETIF_F_GRO_HW

2017-12-11 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag and convert drivers that support hardware GRO to use the new flag. v4: - more changes requested by Alexander Duyck: - check GRO_HW/GRO dependency in drivers's ndo_fix_features(). - Reverse the order of RXCSUM and GRO_HW dependency check in

Re: [PATCH v1] Bluetooth: Utilize %*ph specifier

2017-12-11 Thread Marcel Holtmann
Hi Andy, > Instead of open coding byte-by-byte printing, re-use %*ph specifier. > > Signed-off-by: Andy Shevchenko > --- > net/bluetooth/hci_debugfs.c | 17 +++-- > 1 file changed, 3 insertions(+), 14 deletions(-) patch has been applied to

Re: [PATCH v3 32/33] irqchip: Andestech Internal Vector Interrupt Controller driver

2017-12-11 Thread Marc Zyngier
On 08/12/17 09:12, Greentime Hu wrote: > From: Greentime Hu > > This patch adds the Andestech Internal Vector Interrupt Controller > driver. You can find the spec here. Ch4.9 of AndeStar SPA V3 Manual. > http://www.andestech.com/product.php?cls=9 > > Signed-off-by: Rick

pull-request: mac80211 2017-12-11

2017-12-11 Thread Johannes Berg
Hi Dave, Three fixes, two related to build issues with the new regdb stuff, and one for some patch overlap problem that caused locking to be missing which in turn caused lots of warnings. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-11 Thread Daniel Borkmann
Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] On 12/11/2017 09:32 AM, Richard Weinberger wrote: > Randy, > > Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>> Another week, another rc. >> >> um (uml) won't build on

[PATCH] Revert "ravb: add workaround for clock when resuming with WoL enabled"

2017-12-11 Thread Geert Uytterhoeven
This reverts commit fbf3d034f2ff6264183cfa6845770e8cc2a986c8. As of commit 560869100b99a3da ("clk: renesas: cpg-mssr: Restore module clocks during resume"), the workaround is no longer needed. Signed-off-by: Geert Uytterhoeven ---

[PATCH v1] Bluetooth: Utilize %*ph specifier

2017-12-11 Thread Andy Shevchenko
Instead of open coding byte-by-byte printing, re-use %*ph specifier. Signed-off-by: Andy Shevchenko --- net/bluetooth/hci_debugfs.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/net/bluetooth/hci_debugfs.c

Re: [PATCH v2 net-next 1/5] rhashtable: Change rhashtable_walk_start to return void

2017-12-11 Thread Herbert Xu
On Mon, Dec 04, 2017 at 10:31:41AM -0800, Tom Herbert wrote: > Most callers of rhashtable_walk_start don't care about a resize event > which is indicated by a return value of -EAGAIN. So calls to > rhashtable_walk_start are wrapped wih code to ignore -EAGAIN. Something > like this is common: > >

Re: [PATCH v2 net-next 2/5] rhashtable: Add rhastable_walk_peek

2017-12-11 Thread Herbert Xu
On Mon, Dec 04, 2017 at 10:31:42AM -0800, Tom Herbert wrote: > This function is like rhashtable_walk_next except that it only returns > the current element in the inter and does not advance the iter. > > This patch also creates __rhashtable_walk_find_next. It finds the next > element in the table

[PATCH net] ipv4: igmp: guard against silly MTU values

2017-12-11 Thread Eric Dumazet
From: Eric Dumazet IPv4 stack reacts to changes to small MTU, by disabling itself under RTNL. But there is a window where threads not using RTNL can see a wrong device mtu. This can lead to surprises, in igmp code where it is assumed the mtu is suitable. Fix this by

Re: [PATCH net v2 5/9] net: aquantia: Fill in multicast counter in ndev stats from hardware

2017-12-11 Thread Andrew Lunn
On Mon, Dec 11, 2017 at 03:16:22PM +0300, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh A one link comment for the change log would be good. Otherwise, Reviewed-by: Andrew Lunn Andrew

RE: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF driver

2017-12-11 Thread Salil Mehta
Hi Philippe, > -Original Message- > From: Philippe Ombredanne [mailto:pombreda...@nexb.com] > Sent: Saturday, December 09, 2017 12:17 AM > To: Salil Mehta > Cc: David S. Miller ; Zhuangyuzeng (Yisen) > ; lipeng (Y)

Re: [PATCH next] ipvlan: add L2 check for packets arriving via virtual devices

2017-12-11 Thread David Miller
From: Mahesh Bandewar Date: Thu, 7 Dec 2017 15:15:43 -0800 > From: Mahesh Bandewar > > Packets that don't have dest mac as the mac of the master device should > not be entertained by the IPvlan rx-handler. This is mostly true as the > packet path

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

2017-12-11 Thread Jiri Pirko
Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >Request the same information as ETHTOOL_GDRVINFO. This is read-only so that >corresponding SET_DRVINFO exists but is only used in kernel replies. Rip >the code to query the driver out of the legacy interface and move it to >a new file

[PATCH v9 0/5] Add the ability to do BPF directed error injection

2017-12-11 Thread Josef Bacik
This is the same as v8, just rebased onto the bpf tree. v8->v9: - rebased onto the bpf tree. v7->v8: - removed the _ASM_KPROBE_ERROR_INJECT since it was not needed. v6->v7: - moved the opt-in macro to bpf.h out of kprobes.h. v5->v6: - add BPF_ALLOW_ERROR_INJECTION() tagging for functions that

[PATCH v9 5/5] btrfs: allow us to inject errors at io_ctl_init

2017-12-11 Thread Josef Bacik
From: Josef Bacik This was instrumental in reproducing a space cache bug. Signed-off-by: Josef Bacik Acked-by: Ingo Molnar --- fs/btrfs/free-space-cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/free-space-cache.c

Re: [PATCH v2 net-next 0/5] rhashtable: New features in walk and bucket

2017-12-11 Thread David Miller
From: Herbert Xu Date: Mon, 11 Dec 2017 23:03:24 +1100 > On Tue, Dec 05, 2017 at 02:47:58PM -0500, David Miller wrote: >> >> I'll allow Herbert time to think about this some more as he requested >> in comments against the first version of this series. > > Sorry for

[PATCH] iptables: ip6t_MASQUERADE: add dependency on conntrack module

2017-12-11 Thread Konstantin Khlebnikov
After commit 4d3a57f23dec ("netfilter: conntrack: do not enable connection tracking unless needed") conntrack is disabled by default unless some module explicitly declares dependency in particular network namespace. Signed-off-by: Konstantin Khlebnikov Fixes:

Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics names

2017-12-11 Thread Andrew Lunn
On Mon, Dec 11, 2017 at 03:16:25PM +0300, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > --- > drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git

Re: [PATCH net v2 0/9] net: aquantia: Atlantic driver 12/2017 updates

2017-12-11 Thread Andrew Lunn
On Mon, Dec 11, 2017 at 03:16:17PM +0300, Igor Russkikh wrote: > The patchset contains important hardware fix for machines with large MRRS > and couple of improvement in stats and capabilities reporting > > patch v2: > - split into more detailed commits Hi Igor Thanks for breaking up the

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-12-11 Thread Andreas Hartmann
On 12/08/2017 at 09:44 PM Andreas Hartmann wrote: > On 12/08/2017 at 09:11 PM Andreas Hartmann wrote: >> On 12/08/2017 at 05:04 PM Willem de Bruijn wrote: >>> On Fri, Dec 8, 2017 at 6:40 AM, Michal Kubecek wrote: On Fri, Dec 08, 2017 at 11:31:50AM +0100, Andreas Hartmann

Re: [RFC PATCH 2/9] ethtool: introduce ethtool netlink interface

2017-12-11 Thread Jiri Pirko
Mon, Dec 11, 2017 at 02:53:31PM CET, mkube...@suse.cz wrote: >No function implemented yet, only genetlink and module infrastructure. >Register/unregister genetlink family "ethtool" and allow the module to be >autoloaded by genetlink code (if built as a module, distributions would >probably prefer

Re: [PATCH V2] netlink: Add netns check on taps

2017-12-11 Thread Michal Kubecek
On Wed, Dec 06, 2017 at 03:57:14PM -0500, David Miller wrote: > From: Kevin Cernekee > Date: Wed, 6 Dec 2017 12:12:27 -0800 > > > Currently, a nlmon link inside a child namespace can observe systemwide > > netlink activity. Filter the traffic so that nlmon can only sniff

Re: [PATCH net v3] net: phy: meson-gxl: detect LPA corruption

2017-12-11 Thread David Miller
From: Jerome Brunet Date: Fri, 8 Dec 2017 12:08:11 +0100 > I suppose this patch probably seems a bit hacky, especially the part > about the link partner acknowledge. I'm trying to figure out if the > value in MII_LPA makes sense but I don't have such a deep knowledge > of

Re: [PATCHv2 net-next 00/12] sctp: Implement Stream Interleave: The I-DATA Chunk Supporting User Message Interleaving

2017-12-11 Thread David Miller
From: Xin Long Date: Fri, 8 Dec 2017 21:03:57 +0800 > Stream Interleave would be Implemented in two Parts: > >1. The I-DATA Chunk Supporting User Message Interleaving >2. Interaction with Other SCTP Extensions ... > As the 1st part of Stream Interleave

Re: [PATCH] dt-bindings: fec: Make the phy-reset-gpio polarity explicit

2017-12-11 Thread David Miller
From: Fabio Estevam Date: Fri, 8 Dec 2017 12:11:33 -0200 > From: Fabio Estevam > > The GPIO polarity passed to phy-reset-gpio is ignored by the FEC > driver and it is assumed to be active low. > > It can be active high only when the

Re: RFC(v2): Audit Kernel Container IDs

2017-12-11 Thread Richard Guy Briggs
On 2017-12-09 11:20, Mickaël Salaün wrote: > > On 12/10/2017 18:33, Casey Schaufler wrote: > > On 10/12/2017 7:14 AM, Richard Guy Briggs wrote: > >> Containers are a userspace concept. The kernel knows nothing of them. > >> > >> The Linux audit system needs a way to be able to track the

Re: [PATCH net] sctp: make sure stream nums can match optlen in sctp_setsockopt_reset_streams

2017-12-11 Thread Marcelo Ricardo Leitner
Hi, On Mon, Dec 11, 2017 at 09:54:34AM -0500, Neil Horman wrote: > On Sun, Dec 10, 2017 at 03:40:51PM +0800, Xin Long wrote: > > Now in sctp_setsockopt_reset_streams, it only does the check > > optlen < sizeof(*params) for optlen. But it's not enough, as > > params->srs_number_streams should also

Re: [PATCH] iptables: ip6t_MASQUERADE: add dependency on conntrack module

2017-12-11 Thread Pablo Neira Ayuso
On Mon, Dec 11, 2017 at 06:19:33PM +0300, Konstantin Khlebnikov wrote: > After commit 4d3a57f23dec ("netfilter: conntrack: do not enable connection > tracking unless needed") conntrack is disabled by default unless some > module explicitly declares dependency in particular network namespace.

Re: [PATCH net v2 4/9] net: aquantia: Fill ndev stat couters from hardware

2017-12-11 Thread Andrew Lunn
On Mon, Dec 11, 2017 at 03:16:21PM +0300, Igor Russkikh wrote: > Originally they were filled from ring sw counters. > These sometimes incorrectly calculate byte and packet amounts > when using LRO/LSO and jumboframes. Filling ndev counters from > hardware makes them precise. > > Signed-off-by:

Re: RFC(v2): Audit Kernel Container IDs

2017-12-11 Thread Eric Paris
On Sat, 2017-12-09 at 10:28 -0800, Casey Schaufler wrote: > On 12/9/2017 2:20 AM, Micka�l Sala�n wrote: > > What about automatically create > > and assign an ID to a process when it enters a namespace different > > than > > one of its parent process? This delegates the (permission) > >

[PATCH v9 3/5] bpf: add a bpf_override_function helper

2017-12-11 Thread Josef Bacik
From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Accomplish this with the

Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics names

2017-12-11 Thread David Miller
From: Andrew Lunn Date: Mon, 11 Dec 2017 16:45:06 +0100 > I know it is not nice, but maybe we need to consider this is part of > the kernel ABI? You could be breaking applications by making this > change. > > What do others think? Not really. The whole reason we have a string

Re: Waiting for the PHY to complete auto-negotiation

2017-12-11 Thread Måns Rullgård
Mason writes: > On 11/12/2017 15:36, Måns Rullgård wrote: > >> Mason writes: >> >>> I suppose I should test forcefully setting the enable bit to 0 in >>> the driver, and see if hell breaks loose. >> >> You can't. When the enable bit is 1, writes to that register are >>

Re: [RFC PATCH 0/9] ethtool netlink interface (WiP)

2017-12-11 Thread Jiri Pirko
Mon, Dec 11, 2017 at 02:53:11PM CET, mkube...@suse.cz wrote: >This is still work in progress and only a very small part of the ioctl >interface is reimplemented but I would like to get some comments before >the patchset becomes too big and changing things becomes too tedious. > >The interface used

[PATCH 27/45] net: remove duplicate includes

2017-12-11 Thread Pravin Shedge
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge --- net/core/netprio_cgroup.c| 1 - net/dsa/slave.c | 1 -

[PATCH net] ipv6: mcast: better catch silly mtu values

2017-12-11 Thread Eric Dumazet
From: Eric Dumazet syzkaller reported crashes in IPv6 stack [1] Xin Long found that lo MTU was set to silly values. IPv6 stack reacts to changes to small MTU, by disabling itself under RTNL. But there is a window where threads not using RTNL can see a wrong device mtu.

[RFC][PATCH] new byteorder primitives - ..._{replace,get}_bits()

2017-12-11 Thread Al Viro
A lot of drivers are open-coding the "replace these bits in __be32 with the following value" kind of primitives. Let's add them to byteorder.h. Primitives: {be,le}{16,32,64}_replace_bits(old, v, bit, nbits) {be,le}{16,32,64}_get_bits(val, bit, nbits) Essentially, it gives

[PATCH v9 4/5] samples/bpf: add a test for bpf_override_return

2017-12-11 Thread Josef Bacik
From: Josef Bacik This adds a basic test for bpf_override_return to verify it works. We override the main function for mounting a btrfs fs so it'll return -ENOMEM and then make sure that trying to mount a btrfs fs will fail. Acked-by: Alexei Starovoitov

[PATCH v9 1/5] add infrastructure for tagging functions as error injectable

2017-12-11 Thread Josef Bacik
From: Josef Bacik Using BPF we can override kprob'ed functions and return arbitrary values. Obviously this can be a bit unsafe, so make this feature opt-in for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in order to give BPF access to that function for error

[PATCH v9 2/5] btrfs: make open_ctree error injectable

2017-12-11 Thread Josef Bacik
From: Josef Bacik This allows us to do error injection with BPF for open_ctree. Signed-off-by: Josef Bacik Acked-by: Ingo Molnar --- fs/btrfs/disk-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/disk-io.c

[PATCH net-next 2/2] hv_netvsc: Fix the TX/RX buffer default sizes

2017-12-11 Thread Stephen Hemminger
From: Haiyang Zhang The values were not computed correctly. There are no significant visible impact, though. The intended size of RX buffer is 16 MB, and the default slot size is 1728. So, NETVSC_DEFAULT_RX should be 16*1024*1024 / 1728 = 9709. The intended size of TX

Re: [PATCH net-next 1/2] net: tap: replay while() loop with % operator in tap_get_queue()

2017-12-11 Thread Stephen Hemminger
On Mon, 11 Dec 2017 21:26:41 +0800 yuan linyu wrote: > From: yuan linyu > > Signed-off-by: yuan linyu > --- > drivers/net/tap.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git

  1   2   3   >