Re: [PATCH RESEND 1/3] net: Fix possible race in peernet2id_alloc()

On 29.12.2017 21:18, Eric W. Biederman wrote: > Kirill Tkhai writes: > >> peernet2id_alloc() is racy without rtnl_lock() as atomic_read(>count) >> under net->nsid_lock does not guarantee, peer is alive: >> >> rcu_read_lock() >> peernet2id_alloc()

Re: [PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post

On 12/30/2017 05:08 AM, Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai checkpatch.pl reports the following

Re: [PATCH] sky2: Replace mdelay with msleep in sky2_vpd_wait

On Sat, 30 Dec 2017 19:09:47 +0800 Jia-Ju Bai wrote: > sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai > --- >

[PATCH V4 3/4] sctp: Add LSM hooks

Add security hooks to allow security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c

[PATCH V4 0/4] Add SELinux SCTP protocol support

Note: Some conflicts are expected when merging with current net-next due to Interleaving Data (I-DATA) sets of patches: PATCH 2/4 - Where 'sctp_datachk_len(>stream)' has replaced 'sizeof(struct sctp_data_chunk)' in include/net/sctp/sctp.h, net/sctp/chunk.c and net/sctp/socket.c PATCH 3/4 - Where

[PATCH V4 4/4] selinux: Add SCTP support

The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.rst | 157 ++ security/selinux/hooks.c| 280

[PATCH V4 1/4] security: Add support for SCTP security hooks

The SCTP security hooks are explained in: Documentation/security/LSM-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.rst | 175 include/linux/lsm_hooks.h | 36

[PATCH V4 2/4] sctp: Add ip option support

Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/sctp.h| 4 +++- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 13 -

Re: [patch net-next v2 00/10] Add support for resource abstraction

> In my opinion it should not change. Unless there is a bug (like the one > DaveA found in mlxsw erif table). Existing tables and resources should > be only added. It is the driver's maintainer responsibility to not to > break user scripts. So we agree with is ABI. Great. Andrew

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

Hi Marcin, On Sat, Dec 30, 2017 at 05:34:23PM +0100, Marcin Wojtas wrote: > Yes, I already split the series and will send first one right away. I > will be followed by MDIO bus / PHY handling proposal, including the > bits related to phylink. I'm looking forward to your opinion on that > once

Re: [PATCH iproute2 v2 1/4] man: drop references to Debian-specific paths

On Sat, 30 Dec 2017 11:31:14 +0100 Luca Boccassi wrote: > Documentation should be distribution-agnostic - any specific quirks > should be handled by downstream maintainers, if necessary. > Remove mentions of Debian paths and package names. > > Signed-off-by: Luca Boccassi

Re: general protection fault in skb_segment

On Sat, Dec 30, 2017 at 7:54 PM, Willem de Bruijn wrote: >> So this is a packet socket writing something that apparently looks >> like an SCTP packet, is only 42 bytes long, but has GSO set in its >> virtio_net_hdr struct. >> >> It crashes in skb_segment seemingly

[PATCH] qed: Use zeroing memory allocator than allocator/memset

Use dma_zalloc_coherent and vzalloc for allocating zeroed memory and remove unnecessary memset function. Done using Coccinelle. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci 0-day tested with no failures. Suggested-by: Luis R. Rodriguez Signed-off-by:

[PATCH] ethernet/broadcom: Use zeroing memory allocator than allocator/memset

Use dma_zalloc_coherent for allocating zeroed memory and remove unnecessary memset function. Done using Coccinelle. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci 0-day tested with no failures. Suggested-by: Luis R. Rodriguez Signed-off-by: Himanshu Jha

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

From: Michael Chan Date: Fri, 29 Dec 2017 21:20:02 -0800 > I think the name GRO_HW is perfectly fine. It is GRO aggregation done > in hardware, and hardware providing extra information to the driver to > setup the SKB just like GRO. I don't know what better name to

[PATCH] brcmfmac: Use zeroing memory allocator than allocator/memset

Use dma_zalloc_coherent for allocating zeroed memory and remove unnecessary memset function. Done using Coccinelle. Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci 0-day tested with no failures. Suggested-by: Luis R. Rodriguez Signed-off-by: Himanshu Jha

Re: [PATCH net-next 7/7] net: phy: convert read-modify-write to phy_modify()

Hi, Unfortunately, I've found this afternoon that this patch causes a regression for Marvell PHYs connected in RGMII mode - so please do not apply this patch. The remainder of the series is fine. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

Hi Russell and Stefan, 2017-12-29 12:38 GMT+01:00 Russell King - ARM Linux : > On Fri, Dec 29, 2017 at 12:12:15PM +0100, Marcin Wojtas wrote: >> Hi Russell, >> >> I see that I misspelled your email address, hence the series remained >> unnoticed: >>

Re: general protection fault in skb_segment

> So this is a packet socket writing something that apparently looks > like an SCTP packet, is only 42 bytes long, but has GSO set in its > virtio_net_hdr struct. > > It crashes in skb_segment seemingly on a NULL list_skb. > > (gdb) list *(skb_segment+0x2a4) > 0x8167cc24 is in skb_segment

v4.15-rc5 warning: suspicious RCU usage in net/wireless/util.c:778

On Fri, Dec 22, 2017 at 08:20:12AM +0100, Dominik Brodowski wrote: > Dear all, > > once the (wifi) link becomes ready, the following warning is emitted on > mainline (v4.15-rc4-202-gead68f216110) on my notebook: ... and it is still present as of v4.15-rc5-149-g5aa90a845892 > [ 22.770422]

[PATCH] orinoco: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Sat, 30 Dec 2017 20:20:56 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] rds: fix use-after-free read in rds_find_bound

socket buffer can get freed as part of sock_close callback so before adding reference check underneath socket validity. Reported-by: syzbot+93a5839deb3555374...@syzkaller.appspotmail.com Signed-off-by: Santosh Shilimkar --- net/rds/bind.c | 2 +- 1 file changed, 1

Re: KASAN: use-after-free Read in rds_find_bound

On 12/30/17 1:17 AM, syzbot wrote: Hello, syzkaller hit the following crash on fba961ab29e5ffb055592442808bb0f7962e05da git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. Unfortunately,

[PATCH] wireless: airo: Delete an error message for a failed memory allocation in airo_networks_allocate()

From: Markus Elfring Date: Sat, 30 Dec 2017 20:48:44 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: iproute2 net-next

On 12/30/2017 05:00 AM, Stephen Hemminger wrote: > On Fri, 29 Dec 2017 09:58:23 +0100 > Jiri Pirko wrote: >> Fri, Dec 29, 2017 at 12:46:31AM CET, dan...@iogearbox.net wrote: >>> On 12/26/2017 10:35 AM, Leon Romanovsky wrote: On Mon, Dec 25, 2017 at 10:14:26PM -0800,

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On (12/30/17 11:36), Santosh Shilimkar wrote: > > socket buffer can get freed as part of sock_close > callback so before adding reference check underneath > socket validity. I'm not sure I understand this fix- struct rds_sock is: struct rds_sock { struct sock rs_sk;

[PATCH] wireless: b43: Delete an error message for a failed memory allocation in b43_sdio_probe()

From: Markus Elfring Date: Sat, 30 Dec 2017 21:23:47 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH bpf-next v4 1/3] libbpf: add function to setup XDP

Most of the code is taken from set_link_xdp_fd() in bpf_load.c and slightly modified to be library compliant. Signed-off-by: Eric Leblond Acked-by: Alexei Starovoitov --- tools/lib/bpf/bpf.c| 126 -

[PATCH bpf-next v4 3/3] libbpf: add missing SPDX-License-Identifier

Signed-off-by: Eric Leblond Acked-by: Alexei Starovoitov --- tools/lib/bpf/bpf.c| 2 ++ tools/lib/bpf/bpf.h| 2 ++ tools/lib/bpf/libbpf.c | 2 ++ tools/lib/bpf/libbpf.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/tools/lib/bpf/bpf.c

[PATCH bpf-next v4 0/3] libbpf: add function to setup XDP

Hello, This updated patchset address the remarks by Toshiaki Makita and Philippe Ombredanne: - fixes on errno handling - correct usage of SPDX header Best regards, -- Eric Leblond

[PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP

Parse netlink ext attribute to get the error message returned by the card. Code is partially take from libnl. Signed-off-by: Eric Leblond Acked-by: Alexei Starovoitov --- tools/lib/bpf/Build| 2 +- tools/lib/bpf/bpf.c| 10 ++- tools/lib/bpf/nlattr.c

Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

Hi Emiliano, On Sat, Dec 30, 2017 at 12:00 AM, Emiliano Ingrassia wrote: > Hi Jerome, Hi Martin, > > On Fri, Dec 29, 2017 at 07:04:23PM +0100, Jerome Brunet wrote: >> On Fri, 2017-12-29 at 02:31 +0100, Emiliano Ingrassia wrote: >> > Hi Martin, Hi Dave, >> > >> > On Thu,

[PATCH 2/2] at76c50x-usb: Improve size determinations in at76_usbdfu_download()

From: Markus Elfring Date: Sat, 30 Dec 2017 21:56:56 +0100 Replace the specification of two data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] at76c50x-usb: Delete an error message for a failed memory allocation in at76_submit_rx_urb()

From: Markus Elfring Date: Sat, 30 Dec 2017 21:50:12 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] at76c50x-usb: Adjustments for two function implementations

From: Markus Elfring Date: Sat, 30 Dec 2017 22:01:23 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in at76_submit_rx_urb() Improve size

Re: [patch net-next v2 00/10] Add support for resource abstraction

On 12/28/17 1:21 AM, Yuval Mintz wrote: > I think it goes the other way around. The dpipe tables are the ones that > can be translated to functionality; The resources are internal and HW-specific > representing the possible internal division of resources - > but a given resource sn't necessarily

Re: general protection fault in skb_segment

On Sat, Dec 30, 2017 at 08:42:41AM +0100, Willem de Bruijn wrote: > > syzkaller hit the following crash on > > 37759fa6d0fa9e4d6036d19ac12f555bfc0aeafd > > git://git.cmpxchg.org/linux-mmots.git/master > > compiler: gcc (GCC) 7.1.1 20170620 > > .config is attached > > Raw console output is

Re: general protection fault in skb_segment

On Sat, Dec 30, 2017 at 10:52:20PM -0200, Marcelo Ricardo Leitner wrote: > On Sat, Dec 30, 2017 at 08:42:41AM +0100, Willem de Bruijn wrote: [...] > > Somewhat tangential, but any PF_PACKET socket can set this > > magic gso_size value in its virtio_net_hdr, so if it is assumed to > > be an SCTP

Re: [PATCH v3 net-next 2/5] net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint

On Sun, Dec 31, 2017 at 6:33 AM, Brendan Gregg wrote: > On Tue, Dec 19, 2017 at 7:12 PM, Yafang Shao wrote: >> As sk_state is a common field for struct sock, so the state >> transition tracepoint should not be a TCP specific feature. >> Currently

Re: [PATCH net] ethtool: do not print warning for applications using legacy API

Signed-off-by: David Decotigny On Fri, Dec 29, 2017 at 10:02 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > In kernel log ths message appears on every boot: > "warning: `NetworkChangeNo' uses legacy

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On 12/30/17 2:32 PM, Sowmini Varadhan wrote: On (12/30/17 13:37), santosh.shilim...@oracle.com wrote: [...] Thats what I thought as well initially but since the reported case, the rs seems to be valid where as sk seems to be freed up as part of sock_release callback. I dont understand the

GREETINGS FROM MOHAMMED AHMED .

Hi Friend. I am Mr. Mohammed Ahmed a banker in Bank of Africa Burkina Faso West Africa, Please i want to transfer an abandoned sum of 13.5 millions USD to your account.50% will be for you and 50% for me. No risk involved. Contact me for more details along with your personal information needed

Re: [PATCH V4 3/4] sctp: Add LSM hooks

On Sat, Dec 30, 2017 at 05:20:13PM +, Richard Haines wrote: > Add security hooks to allow security modules to exercise access control > over SCTP. > > Signed-off-by: Richard Haines Acked-by: Marcelo Ricardo Leitner > --- >

Re: [PATCH V4 4/4] selinux: Add SCTP support

On Sat, Dec 30, 2017 at 05:20:35PM +, Richard Haines wrote: > The SELinux SCTP implementation is explained in: > Documentation/security/SELinux-sctp.rst > > Signed-off-by: Richard Haines Reviewed-by: Marcelo Ricardo Leitner

Re: [PATCH V4 2/4] sctp: Add ip option support

On Sat, Dec 30, 2017 at 05:19:50PM +, Richard Haines wrote: > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > and CALIPSO/IPv6 services. > > Signed-off-by: Richard Haines Acked-by: Marcelo Ricardo Leitner

Re: [PATCH V4 1/4] security: Add support for SCTP security hooks

On Sat, Dec 30, 2017 at 05:19:26PM +, Richard Haines wrote: > The SCTP security hooks are explained in: > Documentation/security/LSM-sctp.rst > > Signed-off-by: Richard Haines Reviewed-by: Marcelo Ricardo Leitner > --- >

[PATCH] wan/fsl_ucc_hdlc: Delete an error message for a failed memory allocation in ucc_hdlc_probe()

From: Markus Elfring Date: Sat, 30 Dec 2017 22:25:44 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On 12/30/17 12:26 PM, Sowmini Varadhan wrote: On (12/30/17 11:36), Santosh Shilimkar wrote: socket buffer can get freed as part of sock_close callback so before adding reference check underneath socket validity. I'm not sure I understand this fix- struct rds_sock is: struct rds_sock {

Re: [PATCH] rds: fix use-after-free read in rds_find_bound

On (12/30/17 13:37), santosh.shilim...@oracle.com wrote: > Well thats what the report says o.w flag test wouldn't have > been attempted. the bug report says "use-after-free". It doesnt say that rds_rs_to_sk(rs) is null (if rds_rs_to_sk(rs) was null, rs would also be null, please cscope struct

Re: [PATCH v3 net-next 2/5] net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint

On Tue, Dec 19, 2017 at 7:12 PM, Yafang Shao wrote: > As sk_state is a common field for struct sock, so the state > transition tracepoint should not be a TCP specific feature. > Currently it traces all AF_INET state transition, so I rename this > tracepoint to

Re: [PATCH] af_key: fix buffer overread in parse_exthdrs()

On Fri, Dec 29, 2017 at 06:15:23PM -0600, Eric Biggers wrote: > From: Eric Biggers > > If a message sent to a PF_KEY socket ended with an incomplete extension > header (fewer than 4 bytes remaining), then parse_exthdrs() read past > the end of the message, into uninitialized

Re: [PATCH] af_key: fix buffer overread in verify_address_len()

On Fri, Dec 29, 2017 at 06:13:05PM -0600, Eric Biggers wrote: > From: Eric Biggers > > If a message sent to a PF_KEY socket ended with one of the extensions > that takes a 'struct sadb_address' but there were not enough bytes > remaining in the message for the ->sa_family

Re: [PATCH ipsec] xfrm: skip policies marked as dead while rehashing

On Wed, Dec 27, 2017 at 11:25:45PM +0100, Florian Westphal wrote: > syzkaller triggered following KASAN splat: > > BUG: KASAN: slab-out-of-bounds in xfrm_hash_rebuild+0xdbe/0xf00 > net/xfrm/xfrm_policy.c:618 > read of size 2 at addr 8801c8e92fe4 by task kworker/1:1/23 [..] > Workqueue:

Re: xfrm: Forbid state updates from changing encap type

On Tue, Dec 26, 2017 at 05:34:44PM +1100, Herbert Xu wrote: > Currently we allow state updates to competely replace the contents > of x->encap. This is bad because on the user side ESP only sets up > header lengths depending on encap_type once when the state is first > created. This could result

Re: [PATCHv3 0/2] capability controlled user-namespaces

Hello Mahesh, On 12/28/2017 01:45 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Dec 27, 2017 at 12:23 PM, Michael Kerrisk (man-pages) > wrote: >> Hello Mahesh, >> >> On 27 December 2017 at 18:09, Mahesh Bandewar (महेश बंडेवार) >> wrote: >>>

Re: [PATCHv3 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

Hello Mahesh, On 12/05/2017 11:31 PM, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Add a sysctl variable kernel.controlled_userns_caps_whitelist. This > takes input as capability mask expressed as two comma separated hex > u32 words. The mask, however, is stored in

Re: [patch net-next v2 00/10] Add support for resource abstraction

Sat, Dec 30, 2017 at 11:18:50AM CET, and...@lunn.ch wrote: >> 1. Both dpipe and devlink resource are abstraction models for >> hardware entities, and as a result they true to provide generic objects. >> Each driver/ASIC should register his own and it absolutely proprietary >> implementation. There

Re: [PATCH iproute2 3/4] man: ip-address: document 15-char limit for LABEL

On Fri, 2017-12-29 at 20:04 -0800, Stephen Hemminger wrote: > On Fri, 29 Dec 2017 23:01:24 +0100 > Luca Boccassi wrote: > > > Trying to set a label longer than 15 characters returns an error: > >  RTNETLINK answers: Numerical result out of range > > > > Document the limit in

Re: [PATCH iproute2 2/4] man: add more keywords to ip.8 short description

On Fri, 2017-12-29 at 20:02 -0800, Stephen Hemminger wrote: > On Fri, 29 Dec 2017 23:01:23 +0100 > Luca Boccassi wrote: > > > A Debian user suggested adding more network-related keywords to the > > ip manpage, so that manpage-scraping and indexing software like > > apropos can

[PATCH iproute2 v2 1/4] man: drop references to Debian-specific paths

Documentation should be distribution-agnostic - any specific quirks should be handled by downstream maintainers, if necessary. Remove mentions of Debian paths and package names. Signed-off-by: Luca Boccassi --- man/man8/lnstat.8 | 3 +-- man/man8/ss.8 | 3 +-- 2 files

[PATCH iproute2 v2 3/4] man: ip-address: document 15-char limit for LABEL

Trying to set a label longer than 15 characters returns an error: RTNETLINK answers: Numerical result out of range Document the limit in the manpage. Originally reported as a Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661886 Reported-by: Gabor Kiss

[PATCH iproute2 v2 2/4] man: add more keywords to ip.8 short description

A Debian user suggested adding more network-related keywords to the ip manpage, so that manpage-scraping and indexing software like apropos can do a better job of categorizing the programs. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877983 Suggested-by: Lynoure Braakman

[PATCH iproute2 v2 4/4] man: routel/routef: don't mention filesystem paths

The filesytem paths to these scripts might be different on various distros, so don't mention it in the manpages. It is not really useful information anyway. Originally submitted as Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561424 Reported-by: jida...@jidanni.org

Re: [patch net-next v2 00/10] Add support for resource abstraction

> 1. Both dpipe and devlink resource are abstraction models for > hardware entities, and as a result they true to provide generic objects. > Each driver/ASIC should register his own and it absolutely proprietary > implementation. There is absolutely NO industry standard here, the only > thing that

[PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post

b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/broadcom/b43/phy_n.c |2 +- 1 file changed, 1

[PATCH] sky2: Replace mdelay with msleep in sky2_vpd_wait

sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/marvell/sky2.c |2 +- 1 file changed, 1 insertion(+), 1