Re: [PATCH] MAINTAINERS: Update my email address.

2018-01-04 Thread David Miller
From: Pravin B Shelar Date: Tue, 2 Jan 2018 20:14:42 -0800 > Signed-off-by: Pravin Shelar Applied, but please take Joe's feedback into consideration.

Re: bonding: Completion of error handling around bond_update_slave_arr()

2018-01-04 Thread महेश बंडेवार
On Thu, Jan 4, 2018 at 12:19 AM, SF Markus Elfring wrote: >> If you see 8 out of 9 call sites in this file ignore the return value. > > How do you think about to fix error detection and corresponding > exception handling then? > If I understand your question

Re: [PATCH bpf-next 1/2] bpf: implement syscall command BPF_MAP_GET_NEXT_KEY for stacktrace map

2018-01-04 Thread Yonghong Song
On 1/4/18 1:08 PM, Jakub Kicinski wrote: On Wed, 3 Jan 2018 23:27:45 -0800, Yonghong Song wrote: Currently, bpf syscall command BPF_MAP_GET_NEXT_KEY is not supported for stacktrace map. However, there are use cases where user space wants to enumerate all stacktrace map entries where

Re: [net-next 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

2018-01-04 Thread Stephen Hemminger
On Thu, 4 Jan 2018 15:21:30 -0500 Andy Gospodarek wrote: > +DYNAMIC INTERRUPT MODERATION > +M: Tal Gilboa > +S: Mainained s/Mainained/Maintained/

Re: [PATCH 6/8] net: caif: remove unused hardirq.h

2018-01-04 Thread Yang Shi
Hi David, I'm not sure if CAIF is still maintained by Dmitry Tarnyagin. Do you have any comment on this one? Thanks, Yang On 12/7/17 11:13 AM, Yang Shi wrote: Hi folks, Any comment on this one? Thanks, Yang On 11/17/17 3:02 PM, Yang Shi wrote: Preempt counter APIs have been split out,

[PATCH bpf-next v2 1/2] bpf: implement syscall command BPF_MAP_GET_NEXT_KEY for stacktrace map

2018-01-04 Thread Yonghong Song
Currently, bpf syscall command BPF_MAP_GET_NEXT_KEY is not supported for stacktrace map. However, there are use cases where user space wants to enumerate all stacktrace map entries where BPF_MAP_GET_NEXT_KEY command will be really helpful. In addition, if user space wants to delete all map entries

[PATCH bpf-next v2 2/2] tools/bpf: add a bpf selftest for stacktrace

2018-01-04 Thread Yonghong Song
Added a bpf selftest in test_progs at tools directory for stacktrace. The test will populate a hashtable map and a stacktrace map at the same time with the same key, stackid. The user space will compare both maps, using BPF_MAP_LOOKUP_ELEM command and BPF_MAP_GET_NEXT_KEY command, to ensure that

[PATCH bpf-next v2 0/2] bpf: implement syscall command BPF_MAP_GET_NEXT_KEY for stacktrace map

2018-01-04 Thread Yonghong Song
The patch set implements bpf syscall command BPF_MAP_GET_NEXT_KEY for stacktrace map. Patch #1 is the core implementation and Patch #2 implements a bpf test at tools/testing/selftests/bpf directory. Please see individual patch comments for details. Changelog: v1 -> v2: - For invalid key (key

[PATCH net-next] net: ipv6: Allow connect to linklocal address from socket bound to vrf

2018-01-04 Thread David Ahern
Allow a process bound to a VRF to connect to a linklocal address. Currently, this fails because of a mismatch between the scope of the linklocal address and the sk_bound_dev_if inherited by the VRF binding: $ ssh -6 fe80::70b8:cff:fedd:ead8%eth1 ssh: connect to host

Re: [net-next 00/10] net: create dynamic software irq moderation library

2018-01-04 Thread Andy Gospodarek
On Thu, Jan 04, 2018 at 10:37:37PM +0200, Or Gerlitz wrote: > > net/mlx5e: move interrupt moderation structs to new file > > net/mlx5e: move interrupt moderation forward declarations > > net/mlx5e: remove rq references in mlx5e_rx_am > > net/mlx5e: move AM logic enums > > net/mlx5e: move

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

2018-01-04 Thread Yang Shi
Hi David, Any more comment on this change? Thanks, Yang On 12/7/17 5:40 PM, Ying Xue wrote: On 11/18/2017 07:02 AM, Yang Shi wrote: Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by TIPC at all. So, remove the unused

Re: [PATCH net-next] net: sched: fix tcf_block_get_ext() in case CONFIG_NET_CLS is not set

2018-01-04 Thread Cong Wang
On Thu, Jan 4, 2018 at 1:59 AM, Quentin Monnet wrote: > Hi Cong, > > 2018-01-03 18:08 UTC-0800 ~ Cong Wang >> On Wed, Jan 3, 2018 at 5:30 PM, Jakub Kicinski >> wrote: >>> From: Quentin Monnet

[PATCH net-next] tcp: Split BUG_ON() in tcp_tso_should_defer() into two assertions

2018-01-04 Thread Stefano Brivio
The two conditions triggering BUG_ON() are somewhat unrelated: the tcp_skb_pcount() check is meant to catch TSO flaws, the second one checks sanity of congestion window bookkeeping. Split them into two separate BUG_ON() assertions on two lines, so that we know which one actually triggers, when

[PATCH net 1/2] bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc()

2018-01-04 Thread Michael Chan
From: Sunil Challa flow_type in HWRM_FLOW_ALLOC is not being populated correctly due to incorrect passing of pointer and size of l3_mask argument of is_wildcard(). Fixed this. Fixes: db1d36a27324 ("bnxt_en: add TC flower offload flow_alloc/free FW cmds")

Fw: [Bug 198353] New: Generic netlink family bug when multicast groups are greater than 13

2018-01-04 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 05 Jan 2018 00:21:42 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198353] New: Generic netlink family bug when multicast groups are greater than 13 https://bugzilla.kernel.org/show_bug.cgi?id=198353

Re: Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()"

2018-01-04 Thread Ivan Khoronzhuk
+ G.Strashko The below change also brokes phy connect for am572x.. int genphy_restart_aneg(struct phy_device *phydev) { - int ctl = phy_read(phydev, MII_BMCR); - - if (ctl < 0) - return ctl; - - ctl |= BMCR_ANENABLE | BMCR_ANRESTART; - /* Don't isolate

[PATCH bpf-next v4 07/11] bpf: Add support for reading sk_state and more

2018-01-04 Thread Lawrence Brakmo
Add support for reading many more tcp_sock fields state,same as sk->sk_state rtt_min same as sk->rtt_min.s[0].v (current rtt_min) snd_ssthresh rcv_nxt snd_nxt snd_una mss_cache ecn_flags rate_delivered rate_interval_us packets_out retrans_out total_retrans

[PATCH bpf-next v4 08/11] bpf: Add sock_ops R/W access to tclass & sk_txhash

2018-01-04 Thread Lawrence Brakmo
Adds direct R/W access to sk_txhash and access to tclass for ipv6 flows through getsockopt and setsockopt. Sample usage for tclass: bpf_getsockopt(skops, SOL_IPV6, IPV6_TCLASS, , sizeof(v)) where skops is a pointer to the ctx (struct bpf_sock_ops). Signed-off-by: Lawrence Brakmo

[PATCH bpf-next v4 04/11] bpf: Support passing args to sock_ops bpf function

2018-01-04 Thread Lawrence Brakmo
Adds support for passing up to 4 arguments to sock_ops bpf functions. It reusues the reply union, so the bpf_sock_ops structures are not increased in size. Signed-off-by: Lawrence Brakmo --- include/linux/filter.h | 1 + include/net/tcp.h| 64

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

2018-01-04 Thread Yang, Wenyou
On 2018/1/4 23:17, Faiz Abbas wrote: Hi, On Wednesday 03 January 2018 08:47 PM, Marc Kleine-Budde wrote: On 01/03/2018 04:06 PM, Faiz Abbas wrote: Hi, On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: On 01/03/2018 01:39 PM, Faiz Abbas wrote: On Tuesday 02 January 2018

Re: [net-next PATCH 1/2] bpf: sockmap remove unused function

2018-01-04 Thread Daniel Borkmann
On 01/04/2018 02:57 AM, John Fastabend wrote: > This was added for some work that was eventually factored out but the > helper call was missed. Remove it now and add it back later if needed. > > Signed-off-by: John Fastabend Both applied to bpf-next, thanks John!

Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

2018-01-04 Thread Subash Abhinov Kasiviswanathan
The real device over which the rmnet devices are installed also aggregate multiple IP packets and sends them as a single large aggregate frame to the hardware. It would be nice to give some details about this in the changelog. Also what results you get with different values for the shift

[PATCH bpf-next v4 11/11] bpf: add selftest for tcpbpf

2018-01-04 Thread Lawrence Brakmo
Added a selftest for tcpbpf (sock_ops) that checks that the appropriate callbacks occured and that it can access tcp_sock fields and that their values are correct. Run with command: ./test_tcpbpf_user Signed-off-by: Lawrence Brakmo --- tools/include/uapi/linux/bpf.h

[PATCH bpf-next v4 02/11] bpf: Make SOCK_OPS_GET_TCP struct independent

2018-01-04 Thread Lawrence Brakmo
Changed SOCK_OPS_GET_TCP to SOCK_OPS_GET_FIELD and added 2 arguments so now it can also work with struct sock fields. The first argument is the name of the field in the bpf_sock_ops struct, the 2nd argument is the name of the field in the OBJ struct. Previous: SOCK_OPS_GET_TCP(FIELD_NAME) New:

[PATCH bpf-next v4 09/11] bpf: Add BPF_SOCK_OPS_RETRANS_CB

2018-01-04 Thread Lawrence Brakmo
Adds support for calling sock_ops BPF program when there is a retransmission. Two arguments are used; one for the sequence number and other for the number of segments retransmitted. Does not include syn-ack retransmissions. New op: BPF_SOCK_OPS_RETRANS_CB. Signed-off-by: Lawrence Brakmo

[PATCH bpf-next v4 06/11] bpf: Add sock_ops RTO callback

2018-01-04 Thread Lawrence Brakmo
Adds an optional call to sock_ops BPF program based on whether the BPF_SOCK_OPS_RTO_CB_FLAG is set in bpf_sock_ops_flags. The BPF program is passed 2 arguments: icsk_retransmits and whether the RTO has expired. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 5 +

[PATCH bpf-next v4 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

2018-01-04 Thread Lawrence Brakmo
Adds support for calling sock_ops BPF program when there is a TCP state change. Two arguments are used; one for the old state and another for the new state. There is a new enum in include/uapi/linux/bpf.h that exports the TCP states that prepends BPF_ to the current TCP state names. If it is ever

[PATCH bpf-next v4 00/11] bpf: More sock_ops callbacks

2018-01-04 Thread Lawrence Brakmo
This patchset adds support for: - direct R or R/W access to many tcp_sock fields - passing up to 4 arguments to sock_ops BPF functions - tcp_sock field bpf_sock_ops_flags for controlling callbacks - optionally calling sock_ops BPF program when RTO fires - optionally calling sock_ops BPF program

[PATCH bpf-next v4 05/11] bpf: Adds field bpf_sock_ops_flags to tcp_sock

2018-01-04 Thread Lawrence Brakmo
Adds field bpf_sock_ops_flags to tcp_sock and bpf_sock_ops. Its primary use is to determine if there should be calls to sock_ops bpf program at various points in the TCP code. The field is initialized to zero, disabling the calls. A sock_ops BPF program can set, per connection and as necessary,

[PATCH bpf-next v4 03/11] bpf: Add write access to tcp_sock and sock fields

2018-01-04 Thread Lawrence Brakmo
This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to struct tcp_sock or struct sock fields. This required adding a new field "temp" to struct bpf_sock_ops_kern for temporary storage that is used by sock_ops_convert_ctx_access. It is used to store and recover the contents of a register, so

[PATCH bpf-next v4 01/11] bpf: Make SOCK_OPS_GET_TCP size independent

2018-01-04 Thread Lawrence Brakmo
Make SOCK_OPS_GET_TCP helper macro size independent (before only worked with 4-byte fields. Signed-off-by: Lawrence Brakmo --- net/core/filter.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index

Re: [RFC 11/14] tcp_md5: Move TCP-MD5 code out of TCP itself

2018-01-04 Thread Christoph Paasch
Hello Mat, On 02/01/18 - 11:39:23, Mat Martineau wrote: > > Hi Christoph - > > On Mon, 18 Dec 2017, Christoph Paasch wrote: > > > This is all just copy-pasting the TCP_MD5-code into functions that are > > placed in net/ipv4/tcp_md5.c. > > > > Signed-off-by: Christoph Paasch

Re: [net-next 09/10] bnxt_en: add support for software dynamic interrupt moderation

2018-01-04 Thread Michael Chan
On Thu, Jan 4, 2018 at 12:21 PM, Andy Gospodarek wrote: > From: Andy Gospodarek > > This implements the changes needed for the bnxt_en driver to add support > for dynamic interrupt moderation per ring. > > This does add additional counters in the receive

Re: [PATCH RESEND] bpf: fix bad include in libbpf when srctree is set

2018-01-04 Thread Daniel Borkmann
On 01/01/2018 01:36 PM, Alexander Alemayhu wrote: > The relative path can be wrong and prevents the build. You mean if you move the files from tools/lib/bpf/ to a different location, and then specify srctree var pointing to a kernel tree? I think this would also break various other assumptions

Re: [ovs-dev] [PATCH 7/8] net: ovs: remove unused hardirq.h

2018-01-04 Thread Yang Shi
Hi David, Any comment is appreciated. Thanks, Yang On 12/7/17 11:27 AM, Pravin Shelar wrote: On Fri, Nov 17, 2017 at 3:02 PM, Yang Shi wrote: Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by

[PATCH net 0/2] bnxt_en: 2 small bug fixes.

2018-01-04 Thread Michael Chan
The first one fixes the TC Flower flow parameter passed to firmware. The 2nd one fixes the VF index range checking for iproute2 SRIOV related commands. Sunil Challa (1): bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc() Venkat Duvvuru (1): bnxt_en: Fix the 'Invalid VF' id

[PATCH net 2/2] bnxt_en: Fix the 'Invalid VF' id check in bnxt_vf_ndo_prep routine.

2018-01-04 Thread Michael Chan
From: Venkat Duvvuru In bnxt_vf_ndo_prep (which is called by bnxt_get_vf_config ndo), there is a check for "Invalid VF id". Currently, the check is done against max_vfs. However, the user doesn't always create max_vfs. So, the check should be against the created

Re: Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()"

2018-01-04 Thread Russell King - ARM Linux
On Fri, Jan 05, 2018 at 02:44:07AM +0200, Ivan Khoronzhuk wrote: > + G.Strashko > The below change also brokes phy connect for am572x.. > > int genphy_restart_aneg(struct phy_device *phydev) > { > - int ctl = phy_read(phydev, MII_BMCR); > - > - if (ctl < 0) > - return

Re: [net-next 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

2018-01-04 Thread Andy Gospodarek
On Thu, Jan 04, 2018 at 02:36:54PM -0800, Stephen Hemminger wrote: > On Thu, 4 Jan 2018 15:21:30 -0500 > Andy Gospodarek wrote: > > > +DYNAMIC INTERRUPT MODERATION > > +M: Tal Gilboa > > +S: Mainained > > s/Mainained/Maintained/ Ugh. Thanks for

Re: [PATCH net-next 0/2] net: dsa: lan9303: phy_addr_sel_strap rename and retype

2018-01-04 Thread David Miller
From: Egil Hjelmeland Date: Fri, 29 Dec 2017 13:38:22 +0100 > Non functional cleanups involving chip->phy_addr_sel_strap. > As promised in https://lkml.org/lkml/2017/11/6/273 Series applied, thank you.

Re: [PATCH net] net: stmmac: enable EEE in MII, GMII or RGMII only

2018-01-04 Thread David Miller
From: Jerome Brunet Date: Wed, 3 Jan 2018 16:46:29 +0100 > Note in the databook - Section 4.4 - EEE : > " The EEE feature is not supported when the MAC is configured to use the > TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC > supports multiple PHY

Re: [PATCH] sh_eth: fix TSU resource handling

2018-01-04 Thread David Miller
From: Sergei Shtylyov Date: Wed, 03 Jan 2018 20:09:49 +0300 > When switching the driver to the managed device API, I managed to break > the case of a dual Ether devices sharing a single TSU: the 2nd Ether port > wouldn't probe. Iwamatsu-san has tried to

Re: [PATCH] RDS: null pointer dereference in rds_atomic_free_op

2018-01-04 Thread David Miller
From: simo.ghan...@gmail.com Date: Wed, 3 Jan 2018 21:06:06 + > From: Mohamed Ghannam > > set rm->atomic.op_active to 0 when rds_pin_pages() fails > or the user supplied address is invalid, > this prevents a NULL pointer usage in rds_atomic_free_op() > >

Re: [PATCH net-next v3 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2018-01-04 Thread Jason Baron
On 01/04/2018 01:22 PM, Michael S. Tsirkin wrote: > On Thu, Jan 04, 2018 at 01:12:30PM -0500, Jason Baron wrote: >> >> >> On 01/04/2018 12:05 PM, Michael S. Tsirkin wrote: >>> On Thu, Jan 04, 2018 at 12:16:44AM -0500, Jason Baron wrote: The ability to set speed and duplex for virtio_net is

[RFC -next 0/2] sched: red offload and TC stats

2018-01-04 Thread Jakub Kicinski
Hi! I've been playing with TC qdisc offloads. I came to a little snag with the momentary stats (qlen and backlog). It seems there is a little bit of legacy magic around the backlog while qlen needs changes to be reported. I would appreciate any comments and guidance. Jakub Kicinski (2):

[RFC -next 1/2] net: sched: add qstats.qlen to qlen

2018-01-04 Thread Jakub Kicinski
AFAICT struct gnet_stats_queue.qlen is not used in Qdiscs. It may, however, be useful for offloads to report HW queue length there. Add that value to the result of qdisc_qlen_sum(). Signed-off-by: Jakub Kicinski --- include/net/sch_generic.h | 4 ++-- 1 file

[RFC -next 2/2] net: sched: red: don't reset the backlog on every stat dump

2018-01-04 Thread Jakub Kicinski
Commit 0dfb33a0d7e2 ("sch_red: report backlog information") copied child's backlog into RED's backlog. Back then RED did not maintain its own backlog counts. This has changed after commit 2f5fb43f ("net_sched: update hierarchical backlog too") and commit d7f4f332f082 ("sch_red: update

[net-next 07/10] net: move dynamic interrupt coalescing code to include/linux

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler to act on this collected data once per poll and modify the coalescing parameters

Re: [net-next 00/10] net: create dynamic software irq moderation library

2018-01-04 Thread Or Gerlitz
> net/mlx5e: move interrupt moderation structs to new file > net/mlx5e: move interrupt moderation forward declarations > net/mlx5e: remove rq references in mlx5e_rx_am > net/mlx5e: move AM logic enums > net/mlx5e: move generic functions to new file > net/mlx5e: change Mellanox

Re: [PATCH net-next 0/5] Export SERDES stats via ethtool -S

2018-01-04 Thread Andrew Lunn
> Hi Andrew, > > Isn't the serdes interface just a normal PHY - the register set in > Viviens debugfs patch certainly looks like an 88e1545 in one of the > switches I've here (I think on the dev rev B). Is there a reason why > this PHY isn't visible as a normal PHY, just like we export the other

[PATCH] sh_eth: remove sh_eth_plat_data::edmac_endian

2018-01-04 Thread Sergei Shtylyov
Since the commit 888cc8c20cf ("sh_eth: remove EDMAC_BIG_ENDIAN") (geez, I didn't realize that was 2 years ago!) the initializers in the SuperH platform code for the 'sh_eth_plat_data::edmac_endian' stopped to matter, so we can remove that field for good (not sure if it was ever useful -- SH7786

Re: bonding: Completion of error handling around bond_update_slave_arr()

2018-01-04 Thread SF Markus Elfring
>>> If you see 8 out of 9 call sites in this file ignore the return value. >> >> How do you think about to fix error detection and corresponding >> exception handling then? >> > If I understand your question correctly - not having memory is not a > correctable error I am unsure if it would be

Re: Issue with commit fea23fb591cc "net: phy: convert read-modify-write to phy_modify()"

2018-01-04 Thread Heiner Kallweit
Am 04.01.2018 um 12:44 schrieb Russell King - ARM Linux: > On Thu, Jan 04, 2018 at 08:00:53AM +0100, Heiner Kallweit wrote: >> Parameter mask of phy_modify() holds the bits to be cleared. >> In the mentioned commit parameter mask seems to be inverted in >> few cases, what IMO is wrong (see

Re: [PATCH bpf-next 1/2] bpf: implement syscall command BPF_MAP_GET_NEXT_KEY for stacktrace map

2018-01-04 Thread Jakub Kicinski
On Wed, 3 Jan 2018 23:27:45 -0800, Yonghong Song wrote: > Currently, bpf syscall command BPF_MAP_GET_NEXT_KEY is not > supported for stacktrace map. However, there are use cases where > user space wants to enumerate all stacktrace map entries where > BPF_MAP_GET_NEXT_KEY command will be really

Re: [PATCH net] ipv6: fix general protection fault in fib6_add()

2018-01-04 Thread David Miller
From: Wei Wang Date: Wed, 3 Jan 2018 14:11:59 -0800 > From: Wei Wang > > In fib6_add(), pn could be NULL if fib6_add_1() failed to return a fib6 > node. Checking pn != fn before accessing pn->leaf makes sure pn is not > NULL. > This fixes the following

Re: uapi/if_ether.h: prevent redefinition of struct ethhdr

2018-01-04 Thread David Miller
From: Hauke Mehrtens Date: Wed, 3 Jan 2018 23:14:21 +0100 > Musl provides its own ethhdr struct definition. Add a guard to prevent > its definition of the appropriate musl header has already been included. > > glibc does not implement this header, but when glibc will

Re: [net-next v2] ipv6: sr: export some functions of seg6local

2018-01-04 Thread David Miller
From: Ahmed Abdelsalam Date: Sat, 30 Dec 2017 00:08:32 +0100 > Some functions of seg6local are very useful to process SRv6 > encapsulated packets > > This patch exports some functions of seg6local that are useful and > can be re-used at different parts of the kernel. > >

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-04 Thread Daniel Lezcano
On 04/01/2018 15:06, Greentime Hu wrote: > Hi, Daniel: > > 2018-01-04 21:50 GMT+08:00 Daniel Lezcano : >> >> Hi, >> >> sorry I missed your answer. Comments below. >> >> On 13/12/2017 07:06, Greentime Hu wrote: >>> Hi, Daniel: >>> >>> 2017-12-12 18:05 GMT+08:00 Daniel

Re: [PATCH] nfp: add basic multicast filtering

2018-01-04 Thread Simon Horman
On Thu, Jan 04, 2018 at 04:10:19PM +0100, Simon Horman wrote: > From: Jakub Kicinski > > We currently always pass all multicast traffic through. > Only set L2MC when actually needed. Since the driver > was not making use of the capability to filter out mcast >

Re: [net 02/14] Revert "mlx5: move affinity hints assignments to generic code"

2018-01-04 Thread Saeed Mahameed
On 12/26/2017 9:14 AM, Sagi Grimberg wrote: Are you sure it won't get populated at all  ? even if you manually set IRQ affinity via sysfs ? Yes, the msi_desc affinity is not initialized without the affinity descriptor passed (which is what PCI_IRQ_AFFINITY is for). Anyway we can

Re: [net-next 12/15] i40evf: Drop i40evf_fire_sw_int as it is prone to races

2018-01-04 Thread David Miller
From: Alexander Duyck Date: Thu, 4 Jan 2018 09:51:21 -0800 > I think the patches were reordered an the use of that change was > dropped from the patch. I'll work with Jeff to make certain that the > comment about replacing the line is removed. Thank you.

Re: BUG: free active (active state 0) object type: work_struct hint: strp_work

2018-01-04 Thread Tom Herbert
On Thu, Jan 4, 2018 at 4:10 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6bb8824732f69de0f233ae6b1a8158e149627b38 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1

Re: [PATCH] ps3_gelic_net: Delete an error message for a failed memory allocation in gelic_descr_prepare_rx()

2018-01-04 Thread Geoff Levand
On 01/03/2018 06:40 AM, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. I applied this to my ps3-queue branch. As I mentioned to you several times before, please keep the commit subject line to less than 50 characters. Also, in this case the

Re: [net-next 00/10] net: create dynamic software irq moderation library

2018-01-04 Thread Saeed Mahameed
On 1/4/2018 12:21 PM, Andy Gospodarek wrote: From: Andy Gospodarek This converts the dynamic interrupt moderation library from the mlx5_en driver into a library so it can be used by any driver. The penultimatepatch in this set adds support for interrupt moderation in the

Re: [PATCH net-next] tg3: Add Macronix NVRAM support

2018-01-04 Thread David Miller
From: Satish Baddipadige Date: Wed, 3 Jan 2018 14:59:16 +0530 > From: Prashant Sreedharan > > This patch adds the support for Macronix NVRAM > > Signed-off-by: Prashant Sreedharan >

[net-next 02/10] net/mlx5e: move interrupt moderation forward declarations

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4

[net-next 03/10] net/mlx5e: remove rq references in mlx5e_rx_am

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa

[net-next 08/10] net/dim: use struct net_dim_sample as arg to net_dim

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek Simplify the arguments net_dim() by formatting them into a struct net_dim_sample before calling the function. Signed-off-by: Andy Gospodarek Suggested-by: Tal Gilboa Acked-by: Tal Gilboa ---

[net-next 06/10] net/mlx5e: change Mellanox references in DIM code

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek Change all mlx5_am* and MLX_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used as local variables. Signed-off-by: Andy Gospodarek

[net-next 01/10] net/mlx5e: move interrupt moderation structs to new file

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek Create new header file to prepare to move code that handles irq moderation to a library that lives in a header file. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa ---

[net-next 09/10] bnxt_en: add support for software dynamic interrupt moderation

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek This implements the changes needed for the bnxt_en driver to add support for dynamic interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughput gain

[net-next 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek Signed-off-by: Andy Gospodarek Signed-off-by: Tal Gilboa --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 753799d..769857b 100644 --- a/MAINTAINERS +++

[net-next 00/10] net: create dynamic software irq moderation library

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek This converts the dynamic interrupt moderation library from the mlx5_en driver into a library so it can be used by any driver. The penultimatepatch in this set adds support for interrupt moderation in the bnxt_en driver and the last patch creates an

[net-next 04/10] net/mlx5e: move AM logic enums

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek More movement to help make this code more generic. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa --- drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26 ++

[net-next 05/10] net/mlx5e: move generic functions to new file

2018-01-04 Thread Andy Gospodarek
From: Andy Gospodarek These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_dim.c. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa

Re: [Intel-wired-lan] [bpf-next V4 PATCH 04/14] ixgbe: setup xdp_rxq_info

2018-01-04 Thread John Fastabend
On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote: > Driver hook points for xdp_rxq_info: > * reg : ixgbe_setup_rx_resources() > * unreg: ixgbe_free_rx_resources() > > Tested on actual hardware. > > V2: Fix ixgbe_set_ringparam, clear xdp_rxq_info in temp_ring > > Cc:

Re: [bpf-next V4 PATCH 01/14] xdp: base API for new XDP rx-queue info concept

2018-01-04 Thread John Fastabend
On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote: > This patch only introduce the core data structures and API functions. > All XDP enabled drivers must use the API before this info can used. > > There is a need for XDP to know more about the RX-queue a given XDP > frames have arrived on.

[PATCH v2 bpf] bpf: prevent out-of-bounds speculation

2018-01-04 Thread Alexei Starovoitov
From: Alexei Starovoitov Under speculation, CPUs may mis-predict branches in bounds checks. Thus, memory accesses under a bounds check may be speculated even if the bounds check fails, providing a primitive for building a side channel. To avoid leaking kernel data round up

[PATCH net-next V2 0/2] tun: allow to attahc eBPF filter

2018-01-04 Thread Jason Wang
Hi all: This series tries to implement eBPF socket filter for tun. This could be used for implementing efficient virtio-net receive filter for vhost-net. Thanks Changes from V1: - trim more bytes if vlan tag is existed to make sure the packet length does not exceed what is allowed by the

[PATCH net-next V2 1/2] tuntap: rename struct tun_steering_prog to struct tun_prog

2018-01-04 Thread Jason Wang
To be reused by other eBPF program other than queue selection. Signed-off-by: Jason Wang --- drivers/net/tun.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index

[PATCH net-next V2 2/2] tun: allow to attach ebpf socket filter

2018-01-04 Thread Jason Wang
This patch allows userspace to attach eBPF filter to tun. This will allow to implement VM dataplane filtering in a more efficient way compared to cBPF filter by allowing either qemu or libvirt to attach eBPF filter to tun. Signed-off-by: Jason Wang --- drivers/net/tun.c

Re: [bpf-next V4 PATCH 07/14] bnxt_en: setup xdp_rxq_info

2018-01-04 Thread Michael Chan
On Wed, Jan 3, 2018 at 2:25 AM, Jesper Dangaard Brouer wrote: > Driver hook points for xdp_rxq_info: > * reg : bnxt_alloc_rx_rings > * unreg: bnxt_free_rx_rings > > This driver should be updated to re-register when changing > allocation mode of RX rings. > > Tested on actual

Re: [bpf-next V4 PATCH 13/14] bpf: finally expose xdp_rxq_info to XDP bpf-programs

2018-01-04 Thread John Fastabend
On 01/03/2018 02:26 AM, Jesper Dangaard Brouer wrote: > Now all XDP driver have been updated to setup xdp_rxq_info and assign > this to xdp_buff->rxq. Thus, it is now safe to enable access to some > of the xdp_rxq_info struct members. > > This patch extend xdp_md and expose UAPI to userspace for

[PATCH bpf-next 00/16] bpf: support creating maps on networking devices

2018-01-04 Thread Jakub Kicinski
Hi! This set adds support for creating maps on networking devices. BPF is programs+maps, the pure program offload has been around for quite some time, this patchset adds the map part of the equation. Maps are allocated on the target device from the start. There is no host copy when map is

[PATCH bpf-next 10/16] nfp: bpf: add map data structure

2018-01-04 Thread Jakub Kicinski
To be able to split code into reasonable chunks we need to add the map data structures already. Later patches will add code piece by piece. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

[PATCH bpf-next 02/16] bpf: array: move checks out of alloc function

2018-01-04 Thread Jakub Kicinski
Use the new callback to perform allocation checks for array maps. The fd maps don't need a special allocation callback, they only need a special check callback. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

2018-01-04 Thread Luis R. Rodriguez
On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote: > On Friday 10 November 2017 00:38:22 Pali Rohár wrote: > > This patch series fix processing MAC address for wl1251 chip found in Nokia > > N900. > > > > Changes since v1: > > * Added Acked-by for Pavel Machek > > * Fixed grammar > > *

[PATCH 2/2] build_bug.h: remove BUILD_BUG_ON_NULL()

2018-01-04 Thread Masahiro Yamada
This macro is only used by net/ipv6/mcast.c, but there is no reason why it must be BUILD_BUG_ON_NULL(). Replace it with BUILD_BUG_ON_ZERO(), and remove BUILD_BUG_ON_NULL() definition from . Signed-off-by: Masahiro Yamada --- include/linux/build_bug.h | 2 --

[PATCH 0/2] Consolidate BUILD_BUG macros

2018-01-04 Thread Masahiro Yamada
Masahiro Yamada (2): genl_magic: remove own BUILD_BUG_ON*() defines build_bug.h: remove BUILD_BUG_ON_NULL() include/linux/build_bug.h | 2 -- include/linux/genl_magic_func.h | 12 +--- net/ipv6/mcast.c| 8 3 files changed, 5 insertions(+), 17

Re: [PATCH iproute2-next v1 3/9] rdma: Add filtering infrastructure

2018-01-04 Thread David Ahern
On 1/4/18 12:01 AM, Leon Romanovsky wrote: > diff --git a/rdma/utils.c b/rdma/utils.c > index af2b374d..446c23da 100644 > --- a/rdma/utils.c > +++ b/rdma/utils.c > @@ -114,6 +114,225 @@ static void dev_map_cleanup(struct rd *rd) > } > } > > +static int add_filter(struct rd *rd, char *key,

Re: [PATCH] MAINTAINERS: Update my email address.

2018-01-04 Thread Pravin Shelar
On Thu, Jan 4, 2018 at 10:38 AM, David Miller wrote: > From: Pravin B Shelar > Date: Tue, 2 Jan 2018 20:14:42 -0800 > >> Signed-off-by: Pravin Shelar > > Applied, but please take Joe's feedback into consideration. I was bit busy so could

IPv6 source based policy routing query

2018-01-04 Thread sundeep subbaraya
Hi, I am quite new to IPv6. I ran to one problem hope you guys can help me. I have multiple ethernet port box which runs by Altera's Cyclone 5. I am using source based policy routing for ipv6. The problem is when there is "default via " entry in per interface routing table then ping to a link

Re: Investment

2018-01-04 Thread James Tyler, MBA, CFA
Thank you for your time, We are looking for clients in your country with good business or project that requires financing to execute. Please get back to me if you are interested in this or you know anybody who has good business ideas but lack the necessary capital to fund his projects so we

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-04 Thread Pravin Shelar
On Wed, Jan 3, 2018 at 7:49 PM, Ed Swierk wrote: > On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar wrote: >> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk >> wrote: >>> IPv4 and IPv6 packets may arrive with lower-layer

[PATCH NET-NEXT 1/1] forcedeth: remove duplicate structure member in rx

2018-01-04 Thread Zhu Yanjun
Since both first_rx and rx_ring are the head of rx ring, it not necessary to use two structure members to statically indicate the head of rx ring. So first_rx is removed. CC: Srinivas Eeda CC: Joe Jin CC: Junxiao Bi

Re: [Intel-wired-lan] [bpf-next V4 PATCH 03/14] i40e: setup xdp_rxq_info

2018-01-04 Thread John Fastabend
On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote: > The i40e driver has a special "FDIR" RX-ring (I40E_VSI_FDIR) which is > a sideband channel for configuring/updating the flow director tables. > This (i40e_vsi_)type does not invoke XDP-ebpf code. > > As suggested by Björn (V2): Instead of

[PATCH bpf-next 14/16] nfp: bpf: add verification and codegen for map lookups

2018-01-04 Thread Jakub Kicinski
Verify our current constraints on the location of the key are met and generate the code for calling map lookup on the datapath. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/jit.c

[PATCH bpf-next 04/16] bpf: hashtab: move checks out of alloc function

2018-01-04 Thread Jakub Kicinski
Use the new callback to perform allocation checks for hash maps. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- kernel/bpf/hashtab.c | 55 +--- 1 file changed, 39

[PATCH bpf-next 03/16] bpf: hashtab: move attribute validation before allocation

2018-01-04 Thread Jakub Kicinski
Number of attribute checks are currently performed after hashtab is already allocated. Move them to be able to split them out to the check function later on. Checks have to now be performed on the attr union directly instead of the members of bpf_map, since bpf_map will be allocated later. No

[PATCH bpf-next 15/16] nfp: bpf: add support for reading map memory

2018-01-04 Thread Jakub Kicinski
Map memory needs to use 40 bit addressing. Add handling of such accesses. Since 40 bit addresses are formed by using both 32 bit operands we need to pre-calculate the actual address instead of adding in the offset inside the instruction, like we did in 32 bit mode. Signed-off-by: Jakub Kicinski

  1   2   3   >