[PATCH net] ip6_gre: init dev->mtu and dev->hard_header_len correctly

2018-01-11 Thread Alexey Kodanev
Commit b05229f44228 ("gre6: Cleanup GREv6 transmit path, call common GRE functions") moved dev->mtu initialization from ip6gre_tunnel_setup() to ip6gre_tunnel_init(), as a result, the previously set values, before ndo_init(), are reset in the following cases: * rtnl_create_link() can update

Re: [patch net-next v7 07/13] net: sched: use block index as a handle instead of qdisc when block is shared

2018-01-11 Thread Jamal Hadi Salim
On 18-01-09 09:07 AM, Jiri Pirko wrote: From: Jiri Pirko As the tcm_ifindex 0 is invalid ifindex, reuse it to indicate that we work with block, instead of qdisc. So if tcm_ifindex is 0, tcm_parent is used to carry block_index. Commit log still refers to ifindex of 0

Re: [PATCH 26/32] aio: refactor read/write iocb setup

2018-01-11 Thread Christoph Hellwig
On Wed, Jan 10, 2018 at 04:19:53PM -0500, Jeff Moyer wrote: > > +static int aio_prep_rw(struct kiocb *req, struct iocb *iocb) > > +{ > > + int ret; > > + > > + req->ki_filp = fget(iocb->aio_fildes); > > + if (unlikely(!req->ki_filp)) > > + return -EBADF; > > + req->ki_complete =

Re: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

2018-01-11 Thread Aviad Yehezkel
On 1/11/2018 10:28 AM, Yossi Kuperman wrote: From: Shannon Nelson [mailto:shannon.nel...@oracle.com] Sent: Thursday, January 11, 2018 5:21 AM On 1/10/2018 3:09 PM, Yossi Kuperman wrote: On 10 Jan 2018, at 19:36, Shannon Nelson wrote: On 1/10/2018 2:34 AM,

Re: [patch net-next v7 07/13] net: sched: use block index as a handle instead of qdisc when block is shared

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 02:25:36PM CET, j...@mojatatu.com wrote: >On 18-01-09 09:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> As the tcm_ifindex 0 is invalid ifindex, reuse it to indicate that we >> work with block, instead of qdisc. So if tcm_ifindex is 0, tcm_parent is >>

Re: [patch net-next v7 08/13] net: sched: add rt netlink message type for block get

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 02:27:11PM CET, j...@mojatatu.com wrote: >On 18-01-09 09:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Add simple block get operation which primary purpose is to check the >> block existence by block index. >> > >block_dump missing? It is not needed

Re: [patch net-next v7 00/13] net: sched: allow qdiscs to share filter block instances

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 02:19:16PM CET, j...@mojatatu.com wrote: >On 18-01-09 09:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the filters added to qdiscs are independent. So for example if you >> have 2 netdevices and you create ingress qdisc on both and you want

[PATCH 2/3] tcp: Add ESP encapsulation support

2018-01-11 Thread Herbert Xu
This patch adds the plumbing in TCP for ESP encapsulation support per RFC8229. The patch mostly deals with inbound processing, as well as enabling TCP encapsulation on a socket through setsockopt. The outbound processing is dealt with in the ESP code as is done for UDP. The inbound processing

[PATCH 3/3] ipsec: Add ESP over TCP encapsulation support

2018-01-11 Thread Herbert Xu
This patch adds support for ESP over TCP encapsulation per RFC8229. Most of the input processing is done in the TCP stack and not in this patch, which is similar to UDP encapsulation. On the output side, there are two potential levels of indirection. Firstly all packets are fed through a tasklet

[PATCH 1/3] skbuff: Avoid sleeping in skb_send_sock_locked

2018-01-11 Thread Herbert Xu
For a function that needs to be called with the socket spinlock held, sleeping would seem to be a bad idea. This function does in fact avoid sleeping when calling kernel_sendpage_locked on the page part of the skb. However, it doesn't do that when sending the linear part. Resulting in sleeping

Re: [patch net-next v7 03/13] net: sched: avoid usage of tp->q in tcf_classify

2018-01-11 Thread David Ahern
On 1/11/18 2:40 AM, Jiri Pirko wrote: > Wed, Jan 10, 2018 at 05:17:28PM CET, dsah...@gmail.com wrote: >> On 1/9/18 7:07 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Use block index in the messages instead. >>> >>> Signed-off-by: Jiri Pirko >>> --- >>>

[PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings

2018-01-11 Thread Julia Lawall
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b4464bcab38d3f7fe995a7cb960eeac6889bec08 commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter: nf_tables: add flow table netlink frontend The following is a 0-day report generated by

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 02:36:01PM CET, j...@mojatatu.com wrote: >On 18-01-09 09:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Benefit from the previously introduced shared filter blocks >> infrastructure and allow ingress and clsact qdisc instances to share >> filter

Re: general protection fault in sctp_v6_get_dst

2018-01-11 Thread Neil Horman
On Thu, Jan 11, 2018 at 05:30:17PM +0800, Xin Long wrote: > On Thu, Jan 11, 2018 at 2:15 AM, syzbot > wrote: > > syzkaller has found reproducer for the following crash on > > 61ad64080e039dce99a7f8d89b729bbea995e2f7 > >

[PATCH 0/3] ipsec: Add ESP over TCP encapsulation

2018-01-11 Thread Herbert Xu
Hi: This series of patches add basic support for ESP over TCP (RFC 8229). Note that this does not include TLS support but it could be added in future. Here is an iproute patch to setup xfrm states with this: diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c index 12c2f72..f3fb1e2 100644 --- a/ip/ipxfrm.c

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jamal Hadi Salim
On 18-01-09 09:07 AM, Jiri Pirko wrote: From: Jiri Pirko Benefit from the previously introduced shared filter blocks infrastructure and allow ingress and clsact qdisc instances to share filter blocks. The block index is coming from userspace as qdisc option. Didnt quiet

Re: [PATCH net] net: ipv4: Make "ip route get" match iif lo rules again.

2018-01-11 Thread David Ahern
On 1/11/18 2:36 AM, Lorenzo Colitti wrote: > Commit 3765d35ed8b9 ("net: ipv4: Convert inet_rtm_getroute to rcu > versions of route lookup") broke "ip route get" in the presence > of rules that specify iif lo. > > Host-originated traffic always has iif lo, because > ip_route_output_key_hash and

Re: [PATCH] netfilter: nf_tables: fix odd_ptr_err.cocci warnings

2018-01-11 Thread Pablo Neira Ayuso
On Thu, Jan 11, 2018 at 03:02:12PM +0100, Julia Lawall wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b4464bcab38d3f7fe995a7cb960eeac6889bec08 > commit: 3b49e2e94e6ebb8b23d0955d9e898254455734f8 [8286/9035] netfilter: > nf_tables: add flow

BUG: using smp_processor_id() in preemptible

2018-01-11 Thread Ricardo Nabinger Sanchez
Greetings, I'm getting occasional video lock-ups, and while checking logs I found these: === [ 297.445296] BUG: using smp_processor_id() in preemptible [] code: claws-mail/1635 [ 297.445319] caller is jprobe_return+0x12/0x25 [ 297.445332] CPU: 1 PID: 1635 Comm: claws-mail Not tainted

Re: [patch net-next v7 00/13] net: sched: allow qdiscs to share filter block instances

2018-01-11 Thread Jamal Hadi Salim
On 18-01-09 09:07 AM, Jiri Pirko wrote: From: Jiri Pirko Currently the filters added to qdiscs are independent. So for example if you have 2 netdevices and you create ingress qdisc on both and you want to add identical filter rules both, you need to add them twice. This

Re: [patch net-next v7 08/13] net: sched: add rt netlink message type for block get

2018-01-11 Thread Jamal Hadi Salim
On 18-01-09 09:07 AM, Jiri Pirko wrote: From: Jiri Pirko Add simple block get operation which primary purpose is to check the block existence by block index. block_dump missing? cheers, jamal

Re: [PATCH 30/32] aio: add delayed cancel support

2018-01-11 Thread Christoph Hellwig
On Wed, Jan 10, 2018 at 06:26:39PM -0500, Jeff Moyer wrote: > >> The upcoming aio poll support would like to be able to complete the > >> iocb inline from the cancellation context, but that would cause > >> a lock order reversal. Add support for optionally moving the cancelation > >> outside the

[PATCH net] net: ipv4: Make "ip route get" match iif lo rules again.

2018-01-11 Thread Lorenzo Colitti
Commit 3765d35ed8b9 ("net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup") broke "ip route get" in the presence of rules that specify iif lo. Host-originated traffic always has iif lo, because ip_route_output_key_hash and ip6_route_output_flags set the flow iif to

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Jiri Kosina
On Tue, 9 Jan 2018, Josh Poimboeuf wrote: > On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: > > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > > > On Fri, 5 Jan 2018, Dan Williams wrote: > > > > > > [ ... snip ... ] > > >> Andi Kleen (1): > > >> x86,

[PATCH net-next 10/11] net: hns3: add feature check when feature changed

2018-01-11 Thread Peng Li
From: Jian Shen Local variable "changed" was defined to indicates features changed, but was used only for feature NETIF_F_HW_VLAN_CTAG_RX. Add checking for other features. Fixes: 052ece6dc19c ("net: hns3: add ethtool related offload command") Signed-off-by: Jian Shen

[PATCH net-next 06/11] net: hns3: refactor GL update function

2018-01-11 Thread Peng Li
From: Fuyun Liang The GL update function uses the max GL value between tx_int_gl and rx_int_gl to set both new tx_int_gl and new rx_int_gl. Therefore, User can not enable TX GL self-adaptive or RX GL self-adaptive individually. This patch refactors the code to update the

[PATCH net-next 00/11] add some new features and fix some bugs

2018-01-11 Thread Peng Li
This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF driver. [patch 3/11] adds ethtool_ops.get_coalesce support to PF. [patch 4/11] adds ethtool_ops.set_coalesce support to PF. [patch

Re: [PATCH V2] ipvlan: fix ipvlan MTU limits

2018-01-11 Thread Jiri Benc
On Wed, 10 Jan 2018 18:09:50 -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > I still prefer the approach I had mentioned that uses 'mtu_adj'. In > that approach you can leave those slaves which have changed their mtu > to be lower than masters' but if master's mtu changes to larger value > all

Re: [PATCH 03/32] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-01-11 Thread Christoph Hellwig
For other horrors that are even worse than any given ->poll instance take a look at scif_poll and friends..

[PATCH 08/11] xfrm: don't call xfrm_policy_cache_flush while holding spinlock

2018-01-11 Thread Steffen Klassert
From: Florian Westphal xfrm_policy_cache_flush can sleep, so it cannot be called while holding a spinlock. We could release the lock first, but I don't see why we need to invoke this function here in first place, the packet path won't reuse an xdst entry unless its still valid.

[PATCH 10/11] af_key: Fix memory leak in key_notify_policy.

2018-01-11 Thread Steffen Klassert
We leak the allocated out_skb in case pfkey_xfrm_policy2msg() fails. Fix this by freeing it on error. Reported-by: Dmitry Vyukov Signed-off-by: Steffen Klassert --- net/key/af_key.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 09/11] esp: Fix GRO when the headers not fully in the linear part of the skb.

2018-01-11 Thread Steffen Klassert
The GRO layer does not necessarily pull the complete headers into the linear part of the skb, a part may remain on the first page fragment. This can lead to a crash if we try to pull the headers, so make sure we have them on the linear part before pulling. Fixes: 7785bba299a8 ("esp: Add a

[PATCH 11/11] xfrm: Fix a race in the xdst pcpu cache.

2018-01-11 Thread Steffen Klassert
We need to run xfrm_resolve_and_create_bundle() with bottom halves off. Otherwise we may reuse an already released dst_enty when the xfrm lookup functions are called from process context. Fixes: c30d78c14a813db39a647b6a348b428 ("xfrm: add xdst pcpu cache") Reported-by: Darius Ski

[PATCH 06/11] xfrm: Use __skb_queue_tail in xfrm_trans_queue

2018-01-11 Thread Steffen Klassert
From: Herbert Xu We do not need locking in xfrm_trans_queue because it is designed to use per-CPU buffers. However, the original code incorrectly used skb_queue_tail which takes the lock. This patch switches it to __skb_queue_tail instead. Reported-and-tested-by:

[PATCH 05/11] xfrm: fix rcu usage in xfrm_get_type_offload

2018-01-11 Thread Steffen Klassert
From: Sabrina Dubroca request_module can sleep, thus we cannot hold rcu_read_lock() while calling it. The function also jumps back and takes rcu_read_lock() again (in xfrm_state_get_afinfo()), resulting in an imbalance. This codepath is triggered whenever a new offloaded

[PATCH 04/11] af_key: fix buffer overread in parse_exthdrs()

2018-01-11 Thread Steffen Klassert
From: Eric Biggers If a message sent to a PF_KEY socket ended with an incomplete extension header (fewer than 4 bytes remaining), then parse_exthdrs() read past the end of the message, into uninitialized memory. Fix it by returning -EINVAL in this case. Reproducer:

Re: [iptables] extensions: add support for 'srh' match

2018-01-11 Thread Pablo Neira Ayuso
On Thu, Jan 11, 2018 at 11:14:52AM +0100, Ahmed Abdelsalam wrote: > On Wed, 10 Jan 2018 16:32:24 +0100 > Pablo Neira Ayuso wrote: > > > On Fri, Dec 29, 2017 at 12:08:25PM +0100, Ahmed Abdelsalam wrote: > > > This patch adds a new exetension to iptables to supprt 'srh' match

Re: [iptables] extensions: add support for 'srh' match

2018-01-11 Thread Ahmed Abdelsalam
On Wed, 10 Jan 2018 16:32:24 +0100 Pablo Neira Ayuso wrote: > On Fri, Dec 29, 2017 at 12:08:25PM +0100, Ahmed Abdelsalam wrote: > > This patch adds a new exetension to iptables to supprt 'srh' match > > The implementation considers revision 7 of the SRH draft. > >

[patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

2018-01-11 Thread Jiri Pirko
From: Nogah Frankel Support basic stats for PRIO qdisc, which includes tx packets and bytes count, drops count and backlog size. The rest of the stats are irrelevant for this qdisc offload. Since backlog is not only incremental but reflecting momentary value, in case of a

[patch net-next 0/5] mlxsw: Offload PRIO qdisc

2018-01-11 Thread Jiri Pirko
From: Jiri Pirko Add an offload support for PRIO qdisc for mlxsw driver. PRIO qdisc is being offloaded by using ndo_setup_tc. It has three commands, to set or tune the qdisc, to remove it and to get its stats. Like RED offloading, offloading this qdisc is not enforced on the

[patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-11 Thread Jiri Pirko
From: Nogah Frankel Add the ability to offload PRIO qdisc by using ndo_setup_tc. There are three commands for PRIO offloading: * TC_PRIO_REPLACE: handles set and tune * TC_PRIO_DESTROY: handles qdisc destroy * TC_PRIO_STATS: updates the qdiscs counters (given as reference)

[patch net-next 4/5] mlxsw: spectrum: qdiscs: Support PRIO qdisc offload

2018-01-11 Thread Jiri Pirko
From: Nogah Frankel Add support for offloading PRIO qdisc as root qdisc. The support is for up to 8 bands. Routed packets priority is determined by the DSCP field with the default translations. Bridged packets priority is determined by the PCP field, if exist, otherwise it

[patch net-next 2/5] mlxsw: spectrum_router: Configure default routing priority

2018-01-11 Thread Jiri Pirko
From: Yuval Mintz When routing ip packets, the kernel is setting the SKB's priority based on the tos field of the packet. Imitate this behavior in the mlxsw router, having the internal switch priority of a routed packet determined according to its DS field. Signed-off-by:

Re: [PATCH 34/38] arm: Implement thread_struct whitelist for hardened usercopy

2018-01-11 Thread Russell King - ARM Linux
On Wed, Jan 10, 2018 at 06:03:06PM -0800, Kees Cook wrote: > ARM does not carry FPU state in the thread structure, so it can declare > no usercopy whitelist at all. This comment seems to be misleading. We have stored FP state in the thread structure for a long time - for example, VFP state is

Re: KASAN: use-after-free Read in __bpf_prog_put

2018-01-11 Thread Daniel Borkmann
Hi Dmitry, On 01/11/2018 11:22 AM, Dmitry Vyukov wrote: > On Thu, Jan 11, 2018 at 11:17 AM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 4147d50978df60f34d444c647dde9e5b34a4315e >>

[PATCH net-next 03/11] net: hns3: add ethtool_ops.get_coalesce support to PF

2018-01-11 Thread Peng Li
From: Fuyun Liang This patch adds ethtool_ops.get_coalesce support to PF. Whilst our hardware supports per queue values, external interfaces support only a single shared value. As such we use the values for queue 0. Signed-off-by: Fuyun Liang

[PATCH net-next 08/11] net: hns3: change the unit of GL value macro

2018-01-11 Thread Peng Li
From: Fuyun Liang Previously, driver used 2us as the GL unit. The time unit ethtool command "-c" and "-C" use is 1us, so now the GL unit driver uses actually is 1us. This patch changes the unit of GL value macro from 2us to 1us. Signed-off-by: Fuyun Liang

[PATCH net-next 02/11] net: hns3: remove TSO config command from VF driver

2018-01-11 Thread Peng Li
Only main PF can config TSO MSS length according to hardware. This patch removes TSO config command from VF driver. Signed-off-by: Peng Li --- .../net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h | 8 .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c| 20

[PATCH net-next 07/11] net: hns3: remove unused GL setup function

2018-01-11 Thread Peng Li
From: Fuyun Liang Since the TX GL and the RX GL need to be set separately, hns3_set_vector_coalesc_gl() has been replaced with hns3_set_vector_coalesce_rx_gl() and hns3_set_vector_coalesce_tx_gl(). This patch removes hns3_set_vector_coalesc_gl(). Signed-off-by: Fuyun

[PATCH net-next 05/11] net: hns3: refactor interrupt coalescing init function

2018-01-11 Thread Peng Li
From: Fuyun Liang In the hardware, the coalesce configurable registers include GL0, GL1, GL2. In the driver, the TX queues use the register GL1 and the RX queues use the register GL0. This function initializes the configuration of the interrupt coalescing, but does not

[PATCH net-next 01/11] net: hns3: add ethtool_ops.get_channels support for VF

2018-01-11 Thread Peng Li
This patch supports the ethtool's get_channels() for VF. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 1 + .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 30 ++ 2 files changed, 31 insertions(+) diff --git

Re: [PATCH 03/32] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-01-11 Thread Christoph Hellwig
On Wed, Jan 10, 2018 at 09:04:16PM +, Al Viro wrote: > There's another problem with that - currently ->poll() may tell you "sod off, > I've got nothing for you to sleep on, eat your POLLHUP|POLLERR|something > and don't pester me again". With your API that's hard to express sanely. And what

[PATCH 02/11] xfrm: skip policies marked as dead while rehashing

2018-01-11 Thread Steffen Klassert
From: Florian Westphal syzkaller triggered following KASAN splat: BUG: KASAN: slab-out-of-bounds in xfrm_hash_rebuild+0xdbe/0xf00 net/xfrm/xfrm_policy.c:618 read of size 2 at addr 8801c8e92fe4 by task kworker/1:1/23 [..] Workqueue: events xfrm_hash_rebuild [..]

[PATCH 07/11] xfrm: Return error on unknown encap_type in init_state

2018-01-11 Thread Steffen Klassert
From: Herbert Xu Currently esp will happily create an xfrm state with an unknown encap type for IPv4, without setting the necessary state parameters. This patch fixes it by returning -EINVAL. There is a similar problem in IPv6 where if the mode is unknown we will

pull request (net): ipsec 2018-01-11

2018-01-11 Thread Steffen Klassert
1) Don't allow to change the encap type on state updates. The encap type is set on state initialization and should not change anymore. From Herbert Xu. 2) Skip dead policies when rehashing to fix a slab-out-of-bounds bug in xfrm_hash_rebuild. From Florian Westphal. 3) Two buffer

[PATCH 01/11] xfrm: Forbid state updates from changing encap type

2018-01-11 Thread Steffen Klassert
From: Herbert Xu Currently we allow state updates to competely replace the contents of x->encap. This is bad because on the user side ESP only sets up header lengths depending on encap_type once when the state is first created. This could result in the header

[PATCH 03/11] af_key: fix buffer overread in verify_address_len()

2018-01-11 Thread Steffen Klassert
From: Eric Biggers If a message sent to a PF_KEY socket ended with one of the extensions that takes a 'struct sadb_address' but there were not enough bytes remaining in the message for the ->sa_family member of the 'struct sockaddr' which is supposed to follow, then

Re: [Patch net] tipc: fix a memory leak in tipc_nl_node_get_link()

2018-01-11 Thread Ying Xue
On 01/11/2018 04:50 AM, Cong Wang wrote: > When tipc_node_find_by_name() fails, the nlmsg is not > freed. > > While on it, switch to a goto label to properly > free it. > > Fixes: be9c086715c ("tipc: narrow down exposure of struct tipc_node") > Reported-by: Dmitry Vyukov >

Re: [PATCH] [net-next] net: socionext: include linux/io.h to fix build

2018-01-11 Thread Ard Biesheuvel
On 11 January 2018 at 10:36, Arnd Bergmann wrote: > I ran into a randconfig build failure: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe': > drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration > of function 'devm_ioremap'; did you

Re: [patch net-next v7 08/13] net: sched: add rt netlink message type for block get

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 10:37:10AM CET, j...@resnulli.us wrote: >Wed, Jan 10, 2018 at 05:48:09PM CET, dsah...@gmail.com wrote: >>On 1/9/18 7:07 AM, Jiri Pirko wrote: >>> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >>> index 9c026d9..038cde7 100644 >>> ---

[PATCH net-next] net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()

2018-01-11 Thread Wei Yongjun
platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference a bit later in the code. This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = platform_get_resource(pdev, t, n); + if

[PATCH net-next] net: socionext: Fix error return code in netsec_netdev_open()

2018-01-11 Thread Wei Yongjun
Fix to return error code -ENODEV from the of_phy_connect() error handling case instead of 0, as done elsewhere in this function. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/socionext/netsec.c | 1

Re: [Patch net v2] tun: fix a memory leak for tfile->tx_array

2018-01-11 Thread Jason Wang
On 2018年01月11日 02:51, Cong Wang wrote: tfile->tun could be detached before we close the tun fd, via tun_detach_all(), so it should not be used to check for tfile->tx_array. As Jason suggested, we probably have to clean it up unconditionally, but this requires to check if it is initialized or

Re: KASAN: use-after-free Read in __bpf_prog_put

2018-01-11 Thread Dmitry Vyukov
On Thu, Jan 11, 2018 at 11:17 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 4147d50978df60f34d444c647dde9e5b34a4315e > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is

[patch net-next 1/5] mlxsw: reg: add rdpm register

2018-01-11 Thread Jiri Pirko
From: Yuval Mintz Add rdpm definition - router DSCP to priority mapping register. Signed-off-by: Yuval Mintz Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko ---

[PATCH] [net-next] net: socionext: include linux/io.h to fix build

2018-01-11 Thread Arnd Bergmann
I ran into a randconfig build failure: drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe': drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] Including

[PATCH net-next 09/11] net: hns3: add int_gl_idx setup for TX and RX queues

2018-01-11 Thread Peng Li
From: Fuyun Liang If the int_gl_idx does not be set, the default interrupt coalesce index is 0. The TX queues and the RX queues will both use the GL0 as the interrupt coalesce GL switch. But it should be GL1 for TX queues and GL0 for RX queues. This patch adds the

[PATCH net-next 04/11] net: hns3: add ethtool_ops.set_coalesce support to PF

2018-01-11 Thread Peng Li
From: Fuyun Liang This patch adds ethtool_ops.set_coalesce support to PF. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 34 -

[PATCH net-next 11/11] net: hns3: check for NULL function pointer in hns3_nic_set_features

2018-01-11 Thread Peng Li
From: Jian Shen It's necessary to check hook whether being defined before calling, improve the reliability. Signed-off-by: Jian Shen Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 -- 1

PATCH V5 4/4] selinux: Add SCTP support

2018-01-11 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- V5 Change: Rework selinux_netlbl_socket_connect() and selinux_netlbl_socket_connect_locked as requested by Paul.

Re: [patch net-next v7 07/13] net: sched: use block index as a handle instead of qdisc when block is shared

2018-01-11 Thread Jiri Pirko
Wed, Jan 10, 2018 at 07:12:44PM CET, dsah...@gmail.com wrote: >On 1/9/18 7:07 AM, Jiri Pirko wrote: >> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >> index 843e29a..9c026d9 100644 >> --- a/include/uapi/linux/rtnetlink.h >> +++ b/include/uapi/linux/rtnetlink.h >> @@

Re: general protection fault in sctp_v6_get_dst

2018-01-11 Thread Xin Long
On Thu, Jan 11, 2018 at 2:15 AM, syzbot wrote: > syzkaller has found reproducer for the following crash on > 61ad64080e039dce99a7f8d89b729bbea995e2f7 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc

pull request: bluetooth-next 2018-01-11

2018-01-11 Thread Johan Hedberg
Hi Dave, Here's likely the last bluetooth-next pull request for the 4.16 kernel. - Added support for Bluetooth on 2015+ MacBook (Pro) - Fix to QCA Rome suspend/resume handling - Two new QCA_ROME USB IDs in btusb - A few other minor fixes Please let me know if there are any issues pulling.

Re: [patch net-next v7 03/13] net: sched: avoid usage of tp->q in tcf_classify

2018-01-11 Thread Jiri Pirko
Wed, Jan 10, 2018 at 05:17:28PM CET, dsah...@gmail.com wrote: >On 1/9/18 7:07 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Use block index in the messages instead. >> >> Signed-off-by: Jiri Pirko >> --- >> net/sched/cls_api.c | 5 +++-- >> 1 file

[PATCH 2/2] xen-netfront: Fix race between device setup and open

2018-01-11 Thread Ross Lagerwall
When a netfront device is set up it registers a netdev fairly early on, before it has set up the queues and is actually usable. A userspace tool like NetworkManager will immediately try to open it and access its state as soon as it appears. The bug can be reproduced by hotplugging VIFs until the

RE: [PATCH net-next v2] xfrm: Add ESN support for IPSec HW offload

2018-01-11 Thread Yossi Kuperman
> From: Shannon Nelson [mailto:shannon.nel...@oracle.com] > Sent: Thursday, January 11, 2018 5:21 AM > > On 1/10/2018 3:09 PM, Yossi Kuperman wrote: > >> On 10 Jan 2018, at 19:36, Shannon Nelson wrote: > >> > >>> On 1/10/2018 2:34 AM, yoss...@mellanox.com wrote: > >>>

Re: [PATCH 03/32] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-01-11 Thread Christoph Hellwig
On Thu, Jan 11, 2018 at 05:22:00AM +, Al Viro wrote: > Whee... The very first ->poll() instance in alphabetic order on pathnames: > in arch/cris/arch-v10/drivers/gpio.c > > static __poll_t gpio_poll(struct file *file, poll_table *wait) > { > __poll_t mask = 0; > struct

Re: [patch net-next v7 08/13] net: sched: add rt netlink message type for block get

2018-01-11 Thread Jiri Pirko
Wed, Jan 10, 2018 at 05:48:09PM CET, dsah...@gmail.com wrote: >On 1/9/18 7:07 AM, Jiri Pirko wrote: >> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >> index 9c026d9..038cde7 100644 >> --- a/include/uapi/linux/rtnetlink.h >> +++ b/include/uapi/linux/rtnetlink.h >> @@

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jamal Hadi Salim
On 18-01-11 09:41 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 03:37:08PM CET, j...@mojatatu.com wrote: On 18-01-11 09:24 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 02:36:01PM CET, j...@mojatatu.com wrote: On 18-01-09 09:07 AM, Jiri Pirko wrote: From: Jiri Pirko Benefit

[PATCH] usbnet: silence an unnecessary warning

2018-01-11 Thread Oliver Neukum
That a kevent could not be scheduled is not an error. Such handlers must be able to deal with multiple events anyway. As the successful scheduling of a work is a debug event, make the failure debug priority, too. Signed-off-by: Oliver Neukum Reported-by: Cristian Caravena

Re: [PATCH] usbnet: silence an unnecessary warning

2018-01-11 Thread Bjørn Mork
Oliver Neukum writes: > That a kevent could not be scheduled is not an error. > Such handlers must be able to deal with multiple events anyway. > As the successful scheduling of a work is a debug event, make > the failure debug priority, too. > > Signed-off-by: Oliver Neukum

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 1:54 AM, Jiri Kosina wrote: > On Tue, 9 Jan 2018, Josh Poimboeuf wrote: > >> On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: >> > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: >> > > On Fri, 5 Jan 2018, Dan Williams

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jamal Hadi Salim
On 18-01-11 09:24 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 02:36:01PM CET, j...@mojatatu.com wrote: On 18-01-09 09:07 AM, Jiri Pirko wrote: From: Jiri Pirko Benefit from the previously introduced shared filter blocks infrastructure and allow ingress and clsact qdisc

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 03:46:09PM CET, j...@mojatatu.com wrote: >On 18-01-11 09:41 AM, Jiri Pirko wrote: >> Thu, Jan 11, 2018 at 03:37:08PM CET, j...@mojatatu.com wrote: >> > On 18-01-11 09:24 AM, Jiri Pirko wrote: >> > > Thu, Jan 11, 2018 at 02:36:01PM CET, j...@mojatatu.com wrote: >> > > > On

Re: [PATCH 2/2] xen-netfront: Fix race between device setup and open

2018-01-11 Thread David Miller
From: Ross Lagerwall Date: Thu, 11 Jan 2018 09:36:38 + > When a netfront device is set up it registers a netdev fairly early on, > before it has set up the queues and is actually usable. A userspace tool > like NetworkManager will immediately try to open it and

Re: [PATCH 1/2] xen/grant-table: Use put_page instead of free_page

2018-01-11 Thread Ross Lagerwall
+CC netdev On 01/11/2018 09:36 AM, Ross Lagerwall wrote: The page given to gnttab_end_foreign_access() to free could be a compound page so use put_page() instead of free_page() since it can handle both compound and single pages correctly. This bug was discovered when migrating a Xen VM with

Re: [PATCH 2/2] xen-netfront: Fix race between device setup and open

2018-01-11 Thread Ross Lagerwall
On 01/11/2018 03:26 PM, David Miller wrote: From: Ross Lagerwall Date: Thu, 11 Jan 2018 09:36:38 + When a netfront device is set up it registers a netdev fairly early on, before it has set up the queues and is actually usable. A userspace tool like

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread Geert Uytterhoeven
On Thu, Jan 11, 2018 at 4:53 PM, Russell King - ARM Linux wrote: > On Thu, Jan 11, 2018 at 10:48:35AM -0500, David Miller wrote: >> From: Geert Uytterhoeven >> Date: Tue, 9 Jan 2018 12:11:21 +0100 >> >> > In case of success, the return values of

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread Geert Uytterhoeven
On Thu, Jan 11, 2018 at 4:54 PM, Geert Uytterhoeven wrote: > On Thu, Jan 11, 2018 at 4:53 PM, Russell King - ARM Linux > wrote: >> On Thu, Jan 11, 2018 at 10:48:35AM -0500, David Miller wrote: >>> From: Geert Uytterhoeven >>>

Re: [patch iproute2 v8 1/2] lib/libnetlink: Add functions rtnl_talk_msg and rtnl_talk_iov

2018-01-11 Thread Phil Sutter
On Wed, Jan 10, 2018 at 09:12:45PM +0100, Phil Sutter wrote: > On Wed, Jan 10, 2018 at 12:20:36PM -0700, David Ahern wrote: > [...] > > 2. I am using a batch file with drop filters: > > > > filter add dev eth2 ingress protocol ip pref 273 flower dst_ip > > 192.168.253.0/16 action drop > > > >

Re: [PATCH 30/32] aio: add delayed cancel support

2018-01-11 Thread Jeff Moyer
Christoph Hellwig writes: > On Wed, Jan 10, 2018 at 06:26:39PM -0500, Jeff Moyer wrote: >> >> The upcoming aio poll support would like to be able to complete the >> >> iocb inline from the cancellation context, but that would cause >> >> a lock order reversal. Add support for

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Roopa Prabhu
On Thu, Jan 11, 2018 at 7:07 AM, Jiri Pirko wrote: > Thu, Jan 11, 2018 at 03:46:09PM CET, j...@mojatatu.com wrote: >>On 18-01-11 09:41 AM, Jiri Pirko wrote: >>> Thu, Jan 11, 2018 at 03:37:08PM CET, j...@mojatatu.com wrote: >>> > On 18-01-11 09:24 AM, Jiri Pirko wrote: >>> > >

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jamal Hadi Salim
On 18-01-11 10:07 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 03:46:09PM CET, j...@mojatatu.com wrote: On 18-01-11 09:41 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 03:37:08PM CET, j...@mojatatu.com wrote: I only looked at the kernel code. Good you can stop it at tc but the API does not stop

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 9 Jan 2018 12:11:21 +0100 > In case of success, the return values of (__)phy_write() and > (__)phy_modify() are not compatible: (__)phy_write() returns 0, while > (__)phy_modify() returns the old PHY register value. > > Apparently

Re: [PATCH 0/2] Fix a couple of crashes in netfront

2018-01-11 Thread Ross Lagerwall
+CC netdev On 01/11/2018 09:36 AM, Ross Lagerwall wrote: Here are a couple of patches to fix two crashes in netfront. Ross Lagerwall (2): xen/grant-table: Use put_page instead of free_page xen-netfront: Fix race between device setup and open drivers/net/xen-netfront.c | 46

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread Russell King - ARM Linux
On Thu, Jan 11, 2018 at 10:48:35AM -0500, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 9 Jan 2018 12:11:21 +0100 > > > In case of success, the return values of (__)phy_write() and > > (__)phy_modify() are not compatible: (__)phy_write() returns 0, while >

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jiri Pirko
Thu, Jan 11, 2018 at 03:37:08PM CET, j...@mojatatu.com wrote: >On 18-01-11 09:24 AM, Jiri Pirko wrote: >> Thu, Jan 11, 2018 at 02:36:01PM CET, j...@mojatatu.com wrote: >> > On 18-01-09 09:07 AM, Jiri Pirko wrote: >> > > From: Jiri Pirko >> > > >> > > Benefit from the

Re: [PATCH bpf-next v4 5/5] error-injection: Support fault injection framework

2018-01-11 Thread Akinobu Mita
2018-01-11 9:51 GMT+09:00 Masami Hiramatsu : > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Here is the result of test script described in >

Re: [PATCH V2] ipvlan: fix ipvlan MTU limits

2018-01-11 Thread महेश बंडेवार
On Thu, Jan 11, 2018 at 3:25 AM, Jiri Benc wrote: > On Wed, 10 Jan 2018 18:09:50 -0800, Mahesh Bandewar (महेश बंडेवार) wrote: >> I still prefer the approach I had mentioned that uses 'mtu_adj'. In >> that approach you can leave those slaves which have changed their mtu >> to be

Re: [patch net-next v7 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks

2018-01-11 Thread Jamal Hadi Salim
On 18-01-11 11:15 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 04:44:32PM CET, j...@mojatatu.com wrote: On 18-01-11 10:07 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 03:46:09PM CET, j...@mojatatu.com wrote: On 18-01-11 09:41 AM, Jiri Pirko wrote: Thu, Jan 11, 2018 at 03:37:08PM CET,

  1   2   3   >