[PATCH 2/3] tls: reset the crypto info if copy_from_user fails

2018-02-14 Thread Boris Pismenny
copy_from_user could copy some partial information, as a result TLS_CRYPTO_INFO_READY(crypto_info) could be true while crypto_info is using uninitialzed data. This patch resets crypto_info when copy_from_user fails. fixes: 3c4d7559159b ("tls: kernel TLS support") Signed-off-by: Boris Pismenny

[PATCH 1/3] tls: retrun the correct IV in getsockopt

2018-02-14 Thread Boris Pismenny
Current code returns four bytes of salt followed by four bytes of IV. This patch returns all eight bytes of IV. fixes: 3c4d7559159b ("tls: kernel TLS support") Signed-off-by: Boris Pismenny --- net/tls/tls_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 3/3] tls: getsockopt return record sequence number

2018-02-14 Thread Boris Pismenny
Return the TLS record sequence number in getsockopt. Signed-off-by: Boris Pismenny --- net/tls/tls_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index c105f86..e9b4b53 100644 --- a/net/tls/tls_main.c +++

Re: [PATCH ipsec,v3] net: xfrm_policy: fix device unregistration hang

2018-02-14 Thread Steffen Klassert
On Tue, Feb 13, 2018 at 08:23:14PM +0200, Eyal Birger wrote: > Hi Xin Long, > > On Tue, 13 Feb 2018 23:18:14 +0800 > Xin Long wrote: > > > On Tue, Feb 13, 2018 at 6:54 PM, Eyal Birger > > wrote: > > > In setups like the following: > > > > > >

Re: WARNING in kvmalloc_node

2018-02-14 Thread Michal Hocko
On Wed 14-02-18 19:47:30, Jason Wang wrote: > > > On 2018年02月14日 17:28, Daniel Borkmann wrote: > > [ +Jason, +Jesper ] > > > > On 02/14/2018 09:43 AM, Michal Hocko wrote: > > > On Tue 13-02-18 18:55:33, Matthew Wilcox wrote: > > > > On Tue, Feb 13, 2018 at 03:59:01PM -0800, syzbot wrote: > > >

Re: [PATCH net-next 2/2] tun: Add ioctl() SIOCGSKNS cmd to allow obtaining net ns of tun device

2018-02-14 Thread kbuild test robot
Hi Kirill, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Kirill-Tkhai/net-Make-extern-and-export-get_net_ns/20180214-183342 config: x86_64-lkp (attached as .config) compiler: gcc-7 (Debian 7.3.0-1

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Eric Dumazet
On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > syzbot reported a division by 0 bug in the netfilter nat code: ... > Adding the relevant check at parse time could break existing > setup, moreover we would need to read/write such values atomically > to avoid possible transient negative

Re: [PATCH 3/3] docs: segmentation-offloads.txt: add SCTP info

2018-02-14 Thread Marcelo Ricardo Leitner
On Wed, Feb 14, 2018 at 06:05:33PM +1100, Daniel Axtens wrote: > Most of this is extracted from 90017accff61 ("sctp: Add GSO support"), > with some extra text about GSO_BY_FRAGS and the need to check for it. > > Cc: Marcelo Ricardo Leitner > Signed-off-by: Daniel

ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Denys Fedoryshchenko
Hi, Upgraded kernel to 4.15.3, still it crashes after while (several hours, cannot do bisect, as it is production server). dev ppp # gdb ppp_generic.o GNU gdb (Gentoo 7.12.1 vanilla) 7.12.1 <> Reading symbols from ppp_generic.o...done. (gdb) list *ppp_push+0x73 0x681 is in ppp_push

Re: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-14 Thread Eric Dumazet
On Wed, 2018-02-14 at 13:50 +0100, Jon Maloy wrote: > A received sk buffer may contain dozens of smaller 'bundled' messages > which after extraction go each in their own direction. > > Unfortunately, when we extract those messages using skb_clone() each > of the extracted buffers inherit the

[PATCH] ss: prepare rth when killing inet sock

2018-02-14 Thread Masatake YAMATO
kill_inet_sock() expects rhn_handle instance is passed via inet_diag_arg argument. However on the following calling path: generic_show_sock => show_one_inet_sock => kill_inet_sock rth field of inet_diag_arg is not filled with the address of rhn_handle instance. As the result ss

[PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Paolo Abeni
syzbot reported a division by 0 bug in the netfilter nat code: divide error: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 1 PID: 4168 Comm: syzkaller034710 Not tainted 4.16.0-rc1+ #309 Hardware name: Google Google Compute Engine/Google Compute

Re: [PATCH] esp4: remove redundant initialization of pointer esph

2018-02-14 Thread Steffen Klassert
On Fri, Feb 02, 2018 at 08:37:50AM +0100, Steffen Klassert wrote: > On Tue, Jan 30, 2018 at 02:53:48PM +, Colin King wrote: > > From: Colin Ian King > > > > Pointer esph is being assigned a value that is never read, esph is > > re-assigned and only read inside an if

[net-next 1/1] tipc: apply bearer link tolerance on running links

2018-02-14 Thread Jon Maloy
Currently, the default link tolerance set in struct tipc_bearer only has effect on links going up after that moment. I.e., a user has to reset all the node's links across that bearer to have the new value applied. This is too limiting and disturbing on a running cluster to be useful. We now

Re: WARNING in kvmalloc_node

2018-02-14 Thread Jason Wang
On 2018年02月14日 20:29, Jesper Dangaard Brouer wrote: On Wed, 14 Feb 2018 13:17:18 +0100 Daniel Borkmann wrote: On 02/14/2018 01:02 PM, Jason Wang wrote: On 2018年02月14日 19:51, Michal Hocko wrote: On Wed 14-02-18 19:47:30, Jason Wang wrote: On 2018年02月14日 17:28, Daniel

Re: WARNING in kvmalloc_node

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 01:47 PM, Jason Wang wrote: > On 2018年02月14日 20:29, Jesper Dangaard Brouer wrote: >> On Wed, 14 Feb 2018 13:17:18 +0100 >> Daniel Borkmann wrote: >>> On 02/14/2018 01:02 PM, Jason Wang wrote: On 2018年02月14日 19:51, Michal Hocko wrote: > On Wed 14-02-18

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Florian Westphal
Eric Dumazet wrote: > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > syzbot reported a division by 0 bug in the netfilter nat code: > > > Adding the relevant check at parse time could break existing > > setup, moreover we would need to read/write such values

Re: [PATCH net] tuntap: try not batch packets for devmap

2018-02-14 Thread Michael S. Tsirkin
On Wed, Feb 14, 2018 at 11:36:05AM +0800, Jason Wang wrote: > Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the > devmap stall caused by missed xdp flush by counting the pending xdp > redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or > MSG_MORE is clear. This

Re: [PATCH net-next 2/2] tun: Add ioctl() SIOCGSKNS cmd to allow obtaining net ns of tun device

2018-02-14 Thread Kirill Tkhai
On 14.02.2018 15:27, kbuild test robot wrote: > Hi Kirill, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Kirill-Tkhai/net-Make-extern-and-export-get_net_ns/

Re: KASAN: use-after-free Read in get_work_pool

2018-02-14 Thread Dmitry Vyukov
On Wed, Dec 6, 2017 at 1:50 PM, Dmitry Vyukov wrote: > On Fri, Oct 27, 2017 at 11:18 PM, Cong Wang wrote: >> On Thu, Oct 26, 2017 at 11:00 PM, Dmitry Vyukov wrote: >>> On Thu, Oct 26, 2017 at 7:58 PM, Tejun Heo

Re: [PATCH] ravb: add support for changing MTU

2018-02-14 Thread Sergei Shtylyov
Hello! On 02/13/2018 04:12 PM, Niklas Söderlund wrote: >> On 02/12/2018 11:00 PM, Niklas Söderlund wrote: >> >>> Allow for chancing the MTU within the limit of the maximum size of a >> >>Changing. :-) > > Yes :-) > >>> descriptor (2048 bytes). Add the callback to change MTU from user-space

Re: WARNING in kvmalloc_node

2018-02-14 Thread Jason Wang
On 2018年02月14日 19:51, Michal Hocko wrote: On Wed 14-02-18 19:47:30, Jason Wang wrote: On 2018年02月14日 17:28, Daniel Borkmann wrote: [ +Jason, +Jesper ] On 02/14/2018 09:43 AM, Michal Hocko wrote: On Tue 13-02-18 18:55:33, Matthew Wilcox wrote: On Tue, Feb 13, 2018 at 03:59:01PM -0800,

Re: WARNING in kvmalloc_node

2018-02-14 Thread Jesper Dangaard Brouer
On Wed, 14 Feb 2018 13:17:18 +0100 Daniel Borkmann wrote: > On 02/14/2018 01:02 PM, Jason Wang wrote: > > On 2018年02月14日 19:51, Michal Hocko wrote: > >> On Wed 14-02-18 19:47:30, Jason Wang wrote: > >>> On 2018年02月14日 17:28, Daniel Borkmann wrote: > [ +Jason,

Re: WARNING: kmalloc bug in bpf_prog_array_copy_info

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 12:59 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on bpf-next commit > 7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (Sun Feb 11 23:04:29 2018 +) > Linux 4.16-rc1 > > So far this crash happened 362 times on bpf-next. > C reproducer is attached. > syzkaller

Re: [PATCH v2 2/2] net: phy: dp83867: Add documentation for CLK_OUT pin muxing

2018-02-14 Thread Andrew Lunn
On Wed, Feb 14, 2018 at 01:23:39PM +0100, Daniel Schultz wrote: > From: Wadim Egorov > > Add documentation of ti,clk-output-sel which can be used to select > a specific clock for CLK_OUT. > > Signed-off-by: Wadim Egorov > Signed-off-by: Daniel Schultz

Re: [bisected] Forwarded packets occasionally has loopback output interface in Netfilter

2018-02-14 Thread Anders K. Pedersen | Cohaesio
On man, 2018-01-22 at 15:54 +0100, Anders K. Pedersen | Cohaesio wrote: > On tor, 2018-01-11 at 10:18 -0800, Wei Wang wrote: > > On Thu, Jan 11, 2018 at 9:25 AM, Anders K. Pedersen | Cohaesio > > wrote: > > > On tir, 2017-12-26 at 12:05 +0100, Anders K. Pedersen | Cohaesio > >

[PATCH net-next v2 1/3] net: Make extern and export get_net_ns()

2018-02-14 Thread Kirill Tkhai
This function will be used to obtain net of tun device. Signed-off-by: Kirill Tkhai --- include/linux/socket.h |2 ++ net/socket.c |3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/socket.h b/include/linux/socket.h index

[PATCH net-next v2 0/3] Add ioctl() SIOCGSKNS cmd to allow obtaining net ns of tun device

2018-02-14 Thread Kirill Tkhai
Currently, it's not possible to get or check net namespace, which was used to create tun socket. User may have two tun devices with the same names in different nets, and there is no way to differ them each other. The patchset adds support for ioctl() cmd SIOCGSKNS for tun devices. It will allow

Re: [PATCH ipsec] xfrm_user: uncoditionally validate esn replay attribute struct

2018-02-14 Thread Steffen Klassert
On Mon, Feb 12, 2018 at 02:42:01PM +0100, Florian Westphal wrote: > The sanity test added in ecd7918745234 can be bypassed, validation > only occurs if XFRM_STATE_ESN flag is set, but rest of code doesn't care > and just checks if the attribute itself is present. > > So always validate.

Re: WARNING in kvmalloc_node

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 01:02 PM, Jason Wang wrote: > On 2018年02月14日 19:51, Michal Hocko wrote: >> On Wed 14-02-18 19:47:30, Jason Wang wrote: >>> On 2018年02月14日 17:28, Daniel Borkmann wrote: [ +Jason, +Jesper ] On 02/14/2018 09:43 AM, Michal Hocko wrote: > On Tue 13-02-18 18:55:33,

[PATCH v2 2/2] net: phy: dp83867: Add documentation for CLK_OUT pin muxing

2018-02-14 Thread Daniel Schultz
From: Wadim Egorov Add documentation of ti,clk-output-sel which can be used to select a specific clock for CLK_OUT. Signed-off-by: Wadim Egorov Signed-off-by: Daniel Schultz --- Documentation/devicetree/bindings/net/ti,dp83867.txt

[PATCH v2 1/2] net: phy: dp83867: Add binding for the CLK_OUT pin muxing option

2018-02-14 Thread Daniel Schultz
From: Wadim Egorov The DP83867 has a muxing option for the CLK_OUT pin. It is possible to set CLK_OUT for different channels. Create a binding to select a specific clock for CLK_OUT pin. Signed-off-by: Wadim Egorov Signed-off-by: Daniel Schultz

[net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-14 Thread Jon Maloy
A received sk buffer may contain dozens of smaller 'bundled' messages which after extraction go each in their own direction. Unfortunately, when we extract those messages using skb_clone() each of the extracted buffers inherit the truesize value of the original buffer. Apart from causing massive

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Eric Dumazet
On Wed, 2018-02-14 at 13:30 +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > > syzbot reported a division by 0 bug in the netfilter nat code: > > > Adding the relevant check at parse time could break

Re: [PATCH] ravb: add support for changing MTU

2018-02-14 Thread Niklas Söderlund
Hi Sergei, Thanks for your feedback. On 2018-02-14 14:34:09 +0300, Sergei Shtylyov wrote: > Hello! > > On 02/13/2018 04:12 PM, Niklas Söderlund wrote: > > >> On 02/12/2018 11:00 PM, Niklas Söderlund wrote: > >> > >>> Allow for chancing the MTU within the limit of the maximum size of a > >> >

Re: [PATCH net-next 1/2] net: netfilter: export xt_policy match_policy_in() as xt_policy_match_policy_in()

2018-02-14 Thread Eyal Birger
Hi Pablo, On Mon, 15 Jan 2018 13:48:41 +0200 Eyal Birger wrote: > On Mon, Jan 15, 2018 at 12:57 PM, Pablo Neira Ayuso > wrote: > > On Sun, Jan 14, 2018 at 02:47:46PM +0200, Eyal Birger wrote: > >> On Fri, Jan 12, 2018 at 4:00 PM, Pablo Neira Ayuso

[PATCH iproute2 6/7] devlink: Add support for resource/dpipe relation

2018-02-14 Thread Arkadi Sharshevsky
Dpipe - Each dpipe table can have one resource which is mapped to it. The resource is presented via its full path. Furthermore, the number of units consumed by single table entry is presented. Resource - Each resource presents the dpipe tables that use it. Signed-off-by: Arkadi Sharshevsky

[PATCH iproute2 7/7] devlink: Update man pages and add resource man

2018-02-14 Thread Arkadi Sharshevsky
Add resource man, and update dev manual for reload command. Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- man/man8/devlink-dev.8 | 15 + man/man8/devlink-resource.8 | 78 +

Re: [PATCH net-next 1/2] net: netfilter: export xt_policy match_policy_in() as xt_policy_match_policy_in()

2018-02-14 Thread Pablo Neira Ayuso
On Wed, Feb 14, 2018 at 10:14:24AM +0200, Eyal Birger wrote: > Hi Pablo, > > On Mon, 15 Jan 2018 13:48:41 +0200 > Eyal Birger wrote: > > > On Mon, Jan 15, 2018 at 12:57 PM, Pablo Neira Ayuso > > wrote: > > > On Sun, Jan 14, 2018 at 02:47:46PM +0200,

[PATCH iproute2 3/7] devlink: Add support for devlink resource abstraction

2018-02-14 Thread Arkadi Sharshevsky
Add support for devlink resource abstraction. The resources are represented by a tree based structure and are identified by a name and a size. Some resources can present their real time occupancy. First the resources exposed by the driver can be observed, for example: $devlink resource show

[PATCH iproute2 1/7] devlink: Change empty line indication with indentations

2018-02-14 Thread Arkadi Sharshevsky
Currently multi-line objects are separated by new-lines. This patch changes this behavior by using indentations for separation. Signed-off-by: Arkadi Sharhsevsky Acked-by: Jiri Pirko --- devlink/devlink.c | 23 --- 1 file changed, 16

[PATCH iproute2 0/7] Add support for devlink resource abstraction

2018-02-14 Thread Arkadi Sharshevsky
Add support for devlink resource abstraction. Arkadi Sharshevsky (7): devlink: Change empty line indication with indentations devlink: mnlg: Add support for extended ack devlink: Add support for devlink resource abstraction devlink: Add support for hot reload devlink: Move dpipe context

[PATCH iproute2 2/7] devlink: mnlg: Add support for extended ack

2018-02-14 Thread Arkadi Sharshevsky
Add support for extended ack. Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- devlink/mnlg.c | 53 ++-- include/libnetlink.h | 1 + lib/libnetlink.c | 4 ++-- 3 files changed, 54

[PATCH iproute2 4/7] devlink: Add support for hot reload

2018-02-14 Thread Arkadi Sharshevsky
Add support for hot reload. It should be used in order for resource updates to take place. Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- devlink/devlink.c | 29 + 1 file changed, 29 insertions(+) diff --git

[PATCH iproute2 5/7] devlink: Move dpipe context from heap to stack

2018-02-14 Thread Arkadi Sharshevsky
Move dpipe context to stack instead of dynamically. Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- devlink/devlink.c | 67 ++- 1 file changed, 27 insertions(+), 40 deletions(-) diff --git

Re: WARNING in kvmalloc_node

2018-02-14 Thread Daniel Borkmann
[ +Jason, +Jesper ] On 02/14/2018 09:43 AM, Michal Hocko wrote: > On Tue 13-02-18 18:55:33, Matthew Wilcox wrote: >> On Tue, Feb 13, 2018 at 03:59:01PM -0800, syzbot wrote: > [...] >>> kvmalloc include/linux/mm.h:541 [inline] >>> kvmalloc_array include/linux/mm.h:557 [inline] >>>

Re: [PATCH ipsec,v3] net: xfrm_policy: fix device unregistration hang

2018-02-14 Thread Xin Long
On Wed, Feb 14, 2018 at 5:24 PM, Steffen Klassert wrote: > On Tue, Feb 13, 2018 at 08:23:14PM +0200, Eyal Birger wrote: >> Hi Xin Long, >> >> On Tue, 13 Feb 2018 23:18:14 +0800 >> Xin Long wrote: >> >> > On Tue, Feb 13, 2018 at 6:54 PM, Eyal

Re: [net PATCH] Revert "net: thunderx: Add support for xdp redirect"

2018-02-14 Thread Jesper Dangaard Brouer
On Wed, 14 Feb 2018 01:05:16 +0530 Sunil Kovvuri wrote: > On Tue, Feb 13, 2018 at 10:29 PM, Jesper Dangaard Brouer > wrote: > > This reverts commit aa136d0c82fcd6af14535853c30e219e02b2692d. > > > > As I previously[1] pointed out this implementation of

[PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Sowmini Varadhan
If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg() are pinned. The pinning uses the accounting infrastructure added by Commit a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY

[PATCH V2 net-next 1/7] skbuff: export mm_[un]account_pinned_pages for other modules

2018-02-14 Thread Sowmini Varadhan
RDS would like to use the helper functions for managing pinned pages added by Commit a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY pages") Signed-off-by: Sowmini Varadhan --- include/linux/skbuff.h |3 +++ net/core/skbuff.c |6 -- 2 files changed, 7

[PATCH V2 net-next 4/7] rds: support for zcopy completion notification

2018-02-14 Thread Sowmini Varadhan
RDS removes a datagram (rds_message) from the retransmit queue when an ACK is received. The ACK indicates that the receiver has queued the RDS datagram, so that the sender can safely forget the datagram. When all references to the rds_message are quiesced, rds_message_purge is called to release

[PATCH V2 net-next 3/7] sock: permit SO_ZEROCOPY on PF_RDS socket

2018-02-14 Thread Sowmini Varadhan
allow the application to set SO_ZEROCOPY on the underlying sk of a PF_RDS socket Signed-off-by: Sowmini Varadhan --- net/core/sock.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c

[PATCH V2 net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

2018-02-14 Thread Sowmini Varadhan
Send a cookie with sendmsg() on PF_RDS sockets, and process the returned batched cookies in do_recv_completion() Signed-off-by: Sowmini Varadhan --- v2: - restructured do_recv_completion to avoid excessive code re-indent - on-stack allocation of cmsghdr for

Re: WARNING in kvmalloc_node

2018-02-14 Thread Michal Hocko
On Tue 13-02-18 18:55:33, Matthew Wilcox wrote: > On Tue, Feb 13, 2018 at 03:59:01PM -0800, syzbot wrote: [...] > > kvmalloc include/linux/mm.h:541 [inline] > > kvmalloc_array include/linux/mm.h:557 [inline] > > __ptr_ring_init_queue_alloc include/linux/ptr_ring.h:474 [inline] > >

[RESEND PATCH net-next] r8169: add module param for control of ASPM disable.

2018-02-14 Thread Chunhao Lin
The patch is from Todd Broch . ASPM has been disabled in this driver by default as its been implicated in stability issues on at least one platform. This CL adds a module parameter to allow control of ASPM disable. The default value is to

Re: [PATCH net v4 7/7] tipc: Fix missing RTNL lock protection during setting link properties

2018-02-14 Thread Kirill Tkhai
On 14.02.2018 08:38, Ying Xue wrote: > Currently when user changes link properties, TIPC first checks if > user's command message contains media name or bearer name through > tipc_media_find() or tipc_bearer_find() which is protected by RTNL > lock. But when tipc_nl_compat_link_set() conducts the

[PATCH V2 net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock

2018-02-14 Thread Sowmini Varadhan
The existing model holds a reference from the rds_sock to the rds_message, but the rds_message does not itself hold a sock_put() on the rds_sock. Instead the m_rs field in the rds_message is assigned when the message is queued on the sock, and nulled when the message is dequeued from the sock. We

[PATCH V2 net-next 0/7] RDS: zerocopy support

2018-02-14 Thread Sowmini Varadhan
This is version 2 of the series at https://www.mail-archive.com/netdev@vger.kernel.org/msg213829.html Review comments addressed Patch 4: - make sure to always sock_put m_rs even if there is no znotifier. - major rewrite of notification, resulting in much simplification. Patch 5: -

[PATCH V2 net-next 6/7] selftests/net: add support for PF_RDS sockets

2018-02-14 Thread Sowmini Varadhan
Add support for basic PF_RDS client-server testing in msg_zerocopy Signed-off-by: Sowmini Varadhan --- tools/testing/selftests/net/msg_zerocopy.c | 65 +++- 1 files changed, 64 insertions(+), 1 deletions(-) diff --git

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Jesper Dangaard Brouer
On Wed, 14 Feb 2018 22:17:34 +0800 Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since

Re: [PATCH v4 00/36] Andes(nds32) Linux Kernel

2018-02-14 Thread Arnd Bergmann
On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: > This is the 4th version patchset to add the Linux kernel port for Andes(nds32) > processors. Almost all of the feedbacks from v3 patchseries has been > addressed. > Thanks to everyone who provided feedback on the previous

Re: INFO: rcu detected stall in do_softirq

2018-02-14 Thread Dmitry Vyukov
On Fri, Jan 5, 2018 at 11:14 PM, Dmitry Vyukov wrote: > On Fri, Jan 5, 2018 at 11:10 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 8a4816cad00bf14642f0ed6043b32d29a05006ce >>

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 4:21 PM, Sowmini Varadhan wrote: > On (02/14/18 16:11), Dmitry Vyukov wrote: >> >> Hi Sowmini, >> >> Was this ever fixed? What's the fix? This still hangs as open. Please >> provide "syz fix" tag. > > Are you still seeing this problem? > > I

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Pablo Neira Ayuso
On Wed, Feb 14, 2018 at 04:45:31PM +0100, Paolo Abeni wrote: > Hi, > > On Wed, 2018-02-14 at 14:51 +0100, Pablo Neira Ayuso wrote: > > On Wed, Feb 14, 2018 at 01:30:37PM +0100, Florian Westphal wrote: > > > Eric Dumazet wrote: > > > > On Wed, 2018-02-14 at 12:13 +0100,

[PATCH v3 1/2] net: phy: dp83867: Add binding for the CLK_OUT pin muxing option

2018-02-14 Thread Daniel Schultz
From: Wadim Egorov The DP83867 has a muxing option for the CLK_OUT pin. It is possible to set CLK_OUT for different channels. Create a binding to select a specific clock for CLK_OUT pin. Signed-off-by: Wadim Egorov Signed-off-by: Daniel Schultz

Re: [PATCH v3 1/2] net: phy: dp83867: Add binding for the CLK_OUT pin muxing option

2018-02-14 Thread Andrew Lunn
On Wed, Feb 14, 2018 at 05:07:11PM +0100, Daniel Schultz wrote: > From: Wadim Egorov > > The DP83867 has a muxing option for the CLK_OUT pin. It is possible > to set CLK_OUT for different channels. > Create a binding to select a specific clock for CLK_OUT pin. > >

Re: [PATCH v7 23/37] nds32: Debugging support

2018-02-14 Thread Arnd Bergmann
On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: > This patch adds ptrace support. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu This new version looks good to me, Acked-by: Arnd Bergmann

Re: [PATCH v7 08/37] nds32: Exception handling

2018-02-14 Thread Arnd Bergmann
On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: > This patch includes the exception/interrupt entries, pt_reg structure and > related accessors. > > /* Unaligned accessing handling*/ > Andes processors cannot load/store information which is not naturally > aligned on the

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 03:17 PM, Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since cpumap try to call with

Re: WARNING: kmalloc bug in bpf_prog_array_copy_info

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 01:36 PM, Daniel Borkmann wrote: > On 02/14/2018 12:59 AM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on bpf-next commit >> 7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (Sun Feb 11 23:04:29 2018 +) >> Linux 4.16-rc1 >> >> So far this crash happened 362 times on

Re: INFO: task hung in reg_check_chans_work

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 2:59 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > cbd7b8a76b79a2ff6112ef2e77031b694843b8a1 (Tue Feb 6 23:30:52 2018 +) > Merge tag 'platform-drivers-x86-v4.16-1' of >

[PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Jason Wang
There're several implications after commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails") with the using of vmalloc() since can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN since cpumap try to call with GFP_ATOMIC. Fortunately, entry allocation of cpumap can only

[PATCH bpf] bpf: fix bpf_prog_array_copy_to_user warning from perf event prog query

2018-02-14 Thread Daniel Borkmann
syzkaller tried to perform a prog query in perf_event_query_prog_array() where struct perf_event_query_bpf had an ids_len of 1,073,741,353 and thus causing a warning due to failed kcalloc() allocation out of the bpf_prog_array_copy_to_user() helper. Given we cannot attach more than 64 programs to

Re: [PATCH v7 07/37] nds32: Kernel booting and initialization

2018-02-14 Thread Arnd Bergmann
On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: > This patch includes the kernel startup code. It can get dtb pointer > passed from bootloader. It will create a temp mapping by tlb > instructions at beginning and goto start_kernel. > > Signed-off-by: Vincent Chen

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Michal Hocko
On Wed 14-02-18 22:17:34, Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since cpumap try to call with

Re: [PATCH iproute2 2/7] devlink: mnlg: Add support for extended ack

2018-02-14 Thread Stephen Hemminger
On Wed, 14 Feb 2018 10:55:17 +0200 Arkadi Sharshevsky wrote: > +static mnl_cb_t mnlg_cb_array[NLMSG_MIN_TYPE] = { > + [NLMSG_NOOP]= mnlg_cb_noop, > + [NLMSG_ERROR] = mnlg_cb_error, > + [NLMSG_DONE]= mnlg_cb_stop, > + [NLMSG_OVERRUN] = mnlg_cb_noop,

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Fri, Jan 12, 2018 at 7:30 PM, Sowmini Varadhan wrote: > On (01/11/18 21:29), syzbot wrote: >> == >> BUG: KASAN: use-after-free in rds_tcp_tune+0x491/0x520 net/rds/tcp.c:397 >> Read of size 4 at addr

Re: [PATCH iproute2 1/7] devlink: Change empty line indication with indentations

2018-02-14 Thread Stephen Hemminger
On Wed, 14 Feb 2018 10:55:16 +0200 Arkadi Sharshevsky wrote: > Currently multi-line objects are separated by new-lines. This patch > changes this behavior by using indentations for separation. > > Signed-off-by: Arkadi Sharhsevsky > Acked-by: Jiri

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan wrote: > On (02/14/18 16:28), Dmitry Vyukov wrote: >> syzbot is probably not seeing this problem. However if you don't add >> the Reported-by tag to commit, nor provide syz fix tag, it will >> consider it as "open".

Re: [PATCH v7 30/37] nds32: Build infrastructure

2018-02-14 Thread Arnd Bergmann
On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: > This patch adds Makefile, Kconfig and vmlinux.lds.S files required for > building > an nds32 kernel. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu With

Re: [PATCH v7 03/37] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h

2018-02-14 Thread Arnd Bergmann
On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: > A commit for the nds32 architecture bootstrap("asm-generic/io.h: move > ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU") > will move the ioremap_nocache out of the CONFIG_MMU ifdef. This means

Re: [PATCH iproute2 1/7] devlink: Change empty line indication with indentations

2018-02-14 Thread Jiri Pirko
Wed, Feb 14, 2018 at 04:11:33PM CET, step...@networkplumber.org wrote: >On Wed, 14 Feb 2018 10:55:16 +0200 >Arkadi Sharshevsky wrote: > >> Currently multi-line objects are separated by new-lines. This patch >> changes this behavior by using indentations for separation. >>

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Sowmini Varadhan
On (02/14/18 16:11), Dmitry Vyukov wrote: > > Hi Sowmini, > > Was this ever fixed? What's the fix? This still hangs as open. Please > provide "syz fix" tag. Are you still seeing this problem? I had expected that the changes around rds_destroy_pending - see commit ebeeb1ad9b8a - would have

Re: INFO: task hung in linkwatch_event

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 2:59 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > a2e5790d841658485d642196dbb0927303d6c22f (Wed Feb 7 06:15:42 2018 +) > Merge branch 'akpm' (patches from Andrew) > >

Re: [PATCH net v2] netfilter: nat: cope with negative port range

2018-02-14 Thread Paolo Abeni
Hi, On Wed, 2018-02-14 at 14:51 +0100, Pablo Neira Ayuso wrote: > On Wed, Feb 14, 2018 at 01:30:37PM +0100, Florian Westphal wrote: > > Eric Dumazet wrote: > > > On Wed, 2018-02-14 at 12:13 +0100, Paolo Abeni wrote: > > > > syzbot reported a division by 0 bug in the

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Guillaume Nault
On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fedoryshchenko wrote: > Hi, > > Upgraded kernel to 4.15.3, still it crashes after while (several hours, > cannot do bisect, as it is production server). > > dev ppp # gdb ppp_generic.o > GNU gdb (Gentoo 7.12.1 vanilla) 7.12.1 > <> > Reading symbols

[PATCH v3 2/2] net: phy: dp83867: Add documentation for CLK_OUT pin muxing

2018-02-14 Thread Daniel Schultz
From: Wadim Egorov Add documentation of ti,clk-output-sel which can be used to select a specific clock for CLK_OUT. Signed-off-by: Wadim Egorov Signed-off-by: Daniel Schultz --- Changes: v2: - v3:

Re: [PATCH] ss: prepare rth when killing inet sock

2018-02-14 Thread Stephen Hemminger
On Wed, 14 Feb 2018 22:50:04 +0900 Masatake YAMATO wrote: > kill_inet_sock() expects rhn_handle instance is passed > via inet_diag_arg argument. However on the following calling path: > > generic_show_sock > => show_one_inet_sock >=> kill_inet_sock > > rth

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Sowmini Varadhan
On (02/14/18 16:28), Dmitry Vyukov wrote: > syzbot is probably not seeing this problem. However if you don't add > the Reported-by tag to commit, nor provide syz fix tag, it will > consider it as "open". One consequence of this is that it is still on > our radars. Another consequence is that

Re: [PATCH net] netfilter: xt_hashlimit: fix lock imbalance

2018-02-14 Thread Vishwanath Pai
On 02/12/2018 11:11 AM, Eric Dumazet wrote: > From: Eric Dumazet > > syszkaller found that rcu was not held in hashlimit_mt_common() > > We only need to enable BH at this point. > > Fixes: bea74641e378 ("netfilter: xt_hashlimit: add rate match mode") > Signed-off-by: Eric

Re: KASAN: use-after-free Read in rds_find_bound

2018-02-14 Thread Santosh Shilimkar
On 2/13/2018 12:12 PM, Dmitry Vyukov wrote: On Sat, Dec 30, 2017 at 8:41 PM, santosh.shilim...@oracle.com wrote: On 12/30/17 1:17 AM, syzbot wrote: Hello, syzkaller hit the following crash on fba961ab29e5ffb055592442808bb0f7962e05da

Re: [PATCH bpf] bpf: fix bpf_prog_array_copy_to_user warning from perf event prog query

2018-02-14 Thread Alexei Starovoitov
On Wed, Feb 14, 2018 at 03:31:00PM +0100, Daniel Borkmann wrote: > syzkaller tried to perform a prog query in perf_event_query_prog_array() > where struct perf_event_query_bpf had an ids_len of 1,073,741,353 and > thus causing a warning due to failed kcalloc() allocation out of the >

Re: lost connection to test machine (4)

2018-02-14 Thread Dennis Zhou
On Mon, Feb 12, 2018 at 06:00:13PM +0100, Daniel Borkmann wrote: > > [ +Dennis, +Tejun ] > > Looks like we're stuck in percpu allocator with key/value size of 4 bytes > each and large number of entries (max_entries) in the reproducer in above > link. > > Could we have some __GFP_NORETRY

Re: KASAN: use-after-free Read in rds_find_bound

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 5:53 PM, Santosh Shilimkar wrote: >>> On 12/30/17 1:17 AM, syzbot wrote: Hello, syzkaller hit the following crash on fba961ab29e5ffb055592442808bb0f7962e05da

[net-next 10/12] virtchnl: Add filter data structures

2018-02-14 Thread Jeff Kirsher
From: Harshitha Ramamurthy This patch adds infrastructure to send virtchnl messages to the PF to configure filters on the VF. The patch adds a struct called virtchnl_filter which contains information about the fields in the user-specified tc filter.

[net-next 04/12] i40e: Enable ADq and create queue channel/s on VF

2018-02-14 Thread Jeff Kirsher
From: Avinash Dayanand This patch enables ADq and creates queue channels on a VF. An ADq enabled VF can have up to 4 VSIs and each one of them represents a traffic class and this is termed as a queue channel. Each of these VSIs can have up to 4 queues. This patch

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 06:04 PM, Michael S. Tsirkin wrote: > On Wed, Feb 14, 2018 at 10:17:34PM +0800, Jason Wang wrote: >> There're several implications after commit 0bf7800f1799 ("ptr_ring: >> try vmalloc() when kmalloc() fails") with the using of vmalloc() since >> can't allow GFP_ATOMIC but mandate

Re: [PATCH net] fib_semantics: Don't match route with mismatching tclassid

2018-02-14 Thread David Ahern
On 2/14/18 10:28 AM, Stefano Brivio wrote: > In fib_nh_match(), if output interface or gateway are passed in > the FIB configuration, we don't have to check next hops of > multipath routes to conclude whether we have a match or not. > > However, we might still have routes with different realms >

[net-next 07/12] i40evf: Add support to configure bw via tc tool

2018-02-14 Thread Jeff Kirsher
From: Harshitha Ramamurthy This patch adds support to configure bandwidth for the traffic classes via tc tool. The required information is passed to the PF which is used in the process of setting up the traffic classes. Signed-off-by: Harshitha Ramamurthy

[net-next 05/12] i40evf: Alloc queues for ADq on VF

2018-02-14 Thread Jeff Kirsher
From: Avinash Dayanand This patch allocates number of queues requested by the user as a part of TC command when ADq is enabled on a VF. In order to be consistent in design with PF implementation of ADq, don't allow to set channels via ethtool from VF when ADq is

  1   2   3   >