Re: [PATCH][next] wil6210: fix spelling mistake: "preperation"-> "preparation"

2018-02-16 Thread merez
On 2018-01-30 21:27, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in debug error message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/wil6210/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6

Re: INFO: task hung in tun_chr_close

2018-02-16 Thread Dmitry Vyukov
On Fri, Feb 16, 2018 at 9:23 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 1388c80438e69fc01d83fbe98da3cac24c3c8731 (Thu Feb 15 17:28:47 2018 +) > Merge branch 'sched-urgent-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > > Unfortuna

[PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege_events

2018-02-16 Thread Xin Long
Commit fb23403536ea ("sctp: remove the useless check in sctp_renege_events") forgot to remove another check for chunk in sctp_renege_events. Dan found this when doing a static check. This patch is to remove that check, and also to merge two checks into one 'if statement'. Fixes: fb23403536ea ("s

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

2018-02-16 Thread kbuild test robot
Hi Greentime, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc1 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: Commit 05cf0d1bf4 ("net: stmmac: free an skb first when there are no longer any descriptors using it") breaks stmmac?

2018-02-16 Thread Jose Abreu
Hi Niklas, Thank you for looking into this! On 13-02-2018 13:33, Niklas Cassel wrote: > Hello Jose, > > > I remember that you had a problem > with a use after free in stmmac_tx_clean(). > I still don't think that it is related to > commit 05cf0d1bf4, however, when comparing > the stmmac driver to

Information

2018-02-16 Thread Ahmed Zama
Dear Friend, Please confirm back, can your account receive huge amount? Reply so we can discuss details and what will be your commission; Ahmed Zama

Re: [PATCH net] xfrm: reuse uncached_list to track xdsts

2018-02-16 Thread Steffen Klassert
On Thu, Feb 15, 2018 at 03:31:45PM -0500, David Miller wrote: > From: Xin Long > Date: Wed, 14 Feb 2018 19:06:02 +0800 > > > In early time, when freeing a xdst, it would be inserted into > > dst_garbage.list first. Then if it's refcnt was still held > > somewhere, later it would be put into dst_b

[PATCH net-next] tun: export flags, uid, gid, queue information over netlink

2018-02-16 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Stefano Brivio --- drivers/net/tun.c| 56 include/uapi/linux/if_link.h | 18 ++ 2 files changed, 74 insertions(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 81e6cc951e7

[PATCH iproute2-next] ip link: add support to display extended tun attributes

2018-02-16 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Stefano Brivio --- I included the uapi changes from the kernel patch. Let me know if I need to resend without the header changes. include/uapi/linux/if_link.h | 18 ++ ip/iptuntap.c| 85

[PATCH net] netfilter: unlock xt_table earlier in __do_replace

2018-02-16 Thread Xin Long
Now it's doing cleanup_entry for oldinfo under the xt_table lock, but it's not really necessary. After the replacement job is done in xt_replace_table, oldinfo is not used elsewhere any more, and it can be freed without xt_table lock safely. The important thing is that rtnl_lock is called in some

Re: Serious performance degradation in Linux 4.15

2018-02-16 Thread Peter Zijlstra
On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > Peter, if you want to run this test yourself you can do: > > 1. git clone https://github.com/gorman/mmmtests.git root@ivb-ep:/usr/local/src# git clone https://github.com/gorman/mmmtests.git Cloning into 'mmmtests'... Username for 'h

Re: Commit 05cf0d1bf4 ("net: stmmac: free an skb first when there are no longer any descriptors using it") breaks stmmac?

2018-02-16 Thread Niklas Cassel
On Fri, Feb 16, 2018 at 09:34:39AM +, Jose Abreu wrote: > Hi Niklas, > > Thank you for looking into this! > > On 13-02-2018 13:33, Niklas Cassel wrote: > > Hello Jose, > > > > > > I remember that you had a problem > > with a use after free in stmmac_tx_clean(). > > I still don't think that it

Re: Serious performance degradation in Linux 4.15

2018-02-16 Thread Peter Zijlstra
On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > 3. ./run-mmtests.sh > --config=configs/config-global-dhp__network-netperf-unbound `uname -r` Not a success.. firstly it attempts to install packages without asking and then horribly fails at it.. root@ivb-ep:/usr/local/src/mmtests

Re: [PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege_events

2018-02-16 Thread Marcelo Ricardo Leitner
On Fri, Feb 16, 2018 at 05:18:33PM +0800, Xin Long wrote: > Commit fb23403536ea ("sctp: remove the useless check in > sctp_renege_events") forgot to remove another check for > chunk in sctp_renege_events. > > Dan found this when doing a static check. > > This patch is to remove that check, and al

Re: Serious performance degradation in Linux 4.15

2018-02-16 Thread Mel Gorman
On Fri, Feb 16, 2018 at 11:17:01AM +0100, Peter Zijlstra wrote: > On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > > 3. ./run-mmtests.sh > > --config=configs/config-global-dhp__network-netperf-unbound `uname -r` > > Not a success.. firstly it attempts to install packages without a

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

2018-02-16 Thread kbuild test robot
Hi Greentime, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc1 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH net] netfilter: unlock xt_table earlier in __do_replace

2018-02-16 Thread Florian Westphal
Xin Long wrote: > Now it's doing cleanup_entry for oldinfo under the xt_table lock, > but it's not really necessary. After the replacement job is done > in xt_replace_table, oldinfo is not used elsewhere any more, and > it can be freed without xt_table lock safely. Right. > The important thing i

[PATCH] ptr_ring: Remove now-redundant smp_read_barrier_depends()

2018-02-16 Thread Andrea Parri
Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in __ptr_ring_consume() is redundant; this commit removes it and updates the comments. Signed-off-by: Andrea Parri Cc: "David S. Miller" Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: John Fastabend Cc: Er

Re: [PATCH] inet: don't call skb_orphan if tproxy happens in layer 2

2018-02-16 Thread Florian Westphal
Gregory Vander Schueren wrote: [ cc netdev ] > If sysctl bridge-nf-call-iptables is enabled, iptables chains are already > traversed from the bridging code. In such case, tproxy already happened when > reaching ip_rcv. Thus no need to call skb_orphan as this would actually undo > tproxy. I don'

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-16 Thread Denys Fedoryshchenko
On 2018-02-15 21:42, Guillaume Nault wrote: On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:31, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 17:55, Guillaume Nault wrote: > > > On Thu, Feb

Re: [PATCH net] netfilter: unlock xt_table earlier in __do_replace

2018-02-16 Thread Xin Long
On Fri, Feb 16, 2018 at 12:02 PM, Florian Westphal wrote: > Xin Long wrote: >> Now it's doing cleanup_entry for oldinfo under the xt_table lock, >> but it's not really necessary. After the replacement job is done >> in xt_replace_table, oldinfo is not used elsewhere any more, and >> it can be fre

Re: [PATCH] inet: don't call skb_orphan if tproxy happens in layer 2

2018-02-16 Thread Pablo Neira Ayuso
On Fri, Feb 16, 2018 at 12:07:06PM +0100, Florian Westphal wrote: > Gregory Vander Schueren wrote: > > [ cc netdev ] > > > If sysctl bridge-nf-call-iptables is enabled, iptables chains are already > > traversed from the bridging code. In such case, tproxy already happened when > > reaching ip_rc

Re: [PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege_events

2018-02-16 Thread Neil Horman
On Fri, Feb 16, 2018 at 05:18:33PM +0800, Xin Long wrote: > Commit fb23403536ea ("sctp: remove the useless check in > sctp_renege_events") forgot to remove another check for > chunk in sctp_renege_events. > > Dan found this when doing a static check. > > This patch is to remove that check, and al

Re: [PATCH V6 2/4] sctp: Add ip option support

2018-02-16 Thread Marcelo Ricardo Leitner
On Thu, Feb 15, 2018 at 09:15:40AM -0500, Neil Horman wrote: > On Tue, Feb 13, 2018 at 08:54:44PM +, Richard Haines wrote: > > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > > and CALIPSO/IPv6 services. > > > > Signed-off-by: Richard Haines > > --- > > include/ne

[PATCH RFC 1/4] modules: allow insmod load regular elf binaries

2018-02-16 Thread Daniel Borkmann
From: Alexei Starovoitov Signed-off-by: Alexei Starovoitov --- fs/exec.c | 40 +++- include/linux/binfmts.h | 1 + include/linux/umh.h | 4 kernel/module.c | 33 - kernel/umh.c| 24 +

[PATCH RFC 0/4] net: add bpfilter

2018-02-16 Thread Daniel Borkmann
This is a very rough and early proof of concept that implements bpfilter. The basic idea of bpfilter is that it can process iptables queries and translate them in user space into BPF programs which can then get attached at various locations. For simplicity, in this RFC we demo attaching them to XDP

[PATCH RFC 4/4] bpf: rough bpfilter codegen example hack

2018-02-16 Thread Daniel Borkmann
Signed-off-by: Daniel Borkmann --- include/uapi/linux/bpf.h| 31 +++-- kernel/bpf/syscall.c| 39 +++--- net/bpfilter/Makefile | 2 +- net/bpfilter/bpfilter.c | 59 + net/bpfilter/bpfilter_mod.h | 285 ++- net/bpfilter/ctor

[PATCH RFC 2/4] bpf: introduce bpfilter commands

2018-02-16 Thread Daniel Borkmann
From: Alexei Starovoitov Signed-off-by: Alexei Starovoitov --- include/uapi/linux/bpf.h | 16 kernel/bpf/syscall.c | 41 + 2 files changed, 57 insertions(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index db6bd

Re: [PATCH net] tg3: APE heartbeat changes

2018-02-16 Thread Mauro Rodrigues
On Fri, Feb 16, 2018 at 11:22:43AM +0530, Satish Baddipadige wrote: > From: Prashant Sreedharan > > In ungraceful host shutdown or driver crash case BMC connectivity is > lost. APE firmware is missing the driver state in this > case to keep the BMC connectivity alive. > This patch has below chang

[PATCH RFC 3/4] net: initial bpfilter skeleton

2018-02-16 Thread Daniel Borkmann
From: "David S. Miller" Signed-off-by: David S. Miller Signed-off-by: Alexei Starovoitov --- include/linux/bpfilter.h | 13 +++ include/uapi/linux/bpfilter.h | 200 ++ net/Kconfig | 2 + net/Makefile | 1 + ne

Re: [PATCH net] netfilter: xt_hashlimit: fix lock imbalance

2018-02-16 Thread Pablo Neira Ayuso
On Mon, Feb 12, 2018 at 08:11:48AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > syszkaller found that rcu was not held in hashlimit_mt_common() > > We only need to enable BH at this point. Applied, thanks Eric! Sorry, this didn't get into my patchwork [1] for some reason, so it got lost

Re: Serious performance degradation in Linux 4.15

2018-02-16 Thread Matt Fleming
On Wed, 14 Feb, at 10:46:20PM, Matt Fleming wrote: > On Mon, 12 Feb, at 04:16:42PM, Peter Zijlstra wrote: > > On Fri, Feb 09, 2018 at 05:59:12PM +, Jon Maloy wrote: > > > Command for TCP: > > > "netperf TCP_STREAM (netperf -n 4 -f m -c 4 -C 4 -P 1 -H 10.0.0.1 -t > > > TCP_STREAM -l 10 -- -O T

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-16 Thread Florian Westphal
Daniel Borkmann wrote: > This is a very rough and early proof of concept that implements bpfilter. [..] > Also, as a benefit from such design, we get BPF JIT compilation on x86_64, > arm64, ppc64, sparc64, mips64, s390x and arm32, but also rule offloading > into HW for free for Netronome NFP Sma

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Oleksandr Natalenko
Hi, David, Eric, Neal et al. On čtvrtek 15. února 2018 21:42:26 CET Oleksandr Natalenko wrote: > I've faced an issue with a limited TCP bandwidth between my laptop and a > server in my 1 Gbps LAN while using BBR as a congestion control mechanism. > To verify my observations, I've set up 2 KVM VMs

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-16 Thread Jesper Dangaard Brouer
On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang wrote: > On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: > > The virtio_net code have three different RX code-paths in receive_buf(). > > Two of these code paths can handle XDP, but one of them is broken for > > at least XDP_REDIRECT. > > > > Func

Re: [PATCH] inet: don't call skb_orphan if tproxy happens in layer 2

2018-02-16 Thread Gregory Vander Schueren
Hi Florian & Pablo, Thank your very much for your quick feedback. On 02/16/2018 12:28 PM, Pablo Neira Ayuso wrote: On Fri, Feb 16, 2018 at 12:07:06PM +0100, Florian Westphal wrote: Gregory Vander Schueren wrote: [ cc netdev ] If sysctl bridge-nf-call-iptables is enabled, iptables chains ar

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

2018-02-16 Thread Richard Cochran
On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > _port_ is being used as index to array port_hwtstamp before verifying > it is a non-negative number and a valid index at line 209 and 258: > > if (port < 0 || port >= mv88e6xxx_num_ports(chip)) > > Fix this by checking _port_

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-16 Thread Naveen N. Rao
Daniel Borkmann wrote: On 02/15/2018 05:25 PM, Daniel Borkmann wrote: On 02/13/2018 05:05 AM, Sandipan Das wrote: The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base to the start of the callee function. For som

Re: [PATCH][next] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

2018-02-16 Thread Richard Cochran
On Thu, Feb 15, 2018 at 09:27:57PM +0100, Andrew Lunn wrote: > Do you prefer this, or making timehi and timelo a u64? The latter. While you are at it, please move the definition of 'ns' to the start of the function. Thanks, Richard

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

2018-02-16 Thread Andrew Lunn
On Fri, Feb 16, 2018 at 07:48:46AM -0800, Richard Cochran wrote: > On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > > _port_ is being used as index to array port_hwtstamp before verifying > > it is a non-negative number and a valid index at line 209 and 258: > > > > if (port

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

2018-02-16 Thread Richard Cochran
On Fri, Feb 16, 2018 at 07:48:46AM -0800, Richard Cochran wrote: > On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > > _port_ is being used as index to array port_hwtstamp before verifying > > it is a non-negative number and a valid index at line 209 and 258: > > > > if (port

[PATCH v2] ravb: add support for changing MTU

2018-02-16 Thread Niklas Söderlund
Allow for changing the MTU within the limit of the maximum size of a descriptor (2048 bytes). Add the callback to change MTU from user-space and take the configurable MTU into account when configuring the hardware. Signed-off-by: Niklas Söderlund --- drivers/net/ethernet/renesas/ravb.h | 1

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-16 Thread Florian Westphal
Florian Westphal wrote: > Daniel Borkmann wrote: > Several questions spinning at the moment, I will probably come up with > more: ... and here there are some more ... One of the many pain points of xtables design is the assumption of 'used only by sysadmin'. This has not been true for a very l

Re: [PATCH iproute2-next v5 0/9] ipaddress: Make print_linkinfo_brief() static

2018-02-16 Thread David Ahern
On 2/15/18 2:23 PM, Serhey Popovych wrote: > With this series I propose to make print_linkinfo_brief() static in > favor of print_linkinfo() as single point for linkinfo printing. > ... > > Thanks, > Serhii > > Serhey Popovych (9): > ipaddress: Abstract IFA_LABEL matching code > ipaddress:

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Eric Dumazet
Lets CC BBR folks at Google, and remove the ones that probably have no idea. On Thu, 2018-02-15 at 21:42 +0100, Oleksandr Natalenko wrote: > Hello. > > I've faced an issue with a limited TCP bandwidth between my laptop and a > server in my 1 Gbps LAN while using BBR as a congestion control mec

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Eric Dumazet
On Fri, Feb 16, 2018 at 7:15 AM, Oleksandr Natalenko wrote: > Hi, David, Eric, Neal et al. > > On čtvrtek 15. února 2018 21:42:26 CET Oleksandr Natalenko wrote: >> I've faced an issue with a limited TCP bandwidth between my laptop and a >> server in my 1 Gbps LAN while using BBR as a congestion co

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Holger Hoffstätte
On 02/16/18 16:15, Oleksandr Natalenko wrote: > Hi, David, Eric, Neal et al. > > On čtvrtek 15. února 2018 21:42:26 CET Oleksandr Natalenko wrote: >> I've faced an issue with a limited TCP bandwidth between my laptop and a >> server in my 1 Gbps LAN while using BBR as a congestion control mechanis

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Eric Dumazet
On Fri, Feb 16, 2018 at 8:33 AM, Neal Cardwell wrote: > Oleksandr, > > Thanks for the detailed report! Yes, this sounds like an issue in BBR. We > have not run into this one in our team, but we will try to work with you to > fix this. > > Would you be able to take a sender-side tcpdump trace of th

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Neal Cardwell
On Fri, Feb 16, 2018 at 11:43 AM, Eric Dumazet wrote: > > On Fri, Feb 16, 2018 at 8:33 AM, Neal Cardwell wrote: > > Oleksandr, > > > > Thanks for the detailed report! Yes, this sounds like an issue in BBR. We > > have not run into this one in our team, but we will try to work with you to > > fix

Re: Serious performance degradation in Linux 4.15

2018-02-16 Thread Peter Zijlstra
On Fri, Feb 16, 2018 at 02:38:39PM +, Matt Fleming wrote: > On Wed, 14 Feb, at 10:46:20PM, Matt Fleming wrote: > > Here's some more numbers. This is with RETPOLINE=y but you'll see it > > doesn't make much of a difference. Oh, this is also with powersave > > cpufreq governor. > > Feh, I was w

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

2018-02-16 Thread Andy Shevchenko
On Thu, Feb 15, 2018 at 9:42 PM, Colin King wrote: > From: Colin Ian King > > The checks to see if key->dst.s6_addr and key->src.s6_addr are null > pointers are redundant because these are constant size arrays and > so the checks always return true. Fix this by removing the redundant > checks.

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-16 Thread Daniel Borkmann
Hi Florian, thanks for your feedback! More inline: On 02/16/2018 03:57 PM, Florian Westphal wrote: > Daniel Borkmann wrote: >> This is a very rough and early proof of concept that implements bpfilter. > > [..] > >> Also, as a benefit from such design, we get BPF JIT compilation on x86_64, >> a

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

2018-02-16 Thread Colin Ian King
On 16/02/18 16:51, Andy Shevchenko wrote: > On Thu, Feb 15, 2018 at 9:42 PM, Colin King wrote: >> From: Colin Ian King >> >> The checks to see if key->dst.s6_addr and key->src.s6_addr are null >> pointers are redundant because these are constant size arrays and >> so the checks always return true

[PATCH][V2] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

2018-02-16 Thread Colin King
From: Colin Ian King The shifting of timehi by 16 bits to the left will be promoted to a 32 bit signed int and then sign-extended to an u64. If the top bit of timehi is set then all then all the upper bits of ns end up as also being set because of the sign-extension. Fix this by making timehi and

Re: [PATCH iproute2-next v5 0/9] ipaddress: Make print_linkinfo_brief() static

2018-02-16 Thread Serhey Popovych
David Ahern wrote: > On 2/15/18 2:23 PM, Serhey Popovych wrote: >> With this series I propose to make print_linkinfo_brief() static in >> favor of print_linkinfo() as single point for linkinfo printing. >> > > ... > >> >> Thanks, >> Serhii >> >> Serhey Popovych (9): >> ipaddress: Abstract IFA_L

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Neal Cardwell
On Fri, Feb 16, 2018 at 11:26 AM, Holger Hoffstätte wrote: > > BBR in general will run with lower cwnd than e.g. Cubic or others. > That's a feature and necessary for WAN transfers. Please note that there's no general rule about whether BBR will run with a lower or higher cwnd than CUBIC, Reno, o

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Oleksandr Natalenko
Hi! On pátek 16. února 2018 17:45:56 CET Neal Cardwell wrote: > Eric raises a good question: bare metal vs VMs. > > Oleksandr, your first email mentioned KVM VMs and virtio NICs. Your > second e-mail did not seem to mention if those results were for bare > metal or a VM scenario: can you please c

[PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-02-16 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v2: - Implement recv side NAPI - Improved error handling - Implemented C45 writes - Added ethtool callbacks & blink functionality - Improv

[PATCH v3 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2018-02-16 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.txt --- Documentation/devicetree/bindings/net/nixge.txt | 32

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Holger Hoffstätte
On 02/16/18 17:56, Neal Cardwell wrote: > On Fri, Feb 16, 2018 at 11:26 AM, Holger Hoffstätte > wrote: >> >> BBR in general will run with lower cwnd than e.g. Cubic or others. >> That's a feature and necessary for WAN transfers. > > Please note that there's no general rule about whether BBR will

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-16 Thread John Fastabend
On 02/16/2018 07:41 AM, Jesper Dangaard Brouer wrote: > On Fri, 16 Feb 2018 13:31:37 +0800 > Jason Wang wrote: > >> On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: >>> The virtio_net code have three different RX code-paths in receive_buf(). >>> Two of these code paths can handle XDP, but one

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Oleksandr Natalenko
Hi. On pátek 16. února 2018 17:33:48 CET Neal Cardwell wrote: > Thanks for the detailed report! Yes, this sounds like an issue in BBR. We > have not run into this one in our team, but we will try to work with you to > fix this. > > Would you be able to take a sender-side tcpdump trace of the slow

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Oleksandr Natalenko
Hi. On pátek 16. února 2018 17:26:11 CET Holger Hoffstätte wrote: > These are very odd configurations. :) > Non-preempt/100 might well be too slow, whereas PREEMPT/1000 might simply > have too much overhead. Since the pacing is based on hrtimers, should HZ matter at all? Even if so, poor 1 Gbps

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Oleksandr Natalenko
Hi. On pátek 16. února 2018 17:25:58 CET Eric Dumazet wrote: > The way TCP pacing works, it defaults to internal pacing using a hint > stored in the socket. > > If you change the qdisc while flow is alive, result could be unexpected. I don't change a qdisc while flow is alive. Either the VM is c

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

2018-02-16 Thread Gustavo A. R. Silva
On 02/16/2018 09:56 AM, Richard Cochran wrote: On Fri, Feb 16, 2018 at 07:48:46AM -0800, Richard Cochran wrote: On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: _port_ is being used as index to array port_hwtstamp before verifying it is a non-negative number and a valid in

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Holger Hoffstätte
On 02/16/18 18:25, Oleksandr Natalenko wrote: > So, going on with two real HW hosts. They are both running latest stock Arch > Linux kernel (4.15.3-1-ARCH, CONFIG_PREEMPT=y, CONFIG_HZ=1000) and are > interconnected with 1 Gbps link (via switch if that matters). Using iperf3, > running each test

[PATCH] net: dsa: mv88e6xxx: hwtstamp: remove unnecessary range checking tests

2018-02-16 Thread Gustavo A. R. Silva
_port_ is already known to be a valid index in the callers [1]. So these checks are unnecessary. [1] https://lkml.org/lkml/2018/2/16/469 Addresses-Coverity-ID: 1465287 Addresses-Coverity-ID: 1465291 Suggested-by: Richard Cochran Signed-off-by: Gustavo A. R. Silva --- drivers/net/dsa/mv88e6xxx/

[RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-16 Thread Sridhar Samudrala
Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some iss

[RFC PATCH v3 1/3] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

2018-02-16 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a backup for another device with the same MAC address. VIRTIO_NET_F_BACKUP is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala --- drivers/net/virtio_net.c| 2 +- include/

[RFC PATCH v3 2/3] virtio_net: Extend virtio to use VF datapath when available

2018-02-16 Thread Sridhar Samudrala
This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable only

[RFC PATCH v3 3/3] virtio_net: Enable alternate datapath without creating an additional netdev

2018-02-16 Thread Sridhar Samudrala
This patch addresses the issues that were seen with the 3 netdev model by avoiding the creation of an additional netdev. Instead the bypass state information is tracked in the original netdev and a different set of ndo_ops and ethtool_ops are used when BACKUP feature is enabled. Signed-off-by: Sri

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-02-16 Thread Andrew Lunn
On Fri, Feb 16, 2018 at 09:00:33AM -0800, Moritz Fischer wrote: > +#define NIXGE_MDIO_CLAUSE45 BIT(12) > +#define NIXGE_MDIO_CLAUSE22 0 > +#define NIXGE_MDIO_OP(n) (((n) & 0x3) << 10) > +#define NIXGE_MDIO_OP_ADDRESS0 > +#define NIXGE_MDIO_OP_WRITE BIT(0) > +#define NIXGE_MDIO_OP_REA

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-16 Thread Sargun Dhillon
On Wed, Feb 14, 2018 at 8:30 PM, Alexei Starovoitov wrote: > On Wed, Feb 14, 2018 at 10:32:22AM -0700, Tycho Andersen wrote: >> > > >> > > What's the reason for adding eBPF support? seccomp shouldn't need it, >> > > and it only makes the code more complex. I'd rather stick with cBPF >> > > until w

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-16 Thread Guillaume Nault
On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-15 21:42, Guillaume Nault wrote: > > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fed

[PATCH net-next] net: Only honor ifindex in IP_PKTINFO if non-0

2018-02-16 Thread David Ahern
Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually set in the message. Signed-off-by: David Ahern --- net/ipv4/ip_sockglue.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c ind

Re: [PATCH v2] ravb: add support for changing MTU

2018-02-16 Thread Florian Fainelli
On 02/16/2018 08:10 AM, Niklas Söderlund wrote: > Allow for changing the MTU within the limit of the maximum size of a > descriptor (2048 bytes). Add the callback to change MTU from user-space > and take the configurable MTU into account when configuring the > hardware. > > Signed-off-by: Niklas S

Re: [PATCH v2] ravb: add support for changing MTU

2018-02-16 Thread Sergei Shtylyov
Hello! On 02/16/2018 10:42 PM, Florian Fainelli wrote: >> Allow for changing the MTU within the limit of the maximum size of a >> descriptor (2048 bytes). Add the callback to change MTU from user-space >> and take the configurable MTU into account when configuring the >> hardware. >> >> Signed-of

Re: [PATCH v2] ravb: add support for changing MTU

2018-02-16 Thread Florian Fainelli
On 02/16/2018 11:43 AM, Sergei Shtylyov wrote: > Hello! > > On 02/16/2018 10:42 PM, Florian Fainelli wrote: > >>> Allow for changing the MTU within the limit of the maximum size of a >>> descriptor (2048 bytes). Add the callback to change MTU from user-space >>> and take the configurable MTU into

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Oleksandr Natalenko
Hi. On pátek 16. února 2018 18:56:12 CET Holger Hoffstätte wrote: > There is simply no reason why you shouldn't get approx. line rate > (~920+-ish) Mbit over wired 1GBit Ethernet; even my broken 10-year old > Core2Duo laptop can do that. Can you boot with spectre_v2=off and try "the > simplest cas

Re: [PATCH V6 2/4] sctp: Add ip option support

2018-02-16 Thread Neil Horman
On Fri, Feb 16, 2018 at 10:56:07AM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Feb 15, 2018 at 09:15:40AM -0500, Neil Horman wrote: > > On Tue, Feb 13, 2018 at 08:54:44PM +, Richard Haines wrote: > > > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > > > and CALIP

Re: [PATCH net v2] fib_semantics: Don't match route with mismatching tclassid

2018-02-16 Thread David Miller
From: Stefano Brivio Date: Thu, 15 Feb 2018 09:46:03 +0100 > In fib_nh_match(), if output interface or gateway are passed in > the FIB configuration, we don't have to check next hops of > multipath routes to conclude whether we have a match or not. > > However, we might still have routes with di

Re: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-16 Thread David Miller
From: Jon Maloy Date: Thu, 15 Feb 2018 08:57:14 + > The buffers we are cloning are linearized 1 MTU incoming > buffers. There are no fragments. Each clone normally points to only > a tiny fraction of the data area of the base buffer. I don't claim > that copying always is bad, but in this c

Re: [net-next 00/10] tipc: de-generealize topology server

2018-02-16 Thread David Miller
From: Jon Maloy Date: Thu, 15 Feb 2018 10:40:41 +0100 > The topology server is partially based on a template that is much > more generic than what we need. This results in a code that is > unnecessarily hard to follow and keeping bug free. > > We now take the consequence of the fact that we only

Re: [PATCH net] cxgb4: free up resources of pf 0-3

2018-02-16 Thread David Miller
From: Ganesh Goudar Date: Thu, 15 Feb 2018 18:16:57 +0530 > free pf 0-3 resources, commit baf5086840ab ("cxgb4: > restructure VF mgmt code") erroneously removed the > code which frees the pf 0-3 resources, causing the > probe of pf 0-3 to fail in case of driver reload. > > Fixes: baf5086840ab ("

Re: [PATCH net] cxgb4: fix trailing zero in CIM LA dump

2018-02-16 Thread David Miller
From: Rahul Lakkireddy Date: Thu, 15 Feb 2018 18:20:01 +0530 > Set correct size of the CIM LA dump for T6. > > Fixes: 27887bc7cb7f ("cxgb4: collect hardware LA dumps") > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar Applied and queued up for -stable, thanks.

Re: [net-next v2 1/1] tipc: avoid unnecessary copying of bundled messages

2018-02-16 Thread David Miller
From: Jon Maloy Date: Thu, 15 Feb 2018 14:14:37 +0100 > A received sk buffer may contain dozens of smaller 'bundled' messages > which after extraction go each in their own direction. > > Unfortunately, when we extract those messages using skb_clone() each > of the extracted buffers inherit the t

Re: [PATCH net-next 0/2] net: dsa: mv88e6xxx: Improve PTP access latency

2018-02-16 Thread David Miller
From: Andrew Lunn Date: Thu, 15 Feb 2018 14:38:33 +0100 > PTP needs to retrieve the hardware timestamps from the switch device > in a low latency manor. However ethtool -S and bridge fdb show can > hold the switch register access mutex for a long time. These patches > changes the reading the stat

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-16 Thread David Miller
From: Rahul Lakkireddy Date: Thu, 15 Feb 2018 19:24:42 +0530 > Register callback to panic_notifier_list. Invoke dump collect routine > to append dump to vmcore. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar There is absolutely no precedence for a networking driver dumpin

Re: [PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices

2018-02-16 Thread David Miller
From: Ganesh Goudar Date: Thu, 15 Feb 2018 20:03:18 +0530 > From: Casey Leedom > > We've run into a problem where our device is attached > to a Virtual Machine and the use of the new pci_set_vpd_size() > API doesn't help. The VM kernel has been informed that > the accesses are okay, but all of

Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

2018-02-16 Thread David Miller
From: Matteo Croce Date: Thu, 15 Feb 2018 15:04:52 +0100 > What about the other two, removing IPv6 and change the Kconfig? > Other devices like VXLan, Geneve and VRF uses the same architecture > to allow conditional compilation of the IPv6 module, I think that > IPVlan should do the same. Ok, th

Re: [PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()

2018-02-16 Thread David Miller
From: Davide Caratti Date: Thu, 15 Feb 2018 15:50:57 +0100 > When tca_action_flush() calls the action walk() and gets an error, > a successful call to nla_nest_start() is not followed by a call to > nla_nest_cancel(). It's harmless, as the skb is freed in the error > path - but it's worth to fix

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-16 Thread Daniel Borkmann
Hi Florian, On 02/16/2018 05:14 PM, Florian Westphal wrote: > Florian Westphal wrote: >> Daniel Borkmann wrote: >> Several questions spinning at the moment, I will probably come up with >> more: > > ... and here there are some more ... > > One of the many pain points of xtables design is the a

Re: [PATCHv3 net-next 0/8] net: sched: act: add extack support

2018-02-16 Thread David Miller
From: Alexander Aring Date: Thu, 15 Feb 2018 10:54:52 -0500 > this patch series adds extack support for the TC action subsystem. > As example I for the extack support in a TC action I choosed mirred > action. > > - Alex > > Cc: David Ahern > > changes since v3: > - adapt recommended changes f

Re: [PATCH net] dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock

2018-02-16 Thread David Miller
From: Paolo Abeni Date: Thu, 15 Feb 2018 16:59:49 +0100 > After commit 3f34cfae1238 ("netfilter: on sockopt() acquire sock lock > only in the required scope"), the caller of nf_{get/set}sockopt() must > not hold any lock, but, in such changeset, I forgot to cope with DECnet. > > This commit addr

[PATCH] skbuff: Fix comment mis-spelling.

2018-02-16 Thread David Miller
'peform' --> 'perform' Signed-off-by: David S. Miller --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 5ebc0f869720..c1e66bdcf583 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Eric Dumazet
On Fri, Feb 16, 2018 at 9:25 AM, Oleksandr Natalenko wrote: > Hi. > > On pátek 16. února 2018 17:33:48 CET Neal Cardwell wrote: >> Thanks for the detailed report! Yes, this sounds like an issue in BBR. We >> have not run into this one in our team, but we will try to work with you to >> fix this. >

Re: [PATCH net] udplite: fix partial checksum initialization

2018-02-16 Thread David Miller
From: Alexey Kodanev Date: Thu, 15 Feb 2018 20:18:43 +0300 > Since UDP-Lite is always using checksum, the following path is > triggered when calculating pseudo header for it: > > udp4_csum_init() or udp6_csum_init() > skb_checksum_init_zero_check() > __skb_checksum_validate_complete(

Re: [PATCH v1 1/1] drivers: isdn: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-16 Thread David Miller
From: Joe Moriarty Date: Thu, 15 Feb 2018 15:27:00 -0500 > The Parfait (version 2.1.0) static code analysis tool found the > following NULL pointer dereference problem. > > - drivers/isdn/mISDN/core.c > function channelmap_show() does not check the returned mdev > variable from dev_to_mISDN() fo

Re: [PATCH v3 net-next 0/7] RDS: zerocopy support

2018-02-16 Thread David Miller
From: Sowmini Varadhan Date: Thu, 15 Feb 2018 10:49:31 -0800 > This is version 3 of the series, following up on review comments for > http://patchwork.ozlabs.org/project/netdev/list/?series=28530 > > Review comments addressed > Patch 4 > - fix fragile use of skb->cb[], do not set ee_code inco

Re: [PATCH net] tun: fix tun_napi_alloc_frags() frag allocator

2018-02-16 Thread David Miller
From: Eric Dumazet Date: Thu, 15 Feb 2018 14:47:15 -0800 > From: Eric Dumazet > > > While fuzzing arm64 v4.16-rc1 with Syzkaller, I've been hitting a > misaligned atomic in __skb_clone: > > atomic_inc(&(skb_shinfo(skb)->dataref)); > >where dataref doesn't have the require

  1   2   >