[PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege_events

Commit fb23403536ea ("sctp: remove the useless check in sctp_renege_events") forgot to remove another check for chunk in sctp_renege_events. Dan found this when doing a static check. This patch is to remove that check, and also to merge two checks into one 'if statement'. Fixes: fb23403536ea

Re: INFO: task hung in tun_chr_close

On Fri, Feb 16, 2018 at 9:23 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 1388c80438e69fc01d83fbe98da3cac24c3c8731 (Thu Feb 15 17:28:47 2018 +) > Merge branch 'sched-urgent-for-linus' of >

Re: [PATCH][next] wil6210: fix spelling mistake: "preperation"-> "preparation"

On 2018-01-30 21:27, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in debug error message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/wil6210/main.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On Fri, 16 Feb 2018 10:11:19 -0800, Sridhar Samudrala wrote: > Ppatch 2 is in response to the community request for a 3 netdev > solution. However, it creates some issues we'll get into in a moment. > It extends virtio_net to use alternate datapath when available and > registered. When BACKUP

[PATCH nf] netfilter: IDLETIMER: be syzkaller friendly

From: Eric Dumazet We had one report from syzkaller [1] First issue is that INIT_WORK() should be done before mod_timer() or we risk timer being fired too soon, even with a 1 second timer. Second issue is that we need to reject too big info->timeout to avoid overflows in

[net-next v2 2/2] bpf: Add eBPF seccomp sample programs

This adds a sample program that uses seccomp-eBPF, called seccomp1. It shows the simple ability to code seccomp filters in C. Signed-off-by: Sargun Dhillon --- samples/bpf/Makefile| 5 + samples/bpf/bpf_load.c | 9 +++-- samples/bpf/seccomp1_kern.c | 43

[net-next v2 0/2] eBPF Seccomp filters

This patchset enables seccomp filters to be written in eBPF. Although, this patchset doesn't introduce much of the functionality enabled by eBPF, it lays the ground work for it. Currently, you have to disable CHECKPOINT_RESTORE support in order to utilize eBPF seccomp filters, as eBPF filters

[net-next v2 1/2] bpf, seccomp: Add eBPF filter capabilities

This introduces the BPF_PROG_TYPE_SECCOMP bpf program type. It is meant to be used for seccomp filters as an alternative to cBPF filters. The program type has relatively limited capabilities in terms of helpers, but that can be extended later on. The eBPF code loading is separated from attachment

Re: [RFC PATCH v3 2/3] virtio_net: Extend virtio to use VF datapath when available

On Fri, 16 Feb 2018 10:11:21 -0800, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a VM with a direct attached VF without the need to setup a bond/team > between a VF

[PATCH net] xfrm: do not call rcu_read_unlock when afinfo is NULL in xfrm_get_tos

When xfrm_policy_get_afinfo returns NULL, it will not hold rcu read lock. In this case, rcu_read_unlock should not be called in xfrm_get_tos, just like other places where it's calling xfrm_policy_get_afinfo. Fixes: f5e2bb4f5b22 ("xfrm: policy: xfrm_get_tos cannot fail") Signed-off-by: Xin Long

Re: [PATCH net-next 1/3] bpf, seccomp: Add eBPF filter capabilities

On Tue, Feb 13, 2018 at 12:34 PM, Kees Cook wrote: > On Tue, Feb 13, 2018 at 7:42 AM, Sargun Dhillon wrote: >> From: Sargun Dhillon >> >> This introduces the BPF_PROG_TYPE_SECCOMP bpf program type. It is meant >> to be used for

Re: [PATCH V6 2/4] sctp: Add ip option support

On Fri, Feb 16, 2018 at 07:51:02PM -0200, Marcelo Ricardo Leitner wrote: > On Fri, Feb 16, 2018 at 03:14:35PM -0500, Neil Horman wrote: > > On Fri, Feb 16, 2018 at 10:56:07AM -0200, Marcelo Ricardo Leitner wrote: > > > On Thu, Feb 15, 2018 at 09:15:40AM -0500, Neil Horman wrote: > > > > On Tue,

[PATCH net-next] tun: export flags, uid, gid, queue information over netlink

Signed-off-by: Sabrina Dubroca Reviewed-by: Stefano Brivio --- drivers/net/tun.c| 56 include/uapi/linux/if_link.h | 18 ++ 2 files changed, 74 insertions(+) diff --git

Re: [PATCH V6 2/4] sctp: Add ip option support

On Thu, Feb 15, 2018 at 09:15:40AM -0500, Neil Horman wrote: > On Tue, Feb 13, 2018 at 08:54:44PM +, Richard Haines wrote: > > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > > and CALIPSO/IPv6 services. > > > > Signed-off-by: Richard Haines

Re: Serious performance degradation in Linux 4.15

On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > Peter, if you want to run this test yourself you can do: > > 1. git clone https://github.com/gorman/mmmtests.git root@ivb-ep:/usr/local/src# git clone https://github.com/gorman/mmmtests.git Cloning into 'mmmtests'... Username for

Re: Commit 05cf0d1bf4 ("net: stmmac: free an skb first when there are no longer any descriptors using it") breaks stmmac?

On Fri, Feb 16, 2018 at 09:34:39AM +, Jose Abreu wrote: > Hi Niklas, > > Thank you for looking into this! > > On 13-02-2018 13:33, Niklas Cassel wrote: > > Hello Jose, > > > > > > I remember that you had a problem > > with a use after free in stmmac_tx_clean(). > > I still don't think that

Re: [PATCH net] netfilter: unlock xt_table earlier in __do_replace

On Fri, Feb 16, 2018 at 12:02 PM, Florian Westphal wrote: > Xin Long wrote: >> Now it's doing cleanup_entry for oldinfo under the xt_table lock, >> but it's not really necessary. After the replacement job is done >> in xt_replace_table, oldinfo is not used

Re: Commit 05cf0d1bf4 ("net: stmmac: free an skb first when there are no longer any descriptors using it") breaks stmmac?

Hi Niklas, Thank you for looking into this! On 13-02-2018 13:33, Niklas Cassel wrote: > Hello Jose, > > > I remember that you had a problem > with a use after free in stmmac_tx_clean(). > I still don't think that it is related to > commit 05cf0d1bf4, however, when comparing > the stmmac driver

Re: [PATCH net] xfrm: reuse uncached_list to track xdsts

On Thu, Feb 15, 2018 at 03:31:45PM -0500, David Miller wrote: > From: Xin Long > Date: Wed, 14 Feb 2018 19:06:02 +0800 > > > In early time, when freeing a xdst, it would be inserted into > > dst_garbage.list first. Then if it's refcnt was still held > > somewhere, later it

Re: [PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege_events

On Fri, Feb 16, 2018 at 05:18:33PM +0800, Xin Long wrote: > Commit fb23403536ea ("sctp: remove the useless check in > sctp_renege_events") forgot to remove another check for > chunk in sctp_renege_events. > > Dan found this when doing a static check. > > This patch is to remove that check, and

Re: [PATCH net] netfilter: unlock xt_table earlier in __do_replace

Xin Long wrote: > Now it's doing cleanup_entry for oldinfo under the xt_table lock, > but it's not really necessary. After the replacement job is done > in xt_replace_table, oldinfo is not used elsewhere any more, and > it can be freed without xt_table lock safely. Right.

Information

Dear Friend, Please confirm back, can your account receive huge amount? Reply so we can discuss details and what will be your commission; Ahmed Zama

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

On 2018-02-15 21:42, Guillaume Nault wrote: On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:31, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 17:55, Guillaume Nault wrote: > > > On Thu, Feb

Re: [PATCH] inet: don't call skb_orphan if tproxy happens in layer 2

On Fri, Feb 16, 2018 at 12:07:06PM +0100, Florian Westphal wrote: > Gregory Vander Schueren wrote: > > [ cc netdev ] > > > If sysctl bridge-nf-call-iptables is enabled, iptables chains are already > > traversed from the bridging code. In such case, tproxy

Re: [PATCH net] sctp: remove the left unnecessary check for chunk in sctp_renege_events

On Fri, Feb 16, 2018 at 05:18:33PM +0800, Xin Long wrote: > Commit fb23403536ea ("sctp: remove the useless check in > sctp_renege_events") forgot to remove another check for > chunk in sctp_renege_events. > > Dan found this when doing a static check. > > This patch is to remove that check, and

Re: Serious performance degradation in Linux 4.15

On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > 3. ./run-mmtests.sh > --config=configs/config-global-dhp__network-netperf-unbound `uname -r` Not a success.. firstly it attempts to install packages without asking and then horribly fails at it..

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

Hi Greentime, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc1 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH] inet: don't call skb_orphan if tproxy happens in layer 2

Gregory Vander Schueren wrote: [ cc netdev ] > If sysctl bridge-nf-call-iptables is enabled, iptables chains are already > traversed from the bridging code. In such case, tproxy already happened when > reaching ip_rcv. Thus no need to call skb_orphan as this

[PATCH iproute2-next] ip link: add support to display extended tun attributes

Signed-off-by: Sabrina Dubroca Reviewed-by: Stefano Brivio --- I included the uapi changes from the kernel patch. Let me know if I need to resend without the header changes. include/uapi/linux/if_link.h | 18 ++ ip/iptuntap.c|

[PATCH net] netfilter: unlock xt_table earlier in __do_replace

Now it's doing cleanup_entry for oldinfo under the xt_table lock, but it's not really necessary. After the replacement job is done in xt_replace_table, oldinfo is not used elsewhere any more, and it can be freed without xt_table lock safely. The important thing is that rtnl_lock is called in some

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

Hi Greentime, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc1 next-20180216] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: Serious performance degradation in Linux 4.15

On Fri, Feb 16, 2018 at 11:17:01AM +0100, Peter Zijlstra wrote: > On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > > 3. ./run-mmtests.sh > > --config=configs/config-global-dhp__network-netperf-unbound `uname -r` > > Not a success.. firstly it attempts to install packages without

[PATCH] ptr_ring: Remove now-redundant smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in __ptr_ring_consume() is redundant; this commit removes it and updates the comments. Signed-off-by: Andrea Parri Cc: "David S. Miller" Cc: "Michael S.

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > _port_ is being used as index to array port_hwtstamp before verifying > it is a non-negative number and a valid index at line 209 and 258: > > if (port < 0 || port >= mv88e6xxx_num_ports(chip)) > > Fix this by checking _port_

Re: [PATCH] inet: don't call skb_orphan if tproxy happens in layer 2

Hi Florian & Pablo, Thank your very much for your quick feedback. On 02/16/2018 12:28 PM, Pablo Neira Ayuso wrote: On Fri, Feb 16, 2018 at 12:07:06PM +0100, Florian Westphal wrote: Gregory Vander Schueren wrote: [ cc netdev ] If sysctl

Re: [PATCH RFC 0/4] net: add bpfilter

Florian Westphal wrote: > Daniel Borkmann wrote: > Several questions spinning at the moment, I will probably come up with > more: ... and here there are some more ... One of the many pain points of xtables design is the assumption of 'used only by

Re: [PATCH iproute2-next v5 0/9] ipaddress: Make print_linkinfo_brief() static

On 2/15/18 2:23 PM, Serhey Popovych wrote: > With this series I propose to make print_linkinfo_brief() static in > favor of print_linkinfo() as single point for linkinfo printing. > ... > > Thanks, > Serhii > > Serhey Popovych (9): > ipaddress: Abstract IFA_LABEL matching code >

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On 02/16/18 16:15, Oleksandr Natalenko wrote: > Hi, David, Eric, Neal et al. > > On čtvrtek 15. února 2018 21:42:26 CET Oleksandr Natalenko wrote: >> I've faced an issue with a limited TCP bandwidth between my laptop and a >> server in my 1 Gbps LAN while using BBR as a congestion control

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

On 16/02/18 16:51, Andy Shevchenko wrote: > On Thu, Feb 15, 2018 at 9:42 PM, Colin King wrote: >> From: Colin Ian King >> >> The checks to see if key->dst.s6_addr and key->src.s6_addr are null >> pointers are redundant because these are

Re: [PATCH iproute2-next v5 0/9] ipaddress: Make print_linkinfo_brief() static

David Ahern wrote: > On 2/15/18 2:23 PM, Serhey Popovych wrote: >> With this series I propose to make print_linkinfo_brief() static in >> favor of print_linkinfo() as single point for linkinfo printing. >> > > ... > >> >> Thanks, >> Serhii >> >> Serhey Popovych (9): >> ipaddress: Abstract

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Hi! On pátek 16. února 2018 17:45:56 CET Neal Cardwell wrote: > Eric raises a good question: bare metal vs VMs. > > Oleksandr, your first email mentioned KVM VMs and virtio NICs. Your > second e-mail did not seem to mention if those results were for bare > metal or a VM scenario: can you please

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

Daniel Borkmann wrote: On 02/15/2018 05:25 PM, Daniel Borkmann wrote: On 02/13/2018 05:05 AM, Sandipan Das wrote: The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base to the start of the callee function. For

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

On Fri, Feb 16, 2018 at 07:48:46AM -0800, Richard Cochran wrote: > On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > > _port_ is being used as index to array port_hwtstamp before verifying > > it is a non-negative number and a valid index at line 209 and 258: > > > > if (port

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

On Fri, Feb 16, 2018 at 07:48:46AM -0800, Richard Cochran wrote: > On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > > _port_ is being used as index to array port_hwtstamp before verifying > > it is a non-negative number and a valid index at line 209 and 258: > > > > if (port

[PATCH v2] ravb: add support for changing MTU

Allow for changing the MTU within the limit of the maximum size of a descriptor (2048 bytes). Add the callback to change MTU from user-space and take the configurable MTU into account when configuring the hardware. Signed-off-by: Niklas Söderlund ---

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On Fri, Feb 16, 2018 at 11:43 AM, Eric Dumazet wrote: > > On Fri, Feb 16, 2018 at 8:33 AM, Neal Cardwell wrote: > > Oleksandr, > > > > Thanks for the detailed report! Yes, this sounds like an issue in BBR. We > > have not run into this one in our team,

Re: Serious performance degradation in Linux 4.15

On Fri, Feb 16, 2018 at 02:38:39PM +, Matt Fleming wrote: > On Wed, 14 Feb, at 10:46:20PM, Matt Fleming wrote: > > Here's some more numbers. This is with RETPOLINE=y but you'll see it > > doesn't make much of a difference. Oh, this is also with powersave > > cpufreq governor. > > Feh, I was

[PATCH][V2] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

From: Colin Ian King The shifting of timehi by 16 bits to the left will be promoted to a 32 bit signed int and then sign-extended to an u64. If the top bit of timehi is set then all then all the upper bits of ns end up as also being set because of the sign-extension.

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang wrote: > On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: > > The virtio_net code have three different RX code-paths in receive_buf(). > > Two of these code paths can handle XDP, but one of them is broken for > > at least

Re: [PATCH][next] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

On Thu, Feb 15, 2018 at 09:27:57PM +0100, Andrew Lunn wrote: > Do you prefer this, or making timehi and timelo a u64? The latter. While you are at it, please move the definition of 'ns' to the start of the function. Thanks, Richard

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Lets CC BBR folks at Google, and remove the ones that probably have no idea. On Thu, 2018-02-15 at 21:42 +0100, Oleksandr Natalenko wrote: > Hello. > > I've faced an issue with a limited TCP bandwidth between my laptop and a > server in my 1 Gbps LAN while using BBR as a congestion control

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On Fri, Feb 16, 2018 at 7:15 AM, Oleksandr Natalenko wrote: > Hi, David, Eric, Neal et al. > > On čtvrtek 15. února 2018 21:42:26 CET Oleksandr Natalenko wrote: >> I've faced an issue with a limited TCP bandwidth between my laptop and a >> server in my 1 Gbps LAN while

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On Fri, Feb 16, 2018 at 8:33 AM, Neal Cardwell wrote: > Oleksandr, > > Thanks for the detailed report! Yes, this sounds like an issue in BBR. We > have not run into this one in our team, but we will try to work with you to > fix this. > > Would you be able to take a

Re: [PATCH RFC 0/4] net: add bpfilter

Hi Florian, thanks for your feedback! More inline: On 02/16/2018 03:57 PM, Florian Westphal wrote: > Daniel Borkmann wrote: >> This is a very rough and early proof of concept that implements bpfilter. > > [..] > >> Also, as a benefit from such design, we get BPF JIT

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On Fri, Feb 16, 2018 at 11:26 AM, Holger Hoffstätte wrote: > > BBR in general will run with lower cwnd than e.g. Cubic or others. > That's a feature and necessary for WAN transfers. Please note that there's no general rule about whether BBR will run with a lower or

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

On Thu, Feb 15, 2018 at 9:42 PM, Colin King wrote: > From: Colin Ian King > > The checks to see if key->dst.s6_addr and key->src.s6_addr are null > pointers are redundant because these are constant size arrays and > so the checks always return

Re: Serious performance degradation in Linux 4.15

On Wed, 14 Feb, at 10:46:20PM, Matt Fleming wrote: > On Mon, 12 Feb, at 04:16:42PM, Peter Zijlstra wrote: > > On Fri, Feb 09, 2018 at 05:59:12PM +, Jon Maloy wrote: > > > Command for TCP: > > > "netperf TCP_STREAM (netperf -n 4 -f m -c 4 -C 4 -P 1 -H 10.0.0.1 -t > > > TCP_STREAM -l 10 -- -O

Re: [PATCH net] netfilter: xt_hashlimit: fix lock imbalance

On Mon, Feb 12, 2018 at 08:11:48AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > syszkaller found that rcu was not held in hashlimit_mt_common() > > We only need to enable BH at this point. Applied, thanks Eric! Sorry, this didn't get into my patchwork [1] for some

Re: [PATCH RFC 0/4] net: add bpfilter

Daniel Borkmann wrote: > This is a very rough and early proof of concept that implements bpfilter. [..] > Also, as a benefit from such design, we get BPF JIT compilation on x86_64, > arm64, ppc64, sparc64, mips64, s390x and arm32, but also rule offloading > into HW for

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Hi, David, Eric, Neal et al. On čtvrtek 15. února 2018 21:42:26 CET Oleksandr Natalenko wrote: > I've faced an issue with a limited TCP bandwidth between my laptop and a > server in my 1 Gbps LAN while using BBR as a congestion control mechanism. > To verify my observations, I've set up 2 KVM VMs

[PATCH RFC 4/4] bpf: rough bpfilter codegen example hack

Signed-off-by: Daniel Borkmann --- include/uapi/linux/bpf.h| 31 +++-- kernel/bpf/syscall.c| 39 +++--- net/bpfilter/Makefile | 2 +- net/bpfilter/bpfilter.c | 59 + net/bpfilter/bpfilter_mod.h | 285

[PATCH RFC 2/4] bpf: introduce bpfilter commands

From: Alexei Starovoitov Signed-off-by: Alexei Starovoitov --- include/uapi/linux/bpf.h | 16 kernel/bpf/syscall.c | 41 + 2 files changed, 57 insertions(+) diff --git a/include/uapi/linux/bpf.h

Re: [PATCH net] tg3: APE heartbeat changes

On Fri, Feb 16, 2018 at 11:22:43AM +0530, Satish Baddipadige wrote: > From: Prashant Sreedharan > > In ungraceful host shutdown or driver crash case BMC connectivity is > lost. APE firmware is missing the driver state in this > case to keep the BMC connectivity

[PATCH RFC 3/4] net: initial bpfilter skeleton

From: "David S. Miller" Signed-off-by: David S. Miller Signed-off-by: Alexei Starovoitov --- include/linux/bpfilter.h | 13 +++ include/uapi/linux/bpfilter.h | 200 ++ net/Kconfig

[PATCH RFC 1/4] modules: allow insmod load regular elf binaries

From: Alexei Starovoitov Signed-off-by: Alexei Starovoitov --- fs/exec.c | 40 +++- include/linux/binfmts.h | 1 + include/linux/umh.h | 4 kernel/module.c | 33

[PATCH RFC 0/4] net: add bpfilter

This is a very rough and early proof of concept that implements bpfilter. The basic idea of bpfilter is that it can process iptables queries and translate them in user space into BPF programs which can then get attached at various locations. For simplicity, in this RFC we demo attaching them to

[PATCH net-next] net: Only honor ifindex in IP_PKTINFO if non-0

Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually set in the message. Signed-off-by: David Ahern --- net/ipv4/ip_sockglue.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_sockglue.c

Re: [PATCH v2] ravb: add support for changing MTU

On 02/16/2018 11:43 AM, Sergei Shtylyov wrote: > Hello! > > On 02/16/2018 10:42 PM, Florian Fainelli wrote: > >>> Allow for changing the MTU within the limit of the maximum size of a >>> descriptor (2048 bytes). Add the callback to change MTU from user-space >>> and take the configurable MTU

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Hi. On pátek 16. února 2018 18:56:12 CET Holger Hoffstätte wrote: > There is simply no reason why you shouldn't get approx. line rate > (~920+-ish) Mbit over wired 1GBit Ethernet; even my broken 10-year old > Core2Duo laptop can do that. Can you boot with spectre_v2=off and try "the > simplest

Re: [PATCH V6 2/4] sctp: Add ip option support

On Fri, Feb 16, 2018 at 10:56:07AM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Feb 15, 2018 at 09:15:40AM -0500, Neil Horman wrote: > > On Tue, Feb 13, 2018 at 08:54:44PM +, Richard Haines wrote: > > > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > > > and

Re: [PATCH net v2] fib_semantics: Don't match route with mismatching tclassid

From: Stefano Brivio Date: Thu, 15 Feb 2018 09:46:03 +0100 > In fib_nh_match(), if output interface or gateway are passed in > the FIB configuration, we don't have to check next hops of > multipath routes to conclude whether we have a match or not. > > However, we might

Re: [PATCH v2] ravb: add support for changing MTU

Hello! On 02/16/2018 10:42 PM, Florian Fainelli wrote: >> Allow for changing the MTU within the limit of the maximum size of a >> descriptor (2048 bytes). Add the callback to change MTU from user-space >> and take the configurable MTU into account when configuring the >> hardware. >> >>

Re: [PATCH v2] ravb: add support for changing MTU

On 02/16/2018 08:10 AM, Niklas Söderlund wrote: > Allow for changing the MTU within the limit of the maximum size of a > descriptor (2048 bytes). Add the callback to change MTU from user-space > and take the configurable MTU into account when configuring the > hardware. > > Signed-off-by: Niklas

[PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v2: - Implement recv side NAPI - Improved error handling - Implemented C45 writes - Added ethtool callbacks & blink

[PATCH v3 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.txt --- Documentation/devicetree/bindings/net/nixge.txt | 32

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On 02/16/18 17:56, Neal Cardwell wrote: > On Fri, Feb 16, 2018 at 11:26 AM, Holger Hoffstätte > wrote: >> >> BBR in general will run with lower cwnd than e.g. Cubic or others. >> That's a feature and necessary for WAN transfers. > > Please note that there's no

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Hi. On pátek 16. února 2018 17:26:11 CET Holger Hoffstätte wrote: > These are very odd configurations. :) > Non-preempt/100 might well be too slow, whereas PREEMPT/1000 might simply > have too much overhead. Since the pacing is based on hrtimers, should HZ matter at all? Even if so, poor 1 Gbps

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

On 02/16/2018 09:56 AM, Richard Cochran wrote: On Fri, Feb 16, 2018 at 07:48:46AM -0800, Richard Cochran wrote: On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: _port_ is being used as index to array port_hwtstamp before verifying it is a non-negative number and a valid

Re: TCP and BBR: reproducibly low cwnd and bandwidth

On 02/16/18 18:25, Oleksandr Natalenko wrote: > So, going on with two real HW hosts. They are both running latest stock Arch > Linux kernel (4.15.3-1-ARCH, CONFIG_PREEMPT=y, CONFIG_HZ=1000) and are > interconnected with 1 Gbps link (via switch if that matters). Using iperf3, > running each test

[RFC PATCH v3 2/3] virtio_net: Extend virtio to use VF datapath when available

This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable

[RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some

[RFC PATCH v3 1/3] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

This feature bit can be used by hypervisor to indicate virtio_net device to act as a backup for another device with the same MAC address. VIRTIO_NET_F_BACKUP is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Hi. On pátek 16. února 2018 17:25:58 CET Eric Dumazet wrote: > The way TCP pacing works, it defaults to internal pacing using a hint > stored in the socket. > > If you change the qdisc while flow is alive, result could be unexpected. I don't change a qdisc while flow is alive. Either the VM is

[RFC PATCH v3 3/3] virtio_net: Enable alternate datapath without creating an additional netdev

This patch addresses the issues that were seen with the 3 netdev model by avoiding the creation of an additional netdev. Instead the bypass state information is tracked in the original netdev and a different set of ndo_ops and ethtool_ops are used when BACKUP feature is enabled. Signed-off-by:

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

On Fri, Feb 16, 2018 at 09:00:33AM -0800, Moritz Fischer wrote: > +#define NIXGE_MDIO_CLAUSE45 BIT(12) > +#define NIXGE_MDIO_CLAUSE22 0 > +#define NIXGE_MDIO_OP(n) (((n) & 0x3) << 10) > +#define NIXGE_MDIO_OP_ADDRESS0 > +#define NIXGE_MDIO_OP_WRITE BIT(0) > +#define

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

On 02/16/2018 07:41 AM, Jesper Dangaard Brouer wrote: > On Fri, 16 Feb 2018 13:31:37 +0800 > Jason Wang wrote: > >> On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: >>> The virtio_net code have three different RX code-paths in receive_buf(). >>> Two of these code paths

Re: TCP and BBR: reproducibly low cwnd and bandwidth

Hi. On pátek 16. února 2018 17:33:48 CET Neal Cardwell wrote: > Thanks for the detailed report! Yes, this sounds like an issue in BBR. We > have not run into this one in our team, but we will try to work with you to > fix this. > > Would you be able to take a sender-side tcpdump trace of the

Re: [PATCH net-next 0/3] eBPF Seccomp filters

On Wed, Feb 14, 2018 at 8:30 PM, Alexei Starovoitov wrote: > On Wed, Feb 14, 2018 at 10:32:22AM -0700, Tycho Andersen wrote: >> > > >> > > What's the reason for adding eBPF support? seccomp shouldn't need it, >> > > and it only makes the code more complex. I'd rather

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-15 21:42, Guillaume Nault wrote: > > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys

[PATCH] net: dsa: mv88e6xxx: hwtstamp: remove unnecessary range checking tests

_port_ is already known to be a valid index in the callers [1]. So these checks are unnecessary. [1] https://lkml.org/lkml/2018/2/16/469 Addresses-Coverity-ID: 1465287 Addresses-Coverity-ID: 1465291 Suggested-by: Richard Cochran Signed-off-by: Gustavo A. R. Silva

Re: [PATCH net] cxgb4: fix trailing zero in CIM LA dump

From: Rahul Lakkireddy Date: Thu, 15 Feb 2018 18:20:01 +0530 > Set correct size of the CIM LA dump for T6. > > Fixes: 27887bc7cb7f ("cxgb4: collect hardware LA dumps") > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar

Re: [PATCH net] cxgb4: free up resources of pf 0-3

From: Ganesh Goudar Date: Thu, 15 Feb 2018 18:16:57 +0530 > free pf 0-3 resources, commit baf5086840ab ("cxgb4: > restructure VF mgmt code") erroneously removed the > code which frees the pf 0-3 resources, causing the > probe of pf 0-3 to fail in case of driver reload. > >

Re: [PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices

From: Ganesh Goudar Date: Thu, 15 Feb 2018 20:03:18 +0530 > From: Casey Leedom > > We've run into a problem where our device is attached > to a Virtual Machine and the use of the new pci_set_vpd_size() > API doesn't help. The VM kernel has been

Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

From: Matteo Croce Date: Thu, 15 Feb 2018 15:04:52 +0100 > What about the other two, removing IPv6 and change the Kconfig? > Other devices like VXLan, Geneve and VRF uses the same architecture > to allow conditional compilation of the IPv6 module, I think that > IPVlan should

[PATCH] skbuff: Fix comment mis-spelling.

'peform' --> 'perform' Signed-off-by: David S. Miller --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 5ebc0f869720..c1e66bdcf583 100644 --- a/include/linux/skbuff.h +++

Re: [PATCH net-next 0/2] nfp: whitespace sync and flower TCP flags

From: Jakub Kicinski Date: Thu, 15 Feb 2018 20:19:07 -0800 > Whitespace cleanup from Michael and flower offload support for matching > on TCP flags from Pieter. Series applied, thanks Jakub.

Re: [PATCH v2] ravb: add support for changing MTU

From: Niklas Söderlund Date: Fri, 16 Feb 2018 17:10:08 +0100 > Allow for changing the MTU within the limit of the maximum size of a > descriptor (2048 bytes). Add the callback to change MTU from user-space > and take the configurable MTU into account when

Re: [PATCH][V2] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

From: Colin King Date: Fri, 16 Feb 2018 16:55:05 + > From: Colin Ian King > > The shifting of timehi by 16 bits to the left will be promoted to > a 32 bit signed int and then sign-extended to an u64. If the top bit > of timehi is set then

Re: [net-next 00/10] tipc: de-generealize topology server

From: Jon Maloy Date: Thu, 15 Feb 2018 10:40:41 +0100 > The topology server is partially based on a template that is much > more generic than what we need. This results in a code that is > unnecessarily hard to follow and keeping bug free. > > We now take the consequence

Re: [net-next v2 1/1] tipc: avoid unnecessary copying of bundled messages

From: Jon Maloy Date: Thu, 15 Feb 2018 14:14:37 +0100 > A received sk buffer may contain dozens of smaller 'bundled' messages > which after extraction go each in their own direction. > > Unfortunately, when we extract those messages using skb_clone() each > of the

  1   2   >