Re: [PATCH v7 03/37] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h

2018-02-21 Thread Greentime Hu
2018-02-14 22:43 GMT+08:00 Arnd Bergmann : > On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: >> A commit for the nds32 architecture bootstrap("asm-generic/io.h: move >> ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU") >> will

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread Roman Kapl
On 02/21/2018 08:45 AM, Phil Sutter wrote: Hi Roman, On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: So far, if the filter was too large to fit in the allocated skb, the kernel did not return any error and stopped dumping. Modify the dumper so that it returns -EMSGSIZE when a

Re: [PATCH 2/3] net: Make cleanup_list and net::cleanup_list of llist type

2018-02-21 Thread Kirill Tkhai
On 20.02.2018 22:42, Cong Wang wrote: > On Mon, Feb 19, 2018 at 1:58 AM, Kirill Tkhai wrote: >> void __put_net(struct net *net) >> { >> /* Cleanup the network namespace in process context */ >> - unsigned long flags; >> - >> -

Re: WARNING: ODEBUG bug in __queue_work

2018-02-21 Thread Dmitry Vyukov
On Wed, Feb 21, 2018 at 1:59 AM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 1a2a7d3ee659e477e0768ac3fc7579794f89071b (Fri Feb 16 17:11:30 2018 +) > Merge tag 'sound-4.16-rc2' of >

Re: [PATCH net-next] net: dsa: mv88e6xxx: scratch registers and external MDIO pins

2018-02-21 Thread kbuild test robot
Hi Andrew, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Andrew-Lunn/net-dsa-mv88e6xxx-scratch-registers-and-external-MDIO-pins/20180221-150325 config: i386-randconfig-i0-201807 (attached as .config

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread Roman Kapl
On 02/21/2018 09:42 AM, Phil Sutter wrote: Hi Roman, On Wed, Feb 21, 2018 at 09:38:52AM +0100, Roman Kapl wrote: On 02/21/2018 08:45 AM, Phil Sutter wrote: On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: Note: The error case can happen pretty easily if you create a filter with 32

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jiri Pirko
Tue, Feb 20, 2018 at 11:33:56PM CET, kubak...@wp.pl wrote: >On Tue, 20 Feb 2018 21:14:10 +0100, Jiri Pirko wrote: >> Yeah, I can see it now :( I guess that the ship has sailed and we are >> stuck with this ugly thing forever... >> >> Could you at least make some common code that is shared in

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread Phil Sutter
Hi Roman, On Wed, Feb 21, 2018 at 09:38:52AM +0100, Roman Kapl wrote: > On 02/21/2018 08:45 AM, Phil Sutter wrote: > > On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: > >> So far, if the filter was too large to fit in the allocated skb, the > >> kernel did not return any error and

Re: [PATCH 1/3] net: Kill net_mutex

2018-02-21 Thread Kirill Tkhai
Hi, Stephen, On 21.02.2018 02:18, Stephen Hemminger wrote: > On Mon, 19 Feb 2018 12:58:38 +0300 > Kirill Tkhai wrote: > >> +struct list_headexit_list; /* To linked to call pernet exit >> + * methods on dead net

Re: [PATCH net-next 0/5] net/smc: fixes 2018-02-21

2018-02-21 Thread Stefan Raspl
On 21.02.2018 12:32, Ursula Braun wrote: > Dave, > > here are some smc-patches for net-next. Besides cleanups, the link id > field of the LLC confirm link reply is changed to comply with RFC7609. > > Thanks, Ursula Looks good to me! Ciao, Stefan

[PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-21 Thread Eric Dumazet
From: Eric Dumazet BBR uses tcp_tso_autosize() in an attempt to probe what would be the burst sizes and to adjust cwnd in bbr_target_cwnd() with following gold formula : /* Allow enough full-sized skbs in flight to utilize end systems. */ cwnd += 3 * bbr->tso_segs_goal;

Re: [PATCH net-next] net: dsa: mv88e6xxx: scratch registers and external MDIO pins

2018-02-21 Thread Andrew Lunn
h-registers-and-external-MDIO-pins/20180221-150325 > config: i386-randconfig-i0-201807 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefi

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Jason A. Donenfeld
On Wed, Feb 21, 2018 at 6:47 AM, Eric Dumazet wrote: >> This probably should be queued up for stable. > > When was the bug added ? This would help a lot stable teams ... This needs to be backported to 4.16-rc0+, 4.15+, 4.14+, 4.13.14+, and 4.9.63+.

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Eric Dumazet
On Wed, 2018-02-21 at 15:54 +0100, Jason A. Donenfeld wrote: > On Wed, Feb 21, 2018 at 6:47 AM, Eric Dumazet wrote: > > > This probably should be queued up for stable. > > > > When was the bug added ? This would help a lot stable teams ... > > This needs to be backported

Qualcomm rmnet driver and qmi_wwan

2018-02-21 Thread Daniele Palmas
Hello, in rmnet kernel documentation I read: "This driver can be used to register onto any physical network device in IP mode. Physical transports include USB, HSIC, PCIe and IP accelerator." Does this mean that it can be used in association with the qmi_wwan driver? If yes, can someone give

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

2018-02-21 Thread Arnd Bergmann
On Wed, Feb 21, 2018 at 12:21 PM, Greentime Hu wrote: > 2018-02-16 18:47 GMT+08:00 kbuild test robot : > > From: Greentime Hu > Date: Wed, 21 Feb 2018 14:21:23 +0800 > Subject: [PATCH] xtensa: add ioremap_nocache declaration before

[PATCH iproute2-next] rdma: Add batch command support

2018-02-21 Thread Leon Romanovsky
From: Leon Romanovsky Implement an option (-b) to execute RDMAtool commands from supplied file. This follows the same model as in use for ip and devlink tools, by expecting every new command to be on new line. These commands are expected to be without any -* (e.g. -d, -j,

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-02-21 Thread Tommi Rantala
On 20.02.2018 18:26, Neil Horman wrote: On Tue, Feb 20, 2018 at 09:14:41AM +0100, Dmitry Vyukov wrote: On Tue, Feb 20, 2018 at 8:56 AM, Tommi Rantala wrote: On 19.02.2018 20:59, Dmitry Vyukov wrote: Is this meant to be fixed already? I am still seeing this on the

Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-21 Thread Paolo Abeni
Hi, On Wed, 2018-02-21 at 06:43 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > BBR uses tcp_tso_autosize() in an attempt to probe what would be the > burst sizes and to adjust cwnd in bbr_target_cwnd() with following > gold formula : > > /* Allow enough full-sized

Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-21 Thread Eric Dumazet
On Wed, Feb 21, 2018 at 7:01 AM, Paolo Abeni wrote: > > Very minor nit, why don't: > > return max_t(u32, bytes / mss_now, min_tso_segs); > > and drop the 'segs' local variable? Simply to ease backports. We had some constant changes in this function in the past.

Re: [PATCH V7 2/4] sctp: Add ip option support

2018-02-21 Thread Marcelo Ricardo Leitner
On Tue, Feb 20, 2018 at 07:15:27PM +, Richard Haines wrote: > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > and CALIPSO/IPv6 services. > > Signed-off-by: Richard Haines LGTM too, thanks! Acked-by: Marcelo Ricardo Leitner

Re: [PATCH net-next v2 1/1] net: Allow a rule to track originating protocol

2018-02-21 Thread David Miller
From: Donald Sharp Date: Tue, 20 Feb 2018 08:55:58 -0500 > Allow a rule that is being added/deleted/modified or > dumped to contain the originating protocol's id. > > The protocol is handled just like a routes originating > protocol is. This is especially useful

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread David Miller
From: Anders Roxell Date: Wed, 21 Feb 2018 22:30:01 +0100 > bpf builds a test program for loading BPF ELF files. Add the executable > to the .gitignore list. > > Signed-off-by: Anders Roxell Acked-by: David S. Miller

[PATCH net-next 4/7] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE

2018-02-21 Thread David Ahern
Rename NETEVENT_MULTIPATH_HASH_UPDATE to NETEVENT_IPV4_MPATH_HASH_UPDATE to denote it relates to a change in the IPv4 hash policy. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- include/net/netevent.h

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-21 Thread Jakub Kicinski
On Tue, 20 Feb 2018 11:58:22 +0100, Pablo Neira Ayuso wrote: > We also have a large range of TCAM based hardware offload outthere > that will _not_ work with your BPF HW offload infrastructure. What > this bpf infrastructure pushes into the kernel is just a blob > expressing things in a very

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: > I haven't checked emails for days and did not realize the new revision > had already came out. And thank you for the effort, this revision > really looks to be a step forward towards our use case and is close to > what we

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-21 Thread Florian Fainelli
On 02/21/2018 03:46 PM, Jakub Kicinski wrote: > On Tue, 20 Feb 2018 11:58:22 +0100, Pablo Neira Ayuso wrote: >> We also have a large range of TCAM based hardware offload outthere >> that will _not_ work with your BPF HW offload infrastructure. What >> this bpf infrastructure pushes into the kernel

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Shuah Khan
On 02/21/2018 03:48 PM, David Miller wrote: > From: Anders Roxell > Date: Wed, 21 Feb 2018 22:30:01 +0100 > >> bpf builds a test program for loading BPF ELF files. Add the executable >> to the .gitignore list. >> >> Signed-off-by: Anders Roxell

Re: [PATCH] bpf: clean up unused-variable warning

2018-02-21 Thread Daniel Borkmann
On 02/20/2018 11:07 PM, Arnd Bergmann wrote: > The only user of this variable is inside of an #ifdef, causing > a warning without CONFIG_INET: > > net/core/filter.c: In function 'bpf_sock_ops_cb_flags_set': > net/core/filter.c:3382:6: error: unused variable 'val' > [-Werror=unused-variable]

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
On (02/21/18 18:45), Willem de Bruijn wrote: > > I do mean returning 0 instead of -EAGAIN if control data is ready. > Something like > > @@ -611,7 +611,8 @@ int rds_recvmsg(struct socket *sock, struct msghdr > *msg, size_t size, > > if (!rds_next_incoming(rs, )) { >

Bug with 'ip' command where build a stuck list of interfaces

2018-02-21 Thread Rm Beer
Hello. With 'ip tunnel add tun0 mode ipip dev enp1s0' make two interfaces called 'tunl0' and 'tun0'. Late with 'ip tunnel del tun0' remove only 'tun0' and forget the 'tunl0' in the list. with this you can not do anything else in the list, it can not be created and it can not be deleted. It is

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Siwei Liu
On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: > On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: >> I haven't checked emails for days and did not realize the new revision >> had already came out. And thank you for the effort, this

[PATCH v2 net-next 2/2] lan743x: Update MAINTAINERS to include lan743x driver

2018-02-21 Thread Bryan Whitehead
Update MAINTAINERS to include lan743x driver Signed-off-by: Bryan Whitehead --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7f76e..c340125 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9149,6 +9149,13

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
On Wed, Feb 21, 2018 at 3:19 PM, Sowmini Varadhan wrote: > This commit is an optimization that builds on top of commit 01883eda72bd > ("rds: support for zcopy completion notification") for PF_RDS sockets. > > Cookies associated with zerocopy completion are passed up

Re: syzcaller patch postings...

2018-02-21 Thread Florian Westphal
David Miller wrote: > I have to mention this now before it gets out of control. > > I would like to ask that syzkaller stop posting the patch it is > testing when it posts to netdev. Same for netfilter-devel. I could not get a reproducer to trigger and asked syzbot to test

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Siwei Liu
I haven't checked emails for days and did not realize the new revision had already came out. And thank you for the effort, this revision really looks to be a step forward towards our use case and is close to what we wanted to do. A few questions in line. On Sat, Feb 17, 2018 at 9:12 AM, Alexander

nft/bpf interpreters and spectre2. Was: [PATCH RFC 0/4] net: add bpfilter

2018-02-21 Thread Alexei Starovoitov
On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote: > > Obvious candidates are: meta, numgen, limit, objref, quota, reject. > > We should probably also consider removing > CONFIG_NFT_SET_RBTREE and CONFIG_NFT_SET_HASH and just always > build both too (at least rbtree since that

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
On (02/21/18 16:54), Willem de Bruijn wrote: > > I'd put this optimization behind a socket option. Yes, that thought occurred to me as well- I think RDS applications are unlikely to use the error_queue path because, as I mentioned before, these are heavily request-response based, so you're

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
>> Okay. If callers must already handle 0 as a valid return code, then >> it is fine to add another case that does this. >> >> The extra branch in the hot path is still rather unfortunately. Could >> this be integrated in the existing if (nonblock) branch below? > > that's where I first started.

[PATCH net-next] ibmvnic: Fix TX descriptor tracking

2018-02-21 Thread Thomas Falcon
With the recent change, transmissions that only needed one descriptor were being missed. The result is that such packets were tracked as outstanding transmissions but never removed when its completion notification was received. Fixes: ffc385b95adb ("ibmvnic: Keep track of supplementary TX

[PATCH net] ibmvnic: Fix early release of login buffer

2018-02-21 Thread Thomas Falcon
The login buffer is released before the driver can perform sanity checks between resources the driver requested and what firmware will provide. Don't release the login buffer until the sanity check is performed. Fixes: 34f0f4e3f488 ("ibmvnic: Fix login buffer memory leaks") Signed-off-by: Thomas

[PATCH v2 iproute2-next 2/3] ip: Display ip rule protocol used

2018-02-21 Thread Donald Sharp
Modify 'ip rule' command to notice when the kernel passes to us the originating protocol. Add code to allow the `ip rule flush protocol XXX` command to be accepted and properly handled. Modify the documentation to reflect these code changes. Signed-off-by: Donald Sharp

[PATCH v2 iproute2-next 0/3] Allow 'ip rule' command to use protocol

2018-02-21 Thread Donald Sharp
Fix iprule.c to use the actual `struct fib_rule_hdr` and to allow the end user to see and use the protocol keyword for rule manipulations. v2: Rearrange and code changes as per David Ahern Donald Sharp (3): ip: Use the `struct fib_rule_hdr` for rules ip: Display ip rule protocol used ip:

[PATCH v2 iproute2-next 1/3] ip: Use the `struct fib_rule_hdr` for rules

2018-02-21 Thread Donald Sharp
The iprule.c code was using `struct rtmsg` as the data type to pass into the kernel for the netlink message. While 'struct rtmsg' and `struct fib_rule_hdr` are the same size and mostly the same, we should use the correct data structure. This commit translates the data structures to have iprule.c

[PATCH v2 iproute2-next 3/3] ip: Allow rules to accept a specified protocol

2018-02-21 Thread Donald Sharp
Allow the specification of a protocol when the user adds/modifies/deletes a rule. Signed-off-by: Donald Sharp --- ip/iprule.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ip/iprule.c b/ip/iprule.c index 39008768..192fe215 100644 --- a/ip/iprule.c +++

Re: ss issue on arm not showing UDP listening ports

2018-02-21 Thread Jesse Cooper
Thank you for the suggestions. This is on a raspberry pi 3 not sure if that fact matters. I will notify Raspbian of the issue. On 02/21/2018 03:03 PM, Stefano Brivio wrote: > On Wed, 21 Feb 2018 12:37:31 -0500 > jesse_coo...@codeholics.com wrote: > >> ss utility, iproute2-ss161212 > > Works for

Re: [PATCH net-next v4 0/2] Remove IPVlan module dependencies on IPv6 and L3 Master dev

2018-02-21 Thread David Miller
From: Matteo Croce Date: Wed, 21 Feb 2018 01:31:12 +0100 > The IPVlan module currently depends on IPv6 and L3 Master dev. > Refactor the code to allow building IPVlan module regardless of the value > of CONFIG_IPV6 as done in other drivers like VxLAN or GENEVE. > Also change

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Samudrala, Sridhar
On 2/21/2018 6:02 PM, Jakub Kicinski wrote: On Wed, 21 Feb 2018 12:57:09 -0800, Alexander Duyck wrote: I don't see why the team cannot be there always. It is more the logistical nightmare. Part of the goal here was to work with the cloud base images that are out there such as

Re: [PATCH] selftests/bpf: tcpbpf_kern: use in6_* macros from glibc

2018-02-21 Thread Daniel Borkmann
On 02/21/2018 05:51 PM, Anders Roxell wrote: > Both glibc and the kernel have in6_* macros definitions. Build fails > because it picks up wrong in6_* macro from the kernel header and not the > header from glibc. > > Fixes build error below: > clang -I. -I./include/uapi -I../../../include/uapi >

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Daniel Borkmann
Hi Shuah, On 02/22/2018 12:03 AM, Shuah Khan wrote: > On 02/21/2018 03:48 PM, David Miller wrote: >> From: Anders Roxell >> Date: Wed, 21 Feb 2018 22:30:01 +0100 >> >>> bpf builds a test program for loading BPF ELF files. Add the executable >>> to the .gitignore list.

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Daniel Borkmann
On 02/22/2018 01:37 AM, Shuah Khan wrote: > On 02/21/2018 05:33 PM, Daniel Borkmann wrote: >> Hi Shuah, >> >> On 02/22/2018 12:03 AM, Shuah Khan wrote: >>> On 02/21/2018 03:48 PM, David Miller wrote: From: Anders Roxell Date: Wed, 21 Feb 2018 22:30:01 +0100

[PATCH v2] selftests/bpf/test_maps: exit child process without error in ENOMEM case

2018-02-21 Thread Li Zhijian
From: Li Zhijian test_maps contains a series of stress tests, and previously it will break the rest tests when it failed to alloc memory. --- Failed to create hashmap key=8 value=262144 'Cannot allocate memory' Failed to create hashmap key=16

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Eric Dumazet
On Wed, 2018-02-21 at 19:43 -0800, Alexei Starovoitov wrote: > On Wed, Feb 21, 2018 at 07:04:02PM -0800, Eric Dumazet wrote: > > On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: > > > > ... > > > > > +/* Instead of plain jmp %rax, we emit a retpoline to control > > > + * speculative

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-21 Thread Jason Wang
On 2018年02月21日 00:52, John Fastabend wrote: On 02/20/2018 03:17 AM, Jesper Dangaard Brouer wrote: On Fri, 16 Feb 2018 09:19:02 -0800 John Fastabend wrote: On 02/16/2018 07:41 AM, Jesper Dangaard Brouer wrote: On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang

Re: [PATCH net v2 2/2] tuntap: correctly add the missing xdp flush

2018-02-21 Thread Sergei Shtylyov
Hello! On 2/22/2018 9:24 AM, Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or MSG_MORE is clear. This may lead BUG()

Re: [PATCH net v2 1/2] Revert "tuntap: add missing xdp flush"

2018-02-21 Thread Sergei Shtylyov
On 2/22/2018 9:24 AM, Jason Wang wrote: This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The reason is we try to batch packets for devmap which causes calling xdp_do_flush() under the process context. Simply disable premmption s/under/in/. Disabling preemption. may not

[PATCH iproute2-next v1] rdma: Add batch command support

2018-02-21 Thread Leon Romanovsky
From: Leon Romanovsky Implement an option (-b) to execute RDMAtool commands from supplied file. This follows the same model as in use for ip and devlink tools, by expecting every new command to be on new line. These commands are expected to be without any -* (e.g. -d, -j,

[PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Daniel Borkmann
Implement a retpoline [0] for the BPF tail call JIT'ing that converts the indirect jump via jmp %rax that is used to make the long jump into another JITed BPF image. Since this is subject to speculative execution, we need to control the transient instruction sequence here as well when

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
On Wed, Feb 21, 2018 at 7:26 PM, Sowmini Varadhan wrote: > On (02/21/18 18:45), Willem de Bruijn wrote: >> >> I do mean returning 0 instead of -EAGAIN if control data is ready. >> Something like >> >> @@ -611,7 +611,8 @@ int rds_recvmsg(struct socket *sock, struct

[PATCH v2 net-next] net: dsa: mv88e6xxx: scratch registers and external MDIO pins

2018-02-21 Thread Andrew Lunn
MV88E6352 and later switches support GPIO control through the "Scratch & Misc" global2 register. Two of the pins controlled this way on the mv88e6390 family are the external MDIO pins. They can either by used as part of the MII interface for port 0, GPIOs, or MDIO. Add a function to configure them

[PATCH iproute2] ip: Properly display AF_BRIDGE address information for neighbor events

2018-02-21 Thread Donald Sharp
The vxlan driver when a neighbor add/delete event occurs sends NDA_DST filled with a union: union vxlan_addr { struct sockaddr_in sin; struct sockaddr_in6 sin6; struct sockaddr sa; }; This eventually calls rt_addr_n2a_r which had no handler for the AF_BRIDGE family and

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Samudrala, Sridhar
On 2/21/2018 6:35 PM, Samudrala, Sridhar wrote: On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: I haven't checked emails for days and did not

Re: [PATCH bpf v2] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-21 Thread Yonghong Song
On 2/21/18 7:40 PM, Eric Dumazet wrote: On Tue, 2018-02-13 at 19:17 -0800, Alexei Starovoitov wrote: On Tue, Feb 13, 2018 at 07:00:21PM -0800, Yonghong Song wrote: There is a memory leak happening in lpm_trie map_free callback function trie_free. The trie structure itself does not get freed.

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Alexei Starovoitov
On Wed, Feb 21, 2018 at 07:53:22PM -0800, Eric Dumazet wrote: > > So what kinda comment there would make sense? > > I was thinking of something very explicit : > > /* byte sequence for following assembly code used by eBPF >call ... >... >retq > */ > #define

F.LLI PISTOLESI Snc

2018-02-21 Thread . F.LLI PISTOLESI Snc
Hello , I am looking for a reliable supplier /manufacturer of products for sell in Europe. I came across your listing and wanted to get some information regarding minimum Order Quantities, FOB pricing and also the possibility of packaging including payments terms. So could you please get

[PATCH net v2 1/2] Revert "tuntap: add missing xdp flush"

2018-02-21 Thread Jason Wang
This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The reason is we try to batch packets for devmap which causes calling xdp_do_flush() under the process context. Simply disable premmption may not work since process may move among processors which lead xdp_do_flush() to miss some

[PATCH] net/smc9194: Remove bogus CONFIG_MAC reference

2018-02-21 Thread Finn Thain
AFAIK the only version of smc9194.c with Mac support is the one in the linux-mac68k CVS repo, which never made it to the mainline. Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55. (See pre-git era

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
On Wed, Feb 21, 2018 at 5:14 PM, Sowmini Varadhan wrote: > On (02/21/18 16:54), Willem de Bruijn wrote: >> >> I'd put this optimization behind a socket option. > > Yes, that thought occurred to me as well- I think RDS applications > are unlikely to use the error_queue

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
On (02/21/18 17:50), Willem de Bruijn wrote: > > In the common case no more than one notification will be outstanding, > but with a fixed number of notifications per packet, in edge cases this > list may be long. : > Socket functions block if sk_err is non-zero. See for instance >

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Shuah Khan
On 02/21/2018 05:33 PM, Daniel Borkmann wrote: > Hi Shuah, > > On 02/22/2018 12:03 AM, Shuah Khan wrote: >> On 02/21/2018 03:48 PM, David Miller wrote: >>> From: Anders Roxell >>> Date: Wed, 21 Feb 2018 22:30:01 +0100 >>> bpf builds a test program for loading BPF

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-21 Thread Jakub Kicinski
On Wed, 21 Feb 2018 16:30:07 -0800, Florian Fainelli wrote: > On 02/21/2018 03:46 PM, Jakub Kicinski wrote: > > On Tue, 20 Feb 2018 11:58:22 +0100, Pablo Neira Ayuso wrote: > >> We also have a large range of TCAM based hardware offload outthere > >> that will _not_ work with your BPF HW offload

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jakub Kicinski
On Wed, 21 Feb 2018 12:57:09 -0800, Alexander Duyck wrote: > > I don't see why the team cannot be there always. > > It is more the logistical nightmare. Part of the goal here was to work > with the cloud base images that are out there such as > https://alt.fedoraproject.org/cloud/. With just

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Eric Dumazet
On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: ... > +/* Instead of plain jmp %rax, we emit a retpoline to control > + * speculative execution for the indirect branch. > + */ > +static void emit_retpoline_rax_trampoline(u8 **pprog) > +{ > + u8 *prog = *pprog; > + int cnt = 0;

[PATCH iproute2] README: re-add updated information link

2018-02-21 Thread Jakub Kicinski
From: Quentin Monnet The "Information" link was removed from README file in commit d7843207e6fd ("README: update location of git repositories, remove broken info link"), because it redirected to a page that no longer existed on the Linux Foundation wiki. This page

[PATCH net-next 3/3] nfp: advertise firmware for mixed 10G/25G mode

2018-02-21 Thread Jakub Kicinski
From: Dirk van der Merwe The AMDA0099-0001 platform can support the 1x10G + 1x25G mixed mode operation. Recently, firmware has been added for this configuration mode. Signed-off-by: Dirk van der Merwe Acked-by: Jakub Kicinski

[PATCH net-next] ibmvnic: Split counters for scrq/pools/napi

2018-02-21 Thread Nathan Fontenot
The approach of one counter to rule them all when tracking the number of active sub-crqs, pools, and napi has problems handling some failover scenarios. This is due to the split in initializing the sub crqs, pools and napi in different places and the placement of updating the active counts. This

[PATCH net-next 1/3] nfp: add Makefiles to all directories

2018-02-21 Thread Jakub Kicinski
To be able to build separate objects we need to provide Kbuild with a Makefile in each directory. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/Makefile | 2 ++ drivers/net/ethernet/netronome/nfp/flower/Makefile | 2

[PATCH net-next 0/3] nfp: build and FW initramfs updates

2018-02-21 Thread Jakub Kicinski
Hi! This set brings empty makefiles to allow building single object files (useful for build-testing), Kbuild does not cater to this use case too well. There are two ethernet drivers right now which suffer from this (nfp, aquantia), both are fixed. Dirk adds an uncommon FW image name to the list

[PATCH net-next 2/3] aquantia: add Makefiles to all directories

2018-02-21 Thread Jakub Kicinski
To be able to build separate objects we need to provide Kbuild with a Makefile in each directory. Signed-off-by: Jakub Kicinski --- CC: Igor Russkikh drivers/net/ethernet/aquantia/atlantic/hw_atl/Makefile | 2 ++ 1 file changed, 2

[PATCH iproute2 net-next] ss: print skmeminfo for packet sockets

2018-02-21 Thread Roopa Prabhu
From: Roopa Prabhu before: $ss --packet -p -m p_raw0 0*:eth0 users:(("lldpd",pid=2240,fd=11)) after: $ss --packet -p -m p_raw0 0*:eth0

[PATCH net v2 2/2] tuntap: correctly add the missing xdp flush

2018-02-21 Thread Jason Wang
Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or MSG_MORE is clear. This may lead BUG() since xdp_do_flush() was called under process context

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-21 Thread Andrew Lunn
> +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter, > + int vector_index) > +{ > + struct lan743x_vector *vector = >intr.vector_list > + [vector_index]; > + > + devm_free_irq(>pci.pdev->dev,

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-21 Thread Jason Wang
On 2018年02月16日 23:41, Jesper Dangaard Brouer wrote: On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang wrote: On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: The virtio_net code have three different RX code-paths in receive_buf(). Two of these code paths can handle XDP,

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Alexei Starovoitov
On Wed, Feb 21, 2018 at 07:04:02PM -0800, Eric Dumazet wrote: > On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: > > ... > > > +/* Instead of plain jmp %rax, we emit a retpoline to control > > + * speculative execution for the indirect branch. > > + */ > > +static void

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Bo YU
Hi, On Wed, Feb 21, 2018 at 04:41:05PM +0100, Jason A. Donenfeld wrote: Fixes: 41c87425a1ac ("netlink: do not set cb_running if dump's start() errs") I think you Would better to resend it. Bo,

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Samudrala, Sridhar
On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: I haven't checked emails for days and did not realize the new revision had already came out. And

Re: [PATCH bpf v2] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-21 Thread Eric Dumazet
On Tue, 2018-02-13 at 19:17 -0800, Alexei Starovoitov wrote: > On Tue, Feb 13, 2018 at 07:00:21PM -0800, Yonghong Song wrote: > > There is a memory leak happening in lpm_trie map_free callback > > function trie_free. The trie structure itself does not get freed. > > > > Also, trie_free function

[PATCH bpf] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-21 Thread Yonghong Song
Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback function") fixed a memory leak and removed unnecessary locks in map_free callback function. Unfortrunately, it introduced a lockdep warning. When lockdep checking is turned on, running

Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-21 Thread Neal Cardwell
On Wed, Feb 21, 2018 at 9:43 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > BBR uses tcp_tso_autosize() in an attempt to probe what would be the > burst sizes and to adjust cwnd in bbr_target_cwnd() with following > gold formula : > > /* Allow

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Jason A. Donenfeld
Fixes: 41c87425a1ac ("netlink: do not set cb_running if dump's start() errs")

Re: [PATCH iproute2-next] rdma: Add batch command support

2018-02-21 Thread Leon Romanovsky
On Wed, Feb 21, 2018 at 09:10:45AM -0700, David Ahern wrote: > On 2/21/18 5:38 AM, Leon Romanovsky wrote: > > @@ -36,17 +37,54 @@ static int rd_cmd(struct rd *rd) > > { 0 } > > }; > > > > + rd->argc = argc; > > + rd->argv = argv; > > + > > return rd_exec_cmd(rd, cmds,

Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-21 Thread Soheil Hassas Yeganeh
On Wed, Feb 21, 2018 at 10:14 AM Neal Cardwell wrote: > On Wed, Feb 21, 2018 at 9:43 AM, Eric Dumazet wrote: > > > > From: Eric Dumazet > > > > BBR uses tcp_tso_autosize() in an attempt to probe what would be the > > burst

Re: [4.15-stable 1/1] uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define

2018-02-21 Thread David Miller
From: Mark Asselstine Date: Wed, 21 Feb 2018 10:13:18 -0500 > Please promote commit da360299b6734135a5f66d7db458dcc7801c826a [uapi/ > if_ether.h: move __UAPI_DEF_ETHHDR libc define] to linux-4.15.y stable. > Without this fix users of the uapi headers will run into

ss issue on arm not showing UDP listening ports

2018-02-21 Thread jesse_cooper
Hi, I currently had the follow issues with ss where it was not displaying the UDP listening ports.This was on: Linux 4.9.59-v7+ #1047 SMP Sun Oct 29 12:19:23 GMT 2017 armv7l GNU/Linux ss -ul State Recv-Q Send-Q Local Address:Port Peer Address:Port netstat -ul Active Internet

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread David Miller
From: Roman Kapl Date: Wed, 21 Feb 2018 09:49:31 +0100 > Should I send a v3 or something, David? No, it's too late to fix it, sorry.

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 1:51 AM, Jiri Pirko wrote: > Tue, Feb 20, 2018 at 11:33:56PM CET, kubak...@wp.pl wrote: >>On Tue, 20 Feb 2018 21:14:10 +0100, Jiri Pirko wrote: >>> Yeah, I can see it now :( I guess that the ship has sailed and we are >>> stuck with this ugly thing

Re: [PATCH iproute2-next] rdma: Add batch command support

2018-02-21 Thread David Ahern
On 2/21/18 5:38 AM, Leon Romanovsky wrote: > @@ -36,17 +37,54 @@ static int rd_cmd(struct rd *rd) > { 0 } > }; > > + rd->argc = argc; > + rd->argv = argv; > + > return rd_exec_cmd(rd, cmds, "object"); > } > > -static int rd_init(struct rd *rd, int argc, char

Re: [PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-21 Thread Ido Schimmel
On Mon, Feb 12, 2018 at 04:06:00PM -0800, David Ahern wrote: > Some operators prefer IPv6 path selection to use a standard 5-tuple > hash rather than just an L3 hash with the flow the label. To that end > add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb > ("net: ipv4: add

Re: [PATCH v2 iproute2-next 0/5] bridge: json and color support

2018-02-21 Thread David Ahern
On 2/20/18 12:24 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > This set of patches adds color and full JSON support to bridge command. > > The output format for bridge link command changes so that > $ bridge link show > and > $ ip link show > use same

  1   2   >