[PATCH] pktgen: Fix memory leak in pktgen_if_write

_buf_ is an array and the one that must be freed is _tp_ instead. Fixes: a870a02cc963 ("pktgen: use dynamic allocation for debug print buffer") Reported-by: Wang Jian Signed-off-by: Gustavo A. R. Silva --- net/core/pktgen.c | 2 +- 1 file

Re: [PATCH] pktgen: use dynamic allocation for debug print buffer

Arnd: Thanks for the fix. On 03/13/2018 10:02 PM, Wang Jian wrote: + kfree(buf); free tb? buf is an array. Wang: Thanks for the report. I already sent a patch to fix this: https://patchwork.kernel.org/patch/10281587/ -- Gustavo On Wed, Mar 14, 2018 at 8:25 AM, David Miller

Re: [PATCH] pktgen: Fix memory leak in pktgen_if_write

On Wed, Mar 14, 2018 at 9:07 AM, Gustavo A. R. Silva wrote: > _buf_ is an array and the one that must be freed is _tp_ instead. > > Fixes: a870a02cc963 ("pktgen: use dynamic allocation for debug print buffer") > Reported-by: Wang Jian >

Re: [PATCH RFC bpf-next 1/6] bpf: Hooks for sys_bind

On 03/13/2018 08:39 PM, Alexei Starovoitov wrote: From: Andrey Ignatov == The problem == There is a use-case when all processes inside a cgroup should use one single IP address on a host that has multiple IP configured. Those processes should use the IP for both ingress and

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

On Wed, Mar 14, 2018 at 3:50 AM, Jakub Kicinski wrote: > On Tue, 13 Mar 2018 17:53:39 +0200, Or Gerlitz wrote: >> > Starting with type 2, in our current NIC HW APIs we have to duplicate >> > these rules >> > into two rules set to HW: >> > >> > 2.1 VF rep --> uplink 0

[v4.15.9] BUG: KASAN: slab-out-of-bounds in __dev_queue_xmit+0x2e5/0x14c0

Hi, I got the following warning on the v4.15.9 kernel. :[ 4483.052174] == :[ 4483.052659] BUG: KASAN: slab-out-of-bounds in __dev_queue_xmit+0x2e5/0x14c0 :[ 4483.052937] Read of size 1 at addr 880067ef7bc0 by task objtool/26177

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Tue, Mar 13, 2018 at 08:06:50PM +0100, Mohammed Gamal wrote: > @@ -791,6 +791,7 @@ static inline int netvsc_send_pkt( > > VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED); > } > > + ring_avail = hv_ringbuf_avail_percent(_channel->outbound); >

Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc]

> Il 9 marzo 2018 alle 0.14 Cong Wang ha scritto: > > > On Thu, Mar 8, 2018 at 8:02 AM, Marco Berizzi wrote: > >> Marco Berizzi wrote: > >> > >> > >> Hello everyone, > >> > >> Yesterday I got this error on a slackware linux 4.16-rc4 system > >>

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hello, There was a series of patches by Serhey and specifically this one: https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=93fa12418dc6f5943692250244be303bb162175b It drops handling of special prefix names in get_prefix_1(), and in get_addr_1() they always receive family

Re: [PATCH] can: enable multi-queue for SocketCAN devices

On 03/14/2018 11:33 AM, Mark Jonas wrote: > From: Zhu Yi > > The existing SocketCAN implementation provides alloc_candev() to > allocate a CAN device using a single Tx and Rx queue. This can lead to > priority inversion in case the single Tx queue is already full with low >

Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs

On 2018-03-14 01:08, Timur Tabi wrote: On 3/13/18 10:20 PM, Sinan Kaya wrote: +/* Assumes caller has executed a write barrier to order memory and device + * requests. + */ static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value) { - writel(value, ring->tail); +

Re: [pci PATCH v6 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

On Tue, Mar 13, 2018 at 02:28:49PM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch adds a common configuration function called > pci_sriov_configure_simple that will allow for managing VFs on devices > where the PF is not capable of managing VF

Re: [pci PATCH v6 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

Looks good, Reviewed-by: Christoph Hellwig

Re: [pci PATCH v6 4/5] nvme: Migrate over to unmanaged SR-IOV support

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH] can: enable multi-queue for SocketCAN devices

Hello Marc, > > The existing SocketCAN implementation provides alloc_candev() to > > allocate a CAN device using a single Tx and Rx queue. This can lead to > > priority inversion in case the single Tx queue is already full with low > > priority messages and a high priority message needs to be

Re: [PATCH] can: enable multi-queue for SocketCAN devices

On 03/14/2018 01:26 PM, Jonas Mark (BT-FIR/ENG1) wrote: >> Do you have a driver or a patch to make a driver mq aware? > > Yes, we have CAN hardware with multiple queues and we also have a > SocketCAN driver for it. > > IMHO the driver will be of very little use for the Linux community > because

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Tue, 2018-03-13 at 12:35 -0700, Stephen Hemminger wrote: > On Tue, 13 Mar 2018 20:06:50 +0100 > Mohammed Gamal wrote: > > > Dring high network traffic changes to network interface parameters > > such as number of channels or MTU can cause a kernel panic with a > > NULL > >

Re: [bug, bisected] pfifo_fast causes packet reordering

On 14.03.18 05:03, John Fastabend wrote: During stress-testing our "ucan" USB/CAN adapter SocketCAN driver on Linux v4.16-rc4-383-ged58d66f60b3 we observed that a small fraction of packets are delivered out-of-order. Is the stress-testing tool available somewhere? What type of packets are

[PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's firmwares. This is an obsoleted standard and its implementation is something that: 1)

[PATCH] can: enable multi-queue for SocketCAN devices

From: Zhu Yi The existing SocketCAN implementation provides alloc_candev() to allocate a CAN device using a single Tx and Rx queue. This can lead to priority inversion in case the single Tx queue is already full with low priority messages and a high priority message needs

RE: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

From: Kees Cook > Sent: 13 March 2018 22:15 ... > I'll send a "const_max()" which will refuse to work on > non-constant-values (so it doesn't get accidentally used on variables > that could be exposed to double-evaluation), and will work for stack > array declarations (to avoid the

Re: [PATCH 3/7] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs

On 2018-03-14 00:12, Jason Gunthorpe wrote: On Tue, Mar 13, 2018 at 11:20:24PM -0400, Sinan Kaya wrote: Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before

Re: [PATCH v4 net-next 2/6] net/ipv6: Change address check to always take a device argument

On Tue, Mar 13, 2018 at 08:29:37AM -0700, David Ahern wrote: > ipv6_chk_addr_and_flags determines if an address is a local address and > optionally if it is an address on a specific device. For example, it is > called by ip6_route_info_create to determine if a given gateway address > is a local

Re: [PATCH v4 net-next 1/6] net/ipv6: Refactor gateway validation on route add

On Tue, Mar 13, 2018 at 08:29:36AM -0700, David Ahern wrote: > Move gateway validation code from ip6_route_info_create into > ip6_validate_gw. Code move plus adjustments to handle the potential > reset of dev and idev and to make checkpatch happy. > > Signed-off-by: David Ahern

[PATCH net v2] ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu

Prior to the rework of PMTU information storage in commit 2c8cec5c10bc ("ipv4: Cache learned PMTU information in inetpeer."), when a PMTU event advertising a PMTU smaller than net.ipv4.route.min_pmtu was received, we would disable setting the DF flag on packets by locking the MTU metric, and set

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" writes: > Added Konstantin in case he is in charge of administering > patchwork.kernel.org? > > On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees Cook wrote: >> On Tue, Mar 13, 2018 at 7:11 PM, Tobin C. Harding wrote: >> > On Tue, Mar 13, 2018 at

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: >> Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >>>Allow drivers to register netdev callbacks for tc offload in linux bonds. >>>If a

[PATCH 2/2] can: cc770: Fix queue stall & dropped RTR reply

From: Andri Yngvason While waiting for the TX object to send an RTR, an external message with a matching id can overwrite the TX data. In this case we must call the rx routine and then try transmitting the message that was overwritten again. The queue was being stalled

[PATCH 1/2] can: cc770: Fix stalls on rt-linux, remove redundant IRQ ack

From: Andri Yngvason This has been reported to cause stalls on rt-linux. Suggested-by: Richard Weinberger Tested-by: Richard Weinberger Signed-off-by: Andri Yngvason Cc: linux-stable

pull-request: can 2018-03-14

f89782c2d131e6eae0d1ea2569ba76bc4c5875fe: qed: Use after free in qed_rdma_free() (2018-03-13 10:54:17 -0400) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.16-20180314 for you to fetch changes up

Re: [PATCH v5 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

On Tue, Mar 13, 2018 at 08:51:51AM -0500, Razvan Stefanescu wrote: > Add the command build/parse APIs for operating on DPSW objects through > the DPAA2 Management Complex. > > Signed-off-by: Razvan Stefanescu > --- > Changelog: > v2: > - use u8 for en parameter of

Re: [RESEND] rsi: Remove stack VLA usage

tcharding writes: > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> tcharding wrote: >> >> > The kernel would like to have all stack VLA usage removed[1]. rsi uses >> > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size >> >

[PATCH net-next 3/3] net/smc: schedule free_work when link group is terminated

From: Karsten Graul The free_work worker must be scheduled when the link group is abnormally terminated. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/smc_core.c | 20 +---

[PATCH net-next 4/5] sctp: add SCTP_AUTH_FREE_KEY type for AUTHENTICATION_EVENT

This patch is to add SCTP_AUTH_FREE_KEY type for AUTHENTICATION_EVENT, as described in section 6.1.8 of RFC6458. SCTP_AUTH_FREE_KEY: This report indicates that the SCTP implementation will no longer use the key identifier specified in auth_keynumber. After deactivating a

[PATCH net-next 2/5] sctp: add support for SCTP AUTH Information for sendmsg

This patch is to add support for SCTP AUTH Information for sendmsg, as described in section 5.3.8 of RFC6458. With this option, you can provide shared key identifier used for sending the user message. It's also a necessary send info for sctp_sendv. Note that it reuses sinfo->sinfo_tsn to

Re: [pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

> + > +/** > + * pci_pf_stub_white_list - White list of devices to bind pci-pf-stub onto > + * > + * This table provides the list of IDs this driver is supposed to bind > + * onto. You could think of this as a list of "quirked" devices where we > + * are adding support for SR-IOV here since there

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" writes: > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: >> On Tue, Mar 13, 2018 at 10:17 PM, tcharding wrote: >> > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> >> tcharding wrote: >> >> I'm

[PATCH net-next 0/5] sctp: add support for some sctp auth APIs from RFC6458

This patchset mainly adds support for SCTP AUTH Information for sendmsg, described in RFC6458: 5.3.8. SCTP AUTH Information Structure (SCTP_AUTHINFO) and also adds a sockopt described in RFC6458: 8.3.4. Deactivate a Shared Key (SCTP_AUTH_DEACTIVATE_KEY) and two types of events for

[PATCH net-next 1/5] sctp: add refcnt support for sh_key

With refcnt support for sh_key, chunks auth sh_keys can be decided before enqueuing it. Changing the active key later will not affect the chunks already enqueued. Furthermore, this is necessary when adding the support for authinfo for sendmsg in next patch. Note that struct sctp_chunk can't be

[PATCH net-next 5/5] sctp: add SCTP_AUTH_NO_AUTH type for AUTHENTICATION_EVENT

This patch is to add SCTP_AUTH_NO_AUTH type for AUTHENTICATION_EVENT, as described in section 6.1.8 of RFC6458. SCTP_AUTH_NO_AUTH: This report indicates that the peer does not support SCTP authentication as defined in [RFC4895]. Note that the implementation is quite similar as

[PATCH net-next 3/5] sctp: add sockopt SCTP_AUTH_DEACTIVATE_KEY

This patch is to add sockopt SCTP_AUTH_DEACTIVATE_KEY, as described in section 8.3.4 of RFC6458. This set option indicates that the application will no longer send user messages using the indicated key identifier. Note that RFC requires that only deactivated keys that are no longer used by an

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

On Wed, Mar 14, 2018 at 11:50 AM, Jiri Pirko wrote: > Tue, Mar 13, 2018 at 04:51:02PM CET, gerlitz...@gmail.com wrote: >>On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: >>This sounds nice for the case where one install ingress tc rules on >>the bond (lets

RE: [PATCH] net: dsa: drop some VLAs in switch.c

From: Salvatore Mesoraca > Sent: 13 March 2018 22:01 > 2018-03-13 20:58 GMT+01:00 Vivien Didelot > : > > Hi Salvatore, > > Hi Vivien, > > > Salvatore Mesoraca writes: > > > >> dsa_switch's num_ports is currently fixed to

Re: pull-request: can 2018-03-14

ite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git > tags/linux-can-fixes-for-4.16-20180314 > > for you to fetch changes up to 746201235b3f876792099079f4c6fea941d76183: > > can: cc770: Fix queue stall & dropped RTR reply (2018-03-14 13:01:22 +0100) > > -

[PATCH net-next 2/3] net/smc: free link group without pending free_work only

Make sure there is no pending or running free_work worker for the link group when freeing the link group. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 1 + net/smc/smc_core.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 1/3] net/smc: pay attention to MAX_ORDER for CQ entries

smc allocates a certain number of CQ entries for used RoCE devices. For mlx5 devices the chosen constant number results in a large allocation causing this warning: [13355.124656] WARNING: CPU: 3 PID: 16535 at mm/page_alloc.c:3883 __alloc_pages_nodemask+0x2be/0x10c0 [13355.124657] Modules linked

[PATCH net-next 0/3] net/smc: fixes 2018-03-14

here are smc changes for the net-next tree. The first patch enables SMC to work with mlx5-RoCE-devices. Patches 2 and 3 deal with link group freeing. Thanks, Ursula Karsten Graul (1): net/smc: schedule free_work when link group is terminated Ursula Braun (2): net/smc: pay attention to

Re: [PATCH v4 net-next 3/6] net/ipv6: Add l3mdev check to ipv6_chk_addr_and_flags

On Tue, Mar 13, 2018 at 08:29:38AM -0700, David Ahern wrote: > Lookup the L3 master device for the passed in device. Only consider > addresses on netdev's with the same master device. If the device is > not enslaved or is NULL, then the l3mdev is NULL which means only > devices not enslaved (ie,

Re: pull-request: can 2018-03-14

t; >> The following changes since commit > >> f89782c2d131e6eae0d1ea2569ba76bc4c5875fe: > >> > >> qed: Use after free in qed_rdma_free() (2018-03-13 10:54:17 -0400) > >> > >> are available in the Git repository at: >

[PATCH 2/5] dpaa_eth: fix error in dpaa_remove()

The recent changes that make the driver probing compatible with DSA were not propagated in the dpa_remove() function, breaking the module unload function. Using the proper device to address the issue. Signed-off-by: Madalin Bucur ---

[PATCH 3/5] dpaa_eth: remove duplicate initialization

From: Camelia Groza The fd_format has already been initialized at this point. Signed-off-by: Camelia Groza --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 1/5] soc/fsl/qbman: fix issue in qman_delete_cgr_safe()

The wait_for_completion() call in qman_delete_cgr_safe() was triggering a scheduling while atomic bug, replacing the kthread with a smp_call_function_single() call to fix it. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge ---

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

On Tue, 13 Mar 2018 14:14:14 -0700 Jesse Brandeburg wrote: > Maybe it's just that I've been doing this too long, but I regularly > (and many other customers/users do as well) depend on the ethtool stats > being atomically updated w.r.t. each other. This means that if

[PATCH net] tg3: prevent scheduling while atomic splat

The problem was introduced in commit 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs because tp->lock spinlock is held which is obtained in tg3_start by way of tg3_full_lock(), line 11571. The documentation for usleep_range() specifically states it cannot be used inside a

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: > The blackfin architecture is getting removed, so this > driver is now obsolete. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/irda/drivers/Kconfig| 45 -- > drivers/staging/irda/drivers/Makefile |

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

On Wed, Mar 14, 2018 at 5:32 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: >> The blackfin architecture is getting removed, so this >> driver is now obsolete. >> >> Signed-off-by: Arnd Bergmann >> --- >>

[PATCH net-next] sock: remove zerocopy sockopt restriction on closed tcp state

From: Willem de Bruijn Socket option SO_ZEROCOPY determines whether the kernel ignores or processes flag MSG_ZEROCOPY on subsequent send calls. This to avoid changing behavior for legacy processes. Limiting the state change to closed sockets is annoying with passive sockets

Re: [PATCH net-next] sock: remove zerocopy sockopt restriction on closed tcp state

From: Willem de Bruijn Date: Wed, 14 Mar 2018 12:49:19 -0400 > From: Willem de Bruijn > > Socket option SO_ZEROCOPY determines whether the kernel ignores or > processes flag MSG_ZEROCOPY on subsequent send calls. This to avoid > changing

Re: [PATCH] can: enable multi-queue for SocketCAN devices

Hello Marc, > >> Do you have a driver or a patch to make a driver mq aware? > > > > Yes, we have CAN hardware with multiple queues and we also have a > > SocketCAN driver for it. > > > > IMHO the driver will be of very little use for the Linux community > > because the HW is proprietary. > >

[PATCH] vhost: fix vhost ioctl signature to build with clang

Clang is particularly anal about signed vs unsigned comparisons and doesn't like the fact that some ioctl numbers set the MSB, so we get this error when trying to build vhost on aarch64: drivers/vhost/vhost.c:1400:7: error: overflow converting case value to switch condition type (3221794578 to

Re: [PATCH 0/5] DPAA Ethernet fixes

From: Madalin Bucur Date: Wed, 14 Mar 2018 08:37:27 -0500 > This patch set is addressing several issues in the DPAA Ethernet > driver suite: > > - module unload crash caused by wrong reference to device being left >in the cleanup code after the DSA related changes >

[PATCH bpf-next v6 0/2] bpf stackmap with build_id+offset

Changes v4 -> v6: 1. When kernel stack is added to stackmap with build_id, use fallback mechanism to store ip (status == BPF_STACK_BUILD_ID_IP). Changes v4 -> v5: 1. Only allow build_id lookup in non-nmi context. Added comment and commit message to highlight this limitation. 2. Minor fix

[PATCH bpf-next v6 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

Currently, bpf stackmap store address for each entry in the call trace. To map these addresses to user space files, it is necessary to maintain the mapping from these virtual address to symbols in the binary. Usually, the user space profiler (such as perf) has to scan /proc/pid/maps at the

[PATCH bpf-next v6 2/2] bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID

test_stacktrace_build_id() is added. It accesses tracepoint urandom_read with "dd" and "urandom_read" and gathers stack traces. Then it reads the stack traces from the stackmap. urandom_read is a statically link binary that reads from /dev/urandom. test_stacktrace_build_id() calls readelf to read

Re: [PATCH net-next] liquidio: Add support for liquidio 10GBase-T NIC

From: Felix Manlunas Date: Tue, 13 Mar 2018 22:04:45 -0700 > From: Veerasenareddy Burru > > Added ethtool changes to show port type as TP (Twisted Pair) for > 10GBASE-T ports. Same driver and firmware works for liquidio NIC with >

[PATCH 00/16] remove eight obsolete architectures

Here is the collection of patches I have applied to my 'asm-generic' tree on top of the 'metag' removal. This does not include any of the device drivers, I'll send those separately to a someone different list of people. The removal came out of a discussion that is now documented at

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 3/14/2018 3:24 PM, Kalle Valo wrote: +config BRCMFMAC_IAPP >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >+ depends on BRCMFMAC >+ ---help--- >+ Most of Broadcom's firmwares can send 802.11f ADD frame every >+ time new STA connects to the AP interface. Some

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 13:58, Arend van Spriel wrote: On 3/14/2018 12:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in

Re: [PATCH RFC bpf-next 0/6] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

On 3/13/18 8:39 PM, Alexei Starovoitov wrote: > For our container management we've been using complicated and fragile setup > consisting of LD_PRELOAD wrapper intercepting bind and connect calls from > all containerized applications. > The setup involves per-container IPs, policy, etc, so

Re: [PATCH net-next] tuntap: XDP_TX can use native XDP

From: Jason Wang Date: Wed, 14 Mar 2018 11:23:40 +0800 > Now we have ndo_xdp_xmit, switch to use it instead of the slow generic > XDP TX routine. XDP_TX on TAP gets ~20% improvements from ~1.5Mpps to > ~1.8Mpps on 2.60GHz Core(TM) i7-5600U. > > Signed-off-by: Jason Wang

Re: [PATCH net] tg3: prevent scheduling while atomic splat

On 03/14/2018 01:22 PM, Michael Chan wrote: > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock spinlock is held which is obtained in

Re: [PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

> On Mar 14, 2018, at 9:07 AM, Daniel Borkmann wrote: > > Just a minor question below, the rest seems fine to me as far as I > can tell. > > On 03/13/2018 10:47 PM, Song Liu wrote: > [...] >> +enum bpf_stack_build_id_status { >> +/* user space need an empty entry to

Re: [PATCH net-next 2/2] skbuff: Fix not waking applications when errors are enqueued

On 03/13/2018 01:35 PM, Vinicius Costa Gomes wrote: When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in

Re: [PATCH net] net: use skb_to_full_sk() in skb_update_prio()

From: Eric Dumazet Date: Wed, 14 Mar 2018 09:04:16 -0700 > Andrei Vagin reported a KASAN: slab-out-of-bounds error in > skb_update_prio() > > Since SYNACK might be attached to a request socket, we need to > get back to the listener socket. > Since this listener is

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

On 2018-03-14 15:24, Kalle Valo wrote: Rafał Miłecki writes: From: Rafał Miłecki Testing brcmfmac with more recent firmwares resulted in AP interfaces not working in some specific setups. Debugging resulted in discovering support for IAPP in Broadcom's

Re: [PATCH net-next 0/2] sfc: support FEC configuration

From: Edward Cree Date: Wed, 14 Mar 2018 14:19:11 + > Implements the ethtool get & set fecparam operations. Series applied, thanks.

Re: [PATCH RFC bpf-next 0/6] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

On Tue, Mar 13, 2018 at 8:39 PM, Alexei Starovoitov wrote: > For our container management we've been using complicated and fragile setup > consisting of LD_PRELOAD wrapper intercepting bind and connect calls from > all containerized applications. > The setup involves

Re: [PATCH net] tg3: prevent scheduling while atomic splat

On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: > The problem was introduced in commit > 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs > because tp->lock spinlock is held which is obtained in tg3_start > by way of tg3_full_lock(), line 11571.

RE: [Intel-wired-lan] [next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211

Hi, "Brown, Aaron F" writes: >> --- a/drivers/net/ethernet/intel/igb/igb_main.c >> +++ b/drivers/net/ethernet/intel/igb/igb_main.c >> @@ -8747,12 +8747,19 @@ static void igb_rar_set_index(struct igb_adapter >> *adapter, u32 index) >> if

[PATCH] vhost: add vsock compat ioctl

This will allow usage of vsock from 32-bit binaries on a 64-bit kernel. Signed-off-by: Sonny Rao --- drivers/vhost/vsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 0d14e2ff19f16..d0e65e92110e5 100644 ---

Re: [PATCH RFC 5/7] net: phy: make phy_stop synchronous

On 03/14/2018 01:16 PM, Heiner Kallweit wrote: > Currently phy_stop() just sets the state to PHY_HALTED and relies on the > state machine to do the remaining work. It can take up to 1s until the > state machine runs again what causes issues in situations where e.g. > driver / device is brought

[PATCH] netns: send uevent messages

This patch adds a receive method to NETLINK_KOBJECT_UEVENT netlink sockets to allow sending uevent messages into the network namespace the socket belongs to. Currently non-initial network namespaces are already isolated and don't receive uevents. There are a number of cases where it is beneficial

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/xfrm4_policy.c between commit: d52e5a7e7ca4 ("ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu") from the net tree and commit: 68e813aa4307 ("net/ipv4: Remove fib table id from

Re: [PATCH net] net: sched: fix uses after free

On Wed, Mar 14, 2018 at 6:48 PM Eric Dumazet wrote: > syzbot reported one use-after-free in pfifo_fast_enqueue() [1] > Issue here is that we can not reuse skb after a successful skb_array_produce() > since another cpu might have consumed it already. > I believe a similar

Re: regression: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

> I've got additional testing data and this actually a *regression*, because > second CPSW Port became broken after above commits due to Net PHY > connection failure. Hi Grygorii I'm not sure this works by design, more by chance. And i think this is the only MAC driver which does this. Can i

Re: [PATCH 6/7] e1000: eliminate duplicate barriers on weakly-ordered archs

On Tue, Mar 13, 2018 at 8:20 PM, Sinan Kaya wrote: > Code includes wmb() followed by writel(). writel() already has a barrier > on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Since code

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > switch objects discovered on the fsl-mc bus. A description of the driver > can

Re: [PATCH RFC 3/7] net: phy: resume PHY only if needed in, mdio_bus_phy_suspend

On 03/14/2018 01:16 PM, Heiner Kallweit wrote: > Currently the PHY is unconditionally resumed in mdio_bus_phy_suspend(). > In cases where the PHY was sleepinh before suspending or if somebody else > takes care of resuming later, this is not needed and wastes energy. > > Also start the state

Re: KASAN: use-after-free Read in pfifo_fast_enqueue

On 03/14/2018 04:30 PM, syzbot wrote: > syzbot has found reproducer for the following crash on net-next commit > a870a02cc963de35452bbed932560ed69725c4f2 (Tue Mar 13 20:58:39 2018 +) > pktgen: use dynamic allocation for debug print buffer > > So far this crash happened 7 times on mmots,

Re: KASAN: use-after-free Read in pfifo_fast_enqueue

On 03/14/2018 05:16 PM, Eric Dumazet wrote: > > typical use after free... > > diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c > index > 190570f21b208d5a17943360a3a6f85e1c2a2187..663e016491773f40f81d9bbfeab3dd68e1c2fc5c > 100644 > --- a/net/sched/sch_generic.c > +++

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

On Wed, Mar 14, 2018 at 08:14:53PM -0700, David Ahern wrote: > On 3/13/18 2:13 PM, Jason Gunthorpe wrote: > > Could you pull the uapi headers from linux-next? That tree will have > > both netdev and rdma stuff merged together properly. > > What's the merge history between linux-next, Linus' tree,

Re: [PATCH RFC bpf-next 1/6] bpf: Hooks for sys_bind

On Wed, Mar 14, 2018 at 05:17:54PM -0700, Eric Dumazet wrote: > > > On 03/14/2018 11:41 AM, Alexei Starovoitov wrote: > > On Wed, Mar 14, 2018 at 11:00 AM, Alexei Starovoitov > > wrote: > >> > >>> It seems this is exactly the case where a netns would be the correct

Re: [PATCH 00/47] arch-removal: device drivers

Hi Arnd, On Wed, 14 Mar 2018 16:35:13 +0100 Arnd Bergmann wrote: > Hi driver maintainers, > > I just posted one series with the removal of eight architectures, > see https://lkml.org/lkml/2018/3/14/505 for details, or > https://lwn.net/Articles/748074/ for more background. > >

[no subject]

Hi Netdev https://goo.gl/UjB6a9 Avery

Re: [PATCH 06/47] net: smsc: remove m32r specific smc91x configuration

On Wed, 14 Mar 2018, Nicolas Pitre wrote: > On Wed, 14 Mar 2018, Arnd Bergmann wrote: > > > The m32r architecture is getting removed, so this part can be > > cleaned up as well. > > > > Signed-off-by: Arnd Bergmann > > Acked-by: Nicolas Pitre > > > --- > >

Re: [PATCH v2 net] net: sched: fix uses after free

On 03/14/2018 08:10 PM, John Fastabend wrote: > On 03/14/2018 06:53 PM, Eric Dumazet wrote: >> syzbot reported one use-after-free in pfifo_fast_enqueue() [1] >> >> Issue here is that we can not reuse skb after a successful >> skb_array_produce() >> since another cpu might have consumed it

Re: [PATCH RFC 0/7] net: phy: patch series aiming to improve few aspects of phylib

On 03/14/2018 01:10 PM, Heiner Kallweit wrote: > This patch series aims to tackle few issues with phylib: > > - address issues with patch series [1] (smsc911x + phylib changes) > - make phy_stop synchronous > - get rid of phy_start/stop_machine and handle it in phy_start/phy_stop > - in

Re: [PATCH 2/7] ixgbe: eliminate duplicate barriers on weakly-ordered archs

On Tue, Mar 13, 2018 at 8:20 PM, Sinan Kaya wrote: > Code includes wmb() followed by writel() in multiple places. writel() > already has a barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register

[PATCH net] net: sched: fix uses after free

syzbot reported one use-after-free in pfifo_fast_enqueue() [1] Issue here is that we can not reuse skb after a successful skb_array_produce() since another cpu might have consumed it already. I believe a similar problem exists in try_bulk_dequeue_skb_slow() in case we put an skb into

Re: [PATCH 2/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On Wed, Mar 14, 2018 at 05:26:24PM -0500, Grygorii Strashko wrote: > Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per > one netdevice, as result such drivers will produce warning during system > boot and fail to connect second phy to netdevice when PHYLIB framework >

  1   2   3   >