Re: [v3] Bluetooth: btrsi: rework dependencies

Arnd Bergmann wrote: > The linkage between the bluetooth driver and the wireless > driver is not defined properly, leading to build problems > such as: > > warning: (BT_HCIRSI) selects RSI_COEX which has unmet direct dependencies > (NETDEVICES && WLAN && WLAN_VENDOR_RSI &&

Re: [v2] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The use of stack Variable Length Arrays needs to be avoided, as they > can be a vector for stack exhaustion, which can be both a runtime bug > (kernel Oops) or a security flaw (overwriting memory beyond the > stack). Also, in general, as code evolves it

[PATCH net 0/1] net/smc: fix clc problem

Dave, the conversion from kernel_recvmsg() to sock_recvmsg() introduced a problem for SMC. This patch fixes it. Thanks, Ursula Ursula Braun (1): net/smc: use announced length in sock_recvmsg() net/smc/smc_clc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.13.5

[bpf-next V6 PATCH 14/15] xdp: transition into using xdp_frame for return API

Changing API xdp_return_frame() to take struct xdp_frame as argument, seems like a natural choice. But there are some subtle performance details here that needs extra care, which is a deliberate choice. When de-referencing xdp_frame on a remote CPU during DMA-TX completion, result in the

[bpf-next V6 PATCH 11/15] page_pool: refurbish version of page_pool code

Need a fast page recycle mechanism for ndo_xdp_xmit API for returning pages on DMA-TX completion time, which have good cross CPU performance, given DMA-TX completion time can happen on a remote CPU. Refurbish my page_pool code, that was presented[1] at MM-summit 2016. Adapted page_pool code to

[bpf-next V6 PATCH 12/15] xdp: allow page_pool as an allocator type in xdp_return_frame

New allocator type MEM_TYPE_PAGE_POOL for page_pool usage. The registered allocator page_pool pointer is not available directly from xdp_rxq_info, but it could be (if needed). For now, the driver should keep separate track of the page_pool pointer, which it should use for RX-ring page

[bpf-next V6 PATCH 15/15] xdp: transition into using xdp_frame for ndo_xdp_xmit

Changing API ndo_xdp_xmit to take a struct xdp_frame instead of struct xdp_buff. This brings xdp_return_frame and ndp_xdp_xmit in sync. This builds towards changing the API further to become a bulk API, because xdp_buff is not a queue-able object while xdp_frame is. V4: Adjust for commit

[bpf-next V6 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page returns the page through the page allocator. And at the same time, have pages getting returned to the page_pool from ndp_xdp_xmit DMA completion. The

[bpf-next V6 PATCH 09/15] mlx5: register a memory model when XDP is enabled

Now all the users of ndo_xdp_xmit have been converted to use xdp_return_frame. This enable a different memory model, thus activating another code path in the xdp_return_frame API. V2: Fixed issues pointed out by Tariq. Signed-off-by: Jesper Dangaard Brouer Reviewed-by: Tariq

[bpf-next V6 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

Use the IDA infrastructure for getting a cyclic increasing ID number, that is used for keeping track of each registered allocator per RX-queue xdp_rxq_info. Instead of using the IDR infrastructure, which uses a radix tree, use a dynamic rhashtable, for creating ID to pointer lookup table, because

[bpf-next V6 PATCH 08/15] bpf: cpumap convert to use generic xdp_frame

The generic xdp_frame format, was inspired by the cpumap own internal xdp_pkt format. It is now time to convert it over to the generic xdp_frame format. The cpumap needs one extra field dev_rx. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h |1 +

[bpf-next V6 PATCH 07/15] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

The virtio_net driver assumes XDP frames are always released based on page refcnt (via put_page). Thus, is only queues the XDP data pointer address and uses virt_to_head_page() to retrieve struct page. Use the XDP return API to get away from such assumptions. Instead queue an xdp_frame, which

RE: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Tuesday, March 27, 2018 1:45 AM > To: Vicenţiu Galanopulo ; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; robh...@kernel.org; > mark.rutl...@arm.com;

Re: [net-next 03/15] net/mlx5e: PFC stall prevention support

On 25-Mar-18 19:18, Andrew Lunn wrote: >>> Shouldn't you map a value of MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC back to >>> PFC_STORM_PREVENTION_AUTO? >> >> We discussed this point internally, mapping MLX5E_PFC_PREVEN_AUTO_TOUT_MSEC >> (100) to >> PFC_STORM_PREVENTION_AUTO might cause confusion when the

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

On 3/27/2018 12:15 PM, John Fastabend wrote: On 03/25/2018 11:54 PM, Prashant Bhole wrote: When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, when sg table is initialized using sg_init_table(). Magic is checked while navigating the scatterlist. We hit BUG_ON when magic

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

On 03/27/2018 05:06 AM, Du, Changbin wrote: > On Mon, Mar 26, 2018 at 08:02:30PM -0700, Alexei Starovoitov wrote: >> On Tue, Mar 27, 2018 at 10:20:10AM +0800, Du, Changbin wrote: >>> On Mon, Mar 26, 2018 at 07:55:13AM -0700, Alexei Starovoitov wrote: On Mon, Mar 26, 2018 at 05:23:28PM +0800,

Re: [next] rsi: remove redundant duplicate assignment of buffer_size

Colin Ian King wrote: > From: Colin Ian King > > Variable buffer_size is re-assigned the same value, this duplicated > assignment is redundant and can be removed. > > Cleans up clang warning: > drivers/net/wireless/rsi/rsi_91x_usb.c:140:4:

Re: rtlwifi: rtl8821ae: fix spelling mistake: "Aboslute" -> "Absolute"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message text. > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger

Re: [PATCH v2 bpf-next] bpf, tracing: unbreak lttng

On 03/27/2018 02:07 AM, Steven Rostedt wrote: > On Mon, 26 Mar 2018 16:02:20 -0700 > Alexei Starovoitov wrote: > >> for_each_kernel_tracepoint() is used by out-of-tree lttng module >> and therefore cannot be changed. > > This is false and misleading. NACK. Steven, while I

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

On 03/27/2018 10:41 AM, Prashant Bhole wrote: > On 3/27/2018 12:15 PM, John Fastabend wrote: >> On 03/25/2018 11:54 PM, Prashant Bhole wrote: >>> When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, >>> when sg table is initialized using sg_init_table(). Magic is checked >>> while

Re: [PATCH net] vhost: correctly remove wait queue during poll failure

On 2018年03月27日 17:28, Darren Kenny wrote: Hi Jason, On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

On 26.03.2018 21:36, J. Bruce Fields wrote: > On Fri, Mar 23, 2018 at 02:53:34PM -0400, Anna Schumaker wrote: >> >> >> On 03/13/2018 06:49 AM, Kirill Tkhai wrote: >>> These pernet_operations initialize and destroy sunrpc_net_id refered >>> per-net items. Only used global list is cache_list, and

[PATCH] vhost-net: add time limitation for tx polling

handle_tx() will delay rx for a long time when busy tx polling udp packets with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account only sent-bytes but no time. It's not fair for handle_rx(), so needs to limit max time of tx polling. Signed-off-by: Haibin

[PATCH net] lan78xx: Crash in lan78xx_writ_reg (Workqueue: events lan78xx_deferred_multicast_write)

Description: Crash was reported with syzkaller pointing to lan78xx_write_reg routine. Root-cause: Proper cleanup of workqueues and init/setup routines was not happening in failure conditions. Fix: Handled the error conditions by cleaning up the queues and init/setup routines. Fixes:

Re: [RFC PATCH 00/24] Introducing AF_XDP support

On Mon, 26 Mar 2018 14:58:02 -0700 William Tu wrote: > > Again high count for NMI ?!? > > > > Maybe you just forgot to tell perf that you want it to decode the > > bpf_prog correctly? > > > >

[PATCH v3 0/2] of_net: Implement of_get_nvmem_mac_address helper

Posted this as a small set now, with an (optional) second patch that shows how the changes work and what I've used to test the code on a Topic Miami board. v3: Add patch that implements mac in nvmem for the Cadence MACB controller Remove the integrated of_get_mac_address call v2: Use

RE: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, March 27, 2018 1:25 AM > To: Vicenţiu Galanopulo > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > mark.rutl...@arm.com; da...@davemloft.net; mar...@holtmann.org;

[PATCH net 1/1] net/smc: use announced length in sock_recvmsg()

Not every CLC proposal message needs the maximum buffer length. Due to the MSG_WAITALL flag, it is important to use the peeked real length when receiving the message. Fixes: d63d271ce2b5ce ("smc: switch to sock_recvmsg()") Signed-off-by: Ursula Braun ---

Re: [PATCH net] vhost: correctly remove wait queue during poll failure

Hi Jason, On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. This text seems at odds with

Re: [2/4] wireless: Use octal not symbolic permissions

Joe Perches wrote: > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe Perches

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

On Tue, Mar 27, 2018 at 10:52:57AM +0200, Daniel Borkmann wrote: > On 03/27/2018 05:06 AM, Du, Changbin wrote: > > On Mon, Mar 26, 2018 at 08:02:30PM -0700, Alexei Starovoitov wrote: > >> On Tue, Mar 27, 2018 at 10:20:10AM +0800, Du, Changbin wrote: > >>> On Mon, Mar 26, 2018 at 07:55:13AM -0700,

[PATCH iproute2-next] tc: Fix compilation error with old iptables

The compat_rev field does not exists in old versions of iptables. e.g. iptables 1.4. Fixes: dd29621578d2 ("tc: add em_ipt ematch for calling xtables matches from tc matching context") Signed-off-by: Roi Dayan --- tc/em_ipt.c | 2 ++ 1 file changed, 2 insertions(+) diff

[bpf-next V6 PATCH 00/15] XDP redirect memory return API

This patchset works towards supporting different XDP RX-ring memory allocators. As this will be needed by the AF_XDP zero-copy mode. The patchset uses mlx5 as the sample driver, which gets implemented XDP_REDIRECT RX-mode, but not ndo_xdp_xmit (as this API is subject to change thought the

[bpf-next V6 PATCH 01/15] mlx5: basic XDP_REDIRECT forward support

This implements basic XDP redirect support in mlx5 driver. Notice that the ndo_xdp_xmit() is NOT implemented, because that API need some changes that this patchset is working towards. The main purpose of this patch is have different drivers doing XDP_REDIRECT to show how different memory models

[bpf-next V6 PATCH 02/15] xdp: introduce xdp_return_frame API and use in cpumap

Introduce an xdp_return_frame API, and convert over cpumap as the first user, given it have queued XDP frame structure to leverage. V3: Cleanup and remove C99 style comments, pointed out by Alex Duyck. V6: Remove comment that id will be added later (Req by Alex Duyck) Signed-off-by: Jesper

[bpf-next V6 PATCH 06/15] tun: convert to use generic xdp_frame and xdp_return_frame API

The tuntap driver invented it's own driver specific way of queuing XDP packets, by storing the xdp_buff information in the top of the XDP frame data. Convert it over to use the more generic xdp_frame structure. The main problem with the in-driver method is that the xdp_rxq_info pointer cannot be

[bpf-next V6 PATCH 05/15] xdp: introduce a new xdp_frame type

This is needed to convert drivers tuntap and virtio_net. This is a generalization of what is done inside cpumap, which will be converted later. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h | 40 1 file changed, 40

[bpf-next V6 PATCH 03/15] ixgbe: use xdp_return_frame API

Extend struct ixgbe_tx_buffer to store the xdp_mem_info. Notice that this could be optimized further by putting this into a union in the struct ixgbe_tx_buffer, but this patchset works towards removing this again. Thus, this is not done. Signed-off-by: Jesper Dangaard Brouer

[bpf-next V6 PATCH 04/15] xdp: move struct xdp_buff from filter.h to xdp.h

This is done to prepare for the next patch, and it is also nice to move this XDP related struct out of filter.h. Signed-off-by: Jesper Dangaard Brouer --- include/linux/filter.h | 24 +--- include/net/xdp.h | 22 ++ 2 files

Re: [PATCH] vhost-net: add time limitation for tx polling

On 2018年03月27日 17:12, haibinzhang(张海斌) wrote: handle_tx() will delay rx for a long time when busy tx polling udp packets with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account only sent-bytes but no time. Interesting. Looking at vhost_can_busy_poll()

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

On 03/27/2018 11:00 AM, Du, Changbin wrote: > On Tue, Mar 27, 2018 at 10:52:57AM +0200, Daniel Borkmann wrote: >> On 03/27/2018 05:06 AM, Du, Changbin wrote: >>> On Mon, Mar 26, 2018 at 08:02:30PM -0700, Alexei Starovoitov wrote: On Tue, Mar 27, 2018 at 10:20:10AM +0800, Du, Changbin wrote:

[PATCH v3 2/2] net: macb: Try to retrieve MAC addess from nvmem provider

Call of_get_nvmem_mac_address() to fetch the MAC address from an nvmem cell, if one is provided in the device tree. This allows the address to be stored in an I2C EEPROM device for example. Signed-off-by: Mike Looijmans --- drivers/net/ethernet/cadence/macb_main.c | 12

[PATCH v3 1/2] of_net: Implement of_get_nvmem_mac_address helper

It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to obtain the address from an nvmem cell provider. This is particulary useful on devices where

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 23:58 GMT+02:00 William Tu : > Hi Jesper, > > Thanks a lot for your prompt reply. > >>> Hi, >>> I also did an evaluation of AF_XDP, however the performance isn't as >>> good as above. >>> I'd like to share the result and see if there are some tuning suggestions. >>>

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-27 1:03 GMT+02:00 Alexander Duyck : > On Mon, Mar 26, 2018 at 3:54 PM, Tushar Dave wrote: [...] >> >> Whats the implication here. Should IOMMU be disabled? >> I'm asking because I do see a huge difference while running pktgen test for

[PATCH net 2/2] net/mlx4_core: Fix memory leak while delete slave's resources

From: Moshe Shemesh mlx4_delete_all_resources_for_slave in resource tracker should free all memory allocated for a slave. While releasing memory of fs_rule, it misses releasing memory of fs_rule->mirr_mbox. Fixes: 78efed275117 ('net/mlx4_core: Support mirroring VF DMFS rules

[PATCH net 0/2] mlx4 misc fixes for 4.16

Hi Dave, This patchset contains misc bug fixes from the team to the mlx4 Core and Eth drivers. Patch 1 by Eran fixes a control mix of PFC and Global pauses, please queue it to -stable for >= v4.8. Patch 2 by Moshe fixes a resource leak in slave's delete flow, please queue it to -stable for >=

Re: [PATCH v7 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs

Jeff, On 3/23/2018 10:34 PM, ok...@codeaurora.org wrote: > On 2018-03-23 19:58, Jeff Kirsher wrote: >> On Fri, 2018-03-23 at 14:53 -0700, Alexander Duyck wrote: >>> On Fri, Mar 23, 2018 at 11:52 AM, Sinan Kaya >>> wrote: >>> > Code includes wmb() followed by writel() in

[PATCH] net/9p: fix potential refcnt problem of trans module

When specifying trans_mod multiple times in a mount, it may cause inaccurate refcount of trans module. Also, in the error case of option parsing, we should put the trans module if we have already got. Signed-off-by: Chengguang Xu --- net/9p/client.c | 5 - 1 file changed, 4

Re: [PATCH net v2] udp6: set dst cache for a connected sk before udp_v6_send_skb

On 26.03.2018 20:02, Martin KaFai Lau wrote: > On Mon, Mar 26, 2018 at 05:48:47PM +0300, Alexey Kodanev wrote: >> After commit 33c162a980fe ("ipv6: datagram: Update dst cache of a >> connected datagram sk during pmtu update"), when the error occurs on >> sending datagram in udpv6_sendmsg() due to

Re: [PATCH net 1/1] net sched actions: fix dumping which requires several messages to user space

On 18-03-26 02:58 PM, Craig Dillabaugh wrote: Fixes a bug in the tcf_dump_walker function that can cause some actions to not be reported when dumping a large number of actions. This issue became more aggrevated when cookies feature was added. In particular this issue is

[PATCH net 1/2] net/mlx4_en: Fix mixed PFC and Global pause user control requests

From: Eran Ben Elisha Global pause and PFC configuration should be mutually exclusive (i.e. only one of them at most can be set). However, once PFC was turned off, driver automatically turned Global pause on. This is a bug. Fix the driver behaviour to turn off PFC/Global

Re: [PATCH v7 0/7] netdev: Eliminate duplicate barriers on weakly-ordered archs

Dave, On 3/26/2018 12:48 PM, David Miller wrote: > From: Sinan Kaya > Date: Sun, 25 Mar 2018 10:39:14 -0400 > >> Code includes wmb() followed by writel() in multiple places. writel() >> already has a barrier on some architectures like arm64. >> >> This ends up CPU

Re: [PATCH net-next] net: Export net->ipv6.sysctl.ip_nonlocal_bind to /proc

Please, ignore this. Thanks, Kirill On 27.03.2018 14:24, Kirill Tkhai wrote: > Currenly, this parameter can be configured via sysctl > only. But sysctl is considered as depricated interface > (man 2 sysctl), and it only can applied to current's net > namespace (this requires to do setns() to

possible deadlock in rtnl_lock (5)

Hello, syzbot hit the following crash on upstream commit 3eb2ce825ea1ad89d20f7a3b5780df850e4be274 (Sun Mar 25 22:44:30 2018 +) Linux 4.16-rc7 syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=a46d6abf9d56b1365a72 So far this crash happened 27 times on net-next, upstream. C

[PATCH net V2] vhost: correctly remove wait queue during poll failure

We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by switching to use vhost_poll_stop() which zeros poll->wqh after removing poll from waitqueue to make sure it won't be freed twice. Cc: Darren Kenny

Re: [PATCH net V2] vhost: correctly remove wait queue during poll failure

On Tue, Mar 27, 2018 at 08:50:52PM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by switching to use vhost_poll_stop() which zeros poll->wqh after removing poll from waitqueue

Re: [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral

Hello Andrew, On 03/26/2018 04:48 PM, Andrew Lunn wrote: > On Mon, Mar 26, 2018 at 04:15:09PM -0400, Murali Karicheri wrote: >> This patch provide APIs to allow client drivers to support >> probe deferral. On K2G SoC, devices can be probed only >> after the ti_sci_pm_domains driver is probed and

Re: possible deadlock in rtnl_lock (5)

syzbot wrote: [ cc Julian and trimming cc list ] > syzkaller688027/4497 is trying to acquire lock: > (rtnl_mutex){+.+.}, at: [] rtnl_lock+0x17/0x20 > net/core/rtnetlink.c:74 > but task is already holding lock: > IPVS:

Re: [PATCH] net: fec: set dma_coherent_mask

Hi Greg, On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: > As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no > coherent_dma_mask") the Freescale FEC driver is issuing the following > warning on driver initialization on ColdFire systems: > > WARNING: CPU: 0

Re: [PATCH net-next 1/4] qed: Populate nvm image attribute shadow.

On Mon, Mar 26, 2018 at 03:13:45AM -0700, Sudarsana Reddy Kalluru wrote: > This patch add support for populating the flash image attributes. s/add/adds/ [...] > -int qed_mcp_bist_nvm_test_get_image_att(struct qed_hwfn *p_hwfn, > - struct qed_ptt *p_ptt, > -

Re: [PATCH v3 iproute2-next 1/8] rdma: include rdma-core

On 3/26/18 11:46 PM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 01:57:32PM -0700, Steve Wise wrote: >> This avoids requiring rdma-core be installed on systems. >> >> Signed-off-by: Steve Wise >> --- >> rdma/include/rdma/rdma_cma.h | 728 >>

[PATCH v2 net 1/1] qede: Fix barrier usage after tx doorbell write.

Since commit c5ad119fb6c09b0297446be05bd66602fa564758 ("net: sched: pfifo_fast use skb_array") driver is exposed to an issue where it is hitting NULL skbs while handling TX completions. Driver uses mmiowb() to flush the writes to the doorbell bar which is a write-combined bar, however on x86

Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote: > Previous implementation overwrites PCP value, assuming the default value is > 0, instead of 7. > > Avoid this by modifying helper function ethsw_port_set_tci() to > ethsw_port_set_pvid() and make it update only the vlan_id of

Re: [Patch net] llc: properly handle dev_queue_xmit() return value

Hi, I am not sure what is the next step from this? Does it mean that a patch is out in the kernel's GIT/Beta version? Or is this just a proposal? On Tue, Mar 27, 2018 at 1:08 AM, Cong Wang wrote: > llc_conn_send_pdu() pushes the skb into write queue and > calls

Re: [net-next PATCH 3/5] net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC

On 03/26/2018 04:28 PM, Andrew Lunn wrote: > On Mon, Mar 26, 2018 at 04:15:10PM -0400, Murali Karicheri wrote: >> K2G SoC uses 2u cpsw h/w. It uses RGMII instead of SGMII to interface with >> Phy. This patch enhances the driver to check RGMII status instead of SGMII >> status for link state

Re: [PATCH 4/4] selftests/bpf: fix compiling errors

On Tue, Mar 27, 2018 at 11:52:27AM +0200, Daniel Borkmann wrote: > On 03/27/2018 11:00 AM, Du, Changbin wrote: > > On Tue, Mar 27, 2018 at 10:52:57AM +0200, Daniel Borkmann wrote: > >> On 03/27/2018 05:06 AM, Du, Changbin wrote: > >>> On Mon, Mar 26, 2018 at 08:02:30PM -0700, Alexei Starovoitov

[PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

Previous implementation overwrites PCP value, assuming the default value is 0, instead of 7. Avoid this by modifying helper function ethsw_port_set_tci() to ethsw_port_set_pvid() and make it update only the vlan_id of the tci_cfg struct. Signed-off-by: Razvan Stefanescu

Re: [PATCH net-next 3/4] qed: Adapter flash update support.

On Mon, Mar 26, 2018 at 03:13:47AM -0700, Sudarsana Reddy Kalluru wrote: > This patch adds the required driver support for updating the flash or > non volatile memory of the adapter. At highlevel, flash upgrade comprises > of reading the flash images from the input file, validating the images and

Re: [PATCH 1/6] rhashtable: improve documentation for rhashtable_walk_peek()

Hello! On 3/27/2018 2:33 AM, NeilBrown wrote: The documentation for rhashtable_walk_peek() wrong. It claims to return the *next* entry, whereas it in fact returns the *previous* entry. However if no entries have yet been returned - or if the iterator was reset due to a resize event, then

[PATCH net-next] net: Export net->ipv6.sysctl.ip_nonlocal_bind to /proc

Currenly, this parameter can be configured via sysctl only. But sysctl is considered as depricated interface (man 2 sysctl), and it only can applied to current's net namespace (this requires to do setns() to change it in not current's net ns). So, let's export the parameter to /proc in standard

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

Rahul Lakkireddy writes: > On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman wrote: >> >> Rahul Lakkireddy writes: >> >> > On production servers running variety of workloads over time, kernel >> > panic can

Re: [PATCH] net: fec: set dma_coherent_mask

Hi, > > + dma_set_coherent_mask(>pdev->dev, DMA_BIT_MASK(32)); > + > for (i = 0; i < fep->num_tx_queues; i++) { > txq = kzalloc(sizeof(*txq), GFP_KERNEL); > if (!txq) { dma_set_coherent_mask() can fail, so the return value should be checked and a failure

Re: [PATCH 1/6] rhashtable: improve documentation for rhashtable_walk_peek()

Neil, 2018-03-27 1:33 GMT+02:00 NeilBrown : > The documentation for rhashtable_walk_peek() wrong. It claims to > return the *next* entry, whereas it in fact returns the *previous* > entry. > However if no entries have yet been returned - or if the iterator > was reset due to a

Re: [PATCH net-next 0/6] rxrpc: Fixes

Sorry, that should be net, not net-next, in the subject line. David

Re: [PATCH v6 bpf-next 08/11] bpf: introduce BPF_RAW_TRACEPOINT

- On Mar 27, 2018, at 6:48 PM, Alexei Starovoitov a...@fb.com wrote: > On 3/27/18 2:04 PM, Steven Rostedt wrote: >> >> +#ifdef CONFIG_BPF_EVENTS >> +#define BPF_RAW_TP() . = ALIGN(8); \ Given that the section consists of a 16-bytes structure elements on architectures with 8 bytes

Re: [iproute PATCH 2/3] ss: Put filter DB parsing into a separate function

On Tue, Mar 27, 2018 at 11:46:01AM -0700, Stephen Hemminger wrote: > On Sat, 24 Mar 2018 19:18:10 +0100 > Phil Sutter wrote: > > > +#define ENTRY(name, ...) { #name, { __VA_ARGS__, MAX_DB }} > > > + ENTRY(all, UDP_DB, DCCP_DB, TCP_DB, RAW_DB, \ > > +

[PATCH V5 net-next 01/14] tcp: Add clean acked data hook

From: Ilya Lesokhin Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data. This is required by TLS device offload to release metadata associated with acknowledged TLS records.

Re: [PATCH v6 bpf-next 08/11] bpf: introduce BPF_RAW_TRACEPOINT

On 3/27/18 4:13 PM, Mathieu Desnoyers wrote: - On Mar 27, 2018, at 6:48 PM, Alexei Starovoitov a...@fb.com wrote: On 3/27/18 2:04 PM, Steven Rostedt wrote: +#ifdef CONFIG_BPF_EVENTS +#define BPF_RAW_TP() . = ALIGN(8); \ Given that the section consists of a 16-bytes

RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters

Hi Aaron, "Brown, Aaron F" writes: [...] > And watching the rx_queue counters continues to be spread across the > different queues. This is with Jeff Kirsher's next queue, kernel > 4.16.0-rc4_next-queue_dev-queue_e31d20a, which has the series of 8 igb > patches

[pull request][net-next 00/15] Mellanox, mlx5 mlx5-updates-2018-03-27

Hi Dave, This series contains Misc updates and cleanups for mlx5e rx path and SQ recovery feature for tx path. For more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit

[PATCH iproute2-next 1/2] ip/ila: support json and color

From: Stephen Hemminger Use json print to enhance ila output. Signed-off-by: Stephen Hemminger --- ip/ipila.c | 76 ++ 1 file changed, 37 insertions(+), 39 deletions(-) diff --git

Re: RFC on writel and writel_relaxed

On Tue, Mar 27, 2018 at 3:03 PM, Benjamin Herrenschmidt wrote: > > The discussion at hand is about > > dma_buffer->foo = 1;/* WB */ > writel(KICK, DMA_KICK_REGISTER);/* UC */ Yes. That certainly is ordered on x86. In fact,

Re: [V9fs-developer] [PATCH] net/9p: fix potential refcnt problem of trans module

On 2018/3/28 10:52, cgxu...@gmx.com wrote: > 在 2018年3月28日，上午10:10，jiangyiwen 写道： >> >> On 2018/3/27 20:49, Chengguang Xu wrote: >>> When specifying trans_mod multiple times in a mount, >>> it may cause inaccurate refcount of trans module. Also, >>> in the error case of

[PATCH v2 bpf-next 6/9] bpf: Hooks for sys_connect

From: Andrey Ignatov == The problem == See description of the problem in the initial patch of this patch set. == The solution == The patch provides much more reliable in-kernel solution for the 2nd part of the problem: making outgoing connecttion from desired IP. It adds new

[PATCH v2 bpf-next 1/9] bpf: Check attach type at prog load time

From: Andrey Ignatov == The problem == There are use-cases when a program of some type can be attached to multiple attach points and those attach points must have different permissions to access context or to call helpers. E.g. context structure may have fields for both IPv4 and

[PATCH v2 bpf-next 0/9] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

v1->v2: - support expected_attach_type at prog load time so that prog (incl. context accesses and calls to helpers) can be validated with regard to specific attach point it is supposed to be attached to. Later, at attach time, attach type is checked so that it must be same as at load time

Re: [PATCH V5 net-next 06/14] net/tls: Add generic NIC offload infrastructure

On 3/27/2018 4:56 PM, Saeed Mahameed wrote: From: Ilya Lesokhin This patch adds a generic infrastructure to offload TLS crypto to a network device. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path.

Re: RFC on writel and writel_relaxed

On Tue, 2018-03-27 at 23:24 -0400, Sinan Kaya wrote: > On 3/27/2018 10:51 PM, Linus Torvalds wrote: > > > The discussion at hand is about > > > > > > dma_buffer->foo = 1;/* WB */ > > > writel(KICK, DMA_KICK_REGISTER);/* UC */ > > > > Yes. That

[PATCH v2 bpf-next 2/9] libbpf: Support expected_attach_type at prog load

From: Andrey Ignatov Support setting `expected_attach_type` at prog load time in both `bpf/bpf.h` and `bpf/libbpf.h`. Since both headers already have API to load programs, new functions are added not to break backward compatibility for existing ones: * `bpf_load_program_xattr()` is

[PATCH v2 bpf-next 9/9] selftests/bpf: Selftest for sys_bind post-hooks.

From: Andrey Ignatov Add selftest for attach types `BPF_CGROUP_INET4_POST_BIND` and `BPF_CGROUP_INET6_POST_BIND`. The main things tested are: * prog load behaves as expected (valid/invalid accesses in prog); * prog attach behaves as expected (load- vs attach-time attach types); *

[PATCH v2 bpf-next 3/9] bpf: Hooks for sys_bind

From: Andrey Ignatov == The problem == There is a use-case when all processes inside a cgroup should use one single IP address on a host that has multiple IP configured. Those processes should use the IP for both ingress and egress, for TCP and UDP traffic. So TCP/UDP servers

Re: [PATCH v13 net-next 08/12] crypto : chtls - CPL handler definition

On 3/27/2018 11:12 PM, Stefano Brivio wrote: > On Tue, 27 Mar 2018 23:06:37 +0530 > Atul Gupta wrote: > >> Exchange messages with hardware to program the TLS session >> CPL handlers for messages received from chip. >> >> Signed-off-by: Atul Gupta

Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

On 2018年03月27日 19:26, Jason wrote On 2018年03月27日 17:12, haibinzhang wrote: >> handle_tx() will delay rx for a long time when busy tx polling udp packets >> with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT >> takes into account only sent-bytes but no time. > >Interesting.

Re: [PATCH v13 net-next 01/12] tls: support for Inline tls record

On 3/27/2018 11:53 PM, Stefano Brivio wrote: > On Tue, 27 Mar 2018 23:06:30 +0530 > Atul Gupta wrote: > >> +static struct tls_context *create_ctx(struct sock *sk) >> +{ >> +struct inet_connection_sock *icsk = inet_csk(sk); >> +struct tls_context *ctx; >> + >> +

[PATCH v2 bpf-next 4/9] selftests/bpf: Selftest for sys_bind hooks

From: Andrey Ignatov Add selftest to work with bpf_sock_addr context from `BPF_PROG_TYPE_CGROUP_SOCK_ADDR` programs. Try to bind(2) on IP:port and apply: * loads to make sure context can be read correctly, including narrow loads (byte, half) for IP and full-size loads (word) for

[PATCH v2 bpf-next 5/9] net: Introduce __inet_bind() and __inet6_bind

From: Andrey Ignatov Refactor `bind()` code to make it ready to be called from BPF helper function `bpf_bind()` (will be added soon). Implementation of `inet_bind()` and `inet6_bind()` is separated into `__inet_bind()` and `__inet6_bind()` correspondingly. These function can be used

[PATCH v2 bpf-next 8/9] bpf: Post-hooks for sys_bind

From: Andrey Ignatov "Post-hooks" are hooks that are called right before returning from sys_bind. At this time IP and port are already allocated and no further changes to `struct sock` can happen before returning from sys_bind but BPF program has a chance to inspect the socket and

[PATCH v2 bpf-next 7/9] selftests/bpf: Selftest for sys_connect hooks

From: Andrey Ignatov Add selftest for BPF_CGROUP_INET4_CONNECT and BPF_CGROUP_INET6_CONNECT attach types. Try to connect(2) to specified IP:port and test that: * remote IP:port pair is overridden; * local end of connection is bound to specified IP. All combinations of IPv4/IPv6

Re: RFC on writel and writel_relaxed

On Tue, 2018-03-27 at 16:51 -1000, Linus Torvalds wrote: > On Tue, Mar 27, 2018 at 3:03 PM, Benjamin Herrenschmidt > wrote: > > > > The discussion at hand is about > > > > dma_buffer->foo = 1;/* WB */ > > writel(KICK,

  1   2   3   4   5   >