Re: RFC on writel and writel_relaxed

2018-03-28 Thread Benjamin Herrenschmidt
On Tue, 2018-03-27 at 20:26 -1000, Linus Torvalds wrote: > On Tue, Mar 27, 2018 at 6:33 PM, Benjamin Herrenschmidt > wrote: > > > > This is why, I want (with your agreement) to define clearly and once > > and for all, that the Linux semantics of writel are that it is

[PATCH v2] staging: fsl-dpaa2/ethsw: Fix tag control information value overwrite

2018-03-28 Thread Razvan Stefanescu
The tag control information (TCI) part of the VLAN header contains several fields, including PCP (priority code point) and PVID (port VLAN id). Current implementation uses function ethsw_port_set_tci() to set the PVID value and mistakenly overwrites the rest of the TCI fields with 0, including

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Arnd Bergmann
On Wed, Mar 28, 2018 at 8:56 AM, Benjamin Herrenschmidt wrote: > On Wed, 2018-03-28 at 06:53 +, Linus Torvalds wrote: >> On Tue, Mar 27, 2018, 20:43 Benjamin Herrenschmidt >> wrote: >> That's why in/out were *so* slow, and why nobody uses

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Greg Ungerer
Hi Geert, On 27/03/18 22:59, Geert Uytterhoeven wrote: > On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: >> As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no >> coherent_dma_mask") the Freescale FEC driver is issuing the following >> warning on driver

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

2018-03-28 Thread Herbert Xu
On Wed, Mar 28, 2018 at 06:04:40PM +1100, NeilBrown wrote: > > I disagree. My patch 6 only makes it common instead of exceedingly > rare. If any table in the list other than the first has a chain with 16 > elements, then trying to insert an element with a hash which matches > that chain will

Re: [RFC v3 net-next 13/18] net/sched: Introduce the TBS Qdisc

2018-03-28 Thread Thomas Gleixner
Jesus, On Tue, 27 Mar 2018, Jesus Sanchez-Palencia wrote: > On 03/25/2018 04:46 AM, Thomas Gleixner wrote: > > This is missing right now and you want to get that right from the very > > beginning. Duct taping it on the interface later on is a bad idea. > > Agreed that this is needed. On the

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

2018-03-28 Thread Herbert Xu
On Wed, Mar 28, 2018 at 08:34:19AM +1100, NeilBrown wrote: > > It is easy to get an -EBUSY insertion failure when .disable_count is > enabled, and I did get that. Blindly propagating that up caused lustre > to get terribly confused - not too surprising really. Right, so this failure mode is

Re: [PATCH net 0/2] Fix vlan untag and insertion for bridge and vlan with reorder_hdr off

2018-03-28 Thread Eric Dumazet
On 03/16/2018 07:05 AM, David Miller wrote: > From: Toshiaki Makita > Date: Tue, 13 Mar 2018 14:51:26 +0900 > >> As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from >> bridge devices ends up with corrupted packets. He narrowed down this

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Linus Torvalds
On Tue, Mar 27, 2018 at 5:24 PM, Sinan Kaya wrote: > > Basically changing it to > > dma_buffer->foo = 1;/* WB */ > wmb() > writel_relaxed(KICK, DMA_KICK_REGISTER);/* UC */ > mmiowb() Why? Why not just remove the wmb(), and keep the barrier in

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-28 Thread Prashant Bhole
On 3/27/2018 6:05 PM, Daniel Borkmann wrote: On 03/27/2018 10:41 AM, Prashant Bhole wrote: On 3/27/2018 12:15 PM, John Fastabend wrote: On 03/25/2018 11:54 PM, Prashant Bhole wrote: When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, when sg table is initialized using

[PATCH 25/30] net/rxrpc: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/rxrpc/af_rxrpc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c index 0c9c18aa7c77..d2440d5c3ce8 100644 --- a/net/rxrpc/af_rxrpc.c +++ b/net/rxrpc/af_rxrpc.c @@

[PATCH 26/30] crypto: af_alg: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 13 +++-- crypto/algif_aead.c | 4 ++-- crypto/algif_skcipher.c | 4 ++-- include/crypto/if_alg.h | 3 +-- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/crypto/af_alg.c b/crypto/af_alg.c

[PATCH 28/30] eventfd: switch to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/eventfd.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/eventfd.c b/fs/eventfd.c index 012f5bd46dfa..d70b4907f978 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -101,14 +101,20 @@ static int

[PATCH 27/30] pipe: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/pipe.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 7b1954caf388..81937590ea0a 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -509,19 +509,22 @@ static long

[PATCH 12/30] net/tcp: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/tcp.h | 4 ++-- net/ipv4/af_inet.c | 3 ++- net/ipv4/tcp.c | 31 ++- net/ipv6/af_inet6.c | 3 ++- 4 files changed, 20 insertions(+), 21 deletions(-) diff --git a/include/net/tcp.h

[PATCH 10/30] net: add support for ->poll_mask in proto_ops

2018-03-28 Thread Christoph Hellwig
The socket file operations still implement ->poll until all protocols are switched over. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 3 +++ net/socket.c| 51 ++- 2 files changed, 49 insertions(+), 5

[PATCH 14/30] net: convert datagram_poll users tp ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman --- drivers/isdn/mISDN/socket.c| 2 +- drivers/net/ppp/pppoe.c| 2 +- drivers/staging/ipx/af_ipx.c | 2 +- drivers/staging/irda/net/af_irda.c | 6 +++---

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Linus Torvalds
On Tue, Mar 27, 2018 at 6:33 PM, Benjamin Herrenschmidt wrote: > > This is why, I want (with your agreement) to define clearly and once > and for all, that the Linux semantics of writel are that it is ordered > with previous writes to coherent memory (*) Honestly, I

RE: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Andy Duan
From: Geert Uytterhoeven Sent: 2018年3月28日 15:07 > Hi Andy, > > On Wed, Mar 28, 2018 at 5:04 AM, Andy Duan wrote: > > From: Geert Uytterhoeven Sent: 2018年3月27日 > 20:59 > >> On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer

[PATCH 30/30] random: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
The big change is that random_read_wait and random_write_wait are merged into a single waitqueue that uses keyed wakeups. Because wait_event_* doesn't know about that this will lead to occassional spurious wakeups in _random_read and add_hwgenerator_randomness, but wait_event_* is designed to

[PATCH 29/30] timerfd: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/timerfd.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fs/timerfd.c b/fs/timerfd.c index cdad49da3ff7..d84a2bee4f82 100644 --- a/fs/timerfd.c +++ b/fs/timerfd.c @@ -226,21 +226,20 @@ static int

Re: [PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects.

2018-03-28 Thread Herbert Xu
On Wed, Mar 28, 2018 at 06:17:57PM +1100, NeilBrown wrote: > > Sounds like over-kill to me. > It might be reasonable to have a CONFIG_DEBUG_RHASHTABLE which enables > extra to code to catch misuse, but I don't see the justification for > always performing these checks. > The DEBUG code could just

[PATCH 16/30] net/atm: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/atm/common.c | 11 +++ net/atm/common.h | 2 +- net/atm/pvc.c| 2 +- net/atm/svc.c| 2 +- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/net/atm/common.c b/net/atm/common.c index fc78a0508ae1..1f2af59935db

[PATCH 13/30] net/unix: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/unix/af_unix.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 2d465bdeccbc..619c6921dd46 100644 --- a/net/unix/af_unix.c +++

[PATCH 01/30] fs: unexport poll_schedule_timeout

2018-03-28 Thread Christoph Hellwig
No users outside of select.c. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Darrick J. Wong --- fs/select.c | 3 +-- include/linux/poll.h | 2 -- 2 files changed, 1 insertion(+), 4

Re: [PATCH 1/2] af_key: Use DIV_ROUND_UP() instead of open-coded equivalent

2018-03-28 Thread Steffen Klassert
On Mon, Mar 26, 2018 at 07:39:16AM -0400, Kevin Easton wrote: > Several places use (x + 7) / 8 to convert from a number of bits to a number > of bytes. Replace those with DIV_ROUND_UP(x, 8) instead, for consistency > with other parts of the same file. > > Signed-off-by: Kevin Easton

Re: [PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects.

2018-03-28 Thread Herbert Xu
On Wed, Mar 28, 2018 at 08:54:41AM +1100, NeilBrown wrote: > > Possibly. > I particularly want the interface to require that you pass the > previously returned object to _continue. That makes it easy to see that > the object is still being used. If someone changes to code to delete > the object

RE: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-28 Thread Razvan Stefanescu
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Andrew Lunn > Sent: Tuesday, March 27, 2018 4:38 PM > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org;

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

2018-03-28 Thread NeilBrown
On Wed, Mar 28 2018, Herbert Xu wrote: > On Wed, Mar 28, 2018 at 08:34:19AM +1100, NeilBrown wrote: >> >> It is easy to get an -EBUSY insertion failure when .disable_count is >> enabled, and I did get that. Blindly propagating that up caused lustre >> to get terribly confused - not too

[PATCH 20/30] net/bluetooth: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/bluetooth/bluetooth.h | 2 +- net/bluetooth/af_bluetooth.c | 7 ++- net/bluetooth/l2cap_sock.c| 2 +- net/bluetooth/rfcomm/sock.c | 2 +- net/bluetooth/sco.c | 2 +- 5 files changed, 6

[PATCH 19/30] net/sctp: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/sctp/sctp.h | 3 +-- net/sctp/ipv6.c | 2 +- net/sctp/protocol.c | 2 +- net/sctp/socket.c | 4 +--- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h

[PATCH 21/30] net/caif: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/caif/caif_socket.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index a6fb1b3bcad9..c7991867d622 100644 --- a/net/caif/caif_socket.c +++

[PATCH 04/30] fs: add new vfs_poll and file_can_poll helpers

2018-03-28 Thread Christoph Hellwig
These abstract out calls to the poll method in preparation for changes in how we poll. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Darrick J. Wong ---

[PATCH 07/30] aio: add delayed cancel support

2018-03-28 Thread Christoph Hellwig
The upcoming aio poll support would like to be able to complete the iocb inline from the cancellation context, but that would cause a lock order reversal. Add support for optionally moving the cancelation outside the context lock to avoid this reversal. To make this safe aio_complete needs to

[PATCH 05/30] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-03-28 Thread Christoph Hellwig
->get_poll_head returns the waitqueue that the poll operation is going to sleep on. Note that this means we can only use a single waitqueue for the poll, unlike some current drivers that use two waitqueues for different events. But now that we have keyed wakeups and heavily use those for poll

Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

2018-03-28 Thread Jason Wang
On 2018年03月28日 12:01, haibinzhang(张海斌) wrote: On 2018年03月27日 19:26, Jason wrote On 2018年03月27日 17:12, haibinzhang wrote: handle_tx() will delay rx for a long time when busy tx polling udp packets with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account

[PATCH 06/30] aio: simplify cancellation

2018-03-28 Thread Christoph Hellwig
With the current aio code there is no need for the magic KIOCB_CANCELLED value, as a cancelation just kicks the driver to queue the completion ASAP, with all actual completion handling done in another thread. Given that both the completion path and cancelation take the context lock there is no

[PATCH 15/30] net/dccp: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/dccp/dccp.h | 3 +-- net/dccp/ipv4.c | 2 +- net/dccp/ipv6.c | 2 +- net/dccp/proto.c | 13 ++--- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index f91e3816806b..0ea2ee56ac1b

[PATCH 17/30] net/vmw_vsock: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/vmw_vsock/af_vsock.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index e0fc84daed94..b9210329bda8 100644 --- a/net/vmw_vsock/af_vsock.c +++

[PATCH 18/30] net/tipc: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/tipc/socket.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 7dfa9fc99ec3..e9c6f185db74 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -695,10 +695,9

[PATCH 03/30] fs: update documentation to mention __poll_t and match the code

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Reviewed-by: Greg Kroah-Hartman --- Documentation/filesystems/Locking | 2 +- Documentation/filesystems/vfs.txt | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 02/30] fs: cleanup do_pollfd

2018-03-28 Thread Christoph Hellwig
Use straightline code with failure handling gotos instead of a lot of nested conditionals. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Darrick J. Wong --- fs/select.c | 48

aio poll and a new in-kernel poll API V7

2018-03-28 Thread Christoph Hellwig
Hi all, this series adds support for the IOCB_CMD_POLL operation to poll for the readyness of file descriptors using the aio subsystem. The API is based on patches that existed in RHAS2.1 and RHEL3, which means it already is supported by libaio. To implement the poll support efficiently new

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-03-28 Thread Jiri Pirko
Wed, Mar 28, 2018 at 07:02:34AM CEST, step...@networkplumber.org wrote: >On Thu, 22 Mar 2018 11:55:10 +0100 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> This patchset resolves 2 issues we have right now: >> 1) There are many netdevices / ports in the

RE: [PATCH net-next 3/4] qed: Adapter flash update support.

2018-03-28 Thread Kalluru, Sudarsana
-Original Message- From: Yuval Mintz [mailto:yuv...@mellanox.com] Sent: 27 March 2018 19:07 To: Kalluru, Sudarsana Cc: da...@davemloft.net; netdev@vger.kernel.org; Elior, Ariel Subject: Re: [PATCH net-next 3/4] qed: Adapter flash

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Benjamin Herrenschmidt
On Wed, 2018-03-28 at 06:53 +, Linus Torvalds wrote: > > > On Tue, Mar 27, 2018, 20:43 Benjamin Herrenschmidt ing.org> wrote: > > > > > > Of course, you'd have to be pretty odd to want to start a DMA > > with a > > > read anyway - partly exactly because it's bad for

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Geert Uytterhoeven
Hi Andy, On Wed, Mar 28, 2018 at 5:04 AM, Andy Duan wrote: > From: Geert Uytterhoeven Sent: 2018年3月27日 20:59 >> On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: >> > As of commit 205e1b7f51e4 ("dma-mapping: warn when there is

Re: [PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects.

2018-03-28 Thread NeilBrown
On Wed, Mar 28 2018, Herbert Xu wrote: > On Wed, Mar 28, 2018 at 08:54:41AM +1100, NeilBrown wrote: >> >> Possibly. >> I particularly want the interface to require that you pass the >> previously returned object to _continue. That makes it easy to see that >> the object is still being used. If

[PATCH 24/30] net/iucv: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/iucv/af_iucv.h | 2 -- net/iucv/af_iucv.c | 7 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/net/iucv/af_iucv.h b/include/net/iucv/af_iucv.h index f4c21b5a1242..b0eaeb02d46d 100644 ---

[PATCH 23/30] net/phonet: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/phonet/socket.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/phonet/socket.c b/net/phonet/socket.c index 28d981512f5f..70ac4539d5b7 100644 --- a/net/phonet/socket.c +++ b/net/phonet/socket.c @@ -341,15

[PATCH 22/30] net/nfc: convert to ->poll_mask

2018-03-28 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/nfc/llcp_sock.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index 376040092142..b6010750e634 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -549,16

[PATCH 08/30] aio: implement IOCB_CMD_POLL

2018-03-28 Thread Christoph Hellwig
Simple one-shot poll through the io_submit() interface. To poll for a file descriptor the application should submit an iocb of type IOCB_CMD_POLL. It will poll the fd for the events specified in the the first 32 bits of the aio_buf field of the iocb. Unlike poll or epoll without EPOLLONESHOT

[PATCH 11/30] net: remove sock_no_poll

2018-03-28 Thread Christoph Hellwig
Now that sock_poll handles a NULL ->poll or ->poll_mask there is no need for a stub. Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 1 - crypto/algif_hash.c | 2 -- crypto/algif_rng.c | 1 - drivers/isdn/mISDN/socket.c | 1 -

[PATCH 09/30] net: refactor socket_poll

2018-03-28 Thread Christoph Hellwig
Factor out two busy poll related helpers for late reuse, and remove a command that isn't very helpful, especially with the __poll_t annotations in place. Signed-off-by: Christoph Hellwig --- include/net/busy_poll.h | 15 +++ net/socket.c| 21

Re: NFS mounts failing when keytab present on client

2018-03-28 Thread M A Young
On Tue, 27 Mar 2018, Eric Biggers wrote: > Hi Michael, > > On Tue, Mar 27, 2018 at 11:06:14PM +0100, Michael Young wrote: > > NFS mounts stopped working on one of my computers after a kernel update from > > 4.15.3 to 4.15.4. I traced the problem to the commit > >

Re: [PATCH 0/7] net: thunderx: implement DMAC filtering support

2018-03-28 Thread Vadim Lomovtsev
Hi David, Thanks for feedback. On Tue, Mar 27, 2018 at 01:28:22PM -0400, David Miller wrote: > From: Vadim Lomovtsev > Date: Tue, 27 Mar 2018 08:07:29 -0700 > > > From: Vadim Lomovtsev > > > > By default CN88XX BGX accepts all

Problems: network rx out-of-order issue

2018-03-28 Thread Anny Hu
Dears, Recently, we find the following patch will impact multi-core network throughput performance on kernel-4.9, for it will cause rx packet out-of-order. commit id: 4cd13c21b207e80ddb1144c576500098f2d5f882 [kernel version]: kernel-4.9 [repeat steps] 1. two our phones with load based on

Problems: network rx out-of-order issue

2018-03-28 Thread Anny Hu
Dears, Recently, we find the following patch will impact multi-core network throughput performance on kernel-4.9, for it will cause rx packet out-of-order. commit id: 4cd13c21b207e80ddb1144c576500098f2d5f882 [kernel version]: kernel-4.9 [repeat steps] 1. two our phones with load based on

Re: [PATCH net-next 2/4] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

2018-03-28 Thread Russell King - ARM Linux
On Sun, Mar 18, 2018 at 11:52:44AM -0700, Florian Fainelli wrote: > In preparation for having DSA transition entirely to PHYLINK, we need to pass > a > PHY interface type to the mac_link_{up,down} callbacks because we may have to > make decisions on that (e.g: turn on/off RGMII interfaces etc.).

Re: Aw: Re: RFC on writel and writel_relaxed

2018-03-28 Thread Benjamin Herrenschmidt
On Wed, 2018-03-28 at 12:13 +0200, Lino Sanfilippo wrote: > Hi, > > > > > > Yeah so that other trick I'm talking about is also used for timing > > accuracy. > > > > For example, let's say I have a device with a reset bit and the spec > > says the reset bit needs to be set for at least 10us. >

[PATCH v3] staging: fsl-dpaa2/ethsw: Fix tag control information value overwrite

2018-03-28 Thread Razvan Stefanescu
The tag control information (TCI) part of the VLAN header contains several fields, including PCP (priority code point) and PVID (port VLAN id). Current implementation uses function ethsw_port_set_tci() to set the PVID value and mistakenly overwrites the rest of the TCI fields with 0, including

RE: RFC on writel and writel_relaxed

2018-03-28 Thread David Laight
From: Benjamin Herrenschmidt > Sent: 28 March 2018 10:56 ... > For example, let's say I have a device with a reset bit and the spec > says the reset bit needs to be set for at least 10us. > > This is wrong: > > writel(1, RESET_REG); > usleep(10); > writel(0, RESET_REG); > >

RE: [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

2018-03-28 Thread Paul Durrant
> -Original Message- > From: Dongli Zhang [mailto:dongli.zh...@oracle.com] > Sent: 28 March 2018 00:42 > To: xen-de...@lists.xenproject.org; linux-ker...@vger.kernel.org > Cc: netdev@vger.kernel.org; Wei Liu ; Paul Durrant > > Subject: [PATCH

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Benjamin Herrenschmidt
On Wed, 2018-03-28 at 10:07 +0100, Will Deacon wrote: > > For arm/arm64 we guarantee ordering for (1) but not for (2) -- you'd need to > add an mb() to make it work. > > Do both of these work on power? Yes. There's even another quirk, see further down ;-) > If so, I guess I can make readl

[PATCH net 1/1] qede: Do not drop rx-checksum invalidated packets.

2018-03-28 Thread Manish Chopra
Today, driver drops received packets which are indicated as invalid checksum by the device. Instead of dropping such packets, pass them to the stack with CHECKSUM_NONE indication in skb. Signed-off-by: Ariel Elior Signed-off-by: Manish Chopra

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-28 Thread Jesper Dangaard Brouer
On Tue, 27 Mar 2018 17:06:50 -0700 William Tu wrote: > On Tue, Mar 27, 2018 at 2:37 AM, Jesper Dangaard Brouer > wrote: > > On Mon, 26 Mar 2018 14:58:02 -0700 > > William Tu wrote: > > > >> > Again high count for NMI ?!? > >> > > >>

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Benjamin Herrenschmidt
On Wed, 2018-03-28 at 09:11 +0200, Arnd Bergmann wrote: > On Wed, Mar 28, 2018 at 8:56 AM, Benjamin Herrenschmidt > wrote: > > On Wed, 2018-03-28 at 06:53 +, Linus Torvalds wrote: > > > On Tue, Mar 27, 2018, 20:43 Benjamin Herrenschmidt > > >

Re: RFC on writel and writel_relaxed

2018-03-28 Thread Will Deacon
On Wed, Mar 28, 2018 at 05:42:56PM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2018-03-27 at 20:26 -1000, Linus Torvalds wrote: > > On Tue, Mar 27, 2018 at 6:33 PM, Benjamin Herrenschmidt > > wrote: > > > > > > This is why, I want (with your agreement) to define

[PATCH] net: phy: marvell10g: add thermal hwmon device

2018-03-28 Thread Russell King
Add a thermal monitoring device for the Marvell 88x3310, which updates once a second. We also need to hook into the suspend/resume mechanism to ensure that the thermal monitoring is reconfigured when we resume. Suggested-by: Andrew Lunn Signed-off-by: Russell King

Re: [PATCH net 0/2] Fix vlan untag and insertion for bridge and vlan with reorder_hdr off

2018-03-28 Thread Toshiaki Makita
On 2018/03/28 15:11, Eric Dumazet wrote: > On 03/16/2018 07:05 AM, David Miller wrote: >> From: Toshiaki Makita >> Date: Tue, 13 Mar 2018 14:51:26 +0900 >> >>> As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from >>> bridge devices ends up with

RE: [PATCH net-next] qed*: Utilize FW 8.33.11.0

2018-03-28 Thread Kalderon, Michal
> From: Jason Gunthorpe [mailto:j...@ziepe.ca] > Sent: Wednesday, March 28, 2018 1:27 AM > > On Tue, Mar 27, 2018 at 08:50:24PM +0300, Leon Romanovsky wrote: > > On Tue, Mar 27, 2018 at 05:41:51PM +, Kalderon, Michal wrote: > > > > From: Jason Gunthorpe [mailto:j...@ziepe.ca] > > > > Sent:

Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-28 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Razvan-Stefanescu/staging-fsl-dpaa2-ethsw-Fix-TCI-values-overwrite/20180328-154703 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

Passing uninitialised local variable

2018-03-28 Thread Himanshu Jha
Hello everyone, I recently found that a local variable in passed uninitialised to the function at drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:2950 u32 var; err = brcmf_fil_iovar_int_get(ifp, "dtim_assoc", ); if (err) {

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Geert Uytterhoeven
Hi Greg, On Wed, Mar 28, 2018 at 9:27 AM, Greg Ungerer wrote: > On 27/03/18 22:59, Geert Uytterhoeven wrote: >> On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: >>> As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no >>>

[PATCH net-next v2 3/5] qed: Add APIs for flash access.

2018-03-28 Thread Sudarsana Reddy Kalluru
This patch adds APIs for flash access. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 7 ++ drivers/net/ethernet/qlogic/qed/qed_hsi.h | 7 +-

[PATCH net-next v2 4/5] qed: Adapter flash update support.

2018-03-28 Thread Sudarsana Reddy Kalluru
This patch adds the required driver support for updating the flash or non volatile memory of the adapter. At highlevel, flash upgrade comprises of reading the flash images from the input file, validating the images and writing them to the respective paritions. Signed-off-by: Sudarsana Reddy

[PATCH net-next v2 5/5] qede: Ethtool flash update support.

2018-03-28 Thread Sudarsana Reddy Kalluru
The patch adds ethtool callback implementation for flash update. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 9 + 1 file changed, 9 insertions(+) diff

[PATCH net-next v2 0/5] qed*: Flash upgrade support.

2018-03-28 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series adds adapter flash upgrade support for qed/qede drivers. Please consider applying it to net-next branch. Sudarsana Reddy Kalluru (5): qed: Populate nvm image attribute shadow. qed: Fix PTT entry leak in the

[PATCH net-next v2 1/5] qed: Populate nvm image attribute shadow.

2018-03-28 Thread Sudarsana Reddy Kalluru
This patch adds support for populating the flash image attributes. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 8 +++ drivers/net/ethernet/qlogic/qed/qed_dev.c

[PATCH net-next v2 2/5] qed: Fix PTT entry leak in the selftest error flow.

2018-03-28 Thread Sudarsana Reddy Kalluru
Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_selftest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_selftest.c

Aw: Re: RFC on writel and writel_relaxed

2018-03-28 Thread Lino Sanfilippo
Hi, > > Yeah so that other trick I'm talking about is also used for timing > accuracy. > > For example, let's say I have a device with a reset bit and the spec > says the reset bit needs to be set for at least 10us. > > This is wrong: > > writel(1, RESET_REG); > usleep(10); >

Re: [PATCH] sfp: allow cotsworks modules

2018-03-28 Thread Joe Perches
On Wed, 2018-03-28 at 11:18 +0100, Russell King wrote: > Cotsworks modules fail the checksums - it appears that Cotsworks > reprograms the EEPROM at the end of production with the final product > information (serial, date code, and exact part number for module > options) and fails to update the

Re: A cry for help, please don't ignore!

2018-03-28 Thread Sandra Y
Good Day, Forgive my indignation if this message comes to you as a surprise and may offend your personality for contacting you without your prior consent and writing through this channel. I came across your name and contact on the course of my personal searching when i was searching for a

Re: [PATCH] sfp: allow cotsworks modules

2018-03-28 Thread Russell King - ARM Linux
On Wed, Mar 28, 2018 at 03:33:57AM -0700, Joe Perches wrote: > On Wed, 2018-03-28 at 11:18 +0100, Russell King wrote: > > Cotsworks modules fail the checksums - it appears that Cotsworks > > reprograms the EEPROM at the end of production with the final product > > information (serial, date code,

Re: RFC on writel and writel_relaxed

2018-03-28 Thread okaya
On 2018-03-28 02:14, Linus Torvalds wrote: On Tue, Mar 27, 2018 at 5:24 PM, Sinan Kaya wrote: Basically changing it to dma_buffer->foo = 1;/* WB */ wmb() writel_relaxed(KICK, DMA_KICK_REGISTER);/* UC */ mmiowb() Why? Why not just remove

Re: [iproute PATCH] man: ip-route.8: ssthresh parameter is NUMBER

2018-03-28 Thread Simon Horman
On Thu, Mar 22, 2018 at 03:00:38PM +0100, Phil Sutter wrote: > Synopsis section was inconsistent with regards to help text and later > description of ssthresh parameter. > > Signed-off-by: Phil Sutter Reviewed-by: Simon Horman

[PATCH net-next] net: cavium: use module_pci_driver to simplify the code

2018-03-28 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/cavium/common/cavium_ptp.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

Re: 4.14.29 - tcp_push() - null skb's cb dereference

2018-03-28 Thread Eric Dumazet
On 03/28/2018 03:51 AM, Krzysztof Blaszkowski wrote: > Hi, > > I noticed a kernel bug report like below: > > [95576.826393] BUG: unable to handle kernel NULL pointer dereference at > 0038 > [95576.834296] IP: tcp_push+0x3d/0x110 > [95576.837829] PGD 2c8474067 P4D 2c8474067 PUD

[PATCH net-next v3 0/5] qed*: Flash upgrade support.

2018-03-28 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series adds adapter flash upgrade support for qed/qede drivers. Please consider applying it to net-next branch. Sudarsana Reddy Kalluru (5): qed: Populate nvm image attribute shadow. qed: Fix PTT entry leak in the

[PATCH net-next v3 4/5] qed: Adapter flash update support.

2018-03-28 Thread Sudarsana Reddy Kalluru
This patch adds the required driver support for updating the flash or non volatile memory of the adapter. At highlevel, flash upgrade comprises of reading the flash images from the input file, validating the images and writing them to the respective paritions. Signed-off-by: Sudarsana Reddy

[PATCH net-next v3 3/5] qed: Add APIs for flash access.

2018-03-28 Thread Sudarsana Reddy Kalluru
This patch adds APIs for flash access. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 7 ++ drivers/net/ethernet/qlogic/qed/qed_hsi.h | 7 +-

[PATCH net-next v3 2/5] qed: Fix PTT entry leak in the selftest error flow.

2018-03-28 Thread Sudarsana Reddy Kalluru
Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_selftest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_selftest.c

[PATCH net-next v3 1/5] qed: Populate nvm image attribute shadow.

2018-03-28 Thread Sudarsana Reddy Kalluru
This patch adds support for populating the flash image attributes. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 8 +++ drivers/net/ethernet/qlogic/qed/qed_dev.c

[PATCH net-next v3 5/5] qede: Ethtool flash update support.

2018-03-28 Thread Sudarsana Reddy Kalluru
The patch adds ethtool callback implementation for flash update. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 9 + 1 file changed, 9 insertions(+) diff

Re: [PATCH 3/7] net: thunderx: add multicast filter management support

2018-03-28 Thread kbuild test robot
Hi Vadim, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on v4.16-rc7 next-20180328] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Greg Ungerer
Hi Geert, On 28/03/18 17:57, Geert Uytterhoeven wrote: [skip] [PATCH] m68k: set dma and coherent masks for platform FEC ethernets As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no coherent_dma_mask") the Freescale FEC driver is issuing the following warning on driver

Re: [PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

2018-03-28 Thread Daniel Borkmann
On 03/28/2018 01:48 PM, Dan Carpenter wrote: > The skb_segment() function returns error pointers on error. It never > returns NULL. > > Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf > module") > Signed-off-by: Dan Carpenter Patch is directly

Re: [PATCH] samples/bpf: fix spelling mistake: "revieve" -> "receive"

2018-03-28 Thread Daniel Borkmann
On 03/28/2018 12:07 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error message text > > Signed-off-by: Colin Ian King Applied to bpf-next, thanks Colin!

[PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

2018-03-28 Thread Dan Carpenter
The skb_segment() function returns error pointers on error. It never returns NULL. Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf module") Signed-off-by: Dan Carpenter diff --git a/lib/test_bpf.c b/lib/test_bpf.c index

ipv6: stable request

2018-03-28 Thread Denys Zagorui
12d94a804946af291e24b80fc53ec86264765781 ipv6: fix NULL dereference in ip6_route_dev_notify() This BUG touches 4.1 4.4 4.9.

  1   2   3   4   >