Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

On 4/4/18 4:59 PM, Jakub Kicinski wrote: > On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: >>> Jiri, I am not aware of any other API where a driver registers with it >>> yet doesn't want the handler to be called so either waits to register >> >> Again, the thing is, this is kind of unusual

Re: [PATCH net] netns: filter uevents correctly

Christian Brauner writes: > On Wed, Apr 04, 2018 at 09:48:57PM +0200, Christian Brauner wrote: >> commit 07e98962fa77 ("kobject: Send hotplug events in all network >> namespaces") >> >> enabled sending hotplug events into all network namespaces back in 2010. >>

Re: [PATCH net 1/2] net: bgmac: Correctly annotate register space

Hi Florian Fainelli. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: f6a95a24957a net: ethernet: bgmac: Add platform device support. The bot has also determined it's probably a bug fixing patch. (score: 67.8237) The bot has tested

[PULL] fwcfg, vhost: features and fixes

The following changes since commit 0c8efd610b58cb23cefdfa12015799079aef94ae: Linux 4.16-rc5 (2018-03-11 17:25:09 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH net] netns: filter uevents correctly

On Wed, Apr 04, 2018 at 05:38:02PM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Wed, Apr 04, 2018 at 09:48:57PM +0200, Christian Brauner wrote: > >> commit 07e98962fa77 ("kobject: Send hotplug events in all network > >> namespaces") > >>

Re: [PATCH net v5 3/3] ipv6: udp6: set dst cache for a connected sk if current not valid

Hi Alexey Kodanev. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: 33c162a980fe ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update. The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92,

Re: [PATCH v2 net-next 06/10] mlxsw: core: Fix arg name of MLXSW_CORE_RES_VALID and MLXSW_CORE_RES_GET

Hi Ido Schimmel Jiri Pirko. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 1.5151) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build

Re: [PATCH net 2/2] net: bgmac: Fix endian access in bgmac_dma_tx_ring_free()

Hi Florian Fainelli. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: 9cde94506eac bgmac: implement scatter/gather support. The bot has also determined it's probably a bug fixing patch. (score: 45.9160) The bot has tested the

[rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

Hi all, While doing some static analysis I came across the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist, 1582

RE: [Intel-wired-lan] [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Vinicius Costa Gomes > Sent: Thursday, March 29, 2018 2:08 PM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: [Intel-wired-lan]

Re: [PATCH net] net: dsa: Discard frames from unused ports

On Wed, Apr 04, 2018 at 05:49:10PM -0700, Florian Fainelli wrote: > On 04/04/2018 04:56 PM, Andrew Lunn wrote: > > The Marvell switches under some conditions will pass a frame to the > > host with the port being the CPU port. Such frames are invalid, and > > should be dropped. Not dropping them

RE: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

> >> >One issue with the above proposed change to use TP_STATUS_IN_PROGRESS > >> >is that the documentation of the tp_status field is somewhat > >> >inconsistent. In some places it's described as TP_STATUS_KERNEL(0) > >> >meaning the entry is owned by the kernel and

Re: [PATCH v2 net-next 01/10] mlxsw: spectrum_acl: Fix flex actions header ifndef define construct

Hi Ido Schimmel Jiri Pirko. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 2.6781) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build

Re: [PATCH net] route: check sysctl_fib_multipath_use_neigh earlier than hash

Hi Xin Long. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: a6db4494d218 net: ipv4: Consider failed nexthops in multipath routes. The bot has also determined it's probably a bug fixing patch. (score: 58.0140) The bot has tested

marvell switch

Hello, I am trying to use marvell switch in linux, Is it that the kernel drivers from marvell switch are used just to enable all ports, or do they also provide APIs to userspace to enable specific ports only. I have not find examples or wiki for marvell switch, so I am not too sure as what are

Re: [PATCH iproute2] ip/l2tp: remove offset and peer-offset options

On Tue, 3 Apr 2018 17:39:54 +0200 Guillaume Nault wrote: > Ignore options "peer-offset" and "offset" when creating sessions. Keep > them when dumping sessions in order to avoid breaking external scripts. > > "peer-offset" has always been a noop in iproute2. "offset" is now

Re: [PATCH iproute2-next] tc: Correct json output for actions

On Wed, 04 Apr 2018 17:09:04 -0400 Roman Mashak wrote: > Yuval Mintz writes: > > > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > > support for tc-actions at the expense of breaking other use cases that > > reach

Re: [PATCH iproute2 rdma: Ignore unknown netlink attributes

On Tue, 3 Apr 2018 10:28:42 +0300 Leon Romanovsky wrote: > From: Leon Romanovsky > > The check if netlink attributes supplied more than maximum supported > is to strict and may lead to backward compatibility issues with old > application with a newer

Re: [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

On Thu, 2018-04-05 at 01:25 +, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: > > 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct

Re: [PATCH net-next] vxlan: add ttl inherit support

On Wed, Apr 04, 2018 at 12:03:39PM -0400, David Miller wrote: > The net-next tree is closed, please resubmit this when the net-next tree opens > back up. Sorry, I didn't pay much attention on the net-next open/close cycle before. After re-read netdev-FAQ.txt. Now I understand the steps and I need

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: > >Jiri, I am not aware of any other API where a driver registers with it > >yet doesn't want the handler to be called so either waits to register > > Again, the thing is, this is kind of unusual because of the reload > thing. FWIW my knee

[PATCH net] net: dsa: Discard frames from unused ports

The Marvell switches under some conditions will pass a frame to the host with the port being the CPU port. Such frames are invalid, and should be dropped. Not dropping them can result in a crash when incrementing the receive statistics for an invalid port. Reported-by: Chris Healy

Re: [RFC] net: bump the default number of RSS queues

On Tue, 3 Apr 2018 17:20:49 -0700, Eric Dumazet wrote: > On 04/03/2018 05:14 PM, Jakub Kicinski wrote: > > Some popular NIC vendors are not adhering to > > netif_get_num_default_rss_queues() which leads to users being > > surprised and filing bugs :) Bump the number of default RX > > queues to

Re: linux-next: manual merge of the net-next tree with the pci tree

Hi all, On Tue, 3 Apr 2018 13:14:54 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > between commit: > > 2907938d2375 ("net/mlx5e: Use

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On 04/04/18 00:37, Alexei Starovoitov wrote: > hmm. that doesn't fail for me and any other bots didn't complain. > Are you sure you're running the latest kernel and tests? Ah, test_progs isn't actually rebuilding because __NR_bpf is undeclared;  something must be going wrong with header files.

[PATCH] brcm80211: brcmsmac: phy_lcn: remove duplicate code

Remove and refactor some code in order to avoid having identical code for different branches. Notice that this piece of code hasn't been modified since 2011. Addresses-Coverity-ID: 1226756 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH net] net: dsa: Discard frames from unused ports

On 04/04/2018 04:56 PM, Andrew Lunn wrote: > The Marvell switches under some conditions will pass a frame to the > host with the port being the CPU port. Such frames are invalid, and > should be dropped. Not dropping them can result in a crash when > incrementing the receive statistics for an

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, 28 Mar 2018, Yuchung Cheng wrote: > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > wrote: > > > > If SACK is not enabled and the first cumulative ACK after the RTO > > retransmission covers more than the retransmitted skb, a spurious > > FRTO undo will

Re: [PATCH v3 net 4/5] tcp: prevent bogus undos when SACK is not enabled

On Wed, 28 Mar 2018, Yuchung Cheng wrote: > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > wrote: > > When a cumulative ACK lands to high_seq at the end of loss > > recovery and SACK is not enabled, the sender needs to avoid > > false fast retransmits (RFC6582). The

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

On Wed, 28 Mar 2018, Yuchung Cheng wrote: > On Wed, Mar 28, 2018 at 7:14 AM, Yuchung Cheng wrote: > > > > On Wed, Mar 28, 2018 at 5:45 AM, Ilpo Järvinen > > wrote: > > > On Tue, 27 Mar 2018, Yuchung Cheng wrote: > > > > > >> On Tue, Mar 27, 2018 at

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/31/2018 8:21 PM, David Ahern wrote: On 3/31/18 9:53 AM, Andrew Lunn wrote: I want to be able to login to a customer and accessing this snapshot without any previous configuration from the user and not asking for enabling the feature and then waiting for a repro...this will help debugging

Re: PROBLEM: Using BPF_PROG_TEST_RUN with data_out != NULL is unsafe

On 04/04/2018 11:04 AM, Lorenz Bauer wrote: > Hello, > > I’ve encountered an issue when using BPF_PROG_TEST_RUN and capturing the > output. > The kernel copies data into user space without checking the length of > the destination buffer. > > In bpf_test_finish(), size is the amount of data in

[PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

The new of_get_nvmem_mac_address() helper function causes a link error with CONFIG_NVMEM=m: drivers/of/of_net.o: In function `of_get_nvmem_mac_address': of_net.c:(.text+0x168): undefined reference to `of_nvmem_cell_get' of_net.c:(.text+0x19c): undefined reference to `nvmem_cell_read'

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

Thu, Apr 05, 2018 at 01:00:18AM CEST, dsah...@gmail.com wrote: >On 4/4/18 4:59 PM, Jakub Kicinski wrote: >> On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: Jiri, I am not aware of any other API where a driver registers with it yet doesn't want the handler to be called so either

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Wed, Apr 4, 2018 at 7:42 AM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individual >> objects vs just a single "bundle" of them that represents a NIC. But, that's >> the way the DPAA2 hardware is, and we're implementing kernel support

Re: [PATCH net-next RFC 0/5] ipv6: sr: introduce seg6local End.BPF action

On Wed, Apr 4, 2018 at 2:34 AM, Mathieu Xhonneux wrote: > 2018-04-03 16:25 GMT+02:00 David Lebrun : >> Actually I'm wrong here. dst_input() will call either ip6_input() or >> ip6_forward(), not ipv6_rcv(). Both functions expect IP6CB() to be set, >> so

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On Thu, Apr 05, 2018 at 12:58:46AM +0100, Edward Cree wrote: > On 04/04/18 00:37, Alexei Starovoitov wrote: > > hmm. that doesn't fail for me and any other bots didn't complain. > > Are you sure you're running the latest kernel and tests? > Ah, test_progs isn't actually rebuilding because __NR_bpf

[PATCH] mac80211: Fix bad line warning

After 03fe2debbb2771fb90881e merged during 4.17 marge window, I start to see following warning during "make xmldocs" ./include/net/mac80211.h:2083: warning: bad line: > Replace ">" with "*" fix the issue. Signed-off-by: Masanari Iida --- include/net/mac80211.h | 2 +-

Re: [PATCH] net: improve ipv4 performances

On Sun, 2018-04-01 at 20:31 +0200, Anton Gary Ceph wrote: > After a few profiling and analysis, turned out that the ethertype field > of the packets has the following distribution: [...] > 0.6% don't know/no opinion Am I the only one finding the submission date and the above info suspicious

Re: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote: > Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which > casues the ring to get corrupted by allowing multiple kernel threads > to claim ownership of the same ring entry, Mark the ring entry as > already being used

[PATCH] netdevsim: remove incorrect __net_initdata annotations

The __net_initdata section cannot currently be used for structures that get cleaned up in an exitcall using unregister_pernet_operations: WARNING: vmlinux.o(.text+0x868c34): Section mismatch in reference from the function nsim_devlink_exit() to the (unknown reference) .init.data:(unknown) The

Re: [net-next V9 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call

On 03/04/2018 2:08 PM, Jesper Dangaard Brouer wrote: This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page returns the page through the page allocator. And at the same time, have pages getting returned to

[PATCH iproute2-next] tc: Correct json output for actions

Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON support for tc-actions at the expense of breaking other use cases that reach tc_print_action(), as the latter don't expect the 'actions' array to be a new object. Consider the following taken duringrun of tc_chain.sh selftest,

[PATCH net-next] net: avoid unneeded atomic operation in ip*_append_data()

After commit 694aba690de0 ("ipv4: factorize sk_wmem_alloc updates done by __ip_append_data()") and commit 1f4c6eb24029 ("ipv6: factorize sk_wmem_alloc updates done by __ip6_append_data()"), when transmitting sub MTU datagram, an addtional, unneeded atomic operation is performed in

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

> I hear you. It is more complicated this way...having all these individual > objects vs just a single "bundle" of them that represents a NIC. But, that's > the way the DPAA2 hardware is, and we're implementing kernel support for > the hardware as it is. Hi Stuart I see we are not making any

Re: [PATCH net-next] net: avoid unneeded atomic operation in ip*_append_data()

On 04/04/2018 05:30 AM, Paolo Abeni wrote: > After commit 694aba690de0 ("ipv4: factorize sk_wmem_alloc updates > done by __ip_append_data()") and commit 1f4c6eb24029 ("ipv6: > factorize sk_wmem_alloc updates done by __ip6_append_data()"), > when transmitting sub MTU datagram, an addtional,

[PATCH net-next] vxlan: add ttl inherit support

Like tos inherit, ttl inherit should also means inherit the inner protocol's ttl values, which actually not implemented in vxlan yet. But we could not treat ttl == 0 as "use the inner TTL", because that would be used also when the "ttl" option is not specified and that would be a behavior change,

[net-next 1/1] tipc: Fix namespace violation in tipc_sk_fill_sock_diag

To fetch UID info for socket diagnostics, we determine the namespace of user context using tipc socket instance. This may cause namespace violation, as the kernel will remap based on UID. We fix this by fetching namespace info using the calling userspace netlink socket. Fixes: c30b70deb5f4

Re: [net-next V9 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call

On Wed, 4 Apr 2018 16:12:14 +0300 Tariq Toukan wrote: > > @@ -432,9 +434,12 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c, > > > > rq->buff.map_dir = rq->xdp_prog ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE; > > rq->buff.headroom = mlx5e_get_rq_headroom(mdev,

Re: [PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

On Wed, Apr 4, 2018 at 3:32 PM, Mike Looijmans wrote: > > Which may still be very confusing, since it means that CONFIG_MACB=y with > CONFIG_NVMEM=m will fail, but setting both to "y" or both to "m" will work. > So that would introduce more build failures again, right?

Re: [RFC PATCH net] tcp: allow to use TCP Fastopen with MSG_ZEROCOPY

On Tue, Apr 3, 2018 at 2:43 PM, Alexey Kodanev wrote: > With TCP Fastopen we can have the following cases, which could also > use MSG_ZEROCOPY flag with send() and sendto(): > > * sendto() + MSG_FASTOPEN flag, sk state can be in TCP_CLOSE at > the start of

Re: [PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

For making things build again: Acked-by: Mike Looijmans I'd be interested in use-cases for having nvmem as a module, I cannot think of any. I am working on splitting of_get_nvmem_mac_address(), by moving most of its burden to the nvmem interface. Intend to create this "just give me my

Re: [PATCH net-next] pptp: remove a buggy dst release in pptp_connect()

From: Eric Dumazet Date: Mon, 2 Apr 2018 18:48:37 -0700 > Once dst has been cached in socket via sk_setup_caps(), > it is illegal to call ip_rt_put() (or dst_release()), > since sk_setup_caps() did not change dst refcount. > > We can still dereference it since we hold

Re: WARNING: refcount bug in should_fail

Al Viro writes: > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort >> of bugs (most of them preexisting, but I should've checked instead >> of assuming that everything's fine). Will push

Re: [PATCH net 0/2] net: Broadcom drivers sparse fixes

From: Florian Fainelli Date: Mon, 2 Apr 2018 15:58:54 -0700 > This patch series fixes the same warning reported by sparse in bcmsysport and > bcmgenet in the code that deals with inserting the TX checksum pointers: > > drivers/net/ethernet/broadcom/bcmsysport.c:1155:26:

Re: [PATCH net v6 0/4] ipv6: udp: set dst cache for a connected sk if current not valid

From: Alexey Kodanev Date: Tue, 3 Apr 2018 15:00:06 +0300 > A new RTF_CACHE route can be created with the socket's dst cache > update between the below calls in udpv6_sendmsg(), when datagram > sending results to ICMPV6_PKT_TOOBIG error: > >dst =

Re: [net-next 1/1] tipc: Fix missing list initializations in struct tipc_subscription

From: Jon Maloy Date: Tue, 3 Apr 2018 19:11:19 +0200 > When an item of struct tipc_subscription is created, we fail to > initialize the two lists aggregated into the struct. This has so far > never been a problem, since the items are just added to a root > object by

Re: [PATCH] netdevsim: remove incorrect __net_initdata annotations

On 4/4/18 6:12 AM, Arnd Bergmann wrote: > The __net_initdata section cannot currently be used for structures that > get cleaned up in an exitcall using unregister_pernet_operations: > > WARNING: vmlinux.o(.text+0x868c34): Section mismatch in reference from the > function nsim_devlink_exit() to

Re: [PATCH] netdevsim: remove incorrect __net_initdata annotations

On Wed, Apr 4, 2018 at 5:33 PM, David Ahern wrote: > On 4/4/18 6:12 AM, Arnd Bergmann wrote: >> The __net_initdata section cannot currently be used for structures that >> get cleaned up in an exitcall using unregister_pernet_operations: >> > > I am confused ... I do the

Re: [PATCH v2] lan78xx: Connect phy early

From: Alexander Graf Date: Wed, 4 Apr 2018 00:19:35 +0200 > When using wicked with a lan78xx device attached to the system, we > end up with ethtool commands issued on the device before an ifup > got issued. That lead to the following crash: > ... > The culprit is quite simple:

Re: [PATCH] mac80211: Fix bad line warning

From: Masanari Iida Date: Wed, 4 Apr 2018 20:53:33 +0900 > After 03fe2debbb2771fb90881e merged during 4.17 marge window, > I start to see following warning during "make xmldocs" > > ./include/net/mac80211.h:2083: warning: bad line: > > > Replace ">" with "*" fix the

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

On Wed, Apr 04, 2018 at 11:46:28AM -0400, Bob Peterson wrote: > > The patches look good. The big question is whether to add them to this > merge window while it's still open. Opinions? We're still hashing out the rhashtable interface so I don't think now is the time to rush things. Thanks, --

Re: [PATCH] netdevsim: remove incorrect __net_initdata annotations

From: Arnd Bergmann Date: Wed, 4 Apr 2018 14:12:39 +0200 > The __net_initdata section cannot currently be used for structures that > get cleaned up in an exitcall using unregister_pernet_operations: > > WARNING: vmlinux.o(.text+0x868c34): Section mismatch in reference from the

Re: [PATCH net-next 2/2] inet: frags: fix ip6frag_low_thresh boundary

From: Eric Dumazet Date: Wed, 4 Apr 2018 08:35:10 -0700 > Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, > since linker might place next to it a non zero value preventing a change > to ip6frag_low_thresh. > > ip6frag_low_thresh is not used

Re: [PATCH] netdevsim: remove incorrect __net_initdata annotations

On Wed, Apr 4, 2018 at 5:52 PM, David Miller wrote: > From: Arnd Bergmann > Date: Wed, 4 Apr 2018 14:12:39 +0200 > >> The __net_initdata section cannot currently be used for structures that >> get cleaned up in an exitcall using unregister_pernet_operations:

Commits going to plain 'net' tree now.

Therefore, please submit bug fixes relative to 'net', thank you.

Re: RTL8723BE performance regression

On Tue, Apr 3, 2018 at 6:51 PM, João Paulo Rechi Vita wrote: > > This are the results (testing with speedtest.net) I got at some key points: > > VersionCommitPingDownUp > > v4.11a351e9b1225.445.99 > v4.11

Re: [PATCH net-next] rxrpc: Fix undefined packet handling

From: David Howells Date: Mon, 02 Apr 2018 23:51:39 +0100 > By analogy with other Rx implementations, RxRPC packet types 9, 10 and 11 > should just be discarded rather than being aborted like other undefined > packet types. > > Reported-by: Jeffrey Altman

Re: [PATCH net] net: dsa: b53: Fix sparse warnings in b53_mmap.c

From: Florian Fainelli Date: Mon, 2 Apr 2018 16:17:01 -0700 > sparse complains about the following warnings: > > drivers/net/dsa/b53/b53_mmap.c:33:31: warning: incorrect type in > initializer (different address spaces) > drivers/net/dsa/b53/b53_mmap.c:33:31:expected

Re: [PATCH v2] net: phy: marvell10g: add thermal hwmon device

From: Russell King Date: Tue, 03 Apr 2018 10:31:45 +0100 > Add a thermal monitoring device for the Marvell 88x3310, which updates > once a second. We also need to hook into the suspend/resume mechanism > to ensure that the thermal monitoring is reconfigured when we

Re: [PATCH net-next 5/5] macvlan/macvtap: Add support for SCTP checksum offload.

On Mon, 2018-04-02 at 09:40 -0400, Vladislav Yasevich wrote: > Since we now have support for software CRC32c offload, turn it on > for macvlan and macvtap devices so that guests can take advantage > of offload SCTP checksums to the host or host hardware. > > Signed-off-by: Vladislav Yasevich

[PATCH net-next 2/2] inet: frags: fix ip6frag_low_thresh boundary

Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, since linker might place next to it a non zero value preventing a change to ip6frag_low_thresh. ip6frag_low_thresh is not used anymore in the kernel, but we do not want to prematuraly break user scripts wanting to change

Re: [PATCH net] nfp: use full 40 bits of the NSP buffer address

From: Jakub Kicinski Date: Tue, 3 Apr 2018 17:24:23 -0700 > From: Dirk van der Merwe > > The NSP default buffer is a piece of NFP memory where additional > command data can be placed. Its format has been copied from > host buffer,

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

- Original Message - > Here's a second version of the patch (now a patch set) to eliminate > rhashtable_walk_peek in gfs2. > > The first patch introduces lockref_put_not_zero, the inverse of > lockref_get_not_zero. > > The second patch eliminates rhashtable_walk_peek in gfs2. In >

RE: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

> > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > > index e0f3f4a..264d7b2 100644 > > --- a/net/packet/af_packet.c > > +++ b/net/packet/af_packet.c > > @@ -2287,6 +2287,15 @@ static int tpacket_rcv(struct sk_buff *skb, struct > > net_device *dev, > > if

Re: [Patch net] af_unix: remove redundant lockdep class

From: Cong Wang Date: Mon, 2 Apr 2018 11:01:27 -0700 > After commit 581319c58600 ("net/socket: use per af lockdep classes for sk > queues") > sock queue locks now have per-af lockdep classes, including unix socket. > It is no longer necessary to workaround it. > > I

Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer

From: Florian Fainelli Date: Mon, 2 Apr 2018 16:24:14 -0700 > We would be passing 0 instead of NULL as the rsp argument to > mt7530_fdb_cmd(), fix that. > > Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 > switch") > Signed-off-by: Florian

Re: [PATCH 40/47] netfilter: nf_tables: build-in filter chain type

On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso wrote: > One module per supported filter chain family type takes too much memory > for very little code - too much modularization - place all chain filter > definitions in one single file. > > Signed-off-by: Pablo Neira Ayuso

Re: [PATCH] [net] nvmem: disallow modular CONFIG_NVMEM

From: Arnd Bergmann Date: Wed, 4 Apr 2018 12:38:40 +0200 > The new of_get_nvmem_mac_address() helper function causes a link error > with CONFIG_NVMEM=m: > > drivers/of/of_net.o: In function `of_get_nvmem_mac_address': > of_net.c:(.text+0x168): undefined reference to

Re: [PATCH] net: hns3: fix length overflow when CONFIG_ARM64_64K_PAGES

From: Tan Xiaojun Date: Wed, 4 Apr 2018 17:40:48 +0800 > When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE > is 65536(64K). But the type of length is u16, it will overflow. So change it > to u32. > > Signed-off-by: Tan Xiaojun

Re: [PATCH 40/47] netfilter: nf_tables: build-in filter chain type

On Wed, Apr 04, 2018 at 05:38:31PM +0200, Arnd Bergmann wrote: > On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso > wrote: > > One module per supported filter chain family type takes too much memory > > for very little code - too much modularization - place all chain

Re: [PATCH 40/47] netfilter: nf_tables: build-in filter chain type

On Wed, Apr 4, 2018 at 5:46 PM, Pablo Neira Ayuso wrote: > On Wed, Apr 04, 2018 at 05:38:31PM +0200, Arnd Bergmann wrote: >> On Fri, Mar 30, 2018 at 1:46 PM, Pablo Neira Ayuso >> wrote: >> > One module per supported filter chain family type takes too

Re: [PATCH net-next] net: avoid unneeded atomic operation in ip*_append_data()

From: Paolo Abeni Date: Wed, 4 Apr 2018 14:30:01 +0200 > After commit 694aba690de0 ("ipv4: factorize sk_wmem_alloc updates > done by __ip_append_data()") and commit 1f4c6eb24029 ("ipv6: > factorize sk_wmem_alloc updates done by __ip6_append_data()"), > when transmitting sub

Re: [PATCH net] sfc: remove ctpio_dmabuf_start from stats

From: Bert Kenward Date: Wed, 4 Apr 2018 16:40:30 +0100 > The ctpio_dmabuf_start entry is not actually a stat and shouldn't > be exposed to ethtool. > > Fixes: 2c0b6ee837db ("sfc: expose CTPIO stats on NICs that support > them") Please don't break up a long Fixes tag

RE: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

On Wednesday, April 04, 2018 9:49 AM, Willem de Bruijn wrote: > > On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote: > > Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which > > casues the ring to get corrupted by allowing multiple kernel

Re: [PATCH net-next] nfp: add a separate counter for packets with CHECKSUM_COMPLETE

From: Jakub Kicinski Date: Mon, 2 Apr 2018 13:31:20 -0700 > We are currently counting packets with CHECKSUM_COMPLETE as > "hw_rx_csum_ok". This is confusing. Add a new counter. > To make sure it fits in the same cacheline move the less used > error counter to a

Re: [PATCH net-next 2/2] inet: frags: fix ip6frag_low_thresh boundary

On 04/04/2018 08:35 AM, Eric Dumazet wrote: > Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, > since linker might place next to it a non zero value preventing a change > to ip6frag_low_thresh. > > ip6frag_low_thresh is not used anymore in the kernel, but we do not >

[PATCH net] sfc: remove ctpio_dmabuf_start from stats

The ctpio_dmabuf_start entry is not actually a stat and shouldn't be exposed to ethtool. Fixes: 2c0b6ee837db ("sfc: expose CTPIO stats on NICs that support them") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 2 -- drivers/net/ethernet/sfc/nic.h | 1

Re: [net-next 1/1] tipc: Fix namespace violation in tipc_sk_fill_sock_diag

From: GhantaKrishnamurthy MohanKrishna Date: Wed, 4 Apr 2018 14:49:47 +0200 > To fetch UID info for socket diagnostics, we determine the > namespace of user context using tipc socket instance. This > may cause namespace violation, as the kernel

Re: [PATCH net-next] vxlan: add ttl inherit support

From: Hangbin Liu Date: Wed, 4 Apr 2018 21:26:21 +0800 > Like tos inherit, ttl inherit should also means inherit the inner protocol's > ttl values, which actually not implemented in vxlan yet. > > But we could not treat ttl == 0 as "use the inner TTL", because that would

Re: [PATCH net] arp: fix arp_filter on l3slave devices

On 4/4/18 4:13 AM, Miguel Fadon Perlines wrote: > arp_filter performs an ip_route_output search for arp source address and > > checks if output device is the same where the arp request was received, > > if it is not, the arp request is not answered. > >   > > This route lookup is always done

[PATCH iproute2-next 1/1] tc: jsonify tunnel_key action

Signed-off-by: Roman Mashak --- tc/m_tunnel_key.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/tc/m_tunnel_key.c b/tc/m_tunnel_key.c index bac3c07fa90b..0fa461549ad9 100644 --- a/tc/m_tunnel_key.c +++

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/4/18 1:36 AM, Siwei Liu wrote: > On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote: >> On 4/3/18 9:42 AM, Jiri Pirko wrote: There are other use cases that want to hide a device from userspace. I >>> >>> What usecases do you have in mind? >> >> As mentioned in a

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote: > Agreed. That's a good point. And I would much preferred to rename that > to FLAG_ORIG_PROGRESS (w/ updated comment). > so I think we're in agreement to use existing patch w/ the new name > FLAG_ORIG_PROGRESS Yes, SGTM. I

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

From: David Ahern Date: Wed, 4 Apr 2018 11:21:54 -0600 > It is a netdev so there is no reason to have a separate ip command to > inspect it. 'ip link' is the right place. I agree on this. What I really don't understand still is the use case... really. So there are control

Re: [Intel-wired-lan] [iwl next-queue PATCH 03/10] macvlan: Use software path for offloaded local, broadcast, and multicast traffic

On Wed, Apr 4, 2018 at 9:53 AM, Shannon Nelson wrote: > On 4/3/2018 2:16 PM, Alexander Duyck wrote: >> >> This change makes it so that we use a software path for packets that are >> going to be locally switched between two macvlan interfaces on the same >> device. In

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Apr 4, 2018 at 9:33 AM, Neal Cardwell wrote: > > On Wed, Apr 4, 2018 at 6:35 AM Ilpo Järvinen > wrote: > > > On Wed, 28 Mar 2018, Yuchung Cheng wrote: > > > > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > > >

Re: [PATCH iproute2-next] tc: Correct json output for actions

On 4/4/18 6:24 AM, Yuval Mintz wrote: > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > support for tc-actions at the expense of breaking other use cases that > reach tc_print_action(), as the latter don't expect the 'actions' array > to be a new object. > > Consider the

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

On Wed, Apr 4, 2018 at 6:42 AM Ilpo Järvinen wrote: > On Wed, 28 Mar 2018, Yuchung Cheng wrote: ... > > Your patch looks good. Some questions / comments: The patch looks good to me as well (I read the Mar 28 version). Thanks for this fix, Ilpo. > Just to be sure that

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Apr 4, 2018 at 10:22 AM, Neal Cardwell wrote: > n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote: >> Agreed. That's a good point. And I would much preferred to rename that >> to FLAG_ORIG_PROGRESS (w/ updated comment). > >> so I think we're in

  1   2   >