[PATCH] filter.txt: update 'tools/net/' to 'tools/bpf/'

2018-04-15 Thread Wang Sheng-Hui
The tools are located at tootls/bpf/ instead of tools/net/. Update the filter.txt doc. Signed-off-by: Wang Sheng-Hui --- Documentation/networking/filter.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/filter.txt b/Documentation/networking/f

Re: [Patch net] llc: properly handle dev_queue_xmit() return value

2018-04-15 Thread Noam Rathaus
Hi, Is there any update? On Fri, Apr 13, 2018 at 7:49 PM, Noam Rathaus wrote: > Hi > > Any update? > > On Thu, 29 Mar 2018 at 14:11, Noam Rathaus wrote: >> >> Hi, >> >> Will you notify me when its been accepted? if not, how can I do this >> checking myself to see if it was accepted? >> >> On Tu

One question about __tcp_select_window()

2018-04-15 Thread Wang Jian
Hi all, While I read __tcp_select_window() code, I find that it maybe return a smaller window. Below is one scenario I thought, may be not right: In function __tcp_select_window(), assume: full_space is 6mss, free_space is 2mss, tp->rcv_wnd is 3MSS. And assume disable window scaling, then window =

Re: linux-next on x60: network manager often complains "network is disabled" after resume

2018-04-15 Thread Pavel Machek
On Mon 2018-03-26 10:33:55, Dan Williams wrote: > On Sun, 2018-03-25 at 08:19 +0200, Pavel Machek wrote: > > > > > Ok, what does 'nmcli dev' and 'nmcli radio' show? > > > > > > > > Broken state. > > > > > > > > pavel@amd:~$ nmcli dev > > > > DEVICE TYPE STATECONNECTION > > > > eth1

Re: linux-next on x60: network manager often complains "network is disabled" after resume

2018-04-15 Thread Pavel Machek
On Tue 2018-03-20 21:11:54, Woody Suwalski wrote: > Woody Suwalski wrote: > >Pavel Machek wrote: > >>On Mon 2018-03-19 05:17:45, Woody Suwalski wrote: > >>>Pavel Machek wrote: > Hi! > > With recent linux-next, after resume networkmanager often claims that > "network is disabled". S

Re: [PATCH iproute2] utils: Do not reset family for default, any, all addresses

2018-04-15 Thread Thomas Deutschmann
Hi, I can confirm that this patch solves the issue for us and restores previous behavior. Thank you. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

Re: [PATCH net] team: avoid adding twice the same option to the event list

2018-04-15 Thread Paolo Abeni
On Fri, 2018-04-13 at 14:07 -0400, David Miller wrote: > From: Paolo Abeni > Date: Fri, 13 Apr 2018 13:59:25 +0200 > > > When parsing the options provided by the user space, > > team_nl_cmd_options_set() insert them in a temporary list to send > > multiple events with a single message. > > While

[PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread Thomas Falcon
Due to a firmware bug, the hypervisor can send an interrupt to a transmit or receive queue just prior to a partition migration, not allowing the device enough time to handle it and send an EOI. When the partition migrates, the interrupt is lost but an "EOI-pending" flag for the interrupt line is st

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread Thomas Falcon
On 04/15/2018 06:27 PM, Thomas Falcon wrote: > Due to a firmware bug, the hypervisor can send an interrupt to a > transmit or receive queue just prior to a partition migration, not > allowing the device enough time to handle it and send an EOI. When > the partition migrates, the interrupt is lost b

[PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread Thomas Falcon
Due to a firmware bug, the hypervisor can send an interrupt to a transmit or receive queue just prior to a partition migration, not allowing the device enough time to handle it and send an EOI. When the partition migrates, the interrupt is lost but an "EOI-pending" flag for the interrupt line is st

Re: [PATCH v2 iproute2-next 1/1] tc: jsonify skbedit action

2018-04-15 Thread David Ahern
On 4/10/18 12:04 PM, Roman Mashak wrote: > v2: >FIxed strings format in print_string() > > Signed-off-by: Roman Mashak > --- > tc/m_skbedit.c | 53 + > 1 file changed, 29 insertions(+), 24 deletions(-) > applied to iproute2-next

Re: [PATCH iproute2-next 1/1] tc: jsonify ife action

2018-04-15 Thread David Ahern
On 4/13/18 3:40 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/m_ife.c | 54 -- > 1 file changed, 32 insertions(+), 22 deletions(-) > applied to iproute2-next

Re: [PATCH] filter.txt: update 'tools/net/' to 'tools/bpf/'

2018-04-15 Thread David Miller
From: Wang Sheng-Hui Date: Sun, 15 Apr 2018 16:07:12 +0800 > The tools are located at tootls/bpf/ instead of tools/net/. > Update the filter.txt doc. > > Signed-off-by: Wang Sheng-Hui Applied, thank you.

[PATCH net] net: af_packet: fix race in PACKET_{R|T}X_RING

2018-04-15 Thread Eric Dumazet
In order to remove the race caught by syzbot [1], we need to lock the socket before using po->tp_version as this could change under us otherwise. This means lock_sock() and release_sock() must be done by packet_set_ring() callers. [1] : BUG: KMSAN: uninit-value in packet_set_ring+0x1254/0x3870 n

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread David Miller
From: Thomas Falcon Date: Sun, 15 Apr 2018 18:53:36 -0500 > Due to a firmware bug, the hypervisor can send an interrupt to a > transmit or receive queue just prior to a partition migration, not > allowing the device enough time to handle it and send an EOI. When > the partition migrates, the inte

[PATCH 1/1] net/mlx4_core: avoid resetting HCA when accessing an offline device

2018-04-15 Thread Zhu Yanjun
While a faulty cable is used or HCA firmware error, HCA device will be offline. When the driver is accessing this offline device, the following call trace will pop out. " ... [] dump_stack+0x63/0x81 [] panic+0xcc/0x21b [] mlx4_enter_error_state+0xba/0xf0 [mlx4_core] [] mlx4_cmd_reset_flow+

Re: tcp hang when socket fills up ?

2018-04-15 Thread Dominique Martinet
Eric Dumazet wrote on Fri, Apr 13, 2018: > That might be caused by some TS val/ecr breakage : > > Many acks were received by the server tcpdump, > but none of them was accepted by TCP stack, for some reason. > > Try to disable TCP timestamps, it will give some hint if bug does not > reproduce.

[PATCH net] net: Fix one possible memleak in ip_setup_cork

2018-04-15 Thread gfree . wind
From: Gao Feng It would allocate memory in this function when the cork->opt is NULL. But the memory isn't freed if failed in the latter rt check, and return error directly. It causes the memleak if its caller is ip_make_skb which also doesn't free the cork->opt when meet a error. Now move the rt

[PATCH net] net: Fix one possible memleak in ip_setup_cork

2018-04-15 Thread gfree . wind
From: Gao Feng It would allocate memory in this function when the cork->opt is NULL. But the memory isn't freed if failed in the latter rt check, and return error directly. It causes the memleak if its caller is ip_make_skb which also doesn't free the cork->opt when meet a error. Now move the rt

Re: tcp hang when socket fills up ?

2018-04-15 Thread Eric Dumazet
On 04/15/2018 06:47 PM, Dominique Martinet wrote: > Also, here are the per-socket stats I could find (ss -i after having > reproduced hang): >reno wscale:7,7 rto:7456 backoff:5 rtt:32.924/1.41 ato:40 mss:1374 >pmtu:1500 rcvmss:1248 advmss:1448 cwnd:1 ssthresh:16 >bytes_ac

linux-next: build failure after merge of the bpf tree

2018-04-15 Thread Stephen Rothwell
Hi all, After merging the bpf tree, today's linux-next build (arm multi_v7_defconfig) failed like this: kernel/bpf/core.o: In function `sock_map_release': core.c:(.text+0xd04): multiple definition of `sock_map_release' kernel/sysctl.o:sysctl.c:(.text+0x1a50): first defined here kernel/events/core

[PATCH] net: mediatek: use of_device_get_match_data()

2018-04-15 Thread Ryder Lee
The usage of of_device_get_match_data() reduce the code size a bit. Also, the only way to call mtk_probe() is to match an entry in of_mtk_match[], so match cannot be NULL. Signed-off-by: Ryder Lee --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deleti

Re: [PATCH net] net: Fix one possible memleak in ip_setup_cork

2018-04-15 Thread David Miller
From: gfree.w...@vip.163.com Date: Mon, 16 Apr 2018 10:16:45 +0800 > From: Gao Feng > > It would allocate memory in this function when the cork->opt is NULL. But > the memory isn't freed if failed in the latter rt check, and return error > directly. It causes the memleak if its caller is ip_make

Re:Re: [PATCH net] net: Fix one possible memleak in ip_setup_cork

2018-04-15 Thread Gao Feng
At 2018-04-16 10:55:56, "David Miller" wrote: >From: gfree.w...@vip.163.com >Date: Mon, 16 Apr 2018 10:16:45 +0800 > >> From: Gao Feng >> >> It would allocate memory in this function when the cork->opt is NULL. But >> the memory isn't freed if failed in the latter rt check, and return error >> d

Re: tcp hang when socket fills up ?

2018-04-15 Thread Dominique Martinet
Eric Dumazet wrote on Sun, Apr 15, 2018: > Are you sure you do not have some iptables/netfilter stuff ? I have a basic firewall setup with default rules e.g. starts with -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT in the INPUT chain... That said, I just dropped it on the server to check a

Re: tcp hang when socket fills up ?

2018-04-15 Thread Dominique Martinet
Dominique Martinet wrote on Mon, Apr 16, 2018: > . . . Oh, there is something interesting there, the connection doesn't > come up with -G? Hm, sorry, I take this last part back. I cannot reproduce -G not working reliably. I'll dig around the conntrack table a bit more. -- Dominique Martinet | A

KASAN: use-after-free Read in tipc_nametbl_stop

2018-04-15 Thread syzbot
Hello, syzbot hit the following crash on net-next commit 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=d64b64afc55660106556 So far this cras

Re: XDP performance regression due to CONFIG_RETPOLINE Spectre V2

2018-04-15 Thread Jesper Dangaard Brouer
On Sat, 14 Apr 2018 21:29:26 +0200 David Woodhouse wrote: > On Fri, 2018-04-13 at 19:26 +0200, Christoph Hellwig wrote: > > On Fri, Apr 13, 2018 at 10:12:41AM -0700, Tushar Dave wrote: > > > I guess there is nothing we need to do! > > > > > > On x86, in case of no intel iommu or iommu is disabl