Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

2018-05-08 Thread Andres Rodriguez
On 2018-05-08 02:12 PM, Luis R. Rodriguez wrote: Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9

Re: [PATCH bpf-next 6/6] bpf: btf: Tests for BPF_OBJ_GET_INFO_BY_FD and BPF_BTF_GET_FD_BY_ID

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch adds test for BPF_BTF_GET_FD_BY_ID and the new > btf_id/btf_key_id/btf_value_id in the "struct bpf_map_info". > > It also modifies the existing BPF_OBJ_GET_INFO_BY_FD test > to reflect the new "struct

Re: KASAN: use-after-free Read in sctp_do_sm

2018-05-08 Thread Marcelo Ricardo Leitner
On Wed, May 09, 2018 at 01:41:03AM +0800, Xin Long wrote: ... > > sctp_chunk_destroy net/sctp/sm_make_chunk.c:1481 [inline] > > sctp_chunk_put+0x321/0x440 net/sctp/sm_make_chunk.c:1504 > > sctp_ulpevent_make_rcvmsg+0x955/0xd40 net/sctp/ulpevent.c:718 > There's no reason to put the chunk in

Re: [RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-08 Thread Tobin C. Harding
On Tue, May 08, 2018 at 11:36:51AM +0200, Andrea Greco wrote: > On 05/07/2018 04:55 AM, Tobin C. Harding wrote: > >On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote: > >>From: Andrea Greco > > > >Hi Andrea, > > > >Here are some (mostly stylistic) suggestions to help

Re: The SO_BINDTODEVICE was set to the desired interface, but packets are received from all interfaces.

2018-05-08 Thread David Ahern
On 5/7/18 6:41 AM, Paolo Abeni wrote: > Hi, > On Mon, 2018-05-07 at 13:19 +0300, Damir Mansurov wrote: >> After successful call of the setsockopt(SO_BINDTODEVICE) function to set >> data reception from only one interface, the data is still received from >> all interfaces. Function setsockopt()

Re: [PATCH bpf-next 4/6] bpf: btf: Some test_btf clean up

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch adds a CHECK() macro for condition checking > and error report purpose. Something similar to test_progs.c > > It also counts the number of tests passed/skipped/failed and > print them at the end of the test

Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary #address/#size-cells

2018-05-08 Thread Florian Fainelli
On 05/07/2018 05:17 AM, Fabio Estevam wrote: > From: Fabio Estevam > > If the example binding is used on a real dts file, the following DTC > warning is seen with W=1: > > arch/arm/boot/dts/imx6q-b450v3.dtb: Warning (avoid_unnecessary_addr_size): >

Re: [PATCH bpf-next 2/6] bpf: btf: Introduce BTF ID

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch gives an ID to each loaded BTF. The ID is allocated by > the idr like the existing prog-id and map-id. > > The bpf_put(map->btf) is moved to __bpf_map_put() so that the > userspace can stop seeing the BTF ID

Re: [PATCH] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-08 Thread Stephen Hemminger
On Tue, 08 May 2018 20:17:51 +0200 Mohammed Gamal wrote: > On Tue, 2018-05-08 at 11:13 -0700, Stephen Hemminger wrote: > > On Tue,  8 May 2018 19:40:47 +0200 > > Mohammed Gamal wrote: > > > > > On older windows hosts the net_device instance is returned

[PATCH] [ATM] firestream: fix spelling mistake: "reseverd" -> "reserved"

2018-05-08 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in res_strings string array Signed-off-by: Colin Ian King --- drivers/atm/firestream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/firestream.c

Re: [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-08 Thread Kees Cook
On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez wrote: > If you try to read FW_LOADER today it speaks of old riddles and > unless you have been following development closely you will loose Typo: lose > track of what is what. Even the documentation for

Re: [PATCH bpf-next 1/6] bpf: btf: Avoid WARN_ON when CONFIG_REFCOUNT_FULL=y

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > If CONFIG_REFCOUNT_FULL=y, refcount_inc() WARN when refcount is 0. > When creating a new btf, the initial btf->refcnt is 0 and > triggered the following: > > [ 34.855452] refcount_t: increment on 0; use-after-free. > [

Re: [PATCH bpf-next 3/6] bpf: btf: Add struct bpf_btf_info

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > During BPF_OBJ_GET_INFO_BY_FD on a btf_fd, the current bpf_attr's > info.info is directly filled with the BTF binary data. It is > not extensible. In this case, we want to add BTF ID. > > This patch adds "struct

Re: [PATCH bpf-next 5/6] bpf: btf: Update tools/include/uapi/linux/btf.h with BTF ID

2018-05-08 Thread Song Liu
> On May 4, 2018, at 2:49 PM, Martin KaFai Lau wrote: > > This patch sync the tools/include/uapi/linux/btf.h with > the newly introduced BTF ID support. > > Signed-off-by: Martin KaFai Lau > Acked-by: Alexei Starovoitov > --- >

ICMP redirect and VRF

2018-05-08 Thread Ben Greear
While debugging some other problem today on a system using ip rules instead of VRF, I ran into a case where the remote router was sending back ICMP redirects. That got me thinking...where would these routes get stored in a VRF scenario? Would it magically go to the correct VRF routing table

[PATCH] sctp: fix spelling mistake: "max_retans" -> "max_retrans"

2018-05-08 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error string Signed-off-by: Colin Ian King --- net/sctp/sm_make_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_make_chunk.c

Re: pull-request: ieee802154 2018-05-08

2018-05-08 Thread Stefan Schmidt
Hello. On 05/08/2018 04:18 PM, David Miller wrote: > From: Stefan Schmidt > Date: Tue, 8 May 2018 10:29:27 +0200 > >> An update from ieee802154 for your *net* tree. >> >> Two fixes for the mcr20a driver, which was being added in the 4.17 merge >> window, >> by Gustavo

Re: [PATCH v6 00/13] firmware_loader changes for v4.18

2018-05-08 Thread Kees Cook
ware loader can use my linux-next > branch 20180508-firmware_loader_for-v4.18-try2 for now. > > 0-day sends its blessings. > > The patches from Mimi's series still require a bit more discussion and > review. The discussion over the EFI firmware fallback mechanism is still > ongo

Re: [RFC bpf-next 00/10] initial control flow support for eBPF verifier

2018-05-08 Thread David Miller
From: Jiong Wang Date: Mon, 7 May 2018 06:22:36 -0400 > This infrastructure comes with some memory usage and execution time cost. > Memory pool based allocation is used to avoid frequently calling of > kmalloc/free. Singly linked list and compact pointer are used to

Re: [PATCH ghak81 RFC V1 2/5] audit: convert sessionid unset to a macro

2018-05-08 Thread Richard Guy Briggs
On 2018-05-04 16:54, Richard Guy Briggs wrote: > Use a macro, "AUDIT_SID_UNSET", to replace each instance of > initialization and comparison to an audit session ID. > > Signed-off-by: Richard Guy Briggs There's a minor issue with this patch, adding a header include to

Re: KASAN: use-after-free Read in work_is_static_object

2018-05-08 Thread Eric Biggers
On Mon, Jan 08, 2018 at 12:58:11PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Mon, Jan 8, 2018 at 12:55 PM, Dmitry Vyukov wrote: > > On Mon, Jan 8, 2018 at 12:43 PM, syzbot > > wrote: > >> Hello, > >> > >>

Re: ICMP redirect and VRF

2018-05-08 Thread David Ahern
On 5/8/18 3:27 PM, Ben Greear wrote: > While debugging some other problem today on a system using ip rules > instead of > VRF, I ran into a case where the remote router was sending back ICMP > redirects. > > That got me thinking...where would these routes get stored in a VRF > scenario? > >

Re: BUG: spinlock bad magic in tun_do_read

2018-05-08 Thread Jason Wang
On 2018年05月09日 10:50, Cong Wang wrote: On Mon, May 7, 2018 at 11:04 PM, Eric Dumazet wrote: On 05/07/2018 10:54 PM, Cong Wang wrote: Yeah, we should return early before hitting this uninitialized ptr ring... Something like: diff --git a/drivers/net/tun.c

Re: BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-08 Thread Eric Biggers
On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=13d5de4780 >

[PATCH net] stmmac: fix reception of 802.1ad Ethernet tagged frames

2018-05-08 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() . This causes

Re: [RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

2018-05-08 Thread 吉藤英明
Hi, 2018-05-08 15:03 GMT+09:00 Andre Naujoks : > On 11.04.2018 13:02, Andre Naujoks wrote: >> Hi. > > Hi again. > > Since it has been a month now, I'd like to send a little "ping" on this > subject. > > Is anything wrong with this? Or was it just bad timing? I'm just

Re: BUG: spinlock bad magic in tun_do_read

2018-05-08 Thread Eric Dumazet
On 05/07/2018 10:54 PM, Cong Wang wrote: > On Mon, May 7, 2018 at 10:27 PM, syzbot > wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:75bc37fefc44 Linux 4.17-rc4 >> git tree: upstream >> console

Re: [RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

2018-05-08 Thread Andre Naujoks
On 11.04.2018 13:02, Andre Naujoks wrote: > Hi. Hi again. Since it has been a month now, I'd like to send a little "ping" on this subject. Is anything wrong with this? Or was it just bad timing? Regards Andre > > I was running into a problem, when trying to join multiple multicast groups >

Re: Failed to clone net-next.git

2018-05-08 Thread David Miller
From: Song Liu Date: Tue, 8 May 2018 17:46:23 + > We are seeing the following error on multiple different systems while > cloning net-next tree. > > $ git clone > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > Cloning into 'net-next'...

Re: [PATCH net-next 0/9] net: dsa: Plug in PHYLINK support

2018-05-08 Thread David Miller
From: Florian Fainelli Date: Sat, 5 May 2018 12:04:16 -0700 > This patch series adds PHYLINK support to DSA which is necessary to > support more complex PHY and pluggable modules setups. The regression Andrew reported with patch #7 is holding up my applying this series.

Re: [PATCH net-next] dt-bindings: dsa: Remove unnecessary #address/#size-cells

2018-05-08 Thread David Miller
From: Fabio Estevam Date: Mon, 7 May 2018 09:17:51 -0300 > From: Fabio Estevam > > If the example binding is used on a real dts file, the following DTC > warning is seen with W=1: > > arch/arm/boot/dts/imx6q-b450v3.dtb: Warning

Re: [PATCH bpf-next v3 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-08 Thread Alexei Starovoitov
On Mon, May 07, 2018 at 11:21:11PM +0100, Mathieu Xhonneux wrote: > I'm not sure what would be the best approach here. These errors appear > when CONFIG_IPV6=m and CONFIG_IPV6_SEG6_LWTUNNEL=y (which is bool and > depends on IPv6, hence it is also modularized in this case), then >

[PATCH bpf] nfp: bpf: allow zero-length capabilities

2018-05-08 Thread Jakub Kicinski
Some BPF capabilities carry no value, they simply indicate feature is present. Our capability parsing loop will exit early if last capability is zero-length because it's looking for more than 8 bytes of data (8B is our TLV header length). Allow the last capability to be zero-length. This bug

Re: [PATCH bpf-next 0/2] nfp: bpf: add programmable RSS support

2018-05-08 Thread Alexei Starovoitov
On Tue, May 08, 2018 at 07:37:05PM -0700, Jakub Kicinski wrote: > Hi! > > This small series adds a feature which extends BPF offload beyond > a pure host processing offload and firmly into the realm of > heterogeneous processing. Allowing offloaded XDP programs to set > the RX queue index opens

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-08 Thread AceLan Kao
Hi, I didn't get any response around one month. I'm still here hoping you can consider accepting the WoL patch. Without that patch, people have no chance to bump into the issue and have no chance to fix it. Moreover, it leads to the dkms package be spreaded around, and it'll become a more

linux-next: manual merge of the net-next tree with the net tree

2018-05-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/tls/tls_main.c between commit: 98f0a39529e5 ("tls: fix use after free in tls_sk_proto_close") from the net tree and commit: f66de3ee2c16 ("net/tls: Split conf to rx + tx") from the net-next tree. I fixed it

Re: [PATCH] selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()

2018-05-08 Thread Paul Moore
On Tue, May 8, 2018 at 2:40 PM, Stephen Smalley wrote: > On 05/08/2018 01:05 PM, Paul Moore wrote: >> On Tue, May 8, 2018 at 10:05 AM, Alexey Kodanev >> wrote: >>> Commit d452930fd3b9 ("selinux: Add SCTP support") breaks compatibility >>> with the

Re: BUG: spinlock bad magic in tun_do_read

2018-05-08 Thread Cong Wang
On Mon, May 7, 2018 at 11:04 PM, Eric Dumazet wrote: > > > On 05/07/2018 10:54 PM, Cong Wang wrote: >> >> Yeah, we should return early before hitting this uninitialized ptr ring... >> Something like: >> >> diff --git a/drivers/net/tun.c b/drivers/net/tun.c >> index

Re: linux-next: manual merge of the bpf-next tree with the s390 tree

2018-05-08 Thread Stephen Rothwell
Hi all, On Tue, 8 May 2018 10:26:38 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the bpf-next tree got a conflict in: > > arch/s390/net/bpf_jit.S > > between commit: > > de5cb6eb514e ("s390: use expoline thunks in the BPF JIT") > > from the s390

Re: [net-next PATCH v3 0/6] UDP GSO Segmentation clean-ups

2018-05-08 Thread David Miller
From: Alexander Duyck Date: Mon, 7 May 2018 13:03:47 -0700 > On Mon, May 7, 2018 at 11:08 AM, Alexander Duyck > wrote: >> This patch set addresses a number of issues I found while sorting out >> enabling UDP GSO Segmentation support for

[PATCH net-next] net: dsa: fix added_by_user switchdev notification

2018-05-08 Thread Vivien Didelot
Commit 161d82de1ff8 ("net: bridge: Notify about !added_by_user FDB entries") causes the below oops when bringing up a slave interface, because dsa_port_fdb_add is still scheduled, but with a NULL address. To fix this, keep the dsa_slave_switchdev_event function agnostic of the notified info

linux-next: build warning after merge of the bpf-next tree

2018-05-08 Thread Stephen Rothwell
Hi all, After merging the bpf-next tree, today's linux-next build (x86_64 allmodconfig) produced this warning: In file included from include/linux/dma-mapping.h:5:0, from include/linux/skbuff.h:34, from include/linux/if_ether.h:23, from

Re: [bpf-next v2 0/9] bpf: Add helper to do FIB lookups

2018-05-08 Thread Daniel Borkmann
On 05/04/2018 04:54 AM, David Ahern wrote: > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a > simple lookup and forward, the

Re: [net-next 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-07

2018-05-08 Thread David Miller
From: Jeff Kirsher Date: Mon, 7 May 2018 07:45:15 -0700 > This series contains updates to fm10k only. Waiting for a respin after patch #2 is updated based upon feedback. Thanks.

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-08 Thread Alexei Starovoitov
On Mon, May 07, 2018 at 06:51:24PM +, Luis R. Rodriguez wrote: > > Notice that _binary_net_bpfilter_bpfilter_umh_start - end > > is placed into .init.rodata section, so it's freed as soon as __init > > function of bpfilter.ko is finished. > > As part of __init the bpfilter.ko does first

Re: [PATCH net-next v10 3/4] netdev: octeon-ethernet: Add Cavium Octeon III support.

2018-05-08 Thread David Miller
From: "Steven J. Hill" Date: Mon, 7 May 2018 12:22:10 -0500 > +static atomic_t request_mgmt_once; > +static atomic_t load_driver_once; > +static atomic_t pki_id; ... > + /* One time request driver module */ > + if (is_mix) { > +

[PATCH bpf-next] bpf: sync tools bpf.h uapi header

2018-05-08 Thread Prashant Bhole
sync the header from include/uapi/linux/bpf.h which was updated to add fib lookup helper function. This fixes selftests/bpf build failure Signed-off-by: Prashant Bhole --- tools/include/uapi/linux/bpf.h | 84 +- 1 file

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Cong Wang
On Tue, May 8, 2018 at 6:29 AM, Jamal Hadi Salim wrote: > Have you considered using skb->prio instead of peeking into the packet > header. > Also have you looked at the dsmark qdisc? > dsmark modifies ds fields, while this one just maps ds fields into different queues.

Re: KASAN: use-after-free Read in ip6_xmit

2018-05-08 Thread Eric Biggers
On Thu, Jan 04, 2018 at 02:58:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 0e08c463db387a2adcb0243b15ab868a73f87807 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH] isdn: eicon: fix a missing-check bug

2018-05-08 Thread Wenwen Wang
Hello Could you please review this patch? We need a confirmation because we are working on an approaching deadline. Thanks! Wenwen On Sat, May 5, 2018 at 2:32 PM, Wenwen Wang wrote: > In divasmain.c, the function divas_write() firstly invokes the function >

pull-request Cavium liquidio firmware v1.7.2

2018-05-08 Thread Felix Manlunas
The following changes since commit 8fc2d4e55685bf73b6f7752383da9067404a74bb: Merge git://git.marvell.com/mwifiex-firmware (2018-05-07 09:09:40 -0400) are available in the git repository at: https://github.com/felix-cavium/linux-firmware.git for-upstreaming-v1.7.2 for you to fetch changes

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-08 Thread Jason Wang
On 2018年05月08日 17:44, Tiwei Bie wrote: On Tue, May 08, 2018 at 05:34:40PM +0800, Jason Wang wrote: On 2018年05月08日 17:16, Tiwei Bie wrote: On Tue, May 08, 2018 at 03:16:53PM +0800, Jason Wang wrote: On 2018年05月08日 14:44, Tiwei Bie wrote: On Tue, May 08, 2018 at 01:40:40PM +0800, Jason Wang

linux-next: manual merge of the net-next tree with the net tree

2018-05-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/net/Makefile between commit: 1751eb42ddb5 ("selftests: net: use TEST_PROGS_EXTENDED") from the net tree and commits: a7b15ab887e5 ("Merge

Re: KASAN: out-of-bounds Read in ip6_xmit

2018-05-08 Thread Eric Biggers
On Sun, Jan 28, 2018 at 11:24:01AM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 6bb46bc57c8e9ce947cc605e555b7204b44d2b10 (Fri Jan 26 16:00:23 2018 +) > Merge branch 'cxgb4-fix-dump-collection-when-firmware-crashed' > > Unfortunately, I don't have any

Re: [PATCH net-next] net: phy: sfp: handle cases where neither BR,min nor BR,max is given

2018-05-08 Thread David Miller
From: Antoine Tenart Date: Fri, 4 May 2018 17:21:03 +0200 > When computing the bitrate using values read from an SFP module EEPROM, > we use the nominal BR plus BR,min and BR,max to determine the > boundaries. But in some cases BR,min and BR,max aren't provided,

Re: [PATCH ghak81 RFC V1 4/5] audit: use inline function to set audit context

2018-05-08 Thread Tobin C. Harding
On Fri, May 04, 2018 at 04:54:37PM -0400, Richard Guy Briggs wrote: > Recognizing that the audit context is an internal audit value, use an > access function to set the audit context pointer for the task > rather than reaching directly into the task struct to set it. > > Signed-off-by: Richard

Re: [PATCH net] r8169: fix powering up RTL8168h

2018-05-08 Thread David Miller
From: Heiner Kallweit Date: Mon, 7 May 2018 21:11:21 +0200 > Since commit a92a08499b1f "r8169: improve runtime pm in general and > suspend unused ports" interfaces w/o link are runtime-suspended after > 10s. On systems where drivers take longer to load this can lead to the

Re: BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-08 Thread Dmitry Vyukov
On Wed, May 9, 2018 at 7:05 AM, Eric Biggers wrote: > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. >> git tree: upstream >>

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-08 Thread Alexei Starovoitov
On Mon, May 07, 2018 at 06:39:31PM +, Luis R. Rodriguez wrote: > > > Are you saying make 'static struct vfsmount *shm_mnt;' > > global and use it here? so no init_tmpfs() necessary? > > I think that can work, but feels that having two > > tmpfs mounts (one for shmem and one for umh) is

Re: BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-08 Thread Eric Biggers
On Wed, May 09, 2018 at 07:23:41AM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Wed, May 9, 2018 at 7:05 AM, Eric Biggers wrote: > > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD

Re: pull-request: ieee802154 2018-05-08

2018-05-08 Thread David Miller
From: Stefan Schmidt Date: Tue, 8 May 2018 21:55:37 +0200 > On 05/08/2018 04:18 PM, David Miller wrote: >> Please submit the -stable fix directly, you can feel free to CC: me. > > Will do when the patch hits Linus git tree. > > I have a quick question on the process

Re: [PATCH net-next 0/9] net: dsa: Plug in PHYLINK support

2018-05-08 Thread Florian Fainelli
Le 05/08/18 à 17:17, David Miller a écrit : > From: Florian Fainelli > Date: Sat, 5 May 2018 12:04:16 -0700 > >> This patch series adds PHYLINK support to DSA which is necessary to >> support more complex PHY and pluggable modules setups. > > The regression Andrew

[net-next 1/1] tipc: clean up removal of binding table items

2018-05-08 Thread Jon Maloy
In commit be47e41d77fb ("tipc: fix use-after-free in tipc_nametbl_stop") we fixed a problem caused by premature release of service range items. That fix is correct, and solved the problem. However, it doesn't address the root of the problem, which is that we don't lookup the tipc_service ->

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Cong Wang
On Tue, May 8, 2018 at 5:59 AM, Michel Machado wrote: >>> Overall it looks good to me, just one thing below: >>> +struct Qdisc_ops gkprio_qdisc_ops __read_mostly = { + .id = "gkprio", + .priv_size = sizeof(struct

[PATCH bpf-next 1/2] bpf: xdp: allow offloads to store into rx_queue_index

2018-05-08 Thread Jakub Kicinski
It's fairly easy for offloaded XDP programs to select the RX queue packets go to. We need a way of expressing this in the software. Allow write to the rx_queue_index field of struct xdp_md for device-bound programs. Skip convert_ctx_access callback entirely for offloads. Signed-off-by: Jakub

[PATCH bpf-next 2/2] nfp: bpf: support setting the RX queue index

2018-05-08 Thread Jakub Kicinski
BPF has access to all internal FW datapath structures. Including the structure containing RX queue selection. With little coordination with the datapath we can let the offloaded BPF select the RX queue. We just need a way to tell the datapath that queue selection has already been done and it

[PATCH bpf-next 0/2] nfp: bpf: add programmable RSS support

2018-05-08 Thread Jakub Kicinski
Hi! This small series adds a feature which extends BPF offload beyond a pure host processing offload and firmly into the realm of heterogeneous processing. Allowing offloaded XDP programs to set the RX queue index opens the door for defining fully programmable RSS/n-tuple filter replacement. In

Re: [PATCH] net: aquantia: Fix an error handling path in 'aq_pci_probe()'

2018-05-08 Thread Igor Russkikh
Hi Christophe, On 08.05.2018 09:39, Christophe JAILLET wrote: > The position of 2 labels should be swapped in order to release resources > in the correct order and avoid leaks. > > kfree(self->aq_hw); > err_ioremap: > free_netdev(ndev); > -err_pci_func: > -

[PATCH net-next 0/4] bnxt_en: Fixes for net-next.

2018-05-08 Thread Michael Chan
This series includes a bug fix for a regression in firmware message polling introduced recently on net-next. There are 3 additional minor fixes for unsupported link speed checking, VF MAC address handling, and setting PHY eeprom length. Michael Chan (3): bnxt_en: Fix firmware message delay

[PATCH net-next 3/4] bnxt_en: Read phy eeprom A2h address only when optical diagnostics is supported.

2018-05-08 Thread Michael Chan
From: Vasundhara Volam For SFP+ modules, 0xA2 page is available only when Diagnostic Monitoring Type [Address A0h, Byte 92] is implemented. Extend bnxt_get_module_info(), to read optical diagnostics support at offset 92(0x5c) and set eeprom_len length to

[PATCH net-next 2/4] bnxt_en: Check unsupported speeds in bnxt_update_link() on PF only.

2018-05-08 Thread Michael Chan
Only non-NPAR PFs need to actively check and manage unsupported link speeds. NPAR functions and VFs do not control the link speed and should skip the unsupported speed detection logic, to avoid warning messages from firmware rejecting the unsupported firmware calls. Signed-off-by: Michael Chan

[PATCH net-next 1/4] bnxt_en: Fix firmware message delay loop regression.

2018-05-08 Thread Michael Chan
A recent change to reduce delay granularity waiting for firmware reponse has caused a regression. With a tighter delay loop, the driver may see the beginning part of the response faster. The original 5 usec delay to wait for the rest of the message is not long enough and some messages are

[PATCH net-next 4/4] bnxt_en: Always forward VF MAC address to the PF.

2018-05-08 Thread Michael Chan
The current code already forwards the VF MAC address to the PF, except in one case. If the VF driver gets a valid MAC address from the firmware during probe time, it will not forward the MAC address to the PF, incorrectly assuming that the PF already knows the MAC address. This causes "ip link

Re: [PATCH net] stmmac: fix reception of 802.1ad Ethernet tagged frames

2018-05-08 Thread Toshiaki Makita
On 2018/05/08 16:11, Elad Nachman wrote: > Currently running: > ip link add link eth0 eth0.100 type vlan proto 802.1ad id 100 > > On eth0=stmmac succeeds, but the end result is that the vlan device gets > proto 802.1q instead of proto 802.1ad and drops the received packet. Without > the patch

INFO: rcu detected stall in sctp_generate_heartbeat_event

2018-05-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:90278871d4b0 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=119a723780 kernel config: https://syzkaller.appspot.com/x/.config?x=aea320d3af5ef99d

Re: linux-next: manual merge of the bpf-next tree with the s390 tree

2018-05-08 Thread Daniel Borkmann
On 05/08/2018 02:26 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the bpf-next tree got a conflict in: > > arch/s390/net/bpf_jit.S > > between commit: > > de5cb6eb514e ("s390: use expoline thunks in the BPF JIT") > > from the s390 tree and commit: > >

RE: [PATCH v2] net: dsa: drop some VLAs in switch.c

2018-05-08 Thread David Laight
From: Salvatore Mesoraca > Sent: 07 May 2018 20:03 ... > This optimization will save us an allocation when number of ports is > less than 32 or 64 (depending on arch). > IMHO it's useful, if you consider that, right now, DSA works only with > 12-ports switches. Why not just error out if the

Re: [PATCH net-next] net:sched: add gkprio scheduler

2018-05-08 Thread Nishanth Devarajan
On Mon, May 07, 2018 at 10:24:51PM -0700, Cong Wang wrote: > On Mon, May 7, 2018 at 2:36 AM, Nishanth Devarajan wrote: > > net/sched: add gkprio scheduler > > > > Gkprio (Gatekeeper Priority Queue) is a queueing discipline that prioritizes > > IPv4 and IPv6 packets accordingly

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-08 Thread Jia-Ju Bai
On 2018/5/8 13:04, Eric Dumazet wrote: On 05/07/2018 07:16 PM, Jia-Ju Bai wrote: Yes, ">stats" will not change, because it is a fixed address. But the field data in "dev->stats" is changed (rx_frame_errors, rx_crc_errors and rx_missed_errors). So if the driver returns ">stats" without lock

Re: Build regressions/improvements in v4.17-rc4

2018-05-08 Thread Geert Uytterhoeven
On Tue, May 8, 2018 at 9:02 AM, Geert Uytterhoeven wrote: > JFYI, when comparing v4.17-rc4[1] to v4.17-rc3[3], the summaries are: > - build errors: +1/-4 + /kisskb/src/include/linux/mlx5/driver.h: error: 'struct irq_desc' has no member named 'affinity_hint': => 1299:13

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-08 Thread Jason Wang
On 2018年05月08日 14:44, Tiwei Bie wrote: On Tue, May 08, 2018 at 01:40:40PM +0800, Jason Wang wrote: On 2018年05月08日 11:05, Jason Wang wrote: Because in virtqueue_enable_cb_delayed(), we may set an event_off which is bigger than new and both of them have wrapped. And in this case, although new

[PATCH 6/7] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-05-08 Thread Marc Kleine-Budde
From: Sergei Shtylyov Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD bindings. Signed-off-by: Sergei Shtylyov Reviewed-by: Ramesh Shanmugasundaram Reviewed-by:

pull-request: can 2018-05-08

2018-05-08 Thread Marc Kleine-Budde
2c5d5b13c6eb79f5677e206b8aad59b3a2097f60: llc: better deal with too small mtu (2018-05-08 00:11:40 -0400) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.17-20180508 for you to fetch changes up

Re: [RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-08 Thread Andrea Greco
On 05/07/2018 04:55 AM, Tobin C. Harding wrote: On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote: From: Andrea Greco Hi Andrea, Here are some (mostly stylistic) suggestions to help you get your driver merged. Add support for com20022I/com20020, memory mapped

[PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

2018-05-08 Thread Christophe JAILLET
If the 2nd memory allocation of the loop fails, we must undo the memory allocation done so far. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2

Re: [PATCH v2] net: dsa: drop some VLAs in switch.c

2018-05-08 Thread Salvatore Mesoraca
2018-05-07 21:26 GMT+02:00 Andrew Lunn : >> >> +++ b/include/net/dsa.h >> >> @@ -256,6 +256,9 @@ struct dsa_switch { >> >> /* Number of switch port queues */ >> >> unsigned intnum_tx_queues; >> >> >> >> + unsigned long *bitmap; >> >> +

[PATCH net-next] drivers: net: davinci_mdio: prevent sprious timeout

2018-05-08 Thread Sekhar Nori
A well timed kernel preemption in the time_after() loop in wait_for_idle() can result in a spurious timeout error to be returned. Fix it by checking for status of hardware before returning timeout error. Signed-off-by: Sekhar Nori --- The issue has not been personally observed

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-05-08 Thread Kevin Easton
On Mon, May 07, 2018 at 04:03:25PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > > The struct vhost_msg within struct vhost_msg_node is copied to userspace, > > so it should be allocated with kzalloc() to ensure all structure padding > > is

pull-request: ieee802154 2018-05-08

2018-05-08 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Two fixes for the mcr20a driver, which was being added in the 4.17 merge window, by Gustavo and myself. The atusb driver got a change to GFP_KERNEL where no GFP_ATOMIC is needed by Jia-Ju. The last and most important fix is from Alex to

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-08 Thread Tiwei Bie
On Tue, May 08, 2018 at 05:34:40PM +0800, Jason Wang wrote: > On 2018年05月08日 17:16, Tiwei Bie wrote: > > On Tue, May 08, 2018 at 03:16:53PM +0800, Jason Wang wrote: > > > On 2018年05月08日 14:44, Tiwei Bie wrote: > > > > On Tue, May 08, 2018 at 01:40:40PM +0800, Jason Wang wrote: > > > > > On

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-08 Thread kbuild test robot
Hi Sridhar, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Sridhar-Samudrala/Enable-virtio_net-to-act-as-a-standby-for-a-passthru-device/20180508-123531 reproduce: # apt-get install sparse

Re: [PATCH net] stmmac: fix reception of 802.1ad Ethernet tagged frames

2018-05-08 Thread Toshiaki Makita
On 2018/05/08 15:01, Elad Nachman wrote: > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with 802.1Q > protocol, > and assigns ETH_P_8021Q to the skb by hard-coding the

Re: [PATCH net] stmmac: fix reception of 802.1ad Ethernet tagged frames

2018-05-08 Thread Elad Nachman
Currently running: ip link add link eth0 eth0.100 type vlan proto 802.1ad id 100 On eth0=stmmac succeeds, but the end result is that the vlan device gets proto 802.1q instead of proto 802.1ad and drops the received packet. Without the patch packets gets dropped for a seemingly "correct" 802.1ad

Re: RTL8723BE performance regression

2018-05-08 Thread Pkshih
On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: > On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: > > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: > >> > >> > -Original Message- > >> > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > >> >

Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

2018-05-08 Thread Andrea Greco
On 05/07/2018 04:55 AM, Tobin C. Harding wrote: On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote: From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco ---

[PATCH] net: aquantia: Fix an error handling path in 'aq_pci_probe()'

2018-05-08 Thread Christophe JAILLET
The position of 2 labels should be swapped in order to release resources in the correct order and avoid leaks. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Christophe JAILLET --- The order of 'pci_release_regions()' and

[PATCH 5/7] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

2018-05-08 Thread Marc Kleine-Budde
From: Geert Uytterhoeven R8A7796 is R-Car M3-W. Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman Signed-off-by: Marc Kleine-Budde ---

[PATCH 2/7] can: flexcan: fix endianess detection

2018-05-08 Thread Marc Kleine-Budde
From: Uwe Kleine-König In commit 88462d2a7830 ("can: flexcan: Remodel FlexCAN register r/w APIs for big endian FlexCAN controllers.") the following logic was implemented: if the dt property "big-endian" is given or the device is compatible to

[PATCH 1/7] can: dev: increase bus-off message severity

2018-05-08 Thread Marc Kleine-Budde
From: Jakob Unterwurzacher bus-off is usually caused by hardware malfunction or configuration error (baud rate mismatch) and causes a complete loss of communication. Increase the "bus-off" message's severity from netdev_dbg() to netdev_info() to make

[PATCH 4/7] can: kvaser_usb: Increase correct stats counter in kvaser_usb_rx_can_msg()

2018-05-08 Thread Marc Kleine-Budde
From: Jimmy Assarsson Increase rx_dropped, if alloc_can_skb() fails, not tx_dropped. Signed-off-by: Jimmy Assarsson Cc: linux-stable Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/kvaser_usb.c | 2 +-

  1   2   3   >