aio poll and a new in-kernel poll API V12

2018-05-22 Thread Christoph Hellwig
Hi all, this series adds support for the IOCB_CMD_POLL operation to poll for the readyness of file descriptors using the aio subsystem. The API is based on patches that existed in RHAS2.1 and RHEL3, which means it already is supported by libaio. To implement the poll support efficiently new

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

2018-05-22 Thread Jason Wang
On 2018年05月22日 00:39, Jesse Brandeburg wrote: On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: Signed-off-by: Jason Wang --- drivers/vhost/net.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c

Re: [PATCH net-next v11 3/5] net: Introduce net_failover driver

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 04:06:19AM CEST, sridhar.samudr...@intel.com wrote: >The net_failover driver provides an automated failover mechanism via APIs >to create and destroy a failover master netdev and mananges a primary and >standby slave netdevs that get registered via the generic failover

Re: [PATCH bpf-next 0/8] AF_XDP follow-up patches, uapi and cleanups

2018-05-22 Thread Daniel Borkmann
On 05/22/2018 09:34 AM, Björn Töpel wrote: > From: Björn Töpel > > This the second follow-up set. The first four patches are uapi > changes: > > * Removing rebind support > * Getting rid of structure hole > * Removing explicit cache line alignment > * Stricter bind checks

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: >Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: >>Use the registration/notification framework supported by the generic >>failover infrastructure. >> >>Signed-off-by: Sridhar Samudrala

[PATCH net-next v2 1/3] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-22 Thread Antoine Tenart
In case no Tx disable pin is available the SFP modules will always be emitting. This could be an issue when using modules using laser as their light source as we would have no way to disable it when the fiber is removed. This patch adds a warning when registering an SFP cage which do not have its

[PATCH net-next v2 3/3] Documentation/bindings: net: the sfp i2c-bus property is now mandatory

2018-05-22 Thread Antoine Tenart
The i2c-bus property for sfp modules was made mandatory. Update the documentation to keep it in sync with the driver's behaviour. Signed-off-by: Antoine Tenart --- Documentation/devicetree/bindings/net/sff,sfp.txt | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH net-next v2 2/3] net: phy: sfp: make the i2c-bus dt property mandatory

2018-05-22 Thread Antoine Tenart
This patch makes the i2c-bus property mandatory when using a device tree. If the sfp i2c bus isn't described it's impossible to guess the protocol to use for a given module, and the sfp module would then not work in most cases. Signed-off-by: Antoine Tenart ---

Re: [net-next 2/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask

2018-05-22 Thread Or Gerlitz
On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed wrote: > From: Huy Nguyen > > Add pbmc and pptb in the port_access_reg_cap_mask. These two > bits determine if device supports receive buffer configuration. > > Signed-off-by: Huy Nguyen

[PATCH net-next v2 0/3] net: sfp: small improvements

2018-05-22 Thread Antoine Tenart
Hi Russell, David, A small series of patches improving the SFP support by adding a warning when no Tx disable pin is available, and making the i2c-bus property mandatory. Thanks! Antoine Since v1: - Removed the patch fixing the sfp driver when no i2c bus was described. - Made two new

[PATCH net-next v2 0/7] Add support for QCA8334 switch

2018-05-22 Thread Michal Vokáč
This series basically adds support for a QCA8334 ethernet switch to the qca8k driver. It is a four-port variant of the already supported seven port QCA8337. Register map is the same for the whole familly and all chips have the same device ID. Major part of this series enhances the CPU port

[PATCH net-next v2 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth

2018-05-22 Thread Michal Vokáč
By default autonegotiation is enabled to configure MAC on all ports. For the CPU port autonegotiation can not be used so we need to set some sensible defaults manually. This patch forces the default setting of the CPU port to 1000Mbps/full duplex which is the chip maximum capability. Also

[PATCH net-next v2 2/7] net: dsa: qca8k: Add support for QCA8334 switch

2018-05-22 Thread Michal Vokáč
Add support for the four-port variant of the Qualcomm QCA833x switch. Signed-off-by: Michal Vokáč --- Changes in v2: - Add commit message. drivers/net/dsa/qca8k.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c

[PATCH net-next v2 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

2018-05-22 Thread Michal Vokáč
When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn

[PATCH net-next v2 7/7] net: dsa: qca8k: Remove redundant parentheses

2018-05-22 Thread Michal Vokáč
Fix warning reported by checkpatch. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v2: - Fix typo in subject. - Add "Reviewed-by" tags from Andrew and Florian.

[PATCH 30/31] timerfd: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/timerfd.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fs/timerfd.c b/fs/timerfd.c index cdad49da3ff7..d84a2bee4f82 100644 --- a/fs/timerfd.c +++ b/fs/timerfd.c @@ -226,21 +226,20 @@ static int

[PATCH 31/31] random: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
The big change is that random_read_wait and random_write_wait are merged into a single waitqueue that uses keyed wakeups. Because wait_event_* doesn't know about that this will lead to occassional spurious wakeups in _random_read and add_hwgenerator_randomness, but wait_event_* is designed to

[PATCH 28/31] pipe: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/pipe.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 39d6f431da83..bb0840e234f3 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -509,19 +509,22 @@ static long

[PATCH 02/31] fs: cleanup do_pollfd

2018-05-22 Thread Christoph Hellwig
Use straightline code with failure handling gotos instead of a lot of nested conditionals. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Darrick J. Wong --- fs/select.c | 48

[PATCH 04/31] fs: add new vfs_poll and file_can_poll helpers

2018-05-22 Thread Christoph Hellwig
These abstract out calls to the poll method in preparation for changes in how we poll. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Darrick J. Wong ---

[PATCH 03/31] fs: update documentation to mention __poll_t and match the code

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Reviewed-by: Greg Kroah-Hartman --- Documentation/filesystems/Locking | 2 +- Documentation/filesystems/vfs.txt | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 01/31] fs: unexport poll_schedule_timeout

2018-05-22 Thread Christoph Hellwig
No users outside of select.c. Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman Reviewed-by: Darrick J. Wong --- fs/select.c | 3 +-- include/linux/poll.h | 2 -- 2 files changed, 1 insertion(+), 4

[PATCH 06/31] aio: simplify KIOCB_KEY handling

2018-05-22 Thread Christoph Hellwig
No need to pass the key field to lookup_iocb to compare it with KIOCB_KEY, as we can do that right after retrieving it from userspace. Also move the KIOCB_KEY definition to aio.c as it is an internal value not used by any other place in the kernel. Signed-off-by: Christoph Hellwig

[PATCH 05/31] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-05-22 Thread Christoph Hellwig
->get_poll_head returns the waitqueue that the poll operation is going to sleep on. Note that this means we can only use a single waitqueue for the poll, unlike some current drivers that use two waitqueues for different events. But now that we have keyed wakeups and heavily use those for poll

Re: [RFC PATCH net-next 04/12] vhost_net: split out datacopy logic

2018-05-22 Thread Jason Wang
On 2018年05月22日 00:46, Jesse Brandeburg wrote: On Mon, 21 May 2018 17:04:25 +0800 Jason wrote: Instead of mixing zerocopy and datacopy logics, this patch tries to split datacopy logic out. This results for a more compact code and specific optimization could be done on top more easily.

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

2018-05-22 Thread Jason Wang
On 2018年05月22日 00:56, Jesse Brandeburg wrote: On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: This patch implement build XDP buffers in vhost_net. The idea is do userspace copy in vhost_net and build XDP buff based on the page. Vhost_net can then submit one or an array of XDP buffs to

[PATCH 07/31] aio: simplify cancellation

2018-05-22 Thread Christoph Hellwig
With the current aio code there is no need for the magic KIOCB_CANCELLED value, as a cancelation just kicks the driver to queue the completion ASAP, with all actual completion handling done in another thread. Given that both the completion path and cancelation take the context lock there is no

[PATCH 10/31] net: refactor socket_poll

2018-05-22 Thread Christoph Hellwig
Factor out two busy poll related helpers for late reuse, and remove a command that isn't very helpful, especially with the __poll_t annotations in place. Signed-off-by: Christoph Hellwig --- include/net/busy_poll.h | 15 +++ net/socket.c| 21

[PATCH 09/31] aio: try to complete poll iocbs without context switch

2018-05-22 Thread Christoph Hellwig
If we can acquire ctx_lock without spinning we can just remove our iocb from the active_reqs list, and thus complete the iocbs from the wakeup context. Signed-off-by: Christoph Hellwig --- fs/aio.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff

[PATCH 08/31] aio: implement IOCB_CMD_POLL

2018-05-22 Thread Christoph Hellwig
Simple one-shot poll through the io_submit() interface. To poll for a file descriptor the application should submit an iocb of type IOCB_CMD_POLL. It will poll the fd for the events specified in the the first 32 bits of the aio_buf field of the iocb. Unlike poll or epoll without EPOLLONESHOT

[PATCH 12/31] net: remove sock_no_poll

2018-05-22 Thread Christoph Hellwig
Now that sock_poll handles a NULL ->poll or ->poll_mask there is no need for a stub. Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 1 - crypto/algif_hash.c | 2 -- crypto/algif_rng.c | 1 - drivers/isdn/mISDN/socket.c | 1 -

Re: [PATCH bpf v2 6/6] bpf: fix JITed dump for multi-function programs via syscall

2018-05-22 Thread Daniel Borkmann
On 05/21/2018 09:42 PM, Sandipan Das wrote: > On 05/18/2018 09:21 PM, Daniel Borkmann wrote: >> On 05/18/2018 02:50 PM, Sandipan Das wrote: >>> Currently, for multi-function programs, we cannot get the JITed >>> instructions using the bpf system call's BPF_OBJ_GET_INFO_BY_FD >>> command. Because

[PATCH 11/31] net: add support for ->poll_mask in proto_ops

2018-05-22 Thread Christoph Hellwig
The socket file operations still implement ->poll until all protocols are switched over. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 1 + net/socket.c| 48 - 2 files changed, 44 insertions(+), 5 deletions(-) diff

[PATCH net] vhost: synchronize IOTLB message with dev cleanup

2018-05-22 Thread Jason Wang
DaeRyong Jeong reports a race between vhost_dev_cleanup() and vhost_process_iotlb_msg(): Thread interleaving: CPU0 (vhost_process_iotlb_msg) CPU1 (vhost_dev_cleanup) (In the case of both VHOST_IOTLB_UPDATE and VHOST_IOTLB_INVALIDATE) =

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

2018-05-22 Thread Jason Wang
On 2018年05月22日 00:29, Jesse Brandeburg wrote: On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: Signed-off-by: Jason Wang --- drivers/vhost/net.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c

Re: [PATCH net] sctp: fix the issue that flags are ignored when using kernel_connect

2018-05-22 Thread Michal Kubecek
On Sun, May 20, 2018 at 04:39:10PM +0800, Xin Long wrote: > Now sctp uses inet_dgram_connect as its proto_ops .connect, and the flags > param can't be passed into its proto .connect where this flags is really > needed. > > sctp works around it by getting flags from socket file in __sctp_connect.

Re: [PATCH v2 net] stmmac: strip vlan tag on reception only for 8021q tagged frames

2018-05-22 Thread Jose Abreu
On 21-05-2018 17:42, Florian Fainelli wrote: > On 05/21/2018 08:48 AM, David Miller wrote: >> From: David Miller >> Date: Thu, 17 May 2018 12:43:56 -0400 (EDT) >> >>> Giuseppe and Alexandre, please review this patch. >> If nobody thinks this patch is important enough to

Re: [PATCH v2 bpf-next 0/3] bpf: Add MTU check to fib lookup helper

2018-05-22 Thread Daniel Borkmann
On 05/21/2018 06:08 PM, dsah...@kernel.org wrote: > From: David Ahern > > Packets that exceed the egress MTU can not be forwarded in the fast path. > Add IPv4 and IPv6 MTU helpers that take a FIB lookup result (versus the > typical dst path) and add the calls to

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: >Use the registration/notification framework supported by the generic >failover infrastructure. > >Signed-off-by: Sridhar Samudrala In previous patchset versions, the common code did

Re: [RFC feedback] AF_XDP and non-Intel hardware

2018-05-22 Thread Luke Gorrie
On 21 May 2018 at 20:55, Björn Töpel wrote: > > 2018-05-21 14:34 GMT+02:00 Mykyta Iziumtsev : > > Hi Björn and Magnus, > > > > (This thread is a follow up to private dialogue. The intention is to > > let community know that AF_XDP can be

[PATCH net-next v2 5/7] net: dsa: qca8k: Allow overwriting CPU port setting

2018-05-22 Thread Michal Vokáč
Implement adjust_link function that allows to overwrite default CPU port setting using fixed-link device tree subnode. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v2: - Add

[PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

2018-05-22 Thread Michal Vokáč
Add support for the four-port variant of the Qualcomm QCA833x switch. The CPU port default link settings can be reconfigured using a fixed-link sub-node. Signed-off-by: Michal Vokáč --- Changes in v2: - Add commit message and document fixed-link binding.

[PATCH net-next v2 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX

2018-05-22 Thread Michal Vokáč
Replace the GPLv2 license boilerplate with the SPDX license identifier. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- Changes in v2: - Add commit message. - Add "Reviewed-by" tags from

[PATCH 27/31] crypto: af_alg: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 13 +++-- crypto/algif_aead.c | 4 ++-- crypto/algif_skcipher.c | 4 ++-- include/crypto/if_alg.h | 3 +-- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/crypto/af_alg.c b/crypto/af_alg.c

[PATCH 23/31] net/nfc: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/nfc/llcp_sock.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index ea0c0c6f1874..ab5bb14b49af 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -548,16

[PATCH 29/31] eventfd: switch to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/eventfd.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/eventfd.c b/fs/eventfd.c index 08d3bd602f73..61c9514da5e9 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -101,14 +101,20 @@ static int

[PATCH 26/31] net/rxrpc: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/rxrpc/af_rxrpc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c index 9a2c8e7c000e..6b170f2e47f2 100644 --- a/net/rxrpc/af_rxrpc.c +++ b/net/rxrpc/af_rxrpc.c @@

[PATCH 25/31] net/iucv: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/iucv/af_iucv.h | 2 -- net/iucv/af_iucv.c | 7 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/net/iucv/af_iucv.h b/include/net/iucv/af_iucv.h index f4c21b5a1242..b0eaeb02d46d 100644 ---

[PATCH 24/31] net/phonet: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/phonet/socket.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/phonet/socket.c b/net/phonet/socket.c index 9ecf02def928..ea2bfc3aafb9 100644 --- a/net/phonet/socket.c +++ b/net/phonet/socket.c @@ -340,15

[PATCH 19/31] net/tipc: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/tipc/socket.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 252a52ae0893..58549338582a 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -692,10 +692,9

[PATCH 22/31] net/caif: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/caif/caif_socket.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index a6fb1b3bcad9..c7991867d622 100644 --- a/net/caif/caif_socket.c +++

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

2018-05-22 Thread Jason Wang
On 2018年05月22日 00:24, Jesse Brandeburg wrote: Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: Signed-off-by: Jason Wang --- drivers/vhost/net.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff

netdev 0x12 conference update

2018-05-22 Thread Jamal Hadi Salim
Folks, This is a small update to the community on the Netdev 0x12 conference (July 11-13, 2018 in Montreal, Canada, https://www.netdevconf.org/0x12). Early registration fees (20% off) are still in effect until June 1st. To Register: https://www.netdevconf.org/0x12/registration.html Our

Re: [PATCH net-next 0/2] net: sfp: small improvements

2018-05-22 Thread Antoine Tenart
Hi David, On Mon, May 21, 2018 at 11:51:15AM -0400, David Miller wrote: > From: Antoine Tenart > Date: Thu, 17 May 2018 10:29:05 +0200 > > > This series was part of the mvpp2 phylink one but as we reworked it to > > use fixed-link on the DB boards, the SFP commits

Re: [net-next 2/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask

2018-05-22 Thread Or Gerlitz
On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz wrote: > On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed wrote: >> From: Huy Nguyen >> >> Add pbmc and pptb in the port_access_reg_cap_mask. These two >> bits determine if device supports

[PATCH 15/31] net: convert datagram_poll users tp ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Greg Kroah-Hartman --- drivers/isdn/mISDN/socket.c | 2 +- drivers/net/ppp/pppoe.c | 2 +- drivers/staging/ipx/af_ipx.c | 2 +- include/linux/skbuff.h | 3 +-- include/net/udp.h|

[PATCH 13/31] net/tcp: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/tcp.h | 3 +-- net/ipv4/af_inet.c | 2 +- net/ipv4/tcp.c | 23 ++- net/ipv6/af_inet6.c | 2 +- 4 files changed, 9 insertions(+), 21 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

[PATCH 14/31] net/unix: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/unix/af_unix.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 68bb70a62afe..1a9cdad4ab82 100644 --- a/net/unix/af_unix.c +++

Re: [PATCH net-next] sctp: add support for SCTP_REUSE_PORT sockopt

2018-05-22 Thread Neil Horman
On Tue, May 22, 2018 at 03:07:57PM +0800, Xin Long wrote: > On Mon, May 21, 2018 at 9:48 PM, Neil Horman wrote: > > On Mon, May 21, 2018 at 02:16:56PM +0200, Michael Tuexen wrote: > >> > On 21. May 2018, at 13:39, Neil Horman wrote: > >> > > >> > On

Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

2018-05-22 Thread Colin Ian King
On 22/05/18 16:21, Tariq Toukan wrote: > > > On 22/05/2018 11:37 AM, Colin King wrote: >> From: Colin Ian King >> >> Trivial fix to spelling mistake in mlx4_dbg debug message >> >> Signed-off-by: Colin Ian King >> --- >>  

[PATCH net-next v2 1/2] udp: exclude gso from xfrm paths

2018-05-22 Thread Willem de Bruijn
From: Willem de Bruijn UDP GSO delays final datagram construction to the GSO layer. This conflicts with protocol transformations. Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT") CC: Michal Kubecek Signed-off-by: Willem de Bruijn

[PATCH net-next v2 2/2] gso: limit udp gso to egress-only virtual devices

2018-05-22 Thread Willem de Bruijn
From: Willem de Bruijn Until the udp receive stack supports large packets (UDP GRO), GSO packets must not loop from the egress to the ingress path. Revert the change that added NETIF_F_GSO_UDP_L4 to various virtual devices through NETIF_F_GSO_ENCAP_ALL as this included

[PATCH net-next v2 0/2] udp gso fixes

2018-05-22 Thread Willem de Bruijn
From: Willem de Bruijn A few small fixes: - disallow segmentation with XFRM - do not leak gso packets into the ingress path Changes v1 -> v2 - fix build failure in team.c - drop scatter-gather fix: this is now fixed by commit 113f99c33585 ("net: test tailroom

Re: [net-next 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-22 Thread Huy Nguyen
On 5/22/2018 12:20 AM, Jakub Kicinski wrote: On Mon, 21 May 2018 14:04:57 -0700, Saeed Mahameed wrote: From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow user change the NIC's buffer configuration such as priority to buffer mapping and buffer size of

Re: Shepherd request (P83): Multipath TCP: Present Use Cases and an Upstream Future

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: > >On 5/22/2018 2:08 AM, Jiri Pirko wrote: >> Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: >> > Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: >> > > Use the

Re: [PATCH net-next] net: stmmac: Add PPS and Flexible PPS support

2018-05-22 Thread Jose Abreu
On 22-05-2018 16:14, Andrew Lunn wrote: > On Tue, May 22, 2018 at 01:58:40PM +0100, Jose Abreu wrote: >> This adds support for PPS output and Flexible PPS (which is equivalent >> to per_out output of PTP subsystem). > You forgot to Cc: the PTP maintainer, Richard Cochran >

Re: [PATCH net-next 08/12] amd-xgbe: Add ethtool show/set channels support

2018-05-22 Thread Tom Lendacky
On 5/22/2018 8:29 AM, Edward Cree wrote: > On 22/05/18 14:24, Tom Lendacky wrote: >> The amd-xgbe driver is not designed to allocate separate IRQs for Rx and >> Tx. In general, there is one IRQ for a channel of which Tx and Rx are >> shared. You can have more Tx channels than Rx channels or

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 05:32:30PM CEST, m...@redhat.com wrote: >On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: >> Tue, May 22, 2018 at 03:39:33PM CEST, m...@redhat.com wrote: >> >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: >> >> Tue, May 22, 2018 at 03:17:37PM CEST,

Re: [PATCH] net: vxge: fix spelling mistake in macro VXGE_HW_ERR_PRIVILAGED_OPEARATION

2018-05-22 Thread Edward Cree
On 22/05/18 16:36, Colin King wrote: > From: Colin Ian King > > Rename VXGE_HW_ERR_PRIVILAGED_OPEARATION to VXGE_HW_ERR_PRIVILAGED_OPERATION > to fix spelling mistake. > > Signed-off-by: Colin Ian King "Privilaged" doesn't look right either,

Re: Shepherd request (P83): Multipath TCP: Present Use Cases and an Upstream Future

2018-05-22 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: > > > >On 5/22/2018 2:08 AM, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: > >> > Tue, May 22, 2018 at 04:06:18AM CEST,

Re: [PATCH v2] packet: track ring entry use using a shadow ring to prevent RX ring overrun

2018-05-22 Thread Willem de Bruijn
On Tue, May 22, 2018 at 10:12 AM, Jon Rosen (jrosen) wrote: > On Monday, May 21, 2018 2:17 PM, Jon Rosen (jrosen) wrote: >> On Monday, May 21, 2018 1:07 PM, Willem de Bruijn >> wrote: >>> On Mon, May 21, 2018 at 8:57 AM, Jon

Re: [PATCH net-next 08/12] amd-xgbe: Add ethtool show/set channels support

2018-05-22 Thread Edward Cree
On 22/05/18 14:24, Tom Lendacky wrote: > The amd-xgbe driver is not designed to allocate separate IRQs for Rx and > Tx. In general, there is one IRQ for a channel of which Tx and Rx are > shared. You can have more Tx channels than Rx channels or vice-versa, but > the min() of those numbers will

[PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-22 Thread Toke Høiland-Jørgensen
When CAKE is deployed on a gateway that also performs NAT (which is a common deployment mode), the host fairness mechanism cannot distinguish internal hosts from each other, and so fails to work correctly. To fix this, we add an optional NAT awareness mode, which will query the kernel conntrack

[PATCH net-next v15 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-22 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth

pull-request: wireless-drivers 2018-05-22

2018-05-22 Thread Kalle Valo
Hi Dave, here's a pull request to net tree for 4.17. Please let me know if you have any problems. Kalle The following changes since commit a8d7aa17bbc970971ccdf71988ea19230ab368b1: dccp: fix tasklet usage (2018-05-03 15:14:57 -0400) are available in the git repository at:

Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

2018-05-22 Thread Andrea Greco
On 05/18/2018 07:51 PM, David Miller wrote: From: Andrea Greco Date: Fri, 18 May 2018 14:18:41 +0200 In com20020.c found this: /* FIXME: do this some other way! */ if (!dev->dev_addr[0]) dev->dev_addr[0] = arcnet_inb(ioaddr, 8); NODE-ID, must be univoque,

[PATCH 18/31] net/vmw_vsock: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/vmw_vsock/af_vsock.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index c1076c19b858..bb5d5fa68c35 100644 --- a/net/vmw_vsock/af_vsock.c +++

[PATCH 16/31] net/dccp: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/dccp/dccp.h | 3 +-- net/dccp/ipv4.c | 2 +- net/dccp/ipv6.c | 2 +- net/dccp/proto.c | 13 ++--- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index f91e3816806b..0ea2ee56ac1b

[PATCH 17/31] net/atm: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/atm/common.c | 11 +++ net/atm/common.h | 2 +- net/atm/pvc.c| 2 +- net/atm/svc.c| 2 +- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/net/atm/common.c b/net/atm/common.c index fc78a0508ae1..1f2af59935db

[PATCH 20/31] net/sctp: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/sctp/sctp.h | 3 +-- net/sctp/ipv6.c | 2 +- net/sctp/protocol.c | 2 +- net/sctp/socket.c | 4 +--- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h

[PATCH 21/31] net/bluetooth: convert to ->poll_mask

2018-05-22 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/bluetooth/bluetooth.h | 2 +- net/bluetooth/af_bluetooth.c | 7 ++- net/bluetooth/l2cap_sock.c| 2 +- net/bluetooth/rfcomm/sock.c | 2 +- net/bluetooth/sco.c | 2 +- 5 files changed, 6

Re: [RFC feedback] AF_XDP and non-Intel hardware

2018-05-22 Thread Björn Töpel
2018-05-22 9:45 GMT+02:00 Mykyta Iziumtsev : > On 21 May 2018 at 20:55, Björn Töpel wrote: >> 2018-05-21 14:34 GMT+02:00 Mykyta Iziumtsev : >>> Hi Björn and Magnus, >>> >>> (This thread is a follow up to private

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Jiri Pirko
Tue, May 22, 2018 at 03:39:33PM CEST, m...@redhat.com wrote: >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: >> Tue, May 22, 2018 at 03:17:37PM CEST, m...@redhat.com wrote: >> >On Tue, May 22, 2018 at 03:14:22PM +0200, Jiri Pirko wrote: >> >> Tue, May 22, 2018 at 03:12:40PM CEST,

Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

2018-05-22 Thread Tariq Toukan
On 22/05/2018 6:23 PM, Colin Ian King wrote: On 22/05/18 16:21, Tariq Toukan wrote: On 22/05/2018 11:37 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Samudrala, Sridhar
On 5/22/2018 2:08 AM, Jiri Pirko wrote: Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 05:13:43PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 03:39:33PM CEST, m...@redhat.com wrote: > >On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:17:37PM CEST, m...@redhat.com wrote: > >> >On Tue, May 22, 2018 at 03:14:22PM

Re: [PATCH v3] mlx4_core: allocate ICM memory in page size chunks

2018-05-22 Thread Tariq Toukan
On 18/05/2018 12:45 AM, Qing Huang wrote: On 5/17/2018 2:14 PM, Eric Dumazet wrote: On 05/17/2018 01:53 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter

[PATCH] net: vxge: fix spelling mistake in macro VXGE_HW_ERR_PRIVILAGED_OPEARATION

2018-05-22 Thread Colin King
From: Colin Ian King Rename VXGE_HW_ERR_PRIVILAGED_OPEARATION to VXGE_HW_ERR_PRIVILAGED_OPERATION to fix spelling mistake. Signed-off-by: Colin Ian King --- drivers/net/ethernet/neterion/vxge/vxge-config.c | 12 ++--

Re: [PATCH v2] packet: track ring entry use using a shadow ring to prevent RX ring overrun

2018-05-22 Thread Willem de Bruijn
>>> I think the bigger issues as you've pointed out are the cost of >>> the additional spin lock and should the additional state be >>> stored in-band (fewer cache lines) or out-of band (less risk of >>> breaking due to unpredictable application behavior). >> >> We don't need the spinlock if

[PATCH][V2] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface" and rephrase message

2018-05-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message and also change the phrasing of the message so that is is more readable Signed-off-by: Colin Ian King --- V2: rephrase message, as helpfully suggested by Tariq

Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-22 Thread Roopa Prabhu
On Tue, May 22, 2018 at 8:04 AM, Eric Dumazet wrote: > > > On 05/22/2018 07:51 AM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> > > ... > >> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c >> index 4d622112..cf5cfc5 100644 >>

Re: [PATCH net-next 2/2] tcp: do not aggressively quick ack after ECN events

2018-05-22 Thread Soheil Hassas Yeganeh
On Mon, May 21, 2018 at 6:08 PM, Eric Dumazet wrote: > ECN signals currently forces TCP to enter quickack mode for > up to 16 (TCP_MAX_QUICKACKS) following incoming packets. > > We believe this is not needed, and only sending one immediate ack > for the current packet should

Re: [PATCH net-next 08/12] amd-xgbe: Add ethtool show/set channels support

2018-05-22 Thread Tom Lendacky
On 5/22/2018 12:35 AM, Jakub Kicinski wrote: > On Mon, 21 May 2018 16:59:37 -0500, Tom Lendacky wrote: >> +rx = combined + channels->rx_count; >> +tx = combined + channels->tx_count; >> +netdev_notice(netdev, "final channel count assignment: combined=%u, >> rx-only=%u, tx-only=%u\n",

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 03:26:26PM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 03:17:37PM CEST, m...@redhat.com wrote: > >On Tue, May 22, 2018 at 03:14:22PM +0200, Jiri Pirko wrote: > >> Tue, May 22, 2018 at 03:12:40PM CEST, m...@redhat.com wrote: > >> >On Tue, May 22, 2018 at 11:08:53AM

Re: [PATCH net-next 1/2] tcp: add max_quickacks param to tcp_incr_quickack and tcp_enter_quickack_mode

2018-05-22 Thread Soheil Hassas Yeganeh
On Mon, May 21, 2018 at 6:08 PM, Eric Dumazet wrote: > We want to add finer control of the number of ACK packets sent after > ECN events. > > This patch is not changing current behavior, it only enables following > change. > > Signed-off-by: Eric Dumazet

Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-22 Thread Toke Høiland-Jørgensen
Pablo Neira Ayuso writes: > Hi Toke, > > On Tue, May 22, 2018 at 03:57:38PM +0200, Toke Høiland-Jørgensen wrote: >> When CAKE is deployed on a gateway that also performs NAT (which is a >> common deployment mode), the host fairness mechanism cannot distinguish >> internal

Re: [PATCH net-next 00/13] nfp: abm: add basic support for advanced buffering NIC

2018-05-22 Thread Or Gerlitz
On Tue, May 22, 2018 at 10:56 AM, Jakub Kicinski wrote: > On Mon, May 21, 2018 at 11:32 PM, Or Gerlitz wrote: >> On Tue, May 22, 2018 at 8:12 AM, Jakub Kicinski wrote: >>> Hi! >>> >>> This series lays groundwork for advanced buffer management NIC feature. >>> It

Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr

2018-05-22 Thread Jamal Hadi Salim
On 21/05/18 04:03 PM, Vlad Buslov wrote: Initial net_device implementation used ingress_lock spinlock to synchronize ingress path of device. This lock was used in both process and bh context. In some code paths action map lock was obtained while holding ingress_lock. Commit e1e992e52faa

[PATCH net-next] net: stmmac: Add PPS and Flexible PPS support

2018-05-22 Thread Jose Abreu
This adds support for PPS output and Flexible PPS (which is equivalent to per_out output of PTP subsystem). Tested using an oscilloscope and the following commands: 1) Start PTP4L: # ptp4l -A -4 -H -m -i eth0 & 2) Set Flexible PPS frequency: # echo >

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 11:08:53AM +0200, Jiri Pirko wrote: > Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: > >Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: > >>Use the registration/notification framework supported by the generic > >>failover

  1   2   3   4   >