Re: [PATCH] net: phy: mdio-gpio: Cut surplus includes

2018-06-12 Thread Andrew Lunn
On Mon, Jun 11, 2018 at 01:19:03PM +0200, Linus Walleij wrote: > The GPIO MDIO driver now needs only > so cut the legacy and > includes that are no longer used. > > Signed-off-by: Linus Walleij Reviewed-by: Andrew Lunn Andrew

[PATCH RFC v2 ipsec-next 1/3] flow: Extend flow informations with xfrm interface id.

2018-06-12 Thread Steffen Klassert
Add a new flowi_xfrm structure with informations needed to do a xfrm lookup. At the moment it keeps the informations about the new xfrm interface id needed to lookup xfrm interfaces that are introduced with a followup patch. We need this new lookup key as other possible keys, like the ifindex is al

[PATCH RFC v2 ipsec-next 3/3] xfrm: Add virtual xfrm interfaces

2018-06-12 Thread Steffen Klassert
This patch adds support for virtual xfrm interfaces. Packets that are routed through such an interface are guaranteed to be IPsec transformed or dropped. It is a generic virtual interface that ensures IPsec transformation, no need to know what happens behind the interface. This means that we can tu

[PATCH RFC v2 ipsec-next 0/3] Virtual xfrm interfaces

2018-06-12 Thread Steffen Klassert
This patchset introduces new virtual xfrm interfaces. The design of virtual xfrm interfaces interfaces was discussed at the Linux IPsec workshop 2018. This patchset implements these interfaces as the IPsec userspace and kernel developers agreed. The purpose of these interfaces is to overcome the de

[PATCH RFC v2 ipsec-next 2/3] xfrm: Add a new lookup key to match xfrm interfaces.

2018-06-12 Thread Steffen Klassert
This patch adds the xfrm interface id as a lookup key for xfrm states and policies. With this we can assign states and policies to virtual xfrm interfaces. Signed-off-by: Steffen Klassert Acked-by: Shannon Nelson Acked-by: Benedict Wong Tested-by: Benedict Wong Tested-by: Antony Antony Review

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-06-12 Thread Steffen Klassert
On Fri, Jun 08, 2018 at 10:41:37AM +0200, Kristian Evensen wrote: > Hi, > > On Wed, Jun 6, 2018 at 6:03 PM, Tobias Hommel > wrote: > > Sorry no progress until now, I currently do not get time to have a deeper > > look > > into that. We're back to 4.1.6 right now. > > Thanks for letting me know

Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK

2018-06-12 Thread Steffen Klassert
On Tue, Jun 12, 2018 at 11:33:41AM +0900, Lorenzo Colitti wrote: > On Tue, Jun 12, 2018 at 11:12 AM Subash Abhinov Kasiviswanathan > wrote: > > > > This patch adds support for OUTPUT_MARK in xfrm state to exercise the > > functionality added by kernel commit 077fbac405bf > > ("net: xfrm: support s

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-06-12 Thread Kristian Evensen
Hi, On Tue, Jun 12, 2018 at 10:03 AM, Steffen Klassert wrote: > I spent quite some time again yesterday in trying to find a > case where dst_orig can be NULL in xfrm_lookup(). I don't see > how this can happen, so I fear we need a bisection on this. Thanks for spending time on this. I will see w

Re: [PATCH net 2/3] hv_netvsc: fix network namespace issues with VF support

2018-06-12 Thread Dan Carpenter
On Mon, Jun 11, 2018 at 12:44:55PM -0700, Stephen Hemminger wrote: > When finding the parent netvsc device, the search needs to be across > all netvsc device instances (independent of network namespace). > > Find parent device of VF using upper_dev_get routine which > searches only adjacent list.

[PATCH bpf] xsk: re-add queue id check for XDP_SKB path

2018-06-12 Thread Björn Töpel
From: Björn Töpel Commit 173d3adb6f43 ("xsk: add zero-copy support for Rx") introduced a regression on the XDP_SKB receive path, when the queue id checks were removed. Now, they are back again. Fixes: 173d3adb6f43 ("xsk: add zero-copy support for Rx") Reported-by: Qi Zhang Signed-off-by: Björn

Re: [PATCH bpf] xsk: re-add queue id check for XDP_SKB path

2018-06-12 Thread Daniel Borkmann
On 06/12/2018 12:02 PM, Björn Töpel wrote: > From: Björn Töpel > > Commit 173d3adb6f43 ("xsk: add zero-copy support for Rx") introduced a > regression on the XDP_SKB receive path, when the queue id checks were > removed. Now, they are back again. > > Fixes: 173d3adb6f43 ("xsk: add zero-copy supp

Re: [PATCH net] tls: fix NULL pointer dereference on poll

2018-06-12 Thread Daniel Borkmann
On 06/12/2018 07:37 AM, Christoph Hellwig wrote: >> Looks like the recent conversion from poll to poll_mask callback started >> in 152524231023 ("net: add support for ->poll_mask in proto_ops") missed >> to eventually convert kTLS, too: TCP's ->poll was converted over to the >> ->poll_mask in commi

Re: netdevice notifier and device private data

2018-06-12 Thread Alexander Aring
Hi, On Sun, Jun 10, 2018 at 10:09:39PM -0400, Michael Richardson wrote: > > Alexander Aring wrote: > >> It totally seems like broken behaviour. Maybe it's not even > >> intentional. Maybe they are just foobar. > > > They simple don't know what they doing... somebody thought 6LoWPA

Re: [bpf PATCH v2 1/2] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-12 Thread John Fastabend
On 06/11/2018 04:14 PM, Daniel Borkmann wrote: > Hi John, > > On 06/08/2018 05:06 PM, John Fastabend wrote: >> This fixes a crash where we assign tcp_prot to IPv6 sockets instead >> of tcpv6_prot. >> >> Previously we overwrote the sk->prot field with tcp_prot even in the >> AF_INET6 case. This pat

[PATCH 1/1] ip: add rmnet initial support

2018-06-12 Thread Daniele Palmas
This patch adds basic support for Qualcomm rmnet devices. Signed-off-by: Daniele Palmas --- ip/Makefile | 2 +- ip/iplink.c | 2 +- ip/iplink_rmnet.c | 70 +++ 3 files changed, 72 insertions(+), 2 deletions(-) create mode 100644

Re: [PATCH net 2/3] hv_netvsc: fix network namespace issues with VF support

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 12:51:28 +0300 Dan Carpenter wrote: > On Mon, Jun 11, 2018 at 12:44:55PM -0700, Stephen Hemminger wrote: > > When finding the parent netvsc device, the search needs to be across > > all netvsc device instances (independent of network namespace). > > > > Find parent device of

[jkirsher/next-queue PATCH v2 0/7] Add support for L2 Fwd Offload w/o ndo_select_queue

2018-06-12 Thread Alexander Duyck
This patch series is meant to allow support for the L2 forward offload, aka MACVLAN offload without the need for using ndo_select_queue. The existing solution currently requires that we use ndo_select_queue in the transmit path if we want to associate specific Tx queues with a given MACVLAN interf

[jkirsher/next-queue PATCH v2 2/7] net: Add support for subordinate device traffic classes

2018-06-12 Thread Alexander Duyck
This patch is meant to provide the basic tools needed to allow us to create subordinate device traffic classes. The general idea here is to allow subdividing the queues of a device into queue groups accessible through an upper device such as a macvlan. The idea here is to enforce the idea that an

[jkirsher/next-queue PATCH v2 1/7] net-sysfs: Drop support for XPS and traffic_class on single queue device

2018-06-12 Thread Alexander Duyck
This patch makes it so that we do not report the traffic class or allow XPS configuration on single queue devices. This is mostly to avoid unnecessary complexity with changes I have planned that will allow us to reuse the unused tc_to_txq and XPS configuration on a single queue device to allow it t

[jkirsher/next-queue PATCH v2 4/7] net: Add support for subordinate traffic classes to netdev_pick_tx

2018-06-12 Thread Alexander Duyck
This change makes it so that we can support the concept of subordinate device traffic classes to the core networking code. In doing this we can start pulling out the driver specific bits needed to support selecting a queue based on an upper device. The solution at is currently stands is only parti

[jkirsher/next-queue PATCH v2 5/7] net: Add generic ndo_select_queue functions

2018-06-12 Thread Alexander Duyck
This patch adds a generic version of the ndo_select_queue functions for either returning 0 or selecting a queue based on the processor ID. This is generally meant to just reduce the number of functions we have to change in the future when we have to deal with ndo_select_queue changes. Signed-off-b

[jkirsher/next-queue PATCH v2 6/7] net: allow ndo_select_queue to pass netdev

2018-06-12 Thread Alexander Duyck
This patch makes it so that instead of passing a void pointer as the accel_priv we instead pass a net_device pointer as sb_dev. Making this change allows us to pass the subordinate device through to the fallback function eventually so that we can keep the actual code in the ndo_select_queue call as

[jkirsher/next-queue PATCH v2 7/7] net: allow fallback function to pass netdev

2018-06-12 Thread Alexander Duyck
For most of these calls we can just pass NULL through to the fallback function as the sb_dev. The only cases where we cannot are the cases where we might be dealing with either an upper device or a driver that would have configured things to support an sb_dev itself. The only driver that has any s

[jkirsher/next-queue PATCH v2 3/7] ixgbe: Add code to populate and use macvlan tc to Tx queue map

2018-06-12 Thread Alexander Duyck
This patch makes it so that we use the tc_to_txq mapping in the macvlan device in order to select the Tx queue for outgoing packets. The idea here is to try and move away from using ixgbe_select_queue and to come up with a generic way to make this work for devices going forward. By encoding this i

[PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

2018-06-12 Thread Fu, Qiaobin
The new action inheritdsfield copies the field DS of IPv4 and IPv6 packets into skb->priority. This enables later classification of packets based on the DS field. v4: *Not allow setting flags other than the expected ones. *Allow dumping the pure flags. Original idea by Jamal Hadi Salim Signed-

Re: [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports

2018-06-12 Thread Andrew Lunn
On Mon, Jun 11, 2018 at 05:21:05PM +0530, Tejaswi Tanikella wrote: > On receiving a IGMPv2/v3 query, based on max_delay set in the header a > timer is started to send out a response after a random time within > max_delay. If the system then moves into suspend state, Report is > delayed until system

Re: [PATCH 2/2] ktime: helpers to convert between ktime and jiffies

2018-06-12 Thread Andrew Lunn
On Mon, Jun 11, 2018 at 05:22:28PM +0530, Tejaswi Tanikella wrote: > Signed-off-by: Tejaswi Tanikella > --- > include/linux/ktime.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/ktime.h b/include/linux/ktime.h > index 5b9fddb..4881483 100644 > --- a/include/linux/kti

Re: problems with SCTP GSO

2018-06-12 Thread Marcelo Ricardo Leitner
On Mon, Jun 11, 2018 at 08:29:05PM -0700, David Miller wrote: > > I would like to bring up some problems with the current GSO > implementation in SCTP. > > The most important for me right now is that SCTP uses > "skb_gro_receive()" to build "GSO" frames :-( > > Really it just ends up using the s

[PATCH] Revert "net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets"

2018-06-12 Thread Bart Van Assche
Revert the patch mentioned in the subject because it breaks at least the Avahi mDNS daemon. That patch namely causes the Ubuntu 18.04 Avahi daemon to fail to start: Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Successfully called chroot(). Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Successfully

Re: [PATCH] Revert "net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets"

2018-06-12 Thread Eric Dumazet
On 06/12/2018 10:05 AM, Bart Van Assche wrote: > Revert the patch mentioned in the subject because it breaks at least > the Avahi mDNS daemon. That patch namely causes the Ubuntu 18.04 Avahi > daemon to fail to start: > > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Successfully called chroot()

Re: problems with SCTP GSO

2018-06-12 Thread Marcelo Ricardo Leitner
On Tue, Jun 12, 2018 at 02:05:06PM -0300, Marcelo Ricardo Leitner wrote: > On Mon, Jun 11, 2018 at 08:29:05PM -0700, David Miller wrote: > > > > I would like to bring up some problems with the current GSO > > implementation in SCTP. > > > > The most important for me right now is that SCTP uses >

Fw: [Bug 200033] New: stack-out-of-bounds in __xfrm_dst_hash net/xfrm/xfrm_hash.h

2018-06-12 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 12 Jun 2018 01:44:36 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 200033] New: stack-out-of-bounds in __xfrm_dst_hash net/xfrm/xfrm_hash.h https://bugzilla.kernel.org/show_bug.cgi?id=200033 Bug I

Re: [jkirsher/next-queue PATCH v2 2/7] net: Add support for subordinate device traffic classes

2018-06-12 Thread Florian Fainelli
On 06/12/2018 08:18 AM, Alexander Duyck wrote: > This patch is meant to provide the basic tools needed to allow us to create > subordinate device traffic classes. The general idea here is to allow > subdividing the queues of a device into queue groups accessible through an > upper device such as a

Re: [jkirsher/next-queue PATCH v2 0/7] Add support for L2 Fwd Offload w/o ndo_select_queue

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 11:18:25 -0400 Alexander Duyck wrote: > This patch series is meant to allow support for the L2 forward offload, aka > MACVLAN offload without the need for using ndo_select_queue. > > The existing solution currently requires that we use ndo_select_queue in > the transmit path

Re: [jkirsher/next-queue PATCH v2 0/7] Add support for L2 Fwd Offload w/o ndo_select_queue

2018-06-12 Thread Florian Fainelli
On 06/12/2018 08:18 AM, Alexander Duyck wrote: > This patch series is meant to allow support for the L2 forward offload, aka > MACVLAN offload without the need for using ndo_select_queue. > > The existing solution currently requires that we use ndo_select_queue in > the transmit path if we want to

Re: [PATCH] Revert "net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets"

2018-06-12 Thread David Miller
From: Bart Van Assche Date: Tue, 12 Jun 2018 10:05:55 -0700 > Revert the patch mentioned in the subject because it breaks at least > the Avahi mDNS daemon. That patch namely causes the Ubuntu 18.04 Avahi > daemon to fail to start: > > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Successfully cal

Re: [PATCH bpf v3] tools/bpftool: fix a bug in bpftool perf

2018-06-12 Thread Jakub Kicinski
On Mon, 11 Jun 2018 22:35:48 -0700, Yonghong Song wrote: > Commit b04df400c302 ("tools/bpftool: add perf subcommand") > introduced bpftool subcommand perf to query bpf program > kuprobe and tracepoint attachments. > > The perf subcommand will first test whether bpf subcommand > BPF_TASK_FD_QUERY i

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-06-12 Thread Tobias Hommel
On Fri, Jun 08, 2018 at 10:41:37AM +0200, Kristian Evensen wrote: > Hi, > > On Wed, Jun 6, 2018 at 6:03 PM, Tobias Hommel > wrote: > > Sorry no progress until now, I currently do not get time to have a deeper > > look > > into that. We're back to 4.1.6 right now. > > Thanks for letting me know

[PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK

2018-06-12 Thread Subash Abhinov Kasiviswanathan
This patch adds support for OUTPUT_MARK in xfrm state to exercise the functionality added by kernel commit 077fbac405bf ("net: xfrm: support setting an output mark."). Sample output with output-mark - src 192.168.1.1 dst 192.168.1.2 proto esp spi 0x4321 reqid 0 mode tunnel rep

Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK

2018-06-12 Thread Subash Abhinov Kasiviswanathan
Have you considered putting this earlier up in the output, where the mark is printed as well? + if (tb[XFRMA_OUTPUT_MARK]) { + __u32 output_mark = rta_getattr_u32(tb[XFRMA_OUTPUT_MARK]); + + fprintf(fp, "\toutput-mark 0x%x %s", output_mark, _SL_); + }

Problems in tc-cbq-details.8, tc-cbq.8, tc-mqprio.8, tc-prio.8, tc-htb.8

2018-06-12 Thread esr
This is automatically generated email about markup problems in a man page for which you appear to be responsible. If you are not the right person or list, please tell me so I can correct my database. See http://catb.org/~esr/doclifter/bugs.html for details on how and why these patches were genera

Re: [PATCH net-next 0/10] xfrm: remove flow cache

2018-06-12 Thread Kristian Evensen
Hello, On Tue, Jul 18, 2017 at 8:15 PM, David Miller wrote: > Steffen, I know you have some level of trepidation about this because > there is obviously some performance cost immediately for removing this > DoS problem. In a project I am involved in, we are running ipsec (Strongswan) on differen

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

2018-06-12 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 07, 2018 at 01:07:01PM -0700, Martin KaFai Lau escreveu: > On Thu, Jun 07, 2018 at 04:30:29PM -0300, Arnaldo Carvalho de Melo wrote: > > So this must be available in a newer llvm version? Which one? > I should have put in the details in my last email or > in the commit message, my bad.

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

2018-06-12 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 12, 2018 at 05:31:24PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 07, 2018 at 01:07:01PM -0700, Martin KaFai Lau escreveu: > > On Thu, Jun 07, 2018 at 04:30:29PM -0300, Arnaldo Carvalho de Melo wrote: > > > So this must be available in a newer llvm version? Which one? > >

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 15:16:14 -0400 (EDT) e...@thyrsus.com wrote: > This is automatically generated email about markup problems in a man > page for which you appear to be responsible. If you are not the right > person or list, please tell me so I can correct my database. > > See http://catb.org/~

Re: [PATCH] Revert "net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets"

2018-06-12 Thread Maciej Żenczykowski
Any ideas about how to fix the core issue of tb->fast* being effectively invalid? ie. currently any reader of tb->fastreuse(port) which isn't simply testing for it being >= 0 is basically a bug (-1 is the empty tb case, so that AFAICT keeps on working). For example sk_reuseport_match(tb, sk) can

[PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Frank van der Linden
commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table") introduced an optimization for the handling of child sockets created for a new TCP connection. But this optimization passes any data associated with the last ACK of the connection handshake up the stack without verifying

Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread van der Linden, Frank
Resubmitted. The various release/deref requirements in that path make a straight "goto csum_error" impossible without duplicating some lines, but this is 2nd best. Frank On 6/11/18, 4:43 PM, "van der Linden, Frank" wrote: Yeah, true, it's missing INERRS in this case. I'll fix it up a bit

Re: [PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Eric Dumazet
On 06/12/2018 02:41 PM, Frank van der Linden wrote: > commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash > table") introduced an optimization for the handling of child sockets > created for a new TCP connection. > > But this optimization passes any data associated with the las

Re: [PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread van der Linden, Frank
The convention seems to be to call tcp_checksum_complete after tcp_filter has a chance to deal with the packet. I wanted to preserve that. If that is not a concern, then I agree that this is a far better way to go. Frank On 6/12/18, 2:50 PM, "Eric Dumazet" wrote: On 06/12/2018

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Eric S. Raymond
Stephen Hemminger : > Please resubmit as real patch with signed-off-by I would like to follow your intructions, but that description leaves me not quite certain what you want. A git format-patch thing? If so, what git url should I clone from? -- http://www.catb.org/~esr/";>Eric

Re: [PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Eric Dumazet
On 06/12/2018 02:53 PM, van der Linden, Frank wrote: > The convention seems to be to call tcp_checksum_complete after tcp_filter has > a chance to deal with the packet. I wanted to preserve that. > > If that is not a concern, then I agree that this is a far better way to go. > > Frank Given

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v2 2/7] net: Add support for subordinate device traffic classes

2018-06-12 Thread Alexander Duyck
On Tue, Jun 12, 2018 at 10:49 AM, Florian Fainelli wrote: > On 06/12/2018 08:18 AM, Alexander Duyck wrote: >> This patch is meant to provide the basic tools needed to allow us to create >> subordinate device traffic classes. The general idea here is to allow >> subdividing the queues of a device i

Re: [PATCH net 0/4] nfp: fix a warning, stats, naming and route leak

2018-06-12 Thread David Miller
From: Jakub Kicinski Date: Mon, 11 Jun 2018 21:33:34 -0700 > Various fixes for the NFP. Patch 1 fixes a harmless GCC 8 warning. > Patch 2 ensures statistics are correct after users decrease the number > of channels/rings. Patch 3 restores phy_port_name behaviour for flower, > ndo_get_phy_port_n

Re: [PATCH net 0/3] hv_netvsc: notification and namespace fixes

2018-06-12 Thread David Miller
From: Stephen Hemminger Date: Mon, 11 Jun 2018 12:44:53 -0700 > This set of patches addresses two set of fixes. First it backs out > the common callback model which was merged in net-next without > completing all the review feedback or getting maintainer approval. > > Then it fixes the transpare

Re: [PATCH] net: phy: mdio-gpio: Cut surplus includes

2018-06-12 Thread David Miller
From: Linus Walleij Date: Mon, 11 Jun 2018 13:19:03 +0200 > The GPIO MDIO driver now needs only > so cut the legacy and > includes that are no longer used. > > Signed-off-by: Linus Walleij Applied.

Re: [PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread van der Linden, Frank
Sure, fair enough. I was assuming there might be a reason of why tcp_filter was always done after the data (not pseudo header) checksum. If there isn't (and obviously the the possible MD5 checks are done before it too), then that's definitely the right thing to do. I'll resend. Though if you ha

Re: [PATCH net] tc-testing: ife: fix wrong teardown command in test b7b8

2018-06-12 Thread David Miller
From: Davide Caratti Date: Mon, 11 Jun 2018 16:02:36 +0200 > fix failures in the 'teardown' stage of test b7b8, probably a leftover of > commit 7c5995b33d6e ("tc-testing: fixed copy-pasting error in ife tests") > > Fixes: a56e6bcd34b55 ("tc-testing: updated ife test cases") > Signed-off-by: Davi

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v2 0/7] Add support for L2 Fwd Offload w/o ndo_select_queue

2018-06-12 Thread Alexander Duyck
On Tue, Jun 12, 2018 at 10:56 AM, Florian Fainelli wrote: > On 06/12/2018 08:18 AM, Alexander Duyck wrote: >> This patch series is meant to allow support for the L2 forward offload, aka >> MACVLAN offload without the need for using ndo_select_queue. >> >> The existing solution currently requires t

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 18:00:03 -0400 "Eric S. Raymond" wrote: > Stephen Hemminger : > > Please resubmit as real patch with signed-off-by > > I would like to follow your intructions, but that description leaves me > not quite certain what you want. A git format-patch thing? If so, what > git ur

Re: Backport bonding patches to fix active-passive

2018-06-12 Thread David Miller
From: Nate Clark Date: Mon, 11 Jun 2018 13:44:40 -0400 > Would it be possible to queue up the three commits for backporting to > 4.9 stable: > b5bf0f5b16b9c316c34df9f31d4be8729eb86845 bonding: correctly update > link status during mii-commit > 3f3c278c94dd994fe0d9f21679ae19b9c0a55292 bonding: fix

Re: [Patch net] smc: convert to ->poll_mask

2018-06-12 Thread David Miller
From: Cong Wang Date: Mon, 11 Jun 2018 14:07:14 -0700 > smc->clcsock is an internal TCP socket, after TCP socket > converts to ->poll_mask, ->poll doesn't exist any more. > So just convert smc socket to ->poll_mask too. > > Fixes: 2c7d3dacebd4 ("net/tcp: convert to ->poll_mask") > Reported-by: s

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v2 0/7] Add support for L2 Fwd Offload w/o ndo_select_queue

2018-06-12 Thread Alexander Duyck
On Tue, Jun 12, 2018 at 10:50 AM, Stephen Hemminger wrote: > On Tue, 12 Jun 2018 11:18:25 -0400 > Alexander Duyck wrote: > >> This patch series is meant to allow support for the L2 forward offload, aka >> MACVLAN offload without the need for using ndo_select_queue. >> >> The existing solution cur

Re: [PATCH 1/1] ip: add rmnet initial support

2018-06-12 Thread Subash Abhinov Kasiviswanathan
+ +static void print_explain(FILE *f) +{ + fprintf(f, + "Usage: ... rmnet mux_id MUXID\n" + "\n" + "MUXID := 1-127\n" + ); +} Hi Daniele This range can be from 1-254. + +static void explain(void) +{ + print_explain(stderr); +} + +sta

[PATCH v3] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Frank van der Linden
commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table") introduced an optimization for the handling of child sockets created for a new TCP connection. But this optimization passes any data associated with the last ACK of the connection handshake up the stack without verifying

Re: [PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread van der Linden, Frank
Ok, patch v3 sent. It was rightly pointed out to me that I shouldn't commit the mortal sin of top posting - but bear with me guys, I'll dig up my 25-year old .muttrc :-) Frank On 6/12/18, 3:03 PM, "Eric Dumazet" wrote: On 06/12/2018 02:53 PM, van der Linden, Frank wrote: > T

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Eric S. Raymond
Stephen Hemminger : > On Tue, 12 Jun 2018 18:00:03 -0400 > "Eric S. Raymond" wrote: > > > Stephen Hemminger : > > > Please resubmit as real patch with signed-off-by > > > > I would like to follow your intructions, but that description leaves me > > not quite certain what you want. A git format

Re: [PATCH bpf v3] tools/bpftool: fix a bug in bpftool perf

2018-06-12 Thread Daniel Borkmann
On 06/12/2018 07:35 AM, Yonghong Song wrote: > Commit b04df400c302 ("tools/bpftool: add perf subcommand") > introduced bpftool subcommand perf to query bpf program > kuprobe and tracepoint attachments. > > The perf subcommand will first test whether bpf subcommand > BPF_TASK_FD_QUERY is supported

Re: [PATCH 1/1] ip: add rmnet initial support

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 16:12:57 +0200 Daniele Palmas wrote: > This patch adds basic support for Qualcomm rmnet devices. > > Signed-off-by: Daniele Palmas > --- > ip/Makefile | 2 +- > ip/iplink.c | 2 +- > ip/iplink_rmnet.c | 70 > +++

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 19:41:03 -0400 "Eric S. Raymond" wrote: > Stephen Hemminger : > > On Tue, 12 Jun 2018 18:00:03 -0400 > > "Eric S. Raymond" wrote: > > > > > Stephen Hemminger : > > > > Please resubmit as real patch with signed-off-by > > > > > > I would like to follow your intructio

Re: [bpf PATCH] bpf: selftest fix for sockmap

2018-06-12 Thread Daniel Borkmann
On 06/11/2018 08:47 PM, John Fastabend wrote: > In selftest test_maps the sockmap test case attempts to add a socket > in listening state to the sockmap. This is no longer a valid operation > so it fails as expected. However, the test wrongly reports this as an > error now. Fix the test to avoid ad

Backport 3c75f6ee139d ("net_sched: sch_htb: add per class overlimits counter")

2018-06-12 Thread Cong Wang
Hi, Dave Please backport 3c75f6ee139d ("net_sched: sch_htb: add per class overlimits counter") to the stable branches you take care of. Technically it doesn't fix any bug, but it is useful for diagnose purpose. And of course, it is easy to backport too. Please let me know if you need my help to b

Re: Problems in tc-matchall.8, tc-sample.8

2018-06-12 Thread Eric S. Raymond
Stephen Hemminger : > The upstream repositories for master and net-next branch are now > split. Master branch is at: > git://git.kernel.org/pub/scm/network/iproute2/iproute2.gti > > and patches for next release are in (master branch): > git://git.kernel.org/pub/scm/network/iproute2/iproute2-ne

Re: [PATCH net] VSOCK: check sk state before receive

2018-06-12 Thread Hangbin Liu
On Mon, Jun 04, 2018 at 04:02:39PM +, Jorgen S. Hansen wrote: > > > On May 30, 2018, at 11:17 AM, Stefan Hajnoczi wrote: > > > > On Sun, May 27, 2018 at 11:29:45PM +0800, Hangbin Liu wrote: > >> Hmm...Although I won't reproduce this bug with my reproducer after > >> apply my patch. I could s

Re: [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK

2018-06-12 Thread Lorenzo Colitti
On Wed, Jun 13, 2018 at 3:48 AM Subash Abhinov Kasiviswanathan wrote: > > src 192.168.1.1 dst 192.168.1.2 > proto esp spi 0x4321 reqid 0 mode tunnel > replay-window 0 flag af-unspec > mark 0x1/0x3 > output-mark 0x2 Nit: I don't know what guarantees

Re: [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK

2018-06-12 Thread Stephen Hemminger
On Wed, 13 Jun 2018 12:14:53 +0900 Lorenzo Colitti wrote: > On Wed, Jun 13, 2018 at 3:48 AM Subash Abhinov Kasiviswanathan > wrote: > > > > src 192.168.1.1 dst 192.168.1.2 > > proto esp spi 0x4321 reqid 0 mode tunnel > > replay-window 0 flag af-unspec > > mark 0x1

[PATCH net] neighbour: skip NTF_EXT_LEARNED entries during forced gc

2018-06-12 Thread Roopa Prabhu
From: Roopa Prabhu Commit 9ce33e46531d ("neighbour: support for NTF_EXT_LEARNED flag") added support for NTF_EXT_LEARNED for neighbour entries. NTF_EXT_LEARNED entries are neigh entries managed by control plane (eg: Ethernet VPN implementation in FRR routing suite). Periodic gc already excludes t

[PATCH v1 net-next] stmmac: fix DMA channel hang in half-duplex mode

2018-06-12 Thread Bhadram Varka
HW does not support Half-duplex mode in multi-queue scenario. Fix it by not advertising the Half-Duplex mode if multi-queue enabled. Signed-off-by: Bhadram Varka --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethe

Re: [PATCH v3] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Eric Dumazet
On 06/12/2018 04:09 PM, Frank van der Linden wrote: > commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash > table") introduced an optimization for the handling of child sockets > created for a new TCP connection. > > But this optimization passes any data associated with the las

Re: [PATCH v2] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Balbir Singh
On Wed, Jun 13, 2018 at 7:50 AM, Eric Dumazet wrote: > > > On 06/12/2018 02:41 PM, Frank van der Linden wrote: >> commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash >> table") introduced an optimization for the handling of child sockets >> created for a new TCP connection. >> >>

Re: [PATCH v3] tcp: verify the checksum of the first data segment in a new connection

2018-06-12 Thread Balbir Singh
On Wed, Jun 13, 2018 at 9:09 AM, Frank van der Linden wrote: > commit 079096f103fa ("tcp/dccp: install syn_recv requests into ehash > table") introduced an optimization for the handling of child sockets > created for a new TCP connection. > > But this optimization passes any data associated with t

[PATCH net] net/multicast: clean change record if add new INCLUDE group

2018-06-12 Thread Hangbin Liu
Based on RFC3376 5.1 and RFC3810 6.1: If no interface state existed for that multicast address before the change (i.e., the change consisted of creating a new per-interface record), or if no state exists after the change (i.e., the change consisted of deleting a per-interface record)