[PATCH net-next] net: stmmac: Add support for CBS QDISC

2018-06-27 Thread Jose Abreu
This adds support for CBS reconfiguration using the TC application. A new callback was added to TC ops struct and another one to DMA ops to reconfigure the channel mode. Tested in GMAC5.10. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Vitor Soares Cc: Giuseppe Cavallaro

[PATCH bpf 1/4] xsk: fix potential lost completion message in SKB path

2018-06-27 Thread Magnus Karlsson
The code in xskq_produce_addr erroneously checked if there was up to LAZY_UPDATE_THRESHOLD amount of space in the completion queue. It only needs to check if there is one slot left in the queue. This bug could under some circumstances lead to a WARN_ON_ONCE being triggered and the completion

[PATCH bpf 2/4] xsk: frame could be completed more than once in SKB path

2018-06-27 Thread Magnus Karlsson
Fixed a bug in which a frame could be completed more than once when an error was returned from dev_direct_xmit(). The code erroneously retried sending the message leading to multiple calls to the SKB destructor and therefore multiple completions of the same buffer to user space. The error code in

[PATCH bpf 0/4] Bug fixes to the SKB TX path of AF_XDP

2018-06-27 Thread Magnus Karlsson
This patch set fixes three bugs in the SKB TX path of AF_XDP. Details in the individual commits. The structure of the patch set is as follows: Patch 1: Fix for lost completion message Patch 2-3: Fix for possible multiple completions of single packet Patch 4: Fix potential race during error

[PATCH bpf 4/4] xsk: fix potential race in SKB TX completion code

2018-06-27 Thread Magnus Karlsson
There was a potential race in the TX completion code for the SKB case when the TX napi thread and the error path of the sendmsg code could both call the SKB destructor at the same time. Fixed by introducing a spin_lock in the destructor. Fixes: 35fcde7f8deb ("xsk: support for Tx") Signed-off-by:

[PATCH net] net: stmmac: Set DMA buffer size in HW

2018-06-27 Thread Jose Abreu
This is clearly a bug. We need to set the DMA buffer size in the HW otherwise corruption can occur when receiving packets. This is probably not occuring because of small MTU values and because HW has a default value internally (which currently is bigger than default buffer size). Signed-off-by:

Re: [RFC PATCH v2 net-next 01/12] net: core: trivial netif_receive_skb_list() entry point

2018-06-27 Thread Edward Cree
On 27/06/18 01:06, Eric Dumazet wrote: > On 06/26/2018 11:17 AM, Edward Cree wrote: >> Just calls netif_receive_skb() in a loop. > ... > >> +void netif_receive_skb_list(struct sk_buff_head *list) > > Please use a standard list_head and standard list operators. > > (In all your patches) > > 1) We

[PATCH bpf 3/4] samples/bpf: deal with EBUSY return code from sendmsg in xdpsock sample

2018-06-27 Thread Magnus Karlsson
Sendmsg in the SKB path of AF_XDP can now return EBUSY when a packet was discarded and completed by the driver. Just ignore this message in the sample application. Fixes: b4b8faa1ded7 ("samples/bpf: sample application and documentation for AF_XDP sockets") Signed-off-by: Magnus Karlsson

Re: [PATCH net] net: stmmac: Set DMA buffer size in HW

2018-06-27 Thread Jose Abreu
David, On 27-06-2018 15:03, Jose Abreu wrote: > This is clearly a bug. You will probably have an hard time backporting this because of the way the callbacks are handled now. I can send you a patch based on some -stable branch if you prefer. Thanks and Best Regards, Jose Miguel Abreu

Re: [RFC PATCH v2 net-next 06/12] net: core: propagate SKB lists through packet_type lookup

2018-06-27 Thread Edward Cree
On 27/06/18 15:36, Willem de Bruijn wrote: > On Tue, Jun 26, 2018 at 8:19 PM Edward Cree wrote: >> __netif_receive_skb_taps() does a depressingly large amount of per-packet >> work that can't easily be listified, because the another_round looping >> makes it nontrivial to slice up into smaller

Re: [RFC PATCH v2 net-next 07/12] net: ipv4: listified version of ip_rcv

2018-06-27 Thread Florian Westphal
Edward Cree wrote: > Also involved adding a way to run a netfilter hook over a list of packets. > Rather than attempting to make netfilter know about lists (which would be > a major project in itself) we just let it call the regular okfn (in this > case ip_rcv_finish()) for any packets it

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Eric Dumazet
On 06/26/2018 07:34 PM, Lawrence Brakmo wrote: > When using dctcp and doing RPCs, if the last packet of a request is > ECN marked as having seen congestion (CE), the sender can decrease its > cwnd to 1. As a result, it will only send one packet when a new request > is sent. In some instances

[PATCH] test_bpf: flag tests that cannot be jited on s390

2018-06-27 Thread Kleber Sacilotto de Souza
Flag with FLAG_EXPECTED_FAIL the BPF_MAXINSNS tests that cannot be jited on s390 because they exceed BPF_SIZE_MAX and fail when CONFIG_BPF_JIT_ALWAYS_ON is set. Also set .expected_errcode to -ENOTSUPP so the tests pass in that case. Signed-off-by: Kleber Sacilotto de Souza --- lib/test_bpf.c |

Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure

2018-06-27 Thread Jesper Dangaard Brouer
On Tue, 26 Jun 2018 19:46:11 -0700 Saeed Mahameed wrote: > diff --git a/include/net/xdp.h b/include/net/xdp.h > index 2deea7166a34..afe302613ae1 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -138,6 +138,12 @@ xdp_set_data_meta_invalid(struct xdp_buff *xdp) >

Re: [PATCH net-next] net: stmmac: Add support for CBS QDISC

2018-06-27 Thread kbuild test robot
Hi Jose, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Add-support-for-CBS-QDISC/20180627-214704 config: sh-allyesconfig (attached as .config) compiler: sh4-linux-gnu-gcc

Re: [PATCH net-next] net: stmmac: Add support for CBS QDISC

2018-06-27 Thread Jose Abreu
++ SH Maintainers ++ SH ML Hi SH Maintainers, On 27-06-2018 15:15, kbuild test robot wrote: > Hi Jose, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: >

Re: [RFC PATCH v2 net-next 06/12] net: core: propagate SKB lists through packet_type lookup

2018-06-27 Thread Willem de Bruijn
On Tue, Jun 26, 2018 at 8:19 PM Edward Cree wrote: > > __netif_receive_skb_taps() does a depressingly large amount of per-packet > work that can't easily be listified, because the another_round looping > makes it nontrivial to slice up into smaller functions. > Fortunately, most of that work

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Eric Dumazet
On 06/27/2018 08:04 AM, Eric Dumazet wrote: > > > On 06/26/2018 07:34 PM, Lawrence Brakmo wrote: >> When using dctcp and doing RPCs, if the last packet of a request is >> ECN marked as having seen congestion (CE), the sender can decrease its >> cwnd to 1. As a result, it will only send one

Re: [PATCH 3/3] virtio_net: split XDP_TX kick and XDP_REDIRECT map flushing

2018-06-27 Thread Jason Wang
On 2018年06月26日 23:39, Jesper Dangaard Brouer wrote: The driver was combining XDP_TX virtqueue_kick and XDP_REDIRECT map flushing (xdp_do_flush_map). This is suboptimal, these two flush operations should be kept separate. The suboptimal behavior was introduced in commit 9267c430c6b6

[PATCH net-next v2] net: stmmac: Add support for CBS QDISC

2018-06-27 Thread Jose Abreu
This adds support for CBS reconfiguration using the TC application. A new callback was added to TC ops struct and another one to DMA ops to reconfigure the channel mode. Tested in GMAC5.10. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Vitor Soares Cc: Giuseppe Cavallaro

Re: s390x BPF JIT failures with test_bpf

2018-06-27 Thread Kleber Souza
On 06/27/18 12:36, Daniel Borkmann wrote: > On 06/27/2018 12:13 PM, Kleber Souza wrote: >> On 06/27/18 12:01, Daniel Borkmann wrote: >>> On 06/27/2018 11:40 AM, Kleber Souza wrote: >>> [...] When I load the test_bpf module from mainline (v4.18-rc2) with CONFIG_BPF_JIT_ALWAYS_ON=y on a

Re: [PATCH net-next] net: stmmac: Add support for CBS QDISC

2018-06-27 Thread Jose Abreu
Hi Geert, On 27-06-2018 15:36, Geert Uytterhoeven wrote: > Hi Jose, > > On Wed, Jun 27, 2018 at 4:32 PM Jose Abreu wrote: >> ++ SH Maintainers >> ++ SH ML >> >> Hi SH Maintainers, >> >> On 27-06-2018 15:15, kbuild test robot wrote: >>> Hi Jose, >>> >>> I love your patch! Perhaps something to

Re: [Patch net-next v3 1/3] net: introduce helper dev_change_tx_queue_len()

2018-06-27 Thread Eric Dumazet
On 01/25/2018 06:26 PM, Cong Wang wrote: > This patch promotes the local change_tx_queue_len() to a core > helper function, dev_change_tx_queue_len(), so that rtnetlink > and net-sysfs could share the code. This also prepares for the > following patch. > > Note, the -EFAULT in the original

Re: [patch net-next 0/9] net: sched: introduce chain templates support with offloading to mlxsw

2018-06-27 Thread Samudrala, Sridhar
On 6/27/2018 12:50 AM, Jiri Pirko wrote: Tue, Jun 26, 2018 at 11:18:58PM CEST, jakub.kicin...@netronome.com wrote: On Tue, 26 Jun 2018 09:12:17 +0200, Jiri Pirko wrote: Tue, Jun 26, 2018 at 09:00:45AM CEST, jakub.kicin...@netronome.com wrote: On Mon, Jun 25, 2018 at 11:43 PM, Jiri Pirko

Re: [bpf-next PATCH 1/2] samples/bpf: extend xdp_rxq_info to read packet payload

2018-06-27 Thread Song Liu
On Wed, Jun 27, 2018 at 4:23 AM, Jesper Dangaard Brouer wrote: > On Tue, 26 Jun 2018 16:53:15 -0700 > Song Liu wrote: > >> > +static char* options2str(enum cfg_options_flags flag) >> > +{ >> > + if (flag == NO_TOUCH) >> > + return "no_touch"; >> > + if (flag & READ_MEM)

[PATCH net 1/1] net/smc: rebuild nonblocking connect

2018-06-27 Thread Ursula Braun
The recent poll change may lead to stalls for non-blocking connecting SMC sockets, since sock_poll_wait is no longer performed on the internal CLC socket, but on the outer SMC socket. kernel_connect() on the internal CLC socket returns with -EINPROGRESS, but the wake up logic does not work in all

Re: [RFC PATCH v2 net-next 06/12] net: core: propagate SKB lists through packet_type lookup

2018-06-27 Thread Edward Cree
On 27/06/18 17:00, Willem de Bruijn wrote: > On Wed, Jun 27, 2018 at 10:49 AM Edward Cree wrote: >> On 27/06/18 15:36, Willem de Bruijn wrote: >>> Also, this function does more than just process network taps. >> This is true, but naming things is hard, and I couldn't think of either a >> better

Re: [bpf-next PATCH 2/2] samples/bpf: xdp_rxq_info action XDP_TX must adjust MAC-addrs

2018-06-27 Thread Song Liu
On Wed, Jun 27, 2018 at 4:20 AM, Jesper Dangaard Brouer wrote: > On Tue, 26 Jun 2018 17:09:01 -0700 > Song Liu wrote: > >> On Mon, Jun 25, 2018 at 7:27 AM, Jesper Dangaard Brouer >> wrote: >> > XDP_TX requires also changing the MAC-addrs, else some hardware >> > may drop the TX packet before

Re: [PATCH v7 07/11] net: pch_gbe: Remove AR8031 PHY hibernation disable

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:08PM -0700, Paul Burton wrote: > We should now be able to cope with the PHY entering hibernation, ie. > ceasing to provide the RX clock, whilst the ethernet link is down. > > Remove the code responsible for disabling the AR8031 PHY's hibernation > feature, allowing

Re: [PATCH v7 03/11] net: pch_gbe: Probe PHY ID & initialize only once

2018-06-27 Thread Paul Burton
Hi Andrew, On Wed, Jun 27, 2018 at 07:21:31PM +0200, Andrew Lunn wrote: > > [1] Please, someone patent PHY hotplugging & rigorously enforce said > > patent such that nobody can do it. At least not with an EG20T MAC. > > Hi Paul > > It is already possible, and probably patented. SFP cages

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:07PM -0700, Paul Burton wrote: > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > including both the AR8031 used by the Minnowboard & the RTL8211E used by > the MIPS

[PATCH net] tcp: add one more quick ack after after ECN events

2018-06-27 Thread Eric Dumazet
Larry Brakmo proposal ( https://patchwork.ozlabs.org/patch/935233/ tcp: force cwnd at least 2 in tcp_cwnd_reduction) made us rethink about our recent patch removing ~16 quick acks after ECN events. tcp_enter_quickack_mode(sk, 1) makes sure one immediate ack is sent, but in the case the sender

Re: [PATCH bpf 4/4] xsk: fix potential race in SKB TX completion code

2018-06-27 Thread Eric Dumazet
On 06/27/2018 07:02 AM, Magnus Karlsson wrote: > There was a potential race in the TX completion code for > the SKB case when the TX napi thread and the error path > of the sendmsg code could both call the SKB destructor > at the same time. Fixed by introducing a spin_lock in the > destructor.

Re: [net] bpfilter: include bpfilter_umh in assembly instead of using objcopy

2018-06-27 Thread Guenter Roeck
On Tue, Jun 26, 2018 at 08:13:48PM -0700, Alexei Starovoitov wrote: > From: Masahiro Yamada > > What we want here is to embed a user-space program into the kernel. > Instead of the complex ELF magic, let's simply wrap it in the assembly > with the '.incbin' directive. > > Signed-off-by:

RE: [RFC bpf-next 0/6] XDP RX device meta data acceleration (WIP)

2018-06-27 Thread Parikh, Neerav
Thanks Saeed for starting this thread :) My comments inline. > -Original Message- > From: Saeed Mahameed [mailto:sae...@dev.mellanox.co.il] > Sent: Tuesday, June 26, 2018 7:46 PM > To: Jesper Dangaard Brouer ; Alexei Starovoitov > ; Daniel Borkmann > > Cc: Parikh, Neerav ;

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Neal Cardwell
On Tue, Jun 26, 2018 at 10:34 PM Lawrence Brakmo wrote: > The only issue is if it is safe to always use 2 or if it is better to > use min(2, snd_ssthresh) (which could still trigger the problem). Always using 2 SGTM. I don't think we need min(2, snd_ssthresh), as that should be the same as just

Re: [PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero

2018-06-27 Thread Steffen Klassert
On Tue, Jun 26, 2018 at 02:19:10PM -0700, Shannon Nelson wrote: > The offload_handle should be an opaque data cookie for the driver > to use, much like the data cookie for a timer or alarm callback. > Thus, the XFRM stack should not be checking for non-zero, because > the driver might use that to

Re: [RFC PATCH v2 net-next 06/12] net: core: propagate SKB lists through packet_type lookup

2018-06-27 Thread Willem de Bruijn
On Wed, Jun 27, 2018 at 10:49 AM Edward Cree wrote: > > On 27/06/18 15:36, Willem de Bruijn wrote: > > On Tue, Jun 26, 2018 at 8:19 PM Edward Cree wrote: > >> __netif_receive_skb_taps() does a depressingly large amount of per-packet > >> work that can't easily be listified, because the

Re: [PATCH net] tcp: add one more quick ack after after ECN events

2018-06-27 Thread Neal Cardwell
On Wed, Jun 27, 2018 at 11:47 AM Eric Dumazet wrote: > > Larry Brakmo proposal ( https://patchwork.ozlabs.org/patch/935233/ > tcp: force cwnd at least 2 in tcp_cwnd_reduction) made us rethink > about our recent patch removing ~16 quick acks after ECN events. > > tcp_enter_quickack_mode(sk, 1)

Re: [PATCH v7 03/11] net: pch_gbe: Probe PHY ID & initialize only once

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:04PM -0700, Paul Burton wrote: > The pch_gbe driver currently probes for the PHY ID & configures the PHY > every time the MAC is reset, even though we know that the PHY won't have > changed since the last MAC reset [1]. > > This patch moves the PHY probe to instead

Re: [PATCH v7 05/11] net: pch_gbe: Move pch_gbe_watchdog lower in pch_gbe_main.c

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:06PM -0700, Paul Burton wrote: > This patch moves the pch_gbe_watchdog() function lower in pch_gbe_main.c > in order to allow use of other functions in the next patch, without > requiring lots of forward declarations. Doing this as a separate patch > makes it clearer

[PATCH net-next] netem: slotting with non-uniform distribution

2018-06-27 Thread Yousuk Seung
Extend slotting with support for non-uniform distributions. This is similar to netem's non-uniform distribution delay feature. Commit f043efeae2f1 ("netem: support delivering packets in delayed time slots") added the slotting feature to approximate the behaviors of media with packet aggregation

[PATCH v2 net-next 1/6] net sched actions: fix coding style in pedit action

2018-06-27 Thread Roman Mashak
Fix coding style issues in tc pedit action detected by the checkpatch script. Reviewed-by: Simon Horman Signed-off-by: Roman Mashak --- net/sched/act_pedit.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/net/sched/act_pedit.c

[PATCH v2 net-next 0/6] net sched actions: code style cleanup and fixes

2018-06-27 Thread Roman Mashak
The patchset fixes a few code stylistic issues and typos, as well as one detected by sparse semantic checker tool. No functional changes introduced. Patch 1 & 2 fix coding style bits caught by the checkpatch.pl script Patch 3 fixes an issue with a shadowed variable Patch 4 adds sizeof() operator

[PATCH v2 net-next 6/6] net sched actions: avoid bitwise operation on signed value in pedit

2018-06-27 Thread Roman Mashak
Since char can be unsigned or signed, and bitwise operators may have implementation-dependent results when performed on signed operands, declare 'u8 *' operand instead. Suggested-by: Davide Caratti Signed-off-by: Roman Mashak --- net/sched/act_pedit.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 net-next 4/6] net sched actions: use sizeof operator for buffer length

2018-06-27 Thread Roman Mashak
Replace constant integer with sizeof() to clearly indicate the destination buffer length in skb_header_pointer() calls. Reviewed-by: Simon Horman Signed-off-by: Roman Mashak --- net/sched/act_pedit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/act_pedit.c

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Yuchung Cheng
On Wed, Jun 27, 2018 at 8:24 AM, Neal Cardwell wrote: > On Tue, Jun 26, 2018 at 10:34 PM Lawrence Brakmo wrote: >> The only issue is if it is safe to always use 2 or if it is better to >> use min(2, snd_ssthresh) (which could still trigger the problem). > > Always using 2 SGTM. I don't think we

Re: [patch net-next 0/9] net: sched: introduce chain templates support with offloading to mlxsw

2018-06-27 Thread Cong Wang
On Wed, Jun 27, 2018 at 9:46 AM Samudrala, Sridhar wrote: > > On 6/27/2018 12:50 AM, Jiri Pirko wrote: > > if you don't like "tc filter template add dev dummy0 ingress", how > > about: > > "tc template add dev dummy0 ingress ..." > > "tc template add dev dummy0 ingress chain 22 ..." > > that

[PATCH v2 net-next 3/6] net sched actions: fix sparse warning

2018-06-27 Thread Roman Mashak
The variable _data in include/asm-generic/sections.h defines sections, this causes sparse warning in pedit: net/sched/act_pedit.c:293:35: warning: symbol '_data' shadows an earlier one ./include/asm-generic/sections.h:36:13: originally declared here Therefore rename the variable. Reviewed-by:

[PATCH v2 net-next 2/6] net sched actions: fix coding style in pedit headers

2018-06-27 Thread Roman Mashak
Fix coding style issues in tc pedit headers detected by the checkpatch script. Reviewed-by: Simon Horman Signed-off-by: Roman Mashak --- include/net/tc_act/tc_pedit.h| 1 + include/uapi/linux/tc_act/tc_pedit.h | 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v7 03/11] net: pch_gbe: Probe PHY ID & initialize only once

2018-06-27 Thread Andrew Lunn
> This is actually needed because pch_gbe_check_options() sets up, amongst > other things, the autoneg_advertised field in struct pch_gbe_phy_info > and that needs to happen before pch_gbe_phy_init_setting() is called. Hi Paul Please add a comment to the commit message about this. Andrew

[PATCH v2 net-next 5/6] net sched actions: fix misleading text strings in pedit action

2018-06-27 Thread Roman Mashak
Change "tc filter pedit .." to "tc actions pedit .." in error messages to clearly refer to pedit action. Reviewed-by: Simon Horman Signed-off-by: Roman Mashak --- net/sched/act_pedit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/sched/act_pedit.c

Re: [Patch net-next v3 1/3] net: introduce helper dev_change_tx_queue_len()

2018-06-27 Thread Cong Wang
On Wed, Jun 27, 2018 at 9:14 AM Eric Dumazet wrote: > > > > On 01/25/2018 06:26 PM, Cong Wang wrote: > > This patch promotes the local change_tx_queue_len() to a core > > helper function, dev_change_tx_queue_len(), so that rtnetlink > > and net-sysfs could share the code. This also prepares for

Re: [PATCH v7 09/11] net: pch_gbe: Convert to mdiobus and phylib

2018-06-27 Thread Andrew Lunn
> @@ -5,7 +5,8 @@ > config PCH_GBE > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" > depends on PCI && (X86_32 || COMPILE_TEST) > - select MII > + select PHYLIB > + imply AT803X_PHY if X86_32 > select PTP_1588_CLOCK_PCH > select NET_PTP_CLASSIFY That is

Re: [PATCH v7 09/11] net: pch_gbe: Convert to mdiobus and phylib

2018-06-27 Thread Paul Burton
Hi Andrew, On Wed, Jun 27, 2018 at 07:51:44PM +0200, Andrew Lunn wrote: > > @@ -5,7 +5,8 @@ > > config PCH_GBE > > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" > > depends on PCI && (X86_32 || COMPILE_TEST) > > - select MII > > + select PHYLIB > > + imply AT803X_PHY if

Re: [PATCH net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2

2018-06-27 Thread Felix Manlunas
On Tue, Jun 26, 2018 at 09:03:25AM -0700, Shannon Nelson wrote: > On 6/26/2018 4:58 AM, Felix Manlunas wrote: > > From: Rick Farrington > > > > Pre-1.7.2 NIC firmware does not support (and does not respond to) the "get > > speed" command which is sent by the 1.7.2 driver during modprobe. Due to

[PATCH 2/2] net: phy: DP83TC811: Fix SGMII enable/disable

2018-06-27 Thread Dan Murphy
If SGMII was selected in the DT then the device should write the SGMII enable bit. If SGMII is not selected in the DT then the SGMII bit should be disabled. Signed-off-by: Dan Murphy --- arch/arm/configs/omap2plus_defconfig | 1 + drivers/net/phy/dp83tc811.c | 20 +---

[PATCH 1/2] net: phy: DP83TC811: Add INT_STAT3

2018-06-27 Thread Dan Murphy
Add INT_STAT3 interrupt setting and clearing. Also fixed writing to INT_STAT2 when disabling the interrupts as there was a double write to INT_STAT1. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83tc811.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-)

Re: [patch net-next 0/9] net: sched: introduce chain templates support with offloading to mlxsw

2018-06-27 Thread Jakub Kicinski
On Wed, 27 Jun 2018 09:50:17 +0200, Jiri Pirko wrote: > Tue, Jun 26, 2018 at 11:18:58PM CEST, jakub.kicin...@netronome.com wrote: > >On Tue, 26 Jun 2018 09:12:17 +0200, Jiri Pirko wrote: > >> Tue, Jun 26, 2018 at 09:00:45AM CEST, jakub.kicin...@netronome.com wrote: > >> >On Mon, Jun 25, 2018

[PATCH iproute2] man: Fix typos on tc-cbs

2018-06-27 Thread Jesus Sanchez-Palencia
Signed-off-by: Jesus Sanchez-Palencia --- man/man8/tc-cbs.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-cbs.8 b/man/man8/tc-cbs.8 index 32e1e0d4..ad1d8821 100644 --- a/man/man8/tc-cbs.8 +++ b/man/man8/tc-cbs.8 @@ -28,7 +28,7 @@ defined rate limiting method

Re: [RFC bpf-next 6/6] samples/bpf: Add meta data hash example to xdp_redirect_cpu

2018-06-27 Thread Saeed Mahameed
On Wed, 2018-06-27 at 12:59 +0200, Jesper Dangaard Brouer wrote: > On Tue, 26 Jun 2018 19:46:15 -0700 > Saeed Mahameed wrote: > > > Add a new program (prog_num = 4) that will not parse packets and > > will > > use the meta data hash to spread/redirect traffic into different > > cpus. > > You

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Paul Burton
Hi Florian, On Wed, Jun 27, 2018 at 10:54:24AM -0700, Florian Fainelli wrote: > On 06/26/2018 05:06 PM, Paul Burton wrote: > > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > > including both the

Re: [PATCH bpf 3/4] samples/bpf: deal with EBUSY return code from sendmsg in xdpsock sample

2018-06-27 Thread Song Liu
On Wed, Jun 27, 2018 at 7:02 AM, Magnus Karlsson wrote: > Sendmsg in the SKB path of AF_XDP can now return EBUSY when a packet > was discarded and completed by the driver. Just ignore this message > in the sample application. > > Fixes: b4b8faa1ded7 ("samples/bpf: sample application and

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Florian Fainelli
On 06/26/2018 05:06 PM, Paul Burton wrote: > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > including both the AR8031 used by the Minnowboard & the RTL8211E used by > the MIPS Boston development

Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure

2018-06-27 Thread Saeed Mahameed
On Wed, 2018-06-27 at 16:15 +0200, Jesper Dangaard Brouer wrote: > On Tue, 26 Jun 2018 19:46:11 -0700 > Saeed Mahameed wrote: > > > diff --git a/include/net/xdp.h b/include/net/xdp.h > > index 2deea7166a34..afe302613ae1 100644 > > --- a/include/net/xdp.h > > +++ b/include/net/xdp.h > > @@ -138,6

Re: [PATCH v7 11/11] net: pch_gbe: Allow build on MIPS platforms

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:12PM -0700, Paul Burton wrote: > Allow the pch_gbe driver to be built on MIPS platforms, allowing its use > on the MIPS Boston development board. > > Signed-off-by: Paul Burton > Cc: Andrew Lunn > Cc: David S. Miller > Cc: netdev@vger.kernel.org > > --- > >

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Paul Burton
Hi Andrew, On Wed, Jun 27, 2018 at 07:30:14PM +0200, Andrew Lunn wrote: > On Tue, Jun 26, 2018 at 05:06:07PM -0700, Paul Burton wrote: > > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > >

Re: [PATCH bpf 2/4] xsk: frame could be completed more than once in SKB path

2018-06-27 Thread Song Liu
On Wed, Jun 27, 2018 at 7:02 AM, Magnus Karlsson wrote: > Fixed a bug in which a frame could be completed more than once > when an error was returned from dev_direct_xmit(). The code > erroneously retried sending the message leading to multiple > calls to the SKB destructor and therefore multiple

Re: [PATCH net-next 1/1] tc-testing: initial version of tunnel_key unit tests

2018-06-27 Thread Lucas Bates
On Tue, Jun 26, 2018 at 10:51 AM, Davide Caratti wrote: > On Tue, 2018-06-26 at 09:17 -0400, Keara Leibovitz wrote: >> Create unittests for the tc tunnel_key action. >> >> >> Signed-off-by: Keara Leibovitz >> --- >> .../tc-testing/tc-tests/actions/tunnel_key.json| 676 >>

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-27 Thread Grygorii Strashko
On 06/22/2018 02:45 AM, Ilias Apalodimas wrote: > On Thu, Jun 21, 2018 at 05:31:31PM +0200, Arnd Bergmann wrote: >> On Thu, Jun 21, 2018 at 2:45 PM, Ilias Apalodimas >> wrote: >>> On Thu, Jun 21, 2018 at 02:19:55PM +0200, Ivan Vecera wrote: >> >>> The driver is currently widely used and that's

Re: [PATCH v7 10/11] ptp: pch: Allow build on MIPS platforms

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:11PM -0700, Paul Burton wrote: > Allow the ptp_pch driver to be built on MIPS platforms in preparation > for use on the MIPS Boston board. > > Signed-off-by: Paul Burton > Acked-by: Richard Cochran > Cc: Andrew Lunn > Cc: David S. Miller > Cc:

Re: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-27 Thread Or Gerlitz
On Wed, Jun 27, 2018 at 1:31 AM, Jakub Kicinski wrote: > On Tue, 26 Jun 2018 17:57:08 +0300, Or Gerlitz wrote: >> 2. re the egress side of things. Some NIC HWs can't just use LAG >> as the egress port destination of an ACL (tc rule) and the HW rule >> needs to be duplicated to both HW ports.

Re: [PATCH bpf 4/4] xsk: fix potential race in SKB TX completion code

2018-06-27 Thread Daniel Borkmann
On 06/27/2018 05:55 PM, Eric Dumazet wrote: > On 06/27/2018 07:02 AM, Magnus Karlsson wrote: >> There was a potential race in the TX completion code for >> the SKB case when the TX napi thread and the error path >> of the sendmsg code could both call the SKB destructor >> at the same time. Fixed

[PATCH net-next 3/4] ila: Create main ila source file

2018-06-27 Thread Tom Herbert
Create a main ila file that contains the module initialization functions as well as netlink definitions. Previously these were defined in ila_xlat and ila_common. This approach allows better extensibility. Signed-off-by: Tom Herbert --- net/ipv6/ila/Makefile | 2 +- net/ipv6/ila/ila.h

[PATCH net-next 2/4] ila: Call library function alloc_bucket_locks

2018-06-27 Thread Tom Herbert
To allocate the array of bucket locks for the hash table we now call library function alloc_bucket_spinlocks. Signed-off-by: Tom Herbert --- net/ipv6/ila/ila_xlat.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/net/ipv6/ila/ila_xlat.c

[PATCH net-next 4/4] ila: Flush netlink command to clear xlat table

2018-06-27 Thread Tom Herbert
Add ILA_CMD_FLUSH netlink command to clear the ILA translation table. Signed-off-by: Tom Herbert --- include/uapi/linux/ila.h | 1 + net/ipv6/ila/ila.h | 1 + net/ipv6/ila/ila_main.c | 6 + net/ipv6/ila/ila_xlat.c | 62 ++-- 4 files

[PATCH net-next 1/4] ila: Fix use of rhashtable walk in ila_xlat.c

2018-06-27 Thread Tom Herbert
Perform better EAGAIN handling, handle case where ila_dump_info fails and we missed objects in the dump, and add a skip index to skip over ila entires in a list on a rhashtable node that have already been visited (by a previous call to ila_nl_dump). Signed-off-by: Tom Herbert ---

[PATCH net-next 0/4] ila: Cleanup

2018-06-27 Thread Tom Herbert
Perform some cleanup in ILA code. This includes: - Fix rhashtable walk for cases where nl dumps are done with muliple function calls. Add a skip index to skip over entries in a node that have been previously visitied. Call rhashtable_walk_peek to avoid dropping items between calls to

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-27 Thread Arnd Bergmann
On Wed, Jun 27, 2018 at 9:18 PM, Grygorii Strashko wrote: > On 06/22/2018 02:45 AM, Ilias Apalodimas wrote: >> On Thu, Jun 21, 2018 at 05:31:31PM +0200, Arnd Bergmann wrote: >>> On Thu, Jun 21, 2018 at 2:45 PM, Ilias Apalodimas >>> wrote: On Thu, Jun 21, 2018 at 02:19:55PM +0200, Ivan

Re: [PATCH net-next 2/3] rds: Enable RDS IPv6 support

2018-06-27 Thread Santosh Shilimkar
On 6/27/2018 3:07 AM, Ka-Cheong Poon wrote: On 06/26/2018 09:08 PM, Sowmini Varadhan wrote: On (06/26/18 21:02), Ka-Cheong Poon wrote: [...] I don't expect RDS apps will want to use link local address in the first place.  In fact, most normal network apps don't. This is not true.

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-27 Thread Grygorii Strashko
On 06/18/2018 12:49 PM, Ilias Apalodimas wrote: > On Mon, Jun 18, 2018 at 07:30:25PM +0200, Andrew Lunn wrote: >> On Mon, Jun 18, 2018 at 07:46:02PM +0300, Ilias Apalodimas wrote: >>> On Mon, Jun 18, 2018 at 06:28:36PM +0200, Andrew Lunn wrote: > Yes, if the CPU port is added on the VLAN

[PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add the BGX nexus architeture for Octeon III BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- .../net/ethernet/cavium/octeon/octeon3-bgx-nexus.c | 670 + drivers/net/ethernet/cavium/octeon/octeon3-bgx.h | 281 + 2

[PATCH v12 07/10] netdev: cavium: octeon: Add Octeon III SSO Support

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add support for Octeon III SSO logic block for BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-sso.c | 221 +++ drivers/net/ethernet/cavium/octeon/octeon3-sso.h | 89 + 2

[PATCH v12 00/10] netdev: octeon-ethernet: Add Cavium Octeon III support.

2018-06-27 Thread Steven J. Hill
Add the Cavium OCTEON III network driver. There are some corresponding MIPS architecture support changes which will be upstreamed separately. Changes in v12: o Complete reorganization of driver files and defined all bitfields used in the driver. o Implemented suggested changes from Andrew

[PATCH v12 05/10] netdev: cavium: octeon: Add Octeon III PKI Support

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add support for Octeon III PKI logic block for BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-pki.c | 789 +++ drivers/net/ethernet/cavium/octeon/octeon3-pki.h | 113 2 files

Re: Fwd: [PATCH 0/6] offload Linux LAG devices to the TC datapath

2018-06-27 Thread Or Gerlitz
On Tue, Jun 26, 2018 at 9:16 PM, John Hurley wrote: > On Tue, Jun 26, 2018 at 3:57 PM, Or Gerlitz wrote: >>> Forwarded Message >>> Subject: [PATCH 0/6] offload Linux LAG devices to the TC datapath >>> Date: Thu, 21 Jun 2018 14:35:55 +0100 >>> From: John Hurley >>> To:

[PATCH v12 04/10] netdev: cavium: octeon: Add Octeon III BGX Ports

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add individual BGX nexus port support for Octeon III BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- .../net/ethernet/cavium/octeon/octeon3-bgx-port.c | 2192 1 file changed, 2192 insertions(+) create mode 100644

[PATCH v12 08/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet core

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz This is the main core of the BGX Ethernet driver. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-core.c | 2363 + 1 file changed, 2363 insertions(+) create mode 100644

[PATCH v12 09/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet building

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add the build and configuration files for the BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/Kconfig | 22 +- drivers/net/ethernet/cavium/octeon/Makefile | 8 +++- 2 files changed, 28

[PATCH v12 06/10] netdev: cavium: octeon: Add Octeon III PKO Support

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add support for Octeon III PKO logic block for BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-pko.c | 1638 ++ drivers/net/ethernet/cavium/octeon/octeon3-pko.h | 159 +++ 2 files

[PATCH v12 02/10] netdev: cavium: octeon: Header for Octeon III BGX Ethernet

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add the common header file used by the Octeon III BGX Ethernet driver. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-bgx.h | 150 +++ drivers/net/ethernet/cavium/octeon/octeon3.h | 330

[PATCH v12 10/10] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2018-06-27 Thread Steven J. Hill
From: David Daney Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 99e5cef..378009c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3279,6 +3279,12 @@ W: http://www.cavium.com S: Supported F:

[PATCH v12 01/10] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2018-06-27 Thread Steven J. Hill
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- .../devicetree/bindings/net/cavium-bgx.txt | 59 ++ 1 file changed, 59 insertions(+) create mode 100644

Re: [PATCH net-next] mlx4: do not use rwlock in fast path

2018-06-27 Thread Eric Dumazet
On 06/27/2018 05:11 AM, Tariq Toukan wrote: > > > On 09/02/2017 7:10 PM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> Using a reader-writer lock in fast path is silly, when we can >> instead use RCU or a seqlock. >> >> For mlx4 hwstamp clock, a seqlock is the way to go, removing >> two

[BISECTED] [4.17.0-rc6] IPv6 link-local address not getting added

2018-06-27 Thread Sowmini Varadhan
Hi David, An IPv6 regression has been introduced in 4.17.0-rc6 by 8308f3f net/ipv6: Add support for specifying metric of connected routes The regression is that some interfaces on my test machine come up with link-local addrs but the fe80 prefix is missing. After this bug, I cannot send any

Re: [PATCH net-next] net: qmi_wwan: Add pass through mode

2018-06-27 Thread Subash Abhinov Kasiviswanathan
The concepte looks fine to me, but I have a few comments to the implementation below. First: I missed the last part of the discussion around automatic detection of passthrough mode. Could you give us a short summary of the alternatives you tried and why they were dropped? Hi Bjørn The

Re: [net-next PATCH v4 1/7] net: Refactor XPS for CPUs and Rx queues

2018-06-27 Thread Nambiar, Amritha
On 6/26/2018 3:53 PM, Tom Herbert wrote: > On Mon, Jun 25, 2018 at 11:04 AM, Amritha Nambiar > wrote: >> Refactor XPS code to support Tx queue selection based on >> CPU(s) map or Rx queue(s) map. >> >> Signed-off-by: Amritha Nambiar >> --- >> include/linux/cpumask.h | 11 ++ >>

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

2018-06-27 Thread Nambiar, Amritha
On 6/27/2018 3:47 AM, Willem de Bruijn wrote: +static int get_xps_queue(struct net_device *dev, struct sk_buff *skb) { #ifdef CONFIG_XPS struct xps_dev_maps *dev_maps; - struct xps_map *map; + struct sock *sk = skb->sk; int

Re: [BISECTED] [4.17.0-rc6] IPv6 link-local address not getting added

2018-06-27 Thread David Ahern
On 6/27/18 6:35 PM, Sowmini Varadhan wrote: > > Hi David, > > An IPv6 regression has been introduced in 4.17.0-rc6 by > 8308f3f net/ipv6: Add support for specifying metric of connected routes > > The regression is that some interfaces on my test machine come > up with link-local addrs but the

[PATCH net] net: fib_rules: add protocol check in rule_find

2018-06-27 Thread Roopa Prabhu
From: Roopa Prabhu After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule"), rule_find is strict about checking for an existing rule. rule_find must check against all user given attributes, else it may match against a subset of attributes and return

  1   2   >