Re: [PATCH v2 net] net/ipv6: Revert attempt to simplify route replace and append

2018-07-04 Thread David Miller
From: dsah...@kernel.org Date: Tue, 3 Jul 2018 14:36:21 -0700 > From: David Ahern > > NetworkManager likes to manage linklocal prefix routes and does so with > the NLM_F_APPEND flag, breaking attempts to simplify the IPv6 route > code and by extension enable multipath routes with device only

[PATCH net] net: mv __dev_notify_flags from void to int

2018-07-04 Thread Hangbin Liu
As call_netdevice_notifiers() and call_netdevice_notifiers_info() have return values, we should also return the values in function __dev_notify_flags(). Signed-off-by: Hangbin Liu --- include/linux/netdevice.h | 2 +- net/core/dev.c| 30 -- 2 files

Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append

2018-07-04 Thread David Miller
From: Ido Schimmel Date: Thu, 5 Jul 2018 00:10:41 +0300 > We can have the IPv4/IPv6 code only generate a REPLACE / DELETE > notification for routes that are actually used for forwarding and > relieve listeners from the need to implement this logic themselves. I > think this should work. Whilst

Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append

2018-07-04 Thread Ido Schimmel
On Tue, Jul 03, 2018 at 02:02:06PM -0600, David Ahern wrote: > It is unfortunate that mlxsw has to replicate the node lookup code. The kernel can store multiple routes with the same prefix/length, but only one is used for forwarding. Thus when a route is deleted it should be potentially

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

2018-07-04 Thread Russell King - ARM Linux
Subject says offlist, but this isn't... On Wed, Jul 04, 2018 at 08:33:20AM +0100, Peter Robinson wrote: > Sorry for the delay on this from my end. I noticed there was some bpf > bits land in the last net fixes pull request landed Monday so I built > a kernel with the JIT reenabled. It seems it's

Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append

2018-07-04 Thread David Ahern
On 7/4/18 8:29 PM, David Miller wrote: > From: Ido Schimmel > Date: Thu, 5 Jul 2018 00:10:41 +0300 > >> We can have the IPv4/IPv6 code only generate a REPLACE / DELETE >> notification for routes that are actually used for forwarding and >> relieve listeners from the need to implement this logic

Re: [PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-04 Thread David Miller
From: Heiner Kallweit Date: Tue, 3 Jul 2018 22:34:54 +0200 > Currently also the pause flags are removed from phydev->supported because > they're not included in PHY_DEFAULT_FEATURES. I don't think this is > intended, especially when considering that this function can be called > via

Re: [PATCH net] net: mv __dev_notify_flags from void to int

2018-07-04 Thread David Miller
From: Hangbin Liu Date: Wed, 4 Jul 2018 14:29:46 +0800 > @@ -7062,8 +7073,7 @@ int dev_change_flags(struct net_device *dev, unsigned > int flags) > return ret; > > changes = (old_flags ^ dev->flags) | (old_gflags ^ dev->gflags); > - __dev_notify_flags(dev, old_flags,

Re: [PATCH net-next] net: ipv4: fix drop handling in ip_list_rcv() and ip_list_rcv_finish()

2018-07-04 Thread David Miller
From: Edward Cree Date: Wed, 4 Jul 2018 19:23:50 +0100 > Since callees (ip_rcv_core() and ip_rcv_finish_core()) might free or steal > the skb, we can't use the list_cut_before() method; we can't even do a > list_del(>list) in the drop case, because skb might have already been > freed and

Re: [PATCH net] qed: Fix reading stale configuration information

2018-07-04 Thread David Miller
From: Denis Bolotin Date: Wed, 4 Jul 2018 17:06:46 +0300 > Configuration information read at driver load can become stale after it is > updated. Mark information as not valid and re-populate when this happens. > > Signed-off-by: Denis Bolotin > Signed-off-by: Ariel Elior Applied.

[PATCH net-next 4/4] vxlan: fix default fdb entry netlink notify ordering during netdev create

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function also notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same

[PATCH net-next 3/4] vxlan: make netlink notify in vxlan_fdb_destroy optional

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu Add a new option do_notify to vxlan_fdb_destroy to make sending netlink notify optional. Used by a later patch. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c

[PATCH net-next 1/4] rtnetlink: add rtnl_link_state check in rtnl_configure_link

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu rtnl_configure_link sets dev->rtnl_link_state to RTNL_LINK_INITIALIZED and unconditionally calls __dev_notify_flags to notify user-space of dev flags. current call sequence for rtnl_configure_link rtnetlink_newlink rtnl_link_ops->newlink rtnl_configure_link

[PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex).

[PATCH net-next 2/4] vxlan: add new fdb alloc and create helpers

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu - Add new vxlan_fdb_alloc helper - rename existing vxlan_fdb_create into vxlan_fdb_update: because it really creates or updates an existing fdb entry - move new fdb creation into a separate vxlan_fdb_create Main motivation for this change is to introduce the

Re: [PATCH net-next] r8169: fix runtime suspend

2018-07-04 Thread David Miller
From: Heiner Kallweit Date: Wed, 4 Jul 2018 21:11:29 +0200 > When runtime-suspending we configure WoL w/o touching saved_wolopts. > If saved_wolopts == 0 we would power down the PHY in this case what's > wrong. Therefore we have to check the actual chip WoL settings here. > > Fixes:

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

2018-07-04 Thread Daniel Borkmann
On 07/04/2018 09:33 AM, Peter Robinson wrote: > On Tue, Jun 26, 2018 at 1:52 PM, Daniel Borkmann wrote: >> On 06/26/2018 02:23 PM, Peter Robinson wrote: >> On 06/24/2018 11:24 AM, Peter Robinson wrote: > I'm seeing this netlink/sk_filter_trim_cap crash on ARMv7 across quite >

Re: [PATCH][net-next] net: limit each hash list length to MAX_GRO_SKBS

2018-07-04 Thread David Miller
From: Li RongQing Date: Wed, 4 Jul 2018 16:42:48 +0800 > @@ -4989,10 +4988,11 @@ static int napi_gro_complete(struct sk_buff *skb) > return netif_receive_skb_internal(skb); > } > > -static void __napi_gro_flush_chain(struct napi_struct *napi, struct > list_head *head, > +static void

[PATCH net-next] cxgb4: Fix the condition to check if the card is T5

2018-07-04 Thread Ganesh Goudar
Use 'chip_ver' rather than 'chip' to check if the card is T5. Fixes: e8d452923ae6 ("cxgb4: clean up init_one") Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] epic100: remove redundant variable 'irq'

2018-07-04 Thread Colin King
From: Colin Ian King Variable 'irq' is being assigned but is never used hence it is and can be removed. Cleans up clang warning: warning: variable 'irq' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- drivers/net/ethernet/smsc/epic100.c | 2 -- 1 file changed,

Re: [PATCH v5 net-next] net:sched: add action inheritdsfield to skbedit

2018-07-04 Thread David Miller
From: Qiaobin Fu Date: Sun, 1 Jul 2018 15:16:27 -0400 > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->priority. This enables > later classification of packets based on the DS field. > > v5: > *Update the drop counter for TC_ACT_SHOT > > v4: > *Not

Re: [PATCHv2 net] sctp: fix the issue that pathmtu may be set lower than MINSEGMENT

2018-07-04 Thread David Miller
From: Xin Long Date: Tue, 3 Jul 2018 16:30:47 +0800 > After commit b6c5734db070 ("sctp: fix the handling of ICMP Frag Needed > for too small MTUs"), sctp_transport_update_pmtu would refetch pathmtu > from the dst and set it to transport's pathmtu without any check. > > The new pathmtu may be

Re: [PATCH net-next 0/2] bridge: iproute2 isolated port and selftests

2018-07-04 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 3 Jul 2018 15:42:41 +0300 > Add support to iproute2 for port isolation config and selftests for it. Series applied, thanks Nikolay.

Re: [PATCHv2 net] sctp: fix the issue that pathmtu may be set lower than MINSEGMENT

2018-07-04 Thread Neil Horman
On Tue, Jul 03, 2018 at 04:30:47PM +0800, Xin Long wrote: > After commit b6c5734db070 ("sctp: fix the handling of ICMP Frag Needed > for too small MTUs"), sctp_transport_update_pmtu would refetch pathmtu > from the dst and set it to transport's pathmtu without any check. > > The new pathmtu may

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

2018-07-04 Thread Peter Robinson
On Tue, Jun 26, 2018 at 1:52 PM, Daniel Borkmann wrote: > On 06/26/2018 02:23 PM, Peter Robinson wrote: > On 06/24/2018 11:24 AM, Peter Robinson wrote: I'm seeing this netlink/sk_filter_trim_cap crash on ARMv7 across quite a few ARMv7 platforms on Fedora with 4.18rc1. I've

[PATCH net] qed: off by one in qed_parse_mcp_trace_buf()

2018-07-04 Thread Dan Carpenter
If format_idx == s_mcp_trace_meta.formats_num then we read one element beyond the end of the s_mcp_trace_meta.formats[] array. Fixes: 50bc60cb155c ("qed*: Utilize FW 8.33.11.0") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c

[PATCH net] ixgbe: Off by one in ixgbe_ipsec_tx()

2018-07-04 Thread Dan Carpenter
The ipsec->tx_tbl[] has IXGBE_IPSEC_MAX_SA_COUNT elements so the > needs to be changed to >= so we don't read one element beyond the end of the array. Fixes: 592594704761 ("ixgbe: process the Tx ipsec offload") Signed-off-by: Dan Carpenter diff --git

RE: [PATCH net] qed: off by one in qed_parse_mcp_trace_buf()

2018-07-04 Thread Tayar, Tomer
From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, July 04, 2018 12:53 PM > If format_idx == s_mcp_trace_meta.formats_num then we read one element > beyond the end of the s_mcp_trace_meta.formats[] array. > > Fixes: 50bc60cb155c ("qed*: Utilize FW 8.33.11.0") > Signed-off-by:

[PATCH][net-next] net: limit each hash list length to MAX_GRO_SKBS

2018-07-04 Thread Li RongQing
After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash table.")' there is 8 hash buckets, which allows more flows to be held for merging. but MAX_GRO_SKBS, the total held skb for merging, is 8 skb still, limit the hash table performance. keep MAX_GRO_SKBS as 8 skb, but limit

Re: [RFC bpf-next 2/6] net: xdp: RX meta data infrastructure

2018-07-04 Thread Daniel Borkmann
On 07/04/2018 02:57 AM, Saeed Mahameed wrote: > On Tue, 2018-07-03 at 16:01 -0700, Alexei Starovoitov wrote: [...] >> How about we make driver+firmware provide a BTF definition of >> metadata that they >> can provide? There can be multiple definitions of such structs. >> Then in userpsace we can

Re: [net-next, v6, 6/7] net-sysfs: Add interface for Rx queue(s) map per Tx queue

2018-07-04 Thread Andrei Vagin
Hello Amritha, I see a following warning on 4.18.0-rc3-next-20180703. It looks like a problem is in this series. [1.084722] [1.084797] WARNING: possible recursive locking detected [1.084872] 4.18.0-rc3-next-20180703+ #1 Not tainted [

Re: [RFC bpf-next 5/6] net/mlx5e: Add XDP RX meta data support

2018-07-04 Thread Daniel Borkmann
On 06/27/2018 04:46 AM, Saeed Mahameed wrote: [...] > @@ -935,11 +958,16 @@ static inline bool mlx5e_xdp_handle(struct mlx5e_rq *rq, > return false; > > xdp.data = va + *rx_headroom; > - xdp_set_data_meta_invalid(); > xdp.data_end = xdp.data + *len; >

[PATCH net-next] cxgb4: Add support to read actual provisioned resources

2018-07-04 Thread Ganesh Goudar
From: Casey Leedom In highly constrained resources environments (like the 124VF T5 and 248VF T6 configurations), PF4 may not have very many resources at all and we need to adapt to whatever we've been allocated, this patch adds support to get the provisioned resources. Signed-off-by: Casey

Re: [PATCH v4 net-next 7/9] net: ipv4: listified version of ip_rcv

2018-07-04 Thread Edward Cree
On 02/07/18 16:14, Edward Cree wrote: > +/* Receive a list of IP packets */ > +void ip_list_rcv(struct list_head *head, struct packet_type *pt, > + struct net_device *orig_dev) > +{ > + struct net_device *curr_dev = NULL; > + struct net *curr_net = NULL; > + struct sk_buff

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-04 Thread Andrew Lunn
On Mon, Jul 02, 2018 at 11:54:54PM +0200, Heiner Kallweit wrote: > On 02.07.2018 23:21, Andrew Lunn wrote: > >> - auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; > > > > This bit you probably want to keep. The PHY never says it support > > Pause. The MAC needs to enable pause if

Re: [PATCH net-next] net: sched: act_pedit: fix possible memory leak in tcf_pedit_init()

2018-07-04 Thread David Miller
From: Wei Yongjun Date: Tue, 3 Jul 2018 13:45:12 + > 'keys_ex' is malloced by tcf_pedit_keys_ex_parse() in tcf_pedit_init() > but not all of the error handle path free it, this may cause memory > leak. This patch fix it. > > Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative

Re: [PATCH v2] net: usb: asix: allow optionally getting mac address from device tree

2018-07-04 Thread David Miller
From: Marcel Ziswiler Date: Tue, 3 Jul 2018 17:06:49 +0200 > From: Marcel Ziswiler > > For Embedded use where e.g. AX88772B chips may be used without external > EEPROMs the boot loader may choose to pass the MAC address to be used > via device tree. Therefore, allow for optionally getting the

Re: [PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-04 Thread Andrew Lunn
On Tue, Jul 03, 2018 at 10:34:54PM +0200, Heiner Kallweit wrote: > Currently also the pause flags are removed from phydev->supported because > they're not included in PHY_DEFAULT_FEATURES. I don't think this is > intended, especially when considering that this function can be called > via

[PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-07-04 Thread Matteo Croce
From: Stefano Brivio Open vSwitch sends to userspace all received packets that have no associated flow (thus doing an "upcall"). Then the userspace program creates a new flow and determines the actions to apply based on its configuration. When a single port generates a high rate of upcalls, it

Re: [PATCH net] smsc75xx: Add workaround for gigabit link up hardware errata.

2018-07-04 Thread David Miller
From: Yuiko Oshino Date: Tue, 3 Jul 2018 11:21:46 -0400 > In certain conditions, the device may not be able to link in gigabit mode. > This software workaround ensures that the device will not enter the failure > state. > > Fixes: d0cad871703b898a442e4049c532ec39168e5b57 ("SMSC75XX USB 2.0

[PATCH net-next 07/18] tls: Split tls_sw_release_resources_rx

2018-07-04 Thread Boris Pismenny
This patch splits tls_sw_release_resources_rx into two functions one which releases all inner software tls structures and another that also frees the containing structure. In TLS_DEVICE we will need to release the software structures without freeeing the containing structure, which contains other

[PATCH net-next 08/18] tls: Fill software context without allocation

2018-07-04 Thread Boris Pismenny
This patch allows tls_set_sw_offload to fill the context in case it was already allocated previously. We will use it in TLS_DEVICE to fill the RX software context. Signed-off-by: Boris Pismenny --- net/tls/tls_sw.c | 34 ++ 1 file changed, 22 insertions(+), 12

[PATCH net-next 00/18] TLS offload rx, netdev & mlx5

2018-07-04 Thread Boris Pismenny
Hi, This series completes the generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip decryption and authentication operations for SKBs marked as decrypted on the receive side of the data path. Leaving those computationally expensive operations

[PATCH net-next 11/18] net/mlx5: Accel, add TLS rx offload routines

2018-07-04 Thread Boris Pismenny
In Innova TLS, TLS contexts are added or deleted via a command message over the SBU connection. The HW then sends a response message over the same connection. Complete the implementation for Innova TLS (FPGA-based) hardware by adding support for rx inline crypto offload. Signed-off-by: Boris

[PATCH net-next 06/18] tls: Split decrypt_skb to two functions

2018-07-04 Thread Boris Pismenny
Previously, decrypt_skb also updated the TLS context. Now, decrypt_skb only decrypts the payload using the current context, while decrypt_skb_update also updates the state. Later, in the tls_device Rx flow, we will use decrypt_skb directly. Signed-off-by: Boris Pismenny --- include/net/tls.h |

[PATCH net-next 16/18] net/mlx5: Accel, add common metadata functions

2018-07-04 Thread Boris Pismenny
This patch adds common functions to handle mellanox metadata headers. These functions are used by IPsec and TLS to process FPGA metadata. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/accel/accel.h | 37

[PATCH net-next 05/18] tls: Refactor tls_offload variable names

2018-07-04 Thread Boris Pismenny
For symmetry, we rename tls_offload_context to tls_offload_context_tx before we add tls_offload_context_rx. Signed-off-by: Boris Pismenny --- include/net/tls.h | 16 net/tls/tls_device.c | 26 +- net/tls/tls_device_fallback.c | 8

Re: [PATCH v2 net-next 00/14] Scheduled packet Transmission: ETF

2018-07-04 Thread David Miller
From: Jesus Sanchez-Palencia Date: Tue, 3 Jul 2018 15:42:46 -0700 > Overview > > > This work consists of a set of kernel interfaces that can be used by > applications that require (time-based) Scheduled Tx of packets. > It is comprised by 3 new components to the kernel: > > -

[PATCH v2 2/4] samples/bpf: Check the result of system()

2018-07-04 Thread Taeung Song
To avoid the below build warning message, use new generate_load() checking the return value. ignoring return value of ‘system’, declared with attribute warn_unused_result And it also refactors the duplicate code of both test_perf_event_all_cpu() and test_perf_event_task() Cc: Teng Qin

[PATCH v2 4/4] samples/bpf: add .gitignore file

2018-07-04 Thread Taeung Song
For untracked executables of samples/bpf, add this. Untracked files: (use "git add ..." to include in what will be committed) samples/bpf/cpustat samples/bpf/fds_example samples/bpf/lathist samples/bpf/load_sock_ops ... Signed-off-by: Taeung Song

[PATCH net] qed: Fix reading stale configuration information

2018-07-04 Thread Denis Bolotin
Configuration information read at driver load can become stale after it is updated. Mark information as not valid and re-populate when this happens. Signed-off-by: Denis Bolotin Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 1 +

[PATCH net-next 09/18] tls: Add rx inline crypto offload

2018-07-04 Thread Boris Pismenny
This patch completes the generic infrastructure to offload TLS crypto to a network device. It enables the kernel to skip decryption and authentication of some skbs marked as decrypted by the NIC. In the fast path, all packets received are decrypted by the NIC and the performance is comparable to

Re: [PATCH] rhashtable: add restart routine in rhashtable_free_and_destroy()

2018-07-04 Thread Taehee Yoo
2018-07-04 14:45 GMT+09:00 Herbert Xu : > On Tue, Jul 03, 2018 at 10:19:09PM +0900, Taehee Yoo wrote: >> >> diff --git a/lib/rhashtable.c b/lib/rhashtable.c >> index 0e04947..8ea27fa 100644 >> --- a/lib/rhashtable.c >> +++ b/lib/rhashtable.c >> @@ -1134,6 +1134,7 @@ void

[PATCH net-next 18/18] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

2018-07-04 Thread Boris Pismenny
We currently have no devices that support both TLS and IPsec using the accel framework, and the current code does not support both IPsec and TLS. This patch prevents such combinations. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan ---

[PATCH net-next 10/18] net/mlx5e: TLS, refactor variable names

2018-07-04 Thread Boris Pismenny
For symmetry, we rename mlx5e_tls_offload_context to mlx5e_tls_offload_context_tx before we add mlx5e_tls_offload_context_rx. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 2 +-

[PATCH net-next 01/18] net: Add decrypted field to skb

2018-07-04 Thread Boris Pismenny
The decrypted bit is propogated to cloned/copied skbs. This will be used later by the inline crypto receive side offload of tls. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin --- include/linux/skbuff.h | 7 ++- net/core/skbuff.c | 6 ++ 2 files changed, 12

[PATCH net-next 13/18] net/mlx5e: TLS, add Innova TLS rx data path

2018-07-04 Thread Boris Pismenny
Implement the TLS rx offload data path according to the requirements of the TLS generic NIC offload infrastructure. Special metadata ethertype is used to pass information to the hardware. When hardware loses synchronization a special resync request metadata message is used to request resync.

[PATCH net-next 14/18] net/mlx5e: TLS, add software statistics

2018-07-04 Thread Boris Pismenny
This patch adds software statistics for TLS to count important events. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 2 ++ drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h | 4

[PATCH net-next 04/18] tcp: Don't coalesce decrypted and encrypted SKBs

2018-07-04 Thread Boris Pismenny
Prevent coalescing of decrypted and encrypted SKBs in GRO and TCP layer. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin --- net/ipv4/tcp_input.c | 12 net/ipv4/tcp_offload.c | 3 +++ 2 files changed, 15 insertions(+) diff --git a/net/ipv4/tcp_input.c

[PATCH net-next 03/18] net: Add TLS rx resync NDO

2018-07-04 Thread Boris Pismenny
Add new netdev tls op for resynchornizing HW tls context Signed-off-by: Boris Pismenny --- include/linux/netdevice.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index c1ef749..022c55b 100644 --- a/include/linux/netdevice.h +++

[PATCH net-next 17/18] net/mlx5e: IPsec, fix byte count in CQE

2018-07-04 Thread Boris Pismenny
This patch fixes the byte count indication in CQE for processed IPsec packets that contain a metadata header. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 1 +

[PATCH net-next 12/18] net/mlx5e: TLS, add innova rx support

2018-07-04 Thread Boris Pismenny
Add the mlx5 implementation of the TLS Rx routines to add/del TLS contexts, also add the tls_dev_resync_rx routine to work with the TLS inline Rx crypto offload infrastructure. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan ---

[PATCH net-next 02/18] net: Add TLS RX offload feature

2018-07-04 Thread Boris Pismenny
From: Ilya Lesokhin This patch adds a netdev feature to configure TLS RX inline crypto offload. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3 insertions(+) diff --git

[PATCH net-next 15/18] net/mlx5e: TLS, build TLS netdev from capabilities

2018-07-04 Thread Boris Pismenny
This patch enables TLS Rx based on available HW capabilities. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

2018-07-04 Thread Xin Long
On Wed, Jul 4, 2018 at 3:23 AM, David Ahern wrote: > On 7/3/18 5:36 AM, Xin Long wrote: >> On Mon, Jul 2, 2018 at 11:12 PM, David Ahern wrote: >>> On 7/2/18 12:30 AM, Xin Long wrote: +ping_ipv4() +{ + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0 +

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-04 Thread Heiner Kallweit
On 04.07.2018 16:46, Andrew Lunn wrote: > On Mon, Jul 02, 2018 at 11:54:54PM +0200, Heiner Kallweit wrote: >> On 02.07.2018 23:21, Andrew Lunn wrote: - auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; >>> >>> This bit you probably want to keep. The PHY never says it support

[PATCH net-next] net: ipv4: fix drop handling in ip_list_rcv() and ip_list_rcv_finish()

2018-07-04 Thread Edward Cree
Since callees (ip_rcv_core() and ip_rcv_finish_core()) might free or steal the skb, we can't use the list_cut_before() method; we can't even do a list_del(>list) in the drop case, because skb might have already been freed and reused. So instead, take each skb off the source list before

Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

2018-07-04 Thread David Ahern
On 7/4/18 11:56 AM, Xin Long wrote: > A proper test can be done easily with netns, as vrf can't isolate much. > I don't want to bother forwarding/ directory with netns, so I will probably > just drop this selftest, and let the feature patch go first. > > What do you think? > I think I would

[PATCH net-next 1/5 v2] net: gemini: Look up L3 maxlen from table

2018-07-04 Thread Linus Walleij
The code to calculate the hardware register enumerator for the maximum L3 length isn't entirely simple to read. Use the existing defines and rewrite the function into a table look-up. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - No changes, just resending with the rest. ---

[PATCH net-next 2/5 v2] net: gemini: Improve connection prints

2018-07-04 Thread Linus Walleij
Switch over to using a module parameter and debug prints that can be controlled by this or ethtool like everyone else. Depromote all other prints to debug messages. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Use a module parameter and the message levels like all other drivers and

Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

2018-07-04 Thread David Ahern
On 7/4/18 11:56 AM, Xin Long wrote: >> your commands are not a proper test. The test should succeed and fail >> based on the routing lookup, not iptables rules. > A proper test can be done easily with netns, as vrf can't isolate much. > I don't want to bother forwarding/ directory with netns, so

[PATCH net-next 5/5 v2] net: gemini: Indicate that we can handle jumboframes

2018-07-04 Thread Linus Walleij
The hardware supposedly handles frames up to 10236 bytes and implements .ndo_change_mtu() so accept 10236 minus the ethernet header for a VLAN tagged frame on the netdevices. Use ETH_MIN_MTU as minimum MTU. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Change the min MTU from 256 (vendor

[PATCH net-next 3/5 v2] net: gemini: Allow multiple ports to instantiate

2018-07-04 Thread Linus Walleij
The code was not tested with two ports actually in use at the same time. (I blame this on lack of actual hardware using that feature.) Now after locating a system using both ports, add necessary fix to make both ports come up. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - No changes, just

[PATCH net-next 4/5 v2] net: gemini: Move main init to port

2018-07-04 Thread Linus Walleij
The initialization sequence for the ethernet, setting up interrupt routing and such things, need to be done after both the ports are clocked and reset. Before this the config will not "take". Move the initialization to the port probe function and keep track of init status in the state.

Re: [PATCH rdma-next 0/3] Dump and fill MKEY

2018-07-04 Thread Leon Romanovsky
On Wed, Jul 04, 2018 at 11:47:39AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 19, 2018 at 08:47:21AM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > MLX5 IB HCA offers the memory key, dump_fill_mkey to increase > > performance, when used in a send or receive operations. > > > >

Re: [PATCH rdma-next 3/3] IB/mlx5: Expose dump and fill memory key

2018-07-04 Thread Jason Gunthorpe
On Tue, Jun 19, 2018 at 08:47:24AM +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > MLX5 IB HCA offers the memory key, dump_fill_mkey to boost > performance, when used in a send or receive operations. > > It is used to force local HCA operations to skip the PCI bus access, > while

[PATCH net-next] r8169: fix runtime suspend

2018-07-04 Thread Heiner Kallweit
When runtime-suspending we configure WoL w/o touching saved_wolopts. If saved_wolopts == 0 we would power down the PHY in this case what's wrong. Therefore we have to check the actual chip WoL settings here. Fixes: 433f9d0ddcc6 ("r8169: improve saved_wolopts handling") Signed-off-by: Heiner

Re: [PATCH rdma-next 3/3] IB/mlx5: Expose dump and fill memory key

2018-07-04 Thread Leon Romanovsky
On Wed, Jul 04, 2018 at 01:09:37PM -0600, Jason Gunthorpe wrote: > On Tue, Jun 19, 2018 at 08:47:24AM +0300, Leon Romanovsky wrote: > > From: Yonatan Cohen > > > > MLX5 IB HCA offers the memory key, dump_fill_mkey to boost > > performance, when used in a send or receive operations. > > > > It is

Re: [PATCH rdma-next 0/3] Dump and fill MKEY

2018-07-04 Thread Jason Gunthorpe
On Wed, Jul 04, 2018 at 09:54:59PM +0300, Leon Romanovsky wrote: > On Wed, Jul 04, 2018 at 11:47:39AM -0600, Jason Gunthorpe wrote: > > On Tue, Jun 19, 2018 at 08:47:21AM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > MLX5 IB HCA offers the memory key, dump_fill_mkey to

Re: [PATCH rdma-next 0/3] Dump and fill MKEY

2018-07-04 Thread Jason Gunthorpe
On Tue, Jun 19, 2018 at 08:47:21AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > MLX5 IB HCA offers the memory key, dump_fill_mkey to increase > performance, when used in a send or receive operations. > > It is used to force local HCA operations to skip the PCI bus access, > while

Re: [PATCH net] net: phy: fix flag masking in __set_phy_supported

2018-07-04 Thread Florian Fainelli
On July 3, 2018 10:34:54 PM GMT+02:00, Heiner Kallweit wrote: >Currently also the pause flags are removed from phydev->supported >because >they're not included in PHY_DEFAULT_FEATURES. I don't think this is >intended, especially when considering that this function can be called >via

Re: [PATCH net-next 5/5 v2] net: gemini: Indicate that we can handle jumboframes

2018-07-04 Thread Andrew Lunn
On Wed, Jul 04, 2018 at 08:33:24PM +0200, Linus Walleij wrote: > The hardware supposedly handles frames up to 10236 bytes and > implements .ndo_change_mtu() so accept 10236 minus the ethernet > header for a VLAN tagged frame on the netdevices. Use > ETH_MIN_MTU as minimum MTU. > > Signed-off-by:

Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

2018-07-04 Thread Ido Schimmel
On Thu, Jul 05, 2018 at 01:56:23AM +0800, Xin Long wrote: > On Wed, Jul 4, 2018 at 3:23 AM, David Ahern wrote: > > your commands are not a proper test. The test should succeed and fail > > based on the routing lookup, not iptables rules. > A proper test can be done easily with netns, as vrf can't

Re: [PATCH net-next 2/5 v2] net: gemini: Improve connection prints

2018-07-04 Thread Andrew Lunn
On Wed, Jul 04, 2018 at 08:33:21PM +0200, Linus Walleij wrote: > Switch over to using a module parameter and debug prints > that can be controlled by this or ethtool like everyone > else. Depromote all other prints to debug messages. > > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > -