Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Jay Vosburgh
Michal Soltys wrote: >On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >> Mahesh Bandewar (महेश बंडेवार) wrote: >> >>> On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote: Hi, As weird as that sounds, this is what I observed today after bumping kernel version. I have a

Re: [BUG] mlx5 have problems with ipv4-ipv6 tunnels in linux 4.4

2018-07-12 Thread Or Gerlitz
On Tue, Jul 10, 2018 at 12:19 PM, Konstantin Khlebnikov wrote: > On 10.07.2018 01:31, Saeed Mahameed wrote: >> >> On Tue, Jul 3, 2018 at 10:45 PM, Konstantin Khlebnikov >> wrote: >>> >>> I'm seeing problems with tunnelled traffic with Mellanox Technologies >>> MT27710 Family [ConnectX-4 Lx]

[PATCH net-next 0/4] Further ARM BPF jit compiler improvements

2018-07-12 Thread Russell King - ARM Linux
Four further jit compiler improves for 32-bit ARM. arch/arm/net/bpf_jit_32.c | 120 -- 1 file changed, 73 insertions(+), 47 deletions(-) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia:

[PATCH net-next 1/4] ARM: net: bpf: improve 64-bit load immediate implementation

2018-07-12 Thread Russell King
Rather than writing each 32-bit half of the 64-bit immediate value separately when the register is on the stack: movwr6, #45056 ; 0xb000 movtr6, #60979 ; 0xee33 str r6, [fp, #-44] ; 0xffd4 mov r6, #0 str r6, [fp, #-40] ; 0xffd8 arrange to use the

[PATCH net-next 2/4] ARM: net: bpf: improve 64-bit sign-extended immediate load

2018-07-12 Thread Russell King
Improve the 64-bit sign-extended immediate from: mov r6, #1 str r6, [fp, #-52] ; 0xffcc mov r6, #0 str r6, [fp, #-48] ; 0xffd0 to: mov r6, #1 mov r7, #0 strdr6, [fp, #-52] ; 0xffcc Signed-off-by: Russell King ---

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread महेश बंडेवार
On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh wrote: > Michal Soltys wrote: > >>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >>> Mahesh Bandewar (महेश बंडेवार) wrote: >>> On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote: > > Hi, > > As weird as that sounds, this is what

Re: [PATCH net 0/2] sfc: filter locking fixes

2018-07-12 Thread David Miller
From: Bert Kenward Date: Wed, 11 Jul 2018 11:39:39 +0100 > Two fixes for sfc ef10 filter table locking. Initially spotted > by lockdep, but one issue has also been seen in normal use. Series applied, thanks.

[PATCH v2 net-next 2/9] lan743x: Add support for ethtool link settings

2018-07-12 Thread Bryan Whitehead
Use default link setting functions Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c index

[PATCH v2 net-next 3/9] lan743x: Add support for ethtool statistics

2018-07-12 Thread Bryan Whitehead
Implement ethtool statistics Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 180 +++ drivers/net/ethernet/microchip/lan743x_main.c| 6 +- drivers/net/ethernet/microchip/lan743x_main.h| 31 3 files changed, 214

[PATCH v2 net-next 5/9] lan743x: Add support for ethtool eeprom access

2018-07-12 Thread Bryan Whitehead
Implement ethtool eeprom access Also provides access to OTP (One Time Programming) Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 209 +++ drivers/net/ethernet/microchip/lan743x_main.h| 33 2 files changed, 242 insertions(+)

[PATCH v2 net-next 0/9] lan743x: Add features to lan743x driver

2018-07-12 Thread Bryan Whitehead
This patch series adds extra features to the lan743x driver. Updates for V2: Patch 3/9 - Used ARRAY_SIZE macro in lan743x_ethtool_get_ethtool_stats. Patch 5/9 - Used MAX_EEPROM_SIZE in lan743x_ethtool_set_eeprom. Patch 6/9 - Removed unnecessary read of PMT_CTL. Used CRC algorithm from

[PATCH net-next v2 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Heiner Kallweit
Some network drivers include functionality to speed down the PHY when suspending and just waiting for a WoL packet because this saves energy. This functionality is quite generic, therefore let's factor it out to phylib. Signed-off-by: Heiner Kallweit --- v2: - add comment to phy_speed_down

[PATCH net-next v2 1/2] net: phy: add helper phy_config_aneg

2018-07-12 Thread Heiner Kallweit
This functionality will also be needed in subsequent patches of this series, therefore factor it out to a helper. Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/phy.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-)

[PATCH] liquidio: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Helge Deller
Use the existing %pad printk format to print dma_addr_t values. This avoids the following warnings when compiling on the parisc platform: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=] Signed-off-by:

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Russell King - ARM Linux
On Thu, Jul 12, 2018 at 09:02:41PM +0200, Daniel Borkmann wrote: > Applied to bpf-next, thanks a lot Russell! Thanks, I've just sent four more patches, which is the sum total of what I'm intending to send for BPF improvements for the next merge window. -- RMK's Patch system:

Re: [PATCH] tcp: allow user to create repair socket without window probes

2018-07-12 Thread David Miller
From: Stefan Baranoff Date: Tue, 10 Jul 2018 17:31:10 -0400 > Under rare conditions where repair code may be used it is possible that > window probes are either unnecessary or undesired. If the user knows that > window probes are not wanted or needed this change allows them to skip > sending

Re: [PATCH] tcp: fix sequence numbers for repaired sockets re-using TIME-WAIT sockets

2018-07-12 Thread David Miller
From: Stefan Baranoff Date: Tue, 10 Jul 2018 17:25:20 -0400 > This patch fixes a bug where the sequence numbers of a socket created using > TCP repair functionality are lower than set after connect is called. > This occurs when the repair socket overlaps with a TIME-WAIT socket and > triggers

[PATCH net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-12 Thread dsahern
From: David Ahern Eric reported that reverting the patch that fixed and simplified IPv6 multipath routes means reverting back to invalid userspace notifications. eg., $ ip -6 route add 2001:db8:1::/64 nexthop dev eth0 nexthop dev eth1 only generates a single notification: 2001:db8:1::/64 dev

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Michal Soltys
On 2018-07-12 23:26, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh > wrote: >> Michal Soltys wrote: >> >>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys

Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Florian Fainelli
On 07/12/2018 12:25 PM, Florian Fainelli wrote: > > > On 07/12/2018 12:10 PM, Heiner Kallweit wrote: >> On 12.07.2018 21:09, Andrew Lunn wrote: Like r8169 also tg3 driver doesn't wait for the speed-down-renegotiation to finish. Therefore, even though I share Andrew's concerns, there

Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Heiner Kallweit
On 12.07.2018 21:53, Florian Fainelli wrote: > > > On 07/12/2018 12:25 PM, Florian Fainelli wrote: >> >> >> On 07/12/2018 12:10 PM, Heiner Kallweit wrote: >>> On 12.07.2018 21:09, Andrew Lunn wrote: > Like r8169 also tg3 driver doesn't wait for the speed-down-renegotiation > to finish.

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Add support to set a destination from a flow table number. > This functionality will be used in downstream patches from this > series by the DEVX stuff. Reading your cover letter, I still don't understand what is

Re: [PATCH v3 net-next 00/19] TLS offload rx, netdev & mlx5

2018-07-12 Thread Boris Pismenny
Hi Dave, On 7/12/2018 12:54 PM, Dave Watson wrote: On 07/11/18 10:54 PM, Boris Pismenny wrote: Hi, The following series provides TLS RX inline crypto offload. All the tls patches look good to me except #10 "tls: Fix zerocopy_from_iter iov handling" which seems to break the non-device

Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Florian Fainelli
On 07/12/2018 12:10 PM, Heiner Kallweit wrote: > On 12.07.2018 21:09, Andrew Lunn wrote: >>> Like r8169 also tg3 driver doesn't wait for the speed-down-renegotiation >>> to finish. Therefore, even though I share Andrew's concerns, there seem >>> to be chips where it's safe to not wait for the

[PATCH v4 net-next 00/19] TLS offload rx, netdev & mlx5

2018-07-12 Thread Boris Pismenny
Hi, The following series provides TLS RX inline crypto offload. v4->v3: - Remove the iov revert for zero copy send flow v2->v3: - Fix typo - Adjust cover letter - Fix bug in zero copy flows - Use network byte order for the record number in resync - Adjust the sequence

[PATCH v4 net-next 09/19] tls: Add rx inline crypto offload

2018-07-12 Thread Boris Pismenny
This patch completes the generic infrastructure to offload TLS crypto to a network device. It enables the kernel to skip decryption and authentication of some skbs marked as decrypted by the NIC. In the fast path, all packets received are decrypted by the NIC and the performance is comparable to

[PATCH v4 net-next 18/19] net/mlx5e: IPsec, fix byte count in CQE

2018-07-12 Thread Boris Pismenny
This patch fixes the byte count indication in CQE for processed IPsec packets that contain a metadata header. Signed-off-by: Boris Pismenny --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.h | 2 +-

[PATCH v4 net-next 05/19] tls: Refactor tls_offload variable names

2018-07-12 Thread Boris Pismenny
For symmetry, we rename tls_offload_context to tls_offload_context_tx before we add tls_offload_context_rx. Signed-off-by: Boris Pismenny --- .../net/ethernet/mellanox/mlx5/core/en_accel/tls.h | 6 +++--- include/net/tls.h | 16 +++---

[PATCH v4 net-next 13/19] net/mlx5e: TLS, add innova rx support

2018-07-12 Thread Boris Pismenny
Add the mlx5 implementation of the TLS Rx routines to add/del TLS contexts, also add the tls_dev_resync_rx routine to work with the TLS inline Rx crypto offload infrastructure. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin --- .../net/ethernet/mellanox/mlx5/core/en_accel/tls.c |

[PATCH v4 net-next 08/19] tls: Fill software context without allocation

2018-07-12 Thread Boris Pismenny
This patch allows tls_set_sw_offload to fill the context in case it was already allocated previously. We will use it in TLS_DEVICE to fill the RX software context. Signed-off-by: Boris Pismenny --- net/tls/tls_sw.c | 34 ++ 1 file changed, 22 insertions(+), 12

[PATCH v4 net-next 06/19] tls: Split decrypt_skb to two functions

2018-07-12 Thread Boris Pismenny
Previously, decrypt_skb also updated the TLS context. Now, decrypt_skb only decrypts the payload using the current context, while decrypt_skb_update also updates the state. Later, in the tls_device Rx flow, we will use decrypt_skb directly. Signed-off-by: Boris Pismenny --- include/net/tls.h |

[PATCH v4 net-next 12/19] net/mlx5: Accel, add TLS rx offload routines

2018-07-12 Thread Boris Pismenny
In Innova TLS, TLS contexts are added or deleted via a command message over the SBU connection. The HW then sends a response message over the same connection. Complete the implementation for Innova TLS (FPGA-based) hardware by adding support for rx inline crypto offload. Signed-off-by: Boris

[PATCH v4 net-next 16/19] net/mlx5e: TLS, build TLS netdev from capabilities

2018-07-12 Thread Boris Pismenny
This patch enables TLS Rx based on available HW capabilities. Signed-off-by: Boris Pismenny --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c

[PATCH v4 net-next 03/19] net: Add TLS rx resync NDO

2018-07-12 Thread Boris Pismenny
Add new netdev tls op for resynchronizing HW tls context Signed-off-by: Boris Pismenny --- include/linux/netdevice.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index b683971..0434df3 100644 --- a/include/linux/netdevice.h +++

[PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

2018-07-12 Thread Boris Pismenny
We currently have no devices that support both TLS and IPsec using the accel framework, and the current code does not support both IPsec and TLS. This patch prevents such combinations. Signed-off-by: Boris Pismenny --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + 1 file changed, 1

[PATCH v4 net-next 14/19] net/mlx5e: TLS, add Innova TLS rx data path

2018-07-12 Thread Boris Pismenny
Implement the TLS rx offload data path according to the requirements of the TLS generic NIC offload infrastructure. Special metadata ethertype is used to pass information to the hardware. When hardware loses synchronization a special resync request metadata message is used to request resync.

[PATCH v4 net-next 10/19] tls: Fix zerocopy_from_iter iov handling

2018-07-12 Thread Boris Pismenny
zerocopy_from_iter iterates over the message, but it doesn't revert the updates made by the iov iteration. This patch fixes it. Now, the iov can be used after calling zerocopy_from_iter. Fixes: 3c4d75591 ("tls: kernel TLS support") Signed-off-by: Boris Pismenny --- net/tls/tls_sw.c | 8 +---

[PATCH v4 net-next 17/19] net/mlx5: Accel, add common metadata functions

2018-07-12 Thread Boris Pismenny
This patch adds common functions to handle mellanox metadata headers. These functions are used by IPsec and TLS to process FPGA metadata. Signed-off-by: Boris Pismenny --- .../net/ethernet/mellanox/mlx5/core/accel/accel.h | 37 ++

[PATCH v4 net-next 15/19] net/mlx5e: TLS, add software statistics

2018-07-12 Thread Boris Pismenny
This patch adds software statistics for TLS to count important events. Signed-off-by: Boris Pismenny --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 3 +++ drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h | 4

[PATCH v4 net-next 07/19] tls: Split tls_sw_release_resources_rx

2018-07-12 Thread Boris Pismenny
This patch splits tls_sw_release_resources_rx into two functions one which releases all inner software tls structures and another that also frees the containing structure. In TLS_DEVICE we will need to release the software structures without freeeing the containing structure, which contains other

[PATCH v4 net-next 02/19] net: Add TLS RX offload feature

2018-07-12 Thread Boris Pismenny
From: Ilya Lesokhin This patch adds a netdev feature to configure TLS RX inline crypto offload. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3 insertions(+) diff --git

[PATCH v4 net-next 04/19] tcp: Don't coalesce decrypted and encrypted SKBs

2018-07-12 Thread Boris Pismenny
Prevent coalescing of decrypted and encrypted SKBs in GRO and TCP layer. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin --- net/ipv4/tcp_input.c | 12 net/ipv4/tcp_offload.c | 3 +++ 2 files changed, 15 insertions(+) diff --git a/net/ipv4/tcp_input.c

[PATCH v4 net-next 11/19] net/mlx5e: TLS, refactor variable names

2018-07-12 Thread Boris Pismenny
For symmetry, we rename mlx5e_tls_offload_context to mlx5e_tls_offload_context_tx before we add mlx5e_tls_offload_context_rx. Signed-off-by: Boris Pismenny Reviewed-by: Aviad Yehezkel Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 2 +-

[PATCH v4 net-next 01/19] net: Add decrypted field to skb

2018-07-12 Thread Boris Pismenny
The decrypted bit is propogated to cloned/copied skbs. This will be used later by the inline crypto receive side offload of tls. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin --- include/linux/skbuff.h | 7 ++- net/core/skbuff.c | 6 ++ 2 files changed, 12

Re: [PATCH v3 net-next 10/19] tls: Fix zerocopy_from_iter iov handling

2018-07-12 Thread Boris Pismenny
On 7/12/2018 12:46 PM, Dave Watson wrote: On 07/11/18 10:54 PM, Boris Pismenny wrote: zerocopy_from_iter iterates over the message, but it doesn't revert the updates made by the iov iteration. This patch fixes it. Now, the iov can be used after calling zerocopy_from_iter. This breaks tests

[PATCH net-next v2 0/2] net: phy: add functionality to speed down PHY when waiting for WoL packet

2018-07-12 Thread Heiner Kallweit
Some network drivers include functionality to speed down the PHY when suspending and just waiting for a WoL packet because this saves energy. This patch is based on our recent discussion about factoring out this functionality to phylib. First user will be the r8169 driver. v2: - add warning

Re: [net v2] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails

2018-07-12 Thread David Miller
From: Jacob Keller Date: Tue, 10 Jul 2018 14:22:27 -0700 > When fq_codel_init fails, qdisc_create_dflt will cleanup by using > qdisc_destroy. This function calls the ->reset() op prior to calling the > ->destroy() op. > > Unfortunately, during the failure flow for sch_fq_codel, the ->flows >

Re: [PATCH net-next] tc-testing: add geneve options in tunnel_key unit tests

2018-07-12 Thread David Miller
From: Jakub Kicinski Date: Tue, 10 Jul 2018 18:22:31 -0700 > From: Pieter Jansen van Vuuren > > Extend tc tunnel_key action unit tests with geneve options. Tests > include testing single and multiple geneve options, as well as > testing geneve options that are expected to fail. > >

Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 11:06 PM, Jesper Dangaard Brouer wrote: > Well, I would prefer you to implement those. I just did a quick > implementation (its trivially easy) so I have something to benchmark > with. The performance boost is quite impressive! sounds good, but wait > One reason I

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Jason Gunthorpe
On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Add support to set a destination from a flow table number. > > This functionality will be used in downstream patches from this > > series by the

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Or Gerlitz
On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: >> > From: Yishai Hadas >> > >> > Add support to set a destination from a flow table number. >> > This functionality

[PATCH net-next] selftests: tls: add selftests for TLS sockets

2018-07-12 Thread Dave Watson
Add selftests for tls socket. Tests various iov and message options, poll blocking and nonblocking behavior, partial message sends / receives, and control message data. Tests should pass regardless of if TLS is enabled in the kernel or not, and print a warning message if not. Signed-off-by:

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Daniel Borkmann
On 07/11/2018 11:30 AM, Russell King - ARM Linux wrote: > Hi, > > This series improves the ARM BPF JIT compiler by: > - enumerating the stack layout rather than using constants that happen > to be multiples of four > - rejig the BPF "register" accesses to use negative numbers instead of >

[PATCH v2 net-next 9/9] lan743x: Add PTP support

2018-07-12 Thread Bryan Whitehead
PTP support includes: Ingress, and egress timestamping. PTP clock support Pulse per second output on GPIO Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/Makefile |2 +- drivers/net/ethernet/microchip/lan743x_ethtool.c | 28 +

[PATCH v2 net-next 7/9] lan743x: Add EEE support

2018-07-12 Thread Bryan Whitehead
Implement EEE support Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 89 drivers/net/ethernet/microchip/lan743x_main.h| 3 + 2 files changed, 92 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c

[PATCH v2 net-next 1/9] lan743x: Add support for ethtool get_drvinfo

2018-07-12 Thread Bryan Whitehead
Implement ethtool get_drvinfo Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/Makefile | 2 +- drivers/net/ethernet/microchip/lan743x_ethtool.c | 21 + drivers/net/ethernet/microchip/lan743x_ethtool.h | 11 +++

[PATCH v2 net-next 6/9] lan743x: Add power management support

2018-07-12 Thread Bryan Whitehead
Implement power management. Supports suspend, resume, and Wake On LAN Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 48 ++ drivers/net/ethernet/microchip/lan743x_main.c| 184 +++ drivers/net/ethernet/microchip/lan743x_main.h

[PATCH v2 net-next 8/9] lan743x: Add RSS support

2018-07-12 Thread Bryan Whitehead
Implement RSS support Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 132 +++ drivers/net/ethernet/microchip/lan743x_main.c| 20 drivers/net/ethernet/microchip/lan743x_main.h| 19 3 files changed, 171 insertions(+)

[PATCH v2 net-next 4/9] lan743x: Add support for ethtool message level

2018-07-12 Thread Bryan Whitehead
Implement ethtool message level Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_ethtool.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c index

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Daniel Borkmann
On 07/12/2018 11:02 PM, Russell King - ARM Linux wrote: > On Thu, Jul 12, 2018 at 09:02:41PM +0200, Daniel Borkmann wrote: >> Applied to bpf-next, thanks a lot Russell! > > Thanks, I've just sent four more patches, which is the sum total of > what I'm intending to send for BPF improvements for

Re: [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data path

2018-07-12 Thread David Miller
From: Davide Caratti Date: Wed, 11 Jul 2018 16:04:48 +0200 > the data path of act_skbedit can be faster if we avoid using spinlocks: > - patch 1 converts act_skbedit statistics to use per-cpu counters > - patch 2 lets act_skbedit use RCU to read/update its configuration > > test procedure

Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Heiner Kallweit
On 11.07.2018 23:59, Heiner Kallweit wrote: > On 11.07.2018 23:33, Florian Fainelli wrote: >> >> >> On 07/11/2018 02:08 PM, Heiner Kallweit wrote: >>> On 11.07.2018 22:55, Andrew Lunn wrote: > +/** > + * phy_speed_down - set speed to lowest speed supported by both link > partners

[PATCH net-next 3/4] ARM: net: bpf: improve 64-bit store implementation

2018-07-12 Thread Russell King
Improve the 64-bit store implementation from: ldr r6, [fp, #-8] str r8, [r6] ldr r6, [fp, #-8] mov r7, #4 add r7, r6, r7 str r9, [r7] to: ldr r6, [fp, #-8] str r8, [r6] str r9, [r6, #4] We leave the store as two separate STR instructions

[PATCH net-next 4/4] ARM: net: bpf: improve 64-bit ALU implementation

2018-07-12 Thread Russell King
Improbe the 64-bit ALU implementation from: movwr8, #65532 movtr8, #65535 movwr9, #65535 movtr9, #65535 ldr r7, [fp, #-44] addsr7, r7, r8 str r7, [fp, #-44] ldr r7, [fp, #-40] adc r7, r7, r9 str r7, [fp, #-40] to: movwr8, #65532

Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

2018-07-12 Thread Marcelo Ricardo Leitner
On Thu, Jul 12, 2018 at 12:09:26PM -0400, Qiaobin Fu wrote: > @@ -156,6 +162,9 @@ parse_skbedit(struct action_util *a, int *argc_p, char > ***argv_p, int tca_id, > if (flags & SKBEDIT_F_PTYPE) > addattr_l(n, MAX_MSG, TCA_SKBEDIT_PTYPE, > ,

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Jason Gunthorpe
On Fri, Jul 13, 2018 at 12:51:10AM +0300, Or Gerlitz wrote: > On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > >> > From: Yishai Hadas > >> > > >> > Add support

Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Andrew Lunn
> Like r8169 also tg3 driver doesn't wait for the speed-down-renegotiation > to finish. Therefore, even though I share Andrew's concerns, there seem > to be chips where it's safe to not wait for the renegotiation to finish > (e.g. because device is in PCI D3 already and can't generate an

Re: [PATCH net-next 2/2] net: phy: add phy_speed_down and phy_speed_up

2018-07-12 Thread Heiner Kallweit
On 12.07.2018 21:09, Andrew Lunn wrote: >> Like r8169 also tg3 driver doesn't wait for the speed-down-renegotiation >> to finish. Therefore, even though I share Andrew's concerns, there seem >> to be chips where it's safe to not wait for the renegotiation to finish >> (e.g. because device is in

[PATCH bpf v2] bpf: don't leave partial mangled prog in jit_subprogs error path

2018-07-12 Thread Daniel Borkmann
syzkaller managed to trigger the following bug through fault injection: [...] [ 141.043668] verifier bug. No program starts at insn 3 [ 141.044648] WARNING: CPU: 3 PID: 4072 at kernel/bpf/verifier.c:1613 get_callee_stack_depth kernel/bpf/verifier.c:1612 [inline] [

[PATCH net-next] net: phy: realtek: add missing entry for RTL8211C to mdio_device_id table

2018-07-12 Thread Heiner Kallweit
Add missing entry for RTL8211C to mdio_device_id table. Signed-off-by: Heiner Kallweit Fixes: cf87915cb9f8 ("net: phy: realtek: add support for RTL8211C") --- drivers/net/phy/realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c

Re: [PATCH mlx5-next v1 1/8] net/mlx5: Add forward compatible support for the FTE match data

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Use the PRM size including the reserved when working with the FTE > match data. is this actually a bug fix? > This comes to support forward compatibility for cases that current > reserved data will be exposed by

Re: [PATCH bpf v2] bpf: don't leave partial mangled prog in jit_subprogs error path

2018-07-12 Thread Alexei Starovoitov
On Thu, Jul 12, 2018 at 09:44:28PM +0200, Daniel Borkmann wrote: > syzkaller managed to trigger the following bug through fault injection: > > [...] > [ 141.043668] verifier bug. No program starts at insn 3 > [ 141.044648] WARNING: CPU: 3 PID: 4072 at kernel/bpf/verifier.c:1613 >

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Russell King - ARM Linux
On Thu, Jul 12, 2018 at 11:12:45PM +0200, Daniel Borkmann wrote: > On 07/12/2018 11:02 PM, Russell King - ARM Linux wrote: > > On Thu, Jul 12, 2018 at 09:02:41PM +0200, Daniel Borkmann wrote: > >> Applied to bpf-next, thanks a lot Russell! > > > > Thanks, I've just sent four more patches, which

Re: BUG: MAX_LOCK_DEPTH too low! (2)

2018-07-12 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:6e6fddc78323 bpf: fix panic due to oob in bpf_prog_test_ru.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=1364db9440 kernel config:

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Jay Vosburgh
Mahesh Bandewar (महेश बंडेवार) wrote: >On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh > wrote: >> Michal Soltys wrote: >> >>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote: >> >> Hi,

Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

2018-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2018 12:09:26 -0400 Qiaobin Fu wrote: > + if (*flags & SKBEDIT_F_INHERITDSFIELD) > + print_string(PRINT_ANY, "inheritdsfield", " %s", > + "inheritdsfield"); Flags should be represented in JSON output as a null value

Re: [PATCH net] net: Don't copy pfmemalloc flag in __copy_skb_header()

2018-07-12 Thread David Miller
From: Stefano Brivio Date: Wed, 11 Jul 2018 14:39:42 +0200 > The pfmemalloc flag indicates that the skb was allocated from > the PFMEMALLOC reserves, and the flag is currently copied on skb > copy and clone. > > However, an skb copied from an skb flagged with pfmemalloc > wasn't necessarily

Re: [PATCH v2 net-next 5/9] lan743x: Add support for ethtool eeprom access

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:05:02PM -0400, Bryan Whitehead wrote: > Implement ethtool eeprom access > Also provides access to OTP (One Time Programming) > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Proposal

2018-07-12 Thread Miss Victoria Mehmet
Hello I have a business proposal of mutual benefits i would like to discuss with you i asked before and i still await your positive response thanks

Re: [PATCH v2 net-next 4/9] lan743x: Add support for ethtool message level

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:05:01PM -0400, Bryan Whitehead wrote: > Implement ethtool message level > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 3/9] lan743x: Add support for ethtool statistics

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:05:00PM -0400, Bryan Whitehead wrote: > Implement ethtool statistics > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Felix Manlunas
On Thu, Jul 12, 2018 at 10:36:29PM +0200, Helge Deller wrote: > Use the existing %pad printk format to print dma_addr_t values. > This avoids the following warnings when compiling on the parisc platform: > > warning: format '%llx' expects argument of type 'long long unsigned int', but > argument

Re: [PATCH net-next v3 00/11] devlink: Add support for region access

2018-07-12 Thread David Miller
From: Alex Vesker Date: Thu, 12 Jul 2018 15:13:07 +0300 > This is a proposal which will allow access to driver defined address > regions using devlink. Each device can create its supported address > regions and register them. A device which exposes a region will allow > access to it using

Re: [PATCH v2 net-next 6/9] lan743x: Add power management support

2018-07-12 Thread Andrew Lunn
> +#ifdef CONFIG_PM > +static void lan743x_ethtool_get_wol(struct net_device *netdev, > + struct ethtool_wolinfo *wol) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + > + wol->supported = WAKE_BCAST | WAKE_UCAST | WAKE_MCAST | > +

Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding

2018-07-12 Thread David Miller
From: Jesper Dangaard Brouer Date: Wed, 11 Jul 2018 17:01:20 +0200 > In commit 5fa12739a53d ("net: ipv4: listify ip_rcv_finish") calling > dst_input(skb) was split-out. The ip_sublist_rcv_finish() just calls > dst_input(skb) in a loop. > > The problem is that ip_sublist_rcv_finish() forgot to

Re: [PATCH net-next] net: gro: properly remove skb from list

2018-07-12 Thread David Miller
From: Prashant Bhole Date: Thu, 12 Jul 2018 16:24:59 +0900 > Following crash occurs in validate_xmit_skb_list() when same skb is > iterated multiple times in the loop and consume_skb() is called. > > The root cause is calling list_del_init(>list) and not clearing > skb->next in d4546c2509b1.

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread महेश बंडेवार
On Thu, Jul 12, 2018 at 4:14 PM, Michal Soltys wrote: > On 2018-07-13 00:03, Jay Vosburgh wrote: >> Mahesh Bandewar (महेश बंडेवार) wrote: >> >>>On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh >>> wrote: Michal Soltys wrote: >On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >> Mahesh

[PATCH net-next] TCP: make seq # error messages more readable

2018-07-12 Thread Randy Dunlap
cp_recvmsg+0x694/0xba0 Suggested-by: 積丹尼 Dan Jacobson Signed-off-by: Randy Dunlap --- net/ipv4/tcp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) --- linux-next-20180712.orig/net/ipv4/tcp.c +++ linux-next-20180712/net/ipv4/tcp.c @@ -1994,9 +1994,9 @@ int tcp_recvmsg(struc

Re: [PATCH v2 net-next 2/9] lan743x: Add support for ethtool link settings

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:04:59PM -0400, Bryan Whitehead wrote: > Use default link setting functions > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 7/9] lan743x: Add EEE support

2018-07-12 Thread Andrew Lunn
> +static int lan743x_ethtool_set_eee(struct net_device *netdev, > +struct ethtool_eee *eee) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + struct phy_device *phydev = NULL; > + u32 buf = 0; > + int ret = 0; > + > + if

Re: [PATCH net-next v3 02/11] devlink: Add callback to query for snapshot id before snapshot create

2018-07-12 Thread Jakub Kicinski
On Thu, 12 Jul 2018 15:13:09 +0300, Alex Vesker wrote: > To restrict the driver with the snapshot ID selection a new callback > is introduced for the driver to get the snapshot ID before creating > a new snapshot. This will also allow giving the same ID for multiple > snapshots taken of different

Re: [PATCH v2 net-next 1/9] lan743x: Add support for ethtool get_drvinfo

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:04:58PM -0400, Bryan Whitehead wrote: > Implement ethtool get_drvinfo > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Proposal

2018-07-12 Thread Miss Victoria Mehmet
Hello I have a business proposal of mutual benefits i would like to discuss with you.

Re: [PATCH net] nsh: set mac len based on inner packet

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:44 -0400 > From: Willem de Bruijn > > When pulling the NSH header in nsh_gso_segment, set the mac length > based on the encapsulated packet type. > > skb_reset_mac_len computes an offset to the network header, which > here still points to

Re: [PATCH net] packet: reset network header if packet shorter than ll reserved space

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:45 -0400 > From: Willem de Bruijn > > If variable length link layer headers result in a packet shorter > than dev->hard_header_len, reset the network header offset. Else > skb->mac_len may exceed skb->len after skb_mac_reset_len. > >

Re: [PATCH net] selftests: in udpgso_bench do not test udp zerocopy

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:46 -0400 > From: Willem de Bruijn > > The udpgso benchmark compares various configurations of UDP and TCP. > Including one that is not upstream, udp zerocopy. This is a leftover > from the earlier RFC patchset. > > The test is part of

Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

2018-07-12 Thread David Miller
From: Boris Pismenny Date: Thu, 12 Jul 2018 22:25:57 +0300 > We currently have no devices that support both TLS and IPsec using the > accel framework, and the current code does not support both IPsec and > TLS. This patch prevents such combinations. > > Signed-off-by: Boris Pismenny > --- >

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Michal Soltys
On 2018-07-13 00:03, Jay Vosburgh wrote: > Mahesh Bandewar (महेश बंडेवार) wrote: > >>On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh >> wrote: >>> Michal Soltys wrote: >>> On 07/12/2018 04:51 PM, Jay Vosburgh wrote: > Mahesh Bandewar (महेश बंडेवार) wrote: > >> On Wed, Jul 11, 2018

Re: [PATCH net-next 00/10] s390/qeth: updates 2018-07-11

2018-07-12 Thread David Miller
From: Julian Wiedmann Date: Wed, 11 Jul 2018 17:42:37 +0200 > please apply this first batch of qeth patches for net-next. It brings the > usual cleanups, and some performance improvements to the transmit paths. Series applied, thank you.

Re: [PATCH net-next 5/5 v3] net: gemini: Indicate that we can handle jumboframes

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:45 +0200 > The hardware supposedly handles frames up to 10236 bytes and > implements .ndo_change_mtu() so accept 10236 minus the ethernet > header for a VLAN tagged frame on the netdevices. Use > ETH_MIN_MTU as minimum MTU. > > Signed-off-by:

  1   2   >