[iproute PATCH 3/4] Merge common code for conditionally colored output

Instead of calling enable_color() conditionally with identical check in three places, introduce check_enable_color() which does it in one place. Signed-off-by: Phil Sutter --- bridge/bridge.c | 3 +-- include/color.h | 1 + ip/ip.c | 3 +-- lib/color.c | 9 + tc/tc.c

[iproute PATCH 4/4] lib: Enable colored output only for TTYs

Add an additional prerequisite to check_enable_color() to make sure stdout actually points to an open TTY device. Otherwise calls like | ip -color a s >/tmp/foo will print color escape sequences into that file. Signed-off-by: Phil Sutter --- lib/color.c | 3 ++- 1 file changed, 2

[iproute PATCH 1/4] tc: Fix typo in check for colored output

The check used binary instead of boolean AND, which means colored output was enabled only if the number of specified '-color' flags was odd. Fixes: 2d165c0811058 ("tc: implement color output") Signed-off-by: Phil Sutter --- tc/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[iproute PATCH 2/4] bridge: Fix check for colored output

There is no point in calling enable_color() conditionally if it was already called for each time '-color' flag was parsed. Align the algorithm with that in ip and tc by actually making use of 'color' variable. Fixes: e9625d6aead11 ("Merge branch 'iproute2-master' into iproute2-next")

[iproute PATCH 0/4] A bunch of fixes regarding colored output

This series contains fixes for conditionally colored output in patches 1 and 2. Patch 3 merges the common conditionals from ip, tc and bridge tools. Patch 4 then adds a further restriction to colored output to prevent garbled output when redirecting into a file. Phil Sutter (4): tc: Fix typo in

[iproute PATCH] man: ip-route: Clarify referenced versions are Linux ones

Versioning scheme of Linux and iproute2 is similar, therefore the referenced kernel versions are likely to confuse readers. Clarify this by prefixing each kernel version by 'Linux' prefix. Signed-off-by: Phil Sutter --- man/man8/ip-route.8.in | 30 +++--- 1 file changed,

[PATCH stable 4.4 2/9] Revert "tcp: avoid collapses in tcp_prune_queue() if possible"

This reverts commit 5fbec4801264cb3279ef6ac9c70bcbe2aaef89d5. --- net/ipv4/tcp_input.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 995b2bc..df2f342 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -4877,9 +4877,6 @@ static

[PATCH stable 4.4 5/9] tcp: free batches of packets in tcp_prune_ofo_queue()

From: Eric Dumazet Juha-Matti Tilli reported that malicious peers could inject tiny packets in out_of_order_queue, forcing very expensive calls to tcp_collapse_ofo_queue() and tcp_prune_ofo_queue() for every incoming packet. out_of_order_queue rb-tree can contain thousands of nodes, iterating

[PATCH stable 4.4 7/9] tcp: detect malicious patterns in tcp_collapse_ofo_queue()

From: Eric Dumazet [ Upstream commit 3d4bf93ac12003f9b8e1e2de37fe27983deebdcf ] In case an attacker feeds tiny packets completely out of order, tcp_collapse_ofo_queue() might scan the whole rb-tree, performing expensive copies, but not changing socket memory usage at all. 1) Do not attempt to

[PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. --- net/ipv4/tcp_input.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 4a261e0..995b2bc 100644 --- a/net/ipv4/tcp_input.c +++

[PATCH stable 4.4 6/9] tcp: avoid collapses in tcp_prune_queue() if possible

From: Eric Dumazet [ Upstream commit f4a3313d8e2ca9fd8d8f45e40a2903ba782607e7 ] Right after a TCP flow is created, receiving tiny out of order packets allways hit the condition : if (atomic_read(>sk_rmem_alloc) >= sk->sk_rcvbuf) tcp_clamp_window(sk); tcp_clamp_window() increases

[PATCH v3 net-next] veth: Free queues on link delete

David Ahern reported memory leak in veth. === $ cat /sys/kernel/debug/kmemleak unreferenced object 0x8800354d5c00 (size 1024): comm "ip", pid 836, jiffies 4294722952 (age 25.904s) hex dump (first 32 bytes): 00 00 00

KINDLY REPLY stemlightresour...@gmail.com URGENTLY

KINDLY REPLY stemlightresour...@gmail.com URGENTLY

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On Mon, Aug 06, 2018 at 02:20:37PM -0500, Steve Wise wrote: > > > On 8/1/2018 9:27 AM, Max Gurtovoy wrote: > > > > > > On 8/1/2018 8:12 AM, Sagi Grimberg wrote: > >> Hi Max, > > > > Hi, > > > >> > >>> Yes, since nvmf is the only user of this function. > >>> Still waiting for comments on the

[PATCH stable 4.4 4/9] tcp: use an RB tree for ooo receive queue

From: Yaogong Wang Over the years, TCP BDP has increased by several orders of magnitude, and some people are considering to reach the 2 Gbytes limit. Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 MSS. In presence of packet losses (or reorders), TCP stores incoming

[PATCH stable 4.4 8/9] tcp: call tcp_drop() from tcp_data_queue_ofo()

From: Eric Dumazet In order to be able to give better diagnostics and detect malicious traffic, we need to have better sk->sk_drops tracking. Fixes: 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh Acked-by: Yuchung Cheng

[PATCH stable 4.4 9/9] tcp: add tcp_ooo_try_coalesce() helper

From: Eric Dumazet In case skb in out_or_order_queue is the result of multiple skbs coalescing, we would like to get a proper gso_segs counter tracking, so that future tcp_drop() can report an accurate number. I chose to not implement this tracking for skbs in receive queue, since they are not

[PATCH stable 4.4 3/9] tcp: increment sk_drops for dropped rx packets

From: Eric Dumazet Now ss can report sk_drops, we can instruct TCP to increment this per socket counter when it drops an incoming frame, to refine monitoring and debugging. Following patch takes care of listeners drops. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller

[PATCH stable 4.4 0/9] fix SegmentSmack (CVE-2018-5390)

There are five patches to fix CVE-2018-5390 in latest mainline branch, but only two patches exist in stable 4.4 and 3.18: dc6ae4d tcp: detect malicious patterns in tcp_collapse_ofo_queue() 5fbec48 tcp: avoid collapses in tcp_prune_queue() if possible but I have tested with these patches, and

Re: [PATCH stable 4.4 6/9] tcp: avoid collapses in tcp_prune_queue() if possible

On Wed, Aug 15, 2018 at 09:21:05PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > [ Upstream commit f4a3313d8e2ca9fd8d8f45e40a2903ba782607e7 ] > > Right after a TCP flow is created, receiving tiny out of order > packets allways hit the condition : > > if (atomic_read(>sk_rmem_alloc) >=

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On 8/15/18 10:21 AM, Phil Sutter wrote: > Add an additional prerequisite to check_enable_color() to make sure > stdout actually points to an open TTY device. Otherwise calls like > > | ip -color a s >/tmp/foo > > will print color escape sequences into that file. Allow to override this > check by

Re: [PATCH stable 4.4 7/9] tcp: detect malicious patterns in tcp_collapse_ofo_queue()

On Wed, Aug 15, 2018 at 09:21:06PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > [ Upstream commit 3d4bf93ac12003f9b8e1e2de37fe27983deebdcf ] > > In case an attacker feeds tiny packets completely out of order, > tcp_collapse_ofo_queue() might scan the whole rb-tree, performing > expensive

Re: [PATCH stable 4.4 3/9] tcp: increment sk_drops for dropped rx packets

On Wed, Aug 15, 2018 at 09:21:02PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > Now ss can report sk_drops, we can instruct TCP to increment > this per socket counter when it drops an incoming frame, to refine > monitoring and debugging. > > Following patch takes care of listeners drops. >

Re: [PATCH stable 4.4 4/9] tcp: use an RB tree for ooo receive queue

On Wed, Aug 15, 2018 at 09:21:03PM +0800, Mao Wenan wrote: > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 >

net/ipv4/tcp.c:2278 WARN_ON(sock_owned_by_user(sk))

After moving a busy mysql database to AWS (and changing distro, kernel, etc), we see the following kernel warning every few days (on several hosts): WARNING: CPU: 33 PID: 75361 at net/ipv4/tcp.c:2278 tcp_close+0x40f/0x430 This is coming from the following section of tcp_close(): /*

Re: [PATCH stable 4.4 0/9] fix SegmentSmack (CVE-2018-5390)

On Wed, Aug 15, 2018 at 03:24:32PM +0200, Greg KH wrote: > On Wed, Aug 15, 2018 at 09:20:59PM +0800, Mao Wenan wrote: > > There are five patches to fix CVE-2018-5390 in latest mainline > > branch, but only two patches exist in stable 4.4 and 3.18: > > dc6ae4d tcp: detect malicious patterns in

Re: [iproute PATCH 4/4] lib: Enable colored output only for TTYs

On 8/15/18 3:06 AM, Phil Sutter wrote: > Add an additional prerequisite to check_enable_color() to make sure > stdout actually points to an open TTY device. Otherwise calls like > > | ip -color a s >/tmp/foo > > will print color escape sequences into that file. > > Signed-off-by: Phil Sutter >

RE: [iproute PATCH 4/4] lib: Enable colored output only for TTYs

From: Stephen Hemminger > Sent: 15 August 2018 16:04 ... > > This also disables color sequence when the output is piped to a pager > > such as less which with the -R argument can handle it just fine. > > > > ie., the user needs to remove the color arg when that output is not wanted. > > If you

Re: I found a strange place while reading “net/ipv6/reassembly.c”

2018-08-15, 04:38:29 +, Ttttabcd wrote: > Hello everyone who develops the kernel. > > At the beginning I was looking for the source author, but his email > address has expired, so I can only come here to ask questions. > > The problem is in the /net/ipv6/reassembly.c file, the author is >

Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: > This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. I need a reason why, and a signed-off-by line :( thanks, greg k-h

Re: [PATCH stable 4.4 2/9] Revert "tcp: avoid collapses in tcp_prune_queue() if possible"

On Wed, Aug 15, 2018 at 09:21:01PM +0800, Mao Wenan wrote: > This reverts commit 5fbec4801264cb3279ef6ac9c70bcbe2aaef89d5. > --- Same here for description and signed off by. thanks, greg k-h

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

Hi, On Wed, Aug 15, 2018 at 3:35 AM Andrew Lunn wrote: > > On Tue, Aug 14, 2018 at 05:58:12PM +0200, Uwe Kleine-König wrote: > > Hello Ahmad, > > > > > > On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > > > The referenced commit broke initializing macb on the EVB-KSZ9477 eval > >

[PATCH] net: dsa: add support for ksz9897 ethernet switch

From: "Lad, Prabhakar" ksz9477 is superset of ksz9xx series, driver just works out of the box for ksz9897 chip with this patch. Signed-off-by: Lad, Prabhakar --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 4 +++- drivers/net/dsa/microchip/ksz_common.c| 9 +

[PATCH] net/mlx5: Delete unneeded function argument

priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 net-next] veth: Free queues on link delete

On 8/15/18 2:07 AM, Toshiaki Makita wrote: > David Ahern reported memory leak in veth. > ... > veth_rq allocated in veth_newlink() was not freed on dellink. > > We need to free up them after veth_close() so that any packets will not > reference the queues afterwards. Thus free them in

[bpf PATCH] samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM

It is common XDP practice to unload/deattach the XDP bpf program, when the XDP sample program is Ctrl-C interrupted (SIGINT) or killed (SIGTERM). The samples/bpf programs xdp_redirect_cpu and xdp_rxq_info, forgot to trap signal SIGTERM (which is the default signal used by the kill command). This

Re: [iproute PATCH 4/4] lib: Enable colored output only for TTYs

On Wed, 15 Aug 2018 08:40:20 -0600 David Ahern wrote: > On 8/15/18 3:06 AM, Phil Sutter wrote: > > Add an additional prerequisite to check_enable_color() to make sure > > stdout actually points to an open TTY device. Otherwise calls like > > > > | ip -color a s >/tmp/foo > > > > will print

[PATCH v2] net/mlx5: Delete unneeded function argument

priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia --- v1 -> v2: * Remove blank line as pointed by Leon. --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- 1 file changed, 2

Re: [PATCH stable 4.4 0/9] fix SegmentSmack (CVE-2018-5390)

On Wed, Aug 15, 2018 at 09:20:59PM +0800, Mao Wenan wrote: > There are five patches to fix CVE-2018-5390 in latest mainline > branch, but only two patches exist in stable 4.4 and 3.18: > dc6ae4d tcp: detect malicious patterns in tcp_collapse_ofo_queue() > 5fbec48 tcp: avoid collapses in

Re: [PATCH stable 4.4 8/9] tcp: call tcp_drop() from tcp_data_queue_ofo()

On Wed, Aug 15, 2018 at 09:21:07PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > In order to be able to give better diagnostics and detect > malicious traffic, we need to have better sk->sk_drops tracking. > > Fixes: 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") > Signed-off-by:

Re: [PATCH stable 4.4 9/9] tcp: add tcp_ooo_try_coalesce() helper

On Wed, Aug 15, 2018 at 09:21:08PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > In case skb in out_or_order_queue is the result of > multiple skbs coalescing, we would like to get a proper gso_segs > counter tracking, so that future tcp_drop() can report an accurate > number. > > I chose to

Re: [PATCH stable 4.4 5/9] tcp: free batches of packets in tcp_prune_ofo_queue()

On Wed, Aug 15, 2018 at 09:21:04PM +0800, Mao Wenan wrote: > From: Eric Dumazet > > Juha-Matti Tilli reported that malicious peers could inject tiny > packets in out_of_order_queue, forcing very expensive calls > to tcp_collapse_ofo_queue() and tcp_prune_ofo_queue() for > every incoming packet.

Re: [PATCH] net/mlx5: Delete unneeded function argument

On Wed, Aug 15, 2018 at 04:54:33PM +0300, Yuval Shaia wrote: > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > No extra space here. Thanks signature.asc Description: PGP signature

Re: [bpf PATCH] samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM

On Wed, Aug 15, 2018 at 7:57 AM, Jesper Dangaard Brouer wrote: > It is common XDP practice to unload/deattach the XDP bpf program, > when the XDP sample program is Ctrl-C interrupted (SIGINT) or > killed (SIGTERM). > > The samples/bpf programs xdp_redirect_cpu and xdp_rxq_info, > forgot to trap

[iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

Add an additional prerequisite to check_enable_color() to make sure stdout actually points to an open TTY device. Otherwise calls like | ip -color a s >/tmp/foo will print color escape sequences into that file. Allow to override this check by specifying '-color' flag more than once.

[iproute PATCH 3/4] Merge common code for conditionally colored output

Instead of calling enable_color() conditionally with identical check in three places, introduce check_enable_color() which does it in one place. Signed-off-by: Phil Sutter --- bridge/bridge.c | 3 +-- include/color.h | 1 + ip/ip.c | 3 +-- lib/color.c | 9 + tc/tc.c

[iproute PATCH 1/4] tc: Fix typo in check for colored output

The check used binary instead of boolean AND, which means colored output was enabled only if the number of specified '-color' flags was odd. Fixes: 2d165c0811058 ("tc: implement color output") Signed-off-by: Phil Sutter --- tc/tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[iproute PATCH 2/4] bridge: Fix check for colored output

There is no point in calling enable_color() conditionally if it was already called for each time '-color' flag was parsed. Align the algorithm with that in ip and tc by actually making use of 'color' variable. Fixes: e9625d6aead11 ("Merge branch 'iproute2-master' into iproute2-next")

[iproute PATCH v2 0/4] A bunch of fixes regarding colored output

This series contains fixes for conditionally colored output in patches 1 and 2. Patch 3 merges the common conditionals from ip, tc and bridge tools. Patch 4 then adds a further restriction to colored output to prevent garbled output when redirecting into a file. Changes since v1: - Adjusted last

KINDLY REPLY stemlightresour...@gmail.com URGENTLY

KINDLY REPLY stemlightresour...@gmail.com URGENTLY

Re: [iproute PATCH 0/3] Fix and test ssfilter

On Tue, 14 Aug 2018 14:18:05 +0200 Phil Sutter wrote: > This series contains a fix for ssfilter and introduces a testscript to > verify correct functionality. > > Phil Sutter (3): > ss: Review ssfilter > testsuite: Prepare for ss tests > testsuite: Add a first ss test validating ssfilter

Re: 98DX3336 net driver

Hi Joacim, On 16/08/18 01:46, Thomas Petazzoni wrote: > Hello Joacim, > > On Wed, 15 Aug 2018 11:48:17 +, Joacim Zetterling wrote: > >> Sorry for bothering You! But I have a short question that You may have an >> answer to. >> >> Just wondering if You know where to find a

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

On Wed, Aug 15, 2018 at 02:30:11PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 14, 2018 at 05:08:44PM -0700, Roman Gushchin wrote: > > On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: > > > > Commit

Re: [iproute PATCH] man: ip-route: Clarify referenced versions are Linux ones

On Wed, 15 Aug 2018 11:18:26 +0200 Phil Sutter wrote: > Versioning scheme of Linux and iproute2 is similar, therefore the > referenced kernel versions are likely to confuse readers. Clarify this > by prefixing each kernel version by 'Linux' prefix. > Sure, makes sense applied.

Re: virtio_net failover and initramfs (was: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework)

On Wed, Aug 15, 2018 at 12:05 PM, Samudrala, Sridhar wrote: > On 8/14/2018 5:03 PM, Siwei Liu wrote: >> >> Are we sure all userspace apps skip and ignore slave interfaces by >> just looking at "IFLA_MASTER" attribute? >> >> When STANDBY is enabled on virtio-net, a failover master interface >>

[PATCH iproute2 0/2] ip monitor fixes

While debugging another problem noticed that ip monitor does not decode all the netconf messages. Stephen Hemminger (2): ip: convert monitor to switch ipmonitor: decode DELNETCONF message ip/ipmonitor.c | 64 ++ ip/ipnetconf.c | 6 - 2

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

On Tue, Aug 14, 2018 at 05:08:44PM -0700, Roman Gushchin wrote: > On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: > > > Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers > > > to the cgroup

[PATCH 1/2] ip: convert monitor to switch

From: Stephen Hemminger The decoding of netlink message types is natural for a C switch statement. Signed-off-by: Stephen Hemminger --- ip/ipmonitor.c | 63 ++ 1 file changed, 38 insertions(+), 25 deletions(-) diff --git a/ip/ipmonitor.c

[PATCH 2/2] ipmonitor: decode DELNETCONF message

From: Stephen Hemminger When device is deleted DELNETCONF is sent, but ipmonitor was unable to decode it. Signed-off-by: Stephen Hemminger --- ip/ipmonitor.c | 1 + ip/ipnetconf.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c index

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > On 8/15/18 10:21 AM, Phil Sutter wrote: > > Add an additional prerequisite to check_enable_color() to make sure > > stdout actually points to an open TTY device. Otherwise calls like > > > > | ip -color a s >/tmp/foo > > > > will

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On 8/15/18 10:39 AM, Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: >> On 8/15/18 10:21 AM, Phil Sutter wrote: >>> Add an additional prerequisite to check_enable_color() to make sure >>> stdout actually points to an open TTY device. Otherwise calls like >>> >>> |

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On Wed, Aug 15, 2018 at 10:43:25AM -0600, David Ahern wrote: > On 8/15/18 10:39 AM, Phil Sutter wrote: > > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > >> On 8/15/18 10:21 AM, Phil Sutter wrote: > >>> Add an additional prerequisite to check_enable_color() to make sure > >>>

Re: [PATCH net-next][RFC] net/tls: Add support for async decryption of tls records

On 08/14/18 07:47 PM, Vakul Garg wrote: > Incoming TLS records which are directly decrypted into user space > application buffer i.e. records which are decrypted in zero-copy mode > are submitted for async decryption. When the decryption cryptoapi > returns -EINPROGRESS, the next tls record is

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On 8/15/18 10:51 AM, Phil Sutter wrote: > Should I respin the fixes or will you apply the series > partially? Stephen has released 4.18 but not merged -next to master yet, so I applied the first 3 to -next.

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On Wed, Aug 15, 2018 at 10:57:13AM -0600, David Ahern wrote: > On 8/15/18 10:51 AM, Phil Sutter wrote: > > Should I respin the fixes or will you apply the series > > partially? > > Stephen has released 4.18 but not merged -next to master yet, so I > applied the first 3 to -next. OK, thanks!

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On Wed, 15 Aug 2018 18:51:15 +0200 Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:43:25AM -0600, David Ahern wrote: > > On 8/15/18 10:39 AM, Phil Sutter wrote: > > > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: > > >> On 8/15/18 10:21 AM, Phil Sutter wrote: > > >>> Add an

RE: [PATCH net-next][RFC] net/tls: Add support for async decryption of tls records

> -Original Message- > From: Dave Watson [mailto:davejwat...@fb.com] > Sent: Wednesday, August 15, 2018 10:26 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; da...@davemloft.net > Subject: Re: [PATCH net-next][RFC] net/tls: Add support for

Re: virtio_net failover and initramfs (was: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework)

On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just looking at "IFLA_MASTER" attribute? When STANDBY is enabled on virtio-net, a failover master interface will appear, which automatically enslaves the virtio device. But it is found out

Re: [PATCH net] veth: Free queues on link delete

Hi David, I love your patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/dsahern-kernel-org/veth-Free-queues-on-link-delete/20180816-073955 config: i386-randconfig-x016-201832 (attached as .config) compiler: gcc-7 (Debian

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

On 08/15/2018 02:08 AM, Roman Gushchin wrote: > On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: >> On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: >>> Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers >>> to the cgroup storage") refactored the

Re: [PATCH] net: dsa: add support for ksz9897 ethernet switch

On 08/15/2018 08:51 AM, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > ksz9477 is superset of ksz9xx series, driver just works > out of the box for ksz9897 chip with this patch. net-next is currently closed, but other than that: Reviewed-by: Florian Fainelli > > Signed-off-by: Lad,

Re: [PATCH v2 net-next 0/8] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers

On 12/05/2017 05:46 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > This series of patches is to modify the original KSZ9477 DSA driver so > that other KSZ switch drivers can be added and use the common code. > > There are several steps to accomplish this achievement. First is to

[PATCH stable 4.4 9/9] tcp: add tcp_ooo_try_coalesce() helper

From: Eric Dumazet [ Upstream commit 58152ecbbcc6a0ce7fddd5bf5f6ee535834ece0c ] In case skb in out_or_order_queue is the result of multiple skbs coalescing, we would like to get a proper gso_segs counter tracking, so that future tcp_drop() can report an accurate number. I chose to not

[PATCH stable 4.4 3/9] tcp: increment sk_drops for dropped rx packets

From: Eric Dumazet [ Upstream commit 532182cd610782db8c18230c2747626562032205 ] Now ss can report sk_drops, we can instruct TCP to increment this per socket counter when it drops an incoming frame, to refine monitoring and debugging. Following patch takes care of listeners drops.

[PATCH stable 4.4 6/9] tcp: avoid collapses in tcp_prune_queue() if possible

From: Eric Dumazet [ Upstream commit f4a3313d8e2ca9fd8d8f45e40a2903ba782607e7 ] Right after a TCP flow is created, receiving tiny out of order packets allways hit the condition : if (atomic_read(>sk_rmem_alloc) >= sk->sk_rcvbuf) tcp_clamp_window(sk); tcp_clamp_window() increases

[PATCH stable 4.4 4/9] tcp: use an RB tree for ooo receive queue

From: Yaogong Wang [ Upstream commit 9f5afeae51526b3ad7b7cb21ee8b145ce6ea7a7a ] Over the years, TCP BDP has increased by several orders of magnitude, and some people are considering to reach the 2 Gbytes limit. Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 MSS. In

[PATCH stable 4.4 8/9] tcp: call tcp_drop() from tcp_data_queue_ofo()

From: Eric Dumazet [ Upstream commit 8541b21e781a22dce52a74fef0b9bed00404a1cd ] In order to be able to give better diagnostics and detect malicious traffic, we need to have better sk->sk_drops tracking. Fixes: 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") Signed-off-by: Eric

[PATCH stable 4.4 7/9] tcp: detect malicious patterns in tcp_collapse_ofo_queue()

From: Eric Dumazet [ Upstream commit 3d4bf93ac12003f9b8e1e2de37fe27983deebdcf ] In case an attacker feeds tiny packets completely out of order, tcp_collapse_ofo_queue() might scan the whole rb-tree, performing expensive copies, but not changing socket memory usage at all. 1) Do not attempt to

[PATCH iproute2] ipmaddr: use preferred_family when given

From: Mahesh Bandewar When creating socket() AF_INET is used irrespective of the family that is given at the command-line (with -4, -6, or -0). This change will open the socket with the preferred family. Signed-off-by: Mahesh Bandewar --- ip/ipmaddr.c | 13 - 1 file changed, 12

Re: [PATCH stable 4.4 0/9] fix SegmentSmack (CVE-2018-5390)

On 2018/8/15 23:41, Greg KH wrote: > On Wed, Aug 15, 2018 at 03:24:32PM +0200, Greg KH wrote: >> On Wed, Aug 15, 2018 at 09:20:59PM +0800, Mao Wenan wrote: >>> There are five patches to fix CVE-2018-5390 in latest mainline >>> branch, but only two patches exist in stable 4.4 and 3.18: >>>

[PATCH stable 4.4 5/9] tcp: free batches of packets in tcp_prune_ofo_queue()

From: Eric Dumazet [ Upstream commit 72cd43ba64fc172a443410ce01645895850844c8 ] Juha-Matti Tilli reported that malicious peers could inject tiny packets in out_of_order_queue, forcing very expensive calls to tcp_collapse_ofo_queue() and tcp_prune_ofo_queue() for every incoming packet.

[PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. We need change simple queue to RB tree to finally fix CVE-2018-5390, So revert this patch firstly because of many conflicts when we want to apply previous patch 9f5afeae(tcp: use an RB tree for ooo receive queue), after this we will

[PATCH stable 4.4 2/9] Revert "tcp: avoid collapses in tcp_prune_queue() if possible"

This reverts commit 5fbec4801264cb3279ef6ac9c70bcbe2aaef89d5. We need change simple queue to RB tree to finally fix CVE-2018-5390, So revert this patch firstly because of many conflicts when we want to apply previous patch 9f5afeae(tcp: use an RB tree for ooo receive queue), after this we will

[PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

There are five patches to fix CVE-2018-5390 in latest mainline branch, but only two patches exist in stable 4.4 and 3.18: dc6ae4d tcp: detect malicious patterns in tcp_collapse_ofo_queue() 5fbec48 tcp: avoid collapses in tcp_prune_queue() if possible I have tested with stable 4.4 kernel, and

Re: [bpf PATCH] samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM

On Wed, Aug 15, 2018 at 8:47 AM, Y Song wrote: > On Wed, Aug 15, 2018 at 7:57 AM, Jesper Dangaard Brouer > wrote: >> It is common XDP practice to unload/deattach the XDP bpf program, >> when the XDP sample program is Ctrl-C interrupted (SIGINT) or >> killed (SIGTERM). >> >> The samples/bpf

Re: [PATCH bpf-next V3] net/xdp: Fix suspicious RCU usage warning

On 08/13/2018 02:22 PM, Daniel Borkmann wrote: [...] > I'll get the patch in once it has been pulled. Applied to bpf, thanks Tariq!

Re: [bpf PATCH] samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM

On 08/15/2018 05:47 PM, Y Song wrote: > On Wed, Aug 15, 2018 at 7:57 AM, Jesper Dangaard Brouer > wrote: >> It is common XDP practice to unload/deattach the XDP bpf program, >> when the XDP sample program is Ctrl-C interrupted (SIGINT) or >> killed (SIGTERM). >> >> The samples/bpf programs

Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

On 2018/8/15 21:18, Greg KH wrote: > On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: >> This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. > > I need a reason why, and a signed-off-by line :( stable 4.4 only back port two patches to fix CVE-2018-5390, I have tested they

bnxt: card intermittently hanging and dropping link

Hi Michael, I have some user reports of issues with a Broadcom 57412 card with the card intermittently hanging and dropping the link. The problem has been observed on a Dell server with an Ubuntu 4.13 kernel (bnxt_en version 1.7.0) and with an Ubuntu 4.15 kernel (bnxt_en version 1.8.0). It seems

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

Hi Stefano On Tue, Aug 7, 2018 at 6:31 AM, Stefano Brivio wrote: > Hi Pravin, > > On Tue, 31 Jul 2018 16:12:03 -0700 > Pravin Shelar wrote: > >> Rather than reducing number of thread down to 1, we could find better >> number of FDs per port. >> How about this simple solution: >> 1. Allocate (N