[PATCH net-next 1/3] r8169: use default watchdog timeout

2018-09-25 Thread Heiner Kallweit
The networking core has a default watchdog timeout of 5s. I see no need to define an own timeout of 6s which is basically the same. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH net-next 3/3] r8169: improve a check in rtl_init_one

2018-09-25 Thread Heiner Kallweit
The check for pci_is_pcie() is redundant here because all chip versions >=18 are PCIe only anyway. In addition use dma_set_mask_and_coherent() instead of separate calls to pci_set_dma_mask() and pci_set_consistent_dma_mask(). Signed-off-by: Heiner Kallweit ---

[PATCH net-next 2/3] r8169: improve rtl8169_irq_mask_and_ack

2018-09-25 Thread Heiner Kallweit
Code can be slightly simplified by acking even events we're not interested in. In addition add a comment making clear that the read has no functional purpose and is just a PCI commit. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 7 +++ 1 file changed, 3

[PATCH net-next] bridge: br_arp_nd_proxy: set icmp6_router if neigh has NTF_ROUTER

2018-09-25 Thread Roopa Prabhu
From: Roopa Prabhu Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports") Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_arp_nd_proxy.c b/net/bridge/br_arp_nd_proxy.c index

[net-next 01/10] i40e: Fix VF's link state notification

2018-09-25 Thread Jeff Kirsher
From: Mariusz Stachura This resolves an issue where the VF link state was not being updated when the PF is down or up, and the VF link state would always show that it is running. Signed-off-by: Mariusz Stachura Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

pull-request: bpf-next 2018-09-25

2018-09-25 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Allow for RX stack hardening by implementing the kernel's flow dissector in BPF. Idea was originally presented at netconf 2017 [0]. Quote from merge commit: [...] Because of

[PATCH RFC,net-next 06/10] drivers: net: use flow action infrastructure

2018-09-25 Thread Pablo Neira Ayuso
This patch updates drivers to use the new flow action infrastructure. Signed-off-by: Pablo Neira Ayuso --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 78 +++ .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 251 ++--

[PATCH RFC,net-next 01/10] flow_dissector: add flow_rule and flow_match structures and use them

2018-09-25 Thread Pablo Neira Ayuso
This patch wraps the dissector key and mask - that flower uses to represent the matching side - in the flow_match structure. To avoid a follow up patch that would edit the same LoCs in the drivers, this patch also wraps this new flow match structure around the flow rule object. This new structure

[PATCH RFC,net-next 05/10] cls_flower: add statistics retrieval infrastructure and use it

2018-09-25 Thread Pablo Neira Ayuso
Provide a tc_cls_flower_stats structure that acts as container for tc_cls_flower_offload, then restore stats on the TC actions. Hence tcf_exts_stats_update() is not used from drivers. Signed-off-by: Pablo Neira Ayuso --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 4 ++--

[PATCH RFC,net-next 03/10] flow_dissector: add flow action infrastructure

2018-09-25 Thread Pablo Neira Ayuso
This patch adds new infrastructure that defines actions that you can perform in existing network drivers. This infrastructure allows us to avoid the direct dependency with the software TC action infrastructure. Signed-off-by: Pablo Neira Ayuso --- include/net/flow_dissector.h | 70

[PATCH RFC,net-next 09/10] flow_dissector: add basic ethtool_rx_flow_spec to flow_rule structure translator

2018-09-25 Thread Pablo Neira Ayuso
This patch adds a function to translate the ethtool_rx_flow_spec structure to the flow_rule representation. This allows us to reuse code from the driver side given the flower and the ethtool_rx_flow interface use the same representation. Signed-off-by: Pablo Neira Ayuso ---

[PATCH RFC,net-next 08/10] flow_dissector: add wake-up-on-lan and queue to flow_action

2018-09-25 Thread Pablo Neira Ayuso
These actions need to be added to support bcm sf2 features available through the ethtool_rx_flow interface. Signed-off-by: Pablo Neira Ayuso --- include/net/flow_dissector.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h index

[PATCH RFC,net-next 07/10] cls_flower: don't expose TC actions to drivers anymore

2018-09-25 Thread Pablo Neira Ayuso
Now that drivers have been converted to use the flow action infrastructure, remove this field from the tc_cls_flower_offload structure. Signed-off-by: Pablo Neira Ayuso --- include/net/pkt_cls.h | 1 - net/sched/cls_flower.c | 5 - 2 files changed, 6 deletions(-) diff --git

[PATCH RFC,net-next 00/10] add flow_rule infrastructure

2018-09-25 Thread Pablo Neira Ayuso
Hi, This patchset spins over the existing kernel representation for network driver offloads based on the existing cls_flower dissector use for the rule matching side and the TC action infrastructure to represent the action side. The proposed object that represent rules looks like this:

[PATCH RFC,net-next 02/10] net/mlx5e: allow two independent packet edit actions

2018-09-25 Thread Pablo Neira Ayuso
Although the packet edit infrastructure allows an arbitrary number of packet mangling in the same action, it is still possible to define a rule with two or more packet edit instances. This would result in the last packet mangling action being applied to the mlx5e driver. This patch adds

[PATCH RFC,net-next 04/10] cls_flower: add translator to flow_action representation

2018-09-25 Thread Pablo Neira Ayuso
This implements TC action to flow_action translation from cls_flower. Signed-off-by: Pablo Neira Ayuso --- net/sched/cls_flower.c | 124 - 1 file changed, 123 insertions(+), 1 deletion(-) diff --git a/net/sched/cls_flower.c

[PATCH RFC,net-next 10/10] dsa: bcm_sf2: use flow_rule infrastructure

2018-09-25 Thread Pablo Neira Ayuso
Update this driver to use the flow_rule infrastructure, hence the same code to populate hardware IR can be used from ethtool_rx_flow and the cls_flower interfaces. Signed-off-by: Pablo Neira Ayuso --- drivers/net/dsa/bcm_sf2_cfp.c | 311 ++ 1 file

Re: bond: take rcu lock in bond_poll_controller

2018-09-25 Thread Cong Wang
On Mon, Sep 24, 2018 at 1:08 PM Dave Jones wrote: > > Callers of bond_for_each_slave_rcu are expected to hold the rcu lock, > otherwise a trace like below is shown Interesting, netpoll_send_skb_on_dev() already assumes RCU read lock when it calls rcu_dereference_bh()... I wonder how it can't

Urgent,

2018-09-25 Thread Juliet Muhammad
Hello i have been trying to contact you i have a transaction for you.

I have been trying to contact you

2018-09-25 Thread Fridman Mikhail
I have been trying to contact you

[PATCH iproute2 net-next] ipneigh: support setting of NTF_ROUTER on neigh entries

2018-09-25 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- ip/ipneigh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index a0af705..5747152 100644 --- a/ip/ipneigh.c +++ b/ip/ipneigh.c @@ -139,6 +139,8 @@ static int ipneigh_modify(int cmd, int flags, int argc,

[PATCH] net: dsa: lantiq_gswip: Depend on HAS_IOMEM

2018-09-25 Thread Hauke Mehrtens
The driver uses devm_ioremap_resource() which is only available when CONFIG_HAS_IOMEM is set, make the driver depend on this config option. User mode Linux does not have CONFIG_HAS_IOMEM set and the driver was failing on this architecture. Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA

[net-next 03/10] i40e: use declared variables for pf and hw

2018-09-25 Thread Jeff Kirsher
From: Patryk Małek In order to slightly simplify the code use the variables for pf and hw that are declared in i40e_set_mac function. Signed-off-by: Patryk Małek Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 9 - 1 file

[net-next 02/10] i40e: Unset promiscuous settings on VF reset

2018-09-25 Thread Jeff Kirsher
From: Mariusz Stachura This patch cleans up promiscuous configuration when a VF reset occurs. Previously the promiscuous mode settings were still there after the VF driver removal. Signed-off-by: Mariusz Stachura Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 09/10] i40e: clean zero-copy XDP Rx ring on shutdown/reset

2018-09-25 Thread Jeff Kirsher
From: Björn Töpel Outstanding Rx descriptors are temporarily stored on a stash/reuse queue. When/if the HW rings comes up again, entries from the stash are used to re-populate the ring. The latter required some restructuring of the allocation scheme for the AF_XDP zero-copy implementation.

[net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-09-25

2018-09-25 Thread Jeff Kirsher
This series contains updates to i40e and xsk. Mariusz fixes an issue where the VF link state was not being updated properly when the PF is down or up. Also cleaned up the promiscuous configuration during a VF reset. Patryk simplifies the code a bit to use the variables for PF and HW that are

[net-next 06/10] i40e: Remove unused msglen parameter from virtchnl functions

2018-09-25 Thread Jeff Kirsher
From: Patryk Małek msglen parameter seems to be unused in several virtchnl function. This patch removes it from signatures of those functions. Signed-off-by: Patryk Małek Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../ethernet/intel/i40e/i40e_virtchnl_pf.c| 96

[net-next 04/10] i40e: add a helper function to validate a VF based on the vf id

2018-09-25 Thread Jeff Kirsher
From: Harshitha Ramamurthy When we are trying to change VF settings, it is possible for 2 race conditions to happen. One, when the VF is created but not yet enabled. Second, the VF is enabled but the VSI is still not created or not yet re-created in the VF reset flow. This patch introduces a

[net-next 07/10] i40e: clean zero-copy XDP Tx ring on shutdown/reset

2018-09-25 Thread Jeff Kirsher
From: Björn Töpel When the zero-copy enabled XDP Tx ring is torn down, due to configuration changes, outstanding frames on the hardware descriptor ring are queued on the completion ring. The completion ring has a back-pressure mechanism that will guarantee that there is sufficient space on the

[net-next 08/10] net: xsk: add a simple buffer reuse queue

2018-09-25 Thread Jeff Kirsher
From: Jakub Kicinski XSK UMEM is strongly single producer single consumer so reuse of frames is challenging. Add a simple "stash" of FILL packets to reuse for drivers to optionally make use of. This is useful when driver has to free (ndo_stop) or resize a ring with an active AF_XDP ZC socket.

[net-next 05/10] i40e: fix double 'NIC Link is Down' messages

2018-09-25 Thread Jeff Kirsher
From: Sergey Nemov When isup is false meaning that interface is going to shut down set new speed to 0 to avoid double 'NIC Link is Down' messages. Signed-off-by: Sergey Nemov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 5 - 1

[net-next 10/10] i40e: disallow changing the number of descriptors when AF_XDP is on

2018-09-25 Thread Jeff Kirsher
From: Björn Töpel When an AF_XDP UMEM is attached to any of the Rx rings, we disallow a user to change the number of descriptors via e.g. "ethtool -G IFNAME". Otherwise, the size of the stash/reuse queue can grow unbounded, which would result in OOM or leaking userspace buffers. Signed-off-by:

Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

2018-09-25 Thread Michael Chan
On Tue, Sep 25, 2018 at 11:25 AM Song Liu wrote: > > Hi Michael, > > This may not be related. But I am looking at this: > > bnxt_poll_work() { > > while (1) { > > if (rx_pkts == budget) > return > } > } > > With budget

[PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Michael Chan
The current netpoll implementation in the bnxt_en driver has problems that may miss TX completion events. bnxt_poll_work() in effect is only handling at most 1 TX packet before exiting. In addition, there may be in flight TX completions that ->poll() may miss even after we fix bnxt_poll_work()

Re: [PATCH net-next] ravb: Disable Pause Advertisement

2018-09-25 Thread Simon Horman
On Fri, Sep 21, 2018 at 03:52:26PM +0200, Andrew Lunn wrote: > The previous commit to ravb had the side effect of making the PHY > advertise Pause and Asym Pause, which previously did not happen. By > default, phydev->supported has both forms of pause enabled, but > phydev->advertising does not.

Re: [PATCH rdma-next v1 0/7] Preparation to DevX extension series

2018-09-25 Thread Leon Romanovsky
On Sat, Sep 22, 2018 at 11:02:07AM -0600, Jason Gunthorpe wrote: > On Thu, Sep 20, 2018 at 09:35:19PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog v0->v1: > > * Update commit messages > > * Split DevX series to small sub-series. > > * Change static initialization

Re: [PATCH net 1/2] net: core: add member wol_enabled to struct net_device

2018-09-25 Thread Michal Kubecek
On Mon, Sep 24, 2018 at 08:09:48PM +0200, Heiner Kallweit wrote: > Add flag wol_enabled to struct net_device indicating whether > Wake-on-LAN is enabled. As first user phy_suspend() will use it to > decide whether PHY can be suspended or not. > > Fixes: f1e911d5d0df ("r8169: add basic phylib

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-25 Thread Simon Horman
On Fri, Sep 21, 2018 at 03:01:44PM +0200, Andrew Lunn wrote: > > Thanks Andrew, > > > > it seems that removing Aysm Pause does the trick. > > Great. > > I will submit the patch today. > > I see two possible followups: > > 1) Figure out why auto-neg does not complete when Pause is >

Re: [PATCH net] net: phy: sfp: Fix unregistering of HWMON SFP device

2018-09-25 Thread Sergei Shtylyov
Hello! On 9/25/2018 1:38 AM, Andrew Lunn wrote: A HWMON device is only registered is the SFP module supports the s/is/if/? diagnostic page and is complient to SFF8472. Don't unconditionally Compliant? unregister the hwmon device when the SFP module is remove, otherwise we access

Re: [PATCH net v2 1/2] net: core: add member wol_enabled to struct net_device

2018-09-25 Thread Michal Kubecek
(I wrote my comment to v1 because I overlooked there is a v2 already; duplicating it here.) On Mon, Sep 24, 2018 at 09:58:59PM +0200, Heiner Kallweit wrote: > Add flag wol_enabled to struct net_device indicating whether > Wake-on-LAN is enabled. As first user phy_suspend() will use it to > decide

Re: [PATCH bpf-next] flow_dissector: lookup netns by skb->sk if skb->dev is NULL

2018-09-25 Thread Song Liu
On Mon, Sep 24, 2018 at 1:52 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > BPF flow dissectors are configured per network namespace. > __skb_flow_dissect looks up the netns through dev_net(skb->dev). > > In some dissector paths skb->dev is NULL, such as for Unix sockets. > In these

Re: [PATCH iproute2] iplink_vxlan: take into account preferred_family creating vxlan device

2018-09-25 Thread Stephen Hemminger
On Fri, 21 Sep 2018 15:34:25 +0200 Lorenzo Bianconi wrote: > Take into account the configured preferred_family if neither saddr or > daddr are provided since otherwise vxlan kernel module will use IPv4 as > default remote inet family neglecting the one provided by userspace. > This behaviour was

Re: [PATCH iproute2 1/1] Makefile: Add check target

2018-09-25 Thread Stephen Hemminger
On Fri, 21 Sep 2018 22:29:16 +0200 Petr Vorel wrote: > Signed-off-by: Petr Vorel Applied, thanks.

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

2018-09-25 Thread Patrick Ruddy
On Wed, 2018-09-19 at 21:47 -0700, David Ahern wrote: > On 9/18/18 6:12 AM, Patrick Ruddy wrote: > > > > I've hit a small snag with adding the new groups. The number of defined > > groups currently sits at 31 so I can only add one before hitting the > > I believe you have no more available.

Re: netlink: 16 bytes leftover after parsing attributes in process `ip'.

2018-09-25 Thread Christian Brauner
On Mon, Sep 24, 2018 at 09:19:06PM -0600, David Ahern wrote: > On top of net-next I am see a dmesg error: > > netlink: 16 bytes leftover after parsing attributes in process `ip'. > > I traced it to address lists and commit: > > commit 6ecf4c37eb3e89b0832c9616089a5cdca3747da7 > Author: Christian

[PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread Vakul Garg
Current async encryption implementation sometimes showed up socket memory accounting error during socket close. This results in kernel warning calltrace. The root cause of the problem is that socket var sk_forward_alloc gets corrupted due to access in sk_mem_charge() and sk_mem_uncharge() being

Re: [RFC PATCH iproute2-next] System specification health API

2018-09-25 Thread Eran Ben Elisha
On 9/16/2018 10:57 PM, Andrew Lunn wrote: Why is this going under iproute rather than using one of the existing sensor API's. For example Intel NIC's have thermal sensors etc. Hi Stephen These are not that sort of sensors. This is part of the naming problem here. It is not really to do

Re: [RFC PATCH iproute2-next] System specification health API

2018-09-25 Thread Eran Ben Elisha
On 9/16/2018 1:37 PM, Eran Ben Elisha wrote: On 9/13/2018 8:36 PM, Jakub Kicinski wrote: On Thu, 13 Sep 2018 11:18:15 +0300, Eran Ben Elisha wrote: The health spec is targeted for Real Time Alerting, in order to know when something bad had happened to a PCI device By spec you mean some

Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

2018-09-25 Thread Song Liu
> On Sep 24, 2018, at 8:30 AM, Eric Dumazet wrote: > > On Sun, Sep 23, 2018 at 10:04 PM David Miller wrote: >> >> Series applied, thanks Eric. > > Thanks David. > > Song, would you please this additional patch ? > > diff --git a/net/core/netpoll.c b/net/core/netpoll.c > index >

RE: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Tuesday, September 25, 2018 11:14 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] tls: Fix socket mem accounting error

Re: [PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Eric Dumazet
On 09/25/2018 02:31 PM, Michael Chan wrote: > The current netpoll implementation in the bnxt_en driver has problems > that may miss TX completion events. bnxt_poll_work() in effect is > only handling at most 1 TX packet before exiting. In addition, > there may be in flight TX completions that

[PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski (fix documentation and sysctl access to treat it as such) Signed-off-by: Maciej Żenczykowski --- Documentation/networking/ip-sysctl.txt | 2 +- net/ipv4/sysctl_net_ipv4.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 2/2] net-ipv4: remove 2 always zero parameters from ipv4_redirect()

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- include/net/route.h | 3 +-- net/ipv4/ah4.c| 2 +- net/ipv4/esp4.c | 2 +- net/ipv4/icmp.c | 2 +- net/ipv4/ip_gre.c | 4 ++-- net/ipv4/ip_vti.c | 2 +- net/ipv4/ipcomp.c

[PATCH 1/2] net-ipv4: remove 2 always zero parameters from ipv4_update_pmtu()

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- include/net/route.h | 2 +- net/ipv4/ah4.c | 2 +- net/ipv4/esp4.c | 2 +- net/ipv4/icmp.c | 2 +- net/ipv4/ip_gre.c | 2 +- net/ipv4/ip_vti.c

Re: [PATCH 2/2] net-ipv4: remove 2 always zero parameters from ipv4_redirect()

2018-09-25 Thread David Ahern
On 9/25/18 6:41 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski A summary here of which 2 parameters are always 0 would be nice. > > Signed-off-by: Maciej Żenczykowski > --- > include/net/route.h | 3 +-- > net/ipv4/ah4.c| 2 +- > net/ipv4/esp4.c | 2 +-

Re: [PATCH 1/2] net-ipv4: remove 2 always zero parameters from ipv4_update_pmtu()

2018-09-25 Thread David Ahern
On 9/25/18 6:41 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > A summary here of which 2 parameters are always 0 would be nice. > Signed-off-by: Maciej Żenczykowski > --- > include/net/route.h | 2 +- > net/ipv4/ah4.c | 2 +- > net/ipv4/esp4.c

[PATCH bpf-next] bpftool: Fix bpftool net output

2018-09-25 Thread Andrey Ignatov
Print `bpftool net` output to stdout instead of stderr. Only errors should be printed to stderr. Regular output should go to stdout and this is what all other subcommands of bpftool do, including --json and --pretty formats of `bpftool net` itself. Fixes: commit f6f3bac08ff9 ("tools/bpf: bpftool:

Re: [PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Michael Chan
On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet wrote: > > It seems bnx2 should have a similar issue ? > Yes, I think so. The MSIX mode in bnx2 is also auto-masking, meaning that MSIX will only assert once after it is ARMed. If we return from ->poll() when budget of 0 is reached without ARMing,

Re: [PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Song Liu
Thanks Michael! This works well in my tests. Reviewed-and-tested-by: Song Liu > On Sep 25, 2018, at 2:31 PM, Michael Chan wrote: > > The current netpoll implementation in the bnxt_en driver has problems > that may miss TX completion events. bnxt_poll_work() in effect is > only handling

Re: [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-09-25

2018-09-25 Thread David Miller
From: Jeff Kirsher Date: Tue, 25 Sep 2018 13:19:54 -0700 > This series contains updates to i40e and xsk. ... > The following are changes since commit > bd6207202db8974ca3d3183ca0d5611d45b2973c: > net: macb: Clean 64b dma addresses if they are not detected > and are available in the git

Re: pull-request: bpf-next 2018-09-25

2018-09-25 Thread David Miller
From: Daniel Borkmann Date: Tue, 25 Sep 2018 22:43:43 +0200 > The following pull-request contains BPF updates for your *net-next* > tree. Pulled, there was a minor merge conflict. Please double check my work. Thanks.

[PATCH 2/2] net-ipv4: remove 2 always zero parameters from ipv4_redirect()

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski (the parameters in question are mark and flow_flags) Reviewed-by: David Ahern Signed-off-by: Maciej Żenczykowski --- include/net/route.h | 3 +-- net/ipv4/ah4.c| 2 +- net/ipv4/esp4.c | 2 +- net/ipv4/icmp.c | 2 +-

[PATCH 1/2] net-ipv4: remove 2 always zero parameters from ipv4_update_pmtu()

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski (the parameters in question are mark and flow_flags) Reviewed-by: David Ahern Signed-off-by: Maciej Żenczykowski --- include/net/route.h | 2 +- net/ipv4/ah4.c | 2 +- net/ipv4/esp4.c | 2 +- net/ipv4/icmp.c

Re: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

2018-09-25 Thread Samuel Mendoza-Jonas
On Tue, 2018-09-25 at 18:16 +, Vijay Khemka wrote: > Hi Joel, > Thanks, I am adding netdev mailing list here. > Yes, this command is supported for all Mellanox card. It is as per Mellanox > specification. > > Regards > -Vijay Hi Vijay, Thanks for the patch; before I get too into a review

Re: [PATCH bpf-next] bpftool: Fix bpftool net output

2018-09-25 Thread Song Liu
On Tue, Sep 25, 2018 at 3:25 PM Andrey Ignatov wrote: > > Print `bpftool net` output to stdout instead of stderr. Only errors > should be printed to stderr. Regular output should go to stdout and this > is what all other subcommands of bpftool do, including --json and > --pretty formats of

Re: [PATCH net-next v1 1/5] net: allow binding socket in a VRF when there's an unbound socket

2018-09-25 Thread Mike Manning
On 24/09/2018 23:44, David Ahern wrote: On 9/24/18 10:13 AM, Mike Manning wrote: From: Robert Shearman There is no easy way currently for applications that want to receive packets in the default VRF to be isolated from packets arriving in VRFs, which makes using VRF-unaware applications in a

Re: Marvell phy errata origins?

2018-09-25 Thread Daniel Walker
On 04/18/2017 07:04 AM, Andrew Lunn wrote: On Tue, Apr 18, 2017 at 06:16:33AM -0700, Daniel Walker wrote: Hi, Cisco is using a Marvell 88E1112 phy. It seems to be fairly similar to the 88E which Harini added a fix for. Hi Daniel If you look at Marvell reference drive, DSDT, they are

Re: netlink: 16 bytes leftover after parsing attributes in process `ip'.

2018-09-25 Thread Stephen Hemminger
On Tue, 25 Sep 2018 11:49:10 +0200 Christian Brauner wrote: > On Mon, Sep 24, 2018 at 09:19:06PM -0600, David Ahern wrote: > > On top of net-next I am see a dmesg error: > > > > netlink: 16 bytes leftover after parsing attributes in process `ip'. > > > > I traced it to address lists and

[PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski (fix documentation and sysctl access to treat it as such) Tested: # zcat /proc/config.gz | egrep ^CONFIG_HZ CONFIG_HZ_1000=y CONFIG_HZ=1000 # echo $[(1<<32)/1000 + 1] | tee /proc/sys/net/ipv4/tcp_probe_interval 4294968 tee:

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-09-25 Thread Song Liu
On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer wrote: > > XDP can modify (and resize) the Ethernet header in the packet. > > There is a bug in generic-XDP, because skb->protocol and skb->pkt_type > are setup before reaching (netif_receive_)generic_xdp. > > This bug was hit when XDP were

Re: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread David Miller
From: Vakul Garg Date: Wed, 26 Sep 2018 04:19:25 + > BTW, I noticed following build failure. > It gets resolved after reverting d6ab93364734. > > CC [M] drivers/net/phy/marvell.o > drivers/net/phy/marvell.c: In function 'm88e1121_config_aneg': > drivers/net/phy/marvell.c:468:25: error:

Re: Marvell phy errata origins?

2018-09-25 Thread Harini Katakam
Hi, On Tue, Sep 25, 2018 at 11:00 PM Harini Katakam wrote: > > Hi Daniel, > > On Tue, Sep 25, 2018 at 9:10 PM Andrew Lunn wrote: > > > > > I hope this this thread isn't too old to bring back to life. So it seems > > > that Harini found that m88e did not need this errata, and Cisco > > >

Re: netlink: 16 bytes leftover after parsing attributes in process `ip'.

2018-09-25 Thread Jiri Benc
On Tue, 25 Sep 2018 09:37:41 -0600, David Ahern wrote: > For ifaddrmsg ifa_flags aligns with ifi_type which is set by kernel side > so this should be ok. Does the existing user space set ifi_type to anything? Does it zero out the field? Are we able to find a flag value that is not going to be

Re: [PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Eric Dumazet
On Tue, Sep 25, 2018 at 7:15 PM Michael Chan wrote: > > On Tue, Sep 25, 2018 at 4:11 PM Michael Chan > wrote: > > > > On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet wrote: > > > > > > > > It seems bnx2 should have a similar issue ? > > > > > > > Yes, I think so. The MSIX mode in bnx2 is also

Re: [PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Michael Chan
On Tue, Sep 25, 2018 at 4:11 PM Michael Chan wrote: > > On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet wrote: > > > > > It seems bnx2 should have a similar issue ? > > > > Yes, I think so. The MSIX mode in bnx2 is also auto-masking, meaning > that MSIX will only assert once after it is ARMed. If

[PATCH net] vxlan: fill ttl inherit info

2018-09-25 Thread Hangbin Liu
When add vxlan ttl inherit support, I forgot to fill it when dump vlxan info. Fix it now. Fixes: 72f6d71e491e6 ("vxlan: add ttl inherit support") Signed-off-by: Hangbin Liu --- drivers/net/vxlan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c

Re: [PATCH v2 net-next] tcp: expose sk_state in tcp_retransmit_skb tracepoint

2018-09-25 Thread Eric Dumazet
On 09/24/2018 05:57 AM, Yafang Shao wrote: > After sk_state exposed, we can get in which state this retransmission > occurs. That could give us more detail for dignostic. > For example, if this retransmission occurs in SYN_SENT state, it may > also indicates that the syn packet may be dropped

Re: [PATCH] net: dsa: lantiq_gswip: Depend on HAS_IOMEM

2018-09-25 Thread David Miller
From: Hauke Mehrtens Date: Tue, 25 Sep 2018 21:55:33 +0200 > The driver uses devm_ioremap_resource() which is only available when > CONFIG_HAS_IOMEM is set, make the driver depend on this config option. > User mode Linux does not have CONFIG_HAS_IOMEM set and the driver was > failing on this

RE: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Wednesday, September 26, 2018 9:10 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] tls: Fix socket mem accounting error

Re: [PATCH net RFT] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Michael Chan
On Tue, Sep 25, 2018 at 7:25 PM Eric Dumazet wrote: > > On Tue, Sep 25, 2018 at 7:15 PM Michael Chan > wrote: > > > > On Tue, Sep 25, 2018 at 4:11 PM Michael Chan > > wrote: > > > > > > On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet > > > wrote: > > > > > > > > > > > It seems bnx2 should have

Re: [PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-25 Thread Eric Dumazet
On 09/25/2018 05:41 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > (fix documentation and sysctl access to treat it as such) > > Signed-off-by: Maciej Żenczykowski > --- While we are at it, we probably should add sane limits, given tcp_mtu_check_reprobe() does : u32

Re: [PATCH net-next v3 00/10] Refactor classifier API to work with Qdisc/blocks without rtnl lock

2018-09-25 Thread David Miller
From: Vlad Buslov Date: Mon, 24 Sep 2018 19:18:32 +0300 ... > The goal of this change is to refactor tcf_block_find() and its > dependencies to allow concurrent execution: > - Extend Qdisc API with rcu to lookup and take reference to Qdisc > without relying on rtnl lock. > - Extend tcf_block

Re: [PATCH net-next] bridge: br_arp_nd_proxy: set icmp6_router if neigh has NTF_ROUTER

2018-09-25 Thread David Miller
From: Roopa Prabhu Date: Tue, 25 Sep 2018 14:39:14 -0700 > From: Roopa Prabhu > > Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports") > Signed-off-by: Roopa Prabhu Applied.

Re: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread David Miller
From: Vakul Garg Date: Wed, 26 Sep 2018 01:54:25 + > I don't find this patch and one other ("tls: Fixed a memory leak > during socket close") in linux-net-next. Could you please kindly > check? Regards. After applying I didn't push out and instead I started a test build, closed my laptop,

[PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-25 Thread Michael Chan
The current netpoll implementation in the bnxt_en driver has problems that may miss TX completion events. bnxt_poll_work() in effect is only handling at most 1 TX packet before exiting. In addition, there may be in flight TX completions that ->poll() may miss even after we fix bnxt_poll_work()

requesting stable backport of BPF security fix (commit dd066823db2ac4e22f721ec85190817b58059a54)

2018-09-25 Thread Jann Horn
Hi! Per the policy at Documentation/networking/netdev-FAQ.rst, I'm sending this to netdev@ and davem, rather than stable@; with a CC to security@ because I believe that this is a security process issue. Upstream commit dd066823db2ac4e22f721ec85190817b58059a54 ("bpf/verifier: disallow pointer

[PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg

2018-09-25 Thread Petr Vorel
make check from top level Makefile defines several flags which break building generate_nlmsg: $ make check make -C tools gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wformat=2 -O2 -I../include -I../include/uapi -DRESOLVE_HOSTNAMES

Re: requesting stable backport of BPF security fix (commit dd066823db2ac4e22f721ec85190817b58059a54)

2018-09-25 Thread Daniel Borkmann
On 09/25/2018 02:46 PM, Jann Horn wrote: > Hi! > > Per the policy at Documentation/networking/netdev-FAQ.rst, I'm sending > this to netdev@ and davem, rather than stable@; with a CC to security@ > because I believe that this is a security process issue. > > Upstream commit

Re: netlink: 16 bytes leftover after parsing attributes in process `ip'.

2018-09-25 Thread Stephen Hemminger
On Tue, 25 Sep 2018 14:34:08 +0200 Christian Brauner wrote: > On Tue, Sep 25, 2018, 14:07 Stephen Hemminger > wrote: > > > On Tue, 25 Sep 2018 11:49:10 +0200 > > Christian Brauner wrote: > > > > > On Mon, Sep 24, 2018 at 09:19:06PM -0600, David Ahern wrote: > > > > On top of net-next I am

Re: [PATCH net v2 1/2] net: core: add member wol_enabled to struct net_device

2018-09-25 Thread Heiner Kallweit
On 25.09.2018 10:28, Michal Kubecek wrote: > (I wrote my comment to v1 because I overlooked there is a v2 already; > duplicating it here.) > > On Mon, Sep 24, 2018 at 09:58:59PM +0200, Heiner Kallweit wrote: >> Add flag wol_enabled to struct net_device indicating whether >> Wake-on-LAN is

Re: Marvell phy errata origins?

2018-09-25 Thread Harini Katakam
Hi Daniel, On Tue, Sep 25, 2018 at 9:10 PM Andrew Lunn wrote: > > > I hope this this thread isn't too old to bring back to life. So it seems > > that Harini found that m88e did not need this errata, and Cisco > > previously found that Harini's patch fixed m88e1112, we included it > >

Re: [PATCH net-next 0/3] r8169: series with smaller improvements

2018-09-25 Thread David Miller
From: Heiner Kallweit Date: Tue, 25 Sep 2018 07:55:36 +0200 > This series includes smaller improvements, nothing exciting. Series applied.

Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected

2018-09-25 Thread David Miller
From: Michal Simek Date: Tue, 25 Sep 2018 08:32:50 +0200 > Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is > not detected on 64bit system. > The issue was observed when bootloader(u-boot) does not check macb > feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma

Re: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread David Miller
From: Vakul Garg Date: Tue, 25 Sep 2018 16:26:17 +0530 > Current async encryption implementation sometimes showed up socket > memory accounting error during socket close. This results in kernel > warning calltrace. The root cause of the problem is that socket var > sk_forward_alloc gets

Re: [PATCH net-next] tls: Fixed a memory leak during socket close

2018-09-25 Thread David Miller
From: Vakul Garg Date: Tue, 25 Sep 2018 20:21:51 +0530 > During socket close, if there is a open record with tx context, it needs > to be be freed apart from freeing up plaintext and encrypted scatter > lists. This patch frees up the open record if present in tx context. > > Also

Re: [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

2018-09-25 Thread Jakub Kicinski
On Tue, 25 Sep 2018 09:37:20 +0530, Vasundhara Volam wrote: > > Why duplicate the description of the generic parameters? > Not all generic parameters are used by all drivers. So, I want to add > information about > type and configuration mode about generic parameters used by bnxt_en driver. > I

Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates

2018-09-25 Thread Jakub Kicinski
On Tue, 25 Sep 2018 09:44:41 +0530, Vasundhara Volam wrote: > On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski > wrote: > > > > On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote: > > > This patchset adds support for 3 generic and 1 driver-specific devlink > > > parameters. Add

Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

2018-09-25 Thread Eric Dumazet
On Tue, Sep 25, 2018 at 7:02 AM Michael Chan wrote: > > On Mon, Sep 24, 2018 at 2:18 PM Song Liu wrote: > > > > > > > > > On Sep 24, 2018, at 2:05 PM, Eric Dumazet wrote: > > > > > >> > > >> Interesting, maybe a bnxt specific issue. > > >> > > >> It seems their model is to process TX/RX

[bpf-next PATCH 0/3] bpf/xdp: fix generic-XDP and demonstrate VLAN manipulation

2018-09-25 Thread Jesper Dangaard Brouer
While implementing PoC building blocks for eBPF code XDP+TC that can manipulate VLANs headers, I discovered a bug in generic-XDP. The fix should be backported to stable kernels. Even-though generic-XDP were introduced in v4.12, I think the bug is not exposed until v4.14 in the mentined fixes

Re: [PATCH net-next v1 1/5] net: allow binding socket in a VRF when there's an unbound socket

2018-09-25 Thread David Ahern
On 9/25/18 9:26 AM, Mike Manning wrote: > On 24/09/2018 23:44, David Ahern wrote: >> On 9/24/18 10:13 AM, Mike Manning wrote: >>> From: Robert Shearman >>> >>> There is no easy way currently for applications that want to receive >>> packets in the default VRF to be isolated from packets arriving

  1   2   >