From: Igor Russkikh
Date: Fri, 9 Nov 2018 11:53:54 +
> The patchset fixes a number of bugs found in various areas after
> driver validation.
Series applied, thank you.
Please, when you provide a Fixes: tag, do not separate it with the
other Signed-off-by: and Acked-by: etc. tags with an
On Fri, Nov 09, 2018 at 03:28:46PM -0800, David Miller wrote:
> This series looks good to me but I want to give Richard an opportunity to
> review it first.
The series is good to go.
Acked-by: Richard Cochran
A null dereference was observed when a sysctl was being set
from userspace and rmnet was stuck trying to complete some actions
in the NETDEV_REGISTER callback. This is because the real_dev is set
only after the device registration handler completes.
sysctl call stack -
<6> Unable to handle
From: Jeff Kirsher
Date: Fri, 09 Nov 2018 15:33:10 -0800
> On Fri, 2018-11-09 at 15:28 -0800, David Miller wrote:
>> From: Miroslav Lichvar
>> Date: Fri, 9 Nov 2018 11:14:41 +0100
>>
>> > RFC->v1:
>> > - added new patches
>> > - separated PHC timestamp from ptp_system_timestamp
>> > - fixed
On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote:
>
> On 2018/11/10 3:43, Cong Wang wrote:
> > Currently netdev_rx_csum_fault() only shows a device name,
> > we need more information about the skb for debugging.
> >
> > Sample output:
> >
> > ens3: hw csum failure
> > dev features:
On 2018/11/10 10:09, Cong Wang wrote:
> On Fri, Nov 9, 2018 at 6:02 PM Yunsheng Lin wrote:
>>
>> On 2018/11/10 9:42, Cong Wang wrote:
>>> On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote:
On 2018/11/10 3:43, Cong Wang wrote:
> Currently netdev_rx_csum_fault() only shows a device
From: John Hurley
Previously the offload functions in NFP assumed that the ingress (or
egress) netdev passed to them was an nfp repr.
Modify the driver to permit the passing of non repr netdevs as the ingress
device for an offload rule candidate. This may include devices such as
tunnels. The
From: John Hurley
Currently drivers can register to receive TC block bind/unbind callbacks
by implementing the setup_tc ndo in any of their given netdevs. However,
drivers may also be interested in binds to higher level devices (e.g.
tunnel drivers) to potentially offload filters applied to
From: John Hurley
Both the actions and tunnel_conf files contain local functions that check
the type of an input netdev. In preparation for re-use with tunnel offload
via indirect blocks, move these to static inline functions in a header
file.
Signed-off-by: John Hurley
Reviewed-by: Jakub
On Fri, 09 Nov 2018 20:40:25 -0800 (PST), David Miller wrote:
> From: Jakub Kicinski
> Date: Fri, 9 Nov 2018 14:41:22 -0800
>
> > TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
> > currently contain further nested attributes, which are parsed by
> > hand, so the policy is
From: Jakub Kicinski
Date: Fri, 9 Nov 2018 14:41:22 -0800
> TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
> currently contain further nested attributes, which are parsed by
> hand, so the policy is never actually used. Add the validation
> anyway to avoid potential bugs
On Fri, Nov 9, 2018 at 6:02 PM Yunsheng Lin wrote:
>
> On 2018/11/10 9:42, Cong Wang wrote:
> > On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote:
> >>
> >> On 2018/11/10 3:43, Cong Wang wrote:
> >>> Currently netdev_rx_csum_fault() only shows a device name,
> >>> we need more information about
(Cc Randy)
On Fri, Nov 9, 2018 at 10:13 AM yupeng wrote:
>
> The snmp_counter.rst run a set of simple experiments, explains the
> meaning of snmp counters depend on the experiments' results. This is
> an initial version, only covers a small part of the snmp counters.
I don't look into much
From: Jakub Kicinski
Date: Fri, 9 Nov 2018 18:50:00 -0800
> __netdev_tx_sent_queue() was added in commit e59020abf0f
> ("net: bql: add __netdev_tx_sent_queue()") and allows for
> better GSO performance.
>
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Dirk van der Merwe
> Reviewed-by: Simon
Added support in tc flower for filtering based on port ranges.
Example:
1. Match on a port range:
-
$ tc filter add dev enp4s0 protocol ip parent :\
prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\
action drop
$ tc -s filter show dev enp4s0 parent :
On 2018/11/10 9:42, Cong Wang wrote:
> On Fri, Nov 9, 2018 at 5:39 PM Yunsheng Lin wrote:
>>
>> On 2018/11/10 3:43, Cong Wang wrote:
>>> Currently netdev_rx_csum_fault() only shows a device name,
>>> we need more information about the skb for debugging.
>>>
>>> Sample output:
>>>
>>> ens3: hw
Hi netdev,
Could we queue up this patch to stable 4.14 and stable 4.19? I can
provide a backport patch if needed. I checked it is a clean
cherry-pick for 4.19 but have some minor conflict for 4.14.
Thanks
Chenbo Feng
On Thu, Oct 18, 2018 at 4:36 PM Joel Fernandes wrote:
>
> On Thu, Oct 18, 2018
From: Richard Cochran
Date: Fri, 9 Nov 2018 17:44:31 -0800
> On Fri, Nov 09, 2018 at 03:28:46PM -0800, David Miller wrote:
>> This series looks good to me but I want to give Richard an opportunity to
>> review it first.
>
> The series is good to go.
>
> Acked-by: Richard Cochran
Great,
TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
currently contain further nested attributes, which are parsed by
hand, so the policy is never actually used resulting in a W=1
build warning:
net/sched/cls_flower.c:492:1: warning: ‘enc_opts_policy’ defined but not used
On 11/9/2018 12:51 AM, Jiri Pirko wrote:
> Wed, Nov 07, 2018 at 10:22:50PM CET, amritha.namb...@intel.com wrote:
>> Added support for filtering based on port ranges.
>>
>> Example:
>> 1. Match on a port range:
>> -
>> $ tc filter add dev enp4s0 protocol ip parent :\
>>
The following:
skb = skb->next;
...
if (skb == (struct sk_buff *)queue)
is transformed into:
skb = skb_peek_next(skb, queue);
...
if (!skb)
Signed-off-by: David S. Miller
---
drivers/infiniband/hw/nes/nes_mgt.c | 4 ++--
1 file changed, 2
From: Cong Wang
Date: Fri, 9 Nov 2018 11:43:33 -0800
> diff --git a/net/core/datagram.c b/net/core/datagram.c
> index 57f3a6fcfc1e..d8f4d55cd6c5 100644
> --- a/net/core/datagram.c
> +++ b/net/core/datagram.c
> @@ -736,7 +736,7 @@ __sum16 __skb_checksum_complete_head(struct sk_buff *skb,
> int
From: Eric Dumazet
Date: Fri, 9 Nov 2018 16:53:06 -0800
> From: 배석진
>
> Only first fragment has the sport/dport information,
> not the following ones.
>
> If we want consistent hash for all fragments, we need to
> ignore ports even for first fragment.
>
> This bug is visible for IPv6
__netdev_tx_sent_queue() was added in commit e59020abf0f
("net: bql: add __netdev_tx_sent_queue()") and allows for
better GSO performance.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 +---
From: Heiner Kallweit
Date: Fri, 9 Nov 2018 18:35:52 +0100
> As a heritage from the very early days of phylib member interrupts is
> defined as u32 even though it's just a flag whether interrupts are
> enabled. So we can change it to a bitfield member. In addition change
> the code dealing with
From: John Hurley
Recent changes to NFP mean that stats updates from fw to driver no longer
require a flow lookup and (because egdev offload has been removed) the
ingress netdev for a lookup is now always known.
Remove obsolete code in a flow lookup that matches on host context and
that allows
From: Paolo Abeni
Date: Fri, 9 Nov 2018 15:52:45 +0100
> In the udp6 code path, we needed multiple tests to select the correct
> mib to be updated. Since we touch at least a counter at each iteration,
> it's convenient to use the recently introduced __UDPX_MIB() helper once
> and remove some
From: Ioana Ciornei
Date: Fri, 9 Nov 2018 15:26:45 +
> Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator
> after the first attempts of other drivers to use them. Defer the probe when
> this situation happens.
>
> Changes in v2:
> - proper handling of
Sat, Nov 10, 2018 at 01:11:10AM CET, amritha.namb...@intel.com wrote:
[...]
>@@ -1026,8 +1122,7 @@ static void fl_init_dissector(struct flow_dissector
>*dissector,
>FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4);
> FL_KEY_SET_IF_MASKED(mask, keys, cnt,
>
From: 배석진
Only first fragment has the sport/dport information,
not the following ones.
If we want consistent hash for all fragments, we need to
ignore ports even for first fragment.
This bug is visible for IPv6 traffic, if incoming fragments
do not have a flow label, since skb_get_hash() will
On 2018/11/10 3:43, Cong Wang wrote:
> Currently netdev_rx_csum_fault() only shows a device name,
> we need more information about the skb for debugging.
>
> Sample output:
>
> ens3: hw csum failure
> dev features: 0x00014b89
> skb len=84 data_len=0 gso_size=0 gso_type=0 ip_summed=0
From: John Hurley
Previously, TC block tunnel decap rules were only offloaded when a
callback was triggered through registration of the rules egress device.
This meant that the driver had no access to the ingress netdev and so
could not verify it was the same tunnel type that the rule implied.
John says:
This patchset introduces an alternative to egdev offload by allowing a
driver to register for block updates when an external device (e.g. tunnel
netdev) is bound to a TC block. Drivers can track new netdevs or register
to existing ones to receive information on such events. Based on
On Fri, 2018-11-09 at 11:14 +0100, Miroslav Lichvar wrote:
> This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
>
> Cc: Richard Cochran
> Cc: Jacob Keller
> Cc: Jeff Kirsher
> Signed-off-by: Miroslav Lichvar
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 54
On Fri, 2018-11-09 at 11:14 +0100, Miroslav Lichvar wrote:
> This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
>
> Cc: Richard Cochran
> Cc: Jacob Keller
> Cc: Jeff Kirsher
> Signed-off-by: Miroslav Lichvar
> ---
> drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++
>
On Fri, 2018-11-09 at 11:14 +0100, Miroslav Lichvar wrote:
> This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
>
> Cc: Richard Cochran
> Cc: Jacob Keller
> Cc: Jeff Kirsher
> Signed-off-by: Miroslav Lichvar
> ---
> drivers/net/ethernet/intel/igb/igb_ptp.c | 65
From: Subash Abhinov Kasiviswanathan
Date: Fri, 9 Nov 2018 18:56:27 -0700
> A null dereference was observed when a sysctl was being set
> from userspace and rmnet was stuck trying to complete some actions
> in the NETDEV_REGISTER callback. This is because the real_dev is set
> only after the
From: John Hurley
Previously, only tunnel decap rules required egdev registration for
offload in NFP. These are now supported via indirect TC block callbacks.
Remove the egdev code from NFP.
Signed-off-by: John Hurley
Reviewed-by: Jakub Kicinski
---
On 11/9/2018 4:10 AM, Jiri Pirko wrote:
> Wed, Nov 07, 2018 at 10:22:42PM CET, amritha.namb...@intel.com wrote:
>> Added support in tc flower for filtering based on port ranges.
>>
>> Example:
>> 1. Match on a port range:
>> -
>> $ tc filter add dev enp4s0 protocol ip
On 11/8/2018 3:15 PM, David Miller wrote:
> From: Amritha Nambiar
> Date: Wed, 07 Nov 2018 13:22:42 -0800
>
>> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
>> index 401d0c1..b63c3cf 100644
>> --- a/include/uapi/linux/pkt_cls.h
>> +++ b/include/uapi/linux/pkt_cls.h
>>
Sat, Nov 10, 2018 at 06:06:26AM CET, jakub.kicin...@netronome.com wrote:
>TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
>currently contain further nested attributes, which are parsed by
>hand, so the policy is never actually used resulting in a W=1
>build warning:
>
TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
currently contain further nested attributes, which are parsed by
hand, so the policy is never actually used. Add the validation
anyway to avoid potential bugs when other attributes are added
and to make the attribute structure
From: Sudarsana Reddy Kalluru
Date: Fri, 9 Nov 2018 02:10:43 -0800
> +/* Following is the DMAE channel number allocation for the clients.
> + * MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively.
> + * Driver: 0-3 and 8-11 (for PF dmae operations)
> + * 4 and 12
On Fri, Nov 9, 2018 at 6:13 PM Sunil Kovvuri wrote:
> On Fri, Nov 9, 2018 at 4:32 PM Arnd Bergmann wrote:
> > On Fri, Nov 9, 2018 at 5:21 AM Sunil Kovvuri
> > wrote:
> >
> > Since b is aligned to four bytes, you get padding between a and b.
> > On top of that, you also get padding after c to
On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote:
> This series removes VLAN_TAG_PRESENT use from network drivers in
> preparation to removing its special meaning.
>
> Michał Mirosław (4):
> i40iw: remove use of VLAN_TAG_PRESENT
> cnic: remove use of VLAN_TAG_PRESENT
>
On 11/9/18 9:21 AM, David Ahern wrote:
>> Is there possible to add only counters from xdp for vlans ?
>> This will help me in testing.
> I will take a look today at adding counters that you can dump using
> bpftool. It will be a temporary solution for this xdp program only.
>
Same tree,
On 09/11/18 04:35, Alexei Starovoitov wrote:
> On Thu, Nov 08, 2018 at 10:56:55PM +, Edward Cree wrote:
>> think this question of maps should be discussed in tomorrow's
>> call, since it is when we start having other kinds of instances
> turned out most of us have a conflict, so the earliest
Add macros for PHYID matching to be used in PHY driver configs.
By using these macros some boilerplate code can be avoided.
Use them initially in the Realtek PHY drivers.
Heiner Kallweit (2):
net: phy: add macros for PHYID matching
net: phy: realtek: use new PHYID matching macros
W dniu 09.11.2018 o 17:21, David Ahern pisze:
On 11/9/18 3:20 AM, Paweł Staszewski wrote:
I just catch some weird behavior :)
All was working fine for about 20k packets
Then after xdp start to forward every 10 packets
Interesting. Any counter showing drops?
nothing that will fit
NIC
W dniu 08.11.2018 o 20:12, Paweł Staszewski pisze:
CPU load is lower than for connectx4 - but it looks like bandwidth
limit is the same :)
But also after reaching 60Gbit/60Gbit
bwm-ng v0.6.1 (probing every 1.000s), press 'h' for help
input: /proc/net/dev type: rate
- iface
On 11/9/18 1:28 PM, Edward Cree wrote:
> On 09/11/18 21:14, Alexei Starovoitov wrote:
>> same link, but i cannot make it right now.
>> have to extinguish few fires.
>> may be at 2pm (unlikely) or 3pm (more likely) PST?
>
> Yep I can do either of those, just let me know which when you can.
still
Use new macros for PHYID matching to avoid boilerplate code.
Signed-off-by: Heiner Kallweit
---
drivers/net/phy/realtek.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index
On 09/11/18 21:14, Alexei Starovoitov wrote:
> same link, but i cannot make it right now.
> have to extinguish few fires.
> may be at 2pm (unlikely) or 3pm (more likely) PST?
Yep I can do either of those, just let me know which when you can.
On Fri, 2018-11-09 at 15:28 -0800, David Miller wrote:
> From: Miroslav Lichvar
> Date: Fri, 9 Nov 2018 11:14:41 +0100
>
> > RFC->v1:
> > - added new patches
> > - separated PHC timestamp from ptp_system_timestamp
> > - fixed memory leak in PTP_SYS_OFFSET_EXTENDED
> > - changed
On Fri, 9 Nov 2018 09:05:46 -0800
Stephen Hemminger wrote:
> On Mon, 29 Oct 2018 23:04:25 +0100
> Stefano Brivio wrote:
>
> > While rendering columns, we use a local variable to keep track of the
> > field currently being printed, without touching current_field, which is
> > used for
On 11/9/18 9:35 AM, Heiner Kallweit wrote:
> As a heritage from the very early days of phylib member interrupts is
> defined as u32 even though it's just a flag whether interrupts are
> enabled. So we can change it to a bitfield member. In addition change
> the code dealing with this member in a
On Fri, Nov 09, 2018 at 03:26:45PM +, Ioana Ciornei wrote:
> The fsl_mc_object_allocate function can fail because not all allocatable
> objects are probed by the fsl_mc_allocator at the call time. Defer the
> dpaa2-eth probe when this happens.
>
> Signed-off-by: Ioana Ciornei
> ---
> Changes
On 11/9/18 12:00 PM, Edward Cree wrote:
> On 09/11/18 04:35, Alexei Starovoitov wrote:
>> On Thu, Nov 08, 2018 at 10:56:55PM +, Edward Cree wrote:
>>> think this question of maps should be discussed in tomorrow's
>>> call, since it is when we start having other kinds of instances
>> turned
From: Arjun Vynipadath
Date: Fri, 9 Nov 2018 14:50:25 +0530
> The locally maintained list for tracking hash mac table was
> not freed during driver remove.
>
> Signed-off-by: Arjun Vynipadath
> Signed-off-by: Ganesh Goudar
Applied.
From: Arjun Vynipadath
Date: Fri, 9 Nov 2018 14:52:53 +0530
> The locally maintained list for tracking hash mac table was
> not freed during driver remove.
>
> Signed-off-by: Arjun Vynipadath
> Signed-off-by: Ganesh Goudar
Applied.
From: Arjun Vynipadath
Date: Fri, 9 Nov 2018 14:52:01 +0530
> mac_hlist was initialized during adapter_up, which will be called
> every time a vf device is first brought up, or every time when device
> is brought up again after bringing all devices down. This means our
> state of previous list
On Fri, 9 Nov 2018 08:21:39 -0800, Stanislav Fomichev wrote:
> v5 changes:
> * FILE -> PATH for load/loadall (can be either file or directory now)
> * simpler implementation for __bpf_program__pin_name
> * removed p_err for REQ_ARGS checks
> * parse_atach_detach_args -> parse_attach_detach_args
>
On Fri, Nov 09, 2018 at 06:35:52PM +0100, Heiner Kallweit wrote:
> As a heritage from the very early days of phylib member interrupts is
> defined as u32 even though it's just a flag whether interrupts are
> enabled. So we can change it to a bitfield member. In addition change
> the code dealing
From: Li RongQing
Date: Fri, 9 Nov 2018 17:04:51 +0800
> if skb is NULL pointer, and the following access of skb's
> skb_mstamp_ns will trigger panic, which is same as BUG_ON
>
> Signed-off-by: Li RongQing
Applied.
From: Miroslav Lichvar
Date: Fri, 9 Nov 2018 11:14:41 +0100
> RFC->v1:
> - added new patches
> - separated PHC timestamp from ptp_system_timestamp
> - fixed memory leak in PTP_SYS_OFFSET_EXTENDED
> - changed PTP_SYS_OFFSET_EXTENDED to work with array of arrays
> - fixed PTP_SYS_OFFSET_EXTENDED
Add macros for PHYID matching to be used in PHY driver configs.
By using these macros some boilerplate code can be avoided.
Signed-off-by: Heiner Kallweit
---
include/linux/phy.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index
On 10/29/2018 05:02 AM, Nitin Hande wrote:
>
> This patch proposes to extend the sk_lookup() BPF API to the
> XDP hookpoint. The sk_lookup() helper supports a lookup
> on incoming packet to find the corresponding socket that will
> receive this packet. Current support for this BPF API is
> at the
The PTP_SYS_OFFSET ioctl, which can be used to measure the offset
between a PHC and the system clock, includes the total time that the
driver needs to read the PHC timestamp.
This typically involves reading of multiple PCI registers (sometimes in
multiple iterations) and the register that
RFC->v1:
- added new patches
- separated PHC timestamp from ptp_system_timestamp
- fixed memory leak in PTP_SYS_OFFSET_EXTENDED
- changed PTP_SYS_OFFSET_EXTENDED to work with array of arrays
- fixed PTP_SYS_OFFSET_EXTENDED to break correctly from loop
- fixed timecounter updates in drivers
- split
When a driver provides gettimex64(), use it in the PTP_SYS_OFFSET ioctl
and POSIX clock's gettime() instead of gettime64(). Drivers should
provide only one of the functions.
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c| 5 -
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Jacob Keller
Cc: Jeff Kirsher
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++
drivers/net/ethernet/intel/e1000e/netdev.c | 42 --
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Jacob Keller
Cc: Jeff Kirsher
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/igb/igb_ptp.c | 65
1 file changed, 55 insertions(+), 10 deletions(-)
diff --git
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Jacob Keller
Cc: Jeff Kirsher
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 54
1 file changed, 44 insertions(+), 10 deletions(-)
diff --git
If a gettime64 call fails, return the error and avoid copying data back
to user.
Cc: Richard Cochran
Cc: Jacob Keller
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_chardev.c
Reorder declarations of variables as reversed Christmas tree.
Cc: Richard Cochran
Suggested-by: Richard Cochran
Signed-off-by: Miroslav Lichvar
---
drivers/ptp/ptp_chardev.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/ptp/ptp_chardev.c
This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl.
Cc: Richard Cochran
Cc: Michael Chan
Signed-off-by: Miroslav Lichvar
---
drivers/net/ethernet/broadcom/tg3.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c
W dniu 08.11.2018 o 17:06, David Ahern pisze:
On 11/8/18 6:33 AM, Paweł Staszewski wrote:
W dniu 07.11.2018 o 22:06, David Ahern pisze:
On 11/3/18 6:24 PM, Paweł Staszewski wrote:
Does your setup have any other device types besides physical ports with
VLANs (e.g., any macvlans or bonds)?
On Fri, Nov 9, 2018 at 5:21 AM Sunil Kovvuri wrote:
>
> On Fri, Nov 9, 2018 at 2:13 AM Arnd Bergmann wrote:
> >
> > On Thu, Nov 8, 2018 at 7:37 PM wrote:
> > > @@ -666,4 +668,20 @@ struct npc_mcam_unmap_counter_req {
> > > u8 all; /* Unmap all entries using this counter ? */
> > >
mac_hlist was initialized during adapter_up, which will be called
every time a vf device is first brought up, or every time when device
is brought up again after bringing all devices down. This means our
state of previous list is lost, causing a memleak if entries are
present in the list. To fix
Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW
uses this channel for DMAE operations (e.g., TIME_SYNC implementation).
Driver also uses the same channel 0 for DMAE operations for some of the PFs
(e.g., PF0 on Port0). This could lead to concurrent access to the DMAE
On 11/08/2018 10:25 PM, Jakub Kicinski wrote:
> On Thu, 8 Nov 2018 13:00:07 -0800, David Ahern wrote:
>> From: David Ahern
>>
>> bpftool output is not user friendly when dumping a map with only a few
>> populated entries:
>>
>> $ bpftool map
>> 1: devmap name tx_devmap flags 0x0
>>
The locally maintained list for tracking hash mac table was
not freed during driver remove.
Signed-off-by: Arjun Vynipadath
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
W dniu 09.11.2018 o 05:52, Saeed Mahameed pisze:
On Thu, 2018-11-08 at 17:42 -0700, David Ahern wrote:
On 11/8/18 5:40 PM, Paweł Staszewski wrote:
W dniu 08.11.2018 o 17:32, David Ahern pisze:
On 11/8/18 9:27 AM, Paweł Staszewski wrote:
What hardware is this?
mellanox connectx 4
ethtool
On Fri, Nov 9, 2018 at 5:35 AM Sunil Kovvuri wrote:
> On Fri, Nov 9, 2018 at 2:32 AM Arnd Bergmann wrote:
> > On Thu, Nov 8, 2018 at 7:36 PM wrote:
> > > From: Sunil Goutham
> >
> > Hmm, I noticed that you use a different address as the patch author
> > and the submitter. I'm guessing that
The locally maintained list for tracking hash mac table was
not freed during driver remove.
Signed-off-by: Arjun Vynipadath
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8
1 file changed, 8 insertions(+)
diff --git
On Fri, Nov 9, 2018 at 5:29 AM Sunil Kovvuri wrote:
> On Fri, Nov 9, 2018 at 2:17 AM Arnd Bergmann wrote:
> > On Thu, Nov 8, 2018 at 7:37 PM wrote:
> >
> > Here is another instance of bitfields in an interface structure. As
> > before, please try to avoid doing that and use bit shifts and
> > The fsl_mc_object_allocate function can fail because not all
> > allocatable objects are probed by the fsl_mc_allocator at the call
> > time. Defer the dpaa2-eth probe when this happens.
> >
> > Signed-off-by: Ioana Ciornei
> > ---
> > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 30
>
In the udp6 code path, we needed multiple tests to select the correct
mib to be updated. Since we touch at least a counter at each iteration,
it's convenient to use the recently introduced __UDPX_MIB() helper once
and remove some code duplication.
Signed-off-by: Paolo Abeni
---
net/ipv6/udp.c |
Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator
after the first attempts of other drivers to use them. Defer the probe when
this situation happens.
Changes in v2:
- proper handling of IS_ERR_OR_NULL
Ioana Ciornei (2):
dpaa2-eth: defer probe on object allocate
The fsl_mc_portal_allocate can fail when the requested MC portals are
not yet probed by the fsl_mc_allocator. In this situation, the driver
should defer the probe.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- none
drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 5 -
1 file
The fsl_mc_object_allocate function can fail because not all allocatable
objects are probed by the fsl_mc_allocator at the call time. Defer the
dpaa2-eth probe when this happens.
Signed-off-by: Ioana Ciornei
---
Changes in v2:
- proper handling of IS_ERR_OR_NULL
On 11/09, Quentin Monnet wrote:
> 2018-11-08 16:22 UTC-0800 ~ Stanislav Fomichev
> > From: Stanislav Fomichev
> >
> > This patch adds new *loadall* command which slightly differs from the
> > existing *load*. *load* command loads all programs from the obj file,
> > but pins only the first
On 11/08, Jakub Kicinski wrote:
> On Thu, 8 Nov 2018 16:22:08 -0800, Stanislav Fomichev wrote:
> > + for (map = bpf_map__prev(map, obj);
> > +map != NULL;
> > +map = bpf_map__prev(map, obj)) {
>
> nit pick: if you need to respin all these for loops on error paths could
>
Wed, Nov 07, 2018 at 10:22:50PM CET, amritha.namb...@intel.com wrote:
>Added support for filtering based on port ranges.
>
>Example:
>1. Match on a port range:
>-
>$ tc filter add dev enp4s0 protocol ip parent :\
> prio 1 flower ip_proto tcp dst_port range 20-30
if skb is NULL pointer, and the following access of skb's
skb_mstamp_ns will trigger panic, which is same as BUG_ON
Signed-off-by: Li RongQing
---
net/ipv4/tcp_ipv4.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index a336787d75e5..5424a4077c27
On 11/08/2018 10:08 AM, Jiong Wang wrote:
> The maximum packet offset accessed by one BPF program is useful
> information.
>
> Because sometimes there could be packet split and it is possible for some
> reasons (for example performance) we want to reject the BPF program if the
> maximum packet
Wed, Nov 07, 2018 at 10:22:42PM CET, amritha.namb...@intel.com wrote:
>Added support in tc flower for filtering based on port ranges.
>
>Example:
>1. Match on a port range:
>-
>$ tc filter add dev enp4s0 protocol ip parent :\
> prio 1 flower ip_proto tcp dst_port range
Hello all!
I like to please you to bring back IPX and NCPFS modules to the kernel.
Whyever my admins using Novell-shares on our network which I'm not be
able to use anymore - I'm forced to use cifs instead (and the admins
will kill the cifs-shares in some time), because my kernel (4.18) does
not
Hi,
Adding Willem, I think he can be interested.
On Fri, 2018-11-09 at 14:21 +0800, Li RongQing wrote:
> GRO for UDP needs to lookup socket twice, first is in gro receive,
> second is gro complete, so if store sock to skb to avoid looking up
> twice, this can give small performance boost
>
>
Thu, Nov 08, 2018 at 10:14:13AM CET, va...@mellanox.com wrote:
>The region field was not added to the devlink man page.
>
>Fixes: 8b4fbf0bed8e6 ("devlink: Add support for devlink-region access")
>Signed-off-by: Alex Vesker
Acked-by: Jiri Pirko
1 - 100 of 175 matches
Mail list logo
