[PATCH net] Revert "sctp: remove sctp_transport_pmtu_check"

2018-11-18 Thread Xin Long
This reverts commit 22d7be267eaa8114dcc28d66c1c347f667d7878a. The dst's mtu in transport can be updated by a non sctp place like in xfrm where the MTU information didn't get synced between asoc, transport and dst, so it is still needed to do the pmtu check in sctp_packet_config. ---

[no subject]

2018-11-18 Thread Mrs. Maureen Hinckley
I am Maureen Hinckley and my foundation is donating (Five hundred and fifty thousand USD) to you. Contact us via my email at (maurhin...@gmail.com) for further details. Best Regards, Mrs. Maureen Hinckley, Copyright 2018 The Maureen Hinckley Foundation All Rights Reserved.

[PATCHv3 net-next 1/4] sctp: define subscribe in sctp_sock as __u16

2018-11-18 Thread Xin Long
The member subscribe in sctp_sock is used to indicate to which of the events it is subscribed, more like a group of flags. So it's better to be defined as __u16 (2 bytpes), instead of struct sctp_event_subscribe (13 bytes). Note that sctp_event_subscribe is an UAPI struct, used on sockopt calls,

[PATCHv3 net-next 3/4] sctp: rename enum sctp_event to sctp_event_type

2018-11-18 Thread Xin Long
sctp_event is a structure name defined in RFC for sockopt SCTP_EVENT. To avoid the conflict, rename it. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 2 +- include/net/sctp/sm.h| 4 ++-- net/sctp/primitive.c | 2 +- net/sctp/sm_sideeffect.c | 12 ++--

[PATCHv3 net-next 4/4] sctp: add sockopt SCTP_EVENT

2018-11-18 Thread Xin Long
This patch adds sockopt SCTP_EVENT described in rfc6525#section-6.2. With this sockopt users can subscribe to an event from a specified asoc. Signed-off-by: Xin Long --- include/uapi/linux/sctp.h | 7 net/sctp/socket.c | 88 +++ 2 files

[PATCHv3 net-next 0/4] sctp: add subscribe per asoc and sockopt SCTP_EVENT

2018-11-18 Thread Xin Long
This patchset mainly adds the Event Subscription sockopt described in rfc6525#section-6.2: "Subscribing to events as described in [RFC6458] uses a setsockopt() call with the SCTP_EVENT socket option. This option takes the following structure, which specifies the association, the event type

[PATCHv3 net-next 2/4] sctp: add subscribe per asoc

2018-11-18 Thread Xin Long
The member subscribe should be per asoc, so that sockopt SCTP_EVENT in the next patch can subscribe a event from one asoc only. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 2 ++ net/sctp/associola.c | 2 ++ net/sctp/chunk.c | 6 ++ net/sctp/socket.c

Re: hw csum failure + conntrack with more debugging information

2018-11-18 Thread Andre Tomt
On 18.11.2018 02:12, Eric Dumazet wrote: On Sat, Nov 17, 2018 at 3:18 PM Andre Tomt > wrote: I added Cong Wang's hw csum failure debug patch to my 4.19.2 tree and got a splat with a bit more information. > [47273.905616] p0xe0: hw csum failure >

Re: [PATCH iproute2-next v3] rdma: Document IB device renaming option

2018-11-18 Thread Leon Romanovsky
On Fri, Nov 16, 2018 at 08:10:35PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > >ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > >Sent: Sunday, November 4, 2018 2:11 PM > >To: David Ahern > >Cc: Leon Romanovsky ;

[PATCH net-next] tun: use netdev_alloc_frag() in tun_napi_alloc_frags()

2018-11-18 Thread Eric Dumazet
In order to cook skbs in the same way than Ethernet drivers, it is probably better to not use GFP_KERNEL, but rather use the GFP_ATOMIC and PFMEMALLOC mechanisms provided by netdev_alloc_frag(). This would allow to use tun driver even in memory stress situations, especially if swap is used over

[PATCH net] sctp: not increase stream's incnt before sending addstrm_in request

2018-11-18 Thread Xin Long
Different from processing the addstrm_out request, The receiver handles an addstrm_in request by sending back an addstrm_out request to the sender who will increase its stream's in and incnt later. Now stream->incnt has been increased since it sent out the addstrm_in request in

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Pavel Machek
HI! > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > > > seems like drivers/net/dsa supports everything, but this model. > > > > > > > > Did someone work with this hardware before? Any idea if it would be > > > > more suitable to support by existing 88e6060 code, or

Re: [PATCH net-next] add part of TCP counts explanations in snmp_counters.rst

2018-11-18 Thread David Miller
From: yupeng Date: Fri, 16 Nov 2018 11:17:40 -0800 > Add explanations of some generic TCP counters, fast open > related counters and TCP abort related counters and several > examples. > > Signed-off-by: yupeng Applied.

[PATCH net-next] mlxsw: spectrum: Expose discard counters via ethtool

2018-11-18 Thread Ido Schimmel
From: Shalom Toledo Expose packets discard counters via ethtool to help with debugging. Signed-off-by: Shalom Toledo Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 142 .../net/ethernet/mellanox/mlxsw/spectrum.c|

Re: Linux kernel hangs if using RV1108 with MSZ8863 switch with two ports connected

2018-11-18 Thread Andrew Lunn
> The kernel starts booting normally and then hangs like this when two > Ethernet cables are connected to the KSZ8863 switch: > http://dark-code.bulix.org/3xexu5-507563 > > This has the lock detection, inside kernel hacking, enabled. Maybe turn on all the hung-task debug and magic key support.

[PATCH net] ipv6: Fix PMTU updates for UDP/raw sockets in presence of VRF

2018-11-18 Thread David Ahern
From: David Ahern Preethi reported that PMTU discovery for UDP/raw applications is not working in the presence of VRF when the socket is not bound to a device. The problem is that ip6_sk_update_pmtu does not consider the L3 domain of the skb device if the socket is not bound. Update the function

Re: [PATCH RFC net-next] net: SAIL based FIB lookup for XDP

2018-11-18 Thread Andrew Lunn
> > + * The router can have upto 255 ports. This limitation > > + * allows us to represent netdev_index as an u8 > > + */ > > +#define NETDEV_COUNT_MAX 255 > > ... 255 is high for a physical port count but not a logical device > count. In the presence of VLANs 255 is nothing and VLANs are an >

[PATCH net] sctp: always set frag_point on pmtu change

2018-11-18 Thread Jakub Audykowicz
Calling send on a connected SCTP socket results in kernel panic if spp_pathmtu was configured manually before an association is established and it was not reconfigured to another value once the association is established. Steps to reproduce: 1. Set up a listening SCTP server socket. 2. Set up an

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Andrew Lunn
On Sun, Nov 18, 2018 at 07:07:12PM +0100, Pavel Machek wrote: > On Thu 2018-11-15 21:26:18, Andrew Lunn wrote: > > On Thu, Nov 15, 2018 at 08:51:11PM +0100, Pavel Machek wrote: > > > Hi! > > > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > > seems like drivers/net/dsa

Re: [iproute2-next PATCH v3 1/2] tc: flower: Classify packets based port ranges

2018-11-18 Thread Jiri Pirko
Fri, Nov 16, 2018 at 01:55:13AM CET, amritha.namb...@intel.com wrote: >Added support for filtering based on port ranges. >UAPI changes have been accepted into net-next. > >Example: >1. Match on a port range: >- >$ tc filter add dev enp4s0 protocol ip parent :\ > prio 1

Re: Linux kernel hangs if using RV1108 with MSZ8863 switch with two ports connected

2018-11-18 Thread Heiko Stübner
Hi all, Am Sonntag, 18. November 2018, 19:12:30 CET schrieb Andrew Lunn: > > The kernel starts booting normally and then hangs like this when two > > Ethernet cables are connected to the KSZ8863 switch: > > http://dark-code.bulix.org/3xexu5-507563 > > > This has the lock detection, inside kernel

[PATCH 00/12 net-next,v2] add flow_rule infrastructure

2018-11-18 Thread Pablo Neira Ayuso
Hi, This patchset introduces a kernel intermediate representation (IR) to express ACL hardware offloads, as already described in previous RFC and v1 patchset [1] [2]. The idea is to normalize the frontend U/APIs to use the flow dissectors and the flow actions so drivers can reuse the existing TC

[no subject]

2018-11-18 Thread Major Dennis Hornbeck
I am in the military unit here in Afghanistan, we have some amount of funds that we want to move out of the country. My partners and I need a good partner someone we can trust. It is risk free and legal. Reply to this email: hornbeckmajordennis...@gmail.com Regards,Major Dennis Hornbeck.

[PATCH net-next,v2 05/12] cls_flower: add statistics retrieval infrastructure and use it

2018-11-18 Thread Pablo Neira Ayuso
This patch provides a tc_cls_flower_stats structure that acts as container for tc_cls_flower_offload, then we can use to restore the statistics on the existing TC actions. Hence, tcf_exts_stats_update() is not used from drivers. Signed-off-by: Pablo Neira Ayuso --- v2: no changes.

[PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-18 Thread Pablo Neira Ayuso
This patch implements a new function to translate from native TC action to the new flow_action representation. Moreover, this patch also updates cls_flower to use this new function. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/pkt_cls.h | 3 ++ net/sched/cls_api.c|

[PATCH net-next,v2 01/12] flow_dissector: add flow_rule and flow_match structures and use them

2018-11-18 Thread Pablo Neira Ayuso
This patch wraps the dissector key and mask - that flower uses to represent the matching side - around the flow_match structure. To avoid a follow up patch that would edit the same LoCs in the drivers, this patch also wraps this new flow match structure around the flow rule object. This new

[PATCH net-next,v2 09/12] flow_dissector: add basic ethtool_rx_flow_spec to flow_rule structure translator

2018-11-18 Thread Pablo Neira Ayuso
This patch adds a function to translate the ethtool_rx_flow_spec structure to the flow_rule representation. This allows us to reuse code from the driver side given that both flower and ethtool_rx_flow interfaces use the same representation. Signed-off-by: Pablo Neira Ayuso --- v2: no changes.

[PATCH net-next 11/12] qede: place ethtool_rx_flow_spec after code after TC flower codebase

2018-11-18 Thread Pablo Neira Ayuso
This is a preparation patch to reuse the existing TC flower codebase from ethtool_rx_flow_spec. This patch is merely moving the core ethtool_rx_flow_spec parser after tc flower offload driver code so we can skip a few forward function declarations in the follow up patch. Signed-off-by: Pablo

[PATCH net-next,v2 10/12] dsa: bcm_sf2: use flow_rule infrastructure

2018-11-18 Thread Pablo Neira Ayuso
Update this driver to use the flow_rule infrastructure, hence we can use the same code to populate hardware IR from ethtool_rx_flow and the cls_flower interfaces. Signed-off-by: Pablo Neira Ayuso --- v2: remove unused variables, requested by David S. Miller. drivers/net/dsa/bcm_sf2_cfp.c | 108

[PATCH net-next,v2 06/12] drivers: net: use flow action infrastructure

2018-11-18 Thread Pablo Neira Ayuso
This patch updates drivers to use the new flow action infrastructure. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 74 +++--- .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 250 +--

[PATCH net-next,v2 07/12] cls_flower: don't expose TC actions to drivers anymore

2018-11-18 Thread Pablo Neira Ayuso
Now that drivers have been converted to use the flow action infrastructure, remove this field from the tc_cls_flower_offload structure. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/pkt_cls.h | 1 - net/sched/cls_flower.c | 5 - 2 files changed, 6 deletions(-) diff

[PATCH net-next 12/12] qede: use ethtool_rx_flow_rule() to remove duplicated parser code

2018-11-18 Thread Pablo Neira Ayuso
The qede driver supports for ethtool_rx_flow_spec and flower, both codebases look very similar. This patch uses the ethtool_rx_flow_rule() infrastructure to remove the duplicated ethtool_rx_flow_spec parser and consolidate ACL offload support around the flow_rule infrastructure. Furthermore,

[PATCH net-next,v2 03/12] flow_dissector: add flow action infrastructure

2018-11-18 Thread Pablo Neira Ayuso
This new infrastructure defines the nic actions that you can perform from existing network drivers. This infrastructure allows us to avoid a direct dependency with the native software TC action representation. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/flow_dissector.h |

[PATCH net-next,v2 02/12] net/mlx5e: support for two independent packet edit actions

2018-11-18 Thread Pablo Neira Ayuso
This patch adds pedit_headers_action structure to store the result of parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to populate the mlx5e hardware intermediate representation once all actions have been parsed. This patch comes in preparation for the new flow_action

[PATCH net-next,v2 08/12] flow_dissector: add wake-up-on-lan and queue to flow_action

2018-11-18 Thread Pablo Neira Ayuso
These actions need to be added to support bcm sf2 features available through the ethtool_rx_flow interface. Reviewed-by: Florian Fainelli Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/flow_dissector.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH net-next] tun: use netdev_alloc_frag() in tun_napi_alloc_frags()

2018-11-18 Thread David Miller
From: Eric Dumazet Date: Sun, 18 Nov 2018 07:37:33 -0800 > In order to cook skbs in the same way than Ethernet drivers, > it is probably better to not use GFP_KERNEL, but rather > use the GFP_ATOMIC and PFMEMALLOC mechanisms provided by > netdev_alloc_frag(). > > This would allow to use tun

Re: [PATCH net-next] mlxsw: spectrum: Expose discard counters via ethtool

2018-11-18 Thread David Miller
From: Ido Schimmel Date: Sun, 18 Nov 2018 16:43:03 + > From: Shalom Toledo > > Expose packets discard counters via ethtool to help with debugging. > > Signed-off-by: Shalom Toledo > Reviewed-by: Jiri Pirko > Signed-off-by: Ido Schimmel Applied, thanks.

Re: [PATCH net] ipv6: Fix PMTU updates for UDP/raw sockets in presence of VRF

2018-11-18 Thread David Miller
From: David Ahern Date: Sun, 18 Nov 2018 10:45:30 -0800 > From: David Ahern > > Preethi reported that PMTU discovery for UDP/raw applications is not > working in the presence of VRF when the socket is not bound to a device. > The problem is that ip6_sk_update_pmtu does not consider the L3

Re: [PATCH net] tuntap: fix multiqueue rx

2018-11-18 Thread David Miller
From: Matthew Cover Date: Sun, 18 Nov 2018 00:46:00 -0700 > When writing packets to a descriptor associated with a combined queue, the > packets should end up on that queue. > > Before this change all packets written to any descriptor associated with a > tap interface end up on rx-0, even when

[GIT] Networking

2018-11-18 Thread David Miller
1) Fix some potentially uninitialized variables and use-after-free in kvaser_usb can drier, from Jimmy Assarsson. 2) Fix leaks in qed driver, from Denis Bolotin. 3) Socket leak in l2tp, from Xin Long. 4) RSS context allocation fix in bnxt_en from Michael Chan. 5) Fix cxgb4 build errors,

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Andrew Lunn
> If I wanted it to work, what do I need to do? AFAICT phy autoprobing > should just attach it as soon as it is compiled in? Nope. It is a switch, not a PHY. Switches are never auto-probed because they are not guaranteed to have ID registers. You need to use the legacy device tree binding. Look

netns_id in bpf_sk_lookup_{tcp,udp}

2018-11-18 Thread David Ahern
Hi Joe: The netns_id to the bpf_sk_lookup_{tcp,udp} functions in net/core/filter.c is a u64, yet the APIs in include/uapi/linux/bpf.h shows a u32. Is that intentional or an oversight through the iterations? David

Re: [PATCH] rhashtable: detect when object movement between tables might have invalidated a lookup

2018-11-18 Thread Herbert Xu
On Fri, Nov 16, 2018 at 05:59:19PM +1100, NeilBrown wrote: > > NULLS_MARKER assumes a hash value in which the bottom bits are most > likely to be unique. To convert this to a pointer which certainly not > valid, it shifts left by 1 and sets the lsb. > We aren't passing a hash value, but are

Re: [PATCH] rhashtable: detect when object movement between tables might have invalidated a lookup

2018-11-18 Thread Herbert Xu
On Mon, Nov 19, 2018 at 11:54:15AM +0800, Herbert Xu wrote: > > > >> diff --git a/lib/rhashtable.c b/lib/rhashtable.c > > >> index 30526afa8343..852ffa5160f1 100644 > > >> --- a/lib/rhashtable.c > > >> +++ b/lib/rhashtable.c > > >> @@ -1179,8 +1179,7 @@ struct rhash_head __rcu

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-18 Thread Herbert Xu
On Fri, Nov 16, 2018 at 01:32:50PM -0800, Cong Wang wrote: > > This is true only when there is a skb_checksum_init*() or > skb_checksum_validate*() prior to it, it seems not true for > nf_ip_checksum() where skb->csum is correctly set to pesudo header > checksum but there is no validation of the

Re: [PATCH] rhashtable: detect when object movement between tables might have invalidated a lookup

2018-11-18 Thread Herbert Xu
On Mon, Nov 19, 2018 at 11:56:35AM +0800, Herbert Xu wrote: > > I take that back. Because of your shift which cancels out the > shift in NULLS_MARKER, it would appear that this should work just > fine with RHT_NULLS_MARRKER(0), no? IOW, it would appear that > > RHT_NULLS_MARKER(0) =

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-18 Thread Marcelo Ricardo Leitner
On Sun, Nov 18, 2018 at 04:02:25PM +0900, Xin Long wrote: > On Sat, Nov 17, 2018 at 12:12 AM Neil Horman wrote: > > > > On Thu, Nov 15, 2018 at 09:41:01PM -0200, Marcelo Ricardo Leitner wrote: > > > [ re-sending, without html this time ] > > > > > > On Thu, Nov 15, 2018, 15:26 Neil Horman > > >

Re: [PATCH] rhashtable: detect when object movement between tables might have invalidated a lookup

2018-11-18 Thread David Miller
From: Herbert Xu Date: Mon, 19 Nov 2018 12:06:34 +0800 > On Mon, Nov 19, 2018 at 11:56:35AM +0800, Herbert Xu wrote: >> >> I take that back. Because of your shift which cancels out the >> shift in NULLS_MARKER, it would appear that this should work just >> fine with RHT_NULLS_MARRKER(0), no?

"WARNING: CPU: 4 PID: 1 at ./include/net/genetlink.h:294 genlmsg_multicast_netns.isra.10.constprop.19+0x34/0x5e" with mlx4 under 4.9.137

2018-11-18 Thread Krzysztof Olędzki
Hi, I just upgraded kernel from 4.4.161 to 4.9.137 on one of my servers (Dell PowerEdge T110 II) and found this in the dmesg: [0.796066] mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) [0.796251] [ cut here ] [0.796435] WARNING: CPU: 4 PID: 1 at

Re: "WARNING: CPU: 4 PID: 1 at ./include/net/genetlink.h:294 genlmsg_multicast_netns.isra.10.constprop.19+0x34/0x5e" with mlx4 under 4.9.137

2018-11-18 Thread Krzysztof Olędzki
-> j...@mellanox.com Hi, I just upgraded kernel from 4.4.161 to 4.9.137 on one of my servers (Dell PowerEdge T110 II) and found this in the dmesg: [0.796066] mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) [0.796251] [ cut here ] [0.796435]

[PATCH net-next] MAINTAINERS: Add myself as third phylib maintainer

2018-11-18 Thread Heiner Kallweit
Add myself as third phylib maintainer. Signed-off-by: Heiner Kallweit --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ff8865a9..2988ecbf6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5540,6 +5540,7 @@ F:net/bridge/ ETHERNET PHY

Re: selftests: net: udpgro.sh hangs on DUT devices running Linux -next

2018-11-18 Thread Naresh Kamboju
Hi Paolo, On Sun, 18 Nov 2018 at 05:01, Paolo Abeni wrote: > > Hi, > > On Fri, 2018-11-16 at 14:55 +0530, Naresh Kamboju wrote: > > Kernel selftests: net: udpgro.sh hangs / waits forever on x86_64 and > > arm32 devices running Linux -next. Test getting PASS on arm64 devices. > > > > Do you see

RE: [PATCH v2 2/2] dpaa_eth: add ethtool coalesce control

2018-11-18 Thread Madalin-cristian Bucur
> -Original Message- > From: David Miller > Sent: Saturday, November 17, 2018 5:42 AM > To: Madalin-cristian Bucur > Subject: Re: [PATCH v2 2/2] dpaa_eth: add ethtool coalesce control > > From: Madalin Bucur > Date: Tue, 13 Nov 2018 18:29:51 +0200 > > > + for_each_cpu(cpu, cpus) { >

Re: [PATCH net] sctp: always set frag_point on pmtu change

2018-11-18 Thread Xin Long
On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz wrote: > > Calling send on a connected SCTP socket results in kernel panic if > spp_pathmtu was configured manually before an association is established > and it was not reconfigured to another value once the association is > established. > > Steps

Re: [PATCH RFC net-next] net: SAIL based FIB lookup for XDP

2018-11-18 Thread David Ahern
On 11/11/18 7:25 PM, Md. Islam wrote: > This patch implements SAIL[1] based routing table lookup for XDP. I > however made some changes from the original proposal (details are > described in the patch). This changes decreased the memory consumption > from 21.94 MB to 4.97 MB for my example routing

Re: DSA support for Marvell 88e6065 switch

2018-11-18 Thread Pavel Machek
On Thu 2018-11-15 21:26:18, Andrew Lunn wrote: > On Thu, Nov 15, 2018 at 08:51:11PM +0100, Pavel Machek wrote: > > Hi! > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > seems like drivers/net/dsa supports everything, but this model. > > > > Did someone work with this