Re: [v3] ocelot_ace: fix action of trap

2019-08-20 Thread Allan W . Nielsen
Hi, This is fixing a bug introduced in b596229448dd2 Acked-by: Allan W. Nielsen /Allan The 08/20/2019 12:20, Yangbo Lu wrote: > External E-Mail > > > The trap action should be copying the frame to CPU and > dropping it for forwarding, but current setting was just > copying frame to CPU. >

Re: [PATCH net-next] net: openvswitch: Set OvS recirc_id from tc chain

2019-08-20 Thread Paul Blakey
On 8/20/2019 8:50 AM, Pravin Shelar wrote: > On Mon, Aug 19, 2019 at 10:42 AM Marcelo Ricardo Leitner > wrote: >> On Sun, Aug 18, 2019 at 07:00:59PM +0300, Paul Blakey wrote: >>> What do you guys say about the following diff on top of the last one? >>> Use static key, and also have OVS_DP_CMD_SET

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Björn Töpel
On 2019-08-20 03:36, YueHaibing wrote: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- kernel/bpf/xskmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/xskmap.c b/kernel/bpf/xskmap.c index 4cc28e226398..942c662e2eed 10

Re: [PATCH net-next 0/6] Dynamic toggling of vlan_filtering for SJA1105 DSA

2019-08-20 Thread Vivien Didelot
On Tue, 20 Aug 2019 02:59:56 +0300, Vladimir Oltean wrote: > This patchset addresses a few limitations in DSA and the bridge core > that made it impossible for this sequence of commands to work: > > ip link add name br0 type bridge > ip link set dev swp2 master br0 > echo 1 > /sys/class/net

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: > For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH > bpf-next" to let the developers know what tree you're aiming for. There are over 300 trees in linux-next. It impossible to try remember everyone's trees. No o

[PATCH net] gve: Copy and paste buy in gve_get_stats()

2019-08-20 Thread Dan Carpenter
There is a copy and paste error so we have "rx" where "tx" was intended in the priv->tx[] array. Fixes: f5cedc84a30d ("gve: Add transmit and receive support") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/google/gve/gve_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

RE: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Vakul Garg
Thanks for your response. > -Original Message- > From: Florian Westphal > Sent: Monday, August 19, 2019 11:08 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org > Subject: Re: Help needed - Kernel lockup while running ipsec > > Vakul Garg wrote: > > Hi > > > > With kernel 4.14.122, I am

Re: [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property

2019-08-20 Thread Sean Nyekjaer
On 29/04/2019 19.39, Rob Herring wrote: On Tue, 9 Apr 2019 10:39:49 +0200, Sean Nyekjaer wrote: add wakeup-source boolean property. Signed-off-by: Sean Nyekjaer --- Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Rob Herr

[PATCH v2 net] gve: Copy and paste bug in gve_get_stats()

2019-08-20 Thread Dan Carpenter
There is a copy and paste error so we have "rx" where "tx" was intended in the priv->tx[] array. Fixes: f5cedc84a30d ("gve: Add transmit and receive support") Signed-off-by: Dan Carpenter --- v2: fix a typo in the subject: buy -> bug (Thanks Walter Harms) drivers/net/ethernet/google/gve/gve_mai

Re: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Florian Westphal
Vakul Garg wrote: > > > With kernel 4.14.122, I am getting a kernel softlockup while running > > > single > > static ipsec tunnel. > > > The problem reproduces mostly after running 8-10 hours of ipsec encap > > test (on my dual core arm board). > > > > > > I found that in function xfrm_policy_loo

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Björn Töpel
On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: > > On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: > > For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH > > bpf-next" to let the developers know what tree you're aiming for. > > There are over 300 trees in lin

RE: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Vakul Garg
> -Original Message- > From: Florian Westphal > Sent: Tuesday, August 20, 2019 2:53 PM > To: Vakul Garg > Cc: Florian Westphal ; netdev@vger.kernel.org > Subject: Re: Help needed - Kernel lockup while running ipsec > > Vakul Garg wrote: > > > > With kernel 4.14.122, I am getting a ke

RE: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Vakul Garg
> > -Original Message- > > From: Florian Westphal > > Sent: Tuesday, August 20, 2019 2:53 PM > > To: Vakul Garg > > Cc: Florian Westphal ; netdev@vger.kernel.org > > Subject: Re: Help needed - Kernel lockup while running ipsec > > > > Vakul Garg wrote: > > > > > With kernel 4.14.122,

[PATCH bpf-next v2 5/5] tools: bpftool: implement "bpftool btf show|list"

2019-08-20 Thread Quentin Monnet
Add a "btf list" (alias: "btf show") subcommand to bpftool in order to dump all BTF objects loaded on a system. When running the command, hash tables are built in bpftool to retrieve all the associations between BTF objects and BPF maps and programs. This allows for printing all such associations

[PATCH bpf-next v2 1/5] bpf: add new BPF_BTF_GET_NEXT_ID syscall command

2019-08-20 Thread Quentin Monnet
Add a new command for the bpf() system call: BPF_BTF_GET_NEXT_ID is used to cycle through all BTF objects loaded on the system. The motivation is to be able to inspect (list) all BTF objects presents on the system. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- include/linux/bpf

[PATCH bpf-next v2 0/5] bpf: list BTF objects loaded on system

2019-08-20 Thread Quentin Monnet
Hi, This set adds a new command BPF_BTF_GET_NEXT_ID to the bpf() system call, adds the relevant API function in libbpf, and uses it in bpftool to list all BTF objects loaded on the system (and to dump the ids of maps and programs associated with them, if any). The main motivation of listing BTF ob

[PATCH bpf-next v2 4/5] libbpf: add bpf_btf_get_next_id() to cycle through BTF objects

2019-08-20 Thread Quentin Monnet
Add an API function taking a BTF object id and providing the id of the next BTF object in the kernel. This can be used to list all BTF objects loaded on the system. v2: - Rebase on top of Andrii's changes regarding libbpf versioning. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski ---

[PATCH bpf-next v2 2/5] tools: bpf: synchronise BPF UAPI header with tools

2019-08-20 Thread Quentin Monnet
Synchronise the bpf.h header under tools, to report the addition of the new BPF_BTF_GET_NEXT_ID syscall command for bpf(). Signed-off-by: Quentin Monnet --- tools/include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linu

[PATCH bpf-next v2 3/5] libbpf: refactor bpf_*_get_next_id() functions

2019-08-20 Thread Quentin Monnet
In preparation for the introduction of a similar function for retrieving the id of the next BTF object, consolidate the code from bpf_prog_get_next_id() and bpf_map_get_next_id() in libbpf. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- tools/lib/bpf/bpf.c | 21 --

Re: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Florian Westphal
Vakul Garg wrote: > > > > -Original Message- > > From: Florian Westphal > > Sent: Tuesday, August 20, 2019 2:53 PM > > To: Vakul Garg > > Cc: Florian Westphal ; netdev@vger.kernel.org > > Subject: Re: Help needed - Kernel lockup while running ipsec > > > > Vakul Garg wrote: > > > > >

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2019 at 11:25:29AM +0200, Björn Töpel wrote: > On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: > > > > On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: > > > For future patches: Prefix AF_XDP socket work with "xsk:" and use "PATCH > > > bpf-next" to let the developer

Re: [PATCH] can: flexcan: free error skb if enqueueing failed

2019-08-20 Thread Sean Nyekjaer
CC'ing Joakim Zhang On 15/07/2019 20.53, Martin Hundebøll wrote: If the call to can_rx_offload_queue_sorted() fails, the passed skb isn't consumed, so the caller must do so. Fixes: 30164759db1b ("can: flexcan: make use of rx-offload's irq_offload_fifo") Signed-off-by: Martin Hundebøll --- dr

[PATCH bpf-next] bpf: add BTF ids in procfs for file descriptors to BTF objects

2019-08-20 Thread Quentin Monnet
Implement the show_fdinfo hook for BTF FDs file operations, and make it print the id and the size of the BTF object. This allows for a quick retrieval of the BTF id from its FD; or it can help understanding what type of object (BTF) the file descriptor points to. Signed-off-by: Quentin Monnet Rev

RE: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Vakul Garg
> -Original Message- > From: Florian Westphal > Sent: Tuesday, August 20, 2019 3:08 PM > To: Vakul Garg > Cc: Florian Westphal ; netdev@vger.kernel.org > Subject: Re: Help needed - Kernel lockup while running ipsec > > Vakul Garg wrote: > > > > > > > -Original Message- > > >

Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well

2019-08-20 Thread Vladimir Oltean
Hi Vivien! On Tue, 20 Aug 2019 at 08:51, Vivien Didelot wrote: > > Vladimir, > > On Tue, 20 Aug 2019 02:59:59 +0300, Vladimir Oltean wrote: > > Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > > is littering a lot. After deleting a VLAN added on a DSA port, it still > >

Re: [PATCH] ipvs: change type of delta and previous_delta in ip_vs_seq.

2019-08-20 Thread Julian Anastasov
Hello, Cc list trimmed... On Tue, 20 Aug 2019, zhang kai wrote: > In NAT forwarding mode, Applications may decrease the size of packets, > and TCP sequences will get smaller, so both of variables will be negetive > values in this case. As long as nobody cares about the

RE: [PATCH] can: flexcan: free error skb if enqueueing failed

2019-08-20 Thread Joakim Zhang
> -Original Message- > From: Sean Nyekjaer > Sent: 2019年8月20日 17:50 > To: Martin Hundebøll ; Wolfgang Grandegger > ; Marc Kleine-Budde ; > linux-...@vger.kernel.org > Cc: David S . Miller ; netdev@vger.kernel.org; Joakim > Zhang > Subject: Re: [PATCH] can: flexcan: free error skb if enqu

Re: [PATCH net-next 0/6] Dynamic toggling of vlan_filtering for SJA1105 DSA

2019-08-20 Thread Vladimir Oltean
On Tue, 20 Aug 2019 at 11:04, Vivien Didelot wrote: > > On Tue, 20 Aug 2019 02:59:56 +0300, Vladimir Oltean wrote: > > This patchset addresses a few limitations in DSA and the bridge core > > that made it impossible for this sequence of commands to work: > > > > ip link add name br0 type bridge

Re: [PATCH net-next 4/6] net: dsa: Don't program the VLAN as pvid on the upstream port

2019-08-20 Thread Vladimir Oltean
Hi Vivien, On Tue, 20 Aug 2019 at 09:07, Vivien Didelot wrote: > > On Tue, 20 Aug 2019 03:00:00 +0300, Vladimir Oltean wrote: > > Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > > programs the VLAN from the bridge into the specified port as well as the > > upstream port

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-20 Thread Sean Nyekjaer
On 16/08/2019 10.20, Joakim Zhang wrote: As reproted by Sean Nyekjaer below: When suspending, when there is still can traffic on the interfaces the flexcan immediately wakes the platform again. As it should :-). But it throws this error msg: [ 3169.378661] PM: noirq suspend of devices failed

Capturing syscall arguments: `kprobe`, `kretprobe` or `tracepoint` or `raw_tracepoint` type programs

2019-08-20 Thread Tahsin Rahman
Hi, I'm new to ebpf. I want to write an ebpf program that can trace the syscall arguments and return values. According to my research, I can do this using `kprobe`, `kretprobe` or `tracepoint` or `raw_tracepoint` type of bpf programs. - What factors should I consider when choosing one type of prog

Re: [PATCH net-next 6/6] net: dsa: tag_8021q: Restore bridge pvid when enabling vlan_filtering

2019-08-20 Thread Vladimir Oltean
Hi Florian, On Tue, 20 Aug 2019 at 06:33, Florian Fainelli wrote: > > > > On 8/19/2019 5:00 PM, Vladimir Oltean wrote: > > The bridge core assumes that enabling/disabling vlan_filtering will > > translate into the simple toggling of a flag for switchdev drivers. > > > > That is clearly not the ca

RE: Help needed - Kernel lockup while running ipsec

2019-08-20 Thread Vakul Garg
> > > -Original Message- > > From: Florian Westphal > > Sent: Tuesday, August 20, 2019 3:08 PM > > To: Vakul Garg > > Cc: Florian Westphal ; netdev@vger.kernel.org > > Subject: Re: Help needed - Kernel lockup while running ipsec > > > > Vakul Garg wrote: > > > > > > > > > > -Orig

[PATCH net-next 0/2] netfilter: payload mangling offload support

2019-08-20 Thread Pablo Neira Ayuso
Hi, This patchset adds payload mangling offload support for Netfilter: 1) Adapt existing drivers to allow for mangling up to four 32-bit words with one single flow_rule action. Hence, once single action can be used to mangle an IPv6 address. 2) Add support for netfilter packet mangling. P

[PATCH net-next 2/2] netfilter: nft_payload: packet mangling offload support

2019-08-20 Thread Pablo Neira Ayuso
This patch allows for mangling packet fields using hardware offload infrastructure. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_payload.c | 82 + 1 file changed, 82 insertions(+) diff --git a/net/netfilter/nft_payload.c b/net/netfilter/nft_

[PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Pablo Neira Ayuso
The existing infrastructure needs the front-end to generate up to four actions (one for each 32-bit word) to mangle an IPv6 address. This patch allows you to mangle fields than are longer than 4-bytes with one single action. Drivers have been adapted to this new representation following a simple ap

RE: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-20 Thread Joakim Zhang
> -Original Message- > From: Sean Nyekjaer > Sent: 2019年8月20日 18:25 > To: Joakim Zhang ; m...@pengutronix.de; > linux-...@vger.kernel.org > Cc: w...@grandegger.com; netdev@vger.kernel.org; dl-linux-imx > ; Martin Hundebøll > Subject: Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Yuehaibing
On 2019/8/20 17:44, Dan Carpenter wrote: > On Tue, Aug 20, 2019 at 11:25:29AM +0200, Björn Töpel wrote: >> On Tue, 20 Aug 2019 at 10:59, Dan Carpenter wrote: >>> >>> On Tue, Aug 20, 2019 at 09:28:26AM +0200, Björn Töpel wrote: For future patches: Prefix AF_XDP socket work with "xsk:" and use

[RFC bpf-next 1/5] libbpf: Add map definition struct fields from iproute2

2019-08-20 Thread Toke Høiland-Jørgensen
The iproute2 bpf headers define four more fields for map definitions than libbpf does. This adds those fields to the libbpf headers, in preparation for porting the bpf loading functionality of iproute2 to be based on libbpf. Subsequent commits add the functionality needed in libbpf to be able to po

[RFC bpf-next 3/5] libbpf: Add support for specifying map pinning path via callback

2019-08-20 Thread Toke Høiland-Jørgensen
This adds a callback parameter that can be set in struct bpf_prog_load_attr which will allow the calling program to specify arbitrary paths for each map included in an ELF file being loaded. In particular, this allows iproute2 to implement its current semantics for map pinning on top of libbpf. S

[RFC bpf-next 2/5] libbpf: Add support for auto-pinning of maps with reuse on program load

2019-08-20 Thread Toke Høiland-Jørgensen
This adds support for automatically pinning maps on program load to libbpf. This is needed for porting iproute2 bpf support to libbpf, but is also useful in other contexts. The semantics are modelled on those of the same functionality in iproute2, namely: - A path can be supplied in bpf_prog_load

[RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-20 Thread Toke Høiland-Jørgensen
iproute2 uses its own bpf loader to load eBPF programs, which has evolved separately from libbpf. Since we are now standardising on libbpf, this becomes a problem as iproute2 is slowly accumulating feature incompatibilities with libbpf-based loaders. In particular, iproute2 has its own (expanded) v

[RFC bpf-next 4/5] iproute2: Allow compiling against libbpf

2019-08-20 Thread Toke Høiland-Jørgensen
This adds a configure check for libbpf and renames functions to allow lib/bpf.c to be compiled with it present. This makes it possible to port functionality piecemeal to use libbpf. Signed-off-by: Toke Høiland-Jørgensen --- configure | 16 include/bpf_util.h | 6 +++---

[RFC bpf-next 5/5] iproute2: Support loading XDP programs with libbpf

2019-08-20 Thread Toke Høiland-Jørgensen
This switches over loading of XDP programs to the using libbpf, if it is available. It uses the automatic pinning features added to libbpf to construct the same pinning paths as the libelf-based loader. Since map-in-map support has not yet been added to libbpf, this means that map-in-map definitio

[PATCH] xsk: fix ptr_ret.cocci warnings

2019-08-20 Thread kbuild test robot
From: kbuild test robot kernel/bpf/xskmap.c:24:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 0402acd683c6 ("xsk: remove AF_XDP socket from map when the socket is released") CC: B

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-20 Thread Sean Nyekjaer
Unfortunatly it's still possible to reproduce the deadlock with this patch... [ 689.921717] flexcan: probe of 2094000.flexcan failed with error -110 My test setup: PC with CAN-USB dongle connected to can0 and can1. PC: $ while true; do cansend can0 '123#DEADBEEF'; done iMX6ull: root@iwg26:

RE: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-20 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2019年8月20日 19:25 > To: Sean Nyekjaer ; m...@pengutronix.de; > linux-...@vger.kernel.org > Cc: w...@grandegger.com; netdev@vger.kernel.org; dl-linux-imx > ; Martin Hundebøll > Subject: RE: [PATCH REPOST 1/2] can: flexcan: fix deadlock when

Re: [PATCH net-next 4/6] net: dsa: Don't program the VLAN as pvid on the upstream port

2019-08-20 Thread Vladimir Oltean
Hi Florian, On Tue, 20 Aug 2019 at 06:15, Florian Fainelli wrote: > > > > On 8/19/2019 5:00 PM, Vladimir Oltean wrote: > > Commit b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > > programs the VLAN from the bridge into the specified port as well as the > > upstream port, with t

[PATCH net-next v2] net: openvswitch: Set OvS recirc_id from tc chain index

2019-08-20 Thread Paul Blakey
Offloaded OvS datapath rules are translated one to one to tc rules, for example the following simplified OvS rule: recirc_id(0),in_port(dev1),eth_type(0x0800),ct_state(-trk) actions:ct(),recirc(2) Will be translated to the following tc rule: $ tc filter add dev dev1 ingress \ prio 1

Re: [PATCH net-next v2] net: openvswitch: Set OvS recirc_id from tc chain index

2019-08-20 Thread Paul Blakey
Regarding the user_features change, I tested the above patch with this one in userspace that I'll send once this is accepted, togother with the rest of connection tracking offload patches. I also have a test for it, if anyone wants it. Patch is: lib/netdev-offloads-tc: Probe recirc tc sharing fea

Re: [PATCH net-next v2] net: openvswitch: Set OvS recirc_id from tc chain index

2019-08-20 Thread Paul Blakey
Regarding the user_features change, I tested the above patch with this one in userspace that I'll send once this is accepted, togother with the rest of connection tracking offload patches. I also have a test for it, if anyone wants it. Patch is: lib/netdev-offloads-tc: Probe recirc tc sharing fea

Re: [RFC PATCH net-next 03/11] spi: Add a PTP system timestamp to the transfer structure

2019-08-20 Thread Mark Brown
On Fri, Aug 16, 2019 at 05:05:53PM +0300, Vladimir Oltean wrote: > I'm not sure how to respond to this, because I don't know anything > about the timing of DMA transfers. > Maybe snapshotting DMA transfers the same way is not possible (if at > all). Maybe they are not exactly adequate for this sor

Re: [PATCH net-next v2] net: openvswitch: Set OvS recirc_id from tc chain index

2019-08-20 Thread Paul Blakey
Hey guys, sorry for spam, I used the --in-reply-to  this time so it gets to the original thread ("[PATCH net-next v2] net: openvswitch: Set OvS recirc_id from tc chain index") , Ignore this thread and respond there if needed. Thanks. On 8/20/2019 3:40 PM, Paul Blakey wrote: > Regarding the us

Re: [PATCH bpf-next] bpf: add BTF ids in procfs for file descriptors to BTF objects

2019-08-20 Thread Daniel Borkmann
On 8/20/19 11:52 AM, Quentin Monnet wrote: Implement the show_fdinfo hook for BTF FDs file operations, and make it print the id and the size of the BTF object. This allows for a quick retrieval of the BTF id from its FD; or it can help understanding what type of object (BTF) the file descriptor p

Re: [oss-drivers] Re: [PATCH bpf-next] bpf: add BTF ids in procfs for file descriptors to BTF objects

2019-08-20 Thread Quentin Monnet
2019-08-20 15:36 UTC+0200 ~ Daniel Borkmann > On 8/20/19 11:52 AM, Quentin Monnet wrote: >> Implement the show_fdinfo hook for BTF FDs file operations, and make it >> print the id and the size of the BTF object. This allows for a quick >> retrieval of the BTF id from its FD; or it can help underst

Re: [RFC PATCH net-next 03/11] spi: Add a PTP system timestamp to the transfer structure

2019-08-20 Thread Vladimir Oltean
Hi Mark, On Tue, 20 Aug 2019 at 15:55, Mark Brown wrote: > > On Fri, Aug 16, 2019 at 05:05:53PM +0300, Vladimir Oltean wrote: > > > I'm not sure how to respond to this, because I don't know anything > > about the timing of DMA transfers. > > Maybe snapshotting DMA transfers the same way is not po

[PATCH bpf-next v2] bpf: add BTF ids in procfs for file descriptors to BTF objects

2019-08-20 Thread Quentin Monnet
Implement the show_fdinfo hook for BTF FDs file operations, and make it print the id of the BTF object. This allows for a quick retrieval of the BTF id from its FD; or it can help understanding what type of object (BTF) the file descriptor points to. v2: - Do not expose data_size, only btf_id, in

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Edward Cree
On 20/08/2019 11:52, Pablo Neira Ayuso wrote: > The existing infrastructure needs the front-end to generate up to four > actions (one for each 32-bit word) to mangle an IPv6 address. This patch > allows you to mangle fields than are longer than 4-bytes with one single > action. Drivers have been ad

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Pablo Neira Ayuso
On Tue, Aug 20, 2019 at 03:15:16PM +0100, Edward Cree wrote: > On 20/08/2019 11:52, Pablo Neira Ayuso wrote: > > The existing infrastructure needs the front-end to generate up to four > > actions (one for each 32-bit word) to mangle an IPv6 address. This patch > > allows you to mangle fields than a

[PATCH net-next 8/9] s390/ctcm: don't use intparm for channel IO

2019-08-20 Thread Julian Wiedmann
ctcm passes an intparm when calling ccw_device_*(), even though ctcm_irq_handler() later makes no use of this. To reduce the confusion, consistently pass 0 as intparm instead. Signed-off-by: Julian Wiedmann Reviewed-by: Sebastian Ott --- drivers/s390/net/ctcm_fsms.c | 42 ++

[PATCH net-next 3/9] s390/qeth: use correct length field in SNMP cmd callback

2019-08-20 Thread Julian Wiedmann
qeth_snmp_command_cb() is the only cmd callback that pulls the reply's data length from a low-level transport header field. This requires additional complexity (ie. reply->offset) to make the header accessible to what is supposed to be a pure IPA cmd callback. Adapter cmds have a length field in t

[PATCH net-next 4/9] s390/qeth: keep cmd alive after IO completion

2019-08-20 Thread Julian Wiedmann
Current code releases the cmd struct after its initial IO has completed. Any reply processing is done independently, using a separate qeth_reply struct. In preparation for merging the cmd and reply structs together, take an additional reference on the cmd object so that it stays around all the way

[PATCH net-next 6/9] s390/qeth: get vnicc sub-cmd type from reply data

2019-08-20 Thread Julian Wiedmann
When processing the reply for a vnicc cmd, there's no need to remember which specific sub-cmd type we initially sent. The reply itself contains all the needed information. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_l2_main.c | 21 + 1 file changed, 5 insertions(

[PATCH net-next 0/9] s390/net: updates 2019-08-20

2019-08-20 Thread Julian Wiedmann
Hi Dave, please apply the following patches to net-next. This series brings a mix of cleanups and small improvements for various parts of qeth's control path. Also, a minor cleanup for ctcm and lcs. Thanks, Julian Julian Wiedmann (9): s390/qeth: use node_descriptor struct s390/qeth: propaga

[PATCH net-next 1/9] s390/qeth: use node_descriptor struct

2019-08-20 Thread Julian Wiedmann
Rather than fumbling with hard-coded offsets, use the proper struct to access the retrieved RCD information. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 +- drivers/s390/net/qeth_core_main.c | 31 +++ 2 files changed, 24 insertions(+), 9

[PATCH net-next 2/9] s390/qeth: propagate length of processed cmd IO data to callback

2019-08-20 Thread Julian Wiedmann
When an cmd IO completes in qeth_irq(), calculate how much data was processed by the device and pass this value to the cmd's callback. This allows cmds that retrieve data from the device to check whether sufficient data was received, so we do that in qeth_read_conf_data_cb(). Suggested-by: Jens R

[PATCH net-next 5/9] s390/qeth: merge qeth_reply struct into qeth_cmd_buffer

2019-08-20 Thread Julian Wiedmann
Except for card->read_cmd, every cmd we issue now passes through qeth_send_control_data() and allocates a qeth_reply struct. The way we use this struct requires additional refcounting, and pointer tracking. Clean up things by moving most of qeth_reply's content into the main cmd struct. This keeps

[PATCH net-next 9/9] s390/lcs: don't use intparm for channel IO

2019-08-20 Thread Julian Wiedmann
lcs passes an intparm when calling ccw_device_*(), even though lcs_irq() later makes no use of this. To reduce the confusion, consistently pass 0 as intparm instead. Signed-off-by: Julian Wiedmann Reviewed-by: Sebastian Ott --- drivers/s390/net/lcs.c | 6 +++--- 1 file changed, 3 insertions(+)

[PATCH net-next 7/9] s390/qeth: streamline control code for promisc mode

2019-08-20 Thread Julian Wiedmann
We have logic to determine the desired promisc mode in _each_ code path. Change things around so that there is a clean split between (a) high-level code that selects the new mode, and (b) implementations of the various mechanisms to program this mode. This also keeps qeth_promisc_to_bridge() from

Re: [PATCH -next] bpf: Use PTR_ERR_OR_ZERO in xsk_map_inc()

2019-08-20 Thread Daniel Borkmann
On 8/20/19 3:36 AM, YueHaibing wrote: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing Applied, thanks!

Re: [PATCH bpf-next v2] bpf: add BTF ids in procfs for file descriptors to BTF objects

2019-08-20 Thread Daniel Borkmann
On 8/20/19 3:53 PM, Quentin Monnet wrote: Implement the show_fdinfo hook for BTF FDs file operations, and make it print the id of the BTF object. This allows for a quick retrieval of the BTF id from its FD; or it can help understanding what type of object (BTF) the file descriptor points to. v2:

Re: [PATCH bpf-next V9 1/3] bpf: new helper to obtain namespace data from current task

2019-08-20 Thread Carlos Antonio Neira Bustos
Hi Yonghong, Thanks for taking the time to review this. > > + * > > + * **-EINVAL** if *size_of_pidns* is not valid or unable to get > > ns, pid > > + * or tgid of the current task. > > + * > > + * **-ECHILD** if /proc/self/ns/pid does not exists. > > + * > > + *

Re: [PATCH 1/1] net: rds: add service level support in rds-info

2019-08-20 Thread Doug Ledford
On Mon, 2019-08-19 at 20:52 -0400, Zhu Yanjun wrote: > diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h > index fd6b5f6..cba368e 100644 > --- a/include/uapi/linux/rds.h > +++ b/include/uapi/linux/rds.h > @@ -250,6 +250,7 @@ struct rds_info_rdma_connection { > __u32

Re: [v3] ocelot_ace: fix action of trap

2019-08-20 Thread Andrew Lunn
On Tue, Aug 20, 2019 at 09:05:20AM +0200, Allan W . Nielsen wrote: > Hi, > > This is fixing a bug introduced in b596229448dd2 Hi Allan You should express that as: Fixes: b596229448dd ("net: mscc: ocelot: Add support for tcam") Andrew

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-20 Thread Vladimir Oltean
On Sun, 18 Aug 2019 at 21:26, Vladimir Oltean wrote: > > This patchset proposes an interface from the SPI subsystem for > software timestamping SPI transfers. There is a default implementation > provided in the core, as well as a mechanism for SPI slave drivers to > check which byte was in fact ti

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Edward Cree
On 20/08/2019 15:44, Pablo Neira Ayuso wrote: > It looks to me this limitation is coming from tc pedit. > > Four actions to mangle an IPv6 address consume more memory when making > the translation, and if you expect a lot of rules. Your change means that now every pedit uses four hw entries, even i

[PATCH v1] ocfs2/dlm: Move BITS_TO_BYTES() to bitops.h for wider use

2019-08-20 Thread Andy Shevchenko
There are users already and will be more of BITS_TO_BYTES() macro. Move it to bitops.h for wider use. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h | 1 - fs/ocfs2/dlm/dlmcommon.h | 4 include/linux/bitops.h

Re: [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15

2019-08-20 Thread Doug Ledford
On Thu, 2019-08-15 at 19:46 +, Saeed Mahameed wrote: > Hi All, > > This series includes misc updates for mlx5-next shared branch. > > mlx5 HW spec and bits updates: > 1) Aya exposes IP-in-IP capability in mlx5_core. > 2) Maxim exposes lag tx port affinity capabilities. > 3) Moshe adds VNIC_EN

Re: [RFC PATCH net-next 03/11] spi: Add a PTP system timestamp to the transfer structure

2019-08-20 Thread Mark Brown
On Tue, Aug 20, 2019 at 04:48:39PM +0300, Vladimir Oltean wrote: > On Tue, 20 Aug 2019 at 15:55, Mark Brown wrote: > > On Fri, Aug 16, 2019 at 05:05:53PM +0300, Vladimir Oltean wrote: > > > Maybe the SPI master driver should just report what sort of > > > snapshotting capability it can offer, ran

Re: [PATCH bpf-next v2 0/5] bpf: list BTF objects loaded on system

2019-08-20 Thread Alexei Starovoitov
On Tue, Aug 20, 2019 at 2:32 AM Quentin Monnet wrote: > > Hi, > This set adds a new command BPF_BTF_GET_NEXT_ID to the bpf() system call, > adds the relevant API function in libbpf, and uses it in bpftool to list > all BTF objects loaded on the system (and to dump the ids of maps and > programs as

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-20 Thread Andrew Lunn
> - Ethernet has support for hardware timestamping True, but not all drivers support it. Marvell switches are often combined with Marvell MACs. None of the Marvell MAC drivers, mv643xx, mvneta, mvpp2 or octeontx2 support hardware timestamping. My guess is, the hardware probably supports it, but n

Re: [PATCH bpf-next V9 1/3] bpf: new helper to obtain namespace data from current task

2019-08-20 Thread Yonghong Song
On 8/20/19 8:10 AM, Carlos Antonio Neira Bustos wrote: > Hi Yonghong, > > Thanks for taking the time to review this. > > >>> + * >>> + * **-EINVAL** if *size_of_pidns* is not valid or unable to get >>> ns, pid >>> + * or tgid of the current task. >>> + * >>> + * **-ECH

pull-request: can-next 2019-08-20

2019-08-20 Thread Marc Kleine-Budde
git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-5.4-20190820 for you to fetch changes up to df58525df395561551440392d92daa6416b4f8f3: can: mcp251x: remove custom DMA mapped buffer (2019-

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Pablo Neira Ayuso
On Tue, Aug 20, 2019 at 05:00:26PM +0100, Edward Cree wrote: > On 20/08/2019 15:44, Pablo Neira Ayuso wrote: > > It looks to me this limitation is coming from tc pedit. > > > > Four actions to mangle an IPv6 address consume more memory when making > > the translation, and if you expect a lot of rul

Re: [PATCH net-next 6/6] net: dsa: tag_8021q: Restore bridge pvid when enabling vlan_filtering

2019-08-20 Thread Florian Fainelli
On 8/20/19 3:28 AM, Vladimir Oltean wrote: > Hi Florian, > > On Tue, 20 Aug 2019 at 06:33, Florian Fainelli wrote: >> >> >> >> On 8/19/2019 5:00 PM, Vladimir Oltean wrote: >>> The bridge core assumes that enabling/disabling vlan_filtering will >>> translate into the simple toggling of a flag for

Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well

2019-08-20 Thread Vivien Didelot
Hi Vladimir, On Tue, 20 Aug 2019 12:54:44 +0300, Vladimir Oltean wrote: > I can agree that this isn't one of my brightest moments. But at least > we get to see Cunningham's law in action :) > When dsa_8021q is cleaning up the switch's VLAN table for the bridge > to use it, it is good to really cl

Re: [PATCH rdma-next 0/3] RDMA RX RoCE Steering Support

2019-08-20 Thread Doug Ledford
On Mon, 2019-08-19 at 14:36 +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This series from Mark extends mlx5 with RDMA_RX RoCE flow steering > support > for DEVX and QP objects. > > Thanks > > Mark Zhang (3): > net/mlx5: Add per-namespace flow table default miss action su

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Edward Cree
On 20/08/2019 18:33, Pablo Neira Ayuso wrote: > I can update tc pedit to generate one single action for offset > consecutive packet editions, if that is the concern, I'll send a v2. IMHO the fix belongs in TC userland (i.e. iproute2), to turn a single action on the commandline for an ipv6 addr int

Re: [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages

2019-08-20 Thread Mark Brown
On Sun, Aug 18, 2019 at 09:25:56PM +0300, Vladimir Oltean wrote: > /* Extract head of queue */ > - ctlr->cur_msg = > - list_first_entry(&ctlr->queue, struct spi_message, queue); > + mesg = list_first_entry(&ctlr->queue, struct spi_message, queue); > + ctlr->cur_msg =

VRF notes when using ipv6 and flushing tables.

2019-08-20 Thread Ben Greear
I recently spend a few days debugging what in the end was user error on my part. Here are my notes in hope they help someone else. First, 'ip -6 route show vrf vrfX' will not show some of the routes (like local routes) that will show up with 'ip -6 route show table X', where X == vrfX's table-id

Re: [PATCH net-next 1/2] net: flow_offload: mangle 128-bit packet field with one action

2019-08-20 Thread Pablo Neira Ayuso
On Tue, Aug 20, 2019 at 07:15:10PM +0100, Edward Cree wrote: > On 20/08/2019 18:33, Pablo Neira Ayuso wrote: > > I can update tc pedit to generate one single action for offset > > consecutive packet editions, if that is the concern, I'll send a v2. > IMHO the fix belongs in TC userland (i.e. iprout

Re: [PATCHv2 0/2] fix dev null pointer dereference when send pkg larger than mtu in collect_md mode

2019-08-20 Thread David Miller
From: Hangbin Liu Date: Mon, 19 Aug 2019 15:53:25 +0800 > Subject: [PATCHv2 0/2] fix dev null pointer dereference when send pkg larger > than mtu in collect_md mode Please don't use the word "package" or the shorthand "pkg" when referring to network packets. Always use the full word "packets".

Re: [PATCH net-next 0/2] netfilter: payload mangling offload support

2019-08-20 Thread Jakub Kicinski
On Tue, 20 Aug 2019 12:48:05 +0200, Pablo Neira Ayuso wrote: > Hi, > > This patchset adds payload mangling offload support for Netfilter: > > 1) Adapt existing drivers to allow for mangling up to four 32-bit words >with one single flow_rule action. Hence, once single action can be >used t

Re: [net PATCH] net/smc: make sure EPOLLOUT is raised

2019-08-20 Thread David Miller
From: Jason Baron Date: Mon, 19 Aug 2019 14:36:01 -0400 > Currently, we are only explicitly setting SOCK_NOSPACE on a write timeout > for non-blocking sockets. Epoll() edge-trigger mode relies on SOCK_NOSPACE > being set when -EAGAIN is returned to ensure that EPOLLOUT is raised. > Expand the set

Re: [PATCH net-next v2 0/6] net: dsa: enable and disable all ports

2019-08-20 Thread David Miller
From: Vivien Didelot Date: Mon, 19 Aug 2019 16:00:47 -0400 > The DSA stack currently calls the .port_enable and .port_disable switch > callbacks for slave ports only. However, it is useful to call them for all > port types. For example this allows some drivers to delay the optimization > of power

Re: [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages

2019-08-20 Thread Vladimir Oltean
Hi Mark, On Tue, 20 Aug 2019 at 21:21, Mark Brown wrote: > > On Sun, Aug 18, 2019 at 09:25:56PM +0300, Vladimir Oltean wrote: > > > /* Extract head of queue */ > > - ctlr->cur_msg = > > - list_first_entry(&ctlr->queue, struct spi_message, queue); > > + mesg = list_first_

Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well

2019-08-20 Thread Florian Fainelli
On 8/20/19 10:52 AM, Vivien Didelot wrote: > Hi Vladimir, > > On Tue, 20 Aug 2019 12:54:44 +0300, Vladimir Oltean wrote: >> I can agree that this isn't one of my brightest moments. But at least >> we get to see Cunningham's law in action :) >> When dsa_8021q is cleaning up the switch's VLAN table

Re: [PATCH][V2] net: fix __ip_mc_inc_group usage

2019-08-20 Thread David Miller
From: Li RongQing Date: Tue, 20 Aug 2019 13:52:47 +0800 > in ip_mc_inc_group, memory allocation flag, not mcast mode, is expected > by __ip_mc_inc_group > > similar issue in __ip_mc_join_group, both mcase mode and gfp_t are needed > here, so use ip_mc_inc_group(...) > > Fixes: 9fb20801dab4

[net-next v2 06/16] net/mlx5e: Add cq info to tx reporter diagnose

2019-08-20 Thread Saeed Mahameed
From: Aya Levin Add cq information to general diagnose output: CQ size and stride size. Per SQ add information about the related CQ: cqn and CQ's HW status. $ devlink health diagnose pci/:00:0b.0 reporter tx Common Config: SQ: stride size: 64 size: 1024 CQ: stride size: 64 s

[pull request][net-next v2 00/16] Mellanox, mlx5 devlink RX health reporters

2019-08-20 Thread Saeed Mahameed
Hi Dave, This series is adding a new devlink health reporter for RX related errors from Aya. Last two patches from Vlad and Gavi, are trivial fixes for previously submitted patches on this release cycle. v1->v2: - Improve reversed xmas tree variable declaration. - Rebase on top of net-next to

  1   2   3   >