Re: [PATCH net-next v3 7/8] virtio-net: poll tx call xsk zerocopy xmit

2021-04-06 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: poll tx call virtnet_xsk_run, then the data in the xsk tx queue will be continuously consumed by napi. Signed-off-by: Xuan Zhuo Reviewed-by: Dust Li I think we need squash this into patch 4, it looks more like a bug fix to me. --- drivers/net/virti

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Michal Kubecek
On Tue, Apr 06, 2021 at 08:55:41AM +0800, Yunsheng Lin wrote: > > Hi, Jiri > Do you have a reproducer that can be shared here? > With reproducer, I can debug and test it myself too. I'm afraid we are not aware of a simple reproducer. As mentioned in the original discussion, the race window is ext

Re: [PATCH net-next v3 8/8] virtio-net: free old xmit handle xsk

2021-04-06 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: Based on the last two bit of ptr returned by virtqueue_get_buf, 01 represents the packet sent by xdp, 10 is the packet sent by xsk, and 00 is skb by default. If the xmit work of xsk has not been completed, but the ring is full, napi must first exit and wait fo

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-06 Thread Danilo Krummrich
On Tue, Apr 06, 2021 at 12:30:11AM +0200, Danilo Krummrich wrote: > On Mon, Apr 05, 2021 at 09:27:44PM +0200, Andrew Lunn wrote: > > > Now, instead of encoding this information of the bus' capabilities at both > > > places, I'd propose just checking the mii_bus->capabilities field in the > > > mdio

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Michal Kubecek
On Tue, Apr 06, 2021 at 10:46:29AM +0800, Yunsheng Lin wrote: > On 2021/4/6 9:49, Cong Wang wrote: > > On Sat, Apr 3, 2021 at 5:23 AM Jiri Kosina wrote: > >> > >> I am still planning to have Yunsheng Lin's (CCing) fix [1] tested in the > >> coming days. If it works, then we can consider proceeding

[PATCH net v3] net: hsr: Reset MAC header for Tx path

2021-04-06 Thread Kurt Kanzenbach
Reset MAC header in HSR Tx path. This is needed, because direct packet transmission, e.g. by specifying PACKET_QDISC_BYPASS does not reset the MAC header. This has been observed using the following setup: |$ ip link add name hsr0 type hsr slave1 lan0 slave2 lan1 supervision 45 version 1 |$ ifcon

Re: [PATCH v2] nfc: s3fwrn5: remove unnecessary label

2021-04-06 Thread Krzysztof Kozlowski
On 06/04/2021 03:59, samirweng1979 wrote: > From: wengjianfeng > > In function s3fwrn5_nci_post_setup, the variable ret is assigned then > goto out label, which just return ret, so we use return to replace it. > Other goto sentences are similar, we use return sentences to replace > goto sentences

Re: esp-hw-offload support for VF of NVIDIA Mellanox ConnectX-6 Ethernet Adapter Cards

2021-04-06 Thread 高钧浩
Ping ... Saeed Mahameed 于2021年3月30日周二 上午5:05写道: > > On Mon, 2021-03-29 at 16:42 +0800, 高钧浩 wrote: > > Hi Boris,Saeed > > > > I'm enabling esp-hw-offload for VF of NVIDIA Mellanox ConnectX-6 > > Ethernet Adapter Cards, but it doesn't work. > > Before I created VF, the esp-hw-offload func

[PATCH net-next v4] net: Allow to specify ifindex when device is moved to another namespace

2021-04-06 Thread Andrei Vagin
Currently, we can specify ifindex on link creation. This change allows to specify ifindex when a device is moved to another network namespace. Even now, a device ifindex can be changed if there is another device with the same ifindex in the target namespace. So this change doesn't introduce comple

iproute2 ERSPAN version 2 JSON output shows valueless key

2021-04-06 Thread Christian Pössinger
Dear Maintainers, I am new to the reporting process for iproute2 thus please bear with me. I am playing around with ERSPAN version 2 and noticed a valueless key on the JSON output for iproute2. When creating an ERSPAN interface using the following command: $ ip link add dev myerspan type erspan

Re: Something is leaking RCU holds from interrupt context

2021-04-06 Thread Peter Zijlstra
On Sun, Apr 04, 2021 at 11:24:57AM +0100, Matthew Wilcox wrote: > On Sat, Apr 03, 2021 at 09:15:17PM -0700, syzbot wrote: > > HEAD commit:2bb25b3a Merge tag 'mips-fixes_5.12_3' of git://git.kernel.. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=1284c

RE: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

2021-04-06 Thread Salil Mehta
Hi Dave, Hope I am not missing something and not sure how this patchwork bot works, the patch was sent for -net repo (i.e. bug fixes branch) but it got applied to the -net-next repo. > Subject: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of > vector_ring_chain variable [...] > Hello

Re: [PATCH] net/Bluetooth - use the correct print format

2021-04-06 Thread Marcel Holtmann
Hi Kai, > Use the correct print format. Printing an unsigned int value should use %u > instead of %d. For details, please read document: > Documentation/core-api/printk-formats.rst > > Signed-off-by: Kai Ye > --- > net/bluetooth/l2cap_core.c | 16 > 1 file changed, 8 insertions(+

Re: [PATCH 0/2] Bluetooth: Avoid centralized adv handle tracking for extended features

2021-04-06 Thread Marcel Holtmann
Hi Daniel, > This series addresses a race condition where an advertisement > registration can conflict with a software rotation advertisement > refresh. I found that this issue was only occurring with the new > extended MGMT advertising interface. A bad use of the > hdev->cur_adv_instance caused e

linux-next: manual merge of the tty tree with the net-next tree

2021-04-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tty tree got a conflict in: net/nfc/nci/uart.c between commit: d3295869c40c ("net: nfc: Fix spelling errors in net/nfc module") from the net-next tree and commit: c2a5a45c0276 ("net: nfc: nci: drop nci_uart_ops::recv_buf") from the tty tree. I f

Re: [PATCH net-next v5] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-04-06 Thread Xie He
On Mon, Apr 5, 2021 at 11:17 PM Martin Schiller wrote: > > Acked-by: Martin Schiller > > Just for the record: I'm certainly not always the fastest, > but I don't work holidays or weekends. So you also need to have some > patience. Oh. Thank you! Sorry, I didn't know there was a holiday in German

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Michael Walle
Am 2021-04-06 00:13, schrieb Andrew Lunn: On Mon, Apr 05, 2021 at 11:46:04PM +0200, Michael Walle wrote: Hi Andrew, Am 2021-04-05 23:34, schrieb Andrew Lunn: > > -static int of_get_mac_addr_nvmem(struct device_node *np, u8 addr) > > +static int of_get_mac_addr_nvmem(struct device_node *np, u8 *

[PATCH v2 0/1] net/mlx5: Remove duplicated header file inclusion

2021-04-06 Thread Zhen Lei
v1 --> v2: Arrange all included header files in alphabetical order. Zhen Lei (1): net/mlx5: Remove duplicated header file inclusion drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) -- 1.8.3

[PATCH v2 1/1] net/mlx5: Remove duplicated header file inclusion

2021-04-06 Thread Zhen Lei
Delete one of the header files "esw/indir_table.h" that are included twice, all included header files are then rearranged alphabetically. Signed-off-by: Zhen Lei --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) di

RE: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac

2021-04-06 Thread Voon, Weifeng
> > > You have a MAC and an PCS in the stmmac IP block. That then has some > > > sort of SERDES interface, running 1000BaseX, SGMII, SGMII > > > overclocked at 2.5G or 25000BaseX. Connected to the SERDES you have > > > a PHY which converts to copper, giving you 2500BaseT. > > > > > > You said earli

Re: [PATCH net-next 1/3] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol

2021-04-06 Thread Tobias Waldekranz
On Sun, Mar 28, 2021 at 17:24, Andrew Lunn wrote: > On Fri, Mar 26, 2021 at 11:56:46AM +0100, Tobias Waldekranz wrote: >> All devices are capable of using regular DSA tags. Support for >> Ethertyped DSA tags sort into three categories: >> >> 1. No support. Older chips fall into this category. >>

Re: linux-next: manual merge of the tty tree with the net-next tree

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:48:14PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > net/nfc/nci/uart.c > > between commit: > > d3295869c40c ("net: nfc: Fix spelling errors in net/nfc module") > > from the net-next tree and commit:

Re: [PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-04-06 Thread Tobias Waldekranz
On Sat, Mar 27, 2021 at 12:13, Rob Herring wrote: > On Fri, Mar 26, 2021 at 11:56:48AM +0100, Tobias Waldekranz wrote: >> The 'dsa,tag-protocol' is used to force a switch tree to use a >> particular tag protocol, typically because the Ethernet controller >> that it is connected to is not compatibl

gianfar driver and GFAR_MQ_POLLING

2021-04-06 Thread Rasmus Villemoes
Hi, I noticed that gfar_of_init() has if (of_device_is_compatible(np, "fsl,etsec2")) { mode = MQ_MG_MODE; poll_mode = GFAR_SQ_POLLING; } else { mode = SQ_SG_MODE; poll_mode = GFAR_SQ_POLLING; } i.e., poll_mod

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-06 Thread Kalle Valo
"Maciej S. Szmigiero" writes: > On 29.03.2021 00:54, Maciej S. Szmigiero wrote: >> Hi, >> >> It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS, >> since the driver does not update its beacon to account for TIM changes, >> so a station that is sleeping will never learn that

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2021-04-06 Thread Daniel Palmer
Hi Willy, I've been messing with the SSD202D (sibling of the MSC313E) recently and the ethernet performance was awful. I remembered this revert and reverted it and it makes the ethernet work pretty well. So I would like to find some way of making this patch work and I did some digging.. On Thu,

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-04-06 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Sat, Apr 3, 2021 at 10:47 AM Alexei Starovoitov > wrote: >> >> On Sat, Apr 03, 2021 at 12:38:06AM +0530, Kumar Kartikeya Dwivedi wrote: >> > On Sat, Apr 03, 2021 at 12:02:14AM IST, Alexei Starovoitov wrote: >> > > On Fri, Apr 2, 2021 at 8:27 AM Kumar Kartikeya Dwived

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月6日 14:29 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > > Subject: Re:

[PATCH net-next v1 1/1] stmmac: intel: Drop duplicate ID in the list of PCI device IDs

2021-04-06 Thread Andy Shevchenko
The PCI device IDs are defined with a prefix PCI_DEVICE_ID. There is no need to repeat the ID part at the end of each definition. Signed-off-by: Andy Shevchenko --- .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 60 +-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --g

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Juergen Gross
On 06.04.21 09:06, Michal Kubecek wrote: On Tue, Apr 06, 2021 at 08:55:41AM +0800, Yunsheng Lin wrote: Hi, Jiri Do you have a reproducer that can be shared here? With reproducer, I can debug and test it myself too. I'm afraid we are not aware of a simple reproducer. As mentioned in the origin

Re: [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK processing

2021-04-06 Thread Phillip Potter
On Mon, Apr 05, 2021 at 02:59:21PM -0700, David Miller wrote: > From: Phillip Potter > Date: Mon, 5 Apr 2021 12:35:55 +0100 > > > When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len > > to match the appropriate type, using new tun_get_addr_len utility function > > which retu

Re: [PATCHv4 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-06 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > On Mon, Apr 05, 2021 at 05:24:48PM -0700, John Fastabend wrote: >> Hangbin Liu wrote: >> > This patch add two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to >> > extend >> > xdp_redirect_map for broadcast support. >> > >> > Keep the general data path in net/core/filter

[PATCH v2] net: tun: set tun->dev->addr_len during TUNSETLINK processing

2021-04-06 Thread Phillip Potter
When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len to match the appropriate type, using new tun_get_addr_len utility function which returns appropriate address length for given type. Fixes a KMSAN-found uninit-value bug reported by syzbot at: https://syzkaller.appspot.com/bug?

RE: gianfar driver and GFAR_MQ_POLLING

2021-04-06 Thread Claudiu Manoil
>-Original Message- >From: Rasmus Villemoes >Sent: Tuesday, April 6, 2021 12:56 PM >To: Claudiu Manoil >Cc: Network Development ; Vladimir Oltean >; Ioana Ciornei ; Esben >Haabendal >Subject: gianfar driver and GFAR_MQ_POLLING > >Hi, > >I noticed that gfar_of_init() has > > if (of_

[PATCH v2 1/1] time64.h: Consolidated PSEC_PER_SEC definition

2021-04-06 Thread Andy Shevchenko
We have currently three users of the PSEC_PER_SEC each of them defining it individually. Instead, move it to time64.h to be available for everyone. There is a new user coming with the same constant in use. It will also make its life easier. Signed-off-by: Andy Shevchenko Acked-by: Heiko Stuebner

Re: [PATCH net-next] mt76: mt7921: remove unneeded semicolon

2021-04-06 Thread Kalle Valo
Qiheng Lin writes: > Eliminate the following coccicheck warning: > drivers/net/wireless/mediatek/mt76/mt7921/mac.c:1402:2-3: Unneeded semicolon > > Signed-off-by: Qiheng Lin mt76 patches go to the mt76 tree maintained by Felix, not to net-next. -- https://patchwork.kernel.org/project/linux-w

pull-request: can 2021-04-06

2021-04-06 Thread Marc Kleine-Budde
truct batadv_tvlv_tt_vlan_data"->reserved field (2021-04-05 15:06:03 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-5.12-20210406 for you to fetch changes up to 617085fca6375e2c1667d1fbfc6adc4034c

[net] can: mcp251x: fix support for half duplex SPI host controllers

2021-04-06 Thread Marc Kleine-Budde
Some SPI host controllers do not support full-duplex SPI transfers. The function mcp251x_spi_trans() does a full duplex transfer. It is used in several places in the driver, where a TX half duplex transfer is sufficient. To fix support for half duplex SPI host controllers, this patch introduces a

Re: [PATCH net-next v2 0/5] net: pch: fix and a few cleanups

2021-04-06 Thread Andy Shevchenko
On Tue, Mar 30, 2021 at 07:46:58AM +, Flavio Suligoi wrote: > Hi Andy, > ... > > On Thu, Mar 25, 2021 at 07:34:07PM +0200, Andy Shevchenko wrote: > > > The series provides one fix (patch 1) for GPIO to be able to wait for > > > the GPIO driver to appear. This is separated from the conversion to

Re: [PATCHv4 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-06 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > This patch add two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend > xdp_redirect_map for broadcast support. > > Keep the general data path in net/core/filter.c and the native data > path in kernel/bpf/devmap.c so we can use direct calls to get better > performace.

Re: [PATCH net-next 9/9] net: enetc: add support for XDP_REDIRECT

2021-04-06 Thread Toke Høiland-Jørgensen
Vladimir Oltean writes: > On Sat, Apr 03, 2021 at 01:07:29PM +0200, Toke Høiland-Jørgensen wrote: >> Vladimir Oltean writes: >> >> > On Thu, Apr 01, 2021 at 10:38:21PM +0300, Vladimir Oltean wrote: >> >> On Thu, Apr 01, 2021 at 08:01:42PM +0200, Toke Høiland-Jørgensen wrote: >> >> > Vladimir Ol

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Heiner Kallweit
On 06.04.2021 12:07, Joakim Zhang wrote: > >> -Original Message- >> From: Heiner Kallweit >> Sent: 2021年4月6日 14:29 >> To: Joakim Zhang ; christian.me...@t2data.com; >> and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; >> k...@kernel.org >> Cc: netdev@vger.kernel.org; linux-ker..

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-06 Thread Jason Gunthorpe
On Mon, Apr 05, 2021 at 11:42:31PM +, Chuck Lever III wrote: > We need to get a better idea what correctness testing has been done, > and whether positive correctness testing results can be replicated > on a variety of platforms. RO has been rolling out slowly on mlx5 over a few years and st

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-06 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 08:09:43AM +0300, Leon Romanovsky wrote: > On Tue, Apr 06, 2021 at 10:37:38AM +0800, Honggang LI wrote: > > On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > From Avihai, > > > > > > Relaxed Ordering is a PCIe mechani

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-06 Thread Maciej S. Szmigiero
On 06.04.2021 12:00, Kalle Valo wrote: "Maciej S. Szmigiero" writes: On 29.03.2021 00:54, Maciej S. Szmigiero wrote: Hi, It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS, since the driver does not update its beacon to account for TIM changes, so a station that is slee

[PATCH net-next] rfkill: use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- net/rfkill/input.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/rfkill/inp

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-06 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 08:58:54AM +0300, Leon Romanovsky wrote: > On Tue, Apr 06, 2021 at 07:27:17AM +0200, Christoph Hellwig wrote: > > On Tue, Apr 06, 2021 at 08:23:28AM +0300, Leon Romanovsky wrote: > > > The same proposal (enable unconditionally) was raised during > > > submission preparations

[PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- .../realtek/rtlwifi/rtl8192de/sw.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Yunsheng Lin
On 2021/4/6 18:13, Juergen Gross wrote: > On 06.04.21 09:06, Michal Kubecek wrote: >> On Tue, Apr 06, 2021 at 08:55:41AM +0800, Yunsheng Lin wrote: >>> >>> Hi, Jiri >>> Do you have a reproducer that can be shared here? >>> With reproducer, I can debug and test it myself too. >> >> I'm afraid we are

Re: [PATCH v3] ip-nexthop: support flush by id

2021-04-06 Thread Ido Schimmel
On Tue, Apr 06, 2021 at 09:33:23AM +0800, Chunmei Xu wrote: > since id is unique for nexthop, it is heavy to dump all nexthops. > use existing delete_nexthop to support flush by id > > Signed-off-by: Chunmei Xu Reviewed-by: Ido Schimmel Tested-by: Ido Schimmel Thanks

Re: [PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-06 Thread Alexander Aring
Hi, On Mon, 5 Apr 2021 at 15:58, Pavel Skripkin wrote: > > syzbot reported shift-out-of-bounds in nl802154_new_interface. > The problem was in signed representation of enum nl802154_iftype > > enum nl802154_iftype { > /* for backwards compatibility TODO */ > NL802154_IFTYPE_UNSPEC

[PATCH net-next 00/28] Netfilter updates for net-next

2021-04-06 Thread Pablo Neira Ayuso
Hi, The following batch contains Netfilter/IPVS updates for your net-next tree: 1) Simplify log infrastructure modularity: Merge ipv4, ipv6, bridge, netdev and ARP families to nf_log_syslog.c. Add module softdeps. This fixes a rare deadlock condition that might occur when log module auto

[PATCH net-next 01/28] netfilter: nf_log_ipv4: rename to nf_log_syslog

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal Netfilter has multiple log modules: nf_log_arp nf_log_bridge nf_log_ipv4 nf_log_ipv6 nf_log_netdev nfnetlink_log nf_log_common With the exception of nfnetlink_log (packet is sent to userspace for dissection/logging), all of them log to the kernel ringbuffer. This i

[PATCH net-next 03/28] netfilter: nf_log_ipv6: merge with nf_log_syslog

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal This removes the nf_log_ipv6 module, the functionality is now provided by nf_log_syslog. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/Kconfig | 5 +- net/ipv6/netfilter/Makefile | 3 - net/ipv6/netfilter/nf_log_i

[PATCH net-next 02/28] netfilter: nf_log_arp: merge with nf_log_syslog

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal similar to previous change: nf_log_syslog now covers ARP logging as well, the old nf_log_arp module is removed. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/Kconfig | 5 +- net/ipv4/netfilter/Makefile | 3 - net/ip

[PATCH net-next 05/28] netfilter: nf_log_bridge: merge with nf_log_syslog

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal Provide bridge log support from nf_log_syslog. After the merge there is no need to load the "real packet loggers", all of them now reside in the same module. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_log.h | 1

[PATCH net-next 04/28] netfilter: nf_log_netdev: merge with nf_log_syslog

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal Provide netdev family support from the nf_log_syslog module. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig | 4 -- net/netfilter/Makefile| 3 -- net/netfilter/nf_log_netdev.c | 78 ---

[PATCH net-next 07/28] netfilter: nf_log: add module softdeps

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal xt_LOG has no direct dependency on the syslog-based logger, it relies on the nf_log core to probe the requested backend. Now that all syslog-based loggers reside in the same module, we can just add a soft dependency on nf_log_syslog and let modprobe take care of it. Signe

[PATCH net-next 06/28] netfilter: nf_log_common: merge with nf_log_syslog

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal Remove nf_log_common. Now that all per-af modules have been merged there is no longer a need to provide a helper module. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_log.h | 24 net/netfilter/Kconfig | 8

[PATCH net-next 12/28] netfilter: nftables: remove unnecessary spin_lock_init()

2021-04-06 Thread Pablo Neira Ayuso
From: Yang Yingliang The spinlock nf_tables_destroy_list_lock is initialized statically. It is unnecessary to initialize by spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 1 - 1 file changed, 1 dele

[PATCH net-next 08/28] netfilter: nft_log: perform module load from nf_tables

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal modprobe calls from the nf_logger_find_get() API causes deadlock in very special cases because they occur with the nf_tables transaction mutex held. In the specific case of nf_log, deadlock is via: A nf_tables -> transaction mutex -> nft_log -> modprobe -> nf_log_syslog

[PATCH net-next 10/28] netfilter: ipset: Remove duplicate declaration

2021-04-06 Thread Pablo Neira Ayuso
From: Wan Jiabing struct ip_set is declared twice. One is declared at 79th line, so remove the duplicate. Signed-off-by: Wan Jiabing Acked-by: Jozsef Kadlecsik Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter/ipset/ip_set.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/inc

[PATCH net-next 09/28] audit: log nftables configuration change events once per table

2021-04-06 Thread Pablo Neira Ayuso
From: Richard Guy Briggs Reduce logging of nftables events to a level similar to iptables. Restore the table field to list the table, adding the generation. Indicate the op as the most significant operation in the event. A couple of sample events: type=PROCTITLE msg=audit(2021-03-18 09:30:49.8

[PATCH net-next 13/28] netfilter: nftables: add helper function to set the base sequence number

2021-04-06 Thread Pablo Neira Ayuso
This patch adds a helper function to calculate the base sequence number field that is stored in the nfnetlink header. Use the helper function whenever possible. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 23 ++- 1 file changed, 14 insertions(+), 9 de

[PATCH net-next 16/28] netfilter: nftables: fix a warning message in nf_tables_commit_audit_collect()

2021-04-06 Thread Pablo Neira Ayuso
From: Dan Carpenter The first argument of a WARN_ONCE() is a condition. This WARN_ONCE() will only print the table name, and is potentially problematic if the table name has a %s in it. Fixes: c520292f29b8 ("audit: log nftables configuration change events once per table") Signed-off-by: Dan Ca

[PATCH net-next 22/28] netfilter: nf_defrag_ipv4: use net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal This allows followup patch to remove the defrag_ipv4 member from struct net. It also allows to auto-remove the hooks later on by adding a _disable() function. This will be done later in a follow patch series. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ay

[PATCH net-next 20/28] netfilter: cttimeout: use net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal reduce size of struct net and make this self-contained. The member in struct net is kept to minimize changes to struct net layout, it will be removed in a separate patch. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink_cttime

[PATCH net-next 18/28] netfilter: nfnetlink: add and use nfnetlink_broadcast

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal This removes the only reference of net->nfnl outside of the nfnetlink module. This allows to move net->nfnl to net_generic infra. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter/nfnetlink.h | 2 ++ net/netfilter/nfnetlink.c

[PATCH net-next 14/28] netfilter: add helper function to set up the nfnetlink header and use it

2021-04-06 Thread Pablo Neira Ayuso
This patch adds a helper function to set up the netlink and nfnetlink headers. Update existing codebase to use it. Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter/nfnetlink.h | 27 +++ net/netfilter/ipset/ip_set_core.c| 17 + net/netfilter/nf_conntrack_netlink.c | 77

[PATCH net-next 17/28] netfilter: nftables: remove documentation on static functions

2021-04-06 Thread Pablo Neira Ayuso
Since 4f16d25c68ec ("netfilter: nftables: add nft_parse_register_load() and use it") and 345023b0db31 ("netfilter: nftables: add nft_parse_register_store() and use it"), the following functions are not exported symbols anymore: - nft_parse_register() - nft_validate_register_load() - nft_validate_r

[PATCH net-next 11/28] netfilter: flowtable: dst_check() from garbage collector path

2021-04-06 Thread Pablo Neira Ayuso
Move dst_check() to the garbage collector path. Stale routes trigger the flow entry teardown state which makes affected flows go back to the classic forwarding path to re-evaluate flow offloading. IPv6 requires the dst cookie to work, store it in the flow_tuple, otherwise dst_check() always fails.

[PATCH net-next 15/28] netfilter: ipvs: do not printk on netns creation

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal This causes dmesg spew during normal operation, so remove this. Signed-off-by: Florian Westphal Acked-by: Julian Anastasov Reviewed-by: Simon Horman Signed-off-by: Pablo Neira Ayuso --- net/netfilter/ipvs/ip_vs_ftp.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH net-next 23/28] netfilter: ebtables: use net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal ebtables currently uses net->xt.tables[BRIDGE], but upcoming patch will move net->xt.tables away from struct net. To avoid exposing x_tables internals to ebtables, use a private list instead. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/brid

[PATCH net-next 19/28] netfilter: nfnetlink: use net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal No need to place it in struct net, nfnetlink is a module and usage doesn't occur in fastpath. Also remove rcu usage: Not a single reader of net->nfnl uses rcu accessors. When exit_batch callbacks are executed the net namespace is already dead so no calls to these functio

[PATCH net-next 24/28] netfilter: nf_tables: use net_generic infra for transaction data

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal This moves all nf_tables pernet data from struct net to a net_generic extension, with the exception of the gencursor. The latter is used in the data path and also outside of the nf_tables core. All others are only used from the configuration plane. Signed-off-by: Florian

[PATCH net-next 21/28] netfilter: nf_defrag_ipv6: use net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal This allows followup patch to remove these members from struct net. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/ipv6/nf_defrag_ipv6.h | 6 ++ net/ipv6/netfilter/nf_conntrack_reasm.c | 68 +++-- net/ipv6

[PATCH net-next 25/28] netfilter: x_tables: move known table lists to net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal Will reduce struct net size by 208 bytes. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/x_tables.c | 46 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/net/netfilter/x_tables.

[PATCH net-next 26/28] netfilter: conntrack: move sysctl pointer to net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal No need to keep this in struct net, place it in the net_generic data. The sysctl pointer is removed from struct net in a followup patch. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_conntrack.h| 3 +++ net/netfilter/

[PATCH net-next 27/28] netfilter: conntrack: move ecache dwork to net_generic infra

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal dwork struct is large (>128 byte) and not needed when conntrack module is not loaded. Place it in net_generic data instead. The struct net dwork member is now obsolete and will be removed in a followup patch. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ay

[PATCH net-next 28/28] net: remove obsolete members from struct net

2021-04-06 Thread Pablo Neira Ayuso
From: Florian Westphal all have been moved to generic_net infra. On x86_64, this reduces struct net size from 70 to 63 cache lines (4480 to 4032 byte). Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/net_namespace.h | 9 - include/net/netns/conntrack

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2021-04-06 Thread Yunsheng Lin
On 2021/4/6 15:31, Michal Kubecek wrote: > On Tue, Apr 06, 2021 at 10:46:29AM +0800, Yunsheng Lin wrote: >> On 2021/4/6 9:49, Cong Wang wrote: >>> On Sat, Apr 3, 2021 at 5:23 AM Jiri Kosina wrote: I am still planning to have Yunsheng Lin's (CCing) fix [1] tested in the coming days.

[PATCH net-next] mlxsw: core: Remove critical trip points from thermal zones

2021-04-06 Thread Ido Schimmel
From: Vadim Pasternak Disable software thermal protection by removing critical trip points from all thermal zones. The software thermal protection is redundant given there are two layers of protection below it in firmware and hardware. The first layer is performed by firmware, the second, in cas

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-06 Thread Christoph Hellwig
On Tue, Apr 06, 2021 at 09:13:12AM -0300, Jason Gunthorpe wrote: > So we broadly have two choice > 1) Diverge the kernel and user interfaces and make the RDMA drivers > special case all the kernel stuff to force > ACCESS_RELAXED_ORDERING when they are building MRs and processing > FMR

Re: [PATCH net-next v1 1/1] stmmac: intel: Drop duplicate ID in the list of PCI device IDs

2021-04-06 Thread Wong Vee Khee
On Tue, Apr 06, 2021 at 01:13:06PM +0300, Andy Shevchenko wrote: > The PCI device IDs are defined with a prefix PCI_DEVICE_ID. > There is no need to repeat the ID part at the end of each definition. > > Signed-off-by: Andy Shevchenko Reviewed-by: Wong Vee Khee > --- > .../net/ethernet/stmicro

[igb] netconsole triggers warning in netpoll_poll_dev

2021-04-06 Thread Oleksandr Natalenko
Hello. I've raised this here [1] first, but was suggested to engage igb devs, so here we are. I'm experiencing the following woes while using netconsole regularly: ``` [22038.710800] [ cut here ] [22038.710801] igb_poll+0x0/0x1440 [igb] exceeded budget in poll [22038.7108

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Andrew Lunn
> But then pdev will be NULL and nvmem_get_mac_address() won't be called > at all, no? Forget it, it can be added later if there is a real use case. Andrew

Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-06 Thread Andrew Lunn
> > Speed: 2500Mb/s and Duplex: Half is very unlikely. You really only > > ever see 10 Half and occasionally 100 Half. Anything above that will > > be full duplex. > > > > It is probably best to admit the truth and use DUPLEX_UNKNOWN. > > Agreed. I didn't notice this "lie" until I was writing the

[PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Anirudh Rayabharam
Multiple ttys try to claim the same the minor number causing a double unregistration of the same device. The first unregistration succeeds but the next one results in a null-ptr-deref. The get_free_serial_index() function returns an available minor number but doesn't assign it immediately. The ass

[PATCH net] net: hns3: clear VF down state bit before request link status

2021-04-06 Thread Huazhong Tan
From: Guangbin Huang Currently, the VF down state bit is cleared after VF sending link status request command. There is problem that when VF gets link status replied from PF, the down state bit may still set as 1. In this case, the link status replied from PF will be ignored and always set VF lin

[PATCH net v1 1/1] ethtool: fix incorrect datatype in set_eee ops

2021-04-06 Thread Wong Vee Khee
The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool header file. Hence, we should use ethnl_update_u32() in set_eee ops. Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request") Cc: # 5.10.x Cc: Michal Kubecek Signed-off-by: Wong Vee Khee --- net/ethtool/eee.c

Re: [PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-06 Thread Pavel Skripkin
On Tue, 2021-04-06 at 08:21 -0400, Alexander Aring wrote: > Hi, > > On Mon, 5 Apr 2021 at 15:58, Pavel Skripkin > wrote: > > > > syzbot reported shift-out-of-bounds in nl802154_new_interface. > > The problem was in signed representation of enum nl802154_iftype > > > > enum nl802154_iftype { > >

Re: [PATCH net-next 1/3] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol

2021-04-06 Thread Andrew Lunn
> Since DSA is supported on all devices, perhaps we should just have: > > enum mv88e6xxx_edsa_support { > MV88E6XXX_EDSA_UNSUPPORTED, > MV88E6XXX_EDSA_UNDOCUMENTED, > MV88E6XXX_EDSA_SUPPORTED, > }; Yes, that is O.K. > Do we also want to default to DSA on all devices unless there

Re: [PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-04-06 Thread Andrew Lunn
> Andrew, Vladimir: I will just list dsa and edsa for now. If it is needed > on other devices, people can add them to the list after they have tested > their drivers. Fair? O.K. Andrew

[iproute2] finding the name of a TAP created with %d

2021-04-06 Thread Alyssa Ross
If I do ip tuntap add name tap%d mode tap then a TAP device with a name like "tap0", "tap1", etc. will be created. But there's no way for me to find out which name was chosen for the device created by that command. Perhaps ip should print the name of tuntap devices after they're created?

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-06 Thread Jason Gunthorpe
On Tue, Apr 06, 2021 at 02:30:34PM +0200, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 09:13:12AM -0300, Jason Gunthorpe wrote: > > So we broadly have two choice > > 1) Diverge the kernel and user interfaces and make the RDMA drivers > > special case all the kernel stuff to force > >

Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:13:59PM +0530, Anirudh Rayabharam wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index() functio

Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:13:59PM +0530, Anirudh Rayabharam wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index() functio

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-06 Thread Christoph Hellwig
On Tue, Apr 06, 2021 at 11:04:37AM -0300, Jason Gunthorpe wrote: > It might be idiodic, but I have to keep the uverbs thing working > too. > > There is a lot of assumption baked in to all the drivers that > user/kernel is the same thing, we'd have to go in and break this. > > Essentially #2 ends

[RFC net-next 0/4] MT7530 interrupt support

2021-04-06 Thread DENG Qingfang
Add support for MT7530 interrupt controller. DENG Qingfang (4): net: phy: add MediaTek PHY driver net: dsa: mt7530: add interrupt support dt-bindings: net: dsa: add MT7530 interrupt controller binding staging: mt7621-dts: enable MT7530 interrupt controller .../devicetree/bindings/net/dsa

[RFC net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread DENG Qingfang
Add support for MediaTek PHYs found in MT7530 and MT7531 switches. The initialization procedure is from the vendor driver, but due to lack of documentation, the function of some register values remains unknown. Signed-off-by: DENG Qingfang --- drivers/net/phy/Kconfig| 5 ++ drivers/net/phy

  1   2   3   4   >