Re: [PATCH] net/macb: add config for Atmel sama5d2 SoCs

2015-06-18 Thread Alexandre Belloni
= sama5d3_config }, { .compatible = atmel,sama5d4-gem, .data = sama5d4_config }, { .compatible = cdns,at91rm9200-emac, .data = emac_config }, -- 2.1.3 -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list

Re: [PATCH v2 0/4] net/macb: add sama5d2 support

2015-06-18 Thread Alexandre Belloni
: bindings doc: add sama5d2 compatibility sting Documentation/devicetree/bindings/net/macb.txt | 5 +++-- drivers/net/ethernet/cadence/macb.c| 8 2 files changed, 11 insertions(+), 2 deletions(-) For the patch set: Acked-by: Alexandre Belloni alexandre.bell...@free

Re: [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support

2015-07-23 Thread Alexandre Belloni
On 23/07/2015 at 15:44:25 +0530, Harini Katakam wrote : JUMBO and NO_GIGABIT_HALF have the same capability masks. Change one of them. Signed-off-by: Harini Katakam hari...@xilinx.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com -- Alexandre Belloni, Free Electrons

[PATCH 2/2] phy: micrel: Disable auto negotiation on startup

2016-02-26 Thread Alexandre Belloni
-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/net/phy/micrel.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index a5e265b2bbfb..dc85f7095e51 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/mi

[PATCH 1/2] phy: micrel: Ensure interrupts are reenabled on resume

2016-02-26 Thread Alexandre Belloni
: 321beec5047a (net: phy: Use interrupts when available in NOLINK state) Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/net/phy/micrel.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/micrel.c b/drivers/n

[PATCH 0/2] phy: micrel: fix issues with interrupt on atmel boards

2016-02-26 Thread Alexandre Belloni
and I wondering whether this is related to that kind of issue. I had a quick look at the history and could'nt find its use. Alexandre Belloni (2): phy: micrel: Ensure interrupts are reenabled on resume phy: micrel: Disable auto negotiation on startup drivers/net/phy/micrel.c | 28

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-05-19 Thread Alexandre Belloni
o be handled properly. I believe Alexandre Belloni's patch > would do the trick: > > http://www.spinics.net/lists/netdev/msg373324.html > > Or has this been fixed in some other way already? > I don't think it has, last time I checked, Florian was still thinking about it. -- Ale

[PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
configured at boot time. To solve that, ensure the state machine is called as soon as the state changes from READY to UP. Fixes: d5c3d84657db ("net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS") Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> ---

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
On 16/04/2016 at 00:30:26 +0200, Andrew Lunn wrote : > On Sat, Apr 16, 2016 at 12:17:11AM +0200, Alexandre Belloni wrote: > > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > > > > Trace without my patch: > > > > libphy: MACB_mii_bus: probed > > >

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
g with a cable plugged in. Unplugging and replugging the cable makes the link detection work fine even without the patch. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-15 Thread Alexandre Belloni
On 15/04/2016 at 13:10:12 -0700, Florian Fainelli wrote : > On 15/04/16 12:56, Alexandre Belloni wrote: > > Commit d5c3d84657db ("net: phy: Avoid polling PHY with > > PHY_IGNORE_INTERRUPTS") removed the last polling done on the phy. Since > > then, the last actu

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-18 Thread Alexandre Belloni
;priv = bp; > - bp->mii_bus->parent = >dev->dev; > + bp->mii_bus->parent = >pdev->dev; > pdata = dev_get_platdata(>pdev->dev); > > dev_set_drvdata(>dev->dev, bp->mii_bus); Works fine. But still, this doesn't

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-04-18 Thread Alexandre Belloni
On 15/04/2016 at 15:23:39 -0700, Florian Fainelli wrote : > On 15/04/16 15:17, Alexandre Belloni wrote: > > On 16/04/2016 at 00:05:08 +0200, Andrew Lunn wrote : > >>> Trace without my patch: > >>> libphy: MACB_mii_bus: probed > >>> macb f8020

Re: [RESEND PATCH 1/1] can: m_can: fix bitrate setup on latest silicon

2017-02-20 Thread Alexandre Belloni
probably be built on top of it anyway. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[PATCH] wireless/atmel: remove time_t usage

2017-02-23 Thread Alexandre Belloni
last_qual never really holds a time. It only holds jiffies. Make it the same type as jiffies. Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> --- drivers/net/wireless/atmel/atmel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wi

Re: wireless/atmel: remove time_t usage

2017-03-08 Thread Alexandre Belloni
Hi, On 08/03/2017 at 15:13:40 +, Kalle Valo wrote: > Alexandre Belloni <alexandre.bell...@free-electrons.com> wrote: > > last_qual never really holds a time. It only holds jiffies. Make it the > > same type as jiffies. > > > > Signed-off-by: Alexandr

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-26 Thread Alexandre Belloni
On 25/04/2017 at 22:09:11 +0200, Alexandre Belloni wrote: > Hi, > > On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote: > > Hello David! > > > > > 25 апр. 2017 г., в 17:36, David Miller <da...@davemloft.net> написал(а): > > > > &

[PATCH] net: macb: fix phy interrupt parsing

2017-04-26 Thread Alexandre Belloni
Since 83a77e9ec415, the phydev irq is explicitly set to PHY_POLL when there is no pdata. It doesn't work on DT enabled platforms because the phydev irq is already set by libphy before. Fixes: 83a77e9ec415 ("net: macb: Added PCI wrapper for Platform Driver.") Signed-off-by: Alexand

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-25 Thread Alexandre Belloni
ely reverted after Alexander's patch. I had to test on v4.7 because we are not using interrupts on those boards since v4.8 (another issue to be fixed). As Florian pointed out, at the time I sent my patch, I didn't have time to investigate whether this was affecting other phys, see https://lkml.

Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function

2017-05-16 Thread Alexandre Belloni
's been a week since I sent this patch series. Any comments? > > > > Looks good, added to linux-can-next. > > Isn't this a fix for linux-can instead? > > At least it would make no sense to me to have the upgraded M_CAN driver in > Linux 4.12 without this fix. > The

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
roll <ulli.kr...@googlemail.com> > CC: Vladimir Zapolskiy <v...@mleia.com> > CC: Sylvain Lemieux <slemieux.t...@gmail.com> > CC: Barry Song <bao...@kernel.org> > CC: Maxime Ripard <maxime.rip...@free-electrons.com> > CC: Chen-Yu Tsai <w...@csie.org> > CC: Thierry Reding <thierry.red...@gmail.com> > CC: Jonathan Hunter <jonath...@nvidia.com> > CC: linux-te...@vger.kernel.org > CC: patc...@opensource.wolfsonmicro.com > CC: "Rafael J. Wysocki" <r...@rjwysocki.net> > CC: Pavel Machek <pa...@ucw.cz> > CC: Len Brown <len.br...@intel.com> > CC: linux...@vger.kernel.org > > 1.9.1 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
e unusual. > Or not, having an RTC set in the past is actually quite common. I'd find it weird to have a new device boot and be set to a date in the future. Also note that the threshold or offset thing may seem like a good idea but fails with many RTCs because of how they handle leap years. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
On 21/06/2017 at 10:19:49 +0100, Russell King - ARM Linux wrote: > On Wed, Jun 21, 2017 at 10:39:07AM +0200, Alexandre Belloni wrote: > > On 21/06/2017 at 09:51:52 +0200, Pavel Machek wrote: > > > If someone uses different threshold, well, there will be > > > co

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > > rely on 32bits varia

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > > > > > On 20/06/2017 at 11:35:08 +0200,

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
fixups once > per class, not once per driver. Yes, I'm in the middle of the whole rework that allows that. I don't understand the sudden urgency of fixing that and the amount of bikeshedding, seeing that the closest cutoff date is actually 31st of december 2069 in the rtc subsystem and that anyway the current 32bit userspace will explode in february 2038. My plan from the beginning was to have something for the next stable. I know nobody can read my mind but again, I don't think there is currently any urgency to change anything. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > <alexandre.bell...@free-electrons.com>: > > >> Yes, that's argument against ch

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Alexandre Belloni
to work > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches <j...@perches.com> For RTC: Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> -- Alexandr

[PATCH net-next v3 2/7] net: phy: mscc-miim: Add MDIO driver

2018-05-14 Thread Alexandre Belloni
Add a driver for the Microsemi MII Management controller (MIIM) found on Microsemi SoCs. On Ocelot, there are two controllers, one is connected to the internal PHYs, the other one can communicate with external PHYs. Reviewed-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Alexandre B

[PATCH net-next v3 1/7] dt-bindings: net: add DT bindings for Microsemi MIIM

2018-05-14 Thread Alexandre Belloni
DT bindings for the Microsemi MII Management Controller found on Microsemi SoCs Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- .../devicetree/bindings/net/mscc

[PATCH net-next v3 0/7] Microsemi Ocelot Ethernet switch support

2018-05-14 Thread Alexandre Belloni
tried switching to NAPI but this is not working well, mainly because the only way to disable interrupts is to actually mask them in the interrupt controller (it is not possible to tell the switch to stop generating interrupts). Cc: James Hogan <jho...@kernel.org> Alexandre Belloni (7)

[PATCH net-next v3 3/7] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-05-14 Thread Alexandre Belloni
DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- .../devicetree/bindings/net/mscc-ocelot.txt | 82 +++ 1 file changed, 8

[PATCH net-next v3 5/7] MIPS: mscc: Add switch to ocelot

2018-05-14 Thread Alexandre Belloni
Ocelot has an integrated switch, add support for it. Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot.dtsi | 88 + 1 file changed, 88 insertions(+) diff --git a/arch/m

[PATCH net-next v3 6/7] MIPS: mscc: connect phys to ports on ocelot_pcb123

2018-05-14 Thread Alexandre Belloni
Add phy to switch port connections for PCB123 for internal PHYs. Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 20 1 file changed, 20 insertions(+) diff --git

[PATCH net-next v3 7/7] MAINTAINERS: Add entry for Microsemi Ethernet switches

2018-05-14 Thread Alexandre Belloni
Add myself as a maintainer for the Microsemi Ethernet switches. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0a1410d5a621..b632deb3f503 100644 --- a/MAINTAINERS

Re: [PATCH net-next v2 5/7] MIPS: mscc: Add switch to ocelot

2018-04-27 Thread Alexandre Belloni
ch have internal PHYs? > > I'm just wondering if they should be linked together by default. Or a > comment added to the commit message about why they are not linked > together here. > They are dual media ports so they are not necessarily using the integrated PHY but can use SerDEs1G lanes. I'll add that to the commit message. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH net-next v2 4/7] net: mscc: Add initial Ocelot switch support

2018-04-27 Thread Alexandre Belloni
having interfaces from different switches in the same bridge. Anyway, this is definitively not something we want because of the limited bandwidth of the CPU port. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

[PATCH net-next 2/2] net: mscc: ocelot: add VLAN filtering

2018-05-18 Thread Alexandre Belloni
From: Antoine Tenart <antoine.ten...@bootlin.com> Add hardware VLAN filtering offloading on ocelot. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drivers/net/ethernet/m

[PATCH net-next 0/2] net: mscc; ocelot: add more features

2018-05-18 Thread Alexandre Belloni
Hi, This series adds link aggregation and VLAN filtering hardware offload support to the ocelot driver. PTP is also on the list of features but it will probably not be submitted this cycle. Alexandre Belloni (1): net: mscc: ocelot: add bonding support Antoine Tenart (1): net: mscc: ocelot

[PATCH net-next 1/2] net: mscc: ocelot: add bonding support

2018-05-18 Thread Alexandre Belloni
Add link aggregation hardware offload support for Ocelot. ocelot_get_link_ksettings() is not great but it does work until the driver is reworked to switch to phylink. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drivers/net/ethernet/mscc/ocelot.c

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

2018-05-18 Thread Alexandre Belloni
X identifier. > The MIT license does allow sublicensing, so > it does seem you can choose what additional > license restrictions you can assert as long > as the original MIT license is also followed. > Then all is good. -- Alexandre Belloni, Bootlin (formerly Free Electrons

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

2018-05-18 Thread Alexandre Belloni
On 17/05/2018 18:13:25-0700, Joe Perches wrote: > On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > > > > ocelot_qsys.h is m

Re: [PATCH net-next v3 0/7] Microsemi Ocelot Ethernet switch support

2018-05-16 Thread Alexandre Belloni
f you want me to resend. Anyway, I'll probably send another patch to enable the driver in board-ocelot.config -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

[PATCH net-next ] net: mscc: Add SPDX identifier

2018-05-17 Thread Alexandre Belloni
ocelot_qsys.h is missing the SPDX identfier, fix that. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drivers/net/ethernet/mscc/ocelot_qsys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mscc/ocelot_qsys.h b/drivers/net/et

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

2018-05-17 Thread Alexandre Belloni
On 17/05/2018 12:28:59-0700, Joe Perches wrote: > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > > ocelot_qsys.h is missing the SPDX identfier, fix that. > > > > Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> > > Only the

Re: [PATCH net-next] net: mscc: simplify retrieving the tag type from the frame header

2018-07-16 Thread Alexandre Belloni
Antoine Tenart Reviewed-by: Alexandre Belloni > --- > drivers/net/ethernet/mscc/ocelot_board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/ocelot_board.c > b/drivers/net/ethernet/mscc/ocelot_board.c > index 18df7d934e81..26b

Re: [PATCH 26/39] rtc/proc: switch to proc_create_single_data

2018-04-19 Thread Alexandre Belloni
void rtc_proc_add_device(struct rtc_device *rtc) > { > if (is_rtc_hctosys(rtc)) > - proc_create_data("driver/rtc", 0, NULL, _proc_fops, rtc); > + proc_create_single_data("driver/rtc", 0, NULL, rtc_proc_show, > + rtc); > } > > void rtc_proc_del_device(struct rtc_device *rtc) > -- > 2.17.0 > -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

[PATCH] net: phy: allow scanning busses with missing phys

2018-04-24 Thread Alexandre Belloni
at this address and set the phy ID to 0x which is then properly handled in get_phy_device(). Suggested-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drivers/net/phy/phy_device.c | 11 ++- 1 file changed, 10 inse

Re: [PATCH] net: phy: allow scanning busses with missing phys

2018-04-24 Thread Alexandre Belloni
On 24/04/2018 09:37:09-0700, Florian Fainelli wrote: > > > On 04/24/2018 09:09 AM, Alexandre Belloni wrote: > > Some MDIO busses will error out when trying to read a phy address with no > > phy present at that address. In that case, probing the bus will fail > >

Re: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

2018-04-24 Thread Alexandre Belloni
g packets to the host (i.e. forwarding frames received on the port to the cpu port) is separate from bridging ports together. So after that command, the host can receive packets on lan0. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

2018-03-30 Thread Alexandre Belloni
On 23/03/2018 at 14:41:25 -0700, Florian Fainelli wrote: > On 03/23/2018 01:11 PM, Alexandre Belloni wrote: > > Add a driver for Microsemi Ocelot Ethernet switch support. > > > > This makes two modules: > > mscc_ocelot_common handles all the common features tha

Re: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

2018-03-30 Thread Alexandre Belloni
forwarding frames. And this is the case because b53_enable_port() does put 0 in B53_PORT_CTRL. The fact is that ocelot doesn't have separate controls. The port is either forwarding or not. If it is not forwarding, then there is nothing to tell the HW to do. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH net-next 3/8] net: mscc: Add MDIO driver

2018-03-29 Thread Alexandre Belloni
On 23/03/2018 at 21:49:39 +0100, Andrew Lunn wrote: > On Fri, Mar 23, 2018 at 09:11:12PM +0100, Alexandre Belloni wrote: > > Add a driver for the Microsemi MII Management controller (MIIM) found on > > Microsemi SoCs. > > On Ocelot, there are two controllers, one is conn

Re: [PATCH net-next 3/8] net: mscc: Add MDIO driver

2018-03-29 Thread Alexandre Belloni
ds like the correct fix is for get_phy_id() to look at the > error code for mdiobus_read(bus, addr, MII_PHYSID1). If it is EIO and > maybe ENODEV, set *phy_id to 0x and return. The scan code > should then do the correct thing. > That could work indeed. Do you want me to test and send a patch? -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH net-next 3/8] net: mscc: Add MDIO driver

2018-03-29 Thread Alexandre Belloni
c_miim_read(bus, i, MII_PHYSID1) < 0) > > + bus->phy_mask |= BIT(i); > > + } > > What is this used for? You have an OF MDIO bus which would create a > phy_device for each node specified, is this a similar workaround to what > drivers/net/phy/mdio-bcm-unimac.c

Re: [PATCH net-next 1/8] net: phy: Add initial support for Microsemi Ocelot internal PHYs.

2018-03-28 Thread Alexandre Belloni
On 23/03/2018 at 14:08:10 -0700, Florian Fainelli wrote: > On 03/23/2018 01:11 PM, Alexandre Belloni wrote: > > Add Microsemi Ocelot internal PHY ids. For now, simply use the genphy > > functions but more features are available. > > > > Cc: Raju Lakkaraju <raju.lakka

Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

2018-03-19 Thread Alexandre Belloni
net/davicom/Kconfig | 2 +- > drivers/net/ethernet/smsc/Kconfig| 6 +++--- > drivers/net/wireless/cisco/Kconfig | 2 +- > drivers/pwm/Kconfig | 2 +- > drivers/rtc/Kconfig | 2 +- Acked-by: Alexandre Belloni <alexandre.bell...@bootlin.com>

Re: [PATCH net-next 6/8] MIPS: mscc: Add switch to ocelot

2018-03-23 Thread Alexandre Belloni
On 23/03/2018 at 14:17:48 -0700, Florian Fainelli wrote: > On 03/23/2018 01:11 PM, Alexandre Belloni wrote: > > + > > + phy0: ethernet-phy@0 { > > + reg = <0>; > > + }; > > +

[PATCH net-next 2/8] dt-bindings: net: add DT bindings for Microsemi MIIM

2018-03-23 Thread Alexandre Belloni
DT bindings for the Microsemi MII Management Controller found on Microsemi SoCs Cc: Rob Herring <robh...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- .../devicetree/bindings/net/mscc-miim.txt | 25 ++ 1 file changed, 2

[PATCH net-next 7/8] MIPS: mscc: connect phys to ports on ocelot_pcb123

2018-03-23 Thread Alexandre Belloni
Add phy to switch port connections for PCB123 for internal PHYs. Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 16 1 file changed, 16 insertions(+) diff --git a/ar

[PATCH net-next 8/8] MAINTAINERS: Add entry for Microsemi Ethernet switches

2018-03-23 Thread Alexandre Belloni
Add myself as a maintainer for the Microsemi Ethernet switches. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 14ce8b290fea..45be80225130 100644 --- a/MAINTAINERS

[PATCH net-next 1/8] net: phy: Add initial support for Microsemi Ocelot internal PHYs.

2018-03-23 Thread Alexandre Belloni
Add Microsemi Ocelot internal PHY ids. For now, simply use the genphy functions but more features are available. Cc: Raju Lakkaraju <raju.lakkar...@microsemi.com> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drivers/net/phy/mscc.c | 15 +++ 1 file

[PATCH net-next 0/8] Microsemi Ocelot switch support

2018-03-23 Thread Alexandre Belloni
org> Alexandre Belloni (8): net: phy: Add initial support for Microsemi Ocelot internal PHYs. dt-bindings: net: add DT bindings for Microsemi MIIM net: mscc: Add MDIO driver dt-bindings: net: add DT bindings for Microsemi Ocelot Switch net: mscc: Add initial Ocelot switch support MIPS: msc

[PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-03-23 Thread Alexandre Belloni
DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. Cc: Rob Herring <robh...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- .../devicetree/bindings/net/mscc-ocelot.txt| 62 ++ 1 file changed, 6

[PATCH net-next 6/8] MIPS: mscc: Add switch to ocelot

2018-03-23 Thread Alexandre Belloni
Ocelot has an integrated switch, add support for it. Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot.dtsi | 84 + 1 file changed, 84 insertions(+) diff --git

[PATCH net-next 3/8] net: mscc: Add MDIO driver

2018-03-23 Thread Alexandre Belloni
Add a driver for the Microsemi MII Management controller (MIIM) found on Microsemi SoCs. On Ocelot, there are two controllers, one is connected to the internal PHYs, the other one can communicate with external PHYs. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drive

Re: [PATCH 27/40] rtc/proc: switch to proc_create_single_data

2018-04-25 Thread Alexandre Belloni
> if (is_rtc_hctosys(rtc)) > - proc_create_data("driver/rtc", 0, NULL, _proc_fops, rtc); > + proc_create_single_data("driver/rtc", 0, NULL, rtc_proc_show, > + rtc); > } > > void rtc_proc_del_device(struct rtc_device *rtc) > -- > 2.17.0 > -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

[PATCH net-next v2 2/7] net: mscc: Add MDIO driver

2018-04-26 Thread Alexandre Belloni
Add a driver for the Microsemi MII Management controller (MIIM) found on Microsemi SoCs. On Ocelot, there are two controllers, one is connected to the internal PHYs, the other one can communicate with external PHYs. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- drive

[PATCH net-next v2 3/7] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-04-26 Thread Alexandre Belloni
DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. Cc: Rob Herring <robh...@kernel.org> Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- .../devicetree/bindings/net/mscc-ocelot.txt | 82 +

[PATCH net-next v2 1/7] dt-bindings: net: add DT bindings for Microsemi MIIM

2018-04-26 Thread Alexandre Belloni
DT bindings for the Microsemi MII Management Controller found on Microsemi SoCs Cc: Rob Herring <robh...@kernel.org> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- .../devicetree/bindings/net/mscc

[PATCH net-next v2 0/7] Microsemi Ocelot Ethernet switch support

2018-04-26 Thread Alexandre Belloni
interrupts). Cc: James Hogan <jho...@kernel.org> Alexandre Belloni (7): dt-bindings: net: add DT bindings for Microsemi MIIM net: mscc: Add MDIO driver dt-bindings: net: add DT bindings for Microsemi Ocelot Switch net: mscc: Add initial Ocelot switch support MIPS: mscc: Add switch to

[PATCH net-next v2 5/7] MIPS: mscc: Add switch to ocelot

2018-04-26 Thread Alexandre Belloni
Ocelot has an integrated switch, add support for it. Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot.dtsi | 88 + 1 file changed, 88 insertions(+) diff --git a/arch/m

[PATCH net-next v2 7/7] MAINTAINERS: Add entry for Microsemi Ethernet switches

2018-04-26 Thread Alexandre Belloni
Add myself as a maintainer for the Microsemi Ethernet switches. Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0a1410d5a621..b632deb3f503 100644 --- a/MAINTAINERS

[PATCH net-next v2 6/7] MIPS: mscc: connect phys to ports on ocelot_pcb123

2018-04-26 Thread Alexandre Belloni
Add phy to switch port connections for PCB123 for internal PHYs. Cc: James Hogan <jho...@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 20 1 file changed, 20 insertions(+) diff --git

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Alexandre Belloni
it hangs. > > So you never said it hangs. The stacktrace helps, but a description of > what actually happens also helps. And i expect Quentin has booted this > code lots of times and not had a hang. So some hits how to reproduce > it would also help. Maybe your kernel config? > > I'm interested because he is using the core mdio locking > primitives. If those are broken, i want to know. > My first intuition is that he mac driver quentin is using does phy_connect when the interface is opened while macb is doing it at probe time. I didn't investigate but maybe this can help :) -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com