[RFC PATCH kernel] Revert net/mlx4_core: Add port attribute when tracking counters

68230242cdb breaks SRIOV on POWER8 system. I am not really suggesting reverting the patch, rather asking for a fix. To reproduce it: 1. boot latest upstream kernel (v4.2-rc8 sha1 4941b8f, ppc64le) 2. Run: sudo rmmod mlx4_en mlx4_ib mlx4_core sudo modprobe mlx4_core num_vfs=4 probe_vf=4

Re: [RFC PATCH kernel] Revert net/mlx4_core: Add port attribute when tracking counters

On 08/30/2015 04:28 PM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 7:06 AM, Alexey Kardashevskiy a...@ozlabs.ru wrote: 68230242cdb breaks SRIOV on POWER8 system. I am not really suggesting reverting the patch, rather asking for a fix. thanks for the detailed report, we will look

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Add port attribute when tracking counters"

On 09/03/2015 10:09 PM, eran ben elisha wrote: On Mon, Aug 31, 2015 at 5:39 AM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: On 08/30/2015 04:28 PM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 7:06 AM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: 68230242cdb breaks SRIOV on POWE

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Add port attribute when tracking counters"

Any luck with that? On 09/04/2015 01:36 PM, Alexey Kardashevskiy wrote: On 09/03/2015 10:09 PM, eran ben elisha wrote: On Mon, Aug 31, 2015 at 5:39 AM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: On 08/30/2015 04:28 PM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 7:06 AM,

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Add port attribute when tracking counters"

On 09/20/2015 11:51 PM, Or Gerlitz wrote: On Tue, Sep 15, 2015 at 1:41 PM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: Any luck with that? I am checking with the team if they can set a PPC node to try and reproduce the crash, on x86 they don't see it. Somehow I cannot reproduce it a

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 02:29 AM, Christoph Hellwig wrote: On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: Let us check. I was under (the maybe wrong) impression, that before this patch both PF/VF drivers were not operative on some systems, so on those systems it's fair to require the VF

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/15/2016 09:40 PM, Or Gerlitz wrote: On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to

[RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver up: mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) mlx4_core: Initializing :00:00.0 mlx4_core

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

Eli Cohen <e...@mellanox.com> Thanks! Tested-by: Alexey Kardashevskiy <a...@ozlabs.ru> --- drivers/net/ethernet/mellanox/mlx4/main.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today to use as a guest in the next 6 months (or whatever it takes to backport this partucular patch back there). You

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 05:09 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 04:49:00PM +1100, Alexey Kardashevskiy wrote: On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 08:45 PM, Or Gerlitz wrote: On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not work in a guest: So where is the breakage point for you? does 4.4 works? if not, what?

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

On 03/18/2016 08:45 PM, Alexey Kardashevskiy wrote: On 03/18/2016 03:49 AM, Eli Cohen wrote: Commit 85743f1eb345 ("net/mlx4_core: Set UAR page size to 4KB regardless of system page size") introduced dependency where old VF drivers without this fix fail to load if the PF d

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

On 03/22/2016 12:56 AM, Eli Cohen wrote: On Mon, Mar 21, 2016 at 04:02:16PM +1100, Alexey Kardashevskiy wrote: After more tries, I found that if for whatever reason mlx4_core fails to stop while shutting the guest down (last message is "mlx4_core :00:00.0: mlx4_shutdown was c

[RFC PATCH kernel] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

16: b'610-0001-00 H1\x00\x00' #4c [RW] len=173: b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'... #0dff Small item 0 bytes; name 0xf End Tag Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> --- drivers/pci/quirks.c | 12 1 file changed, 12

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

On 12/08/16 04:52, Alexander Duyck wrote: > On Wed, Aug 10, 2016 at 4:54 PM, Benjamin Herrenschmidt > wrote: >> On Wed, 2016-08-10 at 08:47 -0700, Alexander Duyck wrote: >>> >>> The problem is if we don't do this it becomes possible for a guest to >>> essentially cripple

Re: [RFC PATCH kernel] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

On 07/09/16 04:30, Alexander Duyck wrote: > On Tue, Sep 6, 2016 at 8:48 AM, Bjorn Helgaas <helg...@kernel.org> wrote: >> Hi Alexey, >> >> On Thu, Aug 11, 2016 at 08:03:29PM +1000, Alexey Kardashevskiy wrote: >>> There is at least one Chelsio 10Gb card which us

[PATCH kernel v2] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

0-0001-00 H1\x00\x00' #4c [RW] len=173: b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'... 0dff Small item 0 bytes; name 0xf End Tag Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> --- Changes: v2: * used pci_set_vpd_size() helper * added explicit list of IDs from c

Re: [PATCH kernel v2] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

Anyone, ping? On 29/09/16 15:21, Alexey Kardashevskiy wrote: > There is at least one Chelsio 10Gb card which uses VPD area to store > some custom blocks (example below). However pci_vpd_size() returns > the length of the first block only assuming that there can be only > one

[PATCH kernel v3] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

00\x00\x00'... 0dff Small item 0 bytes; name 0xf End Tag 10f3 Large item 13315 bytes; name 0x62 !!! unknown item name 98: b'\xd0\x03\x00@`\x0c\x08\x00\x00\x00\x00\x00\x00\x00\x00\x00' === Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> --- Changes: v3: * unconditionally set VP

Re: [PATCH kernel v2] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

On 11/10/16 02:23, Alexander Duyck wrote: > On Wed, Sep 28, 2016 at 10:21 PM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: >> There is at least one Chelsio 10Gb card which uses VPD area to store >> some custom blocks (example below). However pci_vpd_size() returns >> th