[RFC PATCH 3/3] arcnet: com20020: Add ethtool support

2018-05-05 Thread Andrea Greco
From: Andrea Greco Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020-isa.c| 1 + drivers/net/arcnet/com20020-membus.c | 1 + drivers/net/arcnet/com20020.c| 29 + drivers/net/arcnet/com20020.h

[RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-05 Thread Andrea Greco
From: Andrea Greco Add support for com20022I/com20020, memory mapped chip version. Support bus: Intel 80xx and Motorola 68xx. Bus size: Only 8 bit bus size is supported. Added related device tree bindings Signed-off-by: Andrea Greco --- .../devicetree/bindings/net/smsc-com20020.txt | 23

[RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

2018-05-05 Thread Andrea Greco
From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index f09ea77dd6a8..abd32ed8ec9b

Re: [RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-08 Thread Andrea Greco
On 05/07/2018 04:55 AM, Tobin C. Harding wrote: On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote: From: Andrea Greco Hi Andrea, Here are some (mostly stylistic) suggestions to help you get your driver merged. Add support for com20022I/com20020, memory mapped chip version

Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

2018-05-08 Thread Andrea Greco
On 05/07/2018 04:55 AM, Tobin C. Harding wrote: On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote: From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4

Re: [RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-11 Thread Andrea Greco
On 05/08/2018 06:16 PM, Rob Herring wrote: > On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote: >> From: Andrea Greco >> >> Add support for com20022I/com20020, memory mapped chip version. >> Support bus: Intel 80xx and Motorola 68xx. >> Bus size:

[PATCH 1/2] nl80211: Allow change CW to Ad-Hock network

2019-02-21 Thread Andrea Greco
From: Andrea Greco Add net-link support for change CW in Ad-Hock network Signed-off-by: Andrea Greco --- net/wireless/nl80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index d91a408db113..4fcc63fa4380 100644 --- a

[PATCH 2/2] ath9K: debugfs: Fix SPUR-DOWN field

2019-02-21 Thread Andrea Greco
From: Andrea Greco SPUR DOWN field return spurup inside of spurdown Signed-off-by: Andrea Greco --- drivers/net/wireless/ath/ath9k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c index

Re: [PATCH 2/4] arcnet: com20020: bindings for smsc com20020

2018-05-23 Thread Andrea Greco
On 05/23/2018 06:49 PM, Rob Herring wrote: > One typo, otherwise: > > Reviewed-by: Rob Herring Yes typo, Fixed over my branch, sorry for that... I expect a comment about bps, Bit per Second, used in `bus-speed-bps` You will add it by your self in property-units.txt, or required my patch? If your

[PATCH 1/6] arcnet: leds: Removed leds dependecy

2018-06-11 Thread Andrea Greco
From: Andrea Greco Only PCI driver depends from leds class. Signed-off-by: Andrea Greco --- drivers/net/arcnet/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/arcnet/Kconfig b/drivers/net/arcnet/Kconfig index 39bd16f3f86d..afc5898e7a16 100644 --- a

[PATCH 2/6] arcnet: com20020: Add IO cb for configure rw

2018-06-11 Thread Andrea Greco
From: Andrea Greco Add IO callback. No logic change are intended. Now every driver implementation could specify IO callback. Default IO callback is provided. Signed-off-by: Andrea Greco --- drivers/net/arcnet/arcdevice.h| 4 ++ drivers/net/arcnet/com20020-isa.c | 21 -- drivers/net

[PATCH 3/6] arcnet: com20020: Add com20020 io mapped version

2018-06-11 Thread Andrea Greco
From: Andrea Greco Add support for com20022I/com20020, io mapped. Signed-off-by: Andrea Greco --- drivers/net/arcnet/Kconfig | 9 +- drivers/net/arcnet/Makefile | 1 + drivers/net/arcnet/com20020-io.c | 315 +++ drivers/net/arcnet/com20020.c

[PATCH 4/6] arcnet: com20020: bindings for smsc com20020

2018-06-11 Thread Andrea Greco
From: Andrea Greco Add devicetree bindings for smsc com20020 Signed-off-by: Andrea Greco --- .../devicetree/bindings/net/smsc-com20020.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/smsc-com20020.txt diff --git

[PATCH 5/6] arcnet: com20020: Fixup missing SLOWARB bit

2018-06-11 Thread Andrea Greco
From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 8d979a66d8e9..1a0fd30fe8ae

[PATCH 6/6] arcnet: com20020: Add ethtool support

2018-06-11 Thread Andrea Greco
From: Andrea Greco Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020-io.c | 1 + drivers/net/arcnet/com20020-isa.c | 1 + drivers/net/arcnet/com20020.c | 24 drivers/net/arcnet/com20020.h | 1

[PATCH 4/6] arcnet: com20020: bindings for smsc com20020

2018-06-11 Thread Andrea Greco
From: Andrea Greco Add devicetree bindings for smsc com20020 Signed-off-by: Andrea Greco --- .../devicetree/bindings/net/smsc-com20020.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/smsc-com20020.txt diff --git

[PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

2018-05-17 Thread Andrea Greco
From: Andrea Greco Add support for com20022I/com20020, io mapped. Signed-off-by: Andrea Greco --- drivers/net/arcnet/Kconfig | 9 +- drivers/net/arcnet/Makefile | 1 + drivers/net/arcnet/arcdevice.h | 14 ++ drivers/net/arcnet/com20020-io.c | 287

[PATCH 2/4] arcnet: com20020: bindings for smsc com20020

2018-05-17 Thread Andrea Greco
From: Andrea Greco Add devicetree bindings for smsc com20020 Signed-off-by: Andrea Greco --- .../devicetree/bindings/net/smsc-com20020.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/smsc-com20020.txt diff --git

[PATCH 3/4] arcnet: com20020: Fixup missing SLOWARB bit

2018-05-17 Thread Andrea Greco
From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 2fd00d2dd6bf..f1de02f05305

[PATCH 4/4] arcnet: com20020: Add ethtool support

2018-05-17 Thread Andrea Greco
From: Andrea Greco Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020-io.c | 1 + drivers/net/arcnet/com20020-isa.c | 1 + drivers/net/arcnet/com20020.c | 24 drivers/net/arcnet/com20020.h | 1

Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

2018-05-18 Thread Andrea Greco
On 05/17/2018 10:31 PM, David Miller wrote: > From: Andrea Greco > Date: Thu, 17 May 2018 15:05:29 +0200 > >> + /* Will be set by userspace during if setup */ >> + dev->dev_addr[0] = 0; > > Hmmm... really? > > Also, every error path from this point forward wil

Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

2018-05-22 Thread Andrea Greco
On 05/18/2018 07:51 PM, David Miller wrote: From: Andrea Greco Date: Fri, 18 May 2018 14:18:41 +0200 In com20020.c found this: /* FIXME: do this some other way! */ if (!dev->dev_addr[0]) dev->dev_addr[0] = arcnet_inb(ioaddr, 8); NODE-ID, must be univoque, for all arcnet network. My pr