[PATCH] bonding: require speed/duplex only for 802.3ad, alb and tlb

2017-08-09 Thread Andreas Born
kernel.org/show_bug.cgi?id=196547). Fixes: c4adfc822bf5 ("bonding: make speed, duplex setting consistent with link state") Signed-off-by: Andreas Born --- drivers/net/bonding/bond_main.c | 6 -- include/net/bonding.h | 5 + 2 files changed, 9 insertions(+), 2 deletions(-) diff

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-10 Thread Andreas Born
Hi everyone, 2017-08-10 14:43 GMT+02:00 Arend van Spriel : > > > On 10-08-17 07:39, Kalle Valo wrote: >> >> Hi Mahesh and Andy, >> >> James Feeney reported that there's a serious regression in bonding >> module since v4.12, it doesn't work with wireless drivers anymore as >> wireless drivers don't

[PATCH] bonding: ratelimit failed speed/duplex update warning

2017-08-11 Thread Andreas Born
instead. pr_warn_once() would not be sufficient since the call to bond_update_speed_duplex() could recover to meanwhile succeed and fail again later. Fixes: b5bf0f5b16b9c (bonding: correctly update link status during mii-commit phase) Signed-off-by: Andreas Born --- drivers/net/bonding

[PATCH v2] bonding: ratelimit failed speed/duplex update warning

2017-08-11 Thread Andreas Born
: Andreas Born --- Changes in v2: * swapped pr_warn_ratelimited() for net_ratelimit() drivers/net/bonding/bond_main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 85bb272d2a34..fc63992ab0e0 100644

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-13 Thread Andreas Born
2017-08-12 21:30 GMT+02:00 James Feeney : > > > Andreas patch failed to address the continuous, *10-times per second* warning > which will "spam" the log file, sometimes the console, whenever the test > fails: > if (bond_update_speed_duplex(slave) && bond_needs_speed_duplex(bond)) {...} > which t