[PATCH net-next 2/2] net: fec: use a more proper compatible string for i.MX6UL type device

2016-06-22 Thread Andy Duan
i.MX6UL is a member in i.MX series family, the SOC FEC inherits from i.MX6SX but removes some IP features, lets define a new type for fec device. Signed-off-by: Fugang Duan --- drivers/net/ethernet/freescale/fec_main.c | 8 1 file changed, 8 insertions(+) diff

[PATCH net-next 1/2] net: fec: add interrupt coalesc quirk flag

2016-06-22 Thread Andy Duan
Different i.MX SOC FEC support different features like : - i.MX6Q/DL FEC does not support AVB and interrupt coalesc - i.MX6SX/i.MX7D supports AVB and interrupt coalesc - i.MX6UL/ULL does not support AVB, but support interrupt coalesc So, add new quirk flag to judge the supported features.

[PATCH net-next 0/2] net: fec: add new type device

2016-06-22 Thread Andy Duan
features, and add new type device for i.MX6UL. Andy Duan (2): net: fec: add interrupt coalesc quirk flag net: fec: use a more proper compatible string for i.MX6UL type device drivers/net/ethernet/freescale/fec.h | 2 ++ drivers/net/ethernet/freescale/fec_main.c | 27

[PATCH net 1/1] net: fec: fix multicast filtering hardware setup

2017-02-09 Thread Andy Duan
Fix hardware setup of multicast address hash: - Never clear the hardware hash (to avoid packet loss) - Construct the hash register values in software and then write once to hardware Signed-off-by: Fugang Duan Signed-off-by: Rui Sousa ---

RE: [PATCH net 1/1] net: fec: fix multicast filtering hardware setup

2017-02-12 Thread Andy Duan
From: Fabio Estevam <feste...@gmail.com> Sent: Saturday, February 11, 2017 5:20 AM >To: Andy Duan <fugang.d...@nxp.com> >Cc: David S. Miller <da...@davemloft.net>; netdev@vger.kernel.org; >Stephen Hemminger <step...@networkplumber.org> >Subject: Re: [PA

[PATCH net 1/1] net: fec: fix multicast filtering hardware setup

2017-02-12 Thread Andy Duan
From: Rui Sousa Fix hardware setup of multicast address hash: - Never clear the hardware hash (to avoid packet loss) - Construct the hash register values in software and then write once to hardware Signed-off-by: Rui Sousa Signed-off-by: Fugang Duan

RE: [PATCH v2] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Andy Duan
From: Eric Dumazet <eric.duma...@gmail.com> Sent: Wednesday, January 18, 2017 1:02 PM >To: Yuusuke Ashiduka <ashid...@jp.fujitsu.com> >Cc: Andy Duan <fugang.d...@nxp.com>; netdev@vger.kernel.org >Subject: Re: [PATCH v2] net: fec: Fixed panic problem with non-tso >

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-19 Thread Andy Duan
From: Eric Dumazet <eric.duma...@gmail.com> Sent: Wednesday, January 18, 2017 12:36 PM >To: Ashizuka, Yuusuke <ashid...@jp.fujitsu.com> >Cc: Andy Duan <fugang.d...@nxp.com>; netdev@vger.kernel.org; Pravin B >Shelar <pshe...@nicira.com> >Subject: Re: [PATCH] ne

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Andy Duan
From: Yuusuke Ashiduka <ashid...@jp.fujitsu.com> Sent: Tuesday, January 17, 2017 3:48 PM >To: Andy Duan <fugang.d...@nxp.com> >Cc: netdev@vger.kernel.org; Yuusuke Ashiduka <ashid...@jp.fujitsu.com> >Subject: [PATCH] net: fec: Fixed panic problem with non-tso &g

RE: Alignment issues with freescale FEC driver

2016-09-23 Thread Andy Duan
From: David Miller <da...@davemloft.net> Sent: Saturday, September 24, 2016 10:46 AM > To: e...@nelint.com > Cc: and...@lunn.ch; eduma...@google.com; Andy Duan > <fugang.d...@nxp.com>; ota...@ossystems.com.br; > netdev@vger.kernel.org; troy.ki...@boundarydevices.com; >

RE: [PATCH 0/3] net: fec: updates to align IP header

2016-09-24 Thread Andy Duan
From: Eric Nelson <e...@nelint.com> Sent: Saturday, September 24, 2016 10:42 PM > To: netdev@vger.kernel.org > Cc: li...@arm.linux.org.uk; and...@lunn.ch; Andy Duan > <fugang.d...@nxp.com>; ota...@ossystems.com.br; > eduma...@google.com; troy.ki...@boundarydevices.co

RE: [PATCH 3/3] net: fec: align IP header in hardware

2016-10-08 Thread Andy Duan
From: Eric Nelson <e...@nelint.com> Sent: Friday, September 30, 2016 9:27 PM > To: David Laight <david.lai...@aculab.com>; netdev@vger.kernel.org > Cc: li...@arm.linux.org.uk; and...@lunn.ch; Andy Duan > <fugang.d...@nxp.com>; ota...@ossystems.com.br; >

RE: [PATCH] net: fec: set mac address unconditionally

2016-09-21 Thread Andy Duan
From: Gavin Schenk <g.sch...@eckelmann.de> Sent: Wednesday, September 21, 2016 9:31 PM > To: Andy Duan <fugang.d...@nxp.com> > Cc: netdev@vger.kernel.org; ker...@pengutronix.de; Gavin Schenk > <g.sch...@eckelmann.de> > Subject: [PATCH] net: fec: set mac addr

RE: [PATCH] net: fec: drop check for clk==NULL before calling clk_*

2016-10-20 Thread Andy Duan
From: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> Sent: Thursday, October 20, 2016 4:28 PM > To: Andy Duan <fugang.d...@nxp.com> > Cc: ker...@pengutronix.de; netdev@vger.kernel.org > Subject: [PATCH] net: fec: drop check for clk==NULL before calling clk_* > &

RE: [PATCH] net: fec: hard phy reset on open

2016-10-24 Thread Andy Duan
From: Manfred Schlaegl <manfred.schla...@ginzinger.com> Sent: Monday, October 24, 2016 10:43 PM > To: Andy Duan <fugang.d...@nxp.com> > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] net: fec: hard phy reset on open > > On 2016-1

RE: [PATCH] net: fec: hard phy reset on open

2016-10-24 Thread Andy Duan
From: manfred.schla...@gmx.at <manfred.schla...@gmx.at> Sent: Monday, October 24, 2016 5:26 PM > To: Andy Duan <fugang.d...@nxp.com> > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH] net: fec: hard phy reset on open > > We have s

RE: [patch net] net: fec: cache statistics while device is down

2016-11-28 Thread Andy Duan
From: Nikita Yushchenko <nikita.yo...@cogentembedded.com> Sent: Monday, November 28, 2016 10:27 PM >To: David S. Miller <da...@davemloft.net>; Andy Duan ><fugang.d...@nxp.com>; Troy Kisky <troy.ki...@boundarydevices.com>; >Andrew Lunn <and...@lunn.ch>;

RE: [PATCH] net: fec: turn on device when extracting statistics

2016-11-26 Thread Andy Duan
From: Nikita Yushchenko <nikita.yo...@cogentembedded.com> Sent: Friday, November 25, 2016 6:02 PM >To: Andy Duan <fugang.d...@nxp.com>; David S. Miller ><da...@davemloft.net>; Troy Kisky <troy.ki...@boundarydevices.com>; >Andrew Lunn <and...@lunn.ch>;

RE: [PATCH] net: fec: Detect and recover receive queue hangs

2016-11-18 Thread Andy Duan
From: Chris Lesiak <chris.les...@licor.com> Sent: Friday, November 18, 2016 5:15 AM >To: Andy Duan <fugang.d...@nxp.com> >Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Jaccon >Bastiaansen <jaccon.bastiaan...@gmail.com>; chris.les...@licor.com >Sub

RE: [PATCH] net: fec: Detect and recover receive queue hangs

2016-11-19 Thread Andy Duan
From: Chris Lesiak <chris.les...@licor.com> Sent: Friday, November 18, 2016 10:37 PM >To: Andy Duan <fugang.d...@nxp.com> >Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Jaccon >Bastiaansen <jaccon.bastiaan...@gmail.com> >Subject: Re: [PATCH] net: f

RE: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-29 Thread Andy Duan
From: Nikita Yushchenko <nikita.yo...@cogentembedded.com> Sent: Wednesday, November 30, 2016 2:36 PM >To: Andy Duan <fugang.d...@nxp.com>; David S. Miller ><da...@davemloft.net>; Troy Kisky <troy.ki...@boundarydevices.com>; >Andrew Lunn <and...@lunn.ch>;

RE: [patch net / RFC] net: fec: increase frame size limitation to actually available buffer

2016-11-30 Thread Andy Duan
From: Nikita Yushchenko <nikita.yo...@cogentembedded.com> Sent: Wednesday, November 30, 2016 2:35 AM >To: David S. Miller <da...@davemloft.net>; Andy Duan ><fugang.d...@nxp.com>; Troy Kisky <troy.ki...@boundarydevices.com>; >Andrew Lunn <and...@lunn.ch>;

RE: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Andy Duan
From: Nikita Yushchenko <nikita.yo...@cogentembedded.com> Sent: Monday, December 05, 2016 4:16 PM >To: David S. Miller <da...@davemloft.net>; Andy Duan ><fugang.d...@nxp.com>; Troy Kisky <troy.ki...@boundarydevices.com>; >Andrew Lunn <and...@lunn.ch>;

RE: [patch net] net: fec: fix compile with CONFIG_M5272

2016-12-04 Thread Andy Duan
From: Nikita Yushchenko <nikita.yo...@cogentembedded.com> Sent: Sunday, December 04, 2016 11:18 PM >To: David S. Miller <da...@davemloft.net>; Andy Duan ><fugang.d...@nxp.com>; Troy Kisky <troy.ki...@boundarydevices.com>; >Andrew Lunn <and...@lunn.ch>;

RE: [PATCH 3/3] net: fec: Fix typo in error msg and comment

2016-12-18 Thread Andy Duan
From: Peter Meerwald-Stadler <pme...@pmeerw.net> Sent: Friday, December 16, 2016 9:24 PM >To: netdev@vger.kernel.org >Cc: Peter Meerwald-Stadler <pme...@pmeerw.net>; Andy Duan ><fugang.d...@nxp.com>; triv...@kernel.org >Subject: [PATCH 3/3] net: fec: Fix typo in e

RE: IMX6 FEC connection drops occasionally with 'MDIO read timeout'

2017-04-09 Thread Andy Duan
From: Tim Harvey <thar...@gateworks.com> Sent: Friday, April 07, 2017 10:47 PM >To: netdev <netdev@vger.kernel.org> >Cc: Fabio Estevam <fabio.este...@nxp.com>; Lucas Stach ><l.st...@pengutronix.de>; Andy Duan <fugang.d...@nxp.com>; Koen >Vandeputte <koe

Re: IMX6 FEC connection drops occasionally with 'MDIO read timeout'

2017-04-12 Thread Andy Duan
On 2017年04月13日 00:54, Tim Harvey wrote: > On Wed, Apr 12, 2017 at 9:26 AM, Fabio Estevam wrote: >> Hi Tim, >> >> On Wed, Apr 12, 2017 at 1:15 PM, Tim Harvey wrote: >>> Andrew, >>> >>> Thanks for the reply. Your talking about suspend/resume power >>>

Re: FEC on i.MX 7 transmit queue timeout

2017-04-20 Thread Andy Duan
On 2017年04月20日 07:15, Stefan Agner wrote: > I tested again with imx6sx-fec compatible string. I could reproduce it > on a Colibri with i.MX 7Dual. But not always: It really depends whether > queue 2 is counting up or not. Just after boot, I check /proc/interrupts > twice, if queue 2 is counting

RE: FEC on i.MX 7 transmit queue timeout

2017-04-18 Thread Andy Duan
From: Stefan Agner <ste...@agner.ch> Sent: Wednesday, April 19, 2017 1:02 PM >To: Andy Duan <fugang.d...@nxp.com> >Cc: fugang.d...@freescale.com; feste...@gmail.com; >netdev@vger.kernel.org; netdev-ow...@vger.kernel.org >Subject: Re: FEC on i.MX 7 transmit queue timeout &

Re: FEC on i.MX 7 transmit queue timeout

2017-04-18 Thread Andy Duan
On 2017年04月19日 03:46, Stefan Agner wrote: > Hi, > > I noticed last week on upstream (v4.11-rc6) on a Colibri iMX7 board that > after a while (~10 minutes) the detdev wachdog prints a stacktrace and > the driver then continuously dumps the TX ring. I then did a quick test > with 4.10, and realized

Re: FEC on i.MX 7 transmit queue timeout

2017-04-19 Thread Andy Duan
On 2017年04月19日 13:56, Stefan Agner wrote: > On 2017-04-18 22:28, Andy Duan wrote: >> From: Stefan Agner <ste...@agner.ch> Sent: Wednesday, April 19, 2017 1:02 PM >>> To: Andy Duan <fugang.d...@nxp.com> >>> Cc: fugang.d...@freescale.com; feste...@gmail.com

RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Andy Duan
From: Richard Leitner <richard.leit...@skidata.com> Sent: Friday, July 07, 2017 5:53 PM >To: Andy Duan <fugang.d...@nxp.com>; robh...@kernel.org; >mark.rutl...@arm.com >Cc: netdev@vger.kernel.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org; d...

RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Andy Duan
From: Richard Leitner Sent: Friday, July 07, 2017 1:51 PM >> Since it is common issue so long as using the PHY, can you move it into smsc >phy driver like in .smsc_phy_reset() function ? >> And get the reset pin from phy dts node. > >Some more points that come into

RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Andy Duan
From: Richard Leitner <richard.leit...@skidata.com> Sent: Thursday, July 06, 2017 9:06 PM >To: Andy Duan <fugang.d...@nxp.com>; robh...@kernel.org; >mark.rutl...@arm.com >Cc: netdev@vger.kernel.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org; d...@g0h

RE: [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes

2017-07-30 Thread Andy Duan
From: Andrew Lunn Sent: Monday, July 31, 2017 1:36 AM >The FEC Receive Control Register has a 14 bit field indicating the longest >frame >that my be received. It is being set to 1522. Frames longer than this are My -> may >discarded, but counted as being in error. > >When using

RE: [PATCH net-next] net: fec: Issue error for missing but expected PHY

2017-07-30 Thread Andy Duan
From: Andrew Lunn Sent: Monday, July 31, 2017 4:11 AM >If the PHY is missing but expected, e.g. because of a typ0 in the dt file, it >is not >possible to open the interface. ip link returns: > >RTNETLINK answers: No such device > >It is not very obvious what the problem is. Add a

RE: FEC on i.MX 7 transmit queue timeout

2017-05-03 Thread Andy Duan
From: Stefan Agner <ste...@agner.ch> Sent: Thursday, May 04, 2017 9:22 AM >To: Andy Duan <fugang.d...@nxp.com> >Cc: fugang.d...@freescale.com; feste...@gmail.com; >netdev@vger.kernel.org; netdev-ow...@vger.kernel.org >Subject: Re: FEC on i.MX 7 transmit queue timeout >

RE: [PATCH] net: fec: select queue depending on VLAN priority

2017-05-10 Thread Andy Duan
From: Stefan Agner <ste...@agner.ch> Sent: Thursday, May 11, 2017 12:08 PM >To: Andy Duan <fugang.d...@nxp.com> >Cc: David Miller <da...@davemloft.net>; and...@lunn.ch; >feste...@gmail.com; netdev@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: R

RE: [PATCH] net: fec: select queue depending on VLAN priority

2017-05-09 Thread Andy Duan
From: David Miller <da...@davemloft.net> Sent: Tuesday, May 09, 2017 9:39 PM >To: ste...@agner.ch >Cc: Andy Duan <fugang.d...@nxp.com>; and...@lunn.ch; >feste...@gmail.com; netdev@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH] net: fec: sel

RE: FEC on i.MX 7 transmit queue timeout

2017-05-09 Thread Andy Duan
From: Stefan Agner <ste...@agner.ch> Sent: Tuesday, May 09, 2017 2:23 AM >To: Andy Duan <fugang.d...@nxp.com>; Andrew Lunn <and...@lunn.ch> >Cc: feste...@gmail.com; netdev@vger.kernel.org; netdev- >ow...@vger.kernel.org >Subject: Re: FEC on i.MX 7 transmit queue

RE: [PATCH] net: fec: select queue depending on VLAN priority

2017-05-16 Thread Andy Duan
From: Stefan Agner <ste...@agner.ch> Sent: Monday, May 15, 2017 1:39 PM >To: Andy Duan <fugang.d...@nxp.com> >Cc: David Miller <da...@davemloft.net>; and...@lunn.ch; >feste...@gmail.com; netdev@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH]

RE: [PATCH] net: fec: add post PHY reset delay DT property

2017-05-22 Thread Andy Duan
From: Quentin Schulz Sent: Monday, May 22, 2017 5:15 PM >Some PHY require to wait for a bit after the reset GPIO has been toggled. This >adds support for the DT property `phy-reset-post-delay` which gives the delay >in milliseconds to wait after reset. > >If

RE: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-23 Thread Andy Duan
From: Quentin Schulz Sent: Tuesday, May 23, 2017 5:48 PM >Some PHY require to wait for a bit after the reset GPIO has been toggled. This >adds support for the DT property `phy-reset-post-delay` which gives the delay >in milliseconds to wait after reset. > >If

RE: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Andy Duan
From: Rob Herring Sent: Thursday, June 01, 2017 12:44 AM >On Tue, May 23, 2017 at 11:48:08AM +0200, Quentin Schulz wrote: >> Some PHY require to wait for a bit after the reset GPIO has been >> toggled. This adds support for the DT property `phy-reset-post-delay` >> which gives

RE: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Andy Duan
From: Florian Fainelli <f.faine...@gmail.com> Sent: Thursday, June 01, 2017 9:53 AM >To: Andy Duan <fugang.d...@nxp.com>; Rob Herring <r...@kernel.org>; >Quentin Schulz <quentin.sch...@free-electrons.com> >Cc: mark.rutl...@arm.com; netdev@vger.kernel.org; >d

RE: FEC on i.MX 7 transmit queue timeout

2017-05-07 Thread Andy Duan
From: Andrew Lunn <and...@lunn.ch> Sent: Friday, May 05, 2017 8:24 PM >To: Andy Duan <fugang.d...@nxp.com> >Cc: Stefan Agner <ste...@agner.ch>; feste...@gmail.com; >netdev@vger.kernel.org; netdev-ow...@vger.kernel.org >Subject: Re: FEC on i.MX 7 transmit queue timeout

Re: FEC on i.MX 7 transmit queue timeout

2017-05-04 Thread Andy Duan
On 2017年05月05日 05:36, Stefan Agner wrote: > On 2017-05-03 20:08, Andy Duan wrote: >> From: Stefan Agner <ste...@agner.ch> Sent: Thursday, May 04, 2017 9:22 AM >>> To: Andy Duan <fugang.d...@nxp.com> >>> Cc: fugang.d...@freescale.com; feste...@gmail.com

Re: FEC on i.MX 7 transmit queue timeout

2017-05-04 Thread Andy Duan
On 2017年05月05日 10:09, Stefan Agner wrote: > On 2017-05-04 19:03, Andy Duan wrote: >> On 2017年05月05日 05:36, Stefan Agner wrote: >>> On 2017-05-03 20:08, Andy Duan wrote: >>>> From: Stefan Agner <ste...@agner.ch> Sent: Thursday, May 04, 2017 9:22 AM >>>&g

RE: [PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

2017-09-19 Thread Andy Duan
From: Troy Kisky Sent: Wednesday, September 20, 2017 8:33 AM >FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no >need to enable it. > >Signed-off-by: Troy Kisky >Acked-by: Fugang Duan >

RE: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-15 Thread Andy Duan
From: Troy Kisky Sent: Saturday, October 14, 2017 10:10 AM >This is better for code locality and should slightly speed up normal >interrupts. > >This also allows PPS clock output to start working for i.mx7. This is because >i.mx7 was already using the limit of 3

RE: [PATCH net v1 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-08 Thread Andy Duan
From: Troy Kisky <troy.ki...@boundarydevices.com> Sent: Tuesday, October 03, 2017 8:05 AM >To: shawn@linaro.org; Andy Duan <fugang.d...@nxp.com>; >netdev@vger.kernel.org; da...@davemloft.net >Cc: Fabio Estevam <fabio.este...@nxp.com>; lzn...@gmai

RE: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-19 Thread Andy Duan
From: Troy Kisky <troy.ki...@boundarydevices.com> Sent: Thursday, October 19, 2017 2:30 AM >On 10/18/2017 11:10 AM, Troy Kisky wrote: >> On 10/17/2017 7:30 PM, Andy Duan wrote: >>> From: Troy Kisky <troy.ki...@boundarydevices.com> Sent: Wednesday

RE: [PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-17 Thread Andy Duan
From: Troy Kisky Sent: Wednesday, October 18, 2017 5:34 AM >>> This is better for code locality and should slightly speed up normal >interrupts. >>> >>> This also allows PPS clock output to start working for i.mx7. This is >>> because >>> i.mx7 was already using

RE: fec driver and two micrel phys

2017-11-28 Thread Andy Duan
From: Oliver Graute Sent: Tuesday, November 28, 2017 11:28 PM >Hello list, > >I try to get two Micrel KSZ8041 Phys working with the fec driver from Kernel >4.14. But it looks that something with the mii_bus probing is not working here. >I expect the Phys on address 01

RE: [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20

2017-12-12 Thread Andy Duan
From: Richard Leitner Sent: Monday, December 11, 2017 8:17 PM >This patch series fixes the use of the SMSC LAN8710/20 with a Freescale ETH >when the refclk is generated by the FSL. > >This patchset depends on the "phylib: Add device reset GPIO support" patch >submitted by Geert

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Andy Duan
From: Richard Leitner <richard.leit...@skidata.com> Sent: Monday, November 20, 2017 5:57 PM >To: Andy Duan <fugang.d...@nxp.com>; f.faine...@gmail.com; >and...@lunn.ch >Cc: Richard Leitner <d...@g0hl1n.net>; netdev@vger.kernel.org; linux- >ker...@vger.kernel.org &g

RE: [PATCH v2 1/3] net: ethernet: freescale: simplify fec_reset_phy

2017-11-20 Thread Andy Duan
From: Richard Leitner Sent: Monday, November 20, 2017 4:34 PM >The fec_reset_phy function allowed only one execution during probeing. >To make it more usable move the dt parsing and gpio allocation to the probe >function. The parameters of the phy reset are added to the

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Andy Duan
From: Richard Leitner <d...@g0hl1n.net> Sent: Monday, November 20, 2017 4:34 PM >To: f.faine...@gmail.com; Andy Duan <fugang.d...@nxp.com>; >and...@lunn.ch >Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >richard.leit...@skidata.com >Subject: [PATCH v2 3

RE: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

2017-11-20 Thread Andy Duan
From: Richard Leitner <richard.leit...@skidata.com> Sent: Monday, November 20, 2017 8:55 PM >On 11/20/2017 11:35 AM, Andy Duan wrote: >> From: Richard Leitner <richard.leit...@skidata.com> Sent: Monday, >> November 20, 2017 5:57 PM >>> To: Andy Duan <fug

RE: [PATCH net v5 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-11-05 Thread Andy Duan
uested by Shawn Guo >s/irq_index/irq_idx/ >add function fec_enet_get_irq_cnt() to encapsulate if, > as requested by Andy Duan >--- > Documentation/devicetree/bindings/net/fsl-fec.txt | 13 > drivers/net/ethernet/freescale/fec.h | 3 +- > drivers/net/ethernet/freescale/fe

RE: [PATCH net v4 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-11-01 Thread Andy Duan
From: Troy Kisky <troy.ki...@boundarydevices.com> Sent: Thursday, November 02, 2017 1:36 AM >To: Andy Duan <fugang.d...@nxp.com>; shawn@linaro.org; >netdev@vger.kernel.org; da...@davemloft.net >Cc: Fabio Estevam <fabio.este...@nxp.com>; lzn...@gmail.com; >and..

RE: [PATCH 2/2] net: fec: optimize IRQ handler

2017-12-06 Thread Andy Duan
From: Lucas Stach Sent: Thursday, December 07, 2017 1:25 AM >fep->work_rx and fep->work_tx are both non-zero, as long as the NAPI >softirq hasn't finished its work. So if the current IRQ does not signal any RX >or >TX completion, but some unrelated event, the path to

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

2017-12-05 Thread Andy Duan
From: Richard Leitner Sent: Tuesday, December 05, 2017 9:26 PM >Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning >the refclk on and off again during operation (according to their datasheet). >Nonetheless exactly this behaviour was introduced for power saving

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

2017-12-06 Thread Andy Duan
From: Richard Leitner <richard.leit...@skidata.com> Sent: Wednesday, December 06, 2017 4:12 PM >To: Andy Duan <fugang.d...@nxp.com>; Richard Leitner <d...@g0hl1n.net>; >robh...@kernel.org; mark.rutl...@arm.com; and...@lunn.ch; >f.faine...@gmail.com; frowand.l...@gmail.c

RE: [PATCH net v4 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-31 Thread Andy Duan
From: Troy Kisky Sent: Wednesday, November 01, 2017 4:17 AM >This is better for code locality and should slightly speed up normal >interrupts. > >This also allows PPS clock output to start working for i.mx7. This is because >i.mx7 was already using the limit of 3

RE: [PATCH 1/2] net: fec: ptp: Switch to SPDX identifier

2018-05-20 Thread Andy Duan
From: Fabio Estevam Sent: 2018年5月21日 0:55 > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Fabio Estevam Acked-by: Fugang Duan > --- >

RE: [PATCH 2/2] net: fec: Add a SPDX identifier

2018-05-20 Thread Andy Duan
From: Fabio Estevam Sent: 2018年5月21日 0:55 > From: Fabio Estevam > > Currently there is no license information in the header of this file. > > The MODULE_LICENSE field contains ("GPL"), which means GNU Public > License v2 or later, so add a

RE: [PATCH net-next] net: fec: remove stale comment

2018-05-24 Thread Andy Duan
> From: YueHaibing Sent: 2018年5月24日 19:27 > This comment is outdated as fec_ptp_ioctl has been replaced by > fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement > the SIOCGHWTSTAMP ioctl") > > Signed-off-by: YueHaibing Thanks.

RE: [PATCH net-next v3 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

2018-05-17 Thread Andy Duan
From: Florian Fainelli Sent: 2018年5月18日 4:08 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- >

RE: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-15 Thread Andy Duan
From: Florian Fainelli Sent: 2018年5月16日 7:56 > A number of drivers have the following pattern: > > if (np) > of_mdiobus_register() > else > mdiobus_register() > > which the implementation of of_mdiobus_register() now takes care of. > Remove that pattern in

RE: [PATCH net-next 2/3] net: ethernet: freescale: Allow FEC with COMPILE_TEST

2018-05-15 Thread Andy Duan
From: Florian Fainelli Sent: 2018年5月16日 7:48 > The Freescale FEC driver builds fine with COMPILE_TEST, so make that > possible. > > Signed-off-by: Florian Fainelli Acked-by: Fugang Duan > --- >

RE: [PATCH, net-next] net: ethernet: freescale: fix false-positive string overflow warning

2018-05-28 Thread Andy Duan
From: Arnd Bergmann Sent: 2018年5月28日 23:50 > While compile-testing on arm64 with gcc-8.1, I ran into a build diagnostic: > > drivers/net/ethernet/freescale/fec_main.c: In function 'fec_probe': > drivers/net/ethernet/freescale/fec_main.c:3517:25: error: '%d' directive > writing between 1 and 10

RE: WARNING: CPU: 0 PID: 0 at ./include/linux/netfilter.h:233 arp_rcv

2018-01-07 Thread Andy Duan
From: Marco Franchi Sent: Friday, January 05, 2018 11:03 PM >Hi, > >I am getting the following warning on a imx6ul-evk board running linux-next >20180105: > >[9.233290] [ cut here ] >[9.242068] WARNING: CPU: 0 PID: 0 at

RE: [PATCH] net: fec: add necessary defines to work on ARM64

2018-01-17 Thread Andy Duan
From: Lucas Stach Sent: Thursday, January 18, 2018 2:31 AM >The i.MX8 is a ARMv8 based SoC, that uses the same FEC IP as the earlier, >ARMv7 based, i.MX SoCs. Allow the driver to work on ARM64. > >Signed-off-by: Lucas Stach >--- >

RE: [PATCH] net: fec: add necessary defines to work on ARM64

2018-01-18 Thread Andy Duan
From: Lucas Stach <l.st...@pengutronix.de> Sent: Thursday, January 18, 2018 5:54 PM >Hi Andy, > >Am Donnerstag, den 18.01.2018, 01:49 +0000 schrieb Andy Duan: >> From: Lucas Stach <l.st...@pengutronix.de> Sent: Thursday, January 18, >> 2018 2:31 AM >> >

RE: [PATCH net,stable 1/1] net: fec: defer probe if regulator is not ready

2018-01-02 Thread Andy Duan
From: Fabio Estevam Sent: Tuesday, January 02, 2018 6:21 PM >Hi Andy, > >On Tue, Jan 2, 2018 at 7:57 AM, Fugang Duan wrote: > >> @@ -3576,6 +3580,7 @@ static int fec_enet_get_irq_cnt(struct >platform_device *pdev) >> of_node_put(phy_node); >>

RE: [PATCH net,stable 1/1] net: fec: unmap the xmit buffer that are not transferred by DMA

2017-12-26 Thread Andy Duan
From: Fugang Duan Sent: Friday, December 22, 2017 5:12 PM >The enet IP only support 32 bit, it will use swiotlb buffer to do dma mapping >when xmit buffer DMA memory address is bigger than 4G in i.MX platform. >After stress suspend/resume test, it will print out: > >log:

RE: [PATCH v3 net,stable 0/2] net: fec: clean up in the cases of probe error

2018-01-03 Thread Andy Duan
From: David Miller Sent: Thursday, January 04, 2018 10:23 AM >> The simple patches just clean up in the cases of probe error like >> restore dev_id and handle the defer probe when regulator is still not ready. > >As I stated, v2 of these patches are already in my tree, so

RE: [PATCH v2 net,stable 0/2] net: fec: clean up in the cases of probe error

2018-01-03 Thread Andy Duan
From: David Miller Sent: Thursday, January 04, 2018 12:41 AM >> The simple patches just clean up in the cases of probe error like >> restore dev_id and handle the defer probe when regulator is still not ready. >> >> v2: >> * Fabio Estevam's comment to suggest split v1 to

RE: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Andy Duan
From: Geert Uytterhoeven <ge...@linux-m68k.org> Sent: 2018年3月28日 15:07 > Hi Andy, > > On Wed, Mar 28, 2018 at 5:04 AM, Andy Duan <fugang.d...@nxp.com> wrote: > > From: Geert Uytterhoeven <ge...@linux-m68k.org> Sent: 2018年3月27日 > 20:59 > >> On Mon, Mar

RE: [PATCH] net: fec: set dma_coherent_mask

2018-03-27 Thread Andy Duan
From: Geert Uytterhoeven Sent: 2018年3月27日 20:59 > Hi Greg, > > On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: > > As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no > > coherent_dma_mask") the Freescale FEC driver is issuing the

[PATCH net,stable 1/1] net: fec: don't dump RX FIFO register when not available

2018-10-14 Thread Andy Duan
From: Fugang Duan Commit db65f35f50e0 ("net: fec: add support of ethtool get_regs") introduce ethool "--register-dump" interface to dump all FEC registers. But not all silicon implementations of the Freescale FEC hardware module have the FRBR (FIFO Receive Bound Register) and FRSR (FIFO Receive

RE: [PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

2018-10-21 Thread Andy Duan
From: netdev-ow...@vger.kernel.org > All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the > FEC driver follow this common pattern. This makes no different to > generated code since SPEED_1000 is 1000, and SPEED_100 is 100. > Please also add more information that was introduced