Re: [PATCH] xprtrdma: add missing curly braces, set rc to zero on non-zero

On 11/24/2015 06:11 PM, Colin King wrote: > From: Colin Ian King > > Add the missing curly braces so that rc is only set to zero when > it is non-zero. Without this minor fix, rc is set to zero even > when it is zero, which is slightly redundant. > > Detected with

Re: [PATCH] sunrpc: Remove unnecessary variable

On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote: > The variable `err` is not used anywhere and just returns the > predefined value `0` at the end of the function. Hence, remove the > variable and return 0 explicitly. Makes sense to me. Thanks! Anna > > Signed-off-by: Amitoj Kaur Chawla

Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

plicit-function-declaration] > > Fix this by adding linux/module.h to svc_rdma_backchannel.c > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> This patch looks okay to me: Acked-by: Anna Schumaker <anna.schuma...@netapp.com> > --- > net/sunrpc/x

Re: [PATCH] sunrpc: queue work on system_power_efficient_wq

On 09/01/2016 03:30 AM, Chunyan Zhang wrote: > From: Ke Wang > > sunrpc uses workqueue to clean cache regulary. There is no real dependency > of executing work on the cpu which queueing it. > > On a idle system, especially for a heterogeneous systems like big.LITTLE, >

Re: 答复: [PATCH] sunrpc: queue work on system_power_efficient_wq

t; Thanks, > Ke > ____ > 发件人: Anna Schumaker <anna.schuma...@netapp.com> > 发送时间: 2016年9月2日 2:46 > 收件人: Chunyan Zhang; trond.mykleb...@primarydata.com; > anna.schuma...@netapp.com; da...@davemloft.net > 抄送: linux-...@vger.kernel.org; netdev@vger.kernel.org

Re: nfs NULL-dereferencing in net-next

On 10/25/2016 01:19 PM, Yotam Gigi wrote: > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >> Behalf Of Jakub Kicinski >> Sent: Monday, October 17, 2016 10:20 PM >> To: Andy Adamson <and...@netapp.

Re: net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

On 11/08/2016 12:43 PM, Ross Zwisler wrote: > On Tue, Nov 08, 2016 at 07:42:59AM -0500, Anna Schumaker wrote: >> On 11/08/2016 07:09 AM, Jeff Layton wrote: >>> On Tue, 2016-11-08 at 06:53 -0500, Jeff Layton wrote: >>>> On Mon, 2016-11-07 at 22:42 -0700, Ross Zwisl

Re: net/sunrpc/clnt.c:2773 suspicious rcu_dereference_check() usage!

1] [] ? nfs_clone_super+0x130/0x130 >>> [ 42.750713] [] ? param_set_portnr+0x70/0x70 >>> [ 42.750726] [] mount_fs+0x39/0x170 >>> [ 42.750740] [] vfs_kern_mount+0x6b/0x150 >>> [ 42.750752] [] do_mount+0x1f1/0xd10 >>> [ 42.750765] [] ? copy_mount_optio

Re: nfs NULL-dereferencing in net-next

On 11/10/2016 09:47 AM, Olaf Hering wrote: > On Thu, Nov 03, Anna Schumaker wrote: > >> Aww, I was hoping that patch would work. It still seemed to fix some >> issues for me when mounting multiple servers, so I'm planning to keep >> it. Unfortunately I'm out of town thi

Re: nfs NULL-dereferencing in net-next

On 10/31/2016 11:25 AM, Jakub Kicinski wrote: > On Thu, 27 Oct 2016 06:50:22 +, Yotam Gigi wrote: >>> -Original Message- >>> From: Anna Schumaker [mailto:anna.schuma...@netapp.com] >>> Sent: Wednesday, October 26, 2016 9:17 PM >>> To: Jakub Kicin

Re: nfs NULL-dereferencing in net-next

On 10/26/2016 02:08 PM, Jakub Kicinski wrote: > On Wed, 26 Oct 2016 16:15:24 +, Yotam Gigi wrote: >>> -Original Message- >>> From: Anna Schumaker [mailto:anna.schuma...@netapp.com] >>> Sent: Wednesday, October 26, 2016 5:40 PM >>> To: Yotam Gig

Re: [PATCH 0/4] make function arg and structures as const

On 11/09/2017 09:21 PM, J. Bruce Fields wrote: > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote: >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote: >>> Make the function argument as const. After thing change, make >>> the cache_detail structures as const. >>> >>> Bhumika

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

t tree, since the pernet_operations don't yet have the async field in my tree (and I therefore can't compile once these are applied). Acked-by: Anna Schumaker <anna.schuma...@netapp.com> > --- > net/sunrpc/auth_gss/auth_gss.c |1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

t tree, since the pernet_operations don't yet have the async field in my tree (and I therefore can't compile once these are applied). Acked-by: Anna Schumaker <anna.schuma...@netapp.com> > --- > net/sunrpc/auth_gss/auth_gss.c |1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH net-next nfs 4/6] net: Convert nfs4_dns_resolver_ops

tuozzo.com> Acked-by: Anna Schumaker <anna.schuma...@netapp.com> > --- > fs/nfs/dns_resolve.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c > index 060c658eab66..e90bd69ab653 100644 > --- a/fs/nfs/dns_resolve.c

Re: [PATCH net-next nfs 2/6] net: Convert sunrpc_net_ops

On 03/13/2018 06:49 AM, Kirill Tkhai wrote: > These pernet_operations look similar to rpcsec_gss_net_ops, > they just create and destroy another caches. So, they also > can be async. > > Signed-off-by: Kirill Tkhai <ktk...@virtuozzo.com> Acked-by: Anna Schumaker <a

Re: [PATCH net-next nfs 5/6] net: Convert nfs4blocklayout_net_ops

On 03/13/2018 06:49 AM, Kirill Tkhai wrote: > These pernet_operations create and destroy per-net pipe > and dentry, and they seem safe to be marked as async. > > Signed-off-by: Kirill Tkhai <ktk...@virtuozzo.com> Acked-by: Anna Schumaker <anna.schuma...@netapp.com> >