Re: [Cbe-oss-dev] [PATCH 0/2] RFC: PS3 network driver

2007-06-02 Thread Arnd Bergmann
On Friday 01 June 2007, Geoff Levand wrote: What happened to the idea of incorporating support into spidernet? That is still our goal, but as a first step we want to at least get some Ethernet support included for end users. Right, I agree that having two drivers is a better medium-term

Re: [Cbe-oss-dev] [PATCH 12/15] spidernet: increase the NAPI weight

2007-06-13 Thread Arnd Bergmann
On Wednesday 13 June 2007, Jeff Garzik wrote: +/* We really really want to empty the ring buffer every time, + * so as to avoid the RX ram full bug. So set te napi wieght + * to the ring size. + */ +#define SPIDER_NET_NAPI_WEIGHT   SPIDER_NET_RX_DESCRIPTORS_DEFAULT I don't see why

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Arnd Bergmann
On Wednesday 13 June 2007, Jeff Garzik wrote: Segher Boessenkool wrote: I wish there was a git option to just make my shit look like the remote, dammit!  The above is the easiest way I know how to do that. git-fetch -f remote:local ? If that works... great :)  Much better than what I

[PATCH 2/4] net: update the spider_net driver

2005-08-18 Thread Arnd Bergmann
- fix device cleanup From: Jens Osterkamp [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] diff -u devel-akpm/drivers/net/spider_net.c linux-2.6.13-rc3/drivers/net/spider_net.c --- devel-akpm/drivers/net/spider_net.c 2005-08-06 15:34:31.0 -0700 +++ linux-2.6.13-rc3/drivers

[PATCH 05/25] net: move ppp specific ioctl32 handlers

2005-11-05 Thread Arnd Bergmann
This moves all ioctl32 code for ppp close to the native ioctl implementation. CC: linux-ppp@vger.kernel.org CC: netdev@vger.kernel.org Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.14-rc/drivers/net/ppp_generic.c

[PATCH 03/25] net: improve ioctl32 dev_ioctl handling

2005-11-05 Thread Arnd Bergmann
This patch tries to be a bit smarter about net device ioctl emulation. In particular, the wireless extensions are treated as a group in order to make the switch list a little shorter. CC: netdev@vger.kernel.org Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-cg/net/compat.c

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-09-04 Thread Arnd Bergmann
Am Monday 04 September 2006 22:16 schrieb Francois Romieu: +#include ehea.h +#include ehea_qmr.h +#include ehea_phyp.h Afaik none of those is included in this patch nor in my 2.6.18-git tree. They are in 5, 3 and 2, respectively Happy bissect in sight. The driver should get merged as

Re: [take15 1/4] kevent: Core files.

2006-09-05 Thread Arnd Bergmann
On Monday 04 September 2006 12:14, Evgeniy Polyakov wrote: +asmlinkage long sys_kevent_get_events(int ctl_fd, unsigned int min_nr, unsigned int max_nr, __u64 timeout, void __user *buf, unsigned flags) +asmlinkage long sys_kevent_ctl(int fd, unsigned int cmd,

Re: [take15 4/4] kevent: Timer notifications.

2006-09-05 Thread Arnd Bergmann
On Monday 04 September 2006 12:14, Evgeniy Polyakov wrote: Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. I guess this must have been discussed before, but why is this not using

Re: [PATCH] VIOC: New Network Device Driver

2006-09-10 Thread Arnd Bergmann
Am Friday 15 September 2006 02:15 schrieb Misha Tomushev: VIOC Device Driver provides a standard device interface to the internal fabric interconnected network used on servers designed and built by Fabric 7 Systems. The patch can be found at ftp.fabric7.com/VIOC. We recently had a discussion

Re: [PATCH] VIOC: New Network Device Driver

2006-09-11 Thread Arnd Bergmann
On Monday 11 September 2006 19:58, Misha Tomushev wrote: The descriptor clean-up does not contribute anything to the performance of the driver, it just replenishes the memory pools. It almost does not need interrupts. Why would we want to add more cycles to the receive logic, when driver is

Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-09-30 Thread Arnd Bergmann
-interrupt operation can be actually observed for this driver, when the socket buffer is made large enough. Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 5/6]: powerpc/cell spidernet ethtool -i version number

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:26 schrieb Linas Vepstas: This patch moves transmit queue cleanup code out of the interrupt context, and into the NAPI polling routine. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED

Re: [PATCH 3/6]: powerpc/cell spidernet stop error printing patch.

2006-09-30 Thread Arnd Bergmann
PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas: This patch adds version information as reported by ethtool -i to the Spidernet driver. From: James K Lewis [EMAIL PROTECTED] Signed-off-by: James K Lewis [EMAIL PROTECTED] Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: Arnd

Re: [PATCH 1/6]: powerpc/cell spidernet burst alignment patch.

2006-09-30 Thread Arnd Bergmann
] Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 0/6]: powerpc/cell spidernet ethernet patches

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:05 schrieb Linas Vepstas: Although these patches have not been baking in any -mm tree, they have been tested and are generally available as a part of the Cell SDK 2.0 overseen by Arnd Bergmann. (Arnd, if you want to lend a voice of authority here

Re: [PATCH 0/6]: powerpc/cell spidernet ethernet patches

2006-10-02 Thread Arnd Bergmann
On Monday 02 October 2006 18:27, Linas Vepstas wrote: I'm not sure if I have missed a patch in here, but I don't see anything reintroducing the 'netif_stop_queue' that is missing from the transmit path. Do you have a extra patch for that? Unfinished.  There are several ways in

Re: [PATCH 1/4]: Spidernet stop queue when queue is full

2006-10-03 Thread Arnd Bergmann
On Tuesday 03 October 2006 22:57, Linas Vepstas wrote: +   if ((chain-head-next == chain-tail-prev) || +      (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE)) { result = NETDEV_TX_LOCKED; goto out; } ...  out: -   

Re: [PATCH 21/21]: powerpc/cell spidernet DMA coalescing

2006-10-11 Thread Arnd Bergmann
On Wednesday 11 October 2006 03:46, Geoff Levand wrote: The others look good, but this one complicates the code and doesn't have any benefit.  20 for 21 isn't bad. Is the motivation for this change to improve performance by reducing the overhead of the mapping calls?  If so, there

Re: [PATCH 0/21]: powerpc/cell spidernet bugfixes, etc.

2006-10-11 Thread Arnd Bergmann
On Tuesday 10 October 2006 22:49, Linas Vepstas wrote: Andrew, please apply/forward upstream. The following set of 21 patches (!) are all aimed at the the spidernet ethernet device driver. The spidernet is an etherenet controller built into the Toshiba southbridge for the PowerPC Cell

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-26 Thread Arnd Bergmann
On Tuesday 16 January 2007 19:55, Marcelo Tosatti wrote: Announcing an updated patch of the Marvell Libertas 8388 802.11 USB driver. Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch _Please_ review, this driver is targeted for mainline inclusion.

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-02-05 Thread Arnd Bergmann
On Monday 05 February 2007 15:01, John W. Linville wrote: I disagree, entry/exit points have been shown to be useful in practice to identify firmware problems on field. I'm not too fond of the ENTER/LEAVE stuff either.  But, I do sympathize that they _can_ be useful in certain

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-17 Thread Arnd Bergmann
Am Thursday 18 May 2006 00:06 schrieb Brice Goglin: +static char *myri10ge_fw_name = NULL; +static char *myri10ge_fw_unaligned = myri10ge_ethp_z8e.dat; +static char *myri10ge_fw_aligned = myri10ge_eth_z8e.dat; +static int myri10ge_ecrc_enable = 1; +static int myri10ge_max_intr_slots = 1024;

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-18 Thread Arnd Bergmann
Am Friday 19 May 2006 01:56 schrieb Brice Goglin: This place is actually the only one where we don't want to use msleep. This function (myri10ge_send_cmd) might be called from various context (spinlocked or not) and pass orders to the NIC whose processing time depends a lot on the command. Of

[PATCH 11/14] spidernet: fix Kconfig after BPA-CELL rename

2005-12-05 Thread Arnd Bergmann
We changed the name of the Kconfig symbols along with the move to arch/powerpc. This one hunk got lost during the conversion. From: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.15-rc1/drivers/net/Kconfig

[PATCH 12/14] spidernet: check if firmware was loaded correctly

2005-12-05 Thread Arnd Bergmann
Uploading the device firmware may fail if wrong input data was provided by the user. This checks for the condition. From: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.15-rc/drivers/net/spider_net.c

[PATCH 13/14] spidernet: read firmware from the OF device tree

2005-12-05 Thread Arnd Bergmann
the system. From: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.15-rc/drivers/net/spider_net.c === --- linux-2.6.15-rc.orig/drivers/net/spider_net.c +++ linux-2.6.15-rc

[PATCH 14/14] spidernet: fix HW structures for 64 bit dma_addr_t

2005-12-05 Thread Arnd Bergmann
The driver incorrectly used dma_addr_t to describe HW structures and consequently broke when that type was changed in 2.6.15-rc. This changed spidernet to use u32 for 32 bit HW defined structure elements. From: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org Signed-off-by: Arnd Bergmann [EMAIL

Re: [PATCH 12/14] spidernet: check if firmware was loaded correctly

2005-12-06 Thread Arnd Bergmann
On Dinsdag 06 Dezember 2005 01:59, Paul Mackerras wrote: Arnd Bergmann writes: Uploading the device firmware may fail if wrong input data was provided by the user. This checks for the condition. From: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org This one should be sent to Jeff

Re: [patch 4/5] spidernet: fix HW structures for 64 bit dma_addr_t

2005-12-21 Thread Arnd Bergmann
Jeff Garzik wrote: Assumptions or not, we have a standard way of documenting these assumptions in the source code... __be32 and cpu_to_be32() do the right thing (become no-ops) on BE, while ensuring that we can continue to use valuable source checking tools. If the Cell drivers ever need

Subject: spidernet: fix missing include

2006-01-09 Thread Arnd Bergmann
Including in.h is now required to avoid drivers/net/spider_net.c:844: error: 'IPPROTO_TCP' undeclared Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.16-rc/drivers/net/spider_net.c === --- linux-2.6.16-rc.orig

Re: [PATCH 1/2 RESEND- 2.6.15] net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-10 Thread Arnd Bergmann
On Tuesday 10 January 2006 05:31, Shaun Pereira wrote: Hi Arnd, Arnaldo Thanks for your comments. I initially did not wish to change any of the other modules, but based on Arnd's comments I have removed the extra macro, SOCKOPS_COMPAT_WRAP and use the original SOCKOPS_WRAP. Ok, looks better

Re: [PATCH 2/2 - 2.6.15]net:32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-10 Thread Arnd Bergmann
On Tuesday 10 January 2006 05:31, Shaun Pereira wrote: --- linux-2.6.15-vanilla/include/net/x25.h2006-01-03 14:21:10.0 +1100 +++ linux-2.6.15/include/net/x25.h2006-01-10 16:15:16.0 +1100 @@ -223,6 +223,18 @@ extern struct x25_route *x25_get_route(s extern struct

Re: 32 bit (socket layer) ioctl emulation for 64 bit kernels - patch1

2006-01-11 Thread Arnd Bergmann
On Wednesday 11 January 2006 06:24, Shaun Pereira wrote:  Thanks for reviewing those patches, and your feedback. I have made the changes recommended. If these are acceptable, I will build a proper [PATCH] for submission. This patch looks good to me now. Is there anyone in particular that I

Re: [PATCH] net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-11 Thread Arnd Bergmann
On Wednesday 11 January 2006 06:28, Shaun Pereira wrote: And the correct x.25 patch, (will build a [PATCH] if this is ok). Tested with with xot to a Cisco box. Much better now, but + switch(cmd) { + case TIOCOUTQ: + case TIOCINQ: Looking at how these are

Re: [PATCH 2/4 - 2.6.15]net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-12 Thread Arnd Bergmann
On Thursday 12 January 2006 06:02, Shaun Pereira wrote: +int compat_sock_get_timestamp(struct sock *sk, struct timeval __user *userstamp) +{ +   struct compat_timeval __user *ctv; +   ctv = (struct compat_timeval __user*) userstamp; +   if(!sock_flag(sk, SOCK_TIMESTAMP)) +   

[patch 3/5] spidernet: fix HW structures for 64 bit dma_addr_t

2006-01-12 Thread Arnd Bergmann
] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.16-rc/drivers/net/spider_net.h === --- linux-2.6.16-rc.orig/drivers/net/spider_net.h +++ linux-2.6.16-rc/drivers/net/spider_net.h @@ -373,9 +373,9 @@ enum

[patch 5/5] spidernet: fix missing include

2006-01-12 Thread Arnd Bergmann
This is now required to avoid drivers/net/spider_net.c:844: error: 'IPPROTO_TCP' undeclared Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.16-rc/drivers/net/spider_net.c === --- linux-2.6.16-rc.orig/drivers/net

[patch 0/5] [RESEND^2] spidernet fixes

2006-01-12 Thread Arnd Bergmann
On Thursday 12 January 2006 21:38, Jeff Garzik wrote: failed on first patch: [EMAIL PROTECTED] netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt 5 patch(es) to process. Applying 'spidernet: check if firmware was loaded correctly' fatal: corrupt patch at line 39 Ok, I'm

[patch 2/5] spidernet: read firmware from the OF device tree

2006-01-12 Thread Arnd Bergmann
the system. From: Jens Osterkamp [EMAIL PROTECTED] Signed-off-by: Jens Osterkamp [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.16-rc/drivers/net/spider_net.c === --- linux-2.6.16-rc.orig/drivers/net

[patch 4/5] spidernet: performance optimizations

2006-01-12 Thread Arnd Bergmann
[EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: linux-2.6.16-rc/drivers/net/spider_net.c === --- linux-2.6.16-rc.orig/drivers/net/spider_net.c +++ linux-2.6.16-rc/drivers/net/spider_net.c @@ -22,7 +22,6

Re: [PATCH 2/4 - 2.6.15]net: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-13 Thread Arnd Bergmann
On Friday 13 January 2006 03:14, Shaun Pereira wrote: Thank you for reviewing that bit of code.   I had a look at compat_sys_gettimeofday and sys32_gettimeofday codes. They seem to work in a similar way, casting a pointer to the structure from user space to a compat_timeval type. The part

Re: [PATCH 3/4 -2.6.15]:x25: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-16 Thread Arnd Bergmann
Am Dienstag, 17. Januar 2006 00:12 schrieb Shaun Pereira: +static int compat_x25_subscr_ioctl(unsigned int cmd, + struct compat_x25_subscrip_struct __user *x25_subscr32) +{ + struct x25_subscrip_struct x25_subscr; + struct x25_neigh *nb; + struct net_device

Re: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-18 Thread Arnd Bergmann
and Signed-off-by: line like it is described in Documentation/SubmittingPatches. You can add an 'Acked-by: Arnd Bergmann [EMAIL PROTECTED]' line to the four patches you posted last if you like. Usually submitted/reviewed patches to netdev does not not always guarantee they will be acccepted/signed

Re: [PATCH] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-11-15 Thread Arnd Bergmann
On Thursday 16 November 2006 01:11, divy wrote: This patch adds support for the latest Chelsio adapter, T3. Since some files are bigger than the 40kB advertized in the submit guidelines, a monolithic patch against 2.6.19-rc5 is posted at the following URL:

Re: [Cbe-oss-dev] [RFC][PATCH] spidernet: enable fiber autonegotiation

2006-11-27 Thread Arnd Bergmann
On Monday 27 November 2006 15:47, Jens Osterkamp wrote: While experimenting with a copper passthrough module in bladecenter I found out that this needs autonegotiation enabled in order to work properly. This quick hack enables it with the sideeffect of breaking other bladecenter switch

Re: [Cbe-oss-dev] [RFC][PATCH] spidernet: enable fiber autonegotiation

2006-11-27 Thread Arnd Bergmann
On Monday 27 November 2006 16:46, Jens Osterkamp wrote: Thanks for pointing me to this, I must have overlooked it. Some of it seems only applicable to the Celleb copper interface, but some of it is quite usable for us too. Is it already queued upstream ? No, I'm currently waiting for an

Re: [PATCH/RESEND] ehea: fix for dlpar and sysfs entries

2007-04-23 Thread Arnd Bergmann
On Monday 23 April 2007, Jan-Bernd Themann wrote: - dlpar fix: certain resources may only be allocated when first logical port is available, and must be removed when last logical port has been removed - sysfs entries: create symbolic link from each logical

Re: finding your own dead CONFIG_ variables

2007-05-03 Thread Arnd Bergmann
On Thursday 03 May 2007, Robert P. J. Day wrote: Suggest: configfiles=$(find . -name 'Kconfig*' -or -name '*defconfig*') Some CONFIG_ options exist that are not declared anywhere in the Kconfig files but defined directly in the arch/.../*defconfig* files. it's my understanding that

Re: spider_net versus sungem_phy

2006-03-06 Thread Arnd Bergmann
Am Monday 06 March 2006 23:07 schrieb Andrew Morton: Jens Osterkamp [EMAIL PROTECTED] wrote: Which kernel version was this in ? 2.6.16-rc5 builds ok for me. drivers/net/spider_net.c:421: multiple definition of `mii_phy_probe'

Re: 32bit compat for rtnetlink wireless extensions?

2006-03-27 Thread Arnd Bergmann
Am Monday 27 March 2006 20:42 schrieb Jean Tourrilhes: Actually, when things are passed over RtNetlink, the pointer is removed, and the content of IW_HEADER_TYPE_POINT is moved to not leave a gap. Ah, that makes sense, thanks for the explanation. So if the wireless ioctl interface

Re: [PATCH 2/6] ehea: pHYP interface

2006-08-09 Thread Arnd Bergmann
On Wednesday 09 August 2006 10:38, Jan-Bernd Themann wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_hcall.h 1969-12-31 16:00:00.0 -0800 +++ kernel/drivers/net/ehea/ehea_hcall.h2006-08-08 23:59:38.111462960 -0700 @@ -0,0 +1,52 @@ + +/** + * This file contains

Re: [PATCH 4/6] ehea: header files

2006-08-09 Thread Arnd Bergmann
On Wednesday 09 August 2006 10:39, Jan-Bernd Themann wrote: +extern int ehea_trace_level; + +#ifdef EHEA_NO_EDEB +#define EDEB_P_GENERIC(level, idstring, format, args...) \ +   while (0 == 1) { \ +       if(unlikely (level = ehea_trace_level)) { \ +   printk(%s

Re: [PATCH 0/4]: powerpc/cell spidernet ethernet driver fixes

2006-08-11 Thread Arnd Bergmann
On Friday 11 August 2006 21:31, Linas Vepstas wrote: I put my name at the top when I was the primary author. I put Jim's name at the top when he was the primary author. Both names are there because I sat in Jim's office and used his keyboard. I got him to compile and run the tests on his

Re: [PATCH 1/6] ehea: interface to network stack

2006-08-14 Thread Arnd Bergmann
On Monday 14 August 2006 17:43, Jan-Bernd Themann wrote: as our queue size is always a power of 2, we simply use: i++; i = (ringbufferlength - 1) So we can get along without the if. The recommended (by Linus) way for dealing with ring buffers like that is to always read the counter

Re: [PATCH 1/1] network memory allocator.

2006-08-16 Thread Arnd Bergmann
On Wednesday 16 August 2006 11:00, Evgeniy Polyakov wrote: There is drawback here - if data was allocated on CPU wheere NIC is closer and then processed on different CPU it will cost more than in case where buffer was allocated on CPU where it will be processed. But from other point of

Re: [PATCH 1/2]: powerpc/cell spidernet bottom half

2006-08-16 Thread Arnd Bergmann
Am Wednesday 16 August 2006 22:46 schrieb David Miller: I'm not familiar with the spidernet TX side interrupt capabilities so I can't say whether that is something that can be directly implied.  In fact, I get the impression that spidernet is limited in some way and that's where all the

Re: [PATCH 1/2]: powerpc/cell spidernet bottom half

2006-08-16 Thread Arnd Bergmann
Am Wednesday 16 August 2006 23:32 schrieb David Miller: Can spidernet be told these kinds of parameters?  N packets or X usecs? It can not do exactly this but probably we can get close to it by 1.) Setting a one-time interrupt to fire x*10µs after putting a packet into the TX queue. and

Re: [PATCH 1/2]: powerpc/cell spidernet bottom half

2006-08-16 Thread Arnd Bergmann
Am Thursday 17 August 2006 00:29 schrieb David Miller: Didn't you say spidernet's facilities were sophisticated? :) This Tigon3 stuff is like 5+ year old technology. I was rather overwhelmed by the 34 different interrupts that the chip can create, that does not mean they chose the right events

Re: [PATCH 1/2]: powerpc/cell spidernet bottom half

2006-08-16 Thread Arnd Bergmann
Am Thursday 17 August 2006 00:55 schrieb Linas Vepstas: it only seems to be hard to make it go fast using any of them. Last round of measurements seemed linear for packet sizes between 60 and 600 bytes, suggesting that the hardware can handle a maximum of 120K descriptors/second,

Re: [2.6.19 PATCH 3/7] ehea: queue management

2006-08-18 Thread Arnd Bergmann
On Friday 18 August 2006 15:25, Thomas Klein wrote: wow... is this really so large that it warrants a vmalloc()??? Agreed: Replaced with kmalloc() My understanding from the previous discussion was that it actually is a multi-page power of two allocation, so the right choice might be

Re: [2.6.19 PATCH 3/7] ehea: queue management

2006-08-18 Thread Arnd Bergmann
On Friday 18 August 2006 16:24, Christoph Raisch wrote: And as always in performance tuning... one size fits all unfortunately is not the correct answer. Ah, good. What is the maximum sensible value that you came up with? Therefore we'll leave that open to the user as most other new ethernet

Re: [PATCH 1/6]: powerpc/cell spidernet burst alignment patch

2006-08-18 Thread Arnd Bergmann
On Saturday 19 August 2006 00:20, Linas Vepstas wrote: This patch increases the Burst Address alignment from 64 to 1024 in the Spidernet driver. This improves transmit performance for arge packets from about 100Mbps to 300-400Mbps. Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe

Re: [PATCH 5/6]: powerpc/cell spidernet bottom half

2006-08-18 Thread Arnd Bergmann
On Saturday 19 August 2006 00:26, Linas Vepstas wrote: The recent set of low-waterark patches for the spider result in a significant amount of computing being done in an interrupt context. This patch moves this to a bottom half aka work queue, so that the code runs in a normal kernel context.

[RFC] HOWTO use NAPI to reduce TX interrupts

2006-08-18 Thread Arnd Bergmann
On Saturday 19 August 2006 01:03, Arnd Bergmann wrote: Someone should probably document that in Documentation/networking/NAPI_HOWTO.txt, I might end up doing that once we get it right for spidernet. Oh well, what else is there to do on a Friday night ;-) This is a first draft, I expect

Re: [RFC] HOWTO use NAPI to reduce TX interrupts

2006-08-19 Thread Arnd Bergmann
On Sunday 20 August 2006 03:31, Stephen Hemminger wrote: The reason reclaim via poll() is efficient is because it avoid causing a softirq that is necessary when skb_free_irq() is done. Instead it reuses the softirq from the poll() routine. Ok, I completely missed this point so far,

Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

2006-08-19 Thread Arnd Bergmann
On Saturday 19 August 2006 10:41, Michael Ellerman wrote: A lot of these have started appearing recently, which I think is due to GCC becoming more vocal. Unfortunately many of them are false positives caused by GCC not seeming to grok that this is ok: void foo(int *x) { *x = 1; } ... int

Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-08-20 Thread Arnd Bergmann
On Sunday 20 August 2006 08:31, Benjamin Herrenschmidt wrote: card-low_watermark-next-dmac_cmd_status |= SPIDER_NET_DESCR_TXDESFLG; mb(); card-low_watermark-dmac_cmd_status = ~SPIDER_NET_DESCR_TXDESFLG; card-low_watermark = card-low_watermark-next; when we queue another frame for TX.

[RFC v2] HOWTO use NAPI to reduce TX interrupts

2006-08-20 Thread Arnd Bergmann
this. Please tell me if anything in here is still wrong or could use better wording. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] --- This is the second version of my mini howto, after a few comments I got from Stephen Hemminger and Avuton Olrich. Index: linux-cg/Documentation/networking

[PATCH] spidernet: enable poll() before registering interrupts

2007-07-11 Thread Arnd Bergmann
We must not call netif_poll_enable after enabling interrupts, because an interrupt might come in and set the __LINK_STATE_RX_SCHED bit before we get to clear that bit again. If that happens, the next call to the -poll() function will oops. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-09 Thread Arnd Bergmann
On Thursday 09 August 2007, Chris Snook wrote: This patchset makes the behavior of atomic_read uniform by removing the volatile keyword from all atomic_t and atomic64_t definitions that currently have it, and instead explicitly casts the variable as volatile in atomic_read().  This leaves

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-09 Thread Arnd Bergmann
On Thursday 09 August 2007, Chris Snook wrote: a) chicken and egg: asm-generic/atomic.h depends on definitions in asm/atomic.h Ok, I see. If you can find a way to reshuffle the code and make it simpler, I personally am all for it. I'm skeptical that you'll get much to show for the

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-14 Thread Arnd Bergmann
On Tuesday 14 August 2007, Paul E. McKenney wrote: #define order(x) asm volatile( : +m (x)) There was something very similar discussed earlier in this thread, with quite a bit of debate as to exactly what the m flag should look like.  I suggested something similar named ACCESS_ONCE in the

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-15 Thread Arnd Bergmann
On Wednesday 15 August 2007, Paul E. McKenney wrote: ACCESS_ONCE() is indeed intended to be used when actually loading or storing the variable. That said, I must admit that it is not clear to me why you would want to add an extra order() rather than ACCESS_ONCE()ing one or both of the

Re: [PATCH] spidernet: enable poll() before registering interrupts

2007-08-20 Thread Arnd Bergmann
On Tuesday 21 August 2007, Linas Vepstas wrote: An intervening patch changed the init so that the hardware interrupts aren't enabled until after the request_irq, and after the poll_enable().  Thus, it seems this pach is no longer needed, right? Right, the other patch that you already

Re: new NAPI interface broken for POWER architecture?

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Christoph Raisch wrote: David Miller [EMAIL PROTECTED] wrote on 12.09.2007 14:50:04: I agree that it should be fixed, but we should also fix the IRQ distribution scheme used on powerpc platforms which is totally broken in these cases. This is definitely

Re: [PATCH] net/core: split dev_ifsioc() according to locking

2007-10-06 Thread Arnd Bergmann
On Saturday 06 October 2007, Jeff Garzik wrote: This always bugged me:  dev_ioctl() called dev_ifsioc() either inside read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being executed. This change moves the ioctls executed inside dev_base_lock to a new function,

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Arnd Bergmann
On Thursday 22 November 2007, Andi Kleen wrote:  #define EXPORT_SYMBOL(sym) \ -   __EXPORT_SYMBOL(sym, ) +   __EXPORT_SYMBOL(sym, ,,, NULL)    #define EXPORT_SYMBOL_GPL(sym) \ -   __EXPORT_SYMBOL(sym, _gpl) +

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-29 Thread Arnd Bergmann
On Thursday 29 November 2007, Andi Kleen wrote: I think it would be good if you could specify a default namespace per module, that could reduce the amount of necessary changes significantly. But also give less documentation. It's also not that difficult to mark the exports once. I've

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-28 Thread Arnd Bergmann
On Friday 25 January 2008, Jochen Friedrich wrote: Maybe the wording should be changed to: This driver is now only used on ColdFire (m68knommu) processors. Conditional PowerPC code has been removed. How about adding a pointer to the driver that is now used on powerpc, for the people that

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Arnd Bergmann
On Monday 20 April 2015 22:40:57 Thomas Gleixner wrote: On Mon, 20 Apr 2015, Baolin Wang wrote: @@ -771,6 +771,7 @@ SYSCALL_DEFINE2(timer_gettime, timer_t, timer_id, struct itimerspec __user *, setting) { struct itimerspec cur_setting; + struct itimerspec64

Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions

2015-04-21 Thread Arnd Bergmann
On Tuesday 21 April 2015 16:36:13 Baolin Wang wrote: On 21 April 2015 at 04:48, Thomas Gleixner t...@linutronix.de wrote: On Mon, 20 Apr 2015, Baolin Wang wrote: /* Set clock_realtime */ static int posix_clock_realtime_set(const clockid_t which_clock, -

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Arnd Bergmann
On Tuesday 21 April 2015 16:14:26 Thomas Gleixner wrote: Note the use of a separate __kernel_itimerspec64 for the user interface here, which I think will be needed to hide the differences between the normal itimerspec on 64-bit machines, and the new itimerspec on 32-bit platforms that will

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-21 Thread Arnd Bergmann
On Tuesday 21 April 2015 17:13:32 Thomas Gleixner wrote: On Tue, 21 Apr 2015, Arnd Bergmann wrote: On Tuesday 21 April 2015 16:14:26 Thomas Gleixner wrote: Note the use of a separate __kernel_itimerspec64 for the user interface here, which I think will be needed to hide the differences

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: I've started a list of affected syscalls at https://docs.google.com/spreadsheets/d/1HCYwHXxs48TsTb6IGUduNjQnmfRvMPzCN6T_0YiQwis/edit?usp=sharing Still adding more calls and description, let me know if you want edit permissions

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 17:14:47 Luc Van Oostenryck wrote: On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: ... select, old_selct, pselect6: deprecated Small, copypaste error here for pselect6. Right, that should

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 16:54:32 Richard Cochran wrote: On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: time, stime, gettimeofday, settimeofday, adjtimex, nanosleep, getitimer, setitimer: all deprecated = wontfix If adjtimex is deprecated, what will replace

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 10:45:23 Thomas Gleixner wrote: On Tue, 21 Apr 2015, Thomas Gleixner wrote: So we could save one translation step if we implement new syscalls which have a scalar nsec interface instead of the timespec/timeval cruft and let user space do the translation to whatever

Re: [PATCH net-next 2/6] net: hip04: use the big endian for tx and rx desc

2015-04-15 Thread Arnd Bergmann
On Wednesday 15 April 2015 20:30:04 Ding Tianhong wrote: The hip04 ethernet use the big endian for tx and rx, so set desc to big endian and remove the unused next_addr. I don't understand: diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c

Re: [PATCH net-next 5/6] net: hip04: remove the unnecessary check

2015-04-15 Thread Arnd Bergmann
); if (unlikely(netif_queue_stopped(ndev)) (count (TX_DESC_NUM - 1))) -- Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH net-next 4/6] net: hip04: Don't free the tx skb when the buffer is not ready for xmit

2015-04-15 Thread Arnd Bergmann
On Wednesday 15 April 2015 20:30:06 Ding Tianhong wrote: @@ -489,6 +487,8 @@ static int hip04_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev) /* Ensure tx_head update visible to tx reclaim */ smp_wmb(); + count++; + priv-tx_head =

Re: [PATCH net-next 3/6] net: hip04: Solve the problem of the skb memory allocation failure

2015-04-15 Thread Arnd Bergmann
the memory again to fix this problem. Signed-off-by: Ding Tianhong dingtianh...@huawei.com Cc: David S. Miller da...@davemloft.net Cc: Eric Dumazet eric.duma...@gmail.com Cc: Arnd Bergmann a...@arndb.de Cc: Zhangfei Gao zhangfei@linaro.org Cc: Dan Carpenter dan.carpen...@oracle.com Cc

Re: [PATCH net-next 1/6] net: hip04: Set more appropriate value for tx coalesce num

2015-04-15 Thread Arnd Bergmann
...@davemloft.net Cc: Eric Dumazet eric.duma...@gmail.com Cc: Arnd Bergmann a...@arndb.de Cc: Zhangfei Gao zhangfei@linaro.org Cc: Dan Carpenter dan.carpen...@oracle.com Cc: Joe Perches j...@perches.com Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line

Re: [PATCH net-next 6/6] net: hip04: add ratelimit for rx/tx drops skb

2015-04-15 Thread Arnd Bergmann
Dumazet eric.duma...@gmail.com Cc: Arnd Bergmann a...@arndb.de Cc: Zhangfei Gao zhangfei@linaro.org Cc: Dan Carpenter dan.carpen...@oracle.com Cc: Joe Perches j...@perches.com Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH net-next 0/6] net: hip04: fix some problem for hip04 drivers

2015-04-15 Thread Arnd Bergmann
disabled together, in order to simplify the logic and to avoid getting rx-dropped interrupts when NAPI is in control of the rx queue. Signed-off-by: Arnd Bergmann a...@arndb.de diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c index 525214ef5984

Re: [PATCH net-next 4/6] net: hip04: Don't free the tx skb when the buffer is not ready for xmit

2015-04-16 Thread Arnd Bergmann
On Thursday 16 April 2015 14:26:21 Ding Tianhong wrote: On 2015/4/15 22:19, Arnd Bergmann wrote: On Wednesday 15 April 2015 20:30:06 Ding Tianhong wrote: @@ -489,6 +487,8 @@ static int hip04_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev) /* Ensure tx_head update

Re: [patch v2] net: hip04: Make tx coalesce timer actually work

2015-04-15 Thread Arnd Bergmann
...@linutronix.de Cc: David S. Miller da...@davemloft.net Cc: dingtianhong dingtianh...@huawei.com Cc: Arnd Bergmann a...@arndb.de Cc: Zhangfei Gao zhangfei@linaro.org Cc: Dan Carpenter dan.carpen...@oracle.com Cc: netdev@vger.kernel.org Acked-by: Arnd Bergmann a...@arndb.de

Re: [PATCH v2] isdn: Use ktime_t instead of 'struct timeval'

2015-05-20 Thread Arnd Bergmann
On Tuesday 19 May 2015 13:03:06 Tina Ruchandani wrote: 'struct timeval' uses 32-bit representation for seconds which will overflow in year 2038 and beyond. mISDN/clock.c needs to compute and store elapsed time in intervals of 125 microseconds. This patch replaces the usage of 'struct timeval'

[PATCH] net: thunderx: add 64-bit dependency

2015-05-28 Thread Arnd Bergmann
on an arm64 SoC, this is not a problem for usability. Allowing the build on all 64-bit architectures rather than just CONFIG_ARM64 on the other hand means that we get the benefit of build testing on x86. Signed-off-by: Arnd Bergmann a...@arndb.de diff --git a/drivers/net/ethernet/cavium/Kconfig b

  1   2   3   4   5   6   7   8   9   10   >