deadlink in genetlink?

2007-09-24 Thread Ben Pfaff
; it silences lockdep, at least. It is not clear to me what the value of taking the mutex is there. If this is an appropriate fix, here is a patch for it. Signed-off-by: Ben Pfaff [EMAIL PROTECTED] diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 8c11ca4..2e79035 100644 --- a/net

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-03 Thread Ben Pfaff
On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > intact through linux networking stack. > > Signed-off-by: Michał Mirosław > --- > > Dear NetDevs > > I guess this

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-05 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed &g

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-05 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 11:52:47PM +0100, Michał Mirosław wrote: > On Mon, Dec 05, 2016 at 10:55:45AM -0800, Ben Pfaff wrote: > > On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > > > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > > >

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 09:41:51AM +, Yang, Yi Y wrote: > Hi, Jan > > I have worked out a patch, will send it quickly for Ben. In addition, I also > will send out a patch to change encap_nsh _nsh to push_nsh and pop_nsh. > Per comments from all the people, we all agreed to do so :-) > >

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-08 Thread Ben Pfaff
comments. > > __be32 c[4] is the name Ben Pfaff suggested, the original name is c1, c2, c3, > c4, they are context data, so c seems ok, too :-) > > OVS has merged it and has the same name, maybe the better way is adding > comment /* Context data */ after it. > >

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Ben Pfaff
t I'm not a kernel-side maintainer of any kind. I am only passing along what I've perceived to be common Netlink protocol design patterns. > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Ben Pfaff > Sent: Thu

Re: [PATCH net-next v4] openvswitch: enable NSH support

2017-08-22 Thread Ben Pfaff
On Tue, Aug 22, 2017 at 08:32:49AM +, Jan Scheurich wrote: > > > Or why else does OVS user space code take so great pain to model > > > possible misalignment and provide/use safe access functions? > > > > I don't know how the ovs user space deals with packet allocation. In > > the kernel, the

Re: [ovs-dev] Pravin Shelar

2017-12-27 Thread Ben Pfaff
On Wed, Dec 27, 2017 at 04:22:55PM +0100, Julia Lawall wrote: > The email address pshe...@nicira.com listed for Pravin Shelar in > MAINTAINERS (OPENVSWITCH section) seems to bounce. Pravin has used a newer address recently, so I sent out a suggested update (for OVS):

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-07-31 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 07:43:34PM +, Matteo Croce wrote: > On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote: > > > > On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote: > > > > > > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote: > > > > From: Stefano Brivio > > > > > > > > Open

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-08-03 Thread Ben Pfaff
On Fri, Aug 03, 2018 at 06:52:41PM +0200, Stefano Brivio wrote: > On Tue, 31 Jul 2018 15:06:57 -0700 Ben Pfaff wrote: > > My current thought is that any fairness scheme we implement directly in > > the kernel is going to need to evolve over time. Maybe we could do > > someth

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-08-03 Thread Ben Pfaff
On Sat, Aug 04, 2018 at 02:43:24AM +0200, Stefano Brivio wrote: > On Fri, 3 Aug 2018 16:01:08 -0700 > Ben Pfaff wrote: > > I would be very pleased if we could integrate a simple mechanism for > > fairness, based for now on some simple criteria like the source port, > > b