[PATCH RESEND] mlx4: Fix tx ring affinity_mask creation

= nr_cpu_ids. Signed-off-by: Benjamin Poirier bpoir...@suse.de Acked-by: Ido Shamay i...@mellanox.com Fixes: d03a68f (net/mlx4_en: Configure the XPS queue mapping on driver load) --- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] mlx4: Fix tx ring affinity_mask creation

On 2015/04/13 17:22, Benjamin Poirier wrote: On 2015/04/12 10:03, Ido Shamay wrote: Hi Benjamin, On 4/10/2015 7:27 PM, Benjamin Poirier wrote: By default, the number of tx queues is limited by the number of online cpus in mlx4_en_get_profile(). However, this limit no longer holds

[PATCH] mlx4_core: Fix fallback from MSI-X to INTx

user of MLX4_CMD_NOP. Fixes: f5aef5a (net/mlx4_core: Activate reset flow upon fatal command cases) Signed-off-by: Benjamin Poirier bpoir...@suse.de --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox

[PATCH] net-timestamp: Update skb_complete_tx_timestamp comment

After 62bccb8 net-timestamp: Make the clone operation stand-alone from phy timestamping the hwtstamps parameter of skb_complete_tx_timestamp() may no longer be NULL. Signed-off-by: Benjamin Poirier bpoir...@suse.com Cc: Alexander Duyck alexander.h.du...@redhat.com --- include/linux/skbuff.h | 6

[PATCH 2/2] e1000e: Fix msi-x interrupt automask

t; interrupts. Since e1000_msix_other() reads ICR, all interrupts must be rearmed in that function. Reported-by: Frank Steiner <steiner-...@bio.ifi.lmu.de> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++-- 1 file ch

[PATCH 1/2] e1000e: remove unreachable code

msi-x interrupts are not shared so there's no need to check if the interrupt was really from this adapter. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/intel/

[PATCH 0/2] e1000e msi-x fixes

Hi, For this series: Benjamin Poirier (2): e1000e: remove unreachable code e1000e: Fix msi-x interrupt automask drivers/net/ethernet/intel/e1000e/netdev.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) The first patch is a cleanup but the second one

[PATCH v3 1/4] e1000e: Remove unreachable code

msi-x interrupts are not shared so there's no need to check if the interrupt was really from this adapter. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/intel/

[PATCH v3 0/4] e1000e msi-x fixes

Hi, For this series: Benjamin Poirier (4): e1000e: Remove unreachable code e1000e: Do not read icr in Other interrupt e1000e: Do not write lsc to ics in msi-x mode e1000e: Fix msi-x interrupt automask drivers/net/ethernet/intel/e1000e/defines.h | 3 +- drivers/net/ethernet/intel

[PATCH v3 2/4] e1000e: Do not read icr in Other interrupt

cause that can trigger the Other interrupt is Link Status Change. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- I noticed a 8-16% improvement in netperf rr tests after applying this patch. This is a little surprising since this patch touches the handling of Other interrupts, wh

[PATCH v3 4/4] e1000e: Fix msi-x interrupt automask

ars IAME from CTRL_EXT. This is not strictly necessary for operation of the driver but it is to avoid disruption from potential programs that access the registers directly, like `ethregs -c`. Reported-by: Frank Steiner <steiner-...@bio.ifi.lmu.de> Signed-off-by: Benjamin Poirier <bpoir

[PATCH v3 3/4] e1000e: Do not write lsc to ics in msi-x mode

In msi-x mode, there is no handler for the lsc interrupt so there is no point in writing that to ics now that we always assume Other interrupts are caused by lsc. Reviewed-by: Jasna Hodzic <jhod...@ucdavis.edu> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/et

Re: [PATCH v2 2/4] e1000e: Do not read icr in Other interrupt

On 2015/10/30 12:19, Alexander Duyck wrote: > On 10/30/2015 10:31 AM, Benjamin Poirier wrote: > >Using eiac instead of reading icr allows us to avoid interference with > >rx and tx interrupts in the Other interrupt handler. > > > >According to the 82574 datasheet section

[PATCH v2 4/4] e1000e: Fix msi-x interrupt automask

ted-by: Frank Steiner <steiner-...@bio.ifi.lmu.de> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethern

[PATCH v2 3/4] e1000e: Do not write lsc to ics in msi-x mode

In msi-x mode, there is no handler for the lsc interrupt so there is no point in writing that to ics now that we always assume Other interrupts are caused by lsc. Reviewed-by: Jasna Hodzic <jhod...@ucdavis.edu> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/et

[PATCH v2 1/4] e1000e: Remove unreachable code

msi-x interrupts are not shared so there's no need to check if the interrupt was really from this adapter. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/intel/

[PATCH v2 0/4] e1000e msi-x fixes

Hi, For this series: Benjamin Poirier (4): e1000e: Remove unreachable code e1000e: Do not read icr in Other interrupt e1000e: Do not write lsc to ics in msi-x mode e1000e: Fix msi-x interrupt automask drivers/net/ethernet/intel/e1000e/defines.h | 3 +- drivers/net/ethernet/intel

[PATCH v2 2/4] e1000e: Do not read icr in Other interrupt

enough that the extra cost of needlessly re-reading the link status is negligible. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On 2016/06/13 11:46, Netanel Belgazal wrote: [...] > + > +static int ena_set_coalesce(struct net_device *net_dev, > + struct ethtool_coalesce *coalesce) > +{ > + struct ena_adapter *adapter = netdev_priv(net_dev); > + struct ena_com_dev *ena_dev = adapter->ena_dev;

[PATCH] mld, igmp: Fix reserved tailroom calculation

ss records, the current code may output skbs that have less tailroom than dev->needed_tailroom or it may output more skbs than needed because not all space available is used. Fixes: 4c672e4b ("ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs") Signed-off-by:

Re: [PATCH] mld, igmp: Fix reserved tailroom calculation

On 2016/02/29 15:57, Daniel Borkmann wrote: [...] > > [ cutting the IPv4 part off as diff is the same ] > > >diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c > >index 5ee56d0..c157edc 100644 > >--- a/net/ipv6/mcast.c > >+++ b/net/ipv6/mcast.c > >@@ -1574,9 +1574,9 @@ static struct sk_buff

Re: [PATCH] mld, igmp: Fix reserved tailroom calculation

On 2016/02/29 16:43, Hannes Frederic Sowa wrote: > On 29.02.2016 16:19, Benjamin Poirier wrote: > >On 2016/02/29 15:57, Daniel Borkmann wrote: > >[...] > >> > >>[ cutting the IPv4 part off as diff is the same ] > >> > >>>diff --git a/net/ipv6/

[PATCH net v2] mld, igmp: Fix reserved tailroom calculation

n needed because not all space available is used. Fixes: 4c672e4b ("ipv6: mld: fix add_grhead skb_over_panic for devs with large MTUs") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- Notes: Changes v1->v2 As suggested by Hannes, move the code to an inline helper a

[PATCH] ipv6: Annotate change of locking mechanism for np->opt

follows up commit 45f6fad84cc3 ("ipv6: add complete rcu protection around np->opt") which added mixed rcu/refcount protection to np->opt. Given the current implementation of rcu_pointer_handoff(), this has no effect at runtime. Signed-off-by: Benjamin Poirier <bpoir...@suse.co

Re: [PATCH] net: add missing descriptions in net_device_priv_flags

On 2016/03/21 20:20, Luis de Bethencourt wrote: > The flags IFF_XMIT_DST_RELEASE_PERM, IFF_IPVLAN_MASTER and > IFF_IPVLAN_SLAVE are missing descriptions for the Documentation. Adding > them. > > Signed-off-by: Luis de Bethencourt > --- > Hi, > > I also noticed this issue

[PATCH 1/2] net: Fix indentation of the conf/ documentation block

Commit d67ef35fff67 ("clarify documentation for net.ipv4.igmp_max_memberships") mistakenly indented a block of documentation such that it now looks like it belongs to a specific sysctl. Restore that block's original position. Cc: Jeremy Eder <je...@redhat.com> Signed-off-by:

[PATCH 2/2] igmp: Document sysctl_igmp_max_msf

Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- Documentation/networking/ip-sysctl.txt | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index d3768e8..b183e2b

[PATCH] ip.7: Fix incorrect sockopt name

ek Pazdera <rpazd...@redhat.com> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- man7/ip.7 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man7/ip.7 b/man7/ip.7 index 3905573..37e2c86 100644 --- a/man7/ip.7 +++ b/man7/ip.7 @@ -376,7 +376,7 @@ a given multicas

[PATCH] net: Add missing kernel-doc for netdev ptype lists

Noureddine <nouredd...@arista.com> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- include/linux/netdevice.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 9a3d55c..1937bdd 100644 --- a/include/linux/netdevice

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On 2016/07/14 08:22, Matt Wilson wrote: [...] > > Dave and Benjamin, > > Do you want to see the interrupt moderation extensions to ethtool and > the sysfs nodes removed before this lands in net-next? Or should > Netanel remove the sysfs bits until we can extend the ethtool > interfaces to cover

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On 2016/07/15 08:00, Leon Romanovsky wrote: > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > > This is a driver for the ENA family of networking devices. > > > > Signed-off-by: Netanel Belgazal > > --- > > > > Notes: > > ... > > > - Increase

Re: Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

On 2016/07/12 11:08, Benjamin Poirier wrote: > On 2016/07/06 17:29, Ursula Braun wrote: > > Dave, > > > > we still like to see SMC-R included into a future Linux-kernel. After > > answering your first 2 questions, there is no longer a response. What should >

Re: Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

On 2016/07/06 17:29, Ursula Braun wrote: > Dave, > > we still like to see SMC-R included into a future Linux-kernel. After > answering your first 2 questions, there is no longer a response. What should > we do next? > - Still wait for an answer from you? > - Resend the same whole SMC-R patch

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

On 2016/08/08 09:26, Andreas Werner wrote: [...] > > > + > > > + if (cf->can_dlc > 0) > > > + data[0] = be32_to_cpup((__be32 *)(cf->data)); > > > + if (cf->can_dlc > 3) > > > + data[1] = be32_to_cpup((__be32 *)(cf->data + 4)); > > > + > > > + writel(id, _buf->can_id); > > > +

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

On 2016/07/26 11:16, Andreas Werner wrote: [...] > + > + /* Lock for CTL_BTR register access. > + * This register combines bittiming bits > + * and the operation mode bits. > + * It is also used for bit r/m/w access > + * to all registers. > + */ > + spinlock_t

[PATCH net v2] mlx4: Invoke softirqs after napi_reschedule

edule") and this patch applies the same fix to mlx4. Fixes: 07841f9d94c1 ("net/mlx4_en: Schedule napi when RX buffers allocation fails") Cc: Eric Dumazet <eric.duma...@gmail.com> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/mellanox/mlx4/e

[PATCH net] mlx4: Invoke softirqs after napi_reschedule

edule") and this patch applies the same fix to mlx4. Cc: Eric Dumazet <eric.duma...@gmail.com> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/m

[PATCH] vmxnet3: Wake queue from reset work

ork+0x6a/0xa0 [vmxnet3] [] process_one_work+0x16c/0x350 [] worker_thread+0x17a/0x410 [] kthread+0x96/0xa0 [] kernel_thread_helper+0x4/0x10 Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH] bna: Add synchronization for tx ring.

-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/brocade/bna/bnad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index f9df4b5a..f42f672 100644 --- a/drivers/net/ethernet/b

[PATCH] i40e: Invoke softirqs after napi_reschedule

nvoke softirqs after __napi_schedule") and this patch applies the same fix to i40e. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/driv

Re: [PATCH] i40e: Invoke softirqs after napi_reschedule

On 2017/01/12 17:15, Eric Dumazet wrote: > On Thu, 2017-01-12 at 17:04 -0800, Benjamin Poirier wrote: > > The following message is logged from time to time when using i40e: > > NOHZ: local_softirq_pending 08 > > > > i40e may schedule napi from a workqueue. After

[PATCH] scsi: bfa: Increase requested firmware version to 3.2.5.1

3.2.25.0 Increase bfa's requested firmware version. I only tested that all of the devices probe without error. Cc: Rasesh Mody <rasesh.m...@qlogic.com> Reported-by: Tim Ehlers <tehl...@gwdg.de> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/scsi/bfa/bfad.c | 6

[PATCH v2] scsi: bfa: Increase requested firmware version to 3.2.5.1

Increase bfa's requested firmware version. Also increase the driver version. I only tested that all of the devices probe without error. Reported-by: Tim Ehlers <tehl...@gwdg.de> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> Acked-by: Rasesh Mody <rasesh.m...@cavium.co

[PATCH 2/2] igb: Remove useless argument

Given that all callers of igb_update_stats() pass the same two arguments: (adapter, >stats64), the second argument can be removed. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/igb/igb.h | 2 +- drivers/net/ethernet/intel/igb/igb_ethto

[PATCH 1/2] e1000e: Don't return uninitialized stats

<s.pri...@profihost.ag> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index

Re: commit 16ecba59 breaks 82574L under heavy load.

On 2017/07/18 10:21, Lennart Sorensen wrote: > Commit 16ecba59bc333d6282ee057fb02339f77a880beb has apparently broken > at least the 82574L under heavy load (as in load heavy enough to cause > packet drops). In this case, when running in MSI-X mode, the Other > Causes interrupt fires about 3000

Re: commit 16ecba59 breaks 82574L under heavy load.

On 2017/07/20 10:00, Lennart Sorensen wrote: > On Wed, Jul 19, 2017 at 05:07:47PM -0700, Benjamin Poirier wrote: > > Are you sure about this? In my testing, while triggering the overrun > > with the msleep, I read ICR when entering e1000_msix_other() and RXO is > > consist

[PATCH 4/5] e1000e: Separate signaling for link check/link up

link status needs checking and link status is down. Avoid the problem by using the return value of .check_for_link to signal the link status to e1000e_has_link(). Reported-by: Lennart Sorensen <lsore...@csclub.uwaterloo.ca> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- dr

[PATCH 1/5] e1000e: Fix error path in link detection

In case of error from e1e_rphy(), the loop will exit early and "success" will be set to true erroneously. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/phy.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --g

[PATCH 3/5] e1000e: Fix return value test

All the helpers return -E1000_ERR_PHY. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/ne

[PATCH 2/5] e1000e: Fix wrong comment related to link detection

Reading e1000e_check_for_copper_link() shows that get_link_status is set to false after link has been detected. Therefore, it stays TRUE until then. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

lub.uwaterloo.ca> Fixes: 16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/defines.h | 1 + drivers/net/ethernet/intel/e1000e/netdev.c | 33 +++-- 2 fi

Re: commit 16ecba59 breaks 82574L under heavy load.

On 2017/07/19 10:19, Lennart Sorensen wrote: > On Tue, Jul 18, 2017 at 04:14:35PM -0700, Benjamin Poirier wrote: > > Thanks for the detailed analysis. > > > > Refering to the original discussion around this patch series, it seemed like > > the IMS bit for a condition

Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats

On 2017/04/25 02:07, Jeff Kirsher wrote: [...] > > > > > > I don't see any memset in e1000e_get_stats64(). What kernel version > > > are > > > you looking at? > > > > The call to memset was removed from the upstream kernel with: > >

Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats

On 2017/04/25 10:54, Stephen Hemminger wrote: [...] > > > The call to memset was removed from the upstream kernel with: > > > --- > > > - > > > commit 5944701df90d9577658e2354cc27c4ceaeca30fe > > > Author: stephen

Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats

On 2017/04/24 10:23, Paul Menzel wrote: > Dear Benjamin, > > > Thank you for your fix. > > On 04/21/17 23:20, Benjamin Poirier wrote: > > Some statistics passed to ethtool are garbage because e1000e_get_stats64() > > doesn't write them, for example: tx_heart

Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats

Sasha, please use reply-all to keep everyone in cc (including me...). On 2017/04/24 11:17, Neftin, Sasha wrote: > On 4/23/2017 15:53, Neftin, Sasha wrote: > > -Original Message- > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > > Behal

Re: [Intel-wired-lan] [PATCH 4/5] e1000e: Separate signaling for link check/link up

On 2017/08/02 10:34, Lennart Sorensen wrote: > On Wed, Aug 02, 2017 at 02:28:07PM +0300, Neftin, Sasha wrote: > > On 7/21/2017 21:36, Benjamin Poirier wrote: > > > Lennart reported the following race condition: > > > > > > \ e1000_watchdog_task > > &g

[PATCH v2] e1000e: Don't return uninitialized stats

t;net: remove useless memset's in drivers get_stats64") Reported-by: Stefan Priebe <s.pri...@profihost.ag> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- Notes: Changes v1->v2: * add the Fixes tag drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +- 1 file c

Re: SSE instructions for fast packet copy?

On 2017/05/04 22:50, Tom Herbert wrote: > Hi, > > I am thinking about the possibility of using SSE in kernel for > speeding up the kernel memcpy particularly for copy to userspace > emeory, and maybe even using the string instructions (like if we > supported regex in something like eBPF). AFAIK

Re: [5/5] e1000e: Avoid receiver overrun interrupt bursts

On 2017/09/19 12:38, Philip Prindeville wrote: > Hi. > > We’ve been running this patchset (all 5) for about as long as they’ve been > under review… about 2 months. And in a burn-in lab with heavy traffic. > > We’ve not seen a single link-flap in hundreds of ours of saturated traffic. > >

[PATCH] packet: Don't write vnet header beyond end of buffer

... which may happen with certain values of tp_reserve and maclen. Fixes: 58d19b19cd99 ("packet: vnet_hdr support for tpacket_rcv") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> Cc: Willem de Bruijn <will...@google.com> --- net/packet/af_packet.c | 12 +

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

On 2017/07/21 11:36, Benjamin Poirier wrote: > When e1000e_poll() is not fast enough to keep up with incoming traffic, the > adapter (when operating in msix mode) raises the Other interrupt to signal > Receiver Overrun. > > This is a double problem because 1) at the moment e

[PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value.

47 Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link up") Tested-by: Christian Hesse <l...@eworm.de> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 --- 1 file changed, 8 insertions(+), 3 del

[PATCH] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

ef35 ("e1000e: fix systim issues") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/e

Re: [PATCH for-4.14.y 0/5] e1000e: Upstream fixes for linux-4.14.y

On 2017/12/19 15:27, Jeff Kirsher wrote: > On Tue, 2017-12-19 at 10:10 +0900, Benjamin Poirier wrote: > > On 2017/12/18 12:59, Greg KH wrote: > > > On Mon, Dec 11, 2017 at 10:58:10PM +0100, Christian Hesse wrote: > > > > Greg KH <gre...@linuxfoundat

Re: [PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value.

On 2018/01/10 01:29, rwar...@gmx.de wrote: > hallo > > any chance to get this patch into stable and 4.15 ? > > https://marc.info/?l=linux-kernel=151297726823919=2 > It was part of the last network pull request and should be included in the next mainline release as 4110e02eb45e e1000e: Fix

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/19 17:59, Benjamin Poirier wrote: > On 2018/01/18 07:51, Alexander Duyck wrote: > > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier <bpoir...@suse.com> > > wrote: > > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > &

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/19 08:22, Alexander Duyck wrote: > On Fri, Jan 19, 2018 at 5:36 AM, Benjamin Poirier > <benjamin.poir...@gmail.com> wrote: > > On 2018/01/19 17:59, Benjamin Poirier wrote: > >> On 2018/01/18 07:51, Alexander Duyck wrote: > >> > On Wed, Jan 17, 20

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/20 07:45, Benjamin Poirier wrote: [...] > > > > I'm of the mind that we need to cut down on the code thrash. This > > driver is supposed to have been in a "maintenance" mode for the last > > year or so as there aren't being any new parts added is m

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/18 07:51, Alexander Duyck wrote: > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier <bpoir...@suse.com> wrote: > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid rece

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/20 09:21, Alexander Duyck wrote: > On Fri, Jan 19, 2018 at 2:55 PM, Benjamin Poirier > <benjamin.poir...@gmail.com> wrote: > > On 2018/01/20 07:45, Benjamin Poirier wrote: > > [...] > >> > > >> > I'm of the mind that we need to

[PATCH 0/3] e1000e: Revert interrupt handling changes

000e: Fix msi-x interrupt automask", v4.5-rc1) are preserved. * we manually clear Other from icr in e1000_msix_other(). We try to go back to a long lost time when things were simple and drivers ran smoothly. -------- Benjamin Poirier (3):

[PATCH 2/3] Revert "e1000e: Separate signaling for link check/link up"

restored reading icr in the Other handler. As discussed, the driver should be in "maintenance mode". In the interest of stability, revert to the original code as much as possible instead of a half-baked solution. Link: https://www.spinics.net/lists/netdev/msg479923.html Signed-off-by: Benja

[PATCH 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

n "maintenance" mode and we want to avoid unforeseen fallout from changes that are not strictly necessary. Link: https://www.spinics.net/lists/netdev/msg480675.html Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/defines.h | 1 - drivers/net/

[PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

Other interrupt"). Fixes: 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net

Re: [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/18 15:50, Benjamin Poirier wrote: > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > overrun interrupt bursts", v4.15-rc1). Some tracing shows that after > e1000e_t

Re: [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/18 15:50, Benjamin Poirier wrote: > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > overrun interrupt bursts", v4.15-rc1). Some tracing shows that after > e1000e_t

[RFC PATCH] e1000e: Remove Other from EIAC.

quot;e1000e: Do not read ICR in Other interrupt", v4.5-rc1). Fixes: 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- Jeff, I'm sending as RFC since it looks like a problem that should be fixed in vmware.

[PATCH net] e1000e: Remove Other from EIAC.

quot;e1000e: Do not read ICR in Other interrupt", v4.5-rc1). Fixes: 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 5 +++-- 1 file changed, 3 insertions(+),

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/30 11:46, Alexander Duyck wrote: > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier <bpoir...@suse.com> wrote: > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid rece

Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

On 2018/01/26 13:01, Alexander Duyck wrote: > On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier <bpoir...@suse.com> wrote: > > This reverts commit 16ecba59bc333d6282ee057fb02339f77a880beb. > > > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build

Re: [PATCH 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

On 2018/01/26 08:50, Alexander Duyck wrote: > On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier <bpoir...@suse.com> wrote: > > This reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d. > > > > We keep the fix for the first part of the problem (1) described in the log

Re: [PATCH 2/3] Revert "e1000e: Separate signaling for link check/link up"

On 2018/01/26 09:03, Alexander Duyck wrote: > On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier <bpoir...@suse.com> wrote: > > This reverts commit 19110cfbb34d4af0cdfe14cd243f3b09dc95b013. > > This reverts commit 4110e02eb45ea447ec6f5459c9934de0a273fb91. > > > > .

[PATCH net-queue 3/3] e1000e: Avoid missed interrupts following ICR read.

, therefore we no longer need to clear bits explicitly. Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/defines.h | 21 - drivers/net/ethernet/intel/e1000e/netdev.c | 11 --- 2 files changed, 24 insertions(+), 8 deletions(-) diff

[PATCH net-queue 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

ce mode". Link: https://www.spinics.net/lists/netdev/msg480675.html Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev

[PATCH net-queue 2/3] e1000e: Fix queue interrupt re-raising in Other interrupt.

the queue interrupts in case the txq or rxq bits were set in ICR and the Other interrupt handler read and cleared ICR before the queue interrupt was raised. Fixes: 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --

Re: [PATCH net-queue 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

of manually clearing OTHER via a write to icr as in v1, in v2 we make sure that INT_ASSERTED is always set via bits for all events related to the Other interrupt in IMS. Benjamin Poirier (3): Partial revert "e1000e: Avoid receiver overrun interrupt bursts" e1000e: Fix queue interrupt

Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

On 2018/01/29 09:22, Alexander Duyck wrote: [...] > > > Consequently, we must clear OTHER manually from ICR, otherwise the > > interrupt is immediately re-raised after exiting the handler. > > > > These observations are the same whether the interrupt is triggered via a > > write to ICS or in

[PATCH net-queue] e1000e: Fix check_for_link return value with autoneg off.

1000e: Separate signaling for link check/link up") Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 +- drivers/net/ethernet/intel/e1000e/mac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[RFC PATCH] e1000e: Fix link check race condition.

g checked the link. It seems this problem has been present since the introduction of e1000e. Link: https://lkml.org/lkml/2018/1/29/338 Reported-by: Alexander Duyck <alexander.du...@gmail.com> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/22 10:01, Alexander Duyck wrote: [...] > > > > If the patch that I submitted for the current vmware issue is merged, > > the significant commits that are left are: > > > > 0a8047ac68e5 e1000e: Fix msi-x interrupt automask (v4.5-rc1) > > Fixes a problem in the irq disabling of

Re: [RFC PATCH] e1000e: Remove Other from EIAC.

On 2018/01/18 18:42, Shrikrishna Khare wrote: > > > On Thu, 18 Jan 2018, Benjamin Poirier wrote: > > > On 2018/01/18 15:50, Benjamin Poirier wrote: > > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > > 7526125 do not link up after

Re: [PATCH] e1000e: Fix link status in case of error.

On 2018/02/28 08:48, Alexander Duyck wrote: > On Tue, Feb 27, 2018 at 9:20 PM, Benjamin Poirier <bpoir...@suse.com> wrote: > > Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link > > up"), errors which happen after "get_link_status = fal

e1000e I219 timestamping oops related to TSYNCRXCTL read

In the following openSUSE bug report https://bugzilla.suse.com/show_bug.cgi?id=1075876 Achim reported an oops related to e1000e timestamping: kernel: RIP: 0010:[] timecounter_read+0xf/0x50 [...] kernel: Call Trace: kernel: [] e1000e_phc_gettime+0x2f/0x60 [e1000e] kernel: []

Re: [RFC PATCH] e1000e: Fix link check race condition.

On 2018/02/26 08:14, Alexander Duyck wrote: [...] > > > > > switch (hw->mac.type) { > > case e1000_pch2lan: > > ret_val = e1000_k1_workaround_lv(hw); > > if (ret_val) > > - return ret_val; > > + goto out;

[PATCH] e1000e: Fix link status in case of error.

k is down. Since all combinations of link up/down and error/no error are possible, do the same thing as e1000e_phy_has_link_generic() and return the link status in a separate variable. Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link up") Signed-off-by: Benjamin Poirier <bp

[PATCH 2/2] e1000e: Fix link check race condition

g checked the link. It seems this problem has been present since the introduction of e1000e. Link: https://lkml.org/lkml/2018/1/29/338 Reported-by: Alexander Duyck <alexander.du...@gmail.com> Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- drivers/net/ethernet/intel/

[PATCH 1/2] Revert "e1000e: Separate signaling for link check/link up"

cussed. The race may no longer be triggered by RXO events because commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") restored reading icr in the Other handler. Link: https://lkml.org/lkml/2018/3/1/789 Signed-off-by: Benjamin Poirier <bpoir...@suse.com> --- dr

[PATCH] xfrm: Fix bucket count reported to userspace

sadhcnt is reported by `ip -s xfrm state count` as "buckets count", not the hash mask. Fixes: 28d8909bc790 ("[XFRM]: Export SAD info.") Signed-off-by: Benjamin Poirier --- net/xfrm/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfr

  1   2   >