Correct the function name in the comments supplied with register_netdev()
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc7/net/core/dev.c
===
--- 21-rc7.orig/net/core/dev.c
+++ 21-rc7/net/core/dev.c
@@ -3002,7 +3002,7
Handle return codes of register_netdev().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc7/drivers/net/tokenring/olympic.c
===
--- 21-rc7.orig/drivers/net/tokenring/olympic.c
+++ 21-rc7/drivers/net/tokenring/olympic.c
On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote:
The problem comes from the new macro UDPX_INC_STATS_BH introduced
by Herbert, which was a nice addition to increment the correct
UDP MIB depending on the socket family, but unfortunately
the use of this macro from kernel code (I
On Thu, Jul 30, 2015 at 03:04:01PM +0530, Viresh Kumar wrote:
Its return value is not used by the subsys core and nothing meaningful
can be done with it, even if we want to use it. The subsys device is
anyway getting removed.
I'm assuming sysfs paths covered by it, will remain intact... ? For
Hi people,
I'm seeing this while doing randconfig builds on rc1 + tip:
net/built-in.o: In function `__ovs_ct_lookup':
conntrack.c:(.text+0x3d8075): undefined reference to
`nf_nat_icmp_reply_translation'
make: *** [vmlinux] Error 1
.config attached.
--
Regards/Gruss,
Boris.
ECO tip #101:
On Fri, Apr 15, 2016 at 04:16:02AM +, Grumbach, Emmanuel wrote:
> [1] https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/backport-iwlwi
> fi.git/
It is very strange to pull from this repo, git fetch is doing something
for a while now without any forward progress.
In any case, 4.5 is bad
Hi,
so I'm seeing this when wlan0 tries to associate. On 4.6-rc2 + tip.
After that, wifi is dead in the water. Anyone have a clue?
And 4.5 seems fine, I'm typing from it as we speak.
...
[2.111418] iwlwifi :02:00.0: loaded firmware version 21.302800.0
op_mode iwlmvm
...
[2.220954]
From: Borislav Petkov <b...@suse.de>
Fix:
drivers/net/ethernet/amd/xgbe/xgbe-main.c:835:12: warning: ‘xgbe_suspend’
defined
but not used [-Wunused-function]
drivers/net/ethernet/amd/xgbe/xgbe-main.c:855:12: warning: ‘xgbe_resume’
defined
but not used [-Wunused-function]
Hmm, there's cleanup_net() namespaces fun in there, adding netdev@.
On Sat, Nov 12, 2016 at 02:17:03PM -0800, Ashton Holmes wrote:
> I upgraded to 4.8.7 and the system boots and my root partition gets
> decrypted but right after that both of my monitors turn off and
> looking at syslog from 4.8.6
On Tue, Nov 29, 2016 at 11:22:32AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the net-next tree got a conflict in:
>
> drivers/net/ethernet/amd/xgbe/xgbe-main.c
>
> between commit:
>
> 91eefaabf102 ("amd-xgbe: Fix unused suspend handlers build warning")
>
>
nd as such it's part of the UAPI. I don't think you can
> > remove it unless you can guarantee there are no userspace users.
> I keep it in the v2 of the series, but the maintainer, Borislav Petkov, asks
> me
> to un-export it.
>
> I will follow the maintainer decision.
I'm no
On Fri, Jan 06, 2017 at 10:43:56AM +0100, Nicolas Dichtel wrote:
> This header file is exported, thus move it to uapi.
It should rather not be exported - please remove it from
arch/x86/include/uapi/asm/Kbuild instead.
Thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid
On Thu, Mar 09, 2017 at 10:55:47PM +0100, Borislav Petkov wrote:
> Can you make that:
>
> setup_clear_cpu_cap(X86_FEATURE_PGE);
>
> and see if it fixes your issue?
Hmm, in reading the thread a bit more, that might not work. If I see it
correctly, lguest does
clear_cp
On Thu, Mar 09, 2017 at 10:32:12PM +0100, Daniel Borkmann wrote:
> get_online_cpus();
> if (boot_cpu_has(X86_FEATURE_PGE)) { /* We have a broader idea of
> "global". */
> /* Remember that this was originally set (for cleanup). */
> cpu_had_pge = 1;
>
On Thu, Mar 09, 2017 at 11:11:17PM +0100, Daniel Borkmann wrote:
> Yeah, I just tried that out and it had no effect unfortunately, the
> static_cpu_has() was still 1.
Right, just as I thought.
I guess we could return to doing boot_cpu_has() in __flush_tlb_all()
then. I mean, the
On Thu, Mar 09, 2017 at 03:26:02PM -0800, Linus Torvalds wrote:
> So should all of commit ("c109bf95992b x86/cpufeature: Remove
> cpu_has_pge") just be reverted (and then marked for stable)?
>
> Or do we have some alternate plan?
I think we want to do this:
diff --git
On Thu, Mar 09, 2017 at 03:26:02PM -0800, Linus Torvalds wrote:
> Maybe it's the lguest games with PGE that need to be removed?
Btw, tglx suggested something else the other day: warn when we're
changing boot_cpu_data x86_capability bits *after* alternatives have
run. The reasoning behind it being
Hi,
when I run a small CPU hotplugging script while I'm logged into the
machine over ssh, I see the dev watchdog timeout below. Driver is
e1000e.
After the eth0 reset, I ifdown/ifup the eth0 interface and it comes back
up again just fine.
Any ideas?
Kernel is -rc5 + tip/master.
...
[
On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
>
On Tue, Dec 19, 2017 at 10:51:14AM -0800, Joe Perches wrote:
> > The reason for the code churn being?
>
> Consistency for easier grep by use-type.
Please explain that in the commit message so that we know why it was
changed.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid
On Thu, May 03, 2018 at 08:31:19PM -0700, Yonghong Song wrote:
> Commit d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS")
> removed X86_FAST_FEATURE_TESTS and make macro static_cpu_has() always
> use __always_inline function _static_cpu_has() funciton.
> The static_cpu_has() uses gcc feature asm
On Thu, May 10, 2018 at 08:52:42AM -0700, Alexei Starovoitov wrote:
> That makes me wonder what happened with "we do not break user space" rule?
As someone already pointed out on IRC, arch/x86/include/asm/cpufeature.h
is solely a kernel header so nothing but kernel should include it. So
forget
On Thu, May 10, 2018 at 10:58:35AM -0700, Alexei Starovoitov wrote:
> libbcc is a library. It's not only used by bcc scripts, but by production
> services that compile bpf programs with clang.
Let me get this straight: libbcc fails to compile because it
includes (through some long include chain)
Hi,
this didn't happen before but after 4.16-rc1 my tg3 nic stops for
whatever reason and the connection to the machine is dead. It didn't show
anything in dmesg until today.
The IO pagefaults look like it is trying to access something it
shouldn't and maybe that's why it times out.
It triggers
On Tue, Mar 20, 2018 at 11:41:06AM +0530, Satish Baddipadige wrote:
> Can you please test the attached patch?
Well, the network connection just died with it. It didn't fire the
netdev watchdog but I still had to down and up eth0 in order to continue
using it. ssh connection into the box survived
On Tue, Mar 20, 2018 at 11:41:06AM +0530, Satish Baddipadige wrote:
> Can you please test the attached patch?
Sure, will do when I get back next week.
Thx.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply. Srsly.
26 matches
Mail list logo
