Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-27 Thread Chocron, Jonathan
This is a fixed version of my previous response (using proper indentation and leaving only the specific questions responded to). > > +/* MDIO */ > > +#define AL_ETH_MDIO_C45_DEV_MASK 0x1f > > +#define AL_ETH_MDIO_C45_DEV_SHIFT16 > > +#define AL_ETH_MDIO_C45_REG_MASK 0x > > + >

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-07 Thread Chocron, Jonathan
From: Andrew Lunn Sent: Friday, February 3, 2017 22:58 To: Antoine Tenart Cc: netdev@vger.kernel.org; da...@davemloft.net; linux-arm-ker...@lists.infradead.org; tsa...@annapurnalabs.com; rshit...@annapurnalabs.com; sa...@annapurnalabs.com; ba...@annapurn

RE: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-11-02 Thread Chocron, Jonathan
-Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, August 28, 2017 9:10 PM > To: Chocron, Jonathan > Cc: Antoine Tenart ; > netdev@vger.kernel.org; da...@davemloft.net; linux-arm- > ker...@lists.infradead.org; thomas.petazz...@free-