Adding Guy Damary
Guy, can you help with this one? I believe there is a bugzilla issue
for this already...
--
Cheers,
Luca.
On Thu, 2020-11-19 at 17:42 +0100, Gonsolo wrote:
> Hi!
>
> Sporadically my wifi hangs. Any idea why?
> This is on a 5.10.0-051000rc2-lowlatency kernel from
> https://ker
On Tue, 2021-01-12 at 17:02 +0100, Takashi Iwai wrote:
> On Tue, 12 Jan 2021 16:48:56 +0100,
> Kalle Valo wrote:
> >
> > Takashi Iwai writes:
> >
> > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device
> > > memory") added a termination of name string just to be sure, and this
>
On Tue, 2021-01-12 at 17:05 +0100, Takashi Iwai wrote:
> On Tue, 12 Jan 2021 16:50:54 +0100,
> Kalle Valo wrote:
> >
> > Takashi Iwai writes:
> >
> > > The ucode TLV data may be read-only and should be treated as const
> > > pointers, but currently a few code forcibly cast to the writable
> > >
On Tue, 2021-01-26 at 21:55 +0100, Johannes Berg wrote:
> On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote:
> > On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote:
> > > From: Eric Dumazet
> > >
> > > net/core/tso.c got recent support for USO, and this broke iwlfifi
> > > because the dr
On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote:
> Pierre-Louis Bossart writes:
>
> > An unsigned long variable should rely on '%lu' format strings, not '%zd'
> >
> > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
> > Signed-off-by: Pierre-Louis Bossart
> > ---
> >
On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote:
> Nathan Chancellor writes:
>
> > On Tue, Feb 23, 2021 at 02:00:39PM +, Wei Yongjun wrote:
> > > Make sure dmi_system_id tables are NULL terminated.
> > >
> > > Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG
> >
On Tue, 2021-03-02 at 11:20 -0700, Jens Axboe wrote:
> My laptop crashes at boot, and I ran the same kernel with KASAN enabled.
> Turns out the DMI addition for iwlwifi is broken (and untested?), since
> it doesn't properly terminate the scan table. Ensure that we do so.
>
> ==
On Tue, 2021-03-02 at 13:42 -0800, Jakub Kicinski wrote:
> On Tue, 02 Mar 2021 21:50:18 +0200 Kalle Valo wrote:
> > > if Wei doesn't respond could you please step in to make sure this
> > > fix is part of Dave's next PR to Linus?
> >
> > Will do. Related to this, what's your pull request schedul
On Thu, 2021-03-04 at 10:22 +, 'Wei Yongjun wrote:
> From: Wei Yongjun
>
> GCC reports warning as follows:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
> 'static' is not at beginning of declaration [-Wold-style-declaration]
> 14 | const static struct iwl_rfi_lut_entry
On Mon, 2021-03-22 at 22:51 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The correct order is 'static const', not 'const static', as seen from
> make W=1:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at
> beginning of declaration [-Werror=old-style-decl
On Fri, 2020-11-27 at 10:07 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix
> ---
Thank you. I applied this now to our internal tree and this will reach
the mainline following our usual process.
--
Cheers,
Luca.
On Thu, 2020-12-24 at 21:25 +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun
> ---
Thanks! I have now applied this internally and it will reach the
mainline following our
On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote:
> Fixes three trivial issues as reported by checkpatch.pl, namely two
switch/case indentation issues and one alignment issue in a multiline
comment.
Signed-off-by: Christoph Böhmwalder
---
Why are you already resending this? You sent
On Sun, 2020-09-27 at 21:49 +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior
>
> The usage of in_interrupt) in driver code is phased out.
>
> The iwlwifi_dbg tracepoint records in_interrupt() seperately, but that's
> superfluous because the trace header already records all kind of
On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote:
> These messages are not reporting a real error, just the fact that the
> firmware knows about more flags then the driver.
>
> Currently these messages are presented to the user during boot if there
> is no bootsplash covering the con
On Wed, 2017-09-06 at 16:27 -0700, Linus Torvalds wrote:
> This pull request completely breaks Intel wireless for me.
>
> This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a).
>
> That remains a very standard Intel machine with absolutely zero odd
> things going on.
>
> The fi
On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote:
> On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano
> wrote:
> >
> > This seems to be a problem with backwards-compatibility with FW version
> > 27. We are now in version 31[1] and upgrading will probably fix that.
On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote:
> "Luis R. Rodriguez" writes:
>
> > > +int request_firmware_nowait(struct module *module, bool uevent,
> > > + const char *name, struct device *device, gfp_t gfp,
> > > + void *context,
> > > +
On Thu, 2017-08-03 at 07:47 -0700, João Paulo Rechi Vita wrote:
> These messages are not reporting a real error, just the fact that the
> firmware knows about more flags than the driver.
>
> Currently these messages are presented to the user during boot if there
> is no bootsplash covering the con
Hi Kalle,
On Mon, 2016-05-16 at 16:10 +0300, Kalle Valo wrote:
> (Adding Luca and linux-wireless)
>
> Stephen Rothwell writes:
>
> >
> > Today's linux-next merge of the wireless-drivers-next tree got a
> > conflict in:
> >
> > drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> >
> > between com
On Mon, 2016-05-16 at 17:08 +0300, Kalle Valo wrote:
> Kalle Valo writes:
>
> >
> > Kalle Valo writes:
> >
> > >
> > > The following changes since commit
> > > ede00a5ceb4d903a8c137a52bb77d574baaef8bd:
> > >
> > > Merge tag 'wireless-drivers-next-for-davem-2016-05-02' of
> > > git://git.ke
Hi Emmanuel, Linus,
On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote:
> On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds
> wrote:
> >
> > On Tue, May 17, 2016 at 12:11 PM, David Miller > > wrote:
> > >
> > >
> > > Highlights:
> > Lowlights:
> >
> > 1) the iwlwifi driver seems to b
On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote:
> On Wed, May 18, 2016 at 4:51 AM, Coelho, Luciano
> wrote:
> >
> > Hi Emmanuel, Linus,
> >
> >
> > On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote:
> > >
> > > On Wed
On Wed, 2016-05-18 at 06:51 -0600, Reinoud Koornstra wrote:
> On Wed, May 18, 2016 at 6:41 AM, Coelho, Luciano
> wrote:
> >
> > On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote:
> > >
> > > On Wed, May 18, 2016 at 4:51 AM, Coelho, Luciano
> &
On Wed, 2016-05-18 at 11:45 -0700, Linus Torvalds wrote:
> On Wed, May 18, 2016 at 7:23 AM, Coelho, Luciano
> wrote:
> >
> >
> > I can confirm that 4.6 contains the same bug. And reverting the
> > patch
> > I mentioned does solve the problem...
>
On Wed, 2016-05-18 at 12:00 -0700, Linus Torvalds wrote:
> On Wed, May 18, 2016 at 11:58 AM, Kalle Valo
> wrote:
> >
> >
> > It would be best if you could send a patch either directly to Dave
> > or
> > Linus to resolve this quickly.
> I'm committing my patch myself right now, since this bug mak
On Wed, 2016-05-18 at 01:31 +0200, Heinrich Schuchardt wrote:
> If we dereference a variable anyway in other parts of the code,
> there is no need to check against NULL in a single place.
NACK. This is not true.
If lq_sta is NULL, it means that mvm_sta is also NULL. Then we call
the rate_contro
On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote:
> gcc is apparently unablel to track the state of the local 'resp_v2'
> variable across the kzalloc() function, and warns about the response
> variable being used without an initialization:
>
> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c: In
On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote:
> Linus Torvalds writes:
>
> > So my Dell XPS 13 seems to have grown a new warning as of the
> > networking merge yesterday.
> >
> > Things still work, but when it starts warning, it generates a *lot* of
> > noise (I got 36 of these within abo
On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote:
> Didn't get any feedback or review comments on this patch. Resending
> ...
>
> P.
Sorry, this got flooded down my inbox.
> ---8<---
>
> The iwlwifi driver implements a thermal zone and hwmon device, but
> returns -EIO on temperature r
On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote:
> This fixes incorrect fallthrough in the switch statment checking
> the scan type passed by the caller to iwl_mvm_check_running_scans
> for the switch case IWL_MVM_SCAN_SCHED to return directly after
> the call to iwl_mvm_scan_stop in order
31 matches
Mail list logo
